gofmt72%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• cmd/ck-client/protector.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-client/protector_android.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-server/pprof.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-server/pprof_debug.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/multiplex/frameSorter_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-client/admin.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-client/log_android.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-client/admin_android.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-client/ck-client.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/ck-client/log.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• internal/server/usermanager/controller.go
  • Line 49: warning: cyclomatic complexity 29 of function (*controller).HandleRequest() is high (> 15) (gocyclo)

• cmd/ck-server/ck-server.go
  • Line 43: warning: cyclomatic complexity 25 of function dispatchConnection() is high (> 15) (gocyclo)
  • Line 187: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• cmd/ck-client/ck-client.go
  • Line 123: warning: cyclomatic complexity 20 of function main() is high (> 15) (gocyclo)

• cmd/ck-client/admin.go
  • Line 120: warning: cyclomatic complexity 17 of function (*administrator).getRequest() is high (> 15) (gocyclo)

golint36%

Golint is a linter for Go source code.

• cmd/ck-server/ck-server.go
  • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 166: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/server/auth.go
  • Line 35: warning: exported function TouchStone should have comment or be unexported (golint)

• internal/server/state.go
  • Line 41: warning: exported function InitState should have comment or be unexported (golint)

• internal/server/usermanager/controller.go
  • Line 43: warning: exported method Userpanel.MakeController should have comment or be unexported (golint)
  • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 168: warning: exported var ErrInvalidMac should have comment or be unexported (golint)

• internal/multiplex/frame.go
  • Line 3: warning: exported type Frame should have comment or be unexported (golint)

• internal/multiplex/session.go
  • Line 16: warning: exported var ErrBrokenSession should have comment or be unexported (golint)
  • Line 19: warning: exported type Session should have comment or be unexported (golint)
  • Line 46: warning: exported function MakeSession should have comment or be unexported (golint)
  • Line 62: warning: exported method Session.AddConnection should have comment or be unexported (golint)
  • Line 66: warning: exported method Session.OpenStream should have comment or be unexported (golint)
  • Line 82: warning: exported method Session.AcceptStream should have comment or be unexported (golint)
  • Line 110: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 127: warning: exported method Session.Close should have comment or be unexported (golint)
  • Line 147: warning: exported method Session.IsBroken should have comment or be unexported (golint)

• internal/ecdh/curve25519.go
  • Line 38: warning: exported function GenerateKey should have comment or be unexported (golint)
  • Line 56: warning: exported function Marshal should have comment or be unexported (golint)
  • Line 61: warning: exported function Unmarshal should have comment or be unexported (golint)
  • Line 71: warning: exported function GenerateSharedSecret should have comment or be unexported (golint)

• internal/multiplex/frameSorter_test.go
  • Line 39: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
  • Line 43: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)

• internal/multiplex/switchboard.go
  • Line 26: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 53: warning: exported var ErrNoRxCredit should have comment or be unexported (golint)
  • Line 54: warning: exported var ErrNoTxCredit should have comment or be unexported (golint)

• cmd/ck-client/admin.go
  • Line 26: warning: exported type UserInfo should have comment or be unexported (golint)
  • Line 259: warning: exported var ErrInvalidMac should have comment or be unexported (golint)

• internal/util/util.go
  • Line 14: warning: exported function AESEncrypt should have comment or be unexported (golint)
  • Line 22: warning: exported function AESDecrypt should have comment or be unexported (golint)

• internal/client/TLS/chrome.go
  • Line 3: warning: don't use MixedCaps in package name; TLS should be tls (golint)

• internal/client/TLS/firefox.go
  • Line 1: warning: package comment should be of the form "Package TLS ..." (golint)
  • Line 2: warning: don't use MixedCaps in package name; TLS should be tls (golint)

• internal/server/usermanager/user.go
  • Line 13: warning: comment on exported type UserInfo should be of the form "UserInfo ..." (with optional leading article) (golint)
  • Line 25: warning: exported type User should have comment or be unexported (golint)
  • Line 38: warning: exported function MakeUser should have comment or be unexported (golint)
  • Line 69: warning: exported method User.DelSession should have comment or be unexported (golint)
  • Line 80: warning: exported method User.GetSession should have comment or be unexported (golint)
  • Line 88: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/multiplex/frameSorter.go
  • Line 80: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/client/TLS/TLS.go
  • Line 1: warning: don't use MixedCaps in package name; TLS should be tls (golint)

• internal/client/state.go
  • Line 45: warning: exported function InitState should have comment or be unexported (golint)
  • Line 57: warning: exported method State.SetSessionID should have comment or be unexported (golint)

• internal/server/usermanager/userpanel.go
  • Line 15: warning: exported var Uint32 should have comment or be unexported (golint)
  • Line 16: warning: exported var Uint64 should have comment or be unexported (golint)
  • Line 17: warning: exported var PutUint16 should have comment or be unexported (golint)
  • Line 18: warning: exported var PutUint32 should have comment or be unexported (golint)
  • Line 19: warning: exported var PutUint64 should have comment or be unexported (golint)
  • Line 21: warning: exported type Userpanel should have comment or be unexported (golint)
  • Line 29: warning: exported function MakeUserpanel should have comment or be unexported (golint)
  • Line 99: warning: exported var ErrUserNotFound should have comment or be unexported (golint)
  • Line 100: warning: exported var ErrUserNotActive should have comment or be unexported (golint)
  • Line 102: warning: exported method Userpanel.GetAndActivateAdminUser should have comment or be unexported (golint)
  • Line 127: warning: comment on exported method Userpanel.GetAndActivateUser should be of the form "GetAndActivateUser ..." (golint)

• internal/multiplex/obfs.go
  • Line 11: warning: exported type Obfser should have comment or be unexported (golint)
  • Line 12: warning: exported type Deobfser should have comment or be unexported (golint)
  • Line 26: warning: exported function MakeObfs should have comment or be unexported (golint)
  • Line 51: warning: exported function MakeDeobfs should have comment or be unexported (golint)

• internal/multiplex/qos.go
  • Line 24: warning: exported function MakeValve should have comment or be unexported (golint)
  • Line 34: warning: exported method Valve.SetRxRate should have comment or be unexported (golint)
  • Line 35: warning: exported method Valve.SetTxRate should have comment or be unexported (golint)
  • Line 38: warning: exported method Valve.SetRxCredit should have comment or be unexported (golint)
  • Line 39: warning: exported method Valve.SetTxCredit should have comment or be unexported (golint)
  • Line 40: warning: exported method Valve.GetRxCredit should have comment or be unexported (golint)
  • Line 41: warning: exported method Valve.GetTxCredit should have comment or be unexported (golint)
  • Line 43: warning: comment on exported method Valve.AddRxCredit should be of the form "AddRxCredit ..." (golint)
  • Line 46: warning: comment on exported method Valve.AddTxCredit should be of the form "AddTxCredit ..." (golint)

• internal/multiplex/stream.go
  • Line 12: warning: exported var ErrBrokenStream should have comment or be unexported (golint)
  • Line 14: warning: exported type Stream should have comment or be unexported (golint)
  • Line 119: warning: comment on exported method Stream.Close should be of the form "Close ..." (golint)

• cmd/ck-client/log.go
  • Line 5: warning: don't use underscores in Go names; func log_init should be logInit (golint)

• internal/client/auth.go
  • Line 19: warning: exported function MakeRandomField should have comment or be unexported (golint)
  • Line 36: warning: exported function MakeSessionTicket should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign86%

IneffAssign detects ineffectual assignments in Go code.

• cmd/ck-client/admin.go
  • Line 103: warning: ineffectual assignment to err (ineffassign)
  • Line 115: warning: ineffectual assignment to err (ineffassign)

• cmd/ck-client/ck-client.go
  • Line 35: warning: ineffectual assignment to i (ineffassign)

• internal/server/TLS.go
  • Line 160: warning: ineffectual assignment to finished (ineffassign)
  • Line 160: warning: ineffectual assignment to finished (ineffassign)

• internal/util/util.go
  • Line 45: warning: ineffectual assignment to i (ineffassign)

• cmd/ck-server/ck-server.go
  • Line 34: warning: ineffectual assignment to i (ineffassign)

misspell88%

Misspell Finds commonly misspelled English words

• cmd/ck-server/ck-server.go
  • Line 210: warning: "seperated" is a misspelling of "separated" (misspell)

• internal/multiplex/qos.go
  • Line 12: warning: "refered" is a misspelling of "referred" (misspell)

• internal/multiplex/session.go
  • Line 104: warning: "negligable" is a misspelling of "negligible" (misspell)

• cmd/ck-client/ck-client.go
  • Line 89: warning: "Attemtping" is a misspelling of "Attempting" (misspell)
  • Line 150: warning: "seperated" is a misspelling of "separated" (misspell)