Preparing report...

Report for github.com/cisco/arc

A+    Excellent!    Found 125 issues across 252 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • arc/pkg/aws/secrules.go
    • Line 202: warning: cyclomatic complexity 21 of function (*securityRules).compareEqual() is high (> 15) (gocyclo)
    • Line 56: warning: cyclomatic complexity 19 of function (*securityRules).populate() is high (> 15) (gocyclo)

golint58%

Golint is a linter for Go source code.

    • arc/pkg/arc/instance_replace.go
    • Line 55: warning: exported method Instance.PreReplace should have comment or be unexported (golint)
    • Line 59: warning: exported method Instance.Replace should have comment or be unexported (golint)
    • Line 94: warning: exported method Instance.PostReplace should have comment or be unexported (golint)
    • arc/pkg/config/arc.go
    • Line 38: warning: comment on exported type Arc should be of the form "Arc ..." (with optional leading article) (golint)
    • Line 41: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 42: warning: don't use underscores in Go names; struct field Title_ should be Title (golint)
    • Line 51: warning: exported function NewArc should have comment or be unexported (golint)
    • arc/pkg/route/command.go
    • Line 29: warning: exported type Command should have comment or be unexported (golint)
    • Line 32: warning: exported const None should have comment (or a comment on this block) or be unexported (golint)
    • arc/pkg/config/policy.go
    • Line 31: warning: exported type Policy should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 33: warning: don't use underscores in Go names; struct field Description_ should be Description (golint)
    • Line 34: warning: don't use underscores in Go names; struct field PolicyDocument_ should be PolicyDocument (golint)
    • Line 37: warning: exported method Policy.Name should have comment or be unexported (golint)
    • Line 41: warning: exported method Policy.Description should have comment or be unexported (golint)
    • Line 45: warning: exported method Policy.PolicyDocument should have comment or be unexported (golint)
    • Line 49: warning: exported method Policy.Print should have comment or be unexported (golint)
    • arc/pkg/config/security_group.go
    • Line 44: warning: comment on exported type SecurityGroup should be of the form "SecurityGroup ..." (with optional leading article) (golint)
    • Line 47: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • arc/pkg/config/storage.go
    • Line 31: warning: exported type Storage should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field EncryptionKey_ should be EncryptionKey (golint)
    • Line 37: warning: exported method Storage.EncryptionKey should have comment or be unexported (golint)
    • arc/pkg/aws/route_table.go
    • Line 46: warning: don't use underscores in Go names; struct field name_ should be name (golint)
    • Line 47: warning: don't use underscores in Go names; struct field access_ should be access (golint)
    • Line 48: warning: don't use underscores in Go names; struct field availabilityZone_ should be availabilityZone (golint)
    • Line 51: warning: don't use underscores in Go names; struct field id_ should be id (golint)
    • arc/pkg/resource/bucket.go
    • Line 34: warning: exported type StaticBucket should have comment or be unexported (golint)
    • Line 66: warning: exported type ProviderBucket should have comment or be unexported (golint)
    • arc/pkg/resource/key_management.go
    • Line 34: warning: exported type StaticKeyManagement should have comment or be unexported (golint)
    • Line 39: warning: exported type DynamicKeyManagement should have comment or be unexported (golint)
    • Line 47: warning: exported type KeyManagement should have comment or be unexported (golint)
    • Line 65: warning: exported type ProviderKeyManagement should have comment or be unexported (golint)
    • arc/pkg/config/encryption_key.go
    • Line 31: warning: exported type EncryptionKey should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 33: warning: don't use underscores in Go names; struct field Region_ should be Region (golint)
    • Line 34: warning: don't use underscores in Go names; struct field DeletionPendingWindow_ should be DeletionPendingWindow (golint)
    • Line 35: warning: don't use underscores in Go names; struct field SecurityTags_ should be SecurityTags (golint)
    • Line 38: warning: exported method EncryptionKey.Name should have comment or be unexported (golint)
    • Line 42: warning: exported method EncryptionKey.Region should have comment or be unexported (golint)
    • Line 46: warning: exported method EncryptionKey.DeletionPendingWindow should have comment or be unexported (golint)
    • Line 50: warning: exported method EncryptionKey.SecurityTags should have comment or be unexported (golint)
    • Line 54: warning: exported method EncryptionKey.Print should have comment or be unexported (golint)
    • arc/pkg/config/key_management.go
    • Line 31: warning: exported type KeyManagement should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field Region_ should be Region (golint)
    • Line 36: warning: exported method KeyManagement.Region should have comment or be unexported (golint)
    • Line 40: warning: exported method KeyManagement.Print should have comment or be unexported (golint)
    • arc/pkg/env/env.go
    • Line 49: warning: exported function Init should have comment or be unexported (golint)
    • Line 120: warning: exported function Lookup should have comment or be unexported (golint)
    • Line 124: warning: exported function Set should have comment or be unexported (golint)
    • arc/pkg/config/compute.go
    • Line 31: warning: comment on exported type Compute should be of the form "Compute ..." (with optional leading article) (golint)
    • Line 38: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 39: warning: don't use underscores in Go names; struct field BootstrapVersion_ should be BootstrapVersion (golint)
    • Line 40: warning: don't use underscores in Go names; struct field DeployVersion_ should be DeployVersion (golint)
    • Line 41: warning: don't use underscores in Go names; struct field SecretsVersion_ should be SecretsVersion (golint)
    • Line 42: warning: don't use underscores in Go names; struct field AideVersion_ should be AideVersion (golint)
    • arc/pkg/config/dns_record.go
    • Line 50: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 51: warning: don't use underscores in Go names; struct field Ttl_ should be TTL (golint)
    • Line 52: warning: don't use underscores in Go names; struct field Pod_ should be Pod (golint)
    • Line 53: warning: don't use underscores in Go names; struct field Access_ should be Access (golint)
    • Line 54: warning: don't use underscores in Go names; struct field Values_ should be Values (golint)
    • arc/pkg/aws/vpc.go
    • Line 45: warning: don't use underscores in Go names; struct field name_ should be name (golint)
    • Line 48: warning: don't use underscores in Go names; struct field id_ should be id (golint)
    • arc/pkg/amp/amp.go
    • Line 52: warning: exported function New should have comment or be unexported (golint)
    • Line 200: warning: exported function Help should have comment or be unexported (golint)
    • arc/pkg/arc/instance_audit.go
    • Line 29: warning: exported method Instance.Audit should have comment or be unexported (golint)
    • Line 45: warning: exported method Instance.PreAudit should have comment or be unexported (golint)
    • Line 49: warning: exported method Instance.MidAudit should have comment or be unexported (golint)
    • Line 62: warning: exported method Instance.PostAudit should have comment or be unexported (golint)
    • arc/pkg/arc/instance_paging.go
    • Line 36: warning: exported method Instance.StartPaging should have comment or be unexported (golint)
    • Line 49: warning: exported method Instance.StopPaging should have comment or be unexported (golint)
    • arc/pkg/route/response.go
    • Line 29: warning: exported type Response should have comment or be unexported (golint)
    • Line 32: warning: exported const OK should have comment (or a comment on this block) or be unexported (golint)
    • arc/pkg/config/network.go
    • Line 31: warning: comment on exported type Network should be of the form "Network ..." (with optional leading article) (golint)
    • Line 39: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 40: warning: don't use underscores in Go names; struct field CidrBlock_ should be CidrBlock (golint)
    • Line 41: warning: don't use underscores in Go names; struct field AvailabilityZones_ should be AvailabilityZones (golint)
    • Line 42: warning: don't use underscores in Go names; struct field DnsNameServers_ should be DNSNameServers (golint)
    • Line 43: warning: don't use underscores in Go names; struct field CidrAliases_ should be CidrAliases (golint)
    • Line 44: warning: don't use underscores in Go names; struct field CidrGroups_ should be CidrGroups (golint)
    • arc/pkg/spark/client.go
    • Line 49: warning: exported type Client should have comment or be unexported (golint)
    • Line 58: warning: exported const Text should have comment (or a comment on this block) or be unexported (golint)
    • Line 63: warning: exported function New should have comment or be unexported (golint)
    • Line 85: warning: exported method Client.Get should have comment or be unexported (golint)
    • arc/pkg/arc/instance_provision.go
    • Line 109: warning: exported method Instance.UserUpdate should have comment or be unexported (golint)
    • Line 128: warning: exported method Instance.PreProvision should have comment or be unexported (golint)
    • Line 152: warning: exported method Instance.Provision should have comment or be unexported (golint)
    • Line 186: warning: exported method Instance.PostProvision should have comment or be unexported (golint)
    • arc/pkg/mock/mock.go
    • Line 51: warning: exported function Get should have comment or be unexported (golint)
    • Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 120: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • arc/pkg/resource/bucket_set.go
    • Line 34: warning: exported type StaticBucketSet should have comment or be unexported (golint)
    • Line 40: warning: comment on exported type DynamicBucketSet should be of the form "DynamicBucketSet ..." (with optional leading article) (golint)
    • Line 50: warning: comment on exported type BucketSet should be of the form "BucketSet ..." (with optional leading article) (golint)
    • arc/pkg/arc/pod.go
    • Line 43: warning: exported type PodFactory should have comment or be unexported (golint)
    • Line 47: warning: exported function RegisterPodFactory should have comment or be unexported (golint)
    • Line 55: warning: exported type Pod should have comment or be unexported (golint)
    • Line 62: warning: don't use underscores in Go names; struct field derived_ should be derived (golint)
    • Line 76: warning: comment on exported function NewDefaultPod should be of the form "NewDefaultPod ..." (golint)
    • Line 126: warning: comment on exported method Pod.DnsCNameRecords should be of the form "DnsCNameRecords ..." (golint)
    • Line 148: warning: exported method Pod.PrimaryCname should have comment or be unexported (golint)
    • Line 211: warning: exported method Pod.Derived should have comment or be unexported (golint)
    • Line 215: warning: exported method Pod.SetDerived should have comment or be unexported (golint)
    • Line 408: warning: exported method Pod.PreCreate should have comment or be unexported (golint)
    • Line 412: warning: exported method Pod.Create should have comment or be unexported (golint)
    • Line 416: warning: exported method Pod.PostCreate should have comment or be unexported (golint)
    • Line 451: warning: exported method Pod.PreDestroy should have comment or be unexported (golint)
    • Line 464: warning: exported method Pod.Destroy should have comment or be unexported (golint)
    • Line 468: warning: exported method Pod.PostDestroy should have comment or be unexported (golint)
    • Line 494: warning: exported method Pod.PreProvision should have comment or be unexported (golint)
    • Line 498: warning: exported method Pod.Provision should have comment or be unexported (golint)
    • Line 502: warning: exported method Pod.PostProvision should have comment or be unexported (golint)
    • Line 528: warning: exported method Pod.PreStart should have comment or be unexported (golint)
    • Line 532: warning: exported method Pod.Start should have comment or be unexported (golint)
    • Line 536: warning: exported method Pod.PostStart should have comment or be unexported (golint)
    • Line 562: warning: exported method Pod.PreStop should have comment or be unexported (golint)
    • Line 566: warning: exported method Pod.Stop should have comment or be unexported (golint)
    • Line 570: warning: exported method Pod.PostStop should have comment or be unexported (golint)
    • Line 596: warning: exported method Pod.PreRestart should have comment or be unexported (golint)
    • Line 600: warning: exported method Pod.Restart should have comment or be unexported (golint)
    • Line 604: warning: exported method Pod.PostRestart should have comment or be unexported (golint)
    • Line 630: warning: exported method Pod.PreReplace should have comment or be unexported (golint)
    • Line 634: warning: exported method Pod.Replace should have comment or be unexported (golint)
    • Line 638: warning: exported method Pod.PostReplace should have comment or be unexported (golint)
    • Line 644: warning: exported method Pod.Audit should have comment or be unexported (golint)
    • Line 657: warning: exported method Pod.PreAudit should have comment or be unexported (golint)
    • Line 661: warning: exported method Pod.MidAudit should have comment or be unexported (golint)
    • Line 665: warning: exported method Pod.PostAudit should have comment or be unexported (golint)
    • arc/pkg/config/bucket_set.go
    • Line 31: warning: exported type BucketSets should have comment or be unexported (golint)
    • Line 33: warning: exported type BucketSet should have comment or be unexported (golint)
    • Line 34: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 35: warning: don't use underscores in Go names; struct field Buckets_ should be Buckets (golint)
    • Line 38: warning: exported method BucketSet.Name should have comment or be unexported (golint)
    • Line 42: warning: exported method BucketSet.Buckets should have comment or be unexported (golint)
    • Line 46: warning: exported method BucketSet.PrintLocal should have comment or be unexported (golint)
    • Line 51: warning: exported method BucketSet.Print should have comment or be unexported (golint)
    • arc/pkg/config/subnet_group.go
    • Line 44: warning: comment on exported type SubnetGroup should be of the form "SubnetGroup ..." (with optional leading article) (golint)
    • Line 48: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 49: warning: don't use underscores in Go names; struct field CidrBlock_ should be CidrBlock (golint)
    • Line 50: warning: don't use underscores in Go names; struct field CidrBlocks_ should be CidrBlocks (golint)
    • Line 51: warning: don't use underscores in Go names; struct field Access_ should be Access (golint)
    • Line 52: warning: don't use underscores in Go names; struct field ManageRoutes_ should be ManageRoutes (golint)
    • Line 117: warning: exported type CidrBlock should have comment or be unexported (golint)
    • Line 118: warning: don't use underscores in Go names; struct field Cidr_ should be Cidr (golint)
    • Line 119: warning: don't use underscores in Go names; struct field AvailibilityZone_ should be AvailibilityZone (golint)
    • Line 122: warning: exported method CidrBlock.Cidr should have comment or be unexported (golint)
    • Line 126: warning: exported method CidrBlock.AvailibilityZone should have comment or be unexported (golint)
    • arc/pkg/resource/identity_management.go
    • Line 34: warning: exported type StaticIdentityManagement should have comment or be unexported (golint)
    • Line 38: warning: exported type DynamicIdentityManagement should have comment or be unexported (golint)
    • Line 46: warning: exported type IdentityManagement should have comment or be unexported (golint)
    • Line 67: warning: exported type ProviderIdentityManagement should have comment or be unexported (golint)
    • arc/pkg/arc/instance_restart.go
    • Line 61: warning: exported method Instance.PreStart should have comment or be unexported (golint)
    • Line 65: warning: exported method Instance.Start should have comment or be unexported (golint)
    • Line 69: warning: exported method Instance.PostStart should have comment or be unexported (golint)
    • Line 110: warning: exported method Instance.PreStop should have comment or be unexported (golint)
    • Line 120: warning: exported method Instance.Stop should have comment or be unexported (golint)
    • Line 142: warning: exported method Instance.PostStop should have comment or be unexported (golint)
    • Line 189: warning: exported method Instance.PreRestart should have comment or be unexported (golint)
    • Line 194: warning: exported method Instance.Restart should have comment or be unexported (golint)
    • Line 205: warning: exported method Instance.PostRestart should have comment or be unexported (golint)
    • arc/pkg/config/amp.go
    • Line 39: warning: exported type Amp should have comment or be unexported (golint)
    • Line 40: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 43: warning: don't use underscores in Go names; struct field SecurityTags_ should be SecurityTags (golint)
    • Line 49: warning: exported function NewAmp should have comment or be unexported (golint)
    • Line 63: warning: exported method Amp.Name should have comment or be unexported (golint)
    • Line 67: warning: exported method Amp.SecurityTags should have comment or be unexported (golint)
    • Line 71: warning: exported method Amp.PrintLocal should have comment or be unexported (golint)
    • Line 81: warning: exported method Amp.Print should have comment or be unexported (golint)
    • arc/pkg/config/database.go
    • Line 33: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 34: warning: don't use underscores in Go names; struct field DBName_ should be DBName (golint)
    • Line 35: warning: don't use underscores in Go names; struct field Engine_ should be Engine (golint)
    • Line 36: warning: don't use underscores in Go names; struct field Version_ should be Version (golint)
    • Line 37: warning: don't use underscores in Go names; struct field Type_ should be Type (golint)
    • Line 38: warning: don't use underscores in Go names; struct field Port_ should be Port (golint)
    • Line 39: warning: don't use underscores in Go names; struct field SubnetGroup_ should be SubnetGroup (golint)
    • Line 40: warning: don't use underscores in Go names; struct field SecurityGroups_ should be SecurityGroups (golint)
    • Line 41: warning: don't use underscores in Go names; struct field Storage_ should be Storage (golint)
    • Line 42: warning: don't use underscores in Go names; struct field Type_ should be Type (golint)
    • Line 43: warning: don't use underscores in Go names; struct field Size_ should be Size (golint)
    • Line 44: warning: don't use underscores in Go names; struct field Iops_ should be Iops (golint)
    • Line 46: warning: don't use underscores in Go names; struct field Master_ should be Master (golint)
    • Line 47: warning: don't use underscores in Go names; struct field UserName_ should be UserName (golint)
    • Line 48: warning: don't use underscores in Go names; struct field Password_ should be Password (golint)
    • Line 52: warning: exported method Database.Name should have comment or be unexported (golint)
    • Line 56: warning: exported method Database.DBName should have comment or be unexported (golint)
    • Line 60: warning: exported method Database.Engine should have comment or be unexported (golint)
    • Line 64: warning: exported method Database.Version should have comment or be unexported (golint)
    • Line 68: warning: exported method Database.InstanceType should have comment or be unexported (golint)
    • Line 72: warning: exported method Database.Port should have comment or be unexported (golint)
    • Line 76: warning: exported method Database.SubnetGroup should have comment or be unexported (golint)
    • Line 80: warning: exported method Database.SecurityGroups should have comment or be unexported (golint)
    • Line 84: warning: exported method Database.StorageType should have comment or be unexported (golint)
    • Line 88: warning: exported method Database.StorageSize should have comment or be unexported (golint)
    • Line 92: warning: exported method Database.StorageIops should have comment or be unexported (golint)
    • Line 96: warning: exported method Database.MasterUserName should have comment or be unexported (golint)
    • Line 100: warning: exported method Database.MasterPassword should have comment or be unexported (golint)
    • arc/pkg/config/keypair.go
    • Line 31: warning: comment on exported type KeyPair should be of the form "KeyPair ..." (with optional leading article) (golint)
    • Line 37: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 38: warning: don't use underscores in Go names; struct field LocalName_ should be LocalName (golint)
    • Line 39: warning: don't use underscores in Go names; struct field Format_ should be Format (golint)
    • Line 40: warning: don't use underscores in Go names; struct field Comment_ should be Comment (golint)
    • Line 41: warning: don't use underscores in Go names; struct field KeyMaterial_ should be KeyMaterial (golint)
    • arc/pkg/arc/instance_create.go
    • Line 55: warning: exported method Instance.PreCreate should have comment or be unexported (golint)
    • Line 59: warning: exported method Instance.Create should have comment or be unexported (golint)
    • Line 123: warning: exported method Instance.PostCreate should have comment or be unexported (golint)
    • arc/pkg/arc/instance_destroy.go
    • Line 58: warning: exported method Instance.PreDestroy should have comment or be unexported (golint)
    • Line 71: warning: exported method Instance.Destroy should have comment or be unexported (golint)
    • Line 136: warning: exported method Instance.PostDestroy should have comment or be unexported (golint)
    • arc/pkg/aaa/audit.go
    • Line 40: warning: exported type Audit should have comment or be unexported (golint)
    • Line 53: warning: exported const Deployed should have comment (or a comment on this block) or be unexported (golint)
    • Line 59: warning: exported var AuditBuffer should have comment or be unexported (golint)
    • Line 65: warning: exported function NewAuditWithOptions should have comment or be unexported (golint)
    • Line 83: warning: exported function NewAudit should have comment or be unexported (golint)
    • Line 87: warning: exported method Audit.PreAudit should have comment or be unexported (golint)
    • Line 107: warning: exported method Audit.Audit should have comment or be unexported (golint)
    • Line 123: warning: exported method Audit.FreeFormAudit should have comment or be unexported (golint)
    • Line 199: warning: exported function PostAudit should have comment or be unexported (golint)
    • arc/pkg/resource/storage.go
    • Line 34: warning: exported type StaticStorage should have comment or be unexported (golint)
    • Line 38: warning: exported type DynamicStorage should have comment or be unexported (golint)
    • Line 46: warning: exported type Storage should have comment or be unexported (golint)
    • Line 67: warning: exported type ProviderStorage should have comment or be unexported (golint)
    • arc/pkg/secrets/secrets.go
    • Line 33: warning: exported function InstallCerts should have comment or be unexported (golint)
    • Line 37: warning: exported function InstallMachineUser should have comment or be unexported (golint)
    • arc/pkg/resource/network.go
    • Line 46: warning: comment on exported type DynamicNetwork should be of the form "DynamicNetwork ..." (with optional leading article) (golint)
    • Line 106: warning: exported type NetworkPost should have comment or be unexported (golint)
    • Line 112: warning: exported type ProviderNetworkPost should have comment or be unexported (golint)
    • arc/pkg/users/teams.go
    • Line 78: warning: exported method Team.FindUser should have comment or be unexported (golint)
    • Line 87: warning: exported method Team.FindTeam should have comment or be unexported (golint)
    • Line 96: warning: exported method Team.Populate should have comment or be unexported (golint)
    • arc/pkg/config/bucket.go
    • Line 31: warning: exported type Bucket should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 33: warning: don't use underscores in Go names; struct field Region_ should be Region (golint)
    • Line 34: warning: don't use underscores in Go names; struct field EncryptionKey_ should be EncryptionKey (golint)
    • Line 35: warning: don't use underscores in Go names; struct field Role_ should be Role (golint)
    • Line 36: warning: don't use underscores in Go names; struct field Destination_ should be Destination (golint)
    • Line 37: warning: don't use underscores in Go names; struct field DestinationEncryptionKey_ should be DestinationEncryptionKey (golint)
    • Line 38: warning: don't use underscores in Go names; struct field SecurityTags_ should be SecurityTags (golint)
    • Line 41: warning: exported method Bucket.Name should have comment or be unexported (golint)
    • Line 45: warning: exported method Bucket.Region should have comment or be unexported (golint)
    • Line 49: warning: exported method Bucket.EncryptionKey should have comment or be unexported (golint)
    • Line 53: warning: exported method Bucket.SecurityTags should have comment or be unexported (golint)
    • Line 57: warning: exported method Bucket.Role should have comment or be unexported (golint)
    • Line 61: warning: exported method Bucket.Destination should have comment or be unexported (golint)
    • Line 65: warning: exported method Bucket.DestinationEncryptionKey should have comment or be unexported (golint)
    • Line 69: warning: exported method Bucket.Print should have comment or be unexported (golint)
    • arc/pkg/resource/policy.go
    • Line 34: warning: exported type StaticPolicy should have comment or be unexported (golint)
    • Line 66: warning: exported type ProviderPolicy should have comment or be unexported (golint)
    • arc/cmd/spark/spark.go
    • Line 39: warning: exported type Spark should have comment or be unexported (golint)
    • Line 44: warning: comment on exported function NewSpark should be of the form "NewSpark ..." (golint)
    • arc/pkg/resource/role.go
    • Line 34: warning: exported type StaticRole should have comment or be unexported (golint)
    • Line 66: warning: exported type ProviderRole should have comment or be unexported (golint)
    • arc/pkg/route/path.go
    • Line 29: warning: exported type Path should have comment or be unexported (golint)
    • Line 33: warning: exported function NewPath should have comment or be unexported (golint)
    • Line 39: warning: exported method Path.Top should have comment or be unexported (golint)
    • Line 47: warning: exported method Path.Pop should have comment or be unexported (golint)
    • Line 54: warning: exported method Path.Push should have comment or be unexported (golint)
    • Line 59: warning: exported method Path.Append should have comment or be unexported (golint)
    • arc/pkg/aaa/accounting.go
    • Line 40: warning: exported function PreAccounting should have comment or be unexported (golint)
    • Line 58: warning: exported function Accounting should have comment or be unexported (golint)
    • Line 78: warning: exported function PostAccounting should have comment or be unexported (golint)
    • arc/pkg/resource/encryption_key.go
    • Line 31: warning: exported type StaticEncryptionKey should have comment or be unexported (golint)
    • Line 48: warning: comment on exported type EncryptionKey should be of the form "EncryptionKey ..." (with optional leading article) (golint)
    • Line 64: warning: exported type ProviderEncryptionKey should have comment or be unexported (golint)
    • arc/pkg/users/init.go
    • Line 37: warning: exported var Users should have comment or be unexported (golint)
    • Line 38: warning: exported var Groups should have comment or be unexported (golint)
    • Line 39: warning: exported var Teams should have comment or be unexported (golint)
    • Line 40: warning: exported var DataCenters should have comment or be unexported (golint)
    • Line 42: warning: exported function Init should have comment or be unexported (golint)
    • arc/pkg/config/cluster.go
    • Line 44: warning: comment on exported type Cluster should be of the form "Cluster ..." (with optional leading article) (golint)
    • Line 47: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 49: warning: don't use underscores in Go names; struct field SecurityTags_ should be SecurityTags (golint)
    • Line 50: warning: don't use underscores in Go names; struct field AuditIgnore_ should be AuditIgnore (golint)
    • Line 58: warning: exported method Cluster.SecurityTags should have comment or be unexported (golint)
    • Line 62: warning: exported method Cluster.AuditIgnore should have comment or be unexported (golint)
    • arc/pkg/config/container_service.go
    • Line 31: warning: comment on exported type ContainerService should be of the form "ContainerService ..." (with optional leading article) (golint)
    • Line 34: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • arc/pkg/help/print.go
    • Line 35: warning: exported function Init should have comment or be unexported (golint)
    • Line 44: warning: exported type Resource should have comment or be unexported (golint)
    • Line 49: warning: exported type Command should have comment or be unexported (golint)
    • Line 54: warning: exported function Print should have comment or be unexported (golint)
    • Line 64: warning: exported function Append should have comment or be unexported (golint)
    • arc/cmd/audit/audit.go
    • Line 37: warning: exported type Audit should have comment or be unexported (golint)
    • Line 43: warning: exported function NewAudit should have comment or be unexported (golint)
    • Line 47: warning: exported method Audit.Run should have comment or be unexported (golint)
    • Line 100: warning: exported function Help should have comment or be unexported (golint)
    • arc/pkg/msg/msg.go
    • Line 60: warning: exported function Quiet should have comment or be unexported (golint)
    • Line 64: warning: exported function GetQuiet should have comment or be unexported (golint)
    • Line 68: warning: exported function Error should have comment or be unexported (golint)
    • Line 79: warning: exported function Warn should have comment or be unexported (golint)
    • Line 87: warning: exported function Heading should have comment or be unexported (golint)
    • Line 95: warning: exported function Info should have comment or be unexported (golint)
    • Line 103: warning: exported function Detail should have comment or be unexported (golint)
    • Line 111: warning: exported function Raw should have comment or be unexported (golint)
    • Line 118: warning: exported function Indent should have comment or be unexported (golint)
    • Line 122: warning: exported function Tab should have comment or be unexported (golint)
    • Line 126: warning: exported function IndentInc should have comment or be unexported (golint)
    • Line 130: warning: exported function IndentDec should have comment or be unexported (golint)
    • Line 137: warning: exported function LastError should have comment or be unexported (golint)
    • arc/pkg/config/security_rule.go
    • Line 44: warning: comment on exported type SecurityRule should be of the form "SecurityRule ..." (with optional leading article) (golint)
    • Line 49: warning: don't use underscores in Go names; struct field Description_ should be Description (golint)
    • Line 50: warning: don't use underscores in Go names; struct field Directions_ should be Directions (golint)
    • Line 51: warning: don't use underscores in Go names; struct field Remotes_ should be Remotes (golint)
    • Line 52: warning: don't use underscores in Go names; struct field Protocols_ should be Protocols (golint)
    • Line 53: warning: don't use underscores in Go names; struct field Ports_ should be Ports (golint)
    • Line 56: warning: comment on exported method SecurityRule.Description should be of the form "Description ..." (golint)
    • Line 70: warning: comment on exported method SecurityRule.Directions should be of the form "Directions ..." (golint)
    • Line 77: warning: comment on exported method SecurityRule.Protocols should be of the form "Protocols ..." (golint)
    • Line 82: warning: comment on exported method SecurityRule.Ports should be of the form "Ports ..." (golint)
    • arc/pkg/config/instance.go
    • Line 44: warning: comment on exported type Instance should be of the form "Instance ..." (with optional leading article) (golint)
    • Line 114: warning: exported method Instance.Volumes should have comment or be unexported (golint)
    • arc/pkg/log/log.go
    • Line 61: warning: exported function Init should have comment or be unexported (golint)
    • Line 99: warning: exported function Fini should have comment or be unexported (golint)
    • Line 107: warning: exported function Verbose should have comment or be unexported (golint)
    • Line 113: warning: exported function Debug should have comment or be unexported (golint)
    • Line 119: warning: exported function Info should have comment or be unexported (golint)
    • Line 125: warning: exported function Warn should have comment or be unexported (golint)
    • Line 131: warning: exported function Error should have comment or be unexported (golint)
    • Line 154: warning: exported function Route should have comment or be unexported (golint)
    • arc/pkg/arc/instance.go
    • Line 43: warning: exported type InstanceFactory should have comment or be unexported (golint)
    • Line 50: warning: exported function RegisterInstanceFactory should have comment or be unexported (golint)
    • Line 58: warning: exported type Instance should have comment or be unexported (golint)
    • Line 72: warning: don't use underscores in Go names; struct field derived_ should be derived (golint)
    • Line 89: warning: comment on exported function NewDefaultInstance should be of the form "NewDefaultInstance ..." (golint)
    • Line 272: warning: exported method Instance.Id should have comment or be unexported (golint)
    • Line 279: warning: exported method Instance.ImageId should have comment or be unexported (golint)
    • Line 286: warning: exported method Instance.KeyName should have comment or be unexported (golint)
    • Line 293: warning: exported method Instance.State should have comment or be unexported (golint)
    • Line 300: warning: exported method Instance.Started should have comment or be unexported (golint)
    • Line 307: warning: exported method Instance.Stopped should have comment or be unexported (golint)
    • Line 314: warning: exported method Instance.PrivateIPAddress should have comment or be unexported (golint)
    • Line 321: warning: exported method Instance.PublicIPAddress should have comment or be unexported (golint)
    • Line 331: warning: exported method Instance.SetTags should have comment or be unexported (golint)
    • Line 338: warning: exported method Instance.RootUser should have comment or be unexported (golint)
    • Line 350: warning: exported method Instance.ProviderVolumes should have comment or be unexported (golint)
    • Line 359: warning: exported method Instance.ProviderRoleIdentifier should have comment or be unexported (golint)
    • Line 364: warning: exported method Instance.Derived should have comment or be unexported (golint)
    • Line 371: warning: exported method Instance.SetDerived should have comment or be unexported (golint)
    • Line 375: warning: exported method Instance.Route should have comment or be unexported (golint)
    • arc/pkg/config/datacenter.go
    • Line 31: warning: comment on exported type DataCenter should be of the form "DataCenter ..." (with optional leading article) (golint)
    • Line 37: warning: don't use underscores in Go names; struct field SecurityTags_ should be SecurityTags (golint)
    • Line 40: warning: exported method DataCenter.SecurityTags should have comment or be unexported (golint)
    • arc/pkg/config/dns.go
    • Line 34: warning: don't use underscores in Go names; struct field DomainName_ should be DomainName (golint)
    • Line 35: warning: don't use underscores in Go names; struct field Subdomain_ should be Subdomain (golint)
    • Line 48: warning: comment on exported method Dns.Subdomain should be of the form "Subdomain ..." (golint)
    • arc/pkg/config/role.go
    • Line 31: warning: exported type Role should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 33: warning: don't use underscores in Go names; struct field TrustRelationship_ should be TrustRelationship (golint)
    • Line 34: warning: don't use underscores in Go names; struct field InstanceProfile_ should be InstanceProfile (golint)
    • Line 35: warning: don't use underscores in Go names; struct field Description_ should be Description (golint)
    • Line 36: warning: don't use underscores in Go names; struct field Policies_ should be Policies (golint)
    • Line 39: warning: exported method Role.Name should have comment or be unexported (golint)
    • Line 43: warning: exported method Role.TrustRelationship should have comment or be unexported (golint)
    • Line 47: warning: exported method Role.InstanceProfile should have comment or be unexported (golint)
    • Line 51: warning: exported method Role.Description should have comment or be unexported (golint)
    • Line 55: warning: exported method Role.Policies should have comment or be unexported (golint)
    • Line 59: warning: exported method Role.Print should have comment or be unexported (golint)
    • arc/pkg/arc/cluster.go
    • Line 42: warning: exported type ClusterFactory should have comment or be unexported (golint)
    • Line 46: warning: exported function RegisterClusterFactory should have comment or be unexported (golint)
    • Line 54: warning: exported type Cluster should have comment or be unexported (golint)
    • Line 59: warning: don't use underscores in Go names; struct field derived_ should be derived (golint)
    • Line 78: warning: comment on exported function NewDefaultCluster should be of the form "NewDefaultCluster ..." (golint)
    • Line 106: warning: comment on exported method Cluster.FindPod should be of the form "FindPod ..." (golint)
    • Line 124: warning: exported method Cluster.Derived should have comment or be unexported (golint)
    • Line 128: warning: exported method Cluster.SetDerived should have comment or be unexported (golint)
    • Line 271: warning: exported method Cluster.PreCreate should have comment or be unexported (golint)
    • Line 275: warning: exported method Cluster.Create should have comment or be unexported (golint)
    • Line 279: warning: exported method Cluster.PostCreate should have comment or be unexported (golint)
    • Line 305: warning: exported method Cluster.PreDestroy should have comment or be unexported (golint)
    • Line 309: warning: exported method Cluster.Destroy should have comment or be unexported (golint)
    • Line 313: warning: exported method Cluster.PostDestroy should have comment or be unexported (golint)
    • Line 339: warning: exported method Cluster.PreProvision should have comment or be unexported (golint)
    • Line 343: warning: exported method Cluster.Provision should have comment or be unexported (golint)
    • Line 347: warning: exported method Cluster.PostProvision should have comment or be unexported (golint)
    • Line 373: warning: exported method Cluster.PreStart should have comment or be unexported (golint)
    • Line 377: warning: exported method Cluster.Start should have comment or be unexported (golint)
    • Line 381: warning: exported method Cluster.PostStart should have comment or be unexported (golint)
    • Line 407: warning: exported method Cluster.PreStop should have comment or be unexported (golint)
    • Line 411: warning: exported method Cluster.Stop should have comment or be unexported (golint)
    • Line 415: warning: exported method Cluster.PostStop should have comment or be unexported (golint)
    • Line 441: warning: exported method Cluster.PreRestart should have comment or be unexported (golint)
    • Line 445: warning: exported method Cluster.Restart should have comment or be unexported (golint)
    • Line 449: warning: exported method Cluster.PostRestart should have comment or be unexported (golint)
    • Line 475: warning: exported method Cluster.PreReplace should have comment or be unexported (golint)
    • Line 479: warning: exported method Cluster.Replace should have comment or be unexported (golint)
    • Line 483: warning: exported method Cluster.PostReplace should have comment or be unexported (golint)
    • Line 489: warning: exported method Cluster.Audit should have comment or be unexported (golint)
    • Line 502: warning: exported method Cluster.PreAudit should have comment or be unexported (golint)
    • Line 506: warning: exported method Cluster.MidAudit should have comment or be unexported (golint)
    • Line 513: warning: exported method Cluster.PostAudit should have comment or be unexported (golint)
    • arc/pkg/resource/compute.go
    • Line 29: warning: comment on exported type StaticCompute should be of the form "StaticCompute ..." (with optional leading article) (golint)
    • Line 40: warning: comment on exported type DynamicCompute should be of the form "DynamicCompute ..." (with optional leading article) (golint)
    • arc/pkg/resource/dns.go
    • Line 38: warning: comment on exported type DynamicDns should be of the form "DynamicDns ..." (with optional leading article) (golint)
    • arc/pkg/route/flags.go
    • Line 29: warning: exported type Flags should have comment or be unexported (golint)
    • Line 33: warning: exported function NewFlags should have comment or be unexported (golint)
    • Line 39: warning: exported method Flags.Clone should have comment or be unexported (golint)
    • Line 52: warning: exported method Flags.Set should have comment or be unexported (golint)
    • Line 56: warning: exported method Flags.Get should have comment or be unexported (golint)
    • Line 60: warning: exported method Flags.Append should have comment or be unexported (golint)
    • Line 67: warning: exported method Flags.Remove should have comment or be unexported (golint)
    • Line 78: warning: exported method Flags.Empty should have comment or be unexported (golint)
    • arc/pkg/config/identity_management.go
    • Line 31: warning: exported type IdentityManagement should have comment or be unexported (golint)
    • Line 32: warning: don't use underscores in Go names; struct field Region_ should be Region (golint)
    • Line 37: warning: exported method IdentityManagement.Region should have comment or be unexported (golint)
    • arc/pkg/config/pod.go
    • Line 50: warning: comment on exported type Pod should be of the form "Pod ..." (with optional leading article) (golint)
    • Line 55: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 56: warning: don't use underscores in Go names; struct field ServerType_ should be ServerType (golint)
    • Line 57: warning: don't use underscores in Go names; struct field Version_ should be Version (golint)
    • Line 58: warning: don't use underscores in Go names; struct field Image_ should be Image (golint)
    • Line 59: warning: don't use underscores in Go names; struct field InstanceType_ should be InstanceType (golint)
    • Line 60: warning: don't use underscores in Go names; struct field Role_ should be Role (golint)
    • Line 61: warning: don't use underscores in Go names; struct field SubnetGroup_ should be SubnetGroup (golint)
    • Line 62: warning: don't use underscores in Go names; struct field SecurityGroups_ should be SecurityGroups (golint)
    • Line 63: warning: don't use underscores in Go names; struct field Count_ should be Count (golint)
    • Line 64: warning: don't use underscores in Go names; struct field Teams_ should be Teams (golint)
    • Line 122: warning: comment on exported method Pod.SubnetGroup should be of the form "SubnetGroup ..." (golint)
    • arc/pkg/ssh/doc.go
    • Line 35: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)
    • arc/pkg/command/command.go
    • Line 46: warning: comment on exported const Local should be of the form "Local ..." (golint)
    • Line 55: warning: comment on exported const Sudo should be of the form "Sudo ..." (golint)
    • Line 58: warning: comment on exported const Message should be of the form "Message ..." (golint)
    • arc/pkg/aws/nat_gateway.go
    • Line 46: warning: don't use underscores in Go names; struct field name_ should be name (golint)
    • Line 47: warning: don't use underscores in Go names; struct field availabilityZone_ should be availabilityZone (golint)
    • Line 50: warning: don't use underscores in Go names; struct field id_ should be id (golint)
    • arc/pkg/config/subnet.go
    • Line 31: warning: comment on exported type Subnet should be of the form "Subnet ..." (with optional leading article) (golint)
    • Line 41: warning: don't use underscores in Go names; struct field Name_ should be Name (golint)
    • Line 42: warning: don't use underscores in Go names; struct field GroupName_ should be GroupName (golint)
    • Line 43: warning: don't use underscores in Go names; struct field CidrBlock_ should be CidrBlock (golint)
    • Line 44: warning: don't use underscores in Go names; struct field Access_ should be Access (golint)
    • Line 45: warning: don't use underscores in Go names; struct field AvailabilityZone_ should be AvailabilityZone (golint)
    • Line 46: warning: don't use underscores in Go names; struct field ManageRoutes_ should be ManageRoutes (golint)
    • Line 56: warning: exported method Subnet.SetName should have comment or be unexported (golint)
    • Line 60: warning: comment on exported method Subnet.GroupName should be of the form "GroupName ..." (golint)
    • arc/pkg/config/volume.go
    • Line 31: warning: exported type Volumes should have comment or be unexported (golint)
    • Line 33: warning: exported method Volumes.Print should have comment or be unexported (golint)
    • Line 42: warning: exported type Volume should have comment or be unexported (golint)
    • Line 43: warning: don't use underscores in Go names; struct field Device_ should be Device (golint)
    • Line 44: warning: don't use underscores in Go names; struct field Type_ should be Type (golint)
    • Line 45: warning: don't use underscores in Go names; struct field Size_ should be Size (golint)
    • Line 46: warning: don't use underscores in Go names; struct field Keep_ should be Keep (golint)
    • Line 47: warning: don't use underscores in Go names; struct field Boot_ should be Boot (golint)
    • Line 48: warning: don't use underscores in Go names; struct field FsType_ should be FsType (golint)
    • Line 49: warning: don't use underscores in Go names; struct field Inodes_ should be Inodes (golint)
    • Line 50: warning: don't use underscores in Go names; struct field MountPoint_ should be MountPoint (golint)
    • Line 51: warning: don't use underscores in Go names; struct field Preserve_ should be Preserve (golint)
    • Line 54: warning: exported method Volume.Device should have comment or be unexported (golint)
    • Line 58: warning: exported method Volume.Size should have comment or be unexported (golint)
    • Line 62: warning: exported method Volume.Type should have comment or be unexported (golint)
    • Line 66: warning: exported method Volume.Keep should have comment or be unexported (golint)
    • Line 70: warning: exported method Volume.Boot should have comment or be unexported (golint)
    • Line 74: warning: exported method Volume.FsType should have comment or be unexported (golint)
    • Line 78: warning: exported method Volume.Inodes should have comment or be unexported (golint)
    • Line 82: warning: exported method Volume.MountPoint should have comment or be unexported (golint)
    • Line 86: warning: exported method Volume.Preserve should have comment or be unexported (golint)
    • Line 90: warning: exported method Volume.Print should have comment or be unexported (golint)
    • arc/pkg/resource/subnet.go
    • Line 40: warning: comment on exported type DynamicSubnet should be of the form "DynamicSubnet ..." (with optional leading article) (golint)
    • arc/pkg/route/request.go
    • Line 31: warning: exported type Request should have comment or be unexported (golint)
    • Line 41: warning: exported function NewRequest should have comment or be unexported (golint)
    • Line 52: warning: exported method Request.Clone should have comment or be unexported (golint)
    • Line 63: warning: exported method Request.Parse should have comment or be unexported (golint)
    • Line 80: warning: exported method Request.DataCenter should have comment or be unexported (golint)
    • Line 84: warning: exported method Request.UserId should have comment or be unexported (golint)
    • Line 88: warning: exported method Request.Time should have comment or be unexported (golint)
    • Line 92: warning: exported method Request.Path should have comment or be unexported (golint)
    • Line 96: warning: exported method Request.Command should have comment or be unexported (golint)
    • Line 100: warning: exported method Request.SetCommand should have comment or be unexported (golint)
    • Line 104: warning: exported method Request.Flags should have comment or be unexported (golint)
    • Line 108: warning: exported method Request.Flag should have comment or be unexported (golint)
    • Line 112: warning: exported method Request.TestFlag should have comment or be unexported (golint)
    • Line 120: warning: exported method Request.Top should have comment or be unexported (golint)
    • Line 124: warning: exported method Request.Pop should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign98%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!