Go Report Card

Report for github.com/cohenjo/waste

B    Not bad!    Found 21 issues across 24 files

Tweet
Last refresh:

Refresh now

gofmt50%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint33%

Golint is a linter for Go source code.

    • waste/go/scheduler/schedule.go
    • Line 15: warning: exported type WasteFunc should have comment or be unexported (golint)
    • Line 25: warning: exported var WS should have comment or be unexported (golint)
    • Line 35: warning: exported function SetupScheduler should have comment or be unexported (golint)
    • Line 91: warning: receiver name ws should be consistent with previous receiver name scheduler for wasteScheduler (golint)
    • Line 97: warning: receiver name ws should be consistent with previous receiver name scheduler for wasteScheduler (golint)
    • waste/go/mutators/rename.go
    • Line 13: warning: exported type RenameTable should have comment or be unexported (golint)
    • Line 17: warning: exported method RenameTable.Validate should have comment or be unexported (golint)
    • Line 21: warning: exported method RenameTable.PostSteps should have comment or be unexported (golint)
    • Line 89: warning: exported method RenameTable.GetArtifact should have comment or be unexported (golint)
    • Line 93: warning: exported method RenameTable.GetCluster should have comment or be unexported (golint)
    • Line 97: warning: exported method RenameTable.GetDB should have comment or be unexported (golint)
    • Line 101: warning: exported method RenameTable.Immediate should have comment or be unexported (golint)
    • waste/go/mutators/drop.go
    • Line 13: warning: exported type DropChange should have comment or be unexported (golint)
    • Line 17: warning: exported method DropChange.Validate should have comment or be unexported (golint)
    • Line 21: warning: exported method DropChange.PostSteps should have comment or be unexported (golint)
    • Line 30: warning: exported method DropChange.RunChange should have comment or be unexported (golint)
    • Line 88: warning: exported function DropTask should have comment or be unexported (golint)
    • Line 100: warning: exported method DropChange.GetArtifact should have comment or be unexported (golint)
    • Line 104: warning: exported method DropChange.GetCluster should have comment or be unexported (golint)
    • Line 108: warning: exported method DropChange.GetDB should have comment or be unexported (golint)
    • waste/go/types/bindings.go
    • Line 8: warning: exported type User should have comment or be unexported (golint)
    • Line 19: warning: exported function RegisterNewUser should have comment or be unexported (golint)
    • Line 33: warning: exported function IsUserValid should have comment or be unexported (golint)
    • Line 42: warning: exported function IsUsernameAvailable should have comment or be unexported (golint)
    • waste/go/types/github.go
    • Line 5: warning: exported type ChangedFile should have comment or be unexported (golint)
    • Line 12: warning: don't use underscores in Go names; struct field blob_url should be blobURL (golint)
    • Line 13: warning: don't use underscores in Go names; struct field Raw_url should be RawURL (golint)
    • Line 14: warning: don't use underscores in Go names; struct field Contents_url should be ContentsURL (golint)
    • Line 18: warning: exported type ChangedFiles should have comment or be unexported (golint)
    • Line 20: warning: exported type PullRequestDetails should have comment or be unexported (golint)
    • Line 44: warning: comment on exported type PullRequestsQuery should be of the form "PullRequestsQuery ..." (with optional leading article) (golint)
    • waste/cmd/binder/main.go
    • Line 13: warning: exported function TaskWithoutArgs should have comment or be unexported (golint)
    • Line 17: warning: exported function TaskWithArgs should have comment or be unexported (golint)
    • waste/go/unused/helpers.go
    • Line 21: warning: exported type Server should have comment or be unexported (golint)
    • Line 42: warning: don't use underscores in Go names; var url_template should be urlTemplate (golint)
    • Line 69: warning: don't use underscores in Go names; var rep_templte should be repTemplte (golint)
    • Line 96: warning: exported function GetHttpClient should have comment or be unexported (golint)
    • Line 105: warning: exported function QueryGithub should have comment or be unexported (golint)
    • waste/go/mutators/changer.go
    • Line 16: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 20: warning: comment on exported type BaseChange should be of the form "BaseChange ..." (with optional leading article) (golint)
    • Line 34: warning: exported type Change should have comment or be unexported (golint)
    • Line 77: warning: receiver name cng should be consistent with previous receiver name c for BaseChange (golint)
    • Line 99: warning: exported method BaseChange.InferFromAST should have comment or be unexported (golint)
    • Line 99: warning: receiver name cng should be consistent with previous receiver name c for BaseChange (golint)
    • Line 134: warning: exported method BaseChange.Validate should have comment or be unexported (golint)
    • Line 137: warning: exported method BaseChange.RunChange should have comment or be unexported (golint)
    • Line 140: warning: exported method BaseChange.PostSteps should have comment or be unexported (golint)
    • waste/go/logic/manager.go
    • Line 13: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 21: warning: exported type VersionsChangeLog should have comment or be unexported (golint)
    • Line 27: warning: exported type ArtifactDBVersion should have comment or be unexported (golint)
    • Line 34: warning: exported type ChangeManager should have comment or be unexported (golint)
    • Line 39: warning: exported var CM should have comment or be unexported (golint)
    • Line 41: warning: exported function SetupChangeManager should have comment or be unexported (golint)
    • Line 141: warning: exported function GenerateChange should have comment or be unexported (golint)
    • Line 201: warning: exported method ChangeManager.GetChanges should have comment or be unexported (golint)
    • waste/go/utils/client.go
    • Line 38: warning: exported function GetMasters should have comment or be unexported (golint)
    • Line 45: warning: exported function GetBindings should have comment or be unexported (golint)
    • waste/go/utils/parser.go
    • Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 14: warning: comment on exported function Parse should be of the form "Parse ..." (golint)
    • waste/go/mutators/alter.go
    • Line 13: warning: exported type AlterTable should have comment or be unexported (golint)
    • Line 17: warning: exported method AlterTable.Validate should have comment or be unexported (golint)
    • Line 21: warning: exported method AlterTable.PostSteps should have comment or be unexported (golint)
    • Line 25: warning: exported method AlterTable.Immediate should have comment or be unexported (golint)
    • Line 131: warning: exported method AlterTable.GetArtifact should have comment or be unexported (golint)
    • Line 135: warning: exported method AlterTable.GetCluster should have comment or be unexported (golint)
    • Line 139: warning: exported method AlterTable.GetDB should have comment or be unexported (golint)
    • waste/go/mutators/create.go
    • Line 10: warning: exported type CreateTable should have comment or be unexported (golint)
    • Line 15: warning: exported method CreateTable.Validate should have comment or be unexported (golint)
    • Line 19: warning: exported method CreateTable.PostSteps should have comment or be unexported (golint)
    • Line 23: warning: exported method CreateTable.Immediate should have comment or be unexported (golint)
    • Line 27: warning: comment on exported method CreateTable.RunChange should be of the form "RunChange ..." (golint)
    • Line 81: warning: exported method CreateTable.GetArtifact should have comment or be unexported (golint)
    • Line 85: warning: exported method CreateTable.GetCluster should have comment or be unexported (golint)
    • Line 89: warning: exported method CreateTable.GetDB should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign79%

IneffAssign detects ineffectual assignments in Go code.

    • waste/go/unused/helpers.go
    • Line 44: warning: ineffectual assignment to err (ineffassign)
    • Line 58: warning: ineffectual assignment to err (ineffassign)
    • Line 70: warning: ineffectual assignment to err (ineffassign)
    • Line 78: warning: ineffectual assignment to err (ineffassign)
    • Line 79: warning: ineffectual assignment to err (ineffassign)

misspell91%

Misspell Finds commonly misspelled English words