Report for github.com/compozed/deployadactyl
A Great! Found 98 issues across 172 files
gofmt85%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
deployadactyl/state/start/startmanager_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/artifetcher/artifetcher_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/artifetcher/extractor/extractor_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/controller/controller_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/start/failure_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/push/failure_precheck_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/push/service_suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/server.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/stop/success_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/push/failure_existing_app_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/artifetcher/extractor/extractor.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/start/service_suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/mocks/actionmanagerfactory.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/mocks/fetcher.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/controller/deployer/bluegreen/bluegreen_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/push/failure_no_rollback_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/creator/creator.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/interfaces/logger.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/eventmanager/handlers/envvar/manifest_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/stop/failure_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/stop/service_suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/start/success_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/service_tests/push/success_zip_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/state/stop/stopmanager_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
deployadactyl/state/push/pushmanager_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint56%
Golint is a linter for Go source code.
-
-
deployadactyl/constants/event_constants.go
- Line 4: warning: exported const DeployStartEvent should have comment (or a comment on this block) or be unexported (golint)
-
-
deployadactyl/controller/deployer/error_finder/error_matcher.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 11: warning: exported type ErrorMatcherFactory should have comment or be unexported (golint)
- Line 14: warning: exported method ErrorMatcherFactory.CreateErrorMatcher should have comment or be unexported (golint)
- Line 42: warning: exported type RegExErrorMatcher should have comment or be unexported (golint)
- Line 50: warning: exported method RegExErrorMatcher.Descriptor should have comment or be unexported (golint)
- Line 54: warning: exported method RegExErrorMatcher.Match should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/prechecker/errors.go
- Line 5: warning: exported type NoFoundationsConfiguredError should have comment or be unexported (golint)
- Line 11: warning: exported type InvalidGetRequestError should have comment or be unexported (golint)
- Line 20: warning: exported type FoundationUnavailableError should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/error.go
- Line 3: warning: exported type DeploymentError should have comment or be unexported (golint)
- Line 8: warning: exported type LogMatchedError should have comment or be unexported (golint)
-
-
deployadactyl/mocks/pushcontroller.go
- Line 8: warning: exported type PushController should have comment or be unexported (golint)
- Line 22: warning: exported method PushController.RunDeployment should have comment or be unexported (golint)
-
-
deployadactyl/artifetcher/extractor/errors.go
- Line 5: warning: exported type CreateDirectoryError should have comment or be unexported (golint)
- Line 13: warning: exported type OpenZipError should have comment or be unexported (golint)
- Line 26: warning: exported type ExtractFileError should have comment or be unexported (golint)
- Line 35: warning: exported type OpenManifestError should have comment or be unexported (golint)
- Line 43: warning: exported type PrintToManifestError should have comment or be unexported (golint)
- Line 51: warning: exported type MakeDirectoryError should have comment or be unexported (golint)
- Line 60: warning: exported type OpenFileError should have comment or be unexported (golint)
- Line 69: warning: exported type WriteFileError should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/prechecker/prechecker.go
- Line 26: warning: receiver name b should be consistent with previous receiver name s for eventBinding (golint)
- Line 30: warning: exported type FoundationsUnavailableEvent should have comment or be unexported (golint)
- Line 35: warning: exported method FoundationsUnavailableEvent.Name should have comment or be unexported (golint)
- Line 39: warning: exported function NewFoundationsUnavailableEventBinding should have comment or be unexported (golint)
- Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 53: warning: exported type PrecheckerConstructor should have comment or be unexported (golint)
- Line 55: warning: exported function NewPrechecker should have comment or be unexported (golint)
-
-
deployadactyl/creator/creator.go
- Line 41: warning: exported const ENDPOINT should have comment or be unexported (golint)
- Line 43: warning: exported type CreatorModuleProvider should have comment or be unexported (golint)
- Line 130: warning: exported method Creator.GetLogger should have comment or be unexported (golint)
- Line 160: warning: exported method Creator.CreateController should have comment or be unexported (golint)
- Line 172: warning: exported method Creator.CreatePushController should have comment or be unexported (golint)
- Line 179: warning: exported method Creator.CreateStopController should have comment or be unexported (golint)
- Line 186: warning: exported method Creator.CreateStartController should have comment or be unexported (golint)
- Line 205: warning: exported method Creator.PushManager should have comment or be unexported (golint)
- Line 220: warning: exported method Creator.StopManager should have comment or be unexported (golint)
- Line 229: warning: exported method Creator.StartManager should have comment or be unexported (golint)
- Line 239: warning: exported method Creator.CreateEnvVarHandler should have comment or be unexported (golint)
- Line 243: warning: exported method Creator.CreateHealthChecker should have comment or be unexported (golint)
- Line 251: warning: exported method Creator.CreateRouteMapper should have comment or be unexported (golint)
-
-
deployadactyl/eventmanager/errors.go
- Line 3: warning: exported type InvalidArgumentError should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/startstopper_event_data.go
- Line 7: warning: comment on exported type StartStopEventData should be of the form "StartStopEventData ..." (with optional leading article) (golint)
-
-
deployadactyl/mocks/bluegreener.go
- Line 27: warning: comment on exported method BlueGreener.Execute should be of the form "Execute ..." (golint)
-
-
deployadactyl/mocks/startmanager.go
- Line 12: warning: exported type StartManager should have comment or be unexported (golint)
- Line 23: warning: exported method StartManager.SetUp should have comment or be unexported (golint)
- Line 27: warning: exported method StartManager.OnStart should have comment or be unexported (golint)
- Line 31: warning: exported method StartManager.OnFinish should have comment or be unexported (golint)
- Line 35: warning: exported method StartManager.CleanUp should have comment or be unexported (golint)
- Line 37: warning: exported method StartManager.InitiallyError should have comment or be unexported (golint)
- Line 41: warning: exported method StartManager.Create should have comment or be unexported (golint)
- Line 53: warning: exported method StartManager.ExecuteError should have comment or be unexported (golint)
- Line 57: warning: exported method StartManager.UndoError should have comment or be unexported (golint)
- Line 61: warning: exported method StartManager.SuccessError should have comment or be unexported (golint)
-
-
deployadactyl/structs/error_matcher_descriptor.go
- Line 3: warning: exported type ErrorMatcherDescriptor should have comment or be unexported (golint)
-
-
deployadactyl/state/stop/stopcontroller.go
- Line 15: warning: exported type StopControllerConstructor should have comment or be unexported (golint)
- Line 17: warning: exported function NewStopController should have comment or be unexported (golint)
- Line 28: warning: exported type StopController should have comment or be unexported (golint)
- Line 37: warning: exported method StopController.StopDeployment should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/stopcontroller.go
- Line 8: warning: exported type StopManagerFactory should have comment or be unexported (golint)
- Line 12: warning: exported type StopController should have comment or be unexported (golint)
-
-
deployadactyl/state/push/event.go
- Line 21: warning: receiver name b should be consistent with previous receiver name s for eventBinding (golint)
- Line 25: warning: exported type DeployStartedEvent should have comment or be unexported (golint)
- Line 37: warning: exported method DeployStartedEvent.Name should have comment or be unexported (golint)
- Line 41: warning: exported function NewDeployStartEventBinding should have comment or be unexported (golint)
- Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 55: warning: exported type DeployFinishedEvent should have comment or be unexported (golint)
- Line 66: warning: exported method DeployFinishedEvent.Name should have comment or be unexported (golint)
- Line 70: warning: exported function NewDeployFinishedEventBinding should have comment or be unexported (golint)
- Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 84: warning: exported type DeploySuccessEvent should have comment or be unexported (golint)
- Line 97: warning: exported method DeploySuccessEvent.Name should have comment or be unexported (golint)
- Line 101: warning: exported function NewDeploySuccessEventBinding should have comment or be unexported (golint)
- Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 115: warning: exported type DeployFailureEvent should have comment or be unexported (golint)
- Line 127: warning: exported method DeployFailureEvent.Name should have comment or be unexported (golint)
- Line 131: warning: exported function NewDeployFailureEventBinding should have comment or be unexported (golint)
- Line 138: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 145: warning: exported type PushStartedEvent should have comment or be unexported (golint)
- Line 159: warning: exported method PushStartedEvent.Name should have comment or be unexported (golint)
- Line 163: warning: exported function NewPushStartedEventBinding should have comment or be unexported (golint)
- Line 170: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 177: warning: exported type PushFinishedEvent should have comment or be unexported (golint)
- Line 191: warning: exported method PushFinishedEvent.Name should have comment or be unexported (golint)
- Line 195: warning: exported function NewPushFinishedEventBinding should have comment or be unexported (golint)
- Line 202: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 209: warning: exported type ArtifactRetrievalStartEvent should have comment or be unexported (golint)
- Line 220: warning: exported method ArtifactRetrievalStartEvent.Name should have comment or be unexported (golint)
- Line 224: warning: exported function NewArtifactRetrievalStartEventBinding should have comment or be unexported (golint)
- Line 231: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 238: warning: exported type ArtifactRetrievalFailureEvent should have comment or be unexported (golint)
- Line 249: warning: exported method ArtifactRetrievalFailureEvent.Name should have comment or be unexported (golint)
- Line 253: warning: exported function NewArtifactRetrievalFailureEventBinding should have comment or be unexported (golint)
- Line 260: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 267: warning: exported type ArtifactRetrievalSuccessEvent should have comment or be unexported (golint)
- Line 280: warning: exported method ArtifactRetrievalSuccessEvent.Name should have comment or be unexported (golint)
- Line 284: warning: exported function NewArtifactRetrievalSuccessEventBinding should have comment or be unexported (golint)
- Line 291: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
deployadactyl/eventmanager/eventmanager.go
- Line 9: warning: exported type Err should have comment or be unexported (golint)
- Line 13: warning: exported type InvalidEventType should have comment or be unexported (golint)
- Line 17: warning: exported type EventManagerConstructor should have comment or be unexported (golint)
- Line 46: warning: exported function NewEventManager should have comment or be unexported (golint)
- Line 71: warning: exported method EventManager.AddBinding should have comment or be unexported (golint)
- Line 75: warning: exported method EventManager.EmitEvent should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/error_finder/error_finder.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 7: warning: exported type ErrorFinder should have comment or be unexported (golint)
- Line 11: warning: exported method ErrorFinder.FindErrors should have comment or be unexported (golint)
-
-
deployadactyl/eventmanager/handlers/routemapper/routemapper.go
- Line 32: warning: exported method RouteMapper.PushFinishedEventHandler should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/logger.go
- Line 1: warning: package comment should be of the form "Package interfaces ..." (golint)
- Line 10: warning: exported type Logger should have comment or be unexported (golint)
- Line 37: warning: exported type DeploymentLogger should have comment or be unexported (golint)
- Line 47: warning: exported method DeploymentLogger.Errorf should have comment or be unexported (golint)
- Line 51: warning: exported method DeploymentLogger.Debug should have comment or be unexported (golint)
- Line 56: warning: exported method DeploymentLogger.Debugf should have comment or be unexported (golint)
- Line 60: warning: exported method DeploymentLogger.Info should have comment or be unexported (golint)
- Line 65: warning: exported method DeploymentLogger.Infof should have comment or be unexported (golint)
- Line 69: warning: exported method DeploymentLogger.Fatal should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/pushcontroller.go
- Line 8: warning: exported type PushManagerFactory should have comment or be unexported (golint)
- Line 12: warning: exported type PushController should have comment or be unexported (golint)
-
-
deployadactyl/state/push/pusher.go
- Line 1: warning: package comment should be of the form "Package push ..." (golint)
- Line 34: warning: comment on exported method Pusher.Initially should be of the form "Initially ..." (golint)
- Line 71: warning: exported method Pusher.Verify should have comment or be unexported (golint)
- Line 75: warning: exported method Pusher.Execute should have comment or be unexported (golint)
- Line 131: warning: comment on exported method Pusher.Success should be of the form "Success ..." (golint)
- Line 154: warning: comment on exported method Pusher.Undo should be of the form "Undo ..." (golint)
- Line 164: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 186: warning: comment on exported method Pusher.Finally should be of the form "Finally ..." (golint)
-
-
deployadactyl/config/errors.go
- Line 5: warning: exported type EnvironmentsNotSpecifiedError should have comment or be unexported (golint)
- Line 11: warning: exported type MissingParameterError should have comment or be unexported (golint)
- Line 17: warning: exported type ParseYamlError should have comment or be unexported (golint)
-
-
deployadactyl/artifetcher/artifetcher.go
- Line 14: warning: exported type ArtifetcherConstructor should have comment or be unexported (golint)
- Line 16: warning: exported function NewArtifetcher should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/startcontroller.go
- Line 8: warning: exported type StartManagerFactory should have comment or be unexported (golint)
- Line 12: warning: exported type StartController should have comment or be unexported (golint)
-
-
deployadactyl/mocks/errormatcher.go
- Line 5: warning: exported type ErrorMatcherMock should have comment or be unexported (golint)
- Line 14: warning: exported method ErrorMatcherMock.Match should have comment or be unexported (golint)
- Line 18: warning: exported method ErrorMatcherMock.Descriptor should have comment or be unexported (golint)
-
-
deployadactyl/state/start/starter.go
- Line 10: warning: exported type Starter should have comment or be unexported (golint)
- Line 22: warning: exported method Starter.Verify should have comment or be unexported (golint)
- Line 26: warning: exported method Starter.Success should have comment or be unexported (golint)
- Line 30: warning: exported method Starter.Finally should have comment or be unexported (golint)
- Line 34: warning: comment on exported method Starter.Initially should be of the form "Initially ..." (golint)
- Line 64: warning: exported method Starter.Execute should have comment or be unexported (golint)
- Line 85: warning: exported method Starter.Undo should have comment or be unexported (golint)
-
-
deployadactyl/mocks/action.go
- Line 37: warning: comment on exported method Action.Initially should be of the form "Initially ..." (golint)
- Line 43: warning: exported method Action.Execute should have comment or be unexported (golint)
- Line 47: warning: exported method Action.Verify should have comment or be unexported (golint)
- Line 52: warning: exported method Action.Success should have comment or be unexported (golint)
- Line 57: warning: exported method Action.Undo should have comment or be unexported (golint)
- Line 62: warning: exported method Action.Finally should have comment or be unexported (golint)
-
-
deployadactyl/mocks/eventbinding.go
- Line 3: warning: exported type EventBinding should have comment or be unexported (golint)
- Line 25: warning: exported method EventBinding.Accepts should have comment or be unexported (golint)
- Line 32: warning: exported method EventBinding.Emit should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/bluegreen/actor.go
- Line 5: warning: exported function NewActor should have comment or be unexported (golint)
- Line 27: warning: exported type ActorCommand should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/controller.go
- Line 8: warning: exported type DeploymentType should have comment or be unexported (golint)
- Line 13: warning: exported type Deployment should have comment or be unexported (golint)
- Line 20: warning: exported type Authorization should have comment or be unexported (golint)
- Line 25: warning: exported type CFContext should have comment or be unexported (golint)
- Line 33: warning: exported type Controller should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/eventmanager.go
- Line 3: warning: exported type Event should have comment or be unexported (golint)
- Line 9: warning: exported method Event.Name should have comment or be unexported (golint)
- Line 13: warning: exported type Binding should have comment or be unexported (golint)
- Line 26: warning: exported type IEvent should have comment or be unexported (golint)
-
-
deployadactyl/mocks/stopcontroller.go
- Line 8: warning: exported type StopController should have comment or be unexported (golint)
- Line 23: warning: exported method StopController.StopDeployment should have comment or be unexported (golint)
-
-
deployadactyl/mocks/stopmanager.go
- Line 16: warning: exported type StopManager should have comment or be unexported (golint)
- Line 27: warning: exported method StopManager.SetUp should have comment or be unexported (golint)
- Line 31: warning: exported method StopManager.OnStart should have comment or be unexported (golint)
- Line 35: warning: exported method StopManager.OnFinish should have comment or be unexported (golint)
- Line 39: warning: exported method StopManager.CleanUp should have comment or be unexported (golint)
- Line 41: warning: exported method StopManager.InitiallyError should have comment or be unexported (golint)
- Line 45: warning: exported method StopManager.Create should have comment or be unexported (golint)
- Line 57: warning: exported method StopManager.ExecuteError should have comment or be unexported (golint)
- Line 61: warning: exported method StopManager.UndoError should have comment or be unexported (golint)
- Line 65: warning: exported method StopManager.SuccessError should have comment or be unexported (golint)
-
-
deployadactyl/state/errors.go
- Line 5: warning: exported type CloudFoundryGetLogsError should have comment or be unexported (golint)
- Line 14: warning: exported type DeleteApplicationError should have comment or be unexported (golint)
- Line 23: warning: exported type LoginError should have comment or be unexported (golint)
- Line 32: warning: exported type RenameError should have comment or be unexported (golint)
- Line 41: warning: exported type PushError should have comment or be unexported (golint)
- Line 47: warning: exported type MapRouteError should have comment or be unexported (golint)
- Line 55: warning: exported type UnmapRouteError should have comment or be unexported (golint)
- Line 64: warning: exported type InvalidContentTypeError should have comment or be unexported (golint)
- Line 70: warning: exported type AppPathError should have comment or be unexported (golint)
- Line 78: warning: exported type ManifestError should have comment or be unexported (golint)
- Line 84: warning: exported type UnzippingError should have comment or be unexported (golint)
- Line 92: warning: exported type CourierCreationError should have comment or be unexported (golint)
- Line 100: warning: exported type StartError should have comment or be unexported (golint)
- Line 109: warning: exported type StopError should have comment or be unexported (golint)
- Line 118: warning: exported type ExistsError should have comment or be unexported (golint)
-
-
deployadactyl/state/stop/stopmanager.go
- Line 22: warning: exported type StopManager should have comment or be unexported (golint)
- Line 29: warning: exported method StopManager.Logger should have comment or be unexported (golint)
- Line 33: warning: exported method StopManager.SetUp should have comment or be unexported (golint)
- Line 37: warning: exported method StopManager.OnStart should have comment or be unexported (golint)
- Line 41: warning: exported method StopManager.OnFinish should have comment or be unexported (golint)
- Line 63: warning: exported method StopManager.CleanUp should have comment or be unexported (golint)
- Line 65: warning: exported method StopManager.Create should have comment or be unexported (golint)
- Line 94: warning: exported method StopManager.InitiallyError should have comment or be unexported (golint)
- Line 98: warning: exported method StopManager.ExecuteError should have comment or be unexported (golint)
- Line 102: warning: exported method StopManager.UndoError should have comment or be unexported (golint)
- Line 106: warning: exported method StopManager.SuccessError should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/bluegreener.go
- Line 9: warning: exported type BlueGreener should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/bluegreen/bluegreen.go
- Line 19: warning: comment on exported method BlueGreen.Execute should be of the form "Execute ..." (golint)
-
-
deployadactyl/eventmanager/handlers/healthchecker/errors.go
- Line 7: warning: exported type HealthCheckError should have comment or be unexported (golint)
- Line 26: warning: exported type MapRouteError should have comment or be unexported (golint)
- Line 35: warning: exported type DeleteRouteError should have comment or be unexported (golint)
- Line 44: warning: exported type ClientError should have comment or be unexported (golint)
- Line 52: warning: exported type LoginError should have comment or be unexported (golint)
- Line 60: warning: exported type WrongEventTypeError should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/errormatcher.go
- Line 3: warning: exported type ErrorMatcher should have comment or be unexported (golint)
-
-
deployadactyl/mocks/pushmanager.go
- Line 48: warning: exported type FileSystemCleaner should have comment or be unexported (golint)
- Line 62: warning: exported method FileSystemCleaner.RemoveAll should have comment or be unexported (golint)
- Line 70: warning: exported method PushManager.SetUp should have comment or be unexported (golint)
- Line 75: warning: exported method PushManager.CleanUp should have comment or be unexported (golint)
- Line 79: warning: exported method PushManager.OnStart should have comment or be unexported (golint)
- Line 85: warning: exported method PushManager.OnFinish should have comment or be unexported (golint)
- Line 94: warning: exported method PushManager.Create should have comment or be unexported (golint)
- Line 100: warning: exported method PushManager.InitiallyError should have comment or be unexported (golint)
- Line 104: warning: exported method PushManager.ExecuteError should have comment or be unexported (golint)
- Line 108: warning: exported method PushManager.UndoError should have comment or be unexported (golint)
- Line 112: warning: exported method PushManager.SuccessError should have comment or be unexported (golint)
-
-
deployadactyl/mocks/startcontroller.go
- Line 8: warning: exported type StartController should have comment or be unexported (golint)
- Line 23: warning: exported method StartController.StartDeployment should have comment or be unexported (golint)
-
-
deployadactyl/state/push/pushcontroller.go
- Line 20: warning: exported type PushControllerConstructor should have comment or be unexported (golint)
- Line 22: warning: exported function NewPushController should have comment or be unexported (golint)
- Line 34: warning: exported type PushController should have comment or be unexported (golint)
- Line 44: warning: comment on exported method PushController.RunDeployment should be of the form "RunDeployment ..." (golint)
-
-
deployadactyl/controller/deployer/error_finder/errors.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 5: warning: exported function CreateLogMatchedError should have comment or be unexported (golint)
-
-
deployadactyl/eventmanager/handlers/envvar/envvarhandler.go
- Line 9: warning: exported type Envvarhandler should have comment or be unexported (golint)
- Line 14: warning: exported method Envvarhandler.ArtifactRetrievalSuccessEventHandler should have comment or be unexported (golint)
-
-
deployadactyl/state/stop/event.go
- Line 21: warning: receiver name b should be consistent with previous receiver name s for eventBinding (golint)
- Line 25: warning: exported type StopFailureEvent should have comment or be unexported (golint)
- Line 35: warning: exported method StopFailureEvent.Name should have comment or be unexported (golint)
- Line 39: warning: exported function NewStopFailureEventBinding should have comment or be unexported (golint)
- Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 53: warning: exported type StopSuccessEvent should have comment or be unexported (golint)
- Line 62: warning: exported method StopSuccessEvent.Name should have comment or be unexported (golint)
- Line 66: warning: exported function NewStopSuccessEventBinding should have comment or be unexported (golint)
- Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 80: warning: exported type StopStartedEvent should have comment or be unexported (golint)
- Line 89: warning: exported method StopStartedEvent.Name should have comment or be unexported (golint)
- Line 93: warning: exported function NewStopStartedEventBinding should have comment or be unexported (golint)
- Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 107: warning: exported type StopFinishedEvent should have comment or be unexported (golint)
- Line 116: warning: exported method StopFinishedEvent.Name should have comment or be unexported (golint)
- Line 120: warning: exported function NewStopFinishedEventBinding should have comment or be unexported (golint)
- Line 127: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
deployadactyl/controller/deployer/errors.go
- Line 5: warning: exported type BasicAuthError should have comment or be unexported (golint)
- Line 11: warning: exported type ManifestError should have comment or be unexported (golint)
- Line 19: warning: exported type InvalidContentTypeError should have comment or be unexported (golint)
- Line 25: warning: exported type EventError should have comment or be unexported (golint)
- Line 34: warning: exported type EnvironmentNotFoundError should have comment or be unexported (golint)
-
-
deployadactyl/mocks/actionmanagerfactory.go
- Line 8: warning: comment on exported type PushManagerFactory should be of the form "PushManagerFactory ..." (with optional leading article) (golint)
- Line 28: warning: exported method PushManagerFactory.PushManager should have comment or be unexported (golint)
- Line 40: warning: exported type StopManagerFactory should have comment or be unexported (golint)
- Line 53: warning: exported method StopManagerFactory.StopManager should have comment or be unexported (golint)
- Line 61: warning: exported type StartManagerFactory should have comment or be unexported (golint)
- Line 74: warning: exported method StartManagerFactory.StartManager should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/error_finder/error_matcher_test.go
- Line 1: warning: don't use an underscore in package name (golint)
-
-
deployadactyl/artifetcher/extractor/extractor.go
- Line 15: warning: exported type ExtractorConstructor should have comment or be unexported (golint)
- Line 17: warning: exported function NewExtractor should have comment or be unexported (golint)
-
-
deployadactyl/eventmanager/handlers/healthchecker/healthchecker.go
- Line 33: warning: exported method HealthChecker.PushFinishedEventHandler should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/action.go
- Line 8: warning: exported type Action should have comment or be unexported (golint)
- Line 17: warning: exported type ActionCreator should have comment or be unexported (golint)
-
-
deployadactyl/state/push/pushmanager.go
- Line 41: warning: exported type PushManager should have comment or be unexported (golint)
- Line 54: warning: exported method PushManager.SetUp should have comment or be unexported (golint)
- Line 164: warning: exported method PushManager.OnStart should have comment or be unexported (golint)
- Line 198: warning: exported method PushManager.OnFinish should have comment or be unexported (golint)
- Line 226: warning: exported method PushManager.CleanUp should have comment or be unexported (golint)
- Line 230: warning: exported method PushManager.Create should have comment or be unexported (golint)
- Line 255: warning: exported method PushManager.InitiallyError should have comment or be unexported (golint)
- Line 259: warning: exported method PushManager.ExecuteError should have comment or be unexported (golint)
- Line 263: warning: exported method PushManager.UndoError should have comment or be unexported (golint)
- Line 267: warning: exported method PushManager.SuccessError should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/bluegreen/courier/courier.go
- Line 11: warning: exported type CourierConstructor should have comment or be unexported (golint)
- Line 13: warning: exported function NewCourier should have comment or be unexported (golint)
- Line 36: warning: exported method Courier.CreateService should have comment or be unexported (golint)
- Line 40: warning: exported method Courier.BindService should have comment or be unexported (golint)
- Line 44: warning: exported method Courier.UnbindService should have comment or be unexported (golint)
- Line 48: warning: exported method Courier.DeleteService should have comment or be unexported (golint)
- Line 52: warning: exported method Courier.Restage should have comment or be unexported (golint)
- Line 56: warning: exported method Courier.Start should have comment or be unexported (golint)
- Line 60: warning: exported method Courier.Stop should have comment or be unexported (golint)
- Line 84: warning: comment on exported method Courier.MapRouteWithPath should be of the form "MapRouteWithPath ..." (golint)
- Line 98: warning: comment on exported method Courier.UnmapRouteWithPath should be of the form "UnmapRouteWithPath ..." (golint)
- Line 112: warning: exported method Courier.DeleteRoute should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/bluegreen/errors.go
- Line 8: warning: exported type LoginError should have comment or be unexported (golint)
- Line 17: warning: exported method LoginError.Code should have comment or be unexported (golint)
- Line 21: warning: exported type PushError should have comment or be unexported (golint)
- Line 30: warning: exported method PushError.Code should have comment or be unexported (golint)
- Line 34: warning: exported type RollbackError should have comment or be unexported (golint)
- Line 39: warning: exported type RollbackStopError should have comment or be unexported (golint)
- Line 62: warning: exported method RollbackError.Code should have comment or be unexported (golint)
- Line 66: warning: exported type FinishPushError should have comment or be unexported (golint)
- Line 78: warning: exported method FinishPushError.Code should have comment or be unexported (golint)
- Line 82: warning: exported type StartStopError should have comment or be unexported (golint)
- Line 90: warning: exported type InitializationError should have comment or be unexported (golint)
- Line 98: warning: exported method InitializationError.Code should have comment or be unexported (golint)
- Line 102: warning: exported type FinishStopError should have comment or be unexported (golint)
- Line 112: warning: exported type StopError should have comment or be unexported (golint)
- Line 121: warning: exported method StopError.Code should have comment or be unexported (golint)
- Line 125: warning: exported type FinishDeployError should have comment or be unexported (golint)
- Line 133: warning: exported method FinishDeployError.Code should have comment or be unexported (golint)
- Line 152: warning: exported type FinishStartError should have comment or be unexported (golint)
- Line 162: warning: exported type StartError should have comment or be unexported (golint)
- Line 171: warning: exported method StartError.Code should have comment or be unexported (golint)
- Line 175: warning: exported type RollbackStartError should have comment or be unexported (golint)
-
-
deployadactyl/state/stop/stopper.go
- Line 9: warning: exported type Stopper should have comment or be unexported (golint)
- Line 20: warning: exported method Stopper.Verify should have comment or be unexported (golint)
- Line 24: warning: exported method Stopper.Success should have comment or be unexported (golint)
- Line 28: warning: exported method Stopper.Finally should have comment or be unexported (golint)
- Line 32: warning: comment on exported method Stopper.Initially should be of the form "Initially ..." (golint)
- Line 62: warning: exported method Stopper.Execute should have comment or be unexported (golint)
- Line 83: warning: exported method Stopper.Undo should have comment or be unexported (golint)
-
-
deployadactyl/controller/deployer/deployer.go
- Line 36: warning: exported type SilentDeployer should have comment or be unexported (golint)
- Line 39: warning: exported method SilentDeployer.Deploy should have comment or be unexported (golint)
- Line 71: warning: exported type Deployer should have comment or be unexported (golint)
- Line 81: warning: exported method Deployer.Deploy should have comment or be unexported (golint)
-
-
deployadactyl/mocks/healthchecker.go
- Line 18: warning: exported method HealthChecker.Check should have comment or be unexported (golint)
-
-
deployadactyl/state/start/event.go
- Line 22: warning: receiver name b should be consistent with previous receiver name s for eventBinding (golint)
- Line 26: warning: exported type StartFailureEvent should have comment or be unexported (golint)
- Line 36: warning: exported method StartFailureEvent.Name should have comment or be unexported (golint)
- Line 40: warning: exported function NewStartFailureEventBinding should have comment or be unexported (golint)
- Line 47: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 54: warning: exported type StartSuccessEvent should have comment or be unexported (golint)
- Line 63: warning: exported method StartSuccessEvent.Name should have comment or be unexported (golint)
- Line 67: warning: exported function NewStartSuccessEventBinding should have comment or be unexported (golint)
- Line 74: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 81: warning: exported type StartStartedEvent should have comment or be unexported (golint)
- Line 90: warning: exported method StartStartedEvent.Name should have comment or be unexported (golint)
- Line 94: warning: exported function NewStartStartedEventBinding should have comment or be unexported (golint)
- Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 108: warning: exported type StartFinishedEvent should have comment or be unexported (golint)
- Line 117: warning: exported method StartFinishedEvent.Name should have comment or be unexported (golint)
- Line 121: warning: exported function NewStartFinishedEventBinding should have comment or be unexported (golint)
- Line 128: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
deployadactyl/state/start/start_controller.go
- Line 17: warning: exported type StartControllerConstructor should have comment or be unexported (golint)
- Line 19: warning: exported function NewStartController should have comment or be unexported (golint)
- Line 40: warning: exported method StartController.StartDeployment should have comment or be unexported (golint)
-
-
deployadactyl/eventmanager/handlers/routemapper/errors.go
- Line 5: warning: exported type MapRouteError should have comment or be unexported (golint)
- Line 14: warning: exported type InvalidRouteError should have comment or be unexported (golint)
- Line 22: warning: exported type ReadFileError should have comment or be unexported (golint)
-
-
deployadactyl/eventmanager/handlers/envvar/manifest.go
- Line 18: warning: exported type Application should have comment or be unexported (golint)
- Line 24: warning: don't use underscores in Go names; struct field Java_opts should be JavaOpts (golint)
- Line 27: warning: don't use underscores in Go names; struct field Disk_quota should be DiskQuota (golint)
- Line 31: warning: don't use underscores in Go names; struct field Health_check_type should be HealthCheckType (golint)
- Line 34: warning: don't use underscores in Go names; struct field No_Hostname should be NoHostname (golint)
- Line 42: warning: comment on exported type Manifest should be of the form "Manifest ..." (with optional leading article) (golint)
- Line 52: warning: exported type ManifestError should have comment or be unexported (golint)
- Line 60: warning: exported function CreateManifest should have comment or be unexported (golint)
- Line 96: warning: exported method Manifest.AddEnvVar should have comment or be unexported (golint)
- Line 125: warning: exported method Manifest.AddEnvironmentVariables should have comment or be unexported (golint)
- Line 146: warning: exported method Manifest.HasApplications should have comment or be unexported (golint)
- Line 168: warning: exported method Manifest.UnMarshal should have comment or be unexported (golint)
- Line 193: warning: exported method Manifest.Marshal should have comment or be unexported (golint)
- Line 209: warning: exported method Manifest.WriteManifest should have comment or be unexported (golint)
-
-
deployadactyl/structs/stop_event_data.go
- Line 5: warning: exported type StopEventData should have comment or be unexported (golint)
-
-
deployadactyl/controller/controller.go
- Line 19: warning: exported type PushControllerFactory should have comment or be unexported (golint)
- Line 20: warning: exported type StartControllerFactory should have comment or be unexported (golint)
- Line 21: warning: exported type StopControllerFactory should have comment or be unexported (golint)
- Line 34: warning: exported type PutRequest should have comment or be unexported (golint)
- Line 39: warning: comment on exported method Controller.RunDeployment should be of the form "RunDeployment ..." (golint)
- Line 93: warning: exported method Controller.PutRequestHandler should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/deployer.go
- Line 9: warning: exported type DeployResponse should have comment or be unexported (golint)
-
-
deployadactyl/artifetcher/errors.go
- Line 5: warning: exported type CreateTempFileError should have comment or be unexported (golint)
- Line 13: warning: exported type FetcherRequestError should have comment or be unexported (golint)
- Line 21: warning: exported type GetUrlError should have comment or be unexported (golint)
- Line 30: warning: exported type GetStatusError should have comment or be unexported (golint)
- Line 39: warning: exported type WriteResponseError should have comment or be unexported (golint)
- Line 47: warning: exported type CreateTempDirectoryError should have comment or be unexported (golint)
- Line 55: warning: exported type UnzipError should have comment or be unexported (golint)
-
-
deployadactyl/interfaces/errorfinder.go
- Line 3: warning: exported type ErrorFinder should have comment or be unexported (golint)
-
-
deployadactyl/mocks/controller.go
- Line 12: warning: exported type Controller should have comment or be unexported (golint)
- Line 38: warning: exported method Controller.RunDeployment should have comment or be unexported (golint)
- Line 49: warning: exported method Controller.RunDeploymentViaHttp should have comment or be unexported (golint)
- Line 55: warning: exported method Controller.PutRequestHandler should have comment or be unexported (golint)
-
-
deployadactyl/mocks/courier.go
- Line 198: warning: exported method Courier.Start should have comment or be unexported (golint)
- Line 204: warning: exported method Courier.Stop should have comment or be unexported (golint)
- Line 235: warning: comment on exported method Courier.MapRouteWithPath should be of the form "MapRouteWithPath ..." (golint)
- Line 286: warning: exported method Courier.UnmapRouteWithPath should have comment or be unexported (golint)
- Line 338: warning: exported method Courier.CreateService should have comment or be unexported (golint)
- Line 342: warning: exported method Courier.BindService should have comment or be unexported (golint)
- Line 346: warning: exported method Courier.UnbindService should have comment or be unexported (golint)
- Line 350: warning: exported method Courier.DeleteService should have comment or be unexported (golint)
- Line 354: warning: exported method Courier.Restage should have comment or be unexported (golint)
-
-
deployadactyl/mocks/errorfinder.go
- Line 5: warning: exported type ErrorFinder should have comment or be unexported (golint)
- Line 16: warning: exported method ErrorFinder.FindErrors should have comment or be unexported (golint)
-
-
deployadactyl/mocks/eventmanager.go
- Line 59: warning: exported method EventManager.EmitEvent should have comment or be unexported (golint)
- Line 71: warning: exported method EventManager.AddBinding should have comment or be unexported (golint)
-
-
deployadactyl/mocks/pusher.go
- Line 54: warning: comment on exported method Pusher.Initially should be of the form "Initially ..." (golint)
- Line 62: warning: comment on exported method Pusher.Execute should be of the form "Execute ..." (golint)
- Line 70: warning: exported method Pusher.Verify should have comment or be unexported (golint)
- Line 74: warning: comment on exported method Pusher.Success should be of the form "Success ..." (golint)
- Line 79: warning: comment on exported method Pusher.Undo should be of the form "Undo ..." (golint)
- Line 84: warning: comment on exported method Pusher.Finally should be of the form "Finally ..." (golint)
-
-
deployadactyl/mocks/startstopper.go
- Line 3: warning: exported type StartStopper should have comment or be unexported (golint)
- Line 40: warning: exported method StartStopper.Initially should have comment or be unexported (golint)
- Line 45: warning: exported method StartStopper.Verify should have comment or be unexported (golint)
- Line 50: warning: exported method StartStopper.Finally should have comment or be unexported (golint)
- Line 55: warning: exported method StartStopper.Success should have comment or be unexported (golint)
- Line 60: warning: exported method StartStopper.Execute should have comment or be unexported (golint)
- Line 65: warning: exported method StartStopper.Undo should have comment or be unexported (golint)
-
-
deployadactyl/state/start/startmanager.go
- Line 23: warning: exported type StartManager should have comment or be unexported (golint)
- Line 30: warning: exported method StartManager.SetUp should have comment or be unexported (golint)
- Line 34: warning: exported method StartManager.OnStart should have comment or be unexported (golint)
- Line 38: warning: exported method StartManager.OnFinish should have comment or be unexported (golint)
- Line 59: warning: exported method StartManager.CleanUp should have comment or be unexported (golint)
- Line 61: warning: exported method StartManager.Create should have comment or be unexported (golint)
- Line 91: warning: exported method StartManager.InitiallyError should have comment or be unexported (golint)
- Line 95: warning: exported method StartManager.ExecuteError should have comment or be unexported (golint)
- Line 99: warning: exported method StartManager.UndoError should have comment or be unexported (golint)
- Line 103: warning: exported method StartManager.SuccessError should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell96%
Misspell Finds commonly misspelled English words
-
-
deployadactyl/controller/deployer/bluegreen/bluegreen.go
- Line 14: warning: "creater" is a misspelling of "creature" (misspell)
-
-
deployadactyl/state/push/pusher_test.go
- Line 518: warning: "existant" is a misspelling of "existent" (misspell)
-
-
deployadactyl/eventmanager/handlers/envvar/manifest_test.go
- Line 185: warning: "emtpy" is a misspelling of "empty" (misspell)
-
-
deployadactyl/eventmanager/handlers/routemapper/routemapper_test.go
- Line 229: warning: "arguement" is a misspelling of "argument" (misspell)
-
-
deployadactyl/controller/deployer/bluegreen/courier/courier.go
- Line 84: warning: "arguement" is a misspelling of "argument" (misspell)
-
-
deployadactyl/controller/deployer/bluegreen/courier/courier_test.go
- Line 176: warning: "arguement" is a misspelling of "argument" (misspell)