Preparing report...

Report for github.com/containerssh/docker

A+    Excellent!    Found 8 issues across 27 files

Tweet

gofmt88%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint77%

Golint is a linter for Go source code.

    • docker/codes.go
    • Line 3: warning: comment on exported const EFailedAgentRead should be of the form "EFailedAgentRead ..." (golint)
    • Line 8: warning: comment on exported const EFailedOutputCloseWriting should be of the form "EFailedOutputCloseWriting ..." (golint)
    • Line 12: warning: comment on exported const EFailedInputCloseWriting should be of the form "EFailedInputCloseWriting ..." (golint)
    • Line 16: warning: comment on exported const EConfigError should be of the form "EConfigError ..." (golint)
    • Line 20: warning: comment on exported const MContainerAttach should be of the form "MContainerAttach ..." (golint)
    • Line 23: warning: comment on exported const EFailedContainerAttach should be of the form "EFailedContainerAttach ..." (golint)
    • Line 27: warning: comment on exported const MContainerCreate should be of the form "MContainerCreate ..." (golint)
    • Line 30: warning: comment on exported const EFailedContainerCreate should be of the form "EFailedContainerCreate ..." (golint)
    • Line 34: warning: comment on exported const MContainerStart should be of the form "MContainerStart ..." (golint)
    • Line 37: warning: comment on exported const EFailedContainerStart should be of the form "EFailedContainerStart ..." (golint)
    • Line 41: warning: comment on exported const MContainerStop should be of the form "MContainerStop ..." (golint)
    • Line 44: warning: comment on exported const EContainerStopFailed should be of the form "EContainerStopFailed ..." (golint)
    • Line 48: warning: comment on exported const MContainerRemove should be of the form "MContainerRemove ..." (golint)
    • Line 51: warning: comment on exported const EFailedContainerRemove should be of the form "EFailedContainerRemove ..." (golint)
    • Line 55: warning: comment on exported const MContainerRemoveSuccessful should be of the form "MContainerRemoveSuccessful ..." (golint)
    • Line 58: warning: comment on exported const MContainerSignal should be of the form "MContainerSignal ..." (golint)
    • Line 61: warning: comment on exported const EFailedContainerSignal should be of the form "EFailedContainerSignal ..." (golint)
    • Line 65: warning: comment on exported const EShuttingDown should be of the form "EShuttingDown ..." (golint)
    • Line 68: warning: comment on exported const MExec should be of the form "MExec ..." (golint)
    • Line 72: warning: comment on exported const MExecAttach should be of the form "MExecAttach ..." (golint)
    • Line 75: warning: comment on exported const EFailedExecAttach should be of the form "EFailedExecAttach ..." (golint)
    • Line 79: warning: comment on exported const MExecCreate should be of the form "MExecCreate ..." (golint)
    • Line 82: warning: comment on exported const EFailedExecCreate should be of the form "EFailedExecCreate ..." (golint)
    • Line 86: warning: comment on exported const EFailedPIDRead should be of the form "EFailedPIDRead ..." (golint)
    • Line 91: warning: comment on exported const MResizing should be of the form "MResizing ..." (golint)
    • Line 94: warning: comment on exported const EFailedResize should be of the form "EFailedResize ..." (golint)
    • Line 97: warning: comment on exported const MExecSignal should be of the form "MExecSignal ..." (golint)
    • Line 100: warning: comment on exported const EFailedExecSignal should be of the form "EFailedExecSignal ..." (golint)
    • Line 103: warning: comment on exported const ECannotSendSignalNoAgent should be of the form "ECannotSendSignalNoAgent ..." (golint)
    • Line 107: warning: comment on exported const MExecSignalSuccessful should be of the form "MExecSignalSuccessful ..." (golint)
    • Line 110: warning: comment on exported const MExitCode should be of the form "MExitCode ..." (golint)
    • Line 113: warning: comment on exported const EContainerRestarting should be of the form "EContainerRestarting ..." (golint)
    • Line 117: warning: comment on exported const EFetchingExitCodeFailed should be of the form "EFetchingExitCodeFailed ..." (golint)
    • Line 121: warning: comment on exported const ENegativeExitCode should be of the form "ENegativeExitCode ..." (golint)
    • Line 125: warning: comment on exported const EStillRunning should be of the form "EStillRunning ..." (golint)
    • Line 129: warning: comment on exported const MImageList should be of the form "MImageList ..." (golint)
    • Line 133: warning: comment on exported const EFailedImageList should be of the form "EFailedImageList ..." (golint)
    • Line 138: warning: comment on exported const MImagePull should be of the form "MImagePull ..." (golint)
    • Line 141: warning: comment on exported const EFailedImagePull should be of the form "EFailedImagePull ..." (golint)
    • Line 147: warning: comment on exported const MImagePullNeeded should be of the form "MImagePullNeeded ..." (golint)
    • Line 150: warning: comment on exported const EProgramAlreadyRunning should be of the form "EProgramAlreadyRunning ..." (golint)
    • Line 154: warning: comment on exported const EFailedSignalNoPID should be of the form "EFailedSignalNoPID ..." (golint)
    • Line 158: warning: comment on exported const EFailedInputStream should be of the form "EFailedInputStream ..." (golint)
    • Line 161: warning: comment on exported const EFailedOutputStream should be of the form "EFailedOutputStream ..." (golint)
    • Line 165: warning: comment on exported const ESubsystemNotSupported should be of the form "ESubsystemNotSupported ..." (golint)
    • Line 169: warning: comment on exported const EGuestAgentDisabled should be of the form "EGuestAgentDisabled ..." (golint)
    • Line 176: warning: comment on exported const EDockerRun should be of the form "EDockerRun ..." (golint)
    • Line 181: warning: comment on exported const EProgramExecutionDisabled should be of the form "EProgramExecutionDisabled ..." (golint)
    • Line 185: warning: comment on exported const EProgramNotRunning should be of the form "EProgramNotRunning ..." (golint)
    • docker/config_dockerrun.go
    • Line 25: warning: comment on exported type DockerRunContainerConfig should be of the form "DockerRunContainerConfig ..." (with optional leading article) (golint)
    • Line 34: warning: comment on exported method DockerRunContainerConfig.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)
    • Line 57: warning: comment on exported method DockerRunContainerConfig.UnmarshalYAML should be of the form "UnmarshalYAML ..." (golint)
    • docker/const.go
    • Line 3: warning: comment on exported const UserMessageInitializeSSHSession should be of the form "UserMessageInitializeSSHSession ..." (golint)
    • docker/handler_channel.go
    • Line 64: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 70: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!