Preparing report...

Report for github.com/containerssh/http

A+    Excellent!    Found 2 issues across 15 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • http/config.go
    • Line 435: warning: cyclomatic complexity 18 of function (*ServerConfiguration).Validate() is high (> 15) (gocyclo)

golint86%

Golint is a linter for Go source code.

    • http/config.go
    • Line 18: warning: exported const TLSVersion12 should have comment (or a comment on this block) or be unexported (golint)
    • Line 217: warning: exported const IANA_TLS_AES_128_GCM_SHA256 should have comment (or a comment on this block) or be unexported (golint)
    • Line 221: warning: don't use underscores in Go names; const OpenSSL_TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 should be OpenSSLTLSECDHEECDSAWITHAES128GCMSHA256 (golint)
    • Line 222: warning: don't use underscores in Go names; const GnuTLS_TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 should be GnuTLSTLSECDHEECDSAWITHAES128GCMSHA256 (golint)
    • Line 224: warning: don't use underscores in Go names; const OpenSSL_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 should be OpenSSLTLSECDHERSAWITHAES128GCMSHA256 (golint)
    • Line 225: warning: don't use underscores in Go names; const GnuTLS_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 should be GnuTLSTLSECDHERSAWITHAES128GCMSHA256 (golint)
    • Line 227: warning: don't use underscores in Go names; const OpenSSL_TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 should be OpenSSLTLSECDHEECDSAWITHAES256GCMSHA384 (golint)
    • Line 228: warning: don't use underscores in Go names; const GnuTLS_TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 should be GnuTLSTLSECDHEECDSAWITHAES256GCMSHA384 (golint)
    • Line 230: warning: don't use underscores in Go names; const OpenSSL_TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 should be OpenSSLTLSECDHERSAWITHAES256GCMSHA384 (golint)
    • Line 231: warning: don't use underscores in Go names; const GnuTLS_TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 should be GnuTLSTLSECDHERSAWITHAES256GCMSHA384 (golint)
    • Line 233: warning: don't use underscores in Go names; const OpenSSL_TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 should be OpenSSLTLSECDHEECDSAWITHCHACHA20POLY1305 (golint)
    • Line 234: warning: don't use underscores in Go names; const GnuTLS_TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 should be GnuTLSTLSECDHEECDSAWITHCHACHA20POLY1305 (golint)
    • Line 236: warning: don't use underscores in Go names; const OpenSSL_TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305 should be OpenSSLTLSECDHERSAWITHCHACHA20POLY1305 (golint)
    • Line 237: warning: don't use underscores in Go names; const GnuTLS_TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305 should be GnuTLSTLSECDHERSAWITHCHACHA20POLY1305 (golint)
    • Line 494: warning: comment on exported const RequestEncodingDefault should be of the form "RequestEncodingDefault ..." (golint)
    • Line 500: warning: comment on exported const RequestEncodingWWWURLEncoded should be of the form "RequestEncodingWWWURLEncoded ..." (golint)
    • http/codes.go
    • Line 3: warning: comment on exported const EFailureEncodeFailed should be of the form "EFailureEncodeFailed ..." (golint)
    • Line 6: warning: comment on exported const EFailureConnectionFailed should be of the form "EFailureConnectionFailed ..." (golint)
    • Line 9: warning: comment on exported const EFailureDecodeFailed should be of the form "EFailureDecodeFailed ..." (golint)
    • Line 13: warning: comment on exported const EClientRedirectsDisabled should be of the form "EClientRedirectsDisabled ..." (golint)
    • Line 17: warning: comment on exported const MClientRequest should be of the form "MClientRequest ..." (golint)
    • Line 20: warning: comment on exported const MClientRedirect should be of the form "MClientRedirect ..." (golint)
    • Line 23: warning: comment on exported const MClientResponse should be of the form "MClientResponse ..." (golint)
    • Line 26: warning: comment on exported const MServerResponseWriteFailed should be of the form "MServerResponseWriteFailed ..." (golint)
    • Line 29: warning: comment on exported const MServerEncodeFailed should be of the form "MServerEncodeFailed ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!