Preparing report...

Report for github.com/coreos/etcd

(v2.3.8+incompatible)

A+    Excellent!    Found 261 issues across 469 files

Tweet

gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo78%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • Godeps/_workspace/src/github.com/ugorji/go/codec/encode.go
    • Line 1181: warning: cyclomatic complexity 45 of function (*Encoder).getEncFn() is high (> 15) (gocyclo)
    • Line 687: warning: cyclomatic complexity 41 of function (*Encoder).kMapCanonical() is high (> 15) (gocyclo)
    • Line 1049: warning: cyclomatic complexity 35 of function (*Encoder).encode() is high (> 15) (gocyclo)
    • Line 381: warning: cyclomatic complexity 25 of function (*encFnInfo).kSlice() is high (> 15) (gocyclo)
    • Line 497: warning: cyclomatic complexity 21 of function (*encFnInfo).kStruct() is high (> 15) (gocyclo)
    • Line 607: warning: cyclomatic complexity 16 of function (*encFnInfo).kMap() is high (> 15) (gocyclo)
    • raft/node.go
    • Line 260: warning: cyclomatic complexity 32 of function (*node).run() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/github.com/ugorji/go/codec/decode.go
    • Line 1642: warning: cyclomatic complexity 53 of function (*Decoder).getDecFn() is high (> 15) (gocyclo)
    • Line 810: warning: cyclomatic complexity 49 of function (*decFnInfo).kSlice() is high (> 15) (gocyclo)
    • Line 1468: warning: cyclomatic complexity 47 of function (*Decoder).decode() is high (> 15) (gocyclo)
    • Line 1010: warning: cyclomatic complexity 35 of function (*decFnInfo).kMap() is high (> 15) (gocyclo)
    • Line 700: warning: cyclomatic complexity 29 of function (*decFnInfo).kStruct() is high (> 15) (gocyclo)
    • Line 561: warning: cyclomatic complexity 22 of function (*decFnInfo).kInterfaceNaked() is high (> 15) (gocyclo)
    • Line 1393: warning: cyclomatic complexity 21 of function (*Decoder).swallow() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/golang.org/x/net/http2/transport.go
    • Line 587: warning: cyclomatic complexity 34 of function (*ClientConn).RoundTrip() is high (> 15) (gocyclo)
    • Line 1120: warning: cyclomatic complexity 20 of function (*clientConnReadLoop).run() is high (> 15) (gocyclo)
    • Line 787: warning: cyclomatic complexity 19 of function (*clientStream).writeRequestBody() is high (> 15) (gocyclo)
    • Line 1220: warning: cyclomatic complexity 16 of function (*clientConnReadLoop).handleResponse() is high (> 15) (gocyclo)
    • etcdmain/etcd.go
    • Line 78: warning: cyclomatic complexity 27 of function Main() is high (> 15) (gocyclo)
    • Line 199: warning: cyclomatic complexity 26 of function startEtcd() is high (> 15) (gocyclo)
    • Line 351: warning: cyclomatic complexity 22 of function startProxy() is high (> 15) (gocyclo)
    • client/client.go
    • Line 443: warning: cyclomatic complexity 16 of function (*simpleHTTPClient).Do() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/github.com/russross/blackfriday/block.go
    • Line 1074: warning: cyclomatic complexity 45 of function (*parser).listItem() is high (> 15) (gocyclo)
    • Line 1283: warning: cyclomatic complexity 29 of function (*parser).paragraph() is high (> 15) (gocyclo)
    • Line 542: warning: cyclomatic complexity 29 of function (*parser).isFencedCode() is high (> 15) (gocyclo)
    • Line 724: warning: cyclomatic complexity 28 of function (*parser).tableHeader() is high (> 15) (gocyclo)
    • Line 25: warning: cyclomatic complexity 24 of function (*parser).block() is high (> 15) (gocyclo)
    • Line 209: warning: cyclomatic complexity 21 of function (*parser).prefixHeader() is high (> 15) (gocyclo)
    • Line 302: warning: cyclomatic complexity 18 of function (*parser).html() is high (> 15) (gocyclo)
    • Line 420: warning: cyclomatic complexity 16 of function (*parser).htmlHr() is high (> 15) (gocyclo)
    • etcdserver/server.go
    • Line 214: warning: cyclomatic complexity 41 of function NewServer() is high (> 15) (gocyclo)
    • Line 1053: warning: cyclomatic complexity 19 of function (*EtcdServer).applyRequest() is high (> 15) (gocyclo)
    • etcdserver/v3demo_server.go
    • Line 561: warning: cyclomatic complexity 19 of function applyCompare() is high (> 15) (gocyclo)
    • Line 326: warning: cyclomatic complexity 18 of function applyRange() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/github.com/russross/blackfriday/inline.go
    • Line 202: warning: cyclomatic complexity 91 of function link() is high (> 15) (gocyclo)
    • Line 674: warning: cyclomatic complexity 35 of function autoLink() is high (> 15) (gocyclo)
    • Line 943: warning: cyclomatic complexity 33 of function helperFindEmphChar() is high (> 15) (gocyclo)
    • Line 829: warning: cyclomatic complexity 31 of function tagLength() is high (> 15) (gocyclo)
    • Line 69: warning: cyclomatic complexity 18 of function emphasis() is high (> 15) (gocyclo)
    • etcdserver/cluster.go
    • Line 240: warning: cyclomatic complexity 19 of function (*cluster).ValidateConfigurationChange() is high (> 15) (gocyclo)
    • etcdserver/etcdhttp/client.go
    • Line 447: warning: cyclomatic complexity 29 of function parseKeyRequest() is high (> 15) (gocyclo)
    • Line 208: warning: cyclomatic complexity 26 of function (*membersHandler).ServeHTTP() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/github.com/ugorji/go/codec/msgpack.go
    • Line 284: warning: cyclomatic complexity 33 of function (*msgpackDecDriver).DecodeNaked() is high (> 15) (gocyclo)
    • Line 564: warning: cyclomatic complexity 25 of function (*msgpackDecDriver).ContainerType() is high (> 15) (gocyclo)
    • Line 427: warning: cyclomatic complexity 20 of function (*msgpackDecDriver).DecodeUint() is high (> 15) (gocyclo)
    • Line 383: warning: cyclomatic complexity 16 of function (*msgpackDecDriver).DecodeInt() is high (> 15) (gocyclo)
    • integration/v3_watch_test.go
    • Line 556: warning: cyclomatic complexity 21 of function testV3WatchMultipleWatchers() is high (> 15) (gocyclo)
    • Line 33: warning: cyclomatic complexity 19 of function TestV3WatchFromCurrentRevision() is high (> 15) (gocyclo)
    • Line 418: warning: cyclomatic complexity 16 of function TestV3WatchCurrentPutOverlap() is high (> 15) (gocyclo)
    • clientv3/watch.go
    • Line 262: warning: cyclomatic complexity 18 of function (*watcher).run() is high (> 15) (gocyclo)
    • Line 386: warning: cyclomatic complexity 17 of function (*watcher).serveStream() is high (> 15) (gocyclo)
    • wal/wal_test.go
    • Line 319: warning: cyclomatic complexity 16 of function TestRecoverAfterCut() is high (> 15) (gocyclo)
    • raft/raft.go
    • Line 570: warning: cyclomatic complexity 32 of function stepLeader() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/github.com/spf13/cobra/command.go
    • Line 515: warning: cyclomatic complexity 23 of function (*Command).execute() is high (> 15) (gocyclo)
    • Line 393: warning: cyclomatic complexity 18 of function (*Command).Find() is high (> 15) (gocyclo)
    • Line 337: warning: cyclomatic complexity 17 of function stripFlags() is high (> 15) (gocyclo)
    • Line 622: warning: cyclomatic complexity 16 of function (*Command).ExecuteC() is high (> 15) (gocyclo)
    • wal/wal.go
    • Line 229: warning: cyclomatic complexity 20 of function (*WAL).ReadAll() is high (> 15) (gocyclo)
    • store/stats.go
    • Line 113: warning: cyclomatic complexity 16 of function (*Stats).Inc() is high (> 15) (gocyclo)
    • Godeps/_workspace/src/github.com/ugorji/go/codec/gen.go
    • Line 1023: warning: cyclomatic complexity 43 of function (*genRunner).dec() is high (> 15) (gocyclo)
    • Line 613: warning: cyclomatic complexity 37 of function (*genRunner).enc() is high (> 15) (gocyclo)
    • Line 164: warning: cyclomatic complexity 26 of function Gen() is high (> 15) (gocyclo)
    • Line 772: warning: cyclomatic complexity 23 of function (*genRunner).encStruct() is high (> 15) (gocyclo)
    • Line 1611: warning: cyclomatic complexity 18 of function genMethodNameT() is high (> 15) (gocyclo)
    • Line 366: warning: cyclomatic complexity 17 of function (*genRunner).genRefPkgs() is high (> 15) (gocyclo)
    • Line 1191: warning: cyclomatic complexity 16 of function (*genRunner).decTryAssignPrimitive() is high (> 15) (gocyclo)
    • Line 1739: warning: cyclomatic complexity 16 of function genInternalDecCommandAsString() is high (> 15) (gocyclo)

golint67%

Golint is a linter for Go source code.

    • pkg/wait/wait.go
    • Line 24: warning: exported type Wait should have comment or be unexported (golint)
    • Line 29: warning: exported type List should have comment or be unexported (golint)
    • Line 34: warning: exported function New should have comment or be unexported (golint)
    • Line 38: warning: exported method List.Register should have comment or be unexported (golint)
    • Line 51: warning: exported method List.Trigger should have comment or be unexported (golint)
    • Line 66: warning: exported function NewWithResponse should have comment or be unexported (golint)
    • clientv3/maintenance.go
    • Line 23: warning: exported type DefragmentResponse should have comment or be unexported (golint)
    • Line 26: warning: exported type Maintenance should have comment or be unexported (golint)
    • clientv3/sort.go
    • Line 17: warning: exported type SortTarget should have comment or be unexported (golint)
    • Line 18: warning: exported type SortOrder should have comment or be unexported (golint)
    • Line 21: warning: exported const SortNone should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported const SortByKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type SortOption should have comment or be unexported (golint)
    • etcdserver/api/v3rpc/watch.go
    • Line 34: warning: exported function NewWatchServer should have comment or be unexported (golint)
    • Line 44: warning: comment on exported var ProgressReportInterval should be of the form "ProgressReportInterval ..." (golint)
    • pkg/cors/cors.go
    • Line 25: warning: exported type CORSInfo should have comment or be unexported (golint)
    • Line 27: warning: comment on exported method CORSInfo.Set should be of the form "Set ..." (golint)
    • Line 56: warning: receiver name c should be consistent with previous receiver name ci for CORSInfo (golint)
    • Line 60: warning: exported type CORSHandler should have comment or be unexported (golint)
    • pkg/runtime/fds_linux.go
    • Line 23: warning: exported function FDLimit should have comment or be unexported (golint)
    • Line 31: warning: exported function FDUsage should have comment or be unexported (golint)
    • pkg/testutil/testutil.go
    • Line 25: warning: comment on exported function WaitSchedule should be of the form "WaitSchedule ..." (golint)
    • Line 30: warning: exported function MustNewURLs should have comment or be unexported (golint)
    • Line 42: warning: exported function MustNewURL should have comment or be unexported (golint)
    • etcdserver/server.go
    • Line 63: warning: exported const DefaultSnapCount should have comment (or a comment on this block) or be unexported (golint)
    • Line 102: warning: exported type Response should have comment or be unexported (golint)
    • Line 108: warning: exported type Server should have comment or be unexported (golint)
    • Line 471: warning: exported method EtcdServer.ID should have comment or be unexported (golint)
    • Line 473: warning: exported method EtcdServer.Cluster should have comment or be unexported (golint)
    • Line 475: warning: exported method EtcdServer.RaftHandler should have comment or be unexported (golint)
    • Line 477: warning: exported method EtcdServer.Lessor should have comment or be unexported (golint)
    • Line 479: warning: exported method EtcdServer.Process should have comment or be unexported (golint)
    • Line 490: warning: exported method EtcdServer.IsIDRemoved should have comment or be unexported (golint)
    • Line 492: warning: exported method EtcdServer.ReportUnreachable should have comment or be unexported (golint)
    • Line 785: warning: exported method EtcdServer.SelfStats should have comment or be unexported (golint)
    • Line 787: warning: exported method EtcdServer.LeaderStats should have comment or be unexported (golint)
    • Line 795: warning: exported method EtcdServer.StoreStats should have comment or be unexported (golint)
    • Line 797: warning: exported method EtcdServer.AddMember should have comment or be unexported (golint)
    • Line 817: warning: exported method EtcdServer.RemoveMember should have comment or be unexported (golint)
    • Line 831: warning: exported method EtcdServer.UpdateMember should have comment or be unexported (golint)
    • Line 846: warning: exported method EtcdServer.Index should have comment or be unexported (golint)
    • Line 848: warning: exported method EtcdServer.Term should have comment or be unexported (golint)
    • Line 855: warning: exported method EtcdServer.Leader should have comment or be unexported (golint)
    • Line 857: warning: exported method EtcdServer.IsPprofEnabled should have comment or be unexported (golint)
    • Line 1074: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1148: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 1224: warning: exported method EtcdServer.PauseSending should have comment or be unexported (golint)
    • Line 1226: warning: exported method EtcdServer.ResumeSending should have comment or be unexported (golint)
    • Line 1228: warning: exported method EtcdServer.ClusterVersion should have comment or be unexported (golint)
    • Line 1338: warning: exported method EtcdServer.Backend should have comment or be unexported (golint)
    • Line 1344: warning: exported method EtcdServer.AuthStore should have comment or be unexported (golint)
    • raft/raft.go
    • Line 34: warning: exported var ErrSnapshotTemporarilyUnavailable should have comment or be unexported (golint)
    • clientv3/compare.go
    • Line 21: warning: exported type CompareTarget should have comment or be unexported (golint)
    • Line 22: warning: exported type CompareResult should have comment or be unexported (golint)
    • Line 25: warning: exported const CompareVersion should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported type Cmp should have comment or be unexported (golint)
    • Line 33: warning: exported function Compare should have comment or be unexported (golint)
    • Line 67: warning: exported function Value should have comment or be unexported (golint)
    • Line 71: warning: exported function Version should have comment or be unexported (golint)
    • Line 75: warning: exported function CreatedRevision should have comment or be unexported (golint)
    • Line 79: warning: exported function ModifiedRevision should have comment or be unexported (golint)
    • auth/store.go
    • Line 33: warning: exported type AuthStore should have comment or be unexported (golint)
    • Line 55: warning: exported function NewAuthStore should have comment or be unexported (golint)
    • storage/backend/batch_tx.go
    • Line 26: warning: exported type BatchTx should have comment or be unexported (golint)
    • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • wal/util.go
    • Line 26: warning: error var badWalName should have name of the form errFoo (golint)
    • Line 29: warning: exported function Exist should have comment or be unexported (golint)
    • etcdserver/api/v3rpc/auth.go
    • Line 23: warning: exported type AuthServer should have comment or be unexported (golint)
    • Line 27: warning: exported function NewAuthServer should have comment or be unexported (golint)
    • Line 31: warning: exported method AuthServer.AuthEnable should have comment or be unexported (golint)
    • Line 35: warning: exported method AuthServer.AuthDisable should have comment or be unexported (golint)
    • Line 40: warning: exported method AuthServer.Authenticate should have comment or be unexported (golint)
    • Line 45: warning: exported method AuthServer.RoleAdd should have comment or be unexported (golint)
    • Line 50: warning: exported method AuthServer.RoleDelete should have comment or be unexported (golint)
    • Line 55: warning: exported method AuthServer.RoleGet should have comment or be unexported (golint)
    • Line 60: warning: exported method AuthServer.RoleRevoke should have comment or be unexported (golint)
    • Line 65: warning: exported method AuthServer.RoleGrant should have comment or be unexported (golint)
    • Line 70: warning: exported method AuthServer.UserAdd should have comment or be unexported (golint)
    • Line 75: warning: exported method AuthServer.UserDelete should have comment or be unexported (golint)
    • Line 80: warning: exported method AuthServer.UserGet should have comment or be unexported (golint)
    • Line 85: warning: exported method AuthServer.UserGrant should have comment or be unexported (golint)
    • Line 90: warning: exported method AuthServer.UserRevoke should have comment or be unexported (golint)
    • Line 95: warning: exported method AuthServer.UserChangePassword should have comment or be unexported (golint)
    • wal/walpb/record.go
    • Line 20: warning: exported var ErrCRCMismatch should have comment or be unexported (golint)
    • Line 23: warning: exported method Record.Validate should have comment or be unexported (golint)
    • etcdserver/v3demo_server.go
    • Line 40: warning: exported type RaftKV should have comment or be unexported (golint)
    • Line 49: warning: exported type Lessor should have comment or be unexported (golint)
    • Line 60: warning: exported type Authenticator should have comment or be unexported (golint)
    • Line 64: warning: exported method EtcdServer.Range should have comment or be unexported (golint)
    • Line 76: warning: exported method EtcdServer.Put should have comment or be unexported (golint)
    • Line 84: warning: exported method EtcdServer.DeleteRange should have comment or be unexported (golint)
    • Line 92: warning: exported method EtcdServer.Txn should have comment or be unexported (golint)
    • Line 100: warning: exported method EtcdServer.Compact should have comment or be unexported (golint)
    • Line 116: warning: exported method EtcdServer.Hash should have comment or be unexported (golint)
    • Line 124: warning: exported method EtcdServer.LeaseCreate should have comment or be unexported (golint)
    • Line 137: warning: exported method EtcdServer.LeaseRevoke should have comment or be unexported (golint)
    • Line 145: warning: exported method EtcdServer.LeaseRenew should have comment or be unexported (golint)
    • Line 180: warning: exported method EtcdServer.AuthEnable should have comment or be unexported (golint)
    • clientv3/watch.go
    • Line 28: warning: exported type WatchChan should have comment or be unexported (golint)
    • Line 30: warning: exported type Watcher should have comment or be unexported (golint)
    • Line 42: warning: exported type WatchResponse should have comment or be unexported (golint)
    • Line 126: warning: exported function NewWatcher should have comment or be unexported (golint)
    • pkg/transport/listener.go
    • Line 28: warning: exported function NewListener should have comment or be unexported (golint)
    • Line 55: warning: exported function NewTransport should have comment or be unexported (golint)
    • Line 75: warning: exported type TLSInfo should have comment or be unexported (golint)
    • Line 91: warning: exported method TLSInfo.Empty should have comment or be unexported (golint)
    • contrib/recipes/key.go
    • Line 27: warning: comment on exported type RemoteKV should be of the form "RemoteKV ..." (with optional leading article) (golint)
    • Line 35: warning: exported function NewKey should have comment or be unexported (golint)
    • Line 39: warning: exported function NewKV should have comment or be unexported (golint)
    • Line 47: warning: exported function GetRemoteKV should have comment or be unexported (golint)
    • Line 61: warning: exported function NewUniqueKey should have comment or be unexported (golint)
    • Line 65: warning: exported function NewUniqueKV should have comment or be unexported (golint)
    • Line 141: warning: exported method RemoteKV.Key should have comment or be unexported (golint)
    • Line 142: warning: exported method RemoteKV.Revision should have comment or be unexported (golint)
    • Line 143: warning: exported method RemoteKV.Value should have comment or be unexported (golint)
    • Line 145: warning: exported method RemoteKV.Delete should have comment or be unexported (golint)
    • Line 154: warning: exported method RemoteKV.Put should have comment or be unexported (golint)
    • tools/functional-tester/etcd-agent/rpc.go
    • Line 36: warning: exported method Agent.RPCStart should have comment or be unexported (golint)
    • Line 47: warning: exported method Agent.RPCStop should have comment or be unexported (golint)
    • Line 57: warning: exported method Agent.RPCRestart should have comment or be unexported (golint)
    • Line 68: warning: exported method Agent.RPCCleanup should have comment or be unexported (golint)
    • Line 78: warning: exported method Agent.RPCTerminate should have comment or be unexported (golint)
    • Line 87: warning: exported method Agent.RPCDropPort should have comment or be unexported (golint)
    • Line 96: warning: exported method Agent.RPCRecoverPort should have comment or be unexported (golint)
    • Line 105: warning: exported method Agent.RPCStatus should have comment or be unexported (golint)
    • etcdmain/etcd.go
    • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 78: warning: exported function Main should have comment or be unexported (golint)
    • contrib/recipes/queue.go
    • Line 31: warning: exported function NewQueue should have comment or be unexported (golint)
    • Line 35: warning: exported method Queue.Enqueue should have comment or be unexported (golint)
    • client/curl.go
    • Line 29: warning: exported function EnablecURLDebug should have comment or be unexported (golint)
    • Line 33: warning: exported function DisablecURLDebug should have comment or be unexported (golint)
    • client/client.go
    • Line 35: warning: exported var ErrNoEndpoints should have comment or be unexported (golint)
    • Line 42: warning: exported var DefaultRequestTimeout should have comment or be unexported (golint)
    • Line 44: warning: exported var DefaultTransport should have comment or be unexported (golint)
    • Line 53: warning: exported type EndpointSelectionMode should have comment or be unexported (golint)
    • Line 63: warning: comment on exported const EndpointSelectionPrioritizeLeader should be of the form "EndpointSelectionPrioritizeLeader ..." (golint)
    • Line 76: warning: exported type Config should have comment or be unexported (golint)
    • Line 161: warning: exported type CheckRedirectFunc should have comment or be unexported (golint)
    • Line 171: warning: exported type Client should have comment or be unexported (golint)
    • Line 204: warning: exported function New should have comment or be unexported (golint)
    • Line 304: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • lease/lessor.go
    • Line 41: warning: exported var ErrNotPrimary should have comment or be unexported (golint)
    • Line 46: warning: exported type LeaseID should have comment or be unexported (golint)
    • Line 148: warning: exported function NewLessor should have comment or be unexported (golint)
    • Line 423: warning: exported type Lease should have comment or be unexported (golint)
    • Line 471: warning: exported type LeaseItem should have comment or be unexported (golint)
    • Line 485: warning: exported method FakeLessor.SetRangeDeleter should have comment or be unexported (golint)
    • Line 487: warning: exported method FakeLessor.Grant should have comment or be unexported (golint)
    • Line 489: warning: exported method FakeLessor.Revoke should have comment or be unexported (golint)
    • Line 491: warning: exported method FakeLessor.Attach should have comment or be unexported (golint)
    • Line 493: warning: exported method FakeLessor.Detach should have comment or be unexported (golint)
    • Line 495: warning: exported method FakeLessor.Promote should have comment or be unexported (golint)
    • Line 497: warning: exported method FakeLessor.Demote should have comment or be unexported (golint)
    • Line 499: warning: exported method FakeLessor.Renew should have comment or be unexported (golint)
    • Line 501: warning: exported method FakeLessor.Lookup should have comment or be unexported (golint)
    • Line 501: warning: receiver name le should be consistent with previous receiver name fl for FakeLessor (golint)
    • Line 503: warning: exported method FakeLessor.ExpiredLeasesC should have comment or be unexported (golint)
    • Line 505: warning: exported method FakeLessor.Recover should have comment or be unexported (golint)
    • Line 507: warning: exported method FakeLessor.Stop should have comment or be unexported (golint)
    • pkg/mock/mockwait/wait_recorder.go
    • Line 22: warning: exported type WaitRecorder should have comment or be unexported (golint)
    • Line 31: warning: exported function NewRecorder should have comment or be unexported (golint)
    • Line 35: warning: exported function NewNop should have comment or be unexported (golint)
    • storage/key_index.go
    • Line 27: warning: exported var ErrRevisionNotFound should have comment or be unexported (golint)
    • Line 266: warning: receiver name a should be consistent with previous receiver name ki for keyIndex (golint)
    • Line 270: warning: receiver name a should be consistent with previous receiver name ki for keyIndex (golint)
    • Line 326: warning: receiver name a should be consistent with previous receiver name g for generation (golint)
    • raft/progress.go
    • Line 20: warning: exported const ProgressStateProbe should have comment (or a comment on this block) or be unexported (golint)
    • Line 25: warning: exported type ProgressStateType should have comment or be unexported (golint)
    • etcdserver/etcdhttp/httptypes/member.go
    • Line 25: warning: exported type Member should have comment or be unexported (golint)
    • Line 32: warning: exported type MemberCreateRequest should have comment or be unexported (golint)
    • Line 36: warning: exported type MemberUpdateRequest should have comment or be unexported (golint)
    • Line 40: warning: exported method MemberCreateRequest.UnmarshalJSON should have comment or be unexported (golint)
    • Line 59: warning: exported type MemberCollection should have comment or be unexported (golint)
    • Line 61: warning: exported method MemberCollection.MarshalJSON should have comment or be unexported (golint)
    • clientv3/client.go
    • Line 32: warning: exported var ErrNoAvailableEndpoints should have comment or be unexported (golint)
    • Line 57: warning: exported type Config should have comment or be unexported (golint)
    • etcdmain/config.go
    • Line 70: warning: exported var ErrConflictBootstrapFlags should have comment or be unexported (golint)
    • Line 133: warning: exported function NewConfig should have comment or be unexported (golint)
    • pkg/types/urls.go
    • Line 26: warning: exported type URLs should have comment or be unexported (golint)
    • Line 28: warning: exported function NewURLs should have comment or be unexported (golint)
    • Line 60: warning: exported method URLs.Sort should have comment or be unexported (golint)
    • Line 67: warning: exported method URLs.StringSlice should have comment or be unexported (golint)
    • storage/kvstore.go
    • Line 46: warning: exported var ErrTxnIDMismatch should have comment or be unexported (golint)
    • Line 363: warning: receiver name a should be consistent with previous receiver name s for store (golint)
    • clientv3/auth.go
    • Line 24: warning: exported type AuthEnableResponse should have comment or be unexported (golint)
    • Line 27: warning: exported type Auth should have comment or be unexported (golint)
    • Line 39: warning: exported function NewAuth should have comment or be unexported (golint)
    • etcdserver/stats/leader.go
    • Line 43: warning: exported method LeaderStats.JSON should have comment or be unexported (golint)
    • Line 55: warning: exported method LeaderStats.Follower should have comment or be unexported (golint)
    • etcdserver/api/v3rpc/key.go
    • Line 35: warning: comment on exported var MaxOpsPerTxn should be of the form "MaxOpsPerTxn ..." (golint)
    • Line 48: warning: exported function NewKVServer should have comment or be unexported (golint)
    • store/metrics.go
    • Line 85: warning: exported const GetRecursive should have comment (or a comment on this block) or be unexported (golint)
    • Line 96: warning: don't use underscores in Go names; func parameter read_action should be readAction (golint)
    • Line 100: warning: don't use underscores in Go names; func parameter read_action should be readAction (golint)
    • Line 105: warning: don't use underscores in Go names; func parameter write_action should be writeAction (golint)
    • Line 109: warning: don't use underscores in Go names; func parameter write_action should be writeAction (golint)
    • main.go
    • Line 23: warning: package comment is detached; there should be no blank lines between it and the package statement (golint)
    • etcdserver/stats/server.go
    • Line 56: warning: exported method ServerStats.JSON should have comment or be unexported (golint)
    • Line 144: warning: exported method ServerStats.BecomeLeader should have comment or be unexported (golint)
    • clientv3/concurrency/key.go
    • Line 1: warning: package comment should be of the form "Package concurrency ..." (golint)
    • Line 31: warning: exported function NewUniqueKV should have comment or be unexported (golint)
    • store/event.go
    • Line 18: warning: exported const Get should have comment (or a comment on this block) or be unexported (golint)
    • Line 28: warning: exported type Event should have comment or be unexported (golint)
    • Line 49: warning: exported method Event.IsCreated should have comment or be unexported (golint)
    • Line 56: warning: exported method Event.Index should have comment or be unexported (golint)
    • Line 60: warning: exported method Event.Clone should have comment or be unexported (golint)
    • Line 69: warning: exported method Event.SetRefresh should have comment or be unexported (golint)
    • store/node.go
    • Line 34: warning: exported var Permanent should have comment or be unexported (golint)
    • client/cluster_error.go
    • Line 19: warning: exported type ClusterError should have comment or be unexported (golint)
    • Line 27: warning: exported method ClusterError.Detail should have comment or be unexported (golint)
    • pkg/adt/interval_tree.go
    • Line 81: warning: receiver name n should be consistent with previous receiver name x for intervalNode (golint)
    • Line 156: warning: exported type IntervalValue should have comment or be unexported (golint)
    • Line 403: warning: comment on exported type IntervalVisitor should be of the form "IntervalVisitor ..." (with optional leading article) (golint)
    • Line 453: warning: exported type StringComparable should have comment or be unexported (golint)
    • Line 455: warning: exported method StringComparable.Compare should have comment or be unexported (golint)
    • Line 466: warning: exported function NewStringInterval should have comment or be unexported (golint)
    • Line 470: warning: exported function NewStringPoint should have comment or be unexported (golint)
    • Line 477: warning: exported method StringAffineComparable.Compare should have comment or be unexported (golint)
    • Line 499: warning: exported function NewStringAffineInterval should have comment or be unexported (golint)
    • Line 502: warning: exported function NewStringAffinePoint should have comment or be unexported (golint)
    • Line 506: warning: exported function NewInt64Interval should have comment or be unexported (golint)
    • Line 510: warning: exported function NewInt64Point should have comment or be unexported (golint)
    • Line 514: warning: exported type Int64Comparable should have comment or be unexported (golint)
    • Line 516: warning: exported method Int64Comparable.Compare should have comment or be unexported (golint)
    • etcdserver/etcdhttp/httptypes/errors.go
    • Line 28: warning: exported type HTTPError should have comment or be unexported (golint)
    • Line 38: warning: exported method HTTPError.WriteTo should have comment or be unexported (golint)
    • Line 51: warning: exported function NewHTTPError should have comment or be unexported (golint)
    • etcdserver/member.go
    • Line 49: warning: exported type Member should have comment or be unexported (golint)
    • Line 88: warning: exported method Member.Clone should have comment or be unexported (golint)
    • Line 109: warning: exported method Member.IsStarted should have comment or be unexported (golint)
    • Line 117: warning: exported function MemberAttributesStorePath should have comment or be unexported (golint)
    • etcdserver/api/v3rpc/member.go
    • Line 29: warning: exported type ClusterServer should have comment or be unexported (golint)
    • Line 35: warning: exported function NewClusterServer should have comment or be unexported (golint)
    • Line 43: warning: exported method ClusterServer.MemberAdd should have comment or be unexported (golint)
    • Line 67: warning: exported method ClusterServer.MemberRemove should have comment or be unexported (golint)
    • Line 81: warning: exported method ClusterServer.MemberUpdate should have comment or be unexported (golint)
    • Line 99: warning: exported method ClusterServer.MemberList should have comment or be unexported (golint)
    • wal/wal.go
    • Line 55: warning: exported var ErrMetadataConflict should have comment or be unexported (golint)
    • Line 449: warning: exported method WAL.Close should have comment or be unexported (golint)
    • Line 496: warning: exported method WAL.Save should have comment or be unexported (golint)
    • Line 531: warning: exported method WAL.SaveSnapshot should have comment or be unexported (golint)
    • store/stats.go
    • Line 23: warning: exported const SetSuccess should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: exported type Stats should have comment or be unexported (golint)
    • Line 113: warning: exported method Stats.Inc should have comment or be unexported (golint)
    • client/auth_role.go
    • Line 26: warning: exported type Role should have comment or be unexported (golint)
    • Line 33: warning: exported type Permissions should have comment or be unexported (golint)
    • Line 42: warning: exported type PermissionType should have comment or be unexported (golint)
    • Line 45: warning: exported const ReadPermission should have comment (or a comment on this block) or be unexported (golint)
    • Line 58: warning: exported type AuthRoleAPI should have comment or be unexported (golint)
    • pkg/mock/mockstore/store_recorder.go
    • Line 38: warning: exported function NewNop should have comment or be unexported (golint)
    • Line 39: warning: exported function NewRecorder should have comment or be unexported (golint)
    • Line 43: warning: exported function NewRecorderStream should have comment or be unexported (golint)
    • Line 137: warning: exported function NewErrRecorder should have comment or be unexported (golint)
    • compactor/compactor.go
    • Line 36: warning: exported type Compactable should have comment or be unexported (golint)
    • Line 40: warning: exported type RevGetter should have comment or be unexported (golint)
    • Line 44: warning: exported type Periodic should have comment or be unexported (golint)
    • Line 59: warning: exported function NewPeriodic should have comment or be unexported (golint)
    • Line 68: warning: exported method Periodic.Run should have comment or be unexported (golint)
    • Line 111: warning: exported method Periodic.Stop should have comment or be unexported (golint)
    • Line 115: warning: exported method Periodic.Pause should have comment or be unexported (golint)
    • Line 121: warning: exported method Periodic.Resume should have comment or be unexported (golint)
    • snap/message.go
    • Line 37: warning: exported function NewMessage should have comment or be unexported (golint)
    • Line 52: warning: exported method Message.CloseWithError should have comment or be unexported (golint)
    • rafthttp/transport.go
    • Line 36: warning: exported type Raft should have comment or be unexported (golint)
    • Line 43: warning: exported type Transporter should have comment or be unexported (golint)
    • Line 126: warning: exported method Transport.Start should have comment or be unexported (golint)
    • Line 142: warning: exported method Transport.Handler should have comment or be unexported (golint)
    • Line 154: warning: exported method Transport.Get should have comment or be unexported (golint)
    • Line 160: warning: exported method Transport.Send should have comment or be unexported (golint)
    • Line 190: warning: exported method Transport.Stop should have comment or be unexported (golint)
    • Line 208: warning: exported method Transport.AddRemote should have comment or be unexported (golint)
    • Line 224: warning: exported method Transport.AddPeer should have comment or be unexported (golint)
    • Line 239: warning: exported method Transport.RemovePeer should have comment or be unexported (golint)
    • Line 245: warning: exported method Transport.RemoveAllPeers should have comment or be unexported (golint)
    • Line 265: warning: exported method Transport.UpdatePeer should have comment or be unexported (golint)
    • Line 282: warning: exported method Transport.ActiveSince should have comment or be unexported (golint)
    • Line 291: warning: exported method Transport.SendSnapshot should have comment or be unexported (golint)
    • Line 308: warning: exported method Transport.Pause should have comment or be unexported (golint)
    • Line 314: warning: exported method Transport.Resume should have comment or be unexported (golint)
    • Line 322: warning: exported function NewNopTransporter should have comment or be unexported (golint)
    • Line 346: warning: exported function NewSnapTransporter should have comment or be unexported (golint)
    • etcdserver/auth/auth_test.go
    • Line 31: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 373: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 377: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • clientv3/op.go
    • Line 80: warning: exported function OpGet should have comment or be unexported (golint)
    • Line 86: warning: exported function OpDelete should have comment or be unexported (golint)
    • Line 104: warning: exported function OpPut should have comment or be unexported (golint)
    • raft/util.go
    • Line 24: warning: exported method StateType.MarshalJSON should have comment or be unexported (golint)
    • Line 49: warning: exported function IsLocalMsg should have comment or be unexported (golint)
    • Line 53: warning: exported function IsResponseMsg should have comment or be unexported (golint)
    • store/store.go
    • Line 40: warning: exported type Store should have comment or be unexported (golint)
    • Line 66: warning: exported type TTLOptionSet should have comment or be unexported (golint)
    • Line 218: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • pkg/flags/urls.go
    • Line 23: warning: exported type URLsValue should have comment or be unexported (golint)
    • Line 46: warning: exported function NewURLsValue should have comment or be unexported (golint)
    • etcdctl/command/util.go
    • Line 38: warning: exported var ErrNoAvailSrc should have comment or be unexported (golint)
    • Line 343: warning: context.Context should be the first parameter of a function (golint)
    • version/version.go
    • Line 32: warning: exported var Version should have comment or be unexported (golint)
    • Line 34: warning: comment on exported var GitSHA should be of the form "GitSHA ..." (golint)
    • Line 42: warning: exported const DataDirUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 48: warning: exported type Versions should have comment or be unexported (golint)
    • Line 54: warning: exported function DetectDataDir should have comment or be unexported (golint)
    • clientv3/lease.go
    • Line 27: warning: exported type LeaseCreateResponse should have comment or be unexported (golint)
    • Line 28: warning: exported type LeaseRevokeResponse should have comment or be unexported (golint)
    • Line 29: warning: exported type LeaseKeepAliveResponse should have comment or be unexported (golint)
    • Line 30: warning: exported type LeaseID should have comment or be unexported (golint)
    • Line 40: warning: exported type Lease should have comment or be unexported (golint)
    • Line 89: warning: exported function NewLease should have comment or be unexported (golint)
    • Line 198: warning: context.Context should be the first parameter of a function (golint)
    • client/auth_user.go
    • Line 31: warning: exported type User should have comment or be unexported (golint)
    • Line 45: warning: exported type UserRoles should have comment or be unexported (golint)
    • Line 71: warning: exported type AuthAPI should have comment or be unexported (golint)
    • Line 134: warning: exported type AuthUserAPI should have comment or be unexported (golint)
    • client/keys.go
    • Line 35: warning: exported const ErrorCodeKeyNotFound should have comment (or a comment on this block) or be unexported (golint)
    • Line 57: warning: exported type Error should have comment or be unexported (golint)
    • Line 69: warning: exported var ErrInvalidJSON should have comment or be unexported (golint)
    • Line 78: warning: exported const PrevIgnore should have comment (or a comment on this block) or be unexported (golint)
    • Line 103: warning: exported type KeysAPI should have comment or be unexported (golint)
    • Line 133: warning: exported type WatcherOptions should have comment or be unexported (golint)
    • Line 150: warning: exported type CreateInOrderOptions should have comment or be unexported (golint)
    • Line 158: warning: exported type SetOptions should have comment or be unexported (golint)
    • Line 196: warning: exported type GetOptions should have comment or be unexported (golint)
    • Line 214: warning: exported type DeleteOptions should have comment or be unexported (golint)
    • Line 240: warning: exported type Watcher should have comment or be unexported (golint)
    • Line 254: warning: exported type Response should have comment or be unexported (golint)
    • Line 273: warning: exported type Node should have comment or be unexported (golint)
    • Line 311: warning: exported type Nodes should have comment or be unexported (golint)
    • pkg/pbutil/pbutil.go
    • Line 24: warning: exported type Marshaler should have comment or be unexported (golint)
    • Line 28: warning: exported type Unmarshaler should have comment or be unexported (golint)
    • Line 32: warning: exported function MustMarshal should have comment or be unexported (golint)
    • Line 40: warning: exported function MustUnmarshal should have comment or be unexported (golint)
    • Line 46: warning: exported function MaybeUnmarshal should have comment or be unexported (golint)
    • Line 53: warning: exported function GetBool should have comment or be unexported (golint)
    • Line 60: warning: exported function Boolp should have comment or be unexported (golint)
    • snap/snapshotter.go
    • Line 45: warning: exported var ErrNoSnapshot should have comment or be unexported (golint)
    • Line 51: warning: exported type Snapshotter should have comment or be unexported (golint)
    • Line 55: warning: exported function New should have comment or be unexported (golint)
    • Line 61: warning: exported method Snapshotter.SaveSnap should have comment or be unexported (golint)
    • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 94: warning: exported method Snapshotter.Load should have comment or be unexported (golint)
    • storage/backend/backend.go
    • Line 44: warning: exported type Backend should have comment or be unexported (golint)
    • Line 55: warning: exported type Snapshot should have comment or be unexported (golint)
    • Line 84: warning: exported function New should have comment or be unexported (golint)
    • Line 88: warning: exported function NewDefaultBackend should have comment or be unexported (golint)
    • Line 311: warning: exported function NewDefaultTmpBackend should have comment or be unexported (golint)
    • store/node_extern.go
    • Line 74: warning: exported method NodeExtern.Clone should have comment or be unexported (golint)
    • Line 102: warning: exported type NodeExterns should have comment or be unexported (golint)
    • etcdserver/api/v3rpc/lease.go
    • Line 27: warning: exported type LeaseServer should have comment or be unexported (golint)
    • Line 31: warning: exported function NewLeaseServer should have comment or be unexported (golint)
    • Line 35: warning: exported method LeaseServer.LeaseCreate should have comment or be unexported (golint)
    • Line 43: warning: exported method LeaseServer.LeaseRevoke should have comment or be unexported (golint)
    • Line 51: warning: exported method LeaseServer.LeaseKeepAlive should have comment or be unexported (golint)
    • etcdctlv3/command/error.go
    • Line 25: warning: comment on exported const ExitSuccess should be of the form "ExitSuccess ..." (golint)
    • Line 27: warning: exported const ExitError should have comment (or a comment on this block) or be unexported (golint)
    • Line 36: warning: exported function ExitWithError should have comment or be unexported (golint)
    • pkg/fileutil/lock_unix.go
    • Line 26: warning: exported var ErrLocked should have comment or be unexported (golint)
    • Line 58: warning: exported function NewLock should have comment or be unexported (golint)
    • clientv3/txn.go
    • Line 24: warning: comment on exported type Txn should be of the form "Txn ..." (with optional leading article) (golint)
    • client/members.go
    • Line 35: warning: exported type Member should have comment or be unexported (golint)
    • Line 97: warning: exported type MembersAPI should have comment or be unexported (golint)
    • pkg/logutil/merge_logger.go
    • Line 87: warning: exported function NewMergeLogger should have comment or be unexported (golint)
    • Line 96: warning: exported method MergeLogger.MergeInfo should have comment or be unexported (golint)
    • Line 103: warning: exported method MergeLogger.MergeInfof should have comment or be unexported (golint)
    • Line 110: warning: exported method MergeLogger.MergeNotice should have comment or be unexported (golint)
    • Line 117: warning: exported method MergeLogger.MergeNoticef should have comment or be unexported (golint)
    • Line 124: warning: exported method MergeLogger.MergeWarning should have comment or be unexported (golint)
    • Line 131: warning: exported method MergeLogger.MergeWarningf should have comment or be unexported (golint)
    • Line 138: warning: exported method MergeLogger.MergeError should have comment or be unexported (golint)
    • Line 145: warning: exported method MergeLogger.MergeErrorf should have comment or be unexported (golint)
    • etcdctlv3/command/printer.go
    • Line 40: warning: exported function NewPrinter should have comment or be unexported (golint)
    • Line 172: warning: receiver name pb should be consistent with previous receiver name p for pbPrinter (golint)
    • storage/index.go
    • Line 198: warning: receiver name a should be consistent with previous receiver name ti for treeIndex (golint)
    • clientv3/kv.go
    • Line 26: warning: exported type PutResponse should have comment or be unexported (golint)
    • Line 27: warning: exported type GetResponse should have comment or be unexported (golint)
    • Line 28: warning: exported type DeleteResponse should have comment or be unexported (golint)
    • Line 29: warning: exported type TxnResponse should have comment or be unexported (golint)
    • Line 32: warning: exported type KV should have comment or be unexported (golint)
    • Line 71: warning: exported type OpResponse should have comment or be unexported (golint)
    • Line 85: warning: exported function NewKV should have comment or be unexported (golint)
    • etcdserver/errors.go
    • Line 25: warning: exported var ErrUnknownMethod should have comment or be unexported (golint)
    • Line 45: warning: exported type DiscoveryError should have comment or be unexported (golint)
    • store/watcher.go
    • Line 17: warning: exported type Watcher should have comment or be unexported (golint)
    • Line 92: warning: exported function NewNopWatcher should have comment or be unexported (golint)
    • pkg/crc/crc.go
    • Line 14: warning: comment on exported const Size should be of the form "Size ..." (golint)
    • pkg/flags/flag.go
    • Line 39: warning: exported method DeprecatedFlag.Set should have comment or be unexported (golint)
    • Line 59: warning: exported method IgnoredFlag.Set should have comment or be unexported (golint)
    • Line 168: warning: exported function IsSet should have comment or be unexported (golint)
    • pkg/types/set.go
    • Line 23: warning: exported type Set should have comment or be unexported (golint)
    • Line 34: warning: exported function NewUnsafeSet should have comment or be unexported (golint)
    • Line 42: warning: exported function NewThreadsafeSet should have comment or be unexported (golint)
    • storage/watcher.go
    • Line 25: warning: exported var ErrWatcherNotExist should have comment or be unexported (golint)
    • Line 28: warning: exported type WatchID should have comment or be unexported (golint)
    • Line 30: warning: exported type WatchStream should have comment or be unexported (golint)
    • Line 64: warning: exported type WatchResponse should have comment or be unexported (golint)
    • pkg/wait/wait_time.go
    • Line 22: warning: exported type WaitTime should have comment or be unexported (golint)
    • Line 38: warning: exported function NewTimeList should have comment or be unexported (golint)
    • pkg/testutil/recorder.go
    • Line 24: warning: exported type Action should have comment or be unexported (golint)
    • Line 29: warning: exported type Recorder should have comment or be unexported (golint)
    • Line 47: warning: exported method RecorderBuffered.Record should have comment or be unexported (golint)
    • Line 52: warning: exported method RecorderBuffered.Action should have comment or be unexported (golint)
    • Line 59: warning: exported method RecorderBuffered.Wait should have comment or be unexported (golint)
    • Line 69: warning: exported method RecorderBuffered.Chan should have comment or be unexported (golint)
    • Line 86: warning: exported function NewRecorderStream should have comment or be unexported (golint)
    • etcdserver/auth/auth.go
    • Line 76: warning: exported type Store should have comment or be unexported (golint)
    • Line 94: warning: exported type PasswordStore should have comment or be unexported (golint)
    • Line 107: warning: exported type User should have comment or be unexported (golint)
    • Line 115: warning: exported type Role should have comment or be unexported (golint)
    • Line 122: warning: exported type Permissions should have comment or be unexported (golint)
    • Line 126: warning: exported method Permissions.IsEmpty should have comment or be unexported (golint)
    • Line 130: warning: exported type RWPermission should have comment or be unexported (golint)
    • Line 135: warning: exported type Error should have comment or be unexported (golint)
    • Line 141: warning: exported method Error.HTTPStatus should have comment or be unexported (golint)
    • Line 147: warning: exported function NewStore should have comment or be unexported (golint)
    • Line 159: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 164: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 504: warning: exported method Role.HasKeyAccess should have comment or be unexported (golint)
    • Line 511: warning: exported method Role.HasRecursiveAccess should have comment or be unexported (golint)
    • Line 594: warning: exported method RWPermission.HasAccess should have comment or be unexported (golint)
    • Line 610: warning: exported method RWPermission.HasRecursiveAccess should have comment or be unexported (golint)
    • integration/cluster.go
    • Line 1: warning: package comment should be of the form "Package integration ..." (golint)
    • Line 68: warning: exported type ClusterConfig should have comment or be unexported (golint)
    • Line 699: warning: exported type SortableMemberSliceByPeerURLs should have comment or be unexported (golint)
    • Line 707: warning: exported type ClusterV3 should have comment or be unexported (golint)
    • Line 729: warning: exported method ClusterV3.Terminate should have comment or be unexported (golint)
    • Line 738: warning: exported method ClusterV3.RandClient should have comment or be unexported (golint)
    • Line 742: warning: exported method ClusterV3.Client should have comment or be unexported (golint)
    • raft/logger.go
    • Line 24: warning: exported type Logger should have comment or be unexported (golint)
    • Line 44: warning: exported function SetLogger should have comment or be unexported (golint)
    • Line 62: warning: exported method DefaultLogger.EnableTimestamps should have comment or be unexported (golint)
    • Line 66: warning: exported method DefaultLogger.EnableDebug should have comment or be unexported (golint)
    • Line 70: warning: exported method DefaultLogger.Debug should have comment or be unexported (golint)
    • Line 76: warning: exported method DefaultLogger.Debugf should have comment or be unexported (golint)
    • Line 82: warning: exported method DefaultLogger.Info should have comment or be unexported (golint)
    • Line 86: warning: exported method DefaultLogger.Infof should have comment or be unexported (golint)
    • Line 94: warning: exported method DefaultLogger.Errorf should have comment or be unexported (golint)
    • Line 98: warning: exported method DefaultLogger.Warning should have comment or be unexported (golint)
    • Line 102: warning: exported method DefaultLogger.Warningf should have comment or be unexported (golint)
    • Line 106: warning: exported method DefaultLogger.Fatal should have comment or be unexported (golint)
    • Line 111: warning: exported method DefaultLogger.Fatalf should have comment or be unexported (golint)
    • Line 116: warning: exported method DefaultLogger.Panic should have comment or be unexported (golint)
    • Line 120: warning: exported method DefaultLogger.Panicf should have comment or be unexported (golint)
    • raft/node.go
    • Line 24: warning: exported type SnapshotStatus should have comment or be unexported (golint)
    • Line 27: warning: exported const SnapshotFinish should have comment (or a comment on this block) or be unexported (golint)
    • Line 164: warning: exported type Peer should have comment or be unexported (golint)
    • rafthttp/peer.go
    • Line 38: warning: exported const ConnWriteTimeout should have comment (or a comment on this block) or be unexported (golint)
    • Line 55: warning: exported type Peer should have comment or be unexported (golint)
    • contrib/recipes/rwmutex.go
    • Line 23: warning: exported type RWMutex should have comment or be unexported (golint)
    • Line 31: warning: exported function NewRWMutex should have comment or be unexported (golint)
    • Line 35: warning: exported method RWMutex.RLock should have comment or be unexported (golint)
    • Line 55: warning: exported method RWMutex.Lock should have comment or be unexported (golint)
    • Line 98: warning: exported method RWMutex.RUnlock should have comment or be unexported (golint)
    • Line 99: warning: exported method RWMutex.Unlock should have comment or be unexported (golint)
    • clientv3/cluster.go
    • Line 26: warning: exported type Member should have comment or be unexported (golint)
    • Line 27: warning: exported type MemberListResponse should have comment or be unexported (golint)
    • Line 28: warning: exported type MemberAddResponse should have comment or be unexported (golint)
    • Line 29: warning: exported type MemberRemoveResponse should have comment or be unexported (golint)
    • Line 30: warning: exported type MemberUpdateResponse should have comment or be unexported (golint)
    • Line 33: warning: exported type Cluster should have comment or be unexported (golint)
    • Line 58: warning: exported function NewCluster should have comment or be unexported (golint)
    • clientv3/concurrency/mutex.go
    • Line 33: warning: exported function NewMutex should have comment or be unexported (golint)
    • Line 57: warning: exported method Mutex.Unlock should have comment or be unexported (golint)
    • Line 66: warning: exported method Mutex.IsOwner should have comment or be unexported (golint)
    • Line 70: warning: exported method Mutex.Key should have comment or be unexported (golint)
    • error/error.go
    • Line 15: warning: package comment should be of the form "Package error ..." (golint)
    • Line 81: warning: exported const EcodeKeyNotFound should have comment (or a comment on this block) or be unexported (golint)
    • Line 119: warning: exported type Error should have comment or be unexported (golint)
    • Line 126: warning: exported function NewRequestError should have comment or be unexported (golint)
    • Line 130: warning: exported function NewError should have comment or be unexported (golint)
    • Line 149: warning: exported method Error.StatusCode should have comment or be unexported (golint)
    • Line 157: warning: exported method Error.WriteTo should have comment or be unexported (golint)
    • pkg/testutil/pauseable_handler.go
    • Line 22: warning: exported type PauseableHandler should have comment or be unexported (golint)
    • Line 47: warning: exported method PauseableHandler.Pause should have comment or be unexported (golint)
    • Line 53: warning: exported method PauseableHandler.Resume should have comment or be unexported (golint)
    • etcdserver/config.go
    • Line 117: warning: exported method ServerConfig.MemberDir should have comment or be unexported (golint)
    • Line 119: warning: exported method ServerConfig.WALDir should have comment or be unexported (golint)
    • Line 126: warning: exported method ServerConfig.SnapDir should have comment or be unexported (golint)
    • Line 128: warning: exported method ServerConfig.ShouldDiscover should have comment or be unexported (golint)
    • Line 147: warning: exported method ServerConfig.PrintWithInitial should have comment or be unexported (golint)
    • Line 149: warning: exported method ServerConfig.Print should have comment or be unexported (golint)
    • etcdserver/storage.go
    • Line 32: warning: exported type Storage should have comment or be unexported (golint)
    • Line 50: warning: exported function NewStorage should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!