Preparing report...

Report for github.com/curoverse/arvados

A+    Excellent!    Found 145 issues across 406 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint74%

Golint is a linter for Go source code.

    • arvados/lib/controller/localdb/conn.go
    • Line 19: warning: exported type Conn should have comment or be unexported (golint)
    • Line 25: warning: exported function NewConn should have comment or be unexported (golint)
    • Line 52: warning: exported method Conn.GroupContents should have comment or be unexported (golint)
    • arvados/lib/selfsigned/cert.go
    • Line 19: warning: exported type CertGenerator should have comment or be unexported (golint)
    • Line 25: warning: exported method CertGenerator.Generate should have comment or be unexported (golint)
    • arvados/sdk/go/blockdigest/blockdigest.go
    • Line 15: warning: exported var LocatorPattern should have comment or be unexported (golint)
    • Line 25: warning: exported type DigestWithSize should have comment or be unexported (golint)
    • Line 30: warning: exported type BlockLocator should have comment or be unexported (golint)
    • Line 64: warning: exported function IsBlockLocator should have comment or be unexported (golint)
    • Line 68: warning: exported function ParseBlockLocator should have comment or be unexported (golint)
    • arvados/sdk/go/keepclient/root_sorter.go
    • Line 11: warning: exported type RootSorter should have comment or be unexported (golint)
    • Line 17: warning: exported function NewRootSorter should have comment or be unexported (golint)
    • Line 41: warning: exported method RootSorter.GetSortedRoots should have comment or be unexported (golint)
    • arvados/lib/cmd/cmd.go
    • Line 21: warning: exported type Handler should have comment or be unexported (golint)
    • Line 25: warning: exported type HandlerFunc should have comment or be unexported (golint)
    • Line 27: warning: exported method HandlerFunc.RunCommand should have comment or be unexported (golint)
    • Line 66: warning: exported method Multi.RunCommand should have comment or be unexported (golint)
    • Line 97: warning: exported method Multi.Usage should have comment or be unexported (golint)
    • Line 124: warning: exported type FlagSet should have comment or be unexported (golint)
    • arvados/lib/costanalyzer/cmd.go
    • Line 15: warning: exported var Command should have comment or be unexported (golint)
    • Line 19: warning: exported type NoPrefixFormatter should have comment or be unexported (golint)
    • Line 21: warning: exported method NoPrefixFormatter.Format should have comment or be unexported (golint)
    • arvados/lib/controller/handler.go
    • Line 33: warning: exported type Handler should have comment or be unexported (golint)
    • Line 70: warning: exported method Handler.CheckHealth should have comment or be unexported (golint)
    • Line 80: warning: exported method Handler.Done should have comment or be unexported (golint)
    • arvados/sdk/go/httpserver/error.go
    • Line 12: warning: exported function ErrorWithStatus should have comment or be unexported (golint)
    • Line 25: warning: exported type ErrorResponse should have comment or be unexported (golint)
    • Line 29: warning: exported function Error should have comment or be unexported (golint)
    • Line 33: warning: exported function Errors should have comment or be unexported (golint)
    • arvados/sdk/go/arvadostest/oidc_provider.go
    • Line 23: warning: exported type OIDCProvider should have comment or be unexported (golint)
    • Line 42: warning: exported function NewOIDCProvider should have comment or be unexported (golint)
    • Line 53: warning: exported method OIDCProvider.ValidAccessToken should have comment or be unexported (golint)
    • arvados/services/keepproxy/keepproxy.go
    • Line 170: warning: exported type APITokenCache should have comment or be unexported (golint)
    • Line 219: warning: exported function CheckAuthorizationHeader should have comment or be unexported (golint)
    • Line 338: warning: exported function SetCorsHeaders should have comment or be unexported (golint)
    • Line 345: warning: exported type InvalidPathHandler should have comment or be unexported (golint)
    • arvados/services/keepstore/volume.go
    • Line 20: warning: exported type BlockWriter should have comment or be unexported (golint)
    • Line 26: warning: exported type BlockReader should have comment or be unexported (golint)
    • Line 349: warning: exported method RRVolumeManager.Mounts should have comment or be unexported (golint)
    • Line 353: warning: exported method RRVolumeManager.Lookup should have comment or be unexported (golint)
    • Line 408: warning: exported type InternalStatser should have comment or be unexported (golint)
    • arvados/lib/dispatchcloud/test/queue.go
    • Line 60: warning: exported method Queue.Forget should have comment or be unexported (golint)
    • Line 66: warning: exported method Queue.Lock should have comment or be unexported (golint)
    • Line 72: warning: exported method Queue.Unlock should have comment or be unexported (golint)
    • Line 78: warning: exported method Queue.Cancel should have comment or be unexported (golint)
    • Line 84: warning: exported method Queue.Subscribe should have comment or be unexported (golint)
    • Line 95: warning: exported method Queue.Unsubscribe should have comment or be unexported (golint)
    • arvados/lib/dispatchcloud/test/stub_driver.go
    • Line 98: warning: exported type StubInstanceSet should have comment or be unexported (golint)
    • Line 110: warning: exported method StubInstanceSet.Create should have comment or be unexported (golint)
    • Line 150: warning: exported method StubInstanceSet.Instances should have comment or be unexported (golint)
    • Line 164: warning: exported method StubInstanceSet.Stop should have comment or be unexported (golint)
    • Line 173: warning: exported type RateLimitError should have comment or be unexported (golint)
    • Line 176: warning: exported method RateLimitError.EarliestRetry should have comment or be unexported (golint)
    • Line 219: warning: exported method StubVM.Instance should have comment or be unexported (golint)
    • Line 235: warning: exported method StubVM.Exec should have comment or be unexported (golint)
    • arvados/lib/install/deps.go
    • Line 29: warning: exported var Command should have comment or be unexported (golint)
    • Line 659: warning: exported function ProductionDependencies should have comment or be unexported (golint)
    • arvados/sdk/go/arvados/client.go
    • Line 418: warning: exported type Resource should have comment or be unexported (golint)
    • Line 422: warning: exported type ResourceMethod should have comment or be unexported (golint)
    • Line 428: warning: exported type MethodResponse should have comment or be unexported (golint)
    • Line 432: warning: exported type Schema should have comment or be unexported (golint)
    • Line 475: warning: exported method Client.KindForUUID should have comment or be unexported (golint)
    • Line 487: warning: exported method Client.PathForUUID should have comment or be unexported (golint)
    • arvados/lib/cli/external.go
    • Line 19: warning: exported var Create should have comment or be unexported (golint)
    • Line 33: warning: comment on exported var APICall should be of the form "APICall ..." (golint)
    • arvados/lib/controller/rpc/conn.go
    • Line 31: warning: exported type TokenProvider should have comment or be unexported (golint)
    • Line 33: warning: exported function PassthroughTokenProvider should have comment or be unexported (golint)
    • Line 41: warning: exported type Conn should have comment or be unexported (golint)
    • Line 51: warning: exported function NewConn should have comment or be unexported (golint)
    • Line 162: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 170: warning: exported method Conn.BaseURL should have comment or be unexported (golint)
    • Line 174: warning: exported method Conn.ConfigGet should have comment or be unexported (golint)
    • Line 181: warning: exported method Conn.Login should have comment or be unexported (golint)
    • Line 189: warning: exported method Conn.Logout should have comment or be unexported (golint)
    • Line 212: warning: exported method Conn.CollectionCreate should have comment or be unexported (golint)
    • Line 219: warning: exported method Conn.CollectionUpdate should have comment or be unexported (golint)
    • Line 226: warning: exported method Conn.CollectionGet should have comment or be unexported (golint)
    • Line 233: warning: exported method Conn.CollectionList should have comment or be unexported (golint)
    • Line 240: warning: exported method Conn.CollectionProvenance should have comment or be unexported (golint)
    • Line 247: warning: exported method Conn.CollectionUsedBy should have comment or be unexported (golint)
    • Line 254: warning: exported method Conn.CollectionDelete should have comment or be unexported (golint)
    • Line 261: warning: exported method Conn.CollectionTrash should have comment or be unexported (golint)
    • Line 268: warning: exported method Conn.CollectionUntrash should have comment or be unexported (golint)
    • Line 275: warning: exported method Conn.ContainerCreate should have comment or be unexported (golint)
    • Line 282: warning: exported method Conn.ContainerUpdate should have comment or be unexported (golint)
    • Line 289: warning: exported method Conn.ContainerGet should have comment or be unexported (golint)
    • Line 296: warning: exported method Conn.ContainerList should have comment or be unexported (golint)
    • Line 303: warning: exported method Conn.ContainerDelete should have comment or be unexported (golint)
    • Line 310: warning: exported method Conn.ContainerLock should have comment or be unexported (golint)
    • Line 317: warning: exported method Conn.ContainerUnlock should have comment or be unexported (golint)
    • Line 400: warning: exported method Conn.ContainerRequestCreate should have comment or be unexported (golint)
    • Line 407: warning: exported method Conn.ContainerRequestUpdate should have comment or be unexported (golint)
    • Line 414: warning: exported method Conn.ContainerRequestGet should have comment or be unexported (golint)
    • Line 421: warning: exported method Conn.ContainerRequestList should have comment or be unexported (golint)
    • Line 428: warning: exported method Conn.ContainerRequestDelete should have comment or be unexported (golint)
    • Line 435: warning: exported method Conn.GroupCreate should have comment or be unexported (golint)
    • Line 442: warning: exported method Conn.GroupUpdate should have comment or be unexported (golint)
    • Line 449: warning: exported method Conn.GroupGet should have comment or be unexported (golint)
    • Line 456: warning: exported method Conn.GroupList should have comment or be unexported (golint)
    • Line 463: warning: exported method Conn.GroupContents should have comment or be unexported (golint)
    • Line 470: warning: exported method Conn.GroupShared should have comment or be unexported (golint)
    • Line 477: warning: exported method Conn.GroupDelete should have comment or be unexported (golint)
    • Line 484: warning: exported method Conn.GroupTrash should have comment or be unexported (golint)
    • Line 491: warning: exported method Conn.GroupUntrash should have comment or be unexported (golint)
    • Line 498: warning: exported method Conn.SpecimenCreate should have comment or be unexported (golint)
    • Line 505: warning: exported method Conn.SpecimenUpdate should have comment or be unexported (golint)
    • Line 512: warning: exported method Conn.SpecimenGet should have comment or be unexported (golint)
    • Line 519: warning: exported method Conn.SpecimenList should have comment or be unexported (golint)
    • Line 526: warning: exported method Conn.SpecimenDelete should have comment or be unexported (golint)
    • Line 533: warning: exported method Conn.UserCreate should have comment or be unexported (golint)
    • Line 539: warning: exported method Conn.UserUpdate should have comment or be unexported (golint)
    • Line 545: warning: exported method Conn.UserUpdateUUID should have comment or be unexported (golint)
    • Line 551: warning: exported method Conn.UserMerge should have comment or be unexported (golint)
    • Line 557: warning: exported method Conn.UserActivate should have comment or be unexported (golint)
    • Line 563: warning: exported method Conn.UserSetup should have comment or be unexported (golint)
    • Line 569: warning: exported method Conn.UserUnsetup should have comment or be unexported (golint)
    • Line 575: warning: exported method Conn.UserGet should have comment or be unexported (golint)
    • Line 581: warning: exported method Conn.UserGetCurrent should have comment or be unexported (golint)
    • Line 587: warning: exported method Conn.UserGetSystem should have comment or be unexported (golint)
    • Line 593: warning: exported method Conn.UserList should have comment or be unexported (golint)
    • Line 599: warning: exported method Conn.UserDelete should have comment or be unexported (golint)
    • Line 606: warning: exported method Conn.APIClientAuthorizationCurrent should have comment or be unexported (golint)
    • Line 613: warning: exported type UserSessionAuthInfo should have comment or be unexported (golint)
    • Line 623: warning: exported type UserSessionCreateOptions should have comment or be unexported (golint)
    • Line 628: warning: exported method Conn.UserSessionCreate should have comment or be unexported (golint)
    • Line 635: warning: exported method Conn.UserBatchUpdate should have comment or be unexported (golint)
    • Line 642: warning: exported method Conn.UserAuthenticate should have comment or be unexported (golint)
    • arvados/sdk/go/manifest/manifest.go
    • Line 22: warning: exported var ErrInvalidToken should have comment or be unexported (golint)
    • Line 24: warning: exported type Manifest should have comment or be unexported (golint)
    • Line 29: warning: exported type BlockLocator should have comment or be unexported (golint)
    • Line 83: warning: exported function EscapeName should have comment or be unexported (golint)
    • Line 97: warning: exported function UnescapeName should have comment or be unexported (golint)
    • Line 101: warning: exported function ParseBlockLocator should have comment or be unexported (golint)
    • Line 146: warning: exported method ManifestStream.FileSegmentIterByName should have comment or be unexported (golint)
    • Line 495: warning: exported method Manifest.StreamIter should have comment or be unexported (golint)
    • Line 517: warning: exported method Manifest.FileSegmentIterByName should have comment or be unexported (golint)
    • arvados/sdk/go/keepclient/block_cache.go
    • Line 16: warning: exported var DefaultBlockCache should have comment or be unexported (golint)
    • Line 18: warning: exported type BlockCache should have comment or be unexported (golint)
    • Line 119: warning: exported method BlockCache.Clear should have comment or be unexported (golint)
    • arvados/sdk/go/keepclient/keepclient.go
    • Line 33: warning: exported var DefaultRequestTimeout should have comment or be unexported (golint)
    • Line 71: warning: exported type InsufficientReplicasError should have comment or be unexported (golint)
    • Line 73: warning: exported type OversizeBlockError should have comment or be unexported (golint)
    • Line 75: warning: exported var ErrOversizeBlock should have comment or be unexported (golint)
    • Line 76: warning: error var MissingArvadosApiHost should have name of the form ErrFoo (golint)
    • Line 76: warning: exported var MissingArvadosApiHost should have comment or be unexported (golint)
    • Line 77: warning: error var MissingArvadosApiToken should have name of the form ErrFoo (golint)
    • Line 77: warning: exported var MissingArvadosApiToken should have comment or be unexported (golint)
    • Line 78: warning: error var InvalidLocatorError should have name of the form ErrFoo (golint)
    • Line 78: warning: exported var InvalidLocatorError should have comment or be unexported (golint)
    • Line 87: warning: exported const XKeepDesiredReplicas should have comment (or a comment on this block) or be unexported (golint)
    • Line 93: warning: exported type HTTPClient should have comment or be unexported (golint)
    • Line 100: warning: don't use underscores in Go names; struct field Want_replicas should be WantReplicas (golint)
    • Line 504: warning: exported method KeepClient.ClearBlockCache should have comment or be unexported (golint)
    • Line 586: warning: exported type Locator should have comment or be unexported (golint)
    • Line 602: warning: exported function MakeLocator should have comment or be unexported (golint)
    • arvados/lib/cli/flags.go
    • Line 14: warning: exported type LegacyFlagValues should have comment or be unexported (golint)
    • Line 21: warning: exported function LegacyFlagSet should have comment or be unexported (golint)
    • arvados/lib/dispatchcloud/worker/verify.go
    • Line 24: warning: exported type TagVerifier should have comment or be unexported (golint)
    • Line 30: warning: exported method TagVerifier.InitCommand should have comment or be unexported (golint)
    • Line 34: warning: exported method TagVerifier.VerifyHostKey should have comment or be unexported (golint)
    • arvados/sdk/go/arvados/container.go
    • Line 127: warning: exported const ContainerStateQueued should have comment (or a comment on this block) or be unexported (golint)
    • Line 138: warning: exported const ContainerRequestStateUncomitted should have comment (or a comment on this block) or be unexported (golint)
    • arvados/lib/cloud/interfaces.go
    • Line 39: warning: exported type SharedResourceTags should have comment or be unexported (golint)
    • Line 40: warning: exported type InstanceSetID should have comment or be unexported (golint)
    • Line 41: warning: exported type InstanceTags should have comment or be unexported (golint)
    • Line 42: warning: exported type InstanceID should have comment or be unexported (golint)
    • Line 43: warning: exported type ImageID should have comment or be unexported (golint)
    • Line 62: warning: exported var ErrNotImplemented should have comment or be unexported (golint)
    • Line 144: warning: exported type InitCommand should have comment or be unexported (golint)
    • arvados/lib/config/cmd.go
    • Line 20: warning: exported var DumpCommand should have comment or be unexported (golint)
    • Line 69: warning: exported var CheckCommand should have comment or be unexported (golint)
    • Line 169: warning: exported var DumpDefaultsCommand should have comment or be unexported (golint)
    • arvados/sdk/go/arvadostest/api.go
    • Line 19: warning: exported var ErrStubUnimplemented should have comment or be unexported (golint)
    • Line 21: warning: exported type APIStub should have comment or be unexported (golint)
    • Line 32: warning: exported method APIStub.ConfigGet should have comment or be unexported (golint)
    • Line 36: warning: exported method APIStub.Login should have comment or be unexported (golint)
    • Line 40: warning: exported method APIStub.Logout should have comment or be unexported (golint)
    • Line 44: warning: exported method APIStub.CollectionCreate should have comment or be unexported (golint)
    • Line 48: warning: exported method APIStub.CollectionUpdate should have comment or be unexported (golint)
    • Line 52: warning: exported method APIStub.CollectionGet should have comment or be unexported (golint)
    • Line 56: warning: exported method APIStub.CollectionList should have comment or be unexported (golint)
    • Line 60: warning: exported method APIStub.CollectionProvenance should have comment or be unexported (golint)
    • Line 64: warning: exported method APIStub.CollectionUsedBy should have comment or be unexported (golint)
    • Line 68: warning: exported method APIStub.CollectionDelete should have comment or be unexported (golint)
    • Line 72: warning: exported method APIStub.CollectionTrash should have comment or be unexported (golint)
    • Line 76: warning: exported method APIStub.CollectionUntrash should have comment or be unexported (golint)
    • Line 80: warning: exported method APIStub.ContainerCreate should have comment or be unexported (golint)
    • Line 84: warning: exported method APIStub.ContainerUpdate should have comment or be unexported (golint)
    • Line 88: warning: exported method APIStub.ContainerGet should have comment or be unexported (golint)
    • Line 92: warning: exported method APIStub.ContainerList should have comment or be unexported (golint)
    • Line 96: warning: exported method APIStub.ContainerDelete should have comment or be unexported (golint)
    • Line 100: warning: exported method APIStub.ContainerLock should have comment or be unexported (golint)
    • Line 104: warning: exported method APIStub.ContainerUnlock should have comment or be unexported (golint)
    • Line 108: warning: exported method APIStub.ContainerSSH should have comment or be unexported (golint)
    • Line 112: warning: exported method APIStub.ContainerRequestCreate should have comment or be unexported (golint)
    • Line 116: warning: exported method APIStub.ContainerRequestUpdate should have comment or be unexported (golint)
    • Line 120: warning: exported method APIStub.ContainerRequestGet should have comment or be unexported (golint)
    • Line 124: warning: exported method APIStub.ContainerRequestList should have comment or be unexported (golint)
    • Line 128: warning: exported method APIStub.ContainerRequestDelete should have comment or be unexported (golint)
    • Line 132: warning: exported method APIStub.GroupCreate should have comment or be unexported (golint)
    • Line 136: warning: exported method APIStub.GroupUpdate should have comment or be unexported (golint)
    • Line 140: warning: exported method APIStub.GroupGet should have comment or be unexported (golint)
    • Line 144: warning: exported method APIStub.GroupList should have comment or be unexported (golint)
    • Line 148: warning: exported method APIStub.GroupContents should have comment or be unexported (golint)
    • Line 152: warning: exported method APIStub.GroupShared should have comment or be unexported (golint)
    • Line 156: warning: exported method APIStub.GroupDelete should have comment or be unexported (golint)
    • Line 160: warning: exported method APIStub.GroupTrash should have comment or be unexported (golint)
    • Line 164: warning: exported method APIStub.GroupUntrash should have comment or be unexported (golint)
    • Line 168: warning: exported method APIStub.SpecimenCreate should have comment or be unexported (golint)
    • Line 172: warning: exported method APIStub.SpecimenUpdate should have comment or be unexported (golint)
    • Line 176: warning: exported method APIStub.SpecimenGet should have comment or be unexported (golint)
    • Line 180: warning: exported method APIStub.SpecimenList should have comment or be unexported (golint)
    • Line 184: warning: exported method APIStub.SpecimenDelete should have comment or be unexported (golint)
    • Line 188: warning: exported method APIStub.UserCreate should have comment or be unexported (golint)
    • Line 192: warning: exported method APIStub.UserUpdate should have comment or be unexported (golint)
    • Line 196: warning: exported method APIStub.UserUpdateUUID should have comment or be unexported (golint)
    • Line 200: warning: exported method APIStub.UserActivate should have comment or be unexported (golint)
    • Line 204: warning: exported method APIStub.UserSetup should have comment or be unexported (golint)
    • Line 208: warning: exported method APIStub.UserUnsetup should have comment or be unexported (golint)
    • Line 212: warning: exported method APIStub.UserGet should have comment or be unexported (golint)
    • Line 216: warning: exported method APIStub.UserGetCurrent should have comment or be unexported (golint)
    • Line 220: warning: exported method APIStub.UserGetSystem should have comment or be unexported (golint)
    • Line 224: warning: exported method APIStub.UserList should have comment or be unexported (golint)
    • Line 228: warning: exported method APIStub.UserDelete should have comment or be unexported (golint)
    • Line 232: warning: exported method APIStub.UserMerge should have comment or be unexported (golint)
    • Line 236: warning: exported method APIStub.UserBatchUpdate should have comment or be unexported (golint)
    • Line 240: warning: exported method APIStub.UserAuthenticate should have comment or be unexported (golint)
    • Line 244: warning: exported method APIStub.APIClientAuthorizationCurrent should have comment or be unexported (golint)
    • Line 255: warning: exported method APIStub.Calls should have comment or be unexported (golint)
    • Line 268: warning: exported type APIStubCall should have comment or be unexported (golint)
    • arvados/lib/controller/federation/generated.go
    • Line 20: warning: don't use underscores in Go names; method generated_ContainerList should be generatedContainerList (golint)
    • Line 61: warning: don't use underscores in Go names; method generated_ContainerRequestList should be generatedContainerRequestList (golint)
    • Line 102: warning: don't use underscores in Go names; method generated_GroupList should be generatedGroupList (golint)
    • Line 143: warning: don't use underscores in Go names; method generated_SpecimenList should be generatedSpecimenList (golint)
    • Line 184: warning: don't use underscores in Go names; method generated_UserList should be generatedUserList (golint)
    • arvados/lib/config/load.go
    • Line 25: warning: exported var ErrNoClustersDefined should have comment or be unexported (golint)
    • Line 27: warning: exported type Loader should have comment or be unexported (golint)
    • Line 176: warning: exported method Loader.Load should have comment or be unexported (golint)
    • arvados/lib/dispatchcloud/worker/worker.go
    • Line 31: warning: exported const StateUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: exported const BootOutcomeFailed should have comment (or a comment on this block) or be unexported (golint)
    • Line 78: warning: exported const IdleBehaviorRun should have comment (or a comment on this block) or be unexported (golint)
    • arvados/sdk/go/health/aggregator.go
    • Line 45: warning: exported method Aggregator.CheckHealth should have comment or be unexported (golint)
    • Line 49: warning: exported method Aggregator.Done should have comment or be unexported (golint)
    • Line 82: warning: exported type ClusterHealthResponse should have comment or be unexported (golint)
    • Line 98: warning: exported type CheckResult should have comment or be unexported (golint)
    • Line 107: warning: exported type ServiceHealth should have comment or be unexported (golint)
    • Line 112: warning: exported method Aggregator.ClusterHealth should have comment or be unexported (golint)
    • arvados/sdk/go/arvados/config.go
    • Line 17: warning: exported var DefaultConfigFile should have comment or be unexported (golint)
    • Line 24: warning: exported type Config should have comment or be unexported (golint)
    • Line 60: warning: exported type WebDAVCacheConfig should have comment or be unexported (golint)
    • Line 71: warning: exported type Cluster should have comment or be unexported (golint)
    • Line 273: warning: exported type Volume should have comment or be unexported (golint)
    • Line 282: warning: exported type S3VolumeDriverParameters should have comment or be unexported (golint)
    • Line 299: warning: exported type AzureVolumeDriverParameters should have comment or be unexported (golint)
    • Line 309: warning: exported type DirectoryVolumeDriverParameters should have comment or be unexported (golint)
    • Line 314: warning: exported type VolumeAccess should have comment or be unexported (golint)
    • Line 318: warning: exported type Services should have comment or be unexported (golint)
    • Line 338: warning: exported type Service should have comment or be unexported (golint)
    • Line 343: warning: exported type TestUser should have comment or be unexported (golint)
    • Line 365: warning: exported method URL.MarshalText should have comment or be unexported (golint)
    • Line 373: warning: exported type ServiceInstance should have comment or be unexported (golint)
    • Line 377: warning: exported type PostgreSQL should have comment or be unexported (golint)
    • Line 382: warning: exported type PostgreSQLConnection should have comment or be unexported (golint)
    • Line 384: warning: exported type RemoteCluster should have comment or be unexported (golint)
    • Line 392: warning: exported type InstanceType should have comment or be unexported (golint)
    • Line 404: warning: exported type ContainersConfig should have comment or be unexported (golint)
    • Line 456: warning: exported type CloudVMsConfig should have comment or be unexported (golint)
    • Line 483: warning: exported type InstanceTypeMap should have comment or be unexported (golint)
    • Line 550: warning: exported type StringSet should have comment or be unexported (golint)
    • Line 584: warning: exported type ServiceName should have comment or be unexported (golint)
    • Line 587: warning: exported const ServiceNameRailsAPI should have comment (or a comment on this block) or be unexported (golint)
    • arvados/sdk/go/auth/auth.go
    • Line 15: warning: exported type Credentials should have comment or be unexported (golint)
    • Line 19: warning: exported function NewCredentials should have comment or be unexported (golint)
    • Line 23: warning: exported function NewContext should have comment or be unexported (golint)
    • Line 27: warning: exported function FromContext should have comment or be unexported (golint)
    • Line 32: warning: exported function CredentialsFromRequest should have comment or be unexported (golint)
    • arvados/sdk/go/arvados/node.go
    • Line 22: warning: exported type NodeProperties should have comment or be unexported (golint)
    • Line 29: warning: exported type NodePropertiesCloudNode should have comment or be unexported (golint)
    • arvados/sdk/go/arvadosclient/arvadosclient.go
    • Line 30: warning: exported type StringMatcher should have comment or be unexported (golint)
    • Line 32: warning: exported var UUIDMatch should have comment or be unexported (golint)
    • Line 33: warning: exported var PDHMatch should have comment or be unexported (golint)
    • Line 35: warning: error var MissingArvadosApiHost should have name of the form ErrFoo (golint)
    • Line 35: warning: exported var MissingArvadosApiHost should have comment or be unexported (golint)
    • Line 36: warning: error var MissingArvadosApiToken should have name of the form ErrFoo (golint)
    • Line 36: warning: exported var MissingArvadosApiToken should have comment or be unexported (golint)
    • Line 37: warning: exported var ErrInvalidArgument should have comment or be unexported (golint)
    • Line 39: warning: comment on exported var MaxIdleConnectionDuration should be of the form "MaxIdleConnectionDuration ..." (golint)
    • Line 45: warning: exported var RetryDelay should have comment or be unexported (golint)
    • Line 129: warning: exported var CertFiles should have comment or be unexported (golint)
    • Line 406: warning: exported const ApiDiscoveryResource should have comment or be unexported (golint)
    • arvados/lib/crunchrun/crunchrun.go
    • Line 46: warning: exported var Command should have comment or be unexported (golint)
    • Line 73: warning: exported type RunArvMount should have comment or be unexported (golint)
    • Line 75: warning: exported type MkTempDir should have comment or be unexported (golint)
    • Line 91: warning: exported type PsProcess should have comment or be unexported (golint)
    • Line 318: warning: exported method ContainerRunner.ArvMountCmd should have comment or be unexported (golint)
    • Line 383: warning: exported method ContainerRunner.SetupArvMountPoint should have comment or be unexported (golint)
    • Line 421: warning: exported method ContainerRunner.SetupMounts should have comment or be unexported (golint)
    • Line 696: warning: exported method ContainerRunner.ProcessDockerAttach should have comment or be unexported (golint)
    • Line 1330: warning: exported method ContainerRunner.CleanupDirs should have comment or be unexported (golint)
    • arvados/sdk/go/arvados/api.go
    • Line 16: warning: exported type APIEndpoint should have comment or be unexported (golint)
    • Line 24: warning: exported var EndpointConfigGet should have comment or be unexported (golint)
    • Line 83: warning: exported type ContainerSSHOptions should have comment or be unexported (golint)
    • Line 89: warning: exported type ContainerSSHConnection should have comment or be unexported (golint)
    • Line 95: warning: exported type GetOptions should have comment or be unexported (golint)
    • Line 103: warning: exported type UntrashOptions should have comment or be unexported (golint)
    • Line 108: warning: exported type ListOptions should have comment or be unexported (golint)
    • Line 125: warning: exported type CreateOptions should have comment or be unexported (golint)
    • Line 132: warning: exported type UpdateOptions should have comment or be unexported (golint)
    • Line 138: warning: exported type GroupContentsOptions should have comment or be unexported (golint)
    • Line 155: warning: exported type UpdateUUIDOptions should have comment or be unexported (golint)
    • Line 160: warning: exported type UserActivateOptions should have comment or be unexported (golint)
    • Line 164: warning: exported type UserSetupOptions should have comment or be unexported (golint)
    • Line 174: warning: exported type UserMergeOptions should have comment or be unexported (golint)
    • Line 182: warning: exported type UserBatchUpdateOptions should have comment or be unexported (golint)
    • Line 186: warning: exported type UserBatchUpdateResponse should have comment or be unexported (golint)
    • Line 188: warning: exported type DeleteOptions should have comment or be unexported (golint)
    • Line 192: warning: exported type LoginOptions should have comment or be unexported (golint)
    • Line 199: warning: exported type UserAuthenticateOptions should have comment or be unexported (golint)
    • Line 204: warning: exported type LogoutOptions should have comment or be unexported (golint)
    • Line 208: warning: exported type API should have comment or be unexported (golint)
    • arvados/services/keep-web/s3.go
    • Line 254: warning: exported var NoSuchKey should have comment or be unexported (golint)
    • Line 255: warning: exported var NoSuchBucket should have comment or be unexported (golint)
    • Line 256: warning: exported var InvalidArgument should have comment or be unexported (golint)
    • Line 257: warning: exported var InternalError should have comment or be unexported (golint)
    • Line 258: warning: exported var UnauthorizedAccess should have comment or be unexported (golint)
    • Line 259: warning: exported var InvalidRequest should have comment or be unexported (golint)
    • Line 260: warning: exported var SignatureDoesNotMatch should have comment or be unexported (golint)
    • arvados/lib/controller/federation/conn.go
    • Line 27: warning: exported type Conn should have comment or be unexported (golint)
    • Line 33: warning: exported function New should have comment or be unexported (golint)
    • Line 175: warning: exported method Conn.CollectionCreate should have comment or be unexported (golint)
    • Line 179: warning: exported method Conn.CollectionUpdate should have comment or be unexported (golint)
    • Line 189: warning: exported method Conn.ConfigGet should have comment or be unexported (golint)
    • Line 195: warning: exported method Conn.Login should have comment or be unexported (golint)
    • Line 221: warning: exported method Conn.Logout should have comment or be unexported (golint)
    • Line 247: warning: exported method Conn.CollectionGet should have comment or be unexported (golint)
    • Line 290: warning: exported method Conn.CollectionList should have comment or be unexported (golint)
    • Line 294: warning: exported method Conn.CollectionProvenance should have comment or be unexported (golint)
    • Line 298: warning: exported method Conn.CollectionUsedBy should have comment or be unexported (golint)
    • Line 302: warning: exported method Conn.CollectionDelete should have comment or be unexported (golint)
    • Line 306: warning: exported method Conn.CollectionTrash should have comment or be unexported (golint)
    • Line 310: warning: exported method Conn.CollectionUntrash should have comment or be unexported (golint)
    • Line 314: warning: exported method Conn.ContainerList should have comment or be unexported (golint)
    • Line 318: warning: exported method Conn.ContainerCreate should have comment or be unexported (golint)
    • Line 322: warning: exported method Conn.ContainerUpdate should have comment or be unexported (golint)
    • Line 326: warning: exported method Conn.ContainerGet should have comment or be unexported (golint)
    • Line 330: warning: exported method Conn.ContainerDelete should have comment or be unexported (golint)
    • Line 334: warning: exported method Conn.ContainerLock should have comment or be unexported (golint)
    • Line 338: warning: exported method Conn.ContainerUnlock should have comment or be unexported (golint)
    • Line 342: warning: exported method Conn.ContainerSSH should have comment or be unexported (golint)
    • Line 346: warning: exported method Conn.ContainerRequestList should have comment or be unexported (golint)
    • Line 350: warning: exported method Conn.ContainerRequestCreate should have comment or be unexported (golint)
    • Line 396: warning: exported method Conn.ContainerRequestUpdate should have comment or be unexported (golint)
    • Line 400: warning: exported method Conn.ContainerRequestGet should have comment or be unexported (golint)
    • Line 404: warning: exported method Conn.ContainerRequestDelete should have comment or be unexported (golint)
    • Line 408: warning: exported method Conn.GroupCreate should have comment or be unexported (golint)
    • Line 412: warning: exported method Conn.GroupUpdate should have comment or be unexported (golint)
    • Line 416: warning: exported method Conn.GroupGet should have comment or be unexported (golint)
    • Line 420: warning: exported method Conn.GroupList should have comment or be unexported (golint)
    • Line 426: warning: exported method Conn.GroupContents should have comment or be unexported (golint)
    • Line 439: warning: exported method Conn.GroupShared should have comment or be unexported (golint)
    • Line 443: warning: exported method Conn.GroupDelete should have comment or be unexported (golint)
    • Line 447: warning: exported method Conn.GroupTrash should have comment or be unexported (golint)
    • Line 451: warning: exported method Conn.GroupUntrash should have comment or be unexported (golint)
    • Line 455: warning: exported method Conn.SpecimenList should have comment or be unexported (golint)
    • Line 459: warning: exported method Conn.SpecimenCreate should have comment or be unexported (golint)
    • Line 463: warning: exported method Conn.SpecimenUpdate should have comment or be unexported (golint)
    • Line 467: warning: exported method Conn.SpecimenGet should have comment or be unexported (golint)
    • Line 471: warning: exported method Conn.SpecimenDelete should have comment or be unexported (golint)
    • Line 559: warning: exported method Conn.UserList should have comment or be unexported (golint)
    • Line 574: warning: exported method Conn.UserCreate should have comment or be unexported (golint)
    • Line 578: warning: exported method Conn.UserUpdate should have comment or be unexported (golint)
    • Line 596: warning: exported method Conn.UserUpdateUUID should have comment or be unexported (golint)
    • Line 600: warning: exported method Conn.UserMerge should have comment or be unexported (golint)
    • Line 604: warning: exported method Conn.UserActivate should have comment or be unexported (golint)
    • Line 608: warning: exported method Conn.UserSetup should have comment or be unexported (golint)
    • Line 634: warning: exported method Conn.UserUnsetup should have comment or be unexported (golint)
    • Line 638: warning: exported method Conn.UserGet should have comment or be unexported (golint)
    • Line 655: warning: exported method Conn.UserGetCurrent should have comment or be unexported (golint)
    • Line 659: warning: exported method Conn.UserGetSystem should have comment or be unexported (golint)
    • Line 663: warning: exported method Conn.UserDelete should have comment or be unexported (golint)
    • Line 667: warning: exported method Conn.UserBatchUpdate should have comment or be unexported (golint)
    • Line 671: warning: exported method Conn.UserAuthenticate should have comment or be unexported (golint)
    • Line 675: warning: exported method Conn.APIClientAuthorizationCurrent should have comment or be unexported (golint)
    • arvados/sdk/go/auth/salt.go
    • Line 19: warning: exported var ErrObsoleteToken should have comment or be unexported (golint)
    • Line 24: warning: exported function SaltToken should have comment or be unexported (golint)
    • arvados/lib/ctrlctx/db.go
    • Line 20: warning: exported var ErrNoTransaction should have comment or be unexported (golint)
    • Line 110: warning: exported function CurrentTx should have comment or be unexported (golint)
    • arvados/lib/deduplicationreport/command.go
    • Line 14: warning: exported var Command should have comment or be unexported (golint)
    • Line 18: warning: exported type NoPrefixFormatter should have comment or be unexported (golint)
    • Line 20: warning: exported method NoPrefixFormatter.Format should have comment or be unexported (golint)
    • arvados/sdk/go/arvados/error.go
    • Line 15: warning: exported type TransactionError should have comment or be unexported (golint)
    • Line 34: warning: exported method TransactionError.HTTPStatus should have comment or be unexported (golint)
    • arvados/lib/boot/supervisor.go
    • Line 39: warning: exported type Supervisor should have comment or be unexported (golint)
    • Line 67: warning: exported method Supervisor.Cluster should have comment or be unexported (golint)
    • Line 69: warning: exported method Supervisor.Start should have comment or be unexported (golint)
    • Line 121: warning: exported method Supervisor.Wait should have comment or be unexported (golint)
    • Line 320: warning: exported method Supervisor.Stop should have comment or be unexported (golint)
    • Line 325: warning: exported method Supervisor.WaitReady should have comment or be unexported (golint)
    • arvados/lib/service/cmd.go
    • Line 29: warning: exported type Handler should have comment or be unexported (golint)
    • Line 35: warning: exported type NewHandlerFunc should have comment or be unexported (golint)
    • Line 208: warning: exported function URLFromContext should have comment or be unexported (golint)

gocyclo82%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • arvados/lib/controller/fed_generic.go
    • Line 113: warning: cyclomatic complexity 33 of function (*genericFederatedRequestHandler).handleMultiClusterQuery() is high (> 15) (gocyclo)
    • Line 257: warning: cyclomatic complexity 16 of function (*genericFederatedRequestHandler).ServeHTTP() is high (> 15) (gocyclo)
    • arvados/lib/config/load.go
    • Line 176: warning: cyclomatic complexity 23 of function (*Loader).Load() is high (> 15) (gocyclo)
    • Line 95: warning: cyclomatic complexity 21 of function (*Loader).MungeLegacyConfigArgs() is high (> 15) (gocyclo)
    • arvados/lib/config/deprecated_keepstore.go
    • Line 99: warning: cyclomatic complexity 46 of function (*Loader).loadOldKeepstoreConfig() is high (> 15) (gocyclo)
    • Line 384: warning: cyclomatic complexity 19 of function (*Loader).alreadyMigrated() is high (> 15) (gocyclo)
    • Line 239: warning: cyclomatic complexity 17 of function (*Loader).migrateOldKeepstoreVolumes() is high (> 15) (gocyclo)
    • arvados/services/keep-balance/balance.go
    • Line 592: warning: cyclomatic complexity 56 of function (*Balancer).balanceBlock() is high (> 15) (gocyclo)
    • Line 320: warning: cyclomatic complexity 23 of function (*Balancer).GetCurrentState() is high (> 15) (gocyclo)
    • Line 910: warning: cyclomatic complexity 22 of function (*Balancer).collectStatistics() is high (> 15) (gocyclo)
    • Line 70: warning: cyclomatic complexity 21 of function (*Balancer).Run() is high (> 15) (gocyclo)
    • arvados/sdk/go/arvados/fs_collection.go
    • Line 1027: warning: cyclomatic complexity 35 of function (*dirnode).loadManifest() is high (> 15) (gocyclo)
    • Line 910: warning: cyclomatic complexity 24 of function (*dirnode).marshalManifest() is high (> 15) (gocyclo)
    • Line 454: warning: cyclomatic complexity 23 of function (*filenode).Write() is high (> 15) (gocyclo)
    • Line 710: warning: cyclomatic complexity 17 of function (*dirnode).commitBlock() is high (> 15) (gocyclo)
    • Line 1154: warning: cyclomatic complexity 16 of function (*dirnode).createFileAndParents() is high (> 15) (gocyclo)
    • arvados/lib/boot/supervisor.go
    • Line 625: warning: cyclomatic complexity 37 of function (*Supervisor).autofillConfig() is high (> 15) (gocyclo)
    • Line 126: warning: cyclomatic complexity 30 of function (*Supervisor).run() is high (> 15) (gocyclo)
    • Line 495: warning: cyclomatic complexity 24 of function (*Supervisor).RunProgram() is high (> 15) (gocyclo)
    • arvados/lib/config/deprecated.go
    • Line 59: warning: cyclomatic complexity 26 of function (*Loader).applyDeprecatedConfig() is high (> 15) (gocyclo)
    • Line 390: warning: cyclomatic complexity 21 of function (*Loader).loadOldKeepproxyConfig() is high (> 15) (gocyclo)
    • Line 476: warning: cyclomatic complexity 19 of function (*Loader).loadOldKeepWebConfig() is high (> 15) (gocyclo)
    • Line 604: warning: cyclomatic complexity 18 of function (*Loader).loadOldKeepBalanceConfig() is high (> 15) (gocyclo)
    • arvados/lib/crunchrun/copier.go
    • Line 246: warning: cyclomatic complexity 20 of function (*copier).walkHostFS() is high (> 15) (gocyclo)
    • Line 140: warning: cyclomatic complexity 18 of function (*copier).walkMount() is high (> 15) (gocyclo)
    • arvados/sdk/go/arvados/fs_base.go
    • Line 366: warning: cyclomatic complexity 23 of function (*fileSystem).openFile() is high (> 15) (gocyclo)
    • Line 486: warning: cyclomatic complexity 22 of function (*fileSystem).Rename() is high (> 15) (gocyclo)
    • arvados/lib/cloud/azure/azure.go
    • Line 258: warning: cyclomatic complexity 21 of function (*azureInstanceSet).setup() is high (> 15) (gocyclo)
    • Line 385: warning: cyclomatic complexity 16 of function (*azureInstanceSet).Create() is high (> 15) (gocyclo)
    • arvados/lib/controller/rpc/conn.go
    • Line 84: warning: cyclomatic complexity 24 of function (*Conn).requestAndDecode() is high (> 15) (gocyclo)
    • Line 327: warning: cyclomatic complexity 16 of function (*Conn).ContainerSSH() is high (> 15) (gocyclo)
    • arvados/lib/crunchrun/crunchrun.go
    • Line 421: warning: cyclomatic complexity 78 of function (*ContainerRunner).SetupMounts() is high (> 15) (gocyclo)
    • Line 1775: warning: cyclomatic complexity 27 of function (command).RunCommand() is high (> 15) (gocyclo)
    • Line 1543: warning: cyclomatic complexity 23 of function (*ContainerRunner).Run() is high (> 15) (gocyclo)
    • Line 943: warning: cyclomatic complexity 21 of function (*ContainerRunner).AttachStreams() is high (> 15) (gocyclo)
    • Line 1155: warning: cyclomatic complexity 16 of function (*ContainerRunner).WaitFinish() is high (> 15) (gocyclo)
    • arvados/services/keep-web/s3.go
    • Line 266: warning: cyclomatic complexity 74 of function (*handler).serveS3() is high (> 15) (gocyclo)
    • Line 597: warning: cyclomatic complexity 40 of function (*handler).s3list() is high (> 15) (gocyclo)
    • Line 548: warning: cyclomatic complexity 18 of function walkFS() is high (> 15) (gocyclo)

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!