Go Report Card

Preparing report...

Report for github.com/cybozu-go/meows

A+    Excellent!    Found 16 issues across 49 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint69%

Golint is a linter for Go source code.

    • meows/constants.go
    • Line 54: warning: comment on exported const RunnerEmptyDirPath should be of the form "RunnerEmptyDirPath ..." (golint)
    • meows/metrics/controller.go
    • Line 14: warning: exported function InitControllerMetrics should have comment or be unexported (golint)
    • Line 52: warning: exported function UpdateRunnerPoolMetrics should have comment or be unexported (golint)
    • Line 56: warning: exported function DeleteRunnerPoolMetrics should have comment or be unexported (golint)
    • Line 60: warning: exported function UpdateRunnerMetrics should have comment or be unexported (golint)
    • Line 74: warning: exported function DeleteRunnerMetrics should have comment or be unexported (golint)
    • meows/metrics/runner.go
    • Line 17: warning: exported const Initializing should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: exported var AllRunnerPodState should have comment or be unexported (golint)
    • Line 33: warning: exported const RetryableError should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: exported var AllListenerExitState should have comment or be unexported (golint)
    • Line 50: warning: exported function InitRunnerPodMetrics should have comment or be unexported (golint)
    • Line 82: warning: exported function UpdateRunnerPodState should have comment or be unexported (golint)
    • Line 92: warning: exported function IncrementListenerExitState should have comment or be unexported (golint)
    • meows/agent/jobinfo.go
    • Line 11: warning: exported const DefaultJobInfoFile should have comment or be unexported (golint)
    • Line 31: warning: exported function GetJobInfoFromFile should have comment or be unexported (golint)
    • Line 54: warning: exported method JobInfo.RepositoryURL should have comment or be unexported (golint)
    • Line 58: warning: exported method JobInfo.WorkflowURL should have comment or be unexported (golint)
    • Line 62: warning: exported method JobInfo.BranchTagURL should have comment or be unexported (golint)
    • Line 66: warning: exported method JobInfo.PullRequestURL should have comment or be unexported (golint)
    • meows/metrics/client.go
    • Line 13: warning: exported var ErrNotExist should have comment or be unexported (golint)
    • Line 17: warning: exported type Gauge should have comment or be unexported (golint)
    • meows/controllers/runnermanager.go
    • Line 24: warning: exported type RunnerManager should have comment or be unexported (golint)
    • Line 33: warning: exported type RunnerManagerImpl should have comment or be unexported (golint)
    • Line 43: warning: exported function NewRunnerManager should have comment or be unexported (golint)
    • Line 54: warning: exported method RunnerManagerImpl.StartOrUpdate should have comment or be unexported (golint)
    • Line 75: warning: exported method RunnerManagerImpl.Stop should have comment or be unexported (golint)
    • meows/runner/client/client.go
    • Line 15: warning: exported type DeletionTimePayload should have comment or be unexported (golint)
    • Line 19: warning: exported type Client should have comment or be unexported (golint)
    • Line 28: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 95: warning: exported function NewFakeClient should have comment or be unexported (golint)
    • Line 101: warning: exported method FakeClient.GetDeletionTime should have comment or be unexported (golint)
    • Line 105: warning: exported method FakeClient.PutDeletionTime should have comment or be unexported (golint)
    • Line 110: warning: exported method FakeClient.SetDeletionTimes should have comment or be unexported (golint)
    • meows/runner/runner.go
    • Line 21: warning: exported type Runner should have comment or be unexported (golint)
    • Line 28: warning: exported function NewRunner should have comment or be unexported (golint)
    • Line 44: warning: exported method Runner.Run should have comment or be unexported (golint)
    • Line 161: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • meows/agent/client.go
    • Line 14: warning: exported const JobResultSuccess should have comment (or a comment on this block) or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell97%

Misspell Finds commonly misspelled English words