Preparing report...

Report for github.com/cybozu-go/placemat

A+    Excellent!    Found 30 issues across 127 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • placemat/v1/node.go
    • Line 235: warning: cyclomatic complexity 24 of function (*Node).Start() is high (> 15) (gocyclo)
    • Line 56: warning: cyclomatic complexity 19 of function createNodeVolume() is high (> 15) (gocyclo)

golint85%

Golint is a linter for Go source code.

    • placemat/v2/pkg/vm/bmc.go
    • Line 17: warning: exported type BMCServer should have comment or be unexported (golint)
    • Line 137: warning: exported type BMCInfo should have comment or be unexported (golint)
    • placemat/v2/pkg/types/cluster.go
    • Line 35: warning: exported type NetworkType should have comment or be unexported (golint)
    • Line 38: warning: exported const NetworkInternal should have comment (or a comment on this block) or be unexported (golint)
    • Line 121: warning: exported type NodeVolumeCache should have comment or be unexported (golint)
    • Line 122: warning: exported type NodeVolumeKind should have comment or be unexported (golint)
    • Line 123: warning: exported type NodeVolumeFormat should have comment or be unexported (golint)
    • Line 126: warning: exported const NodeVolumeCacheWriteback should have comment (or a comment on this block) or be unexported (golint)
    • placemat/v2/pkg/util/cache.go
    • Line 20: warning: exported type Cache should have comment or be unexported (golint)
    • Line 24: warning: exported function NewCache should have comment or be unexported (golint)
    • Line 34: warning: exported method Cache.Put should have comment or be unexported (golint)
    • Line 63: warning: exported method Cache.Get should have comment or be unexported (golint)
    • Line 67: warning: exported method Cache.Contains should have comment or be unexported (golint)
    • Line 72: warning: exported method Cache.Path should have comment or be unexported (golint)
    • Line 77: warning: exported function DownloadData should have comment or be unexported (golint)
    • placemat/v2/pkg/virtualbmc/rmcp.go
    • Line 18: warning: exported const RmcpVersion1 should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported const RmcpClassAsf should have comment (or a comment on this block) or be unexported (golint)
    • placemat/v2/pkg/dcnet/link.go
    • Line 12: warning: exported type LinkType should have comment or be unexported (golint)
    • Line 15: warning: exported const LinkTypeVeth should have comment (or a comment on this block) or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell98%

Misspell Finds commonly misspelled English words

    • placemat/v2/pkg/virtualbmc/bmc_server_test.go
    • Line 36: warning: "reponse" is a misspelling of "response" (misspell)
    • Line 47: warning: "reponse" is a misspelling of "response" (misspell)
    • Line 58: warning: "reponse" is a misspelling of "response" (misspell)
    • Line 69: warning: "reponse" is a misspelling of "response" (misspell)
    • Line 80: warning: "reponse" is a misspelling of "response" (misspell)
    • Line 91: warning: "reponse" is a misspelling of "response" (misspell)
    • Line 102: warning: "reponse" is a misspelling of "response" (misspell)