Report for github.com/ddliu/go-dbless
A Great! Found 14 issues across 17 files
gofmt94%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
go-dbless/db.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo88%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-dbless/db.go
- Line 121: warning: cyclomatic complexity 16 of function (*DB).GetRows() is high (> 15) (gocyclo)
-
-
go-dbless/test/resource_test.go
- Line 14: warning: cyclomatic complexity 19 of function doTestResource() is high (> 15) (gocyclo)
golint29%
Golint is a linter for Go source code.
-
-
go-dbless/driver/unknown/unknown.go
- Line 9: warning: exported type UnknownDriver should have comment or be unexported (golint)
- Line 11: warning: exported method UnknownDriver.Name should have comment or be unexported (golint)
- Line 15: warning: exported method UnknownDriver.QuoteIdentifier should have comment or be unexported (golint)
- Line 19: warning: exported method UnknownDriver.ListDatabases should have comment or be unexported (golint)
- Line 23: warning: exported method UnknownDriver.ListTables should have comment or be unexported (golint)
- Line 27: warning: exported method UnknownDriver.ListColumns should have comment or be unexported (golint)
- Line 31: warning: exported method UnknownDriver.Placeholder should have comment or be unexported (golint)
- Line 40: warning: exported method UnknownDriver.ScanReceiver should have comment or be unexported (golint)
-
-
go-dbless/driver/postgres/postgres.go
- Line 10: warning: exported type PostgresDriver should have comment or be unexported (golint)
- Line 13: warning: exported method PostgresDriver.Name should have comment or be unexported (golint)
- Line 17: warning: exported method PostgresDriver.QuoteIdentifier should have comment or be unexported (golint)
- Line 21: warning: exported method PostgresDriver.ListDatabases should have comment or be unexported (golint)
- Line 30: warning: exported method PostgresDriver.ListTables should have comment or be unexported (golint)
- Line 38: warning: exported method PostgresDriver.ListColumns should have comment or be unexported (golint)
- Line 42: warning: exported method PostgresDriver.Placeholder should have comment or be unexported (golint)
- Line 51: warning: exported method PostgresDriver.ScanReceiver should have comment or be unexported (golint)
-
-
go-dbless/driver/sqlserver/sqlserver.go
- Line 9: warning: exported type SqlServerDriver should have comment or be unexported (golint)
- Line 12: warning: exported method SqlServerDriver.Name should have comment or be unexported (golint)
- Line 16: warning: exported method SqlServerDriver.QuoteIdentifier should have comment or be unexported (golint)
- Line 20: warning: exported method SqlServerDriver.ListDatabases should have comment or be unexported (golint)
- Line 29: warning: exported method SqlServerDriver.ListTables should have comment or be unexported (golint)
- Line 37: warning: exported method SqlServerDriver.ListColumns should have comment or be unexported (golint)
- Line 41: warning: exported method SqlServerDriver.Placeholder should have comment or be unexported (golint)
- Line 50: warning: exported method SqlServerDriver.ScanReceiver should have comment or be unexported (golint)
-
-
go-dbless/record.go
- Line 10: warning: exported type Record should have comment or be unexported (golint)
- Line 12: warning: exported method Record.Unmarshal should have comment or be unexported (golint)
-
-
go-dbless/resource.go
- Line 13: warning: exported type Field should have comment or be unexported (golint)
- Line 20: warning: exported method Record.ID should have comment or be unexported (golint)
- Line 29: warning: exported type Resource should have comment or be unexported (golint)
- Line 38: warning: exported method Resource.Get should have comment or be unexported (golint)
- Line 57: warning: exported method Resource.Save should have comment or be unexported (golint)
- Line 93: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 105: warning: exported type ListInput should have comment or be unexported (golint)
- Line 110: warning: exported type ListOutput should have comment or be unexported (golint)
- Line 115: warning: exported method Resource.List should have comment or be unexported (golint)
- Line 154: warning: exported method Resource.Delete should have comment or be unexported (golint)
-
-
go-dbless/filter.go
- Line 7: warning: exported type Filter should have comment or be unexported (golint)
- Line 9: warning: exported method Filter.GetWhere should have comment or be unexported (golint)
-
-
go-dbless/pagination.go
- Line 10: warning: exported type Pagination should have comment or be unexported (golint)
- Line 17: warning: exported method Pagination.GetOffsetLimit should have comment or be unexported (golint)
- Line 24: warning: exported method Pagination.Valid should have comment or be unexported (golint)
- Line 34: warning: exported method Pagination.SetTotal should have comment or be unexported (golint)
- Line 40: warning: exported function NewPagination should have comment or be unexported (golint)
- Line 51: warning: exported type PagedRows should have comment or be unexported (golint)
-
-
go-dbless/driver/sqlite/sqlite.go
- Line 9: warning: exported type Sqlite3Driver should have comment or be unexported (golint)
- Line 12: warning: exported method Sqlite3Driver.Name should have comment or be unexported (golint)
- Line 16: warning: exported method Sqlite3Driver.QuoteIdentifier should have comment or be unexported (golint)
- Line 20: warning: exported method Sqlite3Driver.ListDatabases should have comment or be unexported (golint)
- Line 24: warning: exported method Sqlite3Driver.ListTables should have comment or be unexported (golint)
- Line 31: warning: exported method Sqlite3Driver.ListColumns should have comment or be unexported (golint)
- Line 35: warning: exported method Sqlite3Driver.Placeholder should have comment or be unexported (golint)
- Line 44: warning: exported method Sqlite3Driver.ScanReceiver should have comment or be unexported (golint)
-
-
go-dbless/driver/mysql/mysql.go
- Line 9: warning: exported type MysqlDriver should have comment or be unexported (golint)
- Line 11: warning: exported method MysqlDriver.Name should have comment or be unexported (golint)
- Line 15: warning: exported method MysqlDriver.QuoteIdentifier should have comment or be unexported (golint)
- Line 19: warning: exported method MysqlDriver.ListDatabases should have comment or be unexported (golint)
- Line 28: warning: exported method MysqlDriver.ListTables should have comment or be unexported (golint)
- Line 36: warning: exported method MysqlDriver.ListColumns should have comment or be unexported (golint)
- Line 40: warning: exported method MysqlDriver.Placeholder should have comment or be unexported (golint)
- Line 49: warning: exported method MysqlDriver.ScanReceiver should have comment or be unexported (golint)
-
-
go-dbless/db.go
- Line 14: warning: exported type DB should have comment or be unexported (golint)
- Line 20: warning: exported function Open should have comment or be unexported (golint)
- Line 33: warning: exported function New should have comment or be unexported (golint)
- Line 52: warning: exported method DB.ListDatabases should have comment or be unexported (golint)
- Line 60: warning: exported method DB.ListTables should have comment or be unexported (golint)
- Line 68: warning: exported method DB.ListColumns should have comment or be unexported (golint)
- Line 76: warning: exported method DB.Scalar should have comment or be unexported (golint)
- Line 89: warning: exported method DB.GetPaging should have comment or be unexported (golint)
- Line 121: warning: exported method DB.GetRows should have comment or be unexported (golint)
- Line 142: warning: should omit 2nd value from range; this loop is equivalent to `for index := range ...` (golint)
- Line 213: warning: exported method DB.GetRow should have comment or be unexported (golint)
- Line 226: warning: exported method DB.Insert should have comment or be unexported (golint)
- Line 243: warning: exported method DB.InsertGetID should have comment or be unexported (golint)
- Line 263: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 274: warning: exported method DB.Update should have comment or be unexported (golint)
- Line 310: warning: exported method DB.Delete should have comment or be unexported (golint)
-
-
go-dbless/driver.go
- Line 9: warning: exported function ListDatabaseByQuery should have comment or be unexported (golint)
- Line 36: warning: exported function ListTableByQuery should have comment or be unexported (golint)
- Line 52: warning: exported function ListColumnsByQuery should have comment or be unexported (golint)
- Line 66: warning: exported type NoDriverError should have comment or be unexported (golint)
- Line 73: warning: exported type DriverNotImplementedError should have comment or be unexported (golint)
- Line 80: warning: exported type Driver should have comment or be unexported (golint)
- Line 97: warning: exported function RegisterDriver should have comment or be unexported (golint)
-
-
go-dbless/error.go
- Line 6: warning: exported type RecordNotFoundError should have comment or be unexported (golint)
- Line 13: warning: exported function IsRecordNotFound should have comment or be unexported (golint)
ineffassign94%
IneffAssign detects ineffectual assignments in Go code.
-
-
go-dbless/test/db.go
- Line 45: warning: undeclared name: doTestResource (ineffassign)