Preparing report...

Report for github.com/decred/dcrpool

A+    Excellent!    Found 21 issues across 63 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint96%

Golint is a linter for Go source code.

    • dcrpool/pool/message.go
    • Line 91: warning: comment on exported method StratumError.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • Line 96: warning: comment on exported method StratumError.UnmarshalJSON should be of the form "UnmarshalJSON ..." (golint)

gocyclo71%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • dcrpool/pool/paymentmgr_test.go
    • Line 467: warning: cyclomatic complexity 56 of function testPaymentMgrPayment() is high (> 15) (gocyclo)
    • Line 292: warning: cyclomatic complexity 18 of function testPaymentMgrPPLNS() is high (> 15) (gocyclo)
    • Line 198: warning: cyclomatic complexity 18 of function testPaymentMgrPPS() is high (> 15) (gocyclo)
    • Line 387: warning: cyclomatic complexity 16 of function testPaymentMgrMaturity() is high (> 15) (gocyclo)
    • dcrpool/pool/payment_test.go
    • Line 17: warning: cyclomatic complexity 22 of function testPayment() is high (> 15) (gocyclo)
    • Line 189: warning: cyclomatic complexity 19 of function testPaymentAccessors() is high (> 15) (gocyclo)
    • dcrpool/cmd/miner/client.go
    • Line 232: warning: cyclomatic complexity 36 of function (*Miner).process() is high (> 15) (gocyclo)
    • Line 160: warning: cyclomatic complexity 16 of function (*Miner).read() is high (> 15) (gocyclo)
    • dcrpool/pool/client_test.go
    • Line 212: warning: cyclomatic complexity 257 of function testClientMessageHandling() is high (> 15) (gocyclo)
    • Line 1402: warning: cyclomatic complexity 33 of function testClientTimeRolledWork() is high (> 15) (gocyclo)
    • dcrpool/pool/client.go
    • Line 823: warning: cyclomatic complexity 20 of function (*Client).process() is high (> 15) (gocyclo)
    • Line 1209: warning: cyclomatic complexity 19 of function (*Client).send() is high (> 15) (gocyclo)
    • Line 507: warning: cyclomatic complexity 17 of function (*Client).handleSubmitWorkRequest() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell93%

Misspell Finds commonly misspelled English words