Go Report Card

Preparing report...

Report for github.com/dell/csi-powermax

(v1.7.0)

B    Not bad!    Found 23 issues across 34 files

Tweet
Last refresh:

Refresh now

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gofmt47%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

gocyclo73%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • service/mount.go
    • Line 88: warning: cyclomatic complexity 41 of function publishVolume() is high (> 15) (gocyclo)
    • Line 652: warning: cyclomatic complexity 19 of function validateVolumeCapability() is high (> 15) (gocyclo)
    • Line 446: warning: cyclomatic complexity 16 of function unpublishVolume() is high (> 15) (gocyclo)
    • service/deletion_worker.go
    • Line 373: warning: cyclomatic complexity 27 of function (*deletionQueue).removeVolumesFromStorageGroup() is high (> 15) (gocyclo)
    • Line 503: warning: cyclomatic complexity 17 of function (*deletionQueue).deleteVolumes() is high (> 15) (gocyclo)
    • service/node.go
    • Line 1506: warning: cyclomatic complexity 23 of function (*service).NodeExpandVolume() is high (> 15) (gocyclo)
    • Line 722: warning: cyclomatic complexity 20 of function (*service).createTopologyMap() is high (> 15) (gocyclo)
    • Line 1718: warning: cyclomatic complexity 19 of function (*service).getAndConfigureArrayISCSITargets() is high (> 15) (gocyclo)
    • Line 950: warning: cyclomatic complexity 18 of function (*service).nodeHostSetup() is high (> 15) (gocyclo)
    • Line 526: warning: cyclomatic complexity 18 of function (*service).NodeUnpublishVolume() is high (> 15) (gocyclo)
    • Line 282: warning: cyclomatic complexity 17 of function (*service).NodeUnstageVolume() is high (> 15) (gocyclo)
    • Line 426: warning: cyclomatic complexity 16 of function (*service).NodePublishVolume() is high (> 15) (gocyclo)
    • service/snap.go
    • Line 597: warning: cyclomatic complexity 18 of function snapCleanupThread() is high (> 15) (gocyclo)
    • Line 214: warning: cyclomatic complexity 17 of function (*service).UnlinkAndTerminate() is high (> 15) (gocyclo)
    • service/step_defs_test.go
    • Line 867: warning: cyclomatic complexity 126 of function (*feature).iInduceError() is high (> 15) (gocyclo)
    • Line 1865: warning: cyclomatic complexity 17 of function (*feature).iCallValidateVolumeCapabilitiesWithVoltypeAccessFstype() is high (> 15) (gocyclo)
    • service/controller.go
    • Line 253: warning: cyclomatic complexity 75 of function (*service).CreateVolume() is high (> 15) (gocyclo)
    • Line 1091: warning: cyclomatic complexity 28 of function (*service).ControllerPublishVolume() is high (> 15) (gocyclo)
    • Line 1527: warning: cyclomatic complexity 24 of function (*service).ControllerUnpublishVolume() is high (> 15) (gocyclo)
    • Line 976: warning: cyclomatic complexity 22 of function (*service).DeleteVolume() is high (> 15) (gocyclo)
    • Line 2092: warning: cyclomatic complexity 20 of function (*service).SelectOrCreateFCPGForHost() is high (> 15) (gocyclo)
    • Line 1258: warning: cyclomatic complexity 19 of function (*service).updatePublishContext() is high (> 15) (gocyclo)
    • Line 2189: warning: cyclomatic complexity 17 of function (*service).CreateSnapshot() is high (> 15) (gocyclo)
    • Line 1357: warning: cyclomatic complexity 16 of function (*service).IsNodeISCSI() is high (> 15) (gocyclo)

ineffassign73%

IneffAssign detects ineffectual assignments in Go code.

    • service/snap.go
    • Line 512: warning: ineffectual assignment to srcSessions (ineffassign)
    • Line 512: warning: ineffectual assignment to srcSessions (ineffassign)
    • service/node.go
    • Line 853: warning: ineffectual assignment to portWWNs (ineffassign)
    • Line 854: warning: ineffectual assignment to IQNs (ineffassign)
    • Line 1233: warning: ineffectual assignment to arrays (ineffassign)
    • Line 1473: warning: ineffectual assignment to host (ineffassign)
    • Line 853: warning: ineffectual assignment to portWWNs (ineffassign)
    • Line 854: warning: ineffectual assignment to IQNs (ineffassign)
    • Line 1233: warning: ineffectual assignment to arrays (ineffassign)
    • Line 1473: warning: ineffectual assignment to host (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell79%

Misspell Finds commonly misspelled English words

    • service/envvars.go
    • Line 18: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 21: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 25: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 29: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 34: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 38: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 49: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 53: warning: "enviroment" is a misspelling of "environment" (misspell)
    • Line 64: warning: "specifiy" is a misspelling of "specify" (misspell)
    • Line 69: warning: "specifiy" is a misspelling of "specify" (misspell)
    • Line 72: warning: "specifiy" is a misspelling of "specify" (misspell)
    • service/service_unit_test.go
    • Line 268: warning: "recieved" is a misspelling of "received" (misspell)
    • Line 274: warning: "recieved" is a misspelling of "received" (misspell)
    • Line 279: warning: "recieved" is a misspelling of "received" (misspell)
    • Line 335: warning: "occurence" is a misspelling of "occurrence" (misspell)
    • Line 345: warning: "occurence" is a misspelling of "occurrence" (misspell)