Report for github.com/digitalrebar/provision/v4
A Great! Found 98 issues across 157 files
gofmt89%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
provision/v4/cli/utils.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/agent/chroot_other.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/agent/mktd.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/agent/mktd_other.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/gohai_linux.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/utils_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/api/content.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/catalog.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/gohai_other.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/startup.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/test/server_darwin.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/netwrangle.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/test/server_linux.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/agent/chroot_linux.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/models/task.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
provision/v4/cli/commandHelper.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
golint54%
Golint is a linter for Go source code.
-
-
provision/v4/test/server_linux.go
- Line 15: warning: exported function StartServer should have comment or be unexported (golint)
- Line 50: warning: exported function StopServer should have comment or be unexported (golint)
-
-
provision/v4/cli/contents.go
- Line 152: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 257: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 292: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 388: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 727: warning: exported type DocData should have comment or be unexported (golint)
- Line 737: warning: exported method DocData.LengthString should have comment or be unexported (golint)
-
-
provision/v4/models/owner.go
- Line 12: warning: comment on exported type Owner should be of the form "Owner ..." (with optional leading article) (golint)
-
-
provision/v4/models/plugin_provider.go
- Line 9: warning: comment on exported type PluginProvider should be of the form "PluginProvider ..." (with optional leading article) (golint)
- Line 62: warning: exported method PluginProvider.GetMeta should have comment or be unexported (golint)
- Line 66: warning: exported method PluginProvider.SetMeta should have comment or be unexported (golint)
- Line 70: warning: exported method PluginProvider.GetDocumentation should have comment or be unexported (golint)
- Line 74: warning: exported method PluginProvider.Prefix should have comment or be unexported (golint)
- Line 75: warning: exported method PluginProvider.Key should have comment or be unexported (golint)
- Line 76: warning: exported method PluginProvider.KeyName should have comment or be unexported (golint)
- Line 78: warning: exported method PluginProvider.SliceOf should have comment or be unexported (golint)
- Line 83: warning: exported method PluginProvider.ToModels should have comment or be unexported (golint)
- Line 92: warning: exported method PluginProvider.Fill should have comment or be unexported (golint)
- Line 158: warning: comment on exported type PluginProviderUploadInfo should be of the form "PluginProviderUploadInfo ..." (with optional leading article) (golint)
- Line 177: warning: exported method AvailableAction.Fill should have comment or be unexported (golint)
- Line 196: warning: exported method Action.Fill should have comment or be unexported (golint)
-
-
provision/v4/models/validate.go
- Line 29: warning: comment on exported type Validator should be of the form "Validator ..." (with optional leading article) (golint)
- Line 42: warning: exported method Validation.SaveValidation should have comment or be unexported (golint)
- Line 46: warning: exported method Validation.RestoreValidation should have comment or be unexported (golint)
- Line 52: warning: exported type ValidateSetter should have comment or be unexported (golint)
- Line 57: warning: exported method Validation.ClearValidation should have comment or be unexported (golint)
- Line 70: warning: exported type ChangeForcer should have comment or be unexported (golint)
- Line 75: warning: exported method Validation.ForceChange should have comment or be unexported (golint)
- Line 79: warning: exported method Validation.ChangeForced should have comment or be unexported (golint)
- Line 91: warning: exported method Validation.Errorf should have comment or be unexported (golint)
- Line 99: warning: exported method Validation.AddError should have comment or be unexported (golint)
- Line 115: warning: exported method Validation.HasError should have comment or be unexported (golint)
- Line 122: warning: exported method Validation.Useable should have comment or be unexported (golint)
- Line 126: warning: exported method Validation.IsAvailable should have comment or be unexported (golint)
- Line 130: warning: exported method Validation.SetInvalid should have comment or be unexported (golint)
- Line 135: warning: exported method Validation.SetValid should have comment or be unexported (golint)
- Line 140: warning: exported method Validation.SetAvailable should have comment or be unexported (golint)
- Line 149: warning: exported method Validation.MakeError should have comment or be unexported (golint)
- Line 162: warning: exported function ValidateIP4 should have comment or be unexported (golint)
- Line 170: warning: exported function ValidateMaybeZeroIP4 should have comment or be unexported (golint)
- Line 176: warning: exported function ValidateMac should have comment or be unexported (golint)
-
-
provision/v4/models/version_set.go
- Line 13: warning: exported type FileData should have comment or be unexported (golint)
- Line 46: warning: exported method VersionSet.Key should have comment or be unexported (golint)
- Line 50: warning: exported method VersionSet.KeyName should have comment or be unexported (golint)
- Line 54: warning: exported method VersionSet.AuthKey should have comment or be unexported (golint)
- Line 58: warning: exported method VersionSet.Prefix should have comment or be unexported (golint)
- Line 62: warning: comment on exported method VersionSet.GetDocumentation should be of the form "GetDocumentation ..." (golint)
- Line 86: warning: exported method VersionSet.Fill should have comment or be unexported (golint)
- Line 111: warning: exported method VersionSet.Merge should have comment or be unexported (golint)
- Line 175: warning: exported method VersionSet.SliceOf should have comment or be unexported (golint)
- Line 180: warning: exported method VersionSet.ToModels should have comment or be unexported (golint)
- Line 189: warning: exported method VersionSet.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/models/whoami.go
- Line 18: warning: exported type WhoamiResult should have comment or be unexported (golint)
- Line 33: warning: comment on exported type CloudInit should be of the form "CloudInit ..." (with optional leading article) (golint)
- Line 37: warning: exported type CloudInitv1 should have comment or be unexported (golint)
-
-
provision/v4/models/bundle.go
- Line 14: warning: exported type Bundler should have comment or be unexported (golint)
-
-
provision/v4/models/lease.go
- Line 11: warning: exported function Hexaddr should have comment or be unexported (golint)
- Line 89: warning: exported method Lease.GetMeta should have comment or be unexported (golint)
- Line 93: warning: exported method Lease.SetMeta should have comment or be unexported (golint)
- Line 97: warning: exported method Lease.Prefix should have comment or be unexported (golint)
- Line 101: warning: exported method Lease.Key should have comment or be unexported (golint)
- Line 105: warning: exported method Lease.KeyName should have comment or be unexported (golint)
- Line 109: warning: exported method Lease.Fill should have comment or be unexported (golint)
- Line 128: warning: exported method Lease.AuthKey should have comment or be unexported (golint)
- Line 132: warning: exported method Lease.SliceOf should have comment or be unexported (golint)
- Line 132: warning: receiver name b should be consistent with previous receiver name l for Lease (golint)
- Line 137: warning: exported method Lease.ToModels should have comment or be unexported (golint)
- Line 137: warning: receiver name b should be consistent with previous receiver name l for Lease (golint)
- Line 146: warning: exported method Lease.CanHaveActions should have comment or be unexported (golint)
- Line 146: warning: receiver name b should be consistent with previous receiver name l for Lease (golint)
- Line 150: warning: exported method Lease.Expired should have comment or be unexported (golint)
- Line 154: warning: exported method Lease.Fake should have comment or be unexported (golint)
- Line 158: warning: exported method Lease.Expire should have comment or be unexported (golint)
- Line 163: warning: exported method Lease.Invalidate should have comment or be unexported (golint)
-
-
provision/v4/models/preference.go
- Line 13: warning: exported method Pref.Prefix should have comment or be unexported (golint)
- Line 17: warning: exported method Pref.Key should have comment or be unexported (golint)
- Line 21: warning: exported method Pref.KeyName should have comment or be unexported (golint)
- Line 25: warning: exported method Pref.Fill should have comment or be unexported (golint)
- Line 31: warning: exported method Pref.AuthKey should have comment or be unexported (golint)
- Line 35: warning: exported method Pref.SliceOf should have comment or be unexported (golint)
- Line 35: warning: receiver name b should be consistent with previous receiver name p for Pref (golint)
- Line 40: warning: exported method Pref.ToModels should have comment or be unexported (golint)
- Line 40: warning: receiver name b should be consistent with previous receiver name p for Pref (golint)
-
-
provision/v4/api/utils.go
- Line 15: warning: exported type Decoder should have comment or be unexported (golint)
- Line 19: warning: exported type Encoder should have comment or be unexported (golint)
-
-
provision/v4/cli/startup.go
- Line 501: warning: exported function ResetDefaults should have comment or be unexported (golint)
-
-
provision/v4/models/workflow.go
- Line 19: warning: exported method Workflow.GetMeta should have comment or be unexported (golint)
- Line 23: warning: exported method Workflow.SetMeta should have comment or be unexported (golint)
- Line 27: warning: comment on exported method Workflow.GetDocumentation should be of the form "GetDocumentation ..." (golint)
- Line 37: warning: exported method Workflow.Prefix should have comment or be unexported (golint)
- Line 41: warning: exported method Workflow.Key should have comment or be unexported (golint)
- Line 45: warning: exported method Workflow.KeyName should have comment or be unexported (golint)
- Line 49: warning: exported method Workflow.Fill should have comment or be unexported (golint)
- Line 59: warning: exported method Workflow.AuthKey should have comment or be unexported (golint)
- Line 63: warning: exported method Workflow.SliceOf should have comment or be unexported (golint)
- Line 68: warning: exported method Workflow.ToModels should have comment or be unexported (golint)
- Line 77: warning: exported method Workflow.Validate should have comment or be unexported (golint)
- Line 84: warning: exported method Workflow.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/plugin/interfaces.go
- Line 32: warning: comment on exported type PluginEventSelecter should be of the form "PluginEventSelecter ..." (with optional leading article) (golint)
-
-
provision/v4/agent/agent.go
- Line 31: warning: exported const AGENT_INIT should have comment (or a comment on this block) or be unexported (golint)
- Line 164: warning: exported method Agent.StateLoc should have comment or be unexported (golint)
- Line 169: warning: exported method Agent.Context should have comment or be unexported (golint)
- Line 174: warning: exported method Agent.RunnerDir should have comment or be unexported (golint)
- Line 747: warning: exported method Agent.Kill should have comment or be unexported (golint)
- Line 757: warning: exported method Agent.Close should have comment or be unexported (golint)
-
-
provision/v4/cli/catalog.go
- Line 157: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 163: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 395: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
-
-
provision/v4/models/catalogItem.go
- Line 47: warning: exported method CatalogItem.Key should have comment or be unexported (golint)
- Line 51: warning: exported method CatalogItem.KeyName should have comment or be unexported (golint)
- Line 55: warning: exported method CatalogItem.AuthKey should have comment or be unexported (golint)
- Line 59: warning: exported method CatalogItem.Prefix should have comment or be unexported (golint)
- Line 77: warning: exported method CatalogItem.Fill should have comment or be unexported (golint)
- Line 125: warning: exported method CatalogItem.SliceOf should have comment or be unexported (golint)
- Line 130: warning: exported method CatalogItem.ToModels should have comment or be unexported (golint)
-
-
provision/v4/models/ha-state.go
- Line 88: warning: exported method GlobalHaState.FillTls should have comment or be unexported (golint)
- Line 193: warning: exported method CurrentHAState.EndpointCert should have comment or be unexported (golint)
- Line 222: warning: receiver name cOpts should be consistent with previous receiver name c for CurrentHAState (golint)
-
-
provision/v4/models/info.go
- Line 165: warning: exported method Info.Fill should have comment or be unexported (golint)
-
-
provision/v4/models/raw_model.go
- Line 18: warning: comment on exported method RawModel.IsReadOnly should be of the form "IsReadOnly ..." (golint)
- Line 27: warning: exported method RawModel.SetReadOnly should have comment or be unexported (golint)
- Line 31: warning: exported method RawModel.SetBundle should have comment or be unexported (golint)
- Line 35: warning: comment on exported method RawModel.GetEndpoint should be of the form "GetEndpoint ..." (golint)
- Line 41: warning: exported method RawModel.SetEndpoint should have comment or be unexported (golint)
- Line 45: warning: comment on exported method RawModel.GetStringField should be of the form "GetStringField ..." (golint)
- Line 107: warning: comment on exported method RawModel.SaveValidation should be of the form "SaveValidation ..." (golint)
- Line 116: warning: exported method RawModel.RestoreValidation should have comment or be unexported (golint)
- Line 122: warning: exported method RawModel.ClearValidation should have comment or be unexported (golint)
- Line 128: warning: exported method RawModel.ForceChange should have comment or be unexported (golint)
- Line 132: warning: exported method RawModel.ChangeForced should have comment or be unexported (golint)
- Line 136: warning: exported method RawModel.Errorf should have comment or be unexported (golint)
- Line 142: warning: exported method RawModel.AddError should have comment or be unexported (golint)
- Line 157: warning: exported method RawModel.HasError should have comment or be unexported (golint)
- Line 164: warning: exported method RawModel.Useable should have comment or be unexported (golint)
- Line 168: warning: exported method RawModel.IsAvailable should have comment or be unexported (golint)
- Line 172: warning: exported method RawModel.SetInvalid should have comment or be unexported (golint)
- Line 177: warning: exported method RawModel.SetValid should have comment or be unexported (golint)
- Line 183: warning: exported method RawModel.SetAvailable should have comment or be unexported (golint)
- Line 193: warning: exported method RawModel.MakeError should have comment or be unexported (golint)
- Line 206: warning: comment on exported method RawModel.GetMeta should be of the form "GetMeta ..." (golint)
- Line 218: warning: exported method RawModel.SetMeta should have comment or be unexported (golint)
- Line 222: warning: comment on exported method RawModel.GetParams should be of the form "GetParams ..." (golint)
- Line 227: warning: exported method RawModel.SetParams should have comment or be unexported (golint)
- Line 231: warning: exported method RawModel.IsPartial should have comment or be unexported (golint)
- Line 239: warning: exported method RawModel.SetPartial should have comment or be unexported (golint)
- Line 243: warning: exported method RawModel.Prefix should have comment or be unexported (golint)
- Line 247: warning: exported method RawModel.Key should have comment or be unexported (golint)
- Line 255: warning: exported method RawModel.KeyName should have comment or be unexported (golint)
- Line 259: warning: exported method RawModel.Fill should have comment or be unexported (golint)
- Line 300: warning: exported method RawModel.AuthKey should have comment or be unexported (golint)
- Line 304: warning: exported method RawModel.SliceOf should have comment or be unexported (golint)
- Line 308: warning: exported method RawModel.ToModels should have comment or be unexported (golint)
- Line 317: warning: exported method RawModel.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/models/secureData.go
- Line 37: warning: error var BadKey should have name of the form ErrFoo (golint)
- Line 37: warning: exported var BadKey should have comment or be unexported (golint)
- Line 38: warning: error var BadNonce should have name of the form ErrFoo (golint)
- Line 39: warning: error var Corrupt should have name of the form ErrFoo (golint)
- Line 42: warning: exported function IsSecureData should have comment or be unexported (golint)
- Line 148: warning: exported method SecureData.Unmarshal should have comment or be unexported (golint)
-
-
provision/v4/models/tenant.go
- Line 3: warning: comment on exported type Tenant should be of the form "Tenant ..." (with optional leading article) (golint)
- Line 20: warning: exported method Tenant.Fill should have comment or be unexported (golint)
- Line 33: warning: exported method Tenant.GetMeta should have comment or be unexported (golint)
- Line 37: warning: exported method Tenant.SetMeta should have comment or be unexported (golint)
- Line 41: warning: comment on exported method Tenant.GetDocumentation should be of the form "GetDocumentation ..." (golint)
- Line 51: warning: exported method Tenant.Validate should have comment or be unexported (golint)
- Line 60: warning: exported method Tenant.Prefix should have comment or be unexported (golint)
- Line 64: warning: exported method Tenant.Key should have comment or be unexported (golint)
- Line 68: warning: exported method Tenant.KeyName should have comment or be unexported (golint)
- Line 72: warning: exported method Tenant.AuthKey should have comment or be unexported (golint)
- Line 76: warning: exported method Tenant.SliceOf should have comment or be unexported (golint)
- Line 81: warning: exported method Tenant.ToModels should have comment or be unexported (golint)
-
-
provision/v4/models/user.go
- Line 34: warning: exported method User.GetMeta should have comment or be unexported (golint)
- Line 38: warning: exported method User.SetMeta should have comment or be unexported (golint)
- Line 42: warning: exported method User.Validate should have comment or be unexported (golint)
- Line 46: warning: exported method User.Prefix should have comment or be unexported (golint)
- Line 50: warning: exported method User.Key should have comment or be unexported (golint)
- Line 54: warning: exported method User.KeyName should have comment or be unexported (golint)
- Line 63: warning: exported method User.Fill should have comment or be unexported (golint)
- Line 73: warning: exported method User.CheckPassword should have comment or be unexported (golint)
- Line 80: warning: exported method User.ChangePassword should have comment or be unexported (golint)
- Line 91: warning: exported method User.Sanitize should have comment or be unexported (golint)
- Line 97: warning: exported method User.AuthKey should have comment or be unexported (golint)
- Line 101: warning: comment on exported type UserPassword should be of the form "UserPassword ..." (with optional leading article) (golint)
- Line 106: warning: exported method User.SliceOf should have comment or be unexported (golint)
- Line 106: warning: receiver name b should be consistent with previous receiver name u for User (golint)
- Line 111: warning: exported method User.ToModels should have comment or be unexported (golint)
- Line 111: warning: receiver name b should be consistent with previous receiver name u for User (golint)
- Line 120: warning: exported method User.SetName should have comment or be unexported (golint)
- Line 120: warning: receiver name b should be consistent with previous receiver name u for User (golint)
- Line 124: warning: exported method User.CanHaveActions should have comment or be unexported (golint)
- Line 124: warning: receiver name b should be consistent with previous receiver name u for User (golint)
-
-
provision/v4/store/directory.go
- Line 19: warning: exported method Directory.Type should have comment or be unexported (golint)
- Line 23: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
- Line 27: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
- Line 60: warning: exported method Directory.Prefixes should have comment or be unexported (golint)
- Line 64: warning: exported method Directory.Keys should have comment or be unexported (golint)
- Line 68: warning: exported method Directory.MetaData should have comment or be unexported (golint)
- Line 107: warning: exported method Directory.SetMetaData should have comment or be unexported (golint)
- Line 143: warning: exported method Directory.Open should have comment or be unexported (golint)
- Line 143: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
- Line 175: warning: exported method Directory.Exists should have comment or be unexported (golint)
- Line 175: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
- Line 181: warning: exported method Directory.Load should have comment or be unexported (golint)
- Line 181: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
- Line 202: warning: exported method Directory.Save should have comment or be unexported (golint)
- Line 202: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
- Line 214: warning: exported method Directory.Remove should have comment or be unexported (golint)
- Line 214: warning: receiver name f should be consistent with previous receiver name d for Directory (golint)
-
-
provision/v4/agent/taskRunner.go
- Line 419: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
provision/v4/cli/support.go
- Line 1: warning: package comment should be of the form "Package cli ..." (golint)
- Line 240: warning: comment on exported function AddDirToZip should be of the form "AddDirToZip ..." (golint)
- Line 269: warning: comment on exported function AddFileToZip should be of the form "AddFileToZip ..." (golint)
-
-
provision/v4/models/dhcpOption.go
- Line 251: warning: exported method DhcpOption.Fill should have comment or be unexported (golint)
- Line 260: warning: exported method DhcpOption.AddToPacket should have comment or be unexported (golint)
- Line 269: warning: exported method DhcpOption.FillFromPacketOpt should have comment or be unexported (golint)
- Line 274: warning: exported method DhcpOption.ConvertOptionValueToByte should have comment or be unexported (golint)
- Line 279: warning: exported method DhcpOption.RenderToDHCP should have comment or be unexported (golint)
-
-
provision/v4/models/meta.go
- Line 14: warning: exported type MetaHaver should have comment or be unexported (golint)
- Line 20: warning: exported method Meta.ClearFeatures should have comment or be unexported (golint)
- Line 24: warning: exported method Meta.Features should have comment or be unexported (golint)
- Line 31: warning: exported method Meta.HasFeature should have comment or be unexported (golint)
- Line 41: warning: exported method Meta.AddFeature should have comment or be unexported (golint)
- Line 52: warning: exported method Meta.RemoveFeature should have comment or be unexported (golint)
- Line 64: warning: exported method Meta.MergeFeatures should have comment or be unexported (golint)
-
-
provision/v4/store/hooks.go
- Line 3: warning: comment on exported type ReadOnlySetter should be of the form "ReadOnlySetter ..." (with optional leading article) (golint)
- Line 9: warning: comment on exported type BundleSetter should be of the form "BundleSetter ..." (with optional leading article) (golint)
-
-
provision/v4/api/bootenv.go
- Line 15: warning: exported method Client.InstallRawTemplateFromFile should have comment or be unexported (golint)
- Line 20: warning: exported method Client.InstallRawTemplateFromFileWithId should have comment or be unexported (golint)
- Line 40: warning: exported method Client.UploadISOForBootEnv should have comment or be unexported (golint)
- Line 44: warning: exported method Client.InstallISOForBootenv should have comment or be unexported (golint)
- Line 141: warning: exported method Client.InstallBootEnvFromFile should have comment or be unexported (golint)
-
-
provision/v4/api/event.go
- Line 5: warning: exported method Client.PostEvent should have comment or be unexported (golint)
-
-
provision/v4/cli/doc.go
- Line 1: warning: package comment should be of the form "Package cli ..." (golint)
-
-
provision/v4/models/errors.go
- Line 73: warning: exported method Error.ContainsError should have comment or be unexported (golint)
- Line 77: warning: exported method Error.AddError should have comment or be unexported (golint)
- Line 98: warning: exported method Error.HasError should have comment or be unexported (golint)
-
-
provision/v4/models/templateInfo.go
- Line 11: warning: exported function DrpSafeFuncMap should have comment or be unexported (golint)
- Line 62: warning: exported method TemplateInfo.Id should have comment or be unexported (golint)
- Line 69: warning: exported method TemplateInfo.SanityCheck should have comment or be unexported (golint)
- Line 91: warning: exported method TemplateInfo.PathTemplate should have comment or be unexported (golint)
- Line 95: warning: exported method TemplateInfo.LinkTemplate should have comment or be unexported (golint)
- Line 99: warning: exported function MergeTemplates should have comment or be unexported (golint)
-
-
provision/v4/cli/files.go
- Line 42: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
provision/v4/doc.go
- Line 1: warning: package comment should be of the form "Package v4 ..." (golint)
-
-
provision/v4/api/client.go
- Line 89: warning: exported method Client.UrlForProxy should have comment or be unexported (golint)
- Line 96: warning: exported method Client.UrlFor should have comment or be unexported (golint)
- Line 119: warning: exported method Client.Host should have comment or be unexported (golint)
- Line 234: warning: exported method R.List should have comment or be unexported (golint)
- Line 262: warning: comment on exported method R.ParanoidPatch should be of the form "ParanoidPatch ..." (golint)
- Line 299: warning: exported method R.PatchToFull should have comment or be unexported (golint)
- Line 704: warning: exported method R.GetETag should have comment or be unexported (golint)
- Line 915: warning: exported method Client.GetModelForPatch should have comment or be unexported (golint)
- Line 973: warning: exported method Client.PatchTo should have comment or be unexported (golint)
- Line 977: warning: exported method Client.PatchToFull should have comment or be unexported (golint)
- Line 989: warning: exported method Client.Websocket should have comment or be unexported (golint)
- Line 1052: warning: exported method Client.RunProxy should have comment or be unexported (golint)
- Line 1061: warning: exported method Client.MakeProxy should have comment or be unexported (golint)
- Line 1138: warning: exported function DisconnectedClient should have comment or be unexported (golint)
- Line 1142: warning: context.Context should be the first parameter of a function (golint)
- Line 1173: warning: exported method Client.TokenRefresh should have comment or be unexported (golint)
- Line 1233: warning: comment on exported function UserSessionTokenProxyContext should be of the form "UserSessionTokenProxyContext ..." (golint)
- Line 1306: warning: exported method Client.SetLogger should have comment or be unexported (golint)
-
-
provision/v4/models/job.go
- Line 41: warning: exported method JobAction.ValidForOS should have comment or be unexported (golint)
- Line 46: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 59: warning: exported type JobActions should have comment or be unexported (golint)
- Line 61: warning: exported method JobActions.FilterOS should have comment or be unexported (golint)
- Line 156: warning: exported method Job.GetMeta should have comment or be unexported (golint)
- Line 160: warning: exported method Job.SetMeta should have comment or be unexported (golint)
- Line 164: warning: exported method Job.Validate should have comment or be unexported (golint)
- Line 184: warning: exported method Job.Prefix should have comment or be unexported (golint)
- Line 188: warning: exported method Job.Key should have comment or be unexported (golint)
- Line 192: warning: exported method Job.KeyName should have comment or be unexported (golint)
- Line 196: warning: exported method Job.Fill should have comment or be unexported (golint)
- Line 203: warning: exported method Job.AuthKey should have comment or be unexported (golint)
- Line 207: warning: exported method Job.SliceOf should have comment or be unexported (golint)
- Line 207: warning: receiver name b should be consistent with previous receiver name j for Job (golint)
- Line 212: warning: exported method Job.ToModels should have comment or be unexported (golint)
- Line 212: warning: receiver name b should be consistent with previous receiver name j for Job (golint)
- Line 221: warning: exported method Job.CanHaveActions should have comment or be unexported (golint)
- Line 221: warning: receiver name b should be consistent with previous receiver name j for Job (golint)
-
-
provision/v4/models/modtimesha.go
- Line 16: warning: exported type ModTimeSha should have comment or be unexported (golint)
- Line 21: warning: exported method ModTimeSha.MarshalBinary should have comment or be unexported (golint)
- Line 32: warning: exported method ModTimeSha.UnmarshalBinary should have comment or be unexported (golint)
- Line 42: warning: exported method ModTimeSha.UpToDate should have comment or be unexported (golint)
- Line 47: warning: exported method ModTimeSha.GenerateStat should have comment or be unexported (golint)
- Line 66: warning: exported method ModTimeSha.Generate should have comment or be unexported (golint)
- Line 74: warning: exported method ModTimeSha.Regenerate should have comment or be unexported (golint)
- Line 86: warning: exported method ModTimeSha.ReadFromXattr should have comment or be unexported (golint)
- Line 100: warning: exported method ModTimeSha.SaveToXattr should have comment or be unexported (golint)
-
-
provision/v4/models/partial.go
- Line 24: warning: exported method Partialed.SetPartial should have comment or be unexported (golint)
-
-
provision/v4/models/reservation.go
- Line 59: warning: exported method Reservation.GetMeta should have comment or be unexported (golint)
- Line 63: warning: exported method Reservation.SetMeta should have comment or be unexported (golint)
- Line 77: warning: exported method Reservation.Prefix should have comment or be unexported (golint)
- Line 81: warning: exported method Reservation.Key should have comment or be unexported (golint)
- Line 85: warning: exported method Reservation.KeyName should have comment or be unexported (golint)
- Line 89: warning: exported method Reservation.Fill should have comment or be unexported (golint)
- Line 99: warning: exported method Reservation.AuthKey should have comment or be unexported (golint)
- Line 103: warning: exported method Reservation.SliceOf should have comment or be unexported (golint)
- Line 108: warning: exported method Reservation.ToModels should have comment or be unexported (golint)
- Line 117: warning: exported method Reservation.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/models/secureData_test.go
- Line 33: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 40: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
provision/v4/models/subnet.go
- Line 131: warning: exported method Subnet.GetMeta should have comment or be unexported (golint)
- Line 135: warning: exported method Subnet.SetMeta should have comment or be unexported (golint)
- Line 139: warning: comment on exported method Subnet.GetDocumentation should be of the form "GetDocumentation ..." (golint)
- Line 149: warning: exported method Subnet.Validate should have comment or be unexported (golint)
- Line 155: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 193: warning: exported method Subnet.Prefix should have comment or be unexported (golint)
- Line 197: warning: exported method Subnet.Key should have comment or be unexported (golint)
- Line 201: warning: exported method Subnet.KeyName should have comment or be unexported (golint)
- Line 205: warning: exported method Subnet.Fill should have comment or be unexported (golint)
- Line 231: warning: exported method Subnet.AuthKey should have comment or be unexported (golint)
- Line 235: warning: exported method Subnet.SliceOf should have comment or be unexported (golint)
- Line 235: warning: receiver name b should be consistent with previous receiver name s for Subnet (golint)
- Line 240: warning: exported method Subnet.ToModels should have comment or be unexported (golint)
- Line 240: warning: receiver name b should be consistent with previous receiver name s for Subnet (golint)
- Line 249: warning: exported method Subnet.CanHaveActions should have comment or be unexported (golint)
- Line 249: warning: receiver name b should be consistent with previous receiver name s for Subnet (golint)
-
-
provision/v4/models/task.go
- Line 73: warning: exported method Task.GetMeta should have comment or be unexported (golint)
- Line 77: warning: exported method Task.SetMeta should have comment or be unexported (golint)
- Line 81: warning: comment on exported method Task.GetDocumentation should be of the form "GetDocumentation ..." (golint)
- Line 91: warning: exported method Task.Validate should have comment or be unexported (golint)
- Line 144: warning: exported method Task.Prefix should have comment or be unexported (golint)
- Line 148: warning: exported method Task.Key should have comment or be unexported (golint)
- Line 152: warning: exported method Task.KeyName should have comment or be unexported (golint)
- Line 156: warning: exported method Task.Fill should have comment or be unexported (golint)
- Line 181: warning: exported method Task.AuthKey should have comment or be unexported (golint)
- Line 185: warning: exported method Task.SliceOf should have comment or be unexported (golint)
- Line 190: warning: exported method Task.ToModels should have comment or be unexported (golint)
- Line 199: warning: exported method Task.SetName should have comment or be unexported (golint)
- Line 203: warning: exported method Task.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/models/template.go
- Line 26: warning: exported method Template.GetMeta should have comment or be unexported (golint)
- Line 30: warning: exported method Template.SetMeta should have comment or be unexported (golint)
- Line 34: warning: exported method Template.Validate should have comment or be unexported (golint)
- Line 38: warning: exported method Template.Prefix should have comment or be unexported (golint)
- Line 42: warning: exported method Template.Key should have comment or be unexported (golint)
- Line 46: warning: exported method Template.KeyName should have comment or be unexported (golint)
- Line 55: warning: exported method Template.Fill should have comment or be unexported (golint)
- Line 62: warning: exported method Template.AuthKey should have comment or be unexported (golint)
- Line 66: warning: exported method Template.SliceOf should have comment or be unexported (golint)
- Line 66: warning: receiver name b should be consistent with previous receiver name t for Template (golint)
- Line 71: warning: exported method Template.ToModels should have comment or be unexported (golint)
- Line 71: warning: receiver name b should be consistent with previous receiver name t for Template (golint)
- Line 80: warning: exported method Template.CanHaveActions should have comment or be unexported (golint)
- Line 80: warning: receiver name b should be consistent with previous receiver name t for Template (golint)
-
-
provision/v4/api/content.go
- Line 14: warning: exported method Client.GetContentSummary should have comment or be unexported (golint)
- Line 19: warning: exported method Client.GetContentItem should have comment or be unexported (golint)
- Line 24: warning: exported method Client.CreateContent should have comment or be unexported (golint)
- Line 33: warning: exported method Client.ReplaceContent should have comment or be unexported (golint)
- Line 42: warning: exported method Client.DeleteContent should have comment or be unexported (golint)
- Line 46: warning: exported function FindOrFake should have comment or be unexported (golint)
- Line 70: warning: exported method Client.BundleContent should have comment or be unexported (golint)
- Line 154: warning: exported method Client.UnbundleContent should have comment or be unexported (golint)
-
-
provision/v4/api/event_stream.go
- Line 56: warning: comment on exported function NotItem should be of the form "NotItem ..." (golint)
- Line 335: warning: exported method EventStream.Kill should have comment or be unexported (golint)
-
-
provision/v4/store/memory.go
- Line 5: warning: comment on exported type Memory should be of the form "Memory ..." (with optional leading article) (golint)
- Line 13: warning: exported method Memory.Type should have comment or be unexported (golint)
- Line 17: warning: exported method Memory.MetaData should have comment or be unexported (golint)
- Line 27: warning: exported method Memory.SetMetaData should have comment or be unexported (golint)
- Line 40: warning: exported method Memory.Open should have comment or be unexported (golint)
- Line 57: warning: exported method Memory.Prefixes should have comment or be unexported (golint)
- Line 68: warning: exported method Memory.Keys should have comment or be unexported (golint)
- Line 83: warning: exported method Memory.Exists should have comment or be unexported (golint)
- Line 95: warning: exported method Memory.Load should have comment or be unexported (golint)
- Line 117: warning: exported method Memory.Save should have comment or be unexported (golint)
- Line 135: warning: exported method Memory.Remove should have comment or be unexported (golint)
-
-
provision/v4/cli/system.go
- Line 330: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 349: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 368: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 385: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
provision/v4/models/bootenv.go
- Line 69: warning: exported method ArchInfo.Fill should have comment or be unexported (golint)
- Line 306: warning: exported method BootEnv.GetMeta should have comment or be unexported (golint)
- Line 310: warning: exported method BootEnv.SetMeta should have comment or be unexported (golint)
- Line 314: warning: exported method BootEnv.GetDocumentation should have comment or be unexported (golint)
- Line 318: warning: exported method BootEnv.GetDescription should have comment or be unexported (golint)
- Line 363: warning: exported method BootEnv.KernelFor should have comment or be unexported (golint)
- Line 371: warning: exported method BootEnv.InitrdsFor should have comment or be unexported (golint)
- Line 379: warning: exported method BootEnv.BootParamsFor should have comment or be unexported (golint)
- Line 387: warning: exported method BootEnv.Validate should have comment or be unexported (golint)
- Line 419: warning: exported method BootEnv.Prefix should have comment or be unexported (golint)
- Line 423: warning: exported method BootEnv.Key should have comment or be unexported (golint)
- Line 427: warning: exported method BootEnv.KeyName should have comment or be unexported (golint)
- Line 431: warning: exported method BootEnv.AuthKey should have comment or be unexported (golint)
- Line 435: warning: exported method BootEnv.SliceOf should have comment or be unexported (golint)
- Line 440: warning: exported method BootEnv.ToModels should have comment or be unexported (golint)
- Line 449: warning: exported method BootEnv.Fill should have comment or be unexported (golint)
- Line 478: warning: exported method BootEnv.SetName should have comment or be unexported (golint)
- Line 482: warning: exported method BootEnv.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/store/common.go
- Line 200: warning: exported type UnWritable should have comment or be unexported (golint)
-
-
provision/v4/models/context.go
- Line 37: warning: exported method Context.Prefix should have comment or be unexported (golint)
- Line 41: warning: exported method Context.Key should have comment or be unexported (golint)
- Line 45: warning: exported method Context.KeyName should have comment or be unexported (golint)
- Line 49: warning: exported method Context.AuthKey should have comment or be unexported (golint)
- Line 53: warning: exported method Context.Fill should have comment or be unexported (golint)
- Line 60: warning: exported method Context.SliceOf should have comment or be unexported (golint)
- Line 65: warning: exported method Context.ToModels should have comment or be unexported (golint)
- Line 74: warning: exported method Context.GetMeta should have comment or be unexported (golint)
- Line 78: warning: exported method Context.SetMeta should have comment or be unexported (golint)
-
-
provision/v4/models/machine.go
- Line 53: warning: exported type MachineFingerprint should have comment or be unexported (golint)
- Line 82: warning: exported method MachineFingerprint.Fill should have comment or be unexported (golint)
- Line 220: warning: exported method Machine.IsLocked should have comment or be unexported (golint)
- Line 224: warning: exported method Machine.GetMeta should have comment or be unexported (golint)
- Line 228: warning: exported method Machine.SetMeta should have comment or be unexported (golint)
- Line 232: warning: exported method Machine.Validate should have comment or be unexported (golint)
- Line 276: warning: exported method Machine.UUID should have comment or be unexported (golint)
- Line 280: warning: exported method Machine.Prefix should have comment or be unexported (golint)
- Line 284: warning: exported method Machine.Key should have comment or be unexported (golint)
- Line 288: warning: exported method Machine.KeyName should have comment or be unexported (golint)
- Line 292: warning: exported method Machine.GetDescription should have comment or be unexported (golint)
- Line 292: warning: receiver name m should be consistent with previous receiver name n for Machine (golint)
- Line 296: warning: exported method Machine.Fill should have comment or be unexported (golint)
- Line 322: warning: exported method Machine.AuthKey should have comment or be unexported (golint)
- Line 326: warning: exported method Machine.SliceOf should have comment or be unexported (golint)
- Line 326: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 331: warning: exported method Machine.ToModels should have comment or be unexported (golint)
- Line 331: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 340: warning: comment on exported method Machine.GetParams should be of the form "GetParams ..." (golint)
- Line 341: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 345: warning: exported method Machine.SetParams should have comment or be unexported (golint)
- Line 345: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 349: warning: comment on exported method Machine.GetProfiles should be of the form "GetProfiles ..." (golint)
- Line 350: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 354: warning: exported method Machine.SetProfiles should have comment or be unexported (golint)
- Line 354: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 358: warning: comment on exported method Machine.GetBootEnv should be of the form "GetBootEnv ..." (golint)
- Line 359: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 363: warning: exported method Machine.SetBootEnv should have comment or be unexported (golint)
- Line 363: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 367: warning: comment on exported method Machine.GetTasks should be of the form "GetTasks ..." (golint)
- Line 368: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 372: warning: exported method Machine.SetTasks should have comment or be unexported (golint)
- Line 372: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 376: warning: exported method Machine.RunningTask should have comment or be unexported (golint)
- Line 376: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 380: warning: exported method Machine.SetName should have comment or be unexported (golint)
- Line 380: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 391: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 416: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 459: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
- Line 480: warning: exported method Machine.CanHaveActions should have comment or be unexported (golint)
- Line 480: warning: receiver name b should be consistent with previous receiver name n for Machine (golint)
-
-
provision/v4/models/plugin.go
- Line 37: warning: exported method Plugin.GetMeta should have comment or be unexported (golint)
- Line 41: warning: exported method Plugin.SetMeta should have comment or be unexported (golint)
- Line 45: warning: exported method Plugin.GetDocumentation should have comment or be unexported (golint)
- Line 49: warning: exported method Plugin.GetDescription should have comment or be unexported (golint)
- Line 53: warning: exported method Plugin.Validate should have comment or be unexported (golint)
- Line 61: warning: exported method Plugin.SetName should have comment or be unexported (golint)
- Line 65: warning: exported method Plugin.Prefix should have comment or be unexported (golint)
- Line 65: warning: receiver name n should be consistent with previous receiver name p for Plugin (golint)
- Line 69: warning: exported method Plugin.Key should have comment or be unexported (golint)
- Line 69: warning: receiver name n should be consistent with previous receiver name p for Plugin (golint)
- Line 73: warning: exported method Plugin.KeyName should have comment or be unexported (golint)
- Line 73: warning: receiver name n should be consistent with previous receiver name p for Plugin (golint)
- Line 77: warning: exported method Plugin.Fill should have comment or be unexported (golint)
- Line 77: warning: receiver name n should be consistent with previous receiver name p for Plugin (golint)
- Line 90: warning: exported method Plugin.AuthKey should have comment or be unexported (golint)
- Line 90: warning: receiver name n should be consistent with previous receiver name p for Plugin (golint)
- Line 94: warning: exported method Plugin.SliceOf should have comment or be unexported (golint)
- Line 99: warning: exported method Plugin.ToModels should have comment or be unexported (golint)
- Line 108: warning: comment on exported method Plugin.GetParams should be of the form "GetParams ..." (golint)
- Line 113: warning: exported method Plugin.SetParams should have comment or be unexported (golint)
- Line 117: warning: exported method Plugin.CanHaveActions should have comment or be unexported (golint)
-
-
provision/v4/models/utils.go
- Line 161: warning: exported function ValidNumberName should have comment or be unexported (golint)
- Line 324: warning: exported function ParseDuration should have comment or be unexported (golint)
-
-
provision/v4/cli/common_test.go
- Line 110: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 131: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 220: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
-
-
provision/v4/models/event.go
- Line 39: warning: exported method Event.Text should have comment or be unexported (golint)
- Line 48: warning: exported method Event.Model should have comment or be unexported (golint)
- Line 63: warning: exported method Event.Message should have comment or be unexported (golint)
- Line 70: warning: exported function EventFor should have comment or be unexported (golint)
-
-
provision/v4/models/role.go
- Line 175: warning: comment on exported method Claims.Contains should be of the form "Contains ..." (golint)
- Line 252: warning: exported method Claim.Contains should have comment or be unexported (golint)
- Line 252: warning: receiver name a should be consistent with previous receiver name c for Claim (golint)
- Line 264: warning: exported method Claim.Validate should have comment or be unexported (golint)
- Line 308: warning: exported method Role.GetMeta should have comment or be unexported (golint)
- Line 312: warning: exported method Role.SetMeta should have comment or be unexported (golint)
- Line 316: warning: comment on exported method Role.GetDocumentation should be of the form "GetDocumentation ..." (golint)
- Line 326: warning: exported method Role.Fill should have comment or be unexported (golint)
- Line 336: warning: exported method Role.Compile should have comment or be unexported (golint)
- Line 344: warning: comment on exported method Role.Contains should be of the form "Contains ..." (golint)
- Line 345: warning: receiver name a should be consistent with previous receiver name r for Role (golint)
- Line 350: warning: exported method Role.Validate should have comment or be unexported (golint)
- Line 357: warning: exported method Role.Prefix should have comment or be unexported (golint)
- Line 361: warning: exported method Role.Key should have comment or be unexported (golint)
- Line 365: warning: exported method Role.KeyName should have comment or be unexported (golint)
- Line 369: warning: exported method Role.AuthKey should have comment or be unexported (golint)
- Line 373: warning: exported method Role.SliceOf should have comment or be unexported (golint)
- Line 378: warning: exported method Role.ToModels should have comment or be unexported (golint)
- Line 387: warning: exported method Role.Match should have comment or be unexported (golint)
- Line 396: warning: exported function MakeRole should have comment or be unexported (golint)
-
-
provision/v4/version.go
- Line 4: warning: exported var RSMajorVersion should have comment or be unexported (golint)
-
-
provision/v4/store/codec.go
- Line 57: warning: exported var DefaultCodec should have comment or be unexported (golint)
-
-
provision/v4/cli/common.go
- Line 23: warning: exported function PatchWithString should have comment or be unexported (golint)
- Line 38: warning: comment on exported function PatchWithFunction should be of the form "PatchWithFunction ..." (golint)
-
-
provision/v4/cli/utils.go
- Line 41: warning: exported type CloudiaUrlReq should have comment or be unexported (golint)
- Line 47: warning: exported type CloudiaUrlResp should have comment or be unexported (golint)
-
-
provision/v4/models/content.go
- Line 150: warning: exported method Content.GenerateMetaMap should have comment or be unexported (golint)
- Line 198: warning: exported method Content.Mangle should have comment or be unexported (golint)
- Line 286: warning: exported type Sections should have comment or be unexported (golint)
- Line 287: warning: exported type Section should have comment or be unexported (golint)
- Line 289: warning: exported method Content.Prefix should have comment or be unexported (golint)
- Line 293: warning: exported method Content.Key should have comment or be unexported (golint)
- Line 297: warning: exported method Content.KeyName should have comment or be unexported (golint)
- Line 301: warning: exported method Content.Fill should have comment or be unexported (golint)
- Line 307: warning: exported method Content.AuthKey should have comment or be unexported (golint)
- Line 311: warning: exported method Content.GetDocumentation should have comment or be unexported (golint)
- Line 315: warning: exported method Content.GetDescription should have comment or be unexported (golint)
- Line 330: warning: exported method ContentSummary.Fill should have comment or be unexported (golint)
- Line 339: warning: exported method ContentSummary.FromStore should have comment or be unexported (golint)
-
-
provision/v4/models/license.go
- Line 41: warning: exported method License.Check should have comment or be unexported (golint)
-
-
provision/v4/models/param.go
- Line 36: warning: exported method Param.GetMeta should have comment or be unexported (golint)
- Line 40: warning: exported method Param.SetMeta should have comment or be unexported (golint)
- Line 44: warning: exported method Param.GetDocumentation should have comment or be unexported (golint)
- Line 48: warning: exported method Param.GetDescription should have comment or be unexported (golint)
- Line 52: warning: exported method Param.DefaultValue should have comment or be unexported (golint)
- Line 60: warning: exported method Param.TypeValue should have comment or be unexported (golint)
- Line 68: warning: exported method Param.Validate should have comment or be unexported (golint)
- Line 91: warning: exported method Param.SetName should have comment or be unexported (golint)
- Line 95: warning: exported method Param.Prefix should have comment or be unexported (golint)
- Line 99: warning: exported method Param.Key should have comment or be unexported (golint)
- Line 103: warning: exported method Param.KeyName should have comment or be unexported (golint)
- Line 107: warning: exported method Param.Fill should have comment or be unexported (golint)
- Line 114: warning: exported method Param.AuthKey should have comment or be unexported (golint)
- Line 118: warning: exported method Param.SliceOf should have comment or be unexported (golint)
- Line 118: warning: receiver name b should be consistent with previous receiver name p for Param (golint)
- Line 123: warning: exported method Param.ToModels should have comment or be unexported (golint)
- Line 123: warning: receiver name b should be consistent with previous receiver name p for Param (golint)
-
-
provision/v4/models/pool.go
- Line 24: warning: exported type PoolStatus should have comment or be unexported (golint)
- Line 26: warning: exported const PS_JOINING should have comment or be unexported (golint)
- Line 27: warning: exported const PS_HOLD_JOIN should have comment or be unexported (golint)
- Line 28: warning: exported const PS_FREE should have comment or be unexported (golint)
- Line 29: warning: exported const PS_BUILDING should have comment or be unexported (golint)
- Line 30: warning: exported const PS_HOLD_BUILD should have comment or be unexported (golint)
- Line 31: warning: exported const PS_IN_USE should have comment or be unexported (golint)
- Line 32: warning: exported const PS_DESTROYING should have comment or be unexported (golint)
- Line 33: warning: exported const PS_HOLD_DESTROY should have comment or be unexported (golint)
- Line 34: warning: exported const PS_LEAVING should have comment or be unexported (golint)
- Line 35: warning: exported const PS_HOLD_LEAVE should have comment or be unexported (golint)
- Line 37: warning: comment on exported type Pool should be of the form "Pool ..." (with optional leading article) (golint)
- Line 110: warning: exported method Pool.Validate should have comment or be unexported (golint)
- Line 142: warning: exported method Pool.Key should have comment or be unexported (golint)
- Line 146: warning: exported method Pool.KeyName should have comment or be unexported (golint)
- Line 150: warning: exported method Pool.AuthKey should have comment or be unexported (golint)
- Line 154: warning: exported method Pool.GetDescription should have comment or be unexported (golint)
- Line 158: warning: exported method Pool.GetDocumentation should have comment or be unexported (golint)
- Line 162: warning: exported method Pool.Prefix should have comment or be unexported (golint)
- Line 180: warning: exported method Pool.Fill should have comment or be unexported (golint)
- Line 190: warning: exported method Pool.CanHaveActions should have comment or be unexported (golint)
- Line 194: warning: exported method Pool.SliceOf should have comment or be unexported (golint)
- Line 199: warning: exported method Pool.ToModels should have comment or be unexported (golint)
-
-
provision/v4/store/file.go
- Line 11: warning: exported type File should have comment or be unexported (golint)
- Line 20: warning: exported method File.Type should have comment or be unexported (golint)
- Line 24: warning: exported method File.MetaData should have comment or be unexported (golint)
- Line 34: warning: exported method File.SetMetaData should have comment or be unexported (golint)
- Line 52: warning: exported method File.Open should have comment or be unexported (golint)
- Line 84: warning: exported method File.Prefixes should have comment or be unexported (golint)
- Line 94: warning: exported method File.Keys should have comment or be unexported (golint)
- Line 109: warning: exported method File.Exists should have comment or be unexported (golint)
- Line 121: warning: exported method File.Load should have comment or be unexported (golint)
- Line 152: warning: exported method File.Save should have comment or be unexported (golint)
- Line 165: warning: exported method File.Remove should have comment or be unexported (golint)
-
-
provision/v4/models/aaplbsdp.go
- Line 10: warning: exported const BsdpOS9 should have comment (or a comment on this block) or be unexported (golint)
- Line 73: warning: exported method BsdpBootOption.MarshalText should have comment or be unexported (golint)
- Line 77: warning: exported method BsdpBootOption.UnmarshalText should have comment or be unexported (golint)
-
-
provision/v4/store/stack.go
- Line 31: warning: exported method StackedStore.Type should have comment or be unexported (golint)
- Line 35: warning: exported method StackedStore.Open should have comment or be unexported (golint)
- Line 85: warning: exported type StackPushError should have comment or be unexported (golint)
- Line 151: warning: exported method StackedStore.Layers should have comment or be unexported (golint)
- Line 159: warning: exported method StackedStore.Prefixes should have comment or be unexported (golint)
- Line 169: warning: exported method StackedStore.Keys should have comment or be unexported (golint)
- Line 182: warning: exported method StackedStore.MetaFor should have comment or be unexported (golint)
- Line 195: warning: exported method StackedStore.ItemReadOnly should have comment or be unexported (golint)
- Line 205: warning: exported method StackedStore.Exists should have comment or be unexported (golint)
- Line 210: warning: exported method StackedStore.Load should have comment or be unexported (golint)
- Line 223: warning: exported type StackCannotOverride should have comment or be unexported (golint)
- Line 229: warning: exported type StackCannotBeOverridden should have comment or be unexported (golint)
- Line 235: warning: exported method StackedStore.Save should have comment or be unexported (golint)
- Line 258: warning: exported method StackedStore.Remove should have comment or be unexported (golint)
- Line 278: warning: exported method StackedStore.ReadOnly should have comment or be unexported (golint)
- Line 284: warning: exported method StackedStore.SetReadOnly should have comment or be unexported (golint)
-
-
provision/v4/plugin/plugin.go
- Line 183: warning: exported function ListObjects should have comment or be unexported (golint)
-
-
provision/v4/models/interface.go
- Line 33: warning: exported method Interface.Prefix should have comment or be unexported (golint)
- Line 34: warning: exported method Interface.Key should have comment or be unexported (golint)
- Line 35: warning: exported method Interface.KeyName should have comment or be unexported (golint)
- Line 36: warning: exported method Interface.Fill should have comment or be unexported (golint)
- Line 45: warning: exported method Interface.SliceOf should have comment or be unexported (golint)
- Line 45: warning: receiver name b should be consistent with previous receiver name i for Interface (golint)
- Line 50: warning: exported method Interface.ToModels should have comment or be unexported (golint)
- Line 50: warning: receiver name b should be consistent with previous receiver name i for Interface (golint)
-
-
provision/v4/models/stage.go
- Line 78: warning: comment on exported method Stage.GetDocumentation should be of the form "GetDocumentation ..." (golint)
gocyclo73%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
provision/v4/cli/contents.go
- Line 165: warning: cyclomatic complexity 98 of function registerContent() is high (> 15) (gocyclo)
- Line 71: warning: cyclomatic complexity 16 of function encryptAfterDownload() is high (> 15) (gocyclo)
-
-
provision/v4/cli/actionHelper.go
- Line 21: warning: cyclomatic complexity 21 of function (*ops).actions() is high (> 15) (gocyclo)
-
-
provision/v4/cli/pools.go
- Line 15: warning: cyclomatic complexity 41 of function registerPool() is high (> 15) (gocyclo)
-
-
provision/v4/cli/files.go
- Line 14: warning: cyclomatic complexity 32 of function blobCommands() is high (> 15) (gocyclo)
-
-
provision/v4/cli/inspect.go
- Line 50: warning: cyclomatic complexity 25 of function inspectCommands() is high (> 15) (gocyclo)
-
-
provision/v4/cli/metaHelper.go
- Line 11: warning: cyclomatic complexity 25 of function (*ops).meta() is high (> 15) (gocyclo)
-
-
provision/v4/agent/agent.go
- Line 765: warning: cyclomatic complexity 28 of function (*Agent).Run() is high (> 15) (gocyclo)
- Line 284: warning: cyclomatic complexity 27 of function (*Agent).loadKexec() is high (> 15) (gocyclo)
- Line 646: warning: cyclomatic complexity 17 of function (*Agent).changeStage() is high (> 15) (gocyclo)
- Line 531: warning: cyclomatic complexity 16 of function (*Agent).runTask() is high (> 15) (gocyclo)
-
-
provision/v4/cli/commandHelper.go
- Line 19: warning: cyclomatic complexity 108 of function (*ops).commands() is high (> 15) (gocyclo)
-
-
provision/v4/cli/system.go
- Line 34: warning: cyclomatic complexity 67 of function addSystemCommands() is high (> 15) (gocyclo)
-
-
provision/v4/cli/paramHelper.go
- Line 17: warning: cyclomatic complexity 58 of function (*ops).params() is high (> 15) (gocyclo)
-
-
provision/v4/cli/support.go
- Line 41: warning: cyclomatic complexity 24 of function bundleCmds() is high (> 15) (gocyclo)
-
-
provision/v4/cli/taskHelper.go
- Line 11: warning: cyclomatic complexity 23 of function (*ops).tasks() is high (> 15) (gocyclo)
-
-
provision/v4/cli/agent.go
- Line 99: warning: cyclomatic complexity 18 of function (*agentProg).Start() is high (> 15) (gocyclo)
-
-
provision/v4/api/bootenv.go
- Line 44: warning: cyclomatic complexity 21 of function (*Client).InstallISOForBootenv() is high (> 15) (gocyclo)
- Line 141: warning: cyclomatic complexity 18 of function (*Client).InstallBootEnvFromFile() is high (> 15) (gocyclo)
-
-
provision/v4/plugin/plugin.go
- Line 401: warning: cyclomatic complexity 16 of function configHandler() is high (> 15) (gocyclo)
-
-
provision/v4/models/content.go
- Line 212: warning: cyclomatic complexity 28 of function (*Content).FromStore() is high (> 15) (gocyclo)
- Line 339: warning: cyclomatic complexity 23 of function (*ContentSummary).FromStore() is high (> 15) (gocyclo)
-
-
provision/v4/models/version_set.go
- Line 111: warning: cyclomatic complexity 18 of function (*VersionSet).Merge() is high (> 15) (gocyclo)
-
-
provision/v4/cli/common_test.go
- Line 278: warning: cyclomatic complexity 41 of function testCli() is high (> 15) (gocyclo)
-
-
provision/v4/cli/utils.go
- Line 52: warning: cyclomatic complexity 26 of function signRackNUrl() is high (> 15) (gocyclo)
- Line 390: warning: cyclomatic complexity 23 of function lamePrinter() is high (> 15) (gocyclo)
-
-
provision/v4/cli/jobs.go
- Line 17: warning: cyclomatic complexity 24 of function registerJob() is high (> 15) (gocyclo)
-
-
provision/v4/models/dhcpOption.go
- Line 17: warning: cyclomatic complexity 37 of function DHCPOptionParser() is high (> 15) (gocyclo)
-
-
provision/v4/models/ha-state.go
- Line 222: warning: cyclomatic complexity 23 of function (*CurrentHAState).Validate() is high (> 15) (gocyclo)
-
-
provision/v4/models/whoami.go
- Line 184: warning: cyclomatic complexity 20 of function (*Whoami).Fill() is high (> 15) (gocyclo)
- Line 303: warning: cyclomatic complexity 19 of function (*Whoami).Score() is high (> 15) (gocyclo)
-
-
provision/v4/cli/machines.go
- Line 35: warning: cyclomatic complexity 63 of function registerMachine() is high (> 15) (gocyclo)
-
-
provision/v4/cli/subnet.go
- Line 17: warning: cyclomatic complexity 28 of function registerSubnet() is high (> 15) (gocyclo)
-
-
provision/v4/cli/appleNBI.go
- Line 23: warning: cyclomatic complexity 23 of function genEnvAndArchiveFromAppleNBI() is high (> 15) (gocyclo)
-
-
provision/v4/api/content.go
- Line 70: warning: cyclomatic complexity 19 of function (*Client).BundleContent() is high (> 15) (gocyclo)
- Line 154: warning: cyclomatic complexity 16 of function (*Client).UnbundleContent() is high (> 15) (gocyclo)
-
-
provision/v4/store/common.go
- Line 51: warning: cyclomatic complexity 17 of function Open() is high (> 15) (gocyclo)
-
-
provision/v4/models/bootenv.go
- Line 495: warning: cyclomatic complexity 22 of function (*BootEnv).MergeOverrides() is high (> 15) (gocyclo)
-
-
provision/v4/cli/info.go
- Line 26: warning: cyclomatic complexity 32 of function addInfoCommands() is high (> 15) (gocyclo)
-
-
provision/v4/agent/taskRunner_test.go
- Line 64: warning: cyclomatic complexity 23 of function TestJobs() is high (> 15) (gocyclo)
-
-
provision/v4/cli/catalog.go
- Line 171: warning: cyclomatic complexity 67 of function catalogCommands() is high (> 15) (gocyclo)
- Line 97: warning: cyclomatic complexity 21 of function installItem() is high (> 15) (gocyclo)
-
-
provision/v4/api/client.go
- Line 619: warning: cyclomatic complexity 24 of function (*R).Do() is high (> 15) (gocyclo)
- Line 515: warning: cyclomatic complexity 19 of function (*R).Response() is high (> 15) (gocyclo)
-
-
provision/v4/api/utils.go
- Line 45: warning: cyclomatic complexity 22 of function PrettyColor() is high (> 15) (gocyclo)
-
-
provision/v4/cli/startup.go
- Line 145: warning: cyclomatic complexity 65 of function NewApp() is high (> 15) (gocyclo)
-
-
provision/v4/cli/netwrangle.go
- Line 24: warning: cyclomatic complexity 31 of function writeNetCfg() is high (> 15) (gocyclo)
- Line 155: warning: cyclomatic complexity 27 of function registerNet() is high (> 15) (gocyclo)
-
-
provision/v4/cli/bootenv.go
- Line 25: warning: cyclomatic complexity 30 of function registerBootEnv() is high (> 15) (gocyclo)
-
-
provision/v4/api/bootenv_test.go
- Line 513: warning: cyclomatic complexity 27 of function TestBootEnvImport() is high (> 15) (gocyclo)
-
-
provision/v4/models/aaplbsdp.go
- Line 77: warning: cyclomatic complexity 19 of function (*BsdpBootOption).UnmarshalText() is high (> 15) (gocyclo)
-
-
provision/v4/agent/taskRunner.go
- Line 296: warning: cyclomatic complexity 42 of function (*runner).run() is high (> 15) (gocyclo)
- Line 167: warning: cyclomatic complexity 27 of function (*runner).perform() is high (> 15) (gocyclo)
-
-
provision/v4/agent/change_stage_test.go
- Line 12: warning: cyclomatic complexity 18 of function TestChangeStage() is high (> 15) (gocyclo)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell92%
Misspell Finds commonly misspelled English words
-
-
provision/v4/store/stack.go
- Line 23: warning: "initally" is a misspelling of "initially" (misspell)
- Line 137: warning: "inital" is a misspelling of "initial" (misspell)
-
-
provision/v4/models/owner.go
- Line 7: warning: "amoung" is a misspelling of "among" (misspell)
-
-
provision/v4/cli/bootenv.go
- Line 165: warning: "apropriate" is a misspelling of "appropriate" (misspell)
- Line 170: warning: "containig" is a misspelling of "containing" (misspell)
-
-
provision/v4/cli/startup.go
- Line 163: warning: "seperated" is a misspelling of "separated" (misspell)
-
-
provision/v4/store/common.go
- Line 108: warning: "seperate" is a misspelling of "separate" (misspell)
-
-
provision/v4/models/aaplbsdp.go
- Line 105: warning: "Unkown" is a misspelling of "Unknown" (misspell)
-
-
provision/v4/models/bootenv.go
- Line 240: warning: "commmand" is a misspelling of "command" (misspell)
- Line 264: warning: "bootlaoder" is a misspelling of "bootloader" (misspell)
-
-
provision/v4/models/content.go
- Line 37: warning: "seperated" is a misspelling of "separated" (misspell)
- Line 41: warning: "seperated" is a misspelling of "separated" (misspell)
- Line 95: warning: "sucessfully" is a misspelling of "successfully" (misspell)
-
-
provision/v4/models/errors.go
- Line 52: warning: "satifies" is a misspelling of "satisfies" (misspell)
-
-
provision/v4/models/ha-state.go
- Line 350: warning: "markes" is a misspelling of "marks" (misspell)
-
-
provision/v4/plugin/interfaces.go
- Line 60: warning: "recieved" is a misspelling of "received" (misspell)
-
-
provision/v4/agent/agent.go
- Line 463: warning: "ancilliary" is a misspelling of "ancillary" (misspell)