Go Report Card

Preparing report...

Report for github.com/dmwm/das2go

A+    Excellent!    Found 18 issues across 33 files

Tweet
Last refresh:

Refresh now

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint69%

Golint is a linter for Go source code.

    • das2go/utils/profile.go
    • Line 12: warning: comment on exported var Profiler should be of the form "Profiler ..." (golint)
    • Line 15: warning: exported function InitFunctionProfiler should have comment or be unexported (golint)
    • Line 48: warning: comment on exported function MeasureTime should be of the form "MeasureTime ..." (golint)
    • das2go/das/das.go
    • Line 849: warning: comment on exported function PostProcessing should be of the form "PostProcessing ..." (golint)
    • das2go/services/helpers.go
    • Line 23: warning: exported function DBSUrl should have comment or be unexported (golint)
    • Line 38: warning: exported function PhedexUrl should have comment or be unexported (golint)
    • Line 50: warning: exported function SitedbUrl should have comment or be unexported (golint)
    • Line 62: warning: exported function CricUrl should have comment or be unexported (golint)
    • Line 73: warning: exported function RucioUrl should have comment or be unexported (golint)
    • das2go/services/rucio.go
    • Line 87: warning: should omit 2nd value from range; this loop is equivalent to `for rse := range ...` (golint)
    • Line 120: warning: should omit 2nd value from range; this loop is equivalent to `for k := range ...` (golint)
    • das2go/utils/fetch.go
    • Line 59: warning: comment on exported type TLSCertsManager should be of the form "TLSCertsManager ..." (with optional leading article) (golint)
    • Line 267: warning: exported function Init should have comment or be unexported (golint)
    • das2go/utils/rucio.go
    • Line 19: warning: comment on exported var RucioValidity should be of the form "RucioValidity ..." (golint)
    • Line 22: warning: comment on exported var RucioTokenCurl should be of the form "RucioTokenCurl ..." (golint)
    • Line 104: warning: comment on exported function FetchRucioToken should be of the form "FetchRucioToken ..." (golint)
    • das2go/services/combined.go
    • Line 139: warning: comment on exported method LocalAPIs.Site4BlockPhedex should be of the form "Site4BlockPhedex ..." (golint)
    • Line 512: warning: don't use underscores in Go names; method Site4Dataset_phedex should be Site4DatasetPhedex (golint)
    • Line 661: warning: exported type RucioRecordRSE should have comment or be unexported (golint)

gocyclo63%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • das2go/services/reqmgr.go
    • Line 136: warning: cyclomatic complexity 24 of function findReqMgrIds() is high (> 15) (gocyclo)
    • Line 227: warning: cyclomatic complexity 19 of function reqmgrConfigs() is high (> 15) (gocyclo)
    • Line 74: warning: cyclomatic complexity 17 of function ReqMgrUnmarshal() is high (> 15) (gocyclo)
    • das2go/services/combined.go
    • Line 223: warning: cyclomatic complexity 19 of function rucioInfo() is high (> 15) (gocyclo)
    • Line 36: warning: cyclomatic complexity 17 of function (LocalAPIs).Child4SiteReleaseDataset() is high (> 15) (gocyclo)
    • Line 512: warning: cyclomatic complexity 16 of function (LocalAPIs).Site4Dataset_phedex() is high (> 15) (gocyclo)
    • das2go/dasql/dasql.go
    • Line 237: warning: cyclomatic complexity 37 of function Parse() is high (> 15) (gocyclo)
    • Line 402: warning: cyclomatic complexity 22 of function parsePipe() is high (> 15) (gocyclo)
    • Line 491: warning: cyclomatic complexity 16 of function ValidateDASQuerySpecs() is high (> 15) (gocyclo)
    • das2go/dasmaps/dasmaps.go
    • Line 374: warning: cyclomatic complexity 35 of function (*DASMaps).FindServices() is high (> 15) (gocyclo)
    • Line 215: warning: cyclomatic complexity 16 of function (*DASMaps).DASKeysMaps() is high (> 15) (gocyclo)
    • das2go/web/utils.go
    • Line 353: warning: cyclomatic complexity 54 of function PresentData() is high (> 15) (gocyclo)
    • Line 241: warning: cyclomatic complexity 19 of function lumiEvents() is high (> 15) (gocyclo)
    • Line 40: warning: cyclomatic complexity 17 of function genColor() is high (> 15) (gocyclo)
    • das2go/das/das.go
    • Line 85: warning: cyclomatic complexity 91 of function FormUrlCall() is high (> 15) (gocyclo)
    • Line 569: warning: cyclomatic complexity 36 of function ProcessLogic() is high (> 15) (gocyclo)
    • Line 467: warning: cyclomatic complexity 18 of function processURLs() is high (> 15) (gocyclo)
    • Line 852: warning: cyclomatic complexity 18 of function PostProcessing() is high (> 15) (gocyclo)
    • Line 334: warning: cyclomatic complexity 16 of function FormRESTUrl() is high (> 15) (gocyclo)

ineffassign93%

IneffAssign detects ineffectual assignments in Go code.

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell93%

Misspell Finds commonly misspelled English words