gofmt0%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

An error occurred while running this test (AddError: could not parse "_repos/src/github.com/dsoprea/go-exif/stat ifd_builder_test.go: no such file or directory:1::warning: file is not gofmted with -s (gofmt)" - strconv.Atoi: parsing " no such file or directory": invalid syntax)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint62%

Golint is a linter for Go source code.

• go-exif/ifd.go
  • Line 15: warning: exported const IfdStandard should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported var ErrChildIfdNotMapped should have comment or be unexported (golint)
  • Line 56: warning: exported type MappedIfd should have comment or be unexported (golint)
  • Line 71: warning: exported method MappedIfd.PathPhrase should have comment or be unexported (golint)
  • Line 80: warning: exported function NewIfdMapping should have comment or be unexported (golint)
  • Line 91: warning: exported function NewIfdMappingWithStandard should have comment or be unexported (golint)
  • Line 107: warning: exported method IfdMapping.Get should have comment or be unexported (golint)
  • Line 126: warning: exported method IfdMapping.GetWithPath should have comment or be unexported (golint)
  • Line 183: warning: exported type IfdTagIdAndIndex should have comment or be unexported (golint)
  • Line 254: warning: exported method IfdMapping.FqPathPhraseFromLineage should have comment or be unexported (golint)
  • Line 267: warning: exported method IfdMapping.PathPhraseFromLineage should have comment or be unexported (golint)
  • Line 371: warning: exported method IfdMapping.DumpLineages should have comment or be unexported (golint)
  • Line 387: warning: exported function LoadStandardIfds should have comment or be unexported (golint)

• go-exif/tag_type.go
  • Line 13: warning: exported type TagType should have comment or be unexported (golint)
  • Line 19: warning: exported function NewTagType should have comment or be unexported (golint)
  • Line 36: warning: exported method TagType.Name should have comment or be unexported (golint)
  • Line 40: warning: exported method TagType.Type should have comment or be unexported (golint)
  • Line 44: warning: exported method TagType.ByteOrder should have comment or be unexported (golint)
  • Line 48: warning: exported method TagType.Size should have comment or be unexported (golint)
  • Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 78: warning: exported method TagType.ParseBytes should have comment or be unexported (golint)
  • Line 126: warning: exported method TagType.ParseShorts should have comment or be unexported (golint)
  • Line 141: warning: exported method TagType.ParseLongs should have comment or be unexported (golint)
  • Line 156: warning: exported method TagType.ParseRationals should have comment or be unexported (golint)
  • Line 171: warning: exported method TagType.ParseSignedLongs should have comment or be unexported (golint)
  • Line 186: warning: exported method TagType.ParseSignedRationals should have comment or be unexported (golint)
  • Line 201: warning: exported method TagType.ReadByteValues should have comment or be unexported (golint)
  • Line 216: warning: exported method TagType.ReadAsciiValue should have comment or be unexported (golint)
  • Line 231: warning: exported method TagType.ReadAsciiNoNulValue should have comment or be unexported (golint)
  • Line 246: warning: exported method TagType.ReadShortValues should have comment or be unexported (golint)
  • Line 261: warning: exported method TagType.ReadLongValues should have comment or be unexported (golint)
  • Line 276: warning: exported method TagType.ReadRationalValues should have comment or be unexported (golint)
  • Line 291: warning: exported method TagType.ReadSignedLongValues should have comment or be unexported (golint)
  • Line 306: warning: exported method TagType.ReadSignedRationalValues should have comment or be unexported (golint)
  • Line 384: warning: exported method TagType.FromString should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_927C_maker_note.go
  • Line 15: warning: exported type Tag927CMakerNote should have comment or be unexported (golint)
  • Line 20: warning: exported method Tag927CMakerNote.EncoderName should have comment or be unexported (golint)
  • Line 41: warning: exported type Codec927CMakerNote should have comment or be unexported (golint)
  • Line 44: warning: exported method Codec927CMakerNote.Encode should have comment or be unexported (golint)
  • Line 61: warning: exported method Codec927CMakerNote.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_9286_user_comment.go
  • Line 19: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_ASCII should be TagUndefinedType9286UserCommentEncodingASCII (golint)
  • Line 19: warning: exported const TagUndefinedType_9286_UserComment_Encoding_ASCII should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_JIS should be TagUndefinedType9286UserCommentEncodingJIS (golint)
  • Line 21: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_UNICODE should be TagUndefinedType9286UserCommentEncodingUNICODE (golint)
  • Line 22: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_UNDEFINED should be TagUndefinedType9286UserCommentEncodingUNDEFINED (golint)
  • Line 26: warning: don't use underscores in Go names; var TagUndefinedType_9286_UserComment_Encoding_Names should be TagUndefinedType9286UserCommentEncodingNames (golint)
  • Line 26: warning: exported var TagUndefinedType_9286_UserComment_Encoding_Names should have comment or be unexported (golint)
  • Line 33: warning: don't use underscores in Go names; var TagUndefinedType_9286_UserComment_Encodings should be TagUndefinedType9286UserCommentEncodings (golint)
  • Line 41: warning: exported type Tag9286UserComment should have comment or be unexported (golint)
  • Line 46: warning: exported method Tag9286UserComment.EncoderName should have comment or be unexported (golint)
  • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 66: warning: exported type Codec9286UserComment should have comment or be unexported (golint)
  • Line 69: warning: exported method Codec9286UserComment.Encode should have comment or be unexported (golint)
  • Line 96: warning: exported method Codec9286UserComment.Decode should have comment or be unexported (golint)

• go-exif/error.go
  • Line 8: warning: exported var ErrTagNotFound should have comment or be unexported (golint)

• go-exif/exif_test.go
  • Line 77: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-exif/v2/undefined/exif_9101_components_configuration.go
  • Line 15: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_Y should be TagUndefinedType9101ComponentsConfigurationChannelY (golint)
  • Line 15: warning: exported const TagUndefinedType_9101_ComponentsConfiguration_Channel_Y should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_Cb should be TagUndefinedType9101ComponentsConfigurationChannelCb (golint)
  • Line 17: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_Cr should be TagUndefinedType9101ComponentsConfigurationChannelCr (golint)
  • Line 18: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_R should be TagUndefinedType9101ComponentsConfigurationChannelR (golint)
  • Line 19: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_G should be TagUndefinedType9101ComponentsConfigurationChannelG (golint)
  • Line 20: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_B should be TagUndefinedType9101ComponentsConfigurationChannelB (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_OTHER should be TagUndefinedType9101ComponentsConfigurationOTHER (golint)
  • Line 24: warning: exported const TagUndefinedType_9101_ComponentsConfiguration_OTHER should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_RGB should be TagUndefinedType9101ComponentsConfigurationRGB (golint)
  • Line 26: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_YCBCR should be TagUndefinedType9101ComponentsConfigurationYCBCR (golint)
  • Line 30: warning: don't use underscores in Go names; var TagUndefinedType_9101_ComponentsConfiguration_Names should be TagUndefinedType9101ComponentsConfigurationNames (golint)
  • Line 30: warning: exported var TagUndefinedType_9101_ComponentsConfiguration_Names should have comment or be unexported (golint)
  • Line 36: warning: don't use underscores in Go names; var TagUndefinedType_9101_ComponentsConfiguration_Configurations should be TagUndefinedType9101ComponentsConfigurationConfigurations (golint)
  • Line 53: warning: exported type TagExif9101ComponentsConfiguration should have comment or be unexported (golint)
  • Line 58: warning: exported method TagExif9101ComponentsConfiguration.EncoderName should have comment or be unexported (golint)
  • Line 66: warning: exported type CodecExif9101ComponentsConfiguration should have comment or be unexported (golint)
  • Line 69: warning: exported method CodecExif9101ComponentsConfiguration.Encode should have comment or be unexported (golint)
  • Line 84: warning: exported method CodecExif9101ComponentsConfiguration.Decode should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_A301_scene_type.go
  • Line 13: warning: exported type TagExifA301SceneType should have comment or be unexported (golint)
  • Line 15: warning: exported method TagExifA301SceneType.EncoderName should have comment or be unexported (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUndefinedType_A301_SceneType_DirectlyPhotographedImage should be TagUndefinedTypeA301SceneTypeDirectlyPhotographedImage (golint)
  • Line 24: warning: exported const TagUndefinedType_A301_SceneType_DirectlyPhotographedImage should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type CodecExifA301SceneType should have comment or be unexported (golint)
  • Line 30: warning: exported method CodecExifA301SceneType.Encode should have comment or be unexported (golint)
  • Line 52: warning: exported method CodecExifA301SceneType.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/gps_001C_gps_area_information.go
  • Line 11: warning: exported type Tag001CGPSAreaInformation should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag001CGPSAreaInformation.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec001CGPSAreaInformation should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec001CGPSAreaInformation.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec001CGPSAreaInformation.Decode should have comment or be unexported (golint)

• go-exif/v2/common/type.go
  • Line 76: warning: receiver name tagType should be consistent with previous receiver name typeType for TagTypePrimitive (golint)
  • Line 100: warning: receiver name tagType should be consistent with previous receiver name typeType for TagTypePrimitive (golint)
  • Line 116: warning: comment on exported var TypeNames should be of the form "TypeNames ..." (golint)
  • Line 151: warning: comment on exported function FormatFromType should be of the form "FormatFromType ..." (golint)
  • Line 275: warning: comment on exported function FormatFromBytes should be of the form "FormatFromBytes ..." (golint)

• go-exif/v2/ifd_builder_encode.go
  • Line 16: warning: comment on exported const IfdTagEntrySize should be of the form "IfdTagEntrySize ..." (golint)
  • Line 20: warning: exported type ByteWriter should have comment or be unexported (golint)
  • Line 25: warning: exported function NewByteWriter should have comment or be unexported (golint)
  • Line 45: warning: exported method ByteWriter.WriteUint32 should have comment or be unexported (golint)
  • Line 58: warning: exported method ByteWriter.WriteUint16 should have comment or be unexported (golint)
  • Line 71: warning: exported method ByteWriter.WriteFourBytes should have comment or be unexported (golint)
  • Line 78: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 129: warning: exported function NewIfdByteEncoder should have comment or be unexported (golint)
  • Line 135: warning: exported method IfdByteEncoder.Journal should have comment or be unexported (golint)
  • Line 139: warning: exported method IfdByteEncoder.TableSize should have comment or be unexported (golint)
  • Line 161: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 235: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 360: warning: don't use underscores in Go names; var len_ should be len (golint)

• go-exif/v2/undefined/exif_A300_file_source.go
  • Line 13: warning: exported type TagExifA300FileSource should have comment or be unexported (golint)
  • Line 15: warning: exported method TagExifA300FileSource.EncoderName should have comment or be unexported (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_Others should be TagUndefinedTypeA300SceneTypeOthers (golint)
  • Line 24: warning: exported const TagUndefinedType_A300_SceneType_Others should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_ScannerOfTransparentType should be TagUndefinedTypeA300SceneTypeScannerOfTransparentType (golint)
  • Line 26: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_ScannerOfReflexType should be TagUndefinedTypeA300SceneTypeScannerOfReflexType (golint)
  • Line 27: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_Dsc should be TagUndefinedTypeA300SceneTypeDsc (golint)
  • Line 30: warning: exported type CodecExifA300FileSource should have comment or be unexported (golint)
  • Line 33: warning: exported method CodecExifA300FileSource.Encode should have comment or be unexported (golint)
  • Line 55: warning: exported method CodecExifA300FileSource.Decode should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_A302_cfa_pattern.go
  • Line 14: warning: exported type TagA302CfaPattern should have comment or be unexported (golint)
  • Line 20: warning: exported method TagA302CfaPattern.EncoderName should have comment or be unexported (golint)
  • Line 28: warning: exported type CodecA302CfaPattern should have comment or be unexported (golint)
  • Line 31: warning: exported method CodecA302CfaPattern.Encode should have comment or be unexported (golint)
  • Line 63: warning: exported method CodecA302CfaPattern.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_927C_maker_note.go
  • Line 15: warning: exported type Tag927CMakerNote should have comment or be unexported (golint)
  • Line 20: warning: exported method Tag927CMakerNote.EncoderName should have comment or be unexported (golint)
  • Line 41: warning: exported type Codec927CMakerNote should have comment or be unexported (golint)
  • Line 44: warning: exported method Codec927CMakerNote.Encode should have comment or be unexported (golint)
  • Line 61: warning: exported method Codec927CMakerNote.Decode should have comment or be unexported (golint)

• go-exif/parser.go
  • Line 11: warning: exported type Parser should have comment or be unexported (golint)
  • Line 14: warning: exported method Parser.ParseBytes should have comment or be unexported (golint)
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 77: warning: exported method Parser.ParseShorts should have comment or be unexported (golint)
  • Line 98: warning: exported method Parser.ParseLongs should have comment or be unexported (golint)
  • Line 119: warning: exported method Parser.ParseRationals should have comment or be unexported (golint)
  • Line 141: warning: exported method Parser.ParseSignedLongs should have comment or be unexported (golint)
  • Line 165: warning: exported method Parser.ParseSignedRationals should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_A301_scene_type.go
  • Line 13: warning: exported type TagExifA301SceneType should have comment or be unexported (golint)
  • Line 15: warning: exported method TagExifA301SceneType.EncoderName should have comment or be unexported (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUndefinedType_A301_SceneType_DirectlyPhotographedImage should be TagUndefinedTypeA301SceneTypeDirectlyPhotographedImage (golint)
  • Line 24: warning: exported const TagUndefinedType_A301_SceneType_DirectlyPhotographedImage should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported type CodecExifA301SceneType should have comment or be unexported (golint)
  • Line 30: warning: exported method CodecExifA301SceneType.Encode should have comment or be unexported (golint)
  • Line 52: warning: exported method CodecExifA301SceneType.Decode should have comment or be unexported (golint)

• go-exif/v3/tags.go
  • Line 303: warning: should omit 2nd value from range; this loop is equivalent to `for currentIfdPath := range ...` (golint)

• go-exif/exif-read-tool/main.go
  • Line 34: warning: exported type IfdEntry should have comment or be unexported (golint)
  • Line 103: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-exif/v3/ifd_builder_encode.go
  • Line 16: warning: comment on exported const IfdTagEntrySize should be of the form "IfdTagEntrySize ..." (golint)
  • Line 20: warning: exported type ByteWriter should have comment or be unexported (golint)
  • Line 25: warning: exported function NewByteWriter should have comment or be unexported (golint)
  • Line 45: warning: exported method ByteWriter.WriteUint32 should have comment or be unexported (golint)
  • Line 58: warning: exported method ByteWriter.WriteUint16 should have comment or be unexported (golint)
  • Line 71: warning: exported method ByteWriter.WriteFourBytes should have comment or be unexported (golint)
  • Line 78: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 129: warning: exported function NewIfdByteEncoder should have comment or be unexported (golint)
  • Line 135: warning: exported method IfdByteEncoder.Journal should have comment or be unexported (golint)
  • Line 139: warning: exported method IfdByteEncoder.TableSize should have comment or be unexported (golint)
  • Line 161: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 235: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 360: warning: don't use underscores in Go names; var len_ should be len (golint)

• go-exif/gps.go
  • Line 12: warning: exported var ErrGpsCoordinatesNotValid should have comment or be unexported (golint)
  • Line 15: warning: exported type GpsDegrees should have comment or be unexported (golint)
  • Line 24: warning: exported method GpsDegrees.Decimal should have comment or be unexported (golint)
  • Line 29: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 34: warning: exported type GpsInfo should have comment or be unexported (golint)
  • Line 44: warning: exported method GpsInfo.S2CellId should have comment or be unexported (golint)

• go-exif/v3/ifd_enumerate.go
  • Line 748: warning: comment on exported method Ifd.ChildIfdIndex should be of the form "ChildIfdIndex ..." (golint)
  • Line 773: warning: comment on exported method Ifd.ByteOrder should be of the form "ByteOrder ..." (golint)

• go-exif/v3/undefined/exif_8828_oecf.go
  • Line 14: warning: exported type Tag8828Oecf should have comment or be unexported (golint)
  • Line 25: warning: exported method Tag8828Oecf.EncoderName should have comment or be unexported (golint)
  • Line 29: warning: exported type Codec8828Oecf should have comment or be unexported (golint)
  • Line 32: warning: exported method Codec8828Oecf.Encode should have comment or be unexported (golint)
  • Line 73: warning: exported method Codec8828Oecf.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_9000_exif_version.go
  • Line 11: warning: exported type Tag9000ExifVersion should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag9000ExifVersion.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec9000ExifVersion should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec9000ExifVersion.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec9000ExifVersion.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_A20C_spatial_frequency_response.go
  • Line 14: warning: exported type TagA20CSpatialFrequencyResponse should have comment or be unexported (golint)
  • Line 21: warning: exported method TagA20CSpatialFrequencyResponse.EncoderName should have comment or be unexported (golint)
  • Line 29: warning: exported type CodecA20CSpatialFrequencyResponse should have comment or be unexported (golint)
  • Line 32: warning: exported method CodecA20CSpatialFrequencyResponse.Encode should have comment or be unexported (golint)
  • Line 81: warning: exported method CodecA20CSpatialFrequencyResponse.Decode should have comment or be unexported (golint)

• go-exif/v3/common/parser.go
  • Line 18: warning: exported var ErrParseFail should have comment or be unexported (golint)
  • Line 25: warning: comment on exported method Parser.ParseBytes should be of the form "ParseBytes ..." (golint)

• go-exif/v2/exif.go
  • Line 42: warning: exported var ExifBigEndianSignature should have comment or be unexported (golint)
  • Line 47: warning: exported var ErrNoExif should have comment or be unexported (golint)
  • Line 151: warning: exported type ExifHeader should have comment or be unexported (golint)

• go-exif/v2/undefined/gps_001C_gps_area_information.go
  • Line 11: warning: exported type Tag001CGPSAreaInformation should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag001CGPSAreaInformation.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec001CGPSAreaInformation should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec001CGPSAreaInformation.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec001CGPSAreaInformation.Decode should have comment or be unexported (golint)

• go-exif/package.go
  • Line 1: warning: package comment should be of the form "Package exif ..." (golint)

• go-exif/tags_undefined.go
  • Line 15: warning: exported const UnparseableUnknownTagValuePlaceholder should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: don't use underscores in Go names; const TagUnknownType_9298_UserComment_Encoding_ASCII should be TagUnknownType9298UserCommentEncodingASCII (golint)
  • Line 23: warning: exported const TagUnknownType_9298_UserComment_Encoding_ASCII should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUnknownType_9298_UserComment_Encoding_JIS should be TagUnknownType9298UserCommentEncodingJIS (golint)
  • Line 25: warning: don't use underscores in Go names; const TagUnknownType_9298_UserComment_Encoding_UNICODE should be TagUnknownType9298UserCommentEncodingUNICODE (golint)
  • Line 26: warning: don't use underscores in Go names; const TagUnknownType_9298_UserComment_Encoding_UNDEFINED should be TagUnknownType9298UserCommentEncodingUNDEFINED (golint)
  • Line 30: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_Channel_Y should be TagUnknownType9101ComponentsConfigurationChannelY (golint)
  • Line 30: warning: exported const TagUnknownType_9101_ComponentsConfiguration_Channel_Y should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_Channel_Cb should be TagUnknownType9101ComponentsConfigurationChannelCb (golint)
  • Line 32: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_Channel_Cr should be TagUnknownType9101ComponentsConfigurationChannelCr (golint)
  • Line 33: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_Channel_R should be TagUnknownType9101ComponentsConfigurationChannelR (golint)
  • Line 34: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_Channel_G should be TagUnknownType9101ComponentsConfigurationChannelG (golint)
  • Line 35: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_Channel_B should be TagUnknownType9101ComponentsConfigurationChannelB (golint)
  • Line 39: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_OTHER should be TagUnknownType9101ComponentsConfigurationOTHER (golint)
  • Line 39: warning: exported const TagUnknownType_9101_ComponentsConfiguration_OTHER should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_RGB should be TagUnknownType9101ComponentsConfigurationRGB (golint)
  • Line 41: warning: don't use underscores in Go names; const TagUnknownType_9101_ComponentsConfiguration_YCBCR should be TagUnknownType9101ComponentsConfigurationYCBCR (golint)
  • Line 45: warning: don't use underscores in Go names; var TagUnknownType_9298_UserComment_Encoding_Names should be TagUnknownType9298UserCommentEncodingNames (golint)
  • Line 45: warning: exported var TagUnknownType_9298_UserComment_Encoding_Names should have comment or be unexported (golint)
  • Line 52: warning: don't use underscores in Go names; var TagUnknownType_9298_UserComment_Encodings should be TagUnknownType9298UserCommentEncodings (golint)
  • Line 59: warning: don't use underscores in Go names; var TagUnknownType_9101_ComponentsConfiguration_Names should be TagUnknownType9101ComponentsConfigurationNames (golint)
  • Line 65: warning: don't use underscores in Go names; var TagUnknownType_9101_ComponentsConfiguration_Configurations should be TagUnknownType9101ComponentsConfigurationConfigurations (golint)
  • Line 84: warning: exported type UnknownTagValue should have comment or be unexported (golint)
  • Line 90: warning: don't use underscores in Go names; type TagUnknownType_GeneralString should be TagUnknownTypeGeneralString (golint)
  • Line 90: warning: exported type TagUnknownType_GeneralString should have comment or be unexported (golint)
  • Line 92: warning: exported method TagUnknownType_GeneralString.ValueBytes should have comment or be unexported (golint)
  • Line 98: warning: don't use underscores in Go names; type TagUnknownType_9298_UserComment should be TagUnknownType9298UserComment (golint)
  • Line 98: warning: exported type TagUnknownType_9298_UserComment should have comment or be unexported (golint)
  • Line 115: warning: exported method TagUnknownType_9298_UserComment.ValueBytes should have comment or be unexported (golint)
  • Line 131: warning: don't use underscores in Go names; type TagUnknownType_927C_MakerNote should be TagUnknownType927CMakerNote (golint)
  • Line 131: warning: exported type TagUnknownType_927C_MakerNote should have comment or be unexported (golint)
  • Line 152: warning: exported method TagUnknownType_927C_MakerNote.ValueBytes should have comment or be unexported (golint)
  • Line 152: warning: receiver name uc should be consistent with previous receiver name mn for TagUnknownType_927C_MakerNote (golint)
  • Line 158: warning: don't use underscores in Go names; type TagUnknownType_9101_ComponentsConfiguration should be TagUnknownType9101ComponentsConfiguration (golint)
  • Line 158: warning: exported type TagUnknownType_9101_ComponentsConfiguration should have comment or be unexported (golint)
  • Line 167: warning: exported method TagUnknownType_9101_ComponentsConfiguration.ValueBytes should have comment or be unexported (golint)
  • Line 167: warning: receiver name uc should be consistent with previous receiver name cc for TagUnknownType_9101_ComponentsConfiguration (golint)
  • Line 173: warning: exported function EncodeUnknown_9286 should have comment or be unexported (golint)
  • Line 173: warning: don't use underscores in Go names; func EncodeUnknown_9286 should be EncodeUnknown9286 (golint)
  • Line 193: warning: exported type EncodeableUndefinedValue should have comment or be unexported (golint)
  • Line 199: warning: exported function EncodeUndefined should have comment or be unexported (golint)
  • Line 228: warning: don't use underscores in Go names; type TagUnknownType_UnknownValue should be TagUnknownTypeUnknownValue (golint)
  • Line 228: warning: exported type TagUnknownType_UnknownValue should have comment or be unexported (golint)

• go-exif/type.go
  • Line 14: warning: exported type TagTypePrimitive should have comment or be unexported (golint)
  • Line 20: warning: exported method TagTypePrimitive.Size should have comment or be unexported (golint)
  • Line 20: warning: receiver name tagType should be consistent with previous receiver name typeType for TagTypePrimitive (golint)
  • Line 44: warning: exported const TypeByte should have comment (or a comment on this block) or be unexported (golint)
  • Line 62: warning: comment on exported var TypeNames should be of the form "TypeNames ..." (golint)
  • Line 76: warning: exported var TypeNamesR should have comment or be unexported (golint)
  • Line 88: warning: comment on exported var ErrUnhandledUnknownTypedTag should be of the form "ErrUnhandledUnknownTypedTag ..." (golint)
  • Line 94: warning: exported type Rational should have comment or be unexported (golint)
  • Line 99: warning: exported type SignedRational should have comment or be unexported (golint)
  • Line 104: warning: exported function TagTypeSize should have comment or be unexported (golint)
  • Line 162: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 175: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 193: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 206: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 224: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 239: warning: exported function EncodeStringToBytes should have comment or be unexported (golint)

• go-exif/ifd_tag_entry.go
  • Line 16: warning: exported type IfdTagEntry should have comment or be unexported (golint)
  • Line 187: warning: exported function NewIfdTagEntryValueResolver should have comment or be unexported (golint)
  • Line 215: warning: exported method IfdTagEntryValueResolver.Value should have comment or be unexported (golint)

• go-exif/v2/common/testing_common.go
  • Line 21: warning: comment on exported var TestDefaultByteOrder should be of the form "TestDefaultByteOrder ..." (golint)
  • Line 25: warning: exported function GetModuleRootPath should have comment or be unexported (golint)
  • Line 63: warning: exported function GetTestAssetsPath should have comment or be unexported (golint)

• go-exif/v3/common/type.go
  • Line 83: warning: receiver name tagType should be consistent with previous receiver name typeType for TagTypePrimitive (golint)
  • Line 103: warning: receiver name tagType should be consistent with previous receiver name typeType for TagTypePrimitive (golint)
  • Line 121: warning: comment on exported var TypeNames should be of the form "TypeNames ..." (golint)
  • Line 171: warning: comment on exported function FormatFromType should be of the form "FormatFromType ..." (golint)
  • Line 285: warning: comment on exported function FormatFromBytes should be of the form "FormatFromBytes ..." (golint)

• go-exif/exif.go
  • Line 35: warning: comment on exported var TestDefaultByteOrder should be of the form "TestDefaultByteOrder ..." (golint)
  • Line 38: warning: exported var BigEndianBoBytes should have comment or be unexported (golint)
  • Line 58: warning: exported var ErrNoExif should have comment or be unexported (golint)
  • Line 120: warning: exported type ExifHeader should have comment or be unexported (golint)

• go-exif/ifd_builder.go
  • Line 23: warning: exported var ErrTagEntryNotFound should have comment or be unexported (golint)
  • Line 27: warning: exported type IfdBuilderTagValue should have comment or be unexported (golint)
  • Line 50: warning: exported function NewIfdBuilderTagValueFromBytes should have comment or be unexported (golint)
  • Line 56: warning: exported function NewIfdBuilderTagValueFromIfdBuilder should have comment or be unexported (golint)
  • Line 68: warning: exported method IfdBuilderTagValue.Bytes should have comment or be unexported (golint)
  • Line 78: warning: exported method IfdBuilderTagValue.IsIb should have comment or be unexported (golint)
  • Line 82: warning: exported method IfdBuilderTagValue.Ib should have comment or be unexported (golint)
  • Line 92: warning: exported type BuilderTag should have comment or be unexported (golint)
  • Line 109: warning: exported function NewBuilderTag should have comment or be unexported (golint)
  • Line 119: warning: exported function NewChildIfdBuilderTag should have comment or be unexported (golint)
  • Line 128: warning: exported method BuilderTag.Value should have comment or be unexported (golint)
  • Line 147: warning: exported method BuilderTag.SetValue should have comment or be unexported (golint)
  • Line 208: warning: exported type IfdBuilder should have comment or be unexported (golint)
  • Line 244: warning: exported function NewIfdBuilder should have comment or be unexported (golint)
  • Line 337: warning: exported method IfdBuilder.NextIb should have comment or be unexported (golint)
  • Line 341: warning: exported method IfdBuilder.ChildWithTagId should have comment or be unexported (golint)
  • Line 504: warning: exported method IfdBuilder.Tags should have comment or be unexported (golint)
  • Line 561: warning: exported method IfdBuilder.Thumbnail should have comment or be unexported (golint)
  • Line 636: warning: exported method IfdBuilder.PrintTagTree should have comment or be unexported (golint)
  • Line 677: warning: exported method IfdBuilder.PrintIfdTree should have comment or be unexported (golint)
  • Line 724: warning: exported method IfdBuilder.DumpToStrings should have comment or be unexported (golint)
  • Line 728: warning: exported method IfdBuilder.SetNextIb should have comment or be unexported (golint)
  • Line 740: warning: exported method IfdBuilder.DeleteN should have comment or be unexported (golint)
  • Line 771: warning: exported method IfdBuilder.DeleteFirst should have comment or be unexported (golint)
  • Line 784: warning: exported method IfdBuilder.DeleteAll should have comment or be unexported (golint)
  • Line 805: warning: exported method IfdBuilder.ReplaceAt should have comment or be unexported (golint)
  • Line 823: warning: exported method IfdBuilder.Replace should have comment or be unexported (golint)
  • Line 859: warning: exported method IfdBuilder.FindN should have comment or be unexported (golint)
  • Line 880: warning: exported method IfdBuilder.Find should have comment or be unexported (golint)
  • Line 897: warning: exported method IfdBuilder.FindTag should have comment or be unexported (golint)
  • Line 916: warning: exported method IfdBuilder.FindTagWithName should have comment or be unexported (golint)
  • Line 957: warning: exported method IfdBuilder.Add should have comment or be unexported (golint)
  • Line 1003: warning: exported method IfdBuilder.NewBuilderTagFromBuilder should have comment or be unexported (golint)

• go-exif/v3/common/ifd.go
  • Line 16: warning: exported var ErrChildIfdNotMapped should have comment or be unexported (golint)
  • Line 409: warning: exported function NewIfdTag should have comment or be unexported (golint)
  • Line 466: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 646: warning: comment on exported var IfdGpsInfoStandardIfdIdentity should be of the form "IfdGpsInfoStandardIfdIdentity ..." (golint)

• go-exif/tags.go
  • Line 13: warning: exported const ThumbnailOffsetTagId should have comment (or a comment on this block) or be unexported (golint)
  • Line 58: warning: exported type IndexedTag should have comment or be unexported (golint)
  • Line 69: warning: exported method IndexedTag.IsName should have comment or be unexported (golint)
  • Line 73: warning: exported method IndexedTag.Is should have comment or be unexported (golint)
  • Line 77: warning: exported type TagIndex should have comment or be unexported (golint)
  • Line 82: warning: exported function NewTagIndex should have comment or be unexported (golint)
  • Line 91: warning: exported method TagIndex.Add should have comment or be unexported (golint)
  • Line 155: warning: comment on exported method TagIndex.GetWithName should be of the form "GetWithName ..." (golint)

• go-exif/v3/ifd_builder.go
  • Line 26: warning: exported var ErrTagEntryNotFound should have comment or be unexported (golint)
  • Line 30: warning: exported type IfdBuilderTagValue should have comment or be unexported (golint)
  • Line 53: warning: exported function NewIfdBuilderTagValueFromBytes should have comment or be unexported (golint)
  • Line 59: warning: exported function NewIfdBuilderTagValueFromIfdBuilder should have comment or be unexported (golint)
  • Line 71: warning: exported method IfdBuilderTagValue.Bytes should have comment or be unexported (golint)
  • Line 81: warning: exported method IfdBuilderTagValue.IsIb should have comment or be unexported (golint)
  • Line 85: warning: exported method IfdBuilderTagValue.Ib should have comment or be unexported (golint)
  • Line 95: warning: exported type BuilderTag should have comment or be unexported (golint)
  • Line 112: warning: exported function NewBuilderTag should have comment or be unexported (golint)
  • Line 122: warning: exported function NewChildIfdBuilderTag should have comment or be unexported (golint)
  • Line 131: warning: exported method BuilderTag.Value should have comment or be unexported (golint)
  • Line 150: warning: exported method BuilderTag.SetValue should have comment or be unexported (golint)
  • Line 220: warning: exported type IfdBuilder should have comment or be unexported (golint)
  • Line 245: warning: exported function NewIfdBuilder should have comment or be unexported (golint)
  • Line 302: warning: exported method IfdBuilder.IfdIdentity should have comment or be unexported (golint)
  • Line 306: warning: exported method IfdBuilder.NextIb should have comment or be unexported (golint)
  • Line 310: warning: exported method IfdBuilder.ChildWithTagId should have comment or be unexported (golint)
  • Line 473: warning: exported method IfdBuilder.Tags should have comment or be unexported (golint)
  • Line 530: warning: exported method IfdBuilder.Thumbnail should have comment or be unexported (golint)
  • Line 605: warning: exported method IfdBuilder.PrintTagTree should have comment or be unexported (golint)
  • Line 646: warning: exported method IfdBuilder.PrintIfdTree should have comment or be unexported (golint)
  • Line 693: warning: exported method IfdBuilder.DumpToStrings should have comment or be unexported (golint)
  • Line 697: warning: exported method IfdBuilder.SetNextIb should have comment or be unexported (golint)
  • Line 709: warning: exported method IfdBuilder.DeleteN should have comment or be unexported (golint)
  • Line 740: warning: exported method IfdBuilder.DeleteFirst should have comment or be unexported (golint)
  • Line 753: warning: exported method IfdBuilder.DeleteAll should have comment or be unexported (golint)
  • Line 774: warning: exported method IfdBuilder.ReplaceAt should have comment or be unexported (golint)
  • Line 792: warning: exported method IfdBuilder.Replace should have comment or be unexported (golint)
  • Line 828: warning: exported method IfdBuilder.FindN should have comment or be unexported (golint)
  • Line 849: warning: exported method IfdBuilder.Find should have comment or be unexported (golint)
  • Line 866: warning: exported method IfdBuilder.FindTag should have comment or be unexported (golint)
  • Line 885: warning: exported method IfdBuilder.FindTagWithName should have comment or be unexported (golint)
  • Line 926: warning: exported method IfdBuilder.Add should have comment or be unexported (golint)
  • Line 972: warning: exported method IfdBuilder.NewBuilderTagFromBuilder should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_iop_0002_interop_version.go
  • Line 11: warning: exported type Tag0002InteropVersion should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag0002InteropVersion.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec0002InteropVersion should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec0002InteropVersion.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec0002InteropVersion.Decode should have comment or be unexported (golint)

• go-exif/v3/common/testing_common.go
  • Line 21: warning: comment on exported var TestDefaultByteOrder should be of the form "TestDefaultByteOrder ..." (golint)
  • Line 25: warning: exported function GetModuleRootPath should have comment or be unexported (golint)
  • Line 63: warning: exported function GetTestAssetsPath should have comment or be unexported (golint)

• go-exif/ifd_builder_encode.go
  • Line 14: warning: comment on exported const IfdTagEntrySize should be of the form "IfdTagEntrySize ..." (golint)
  • Line 18: warning: exported type ByteWriter should have comment or be unexported (golint)
  • Line 23: warning: exported function NewByteWriter should have comment or be unexported (golint)
  • Line 43: warning: exported method ByteWriter.WriteUint32 should have comment or be unexported (golint)
  • Line 56: warning: exported method ByteWriter.WriteUint16 should have comment or be unexported (golint)
  • Line 69: warning: exported method ByteWriter.WriteFourBytes should have comment or be unexported (golint)
  • Line 76: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 127: warning: exported function NewIfdByteEncoder should have comment or be unexported (golint)
  • Line 133: warning: exported method IfdByteEncoder.Journal should have comment or be unexported (golint)
  • Line 137: warning: exported method IfdByteEncoder.TableSize should have comment or be unexported (golint)
  • Line 159: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 233: warning: don't use underscores in Go names; var len_ should be len (golint)
  • Line 358: warning: don't use underscores in Go names; var len_ should be len (golint)

• go-exif/value_context.go
  • Line 59: warning: exported method ValueContext.SetUnknownValueType should have comment or be unexported (golint)
  • Line 63: warning: exported method ValueContext.UnitCount should have comment or be unexported (golint)
  • Line 67: warning: exported method ValueContext.ValueOffset should have comment or be unexported (golint)
  • Line 71: warning: exported method ValueContext.RawValueOffset should have comment or be unexported (golint)
  • Line 75: warning: exported method ValueContext.AddressableData should have comment or be unexported (golint)
  • Line 116: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 146: warning: comment on exported method ValueContext.FormatFirst should be of the form "FormatFirst ..." (golint)
  • Line 164: warning: exported method ValueContext.ReadBytes should have comment or be unexported (golint)
  • Line 180: warning: exported method ValueContext.ReadAscii should have comment or be unexported (golint)
  • Line 196: warning: exported method ValueContext.ReadAsciiNoNul should have comment or be unexported (golint)
  • Line 212: warning: exported method ValueContext.ReadShorts should have comment or be unexported (golint)
  • Line 228: warning: exported method ValueContext.ReadLongs should have comment or be unexported (golint)
  • Line 244: warning: exported method ValueContext.ReadRationals should have comment or be unexported (golint)
  • Line 260: warning: exported method ValueContext.ReadSignedLongs should have comment or be unexported (golint)
  • Line 276: warning: exported method ValueContext.ReadSignedRationals should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_9286_user_comment.go
  • Line 19: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_ASCII should be TagUndefinedType9286UserCommentEncodingASCII (golint)
  • Line 19: warning: exported const TagUndefinedType_9286_UserComment_Encoding_ASCII should have comment (or a comment on this block) or be unexported (golint)
  • Line 20: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_JIS should be TagUndefinedType9286UserCommentEncodingJIS (golint)
  • Line 21: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_UNICODE should be TagUndefinedType9286UserCommentEncodingUNICODE (golint)
  • Line 22: warning: don't use underscores in Go names; const TagUndefinedType_9286_UserComment_Encoding_UNDEFINED should be TagUndefinedType9286UserCommentEncodingUNDEFINED (golint)
  • Line 26: warning: don't use underscores in Go names; var TagUndefinedType_9286_UserComment_Encoding_Names should be TagUndefinedType9286UserCommentEncodingNames (golint)
  • Line 26: warning: exported var TagUndefinedType_9286_UserComment_Encoding_Names should have comment or be unexported (golint)
  • Line 33: warning: don't use underscores in Go names; var TagUndefinedType_9286_UserComment_Encodings should be TagUndefinedType9286UserCommentEncodings (golint)
  • Line 41: warning: exported type Tag9286UserComment should have comment or be unexported (golint)
  • Line 46: warning: exported method Tag9286UserComment.EncoderName should have comment or be unexported (golint)
  • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 66: warning: exported type Codec9286UserComment should have comment or be unexported (golint)
  • Line 69: warning: exported method Codec9286UserComment.Encode should have comment or be unexported (golint)
  • Line 96: warning: exported method Codec9286UserComment.Decode should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_A20C_spatial_frequency_response.go
  • Line 14: warning: exported type TagA20CSpatialFrequencyResponse should have comment or be unexported (golint)
  • Line 21: warning: exported method TagA20CSpatialFrequencyResponse.EncoderName should have comment or be unexported (golint)
  • Line 29: warning: exported type CodecA20CSpatialFrequencyResponse should have comment or be unexported (golint)
  • Line 32: warning: exported method CodecA20CSpatialFrequencyResponse.Encode should have comment or be unexported (golint)
  • Line 81: warning: exported method CodecA20CSpatialFrequencyResponse.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_A300_file_source.go
  • Line 13: warning: exported type TagExifA300FileSource should have comment or be unexported (golint)
  • Line 15: warning: exported method TagExifA300FileSource.EncoderName should have comment or be unexported (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_Others should be TagUndefinedTypeA300SceneTypeOthers (golint)
  • Line 24: warning: exported const TagUndefinedType_A300_SceneType_Others should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_ScannerOfTransparentType should be TagUndefinedTypeA300SceneTypeScannerOfTransparentType (golint)
  • Line 26: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_ScannerOfReflexType should be TagUndefinedTypeA300SceneTypeScannerOfReflexType (golint)
  • Line 27: warning: don't use underscores in Go names; const TagUndefinedType_A300_SceneType_Dsc should be TagUndefinedTypeA300SceneTypeDsc (golint)
  • Line 30: warning: exported type CodecExifA300FileSource should have comment or be unexported (golint)
  • Line 33: warning: exported method CodecExifA300FileSource.Encode should have comment or be unexported (golint)
  • Line 55: warning: exported method CodecExifA300FileSource.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_A302_cfa_pattern.go
  • Line 14: warning: exported type TagA302CfaPattern should have comment or be unexported (golint)
  • Line 20: warning: exported method TagA302CfaPattern.EncoderName should have comment or be unexported (golint)
  • Line 28: warning: exported type CodecA302CfaPattern should have comment or be unexported (golint)
  • Line 31: warning: exported method CodecA302CfaPattern.Encode should have comment or be unexported (golint)
  • Line 63: warning: exported method CodecA302CfaPattern.Decode should have comment or be unexported (golint)

• go-exif/type_encode.go
  • Line 25: warning: exported type ValueEncoder should have comment or be unexported (golint)
  • Line 29: warning: exported function NewValueEncoder should have comment or be unexported (golint)

• go-exif/v2/ifd_builder.go
  • Line 26: warning: exported var ErrTagEntryNotFound should have comment or be unexported (golint)
  • Line 30: warning: exported type IfdBuilderTagValue should have comment or be unexported (golint)
  • Line 53: warning: exported function NewIfdBuilderTagValueFromBytes should have comment or be unexported (golint)
  • Line 59: warning: exported function NewIfdBuilderTagValueFromIfdBuilder should have comment or be unexported (golint)
  • Line 71: warning: exported method IfdBuilderTagValue.Bytes should have comment or be unexported (golint)
  • Line 81: warning: exported method IfdBuilderTagValue.IsIb should have comment or be unexported (golint)
  • Line 85: warning: exported method IfdBuilderTagValue.Ib should have comment or be unexported (golint)
  • Line 95: warning: exported type BuilderTag should have comment or be unexported (golint)
  • Line 112: warning: exported function NewBuilderTag should have comment or be unexported (golint)
  • Line 122: warning: exported function NewChildIfdBuilderTag should have comment or be unexported (golint)
  • Line 131: warning: exported method BuilderTag.Value should have comment or be unexported (golint)
  • Line 150: warning: exported method BuilderTag.SetValue should have comment or be unexported (golint)
  • Line 220: warning: exported type IfdBuilder should have comment or be unexported (golint)
  • Line 245: warning: exported function NewIfdBuilder should have comment or be unexported (golint)
  • Line 302: warning: exported method IfdBuilder.IfdIdentity should have comment or be unexported (golint)
  • Line 306: warning: exported method IfdBuilder.NextIb should have comment or be unexported (golint)
  • Line 310: warning: exported method IfdBuilder.ChildWithTagId should have comment or be unexported (golint)
  • Line 473: warning: exported method IfdBuilder.Tags should have comment or be unexported (golint)
  • Line 530: warning: exported method IfdBuilder.Thumbnail should have comment or be unexported (golint)
  • Line 605: warning: exported method IfdBuilder.PrintTagTree should have comment or be unexported (golint)
  • Line 646: warning: exported method IfdBuilder.PrintIfdTree should have comment or be unexported (golint)
  • Line 693: warning: exported method IfdBuilder.DumpToStrings should have comment or be unexported (golint)
  • Line 697: warning: exported method IfdBuilder.SetNextIb should have comment or be unexported (golint)
  • Line 709: warning: exported method IfdBuilder.DeleteN should have comment or be unexported (golint)
  • Line 740: warning: exported method IfdBuilder.DeleteFirst should have comment or be unexported (golint)
  • Line 753: warning: exported method IfdBuilder.DeleteAll should have comment or be unexported (golint)
  • Line 774: warning: exported method IfdBuilder.ReplaceAt should have comment or be unexported (golint)
  • Line 792: warning: exported method IfdBuilder.Replace should have comment or be unexported (golint)
  • Line 828: warning: exported method IfdBuilder.FindN should have comment or be unexported (golint)
  • Line 849: warning: exported method IfdBuilder.Find should have comment or be unexported (golint)
  • Line 866: warning: exported method IfdBuilder.FindTag should have comment or be unexported (golint)
  • Line 885: warning: exported method IfdBuilder.FindTagWithName should have comment or be unexported (golint)
  • Line 926: warning: exported method IfdBuilder.Add should have comment or be unexported (golint)
  • Line 972: warning: exported method IfdBuilder.NewBuilderTagFromBuilder should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_A000_flashpix_version.go
  • Line 11: warning: exported type TagA000FlashpixVersion should have comment or be unexported (golint)
  • Line 15: warning: exported method TagA000FlashpixVersion.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type CodecA000FlashpixVersion should have comment or be unexported (golint)
  • Line 26: warning: exported method CodecA000FlashpixVersion.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method CodecA000FlashpixVersion.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/gps_001B_gps_processing_method.go
  • Line 11: warning: exported type Tag001BGPSProcessingMethod should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag001BGPSProcessingMethod.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec001BGPSProcessingMethod should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec001BGPSProcessingMethod.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec001BGPSProcessingMethod.Decode should have comment or be unexported (golint)

• go-exif/v2/common/parser.go
  • Line 19: warning: comment on exported method Parser.ParseBytes should be of the form "ParseBytes ..." (golint)

• go-exif/utility.go
  • Line 13: warning: exported function DumpBytes should have comment or be unexported (golint)
  • Line 22: warning: exported function DumpBytesClause should have comment or be unexported (golint)
  • Line 38: warning: exported function DumpBytesToString should have comment or be unexported (golint)
  • Line 54: warning: exported function DumpBytesClauseToString should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_8828_oecf.go
  • Line 14: warning: exported type Tag8828Oecf should have comment or be unexported (golint)
  • Line 25: warning: exported method Tag8828Oecf.EncoderName should have comment or be unexported (golint)
  • Line 29: warning: exported type Codec8828Oecf should have comment or be unexported (golint)
  • Line 32: warning: exported method Codec8828Oecf.Encode should have comment or be unexported (golint)
  • Line 73: warning: exported method Codec8828Oecf.Decode should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_9000_exif_version.go
  • Line 11: warning: exported type Tag9000ExifVersion should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag9000ExifVersion.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec9000ExifVersion should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec9000ExifVersion.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec9000ExifVersion.Decode should have comment or be unexported (golint)

• go-exif/v2/undefined/gps_001B_gps_processing_method.go
  • Line 11: warning: exported type Tag001BGPSProcessingMethod should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag001BGPSProcessingMethod.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec001BGPSProcessingMethod should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec001BGPSProcessingMethod.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec001BGPSProcessingMethod.Decode should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_A000_flashpix_version.go
  • Line 11: warning: exported type TagA000FlashpixVersion should have comment or be unexported (golint)
  • Line 15: warning: exported method TagA000FlashpixVersion.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type CodecA000FlashpixVersion should have comment or be unexported (golint)
  • Line 26: warning: exported method CodecA000FlashpixVersion.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method CodecA000FlashpixVersion.Decode should have comment or be unexported (golint)

• go-exif/v3/undefined/exif_9101_components_configuration.go
  • Line 15: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_Y should be TagUndefinedType9101ComponentsConfigurationChannelY (golint)
  • Line 15: warning: exported const TagUndefinedType_9101_ComponentsConfiguration_Channel_Y should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_Cb should be TagUndefinedType9101ComponentsConfigurationChannelCb (golint)
  • Line 17: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_Cr should be TagUndefinedType9101ComponentsConfigurationChannelCr (golint)
  • Line 18: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_R should be TagUndefinedType9101ComponentsConfigurationChannelR (golint)
  • Line 19: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_G should be TagUndefinedType9101ComponentsConfigurationChannelG (golint)
  • Line 20: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_Channel_B should be TagUndefinedType9101ComponentsConfigurationChannelB (golint)
  • Line 24: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_OTHER should be TagUndefinedType9101ComponentsConfigurationOTHER (golint)
  • Line 24: warning: exported const TagUndefinedType_9101_ComponentsConfiguration_OTHER should have comment (or a comment on this block) or be unexported (golint)
  • Line 25: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_RGB should be TagUndefinedType9101ComponentsConfigurationRGB (golint)
  • Line 26: warning: don't use underscores in Go names; const TagUndefinedType_9101_ComponentsConfiguration_YCBCR should be TagUndefinedType9101ComponentsConfigurationYCBCR (golint)
  • Line 30: warning: don't use underscores in Go names; var TagUndefinedType_9101_ComponentsConfiguration_Names should be TagUndefinedType9101ComponentsConfigurationNames (golint)
  • Line 30: warning: exported var TagUndefinedType_9101_ComponentsConfiguration_Names should have comment or be unexported (golint)
  • Line 36: warning: don't use underscores in Go names; var TagUndefinedType_9101_ComponentsConfiguration_Configurations should be TagUndefinedType9101ComponentsConfigurationConfigurations (golint)
  • Line 53: warning: exported type TagExif9101ComponentsConfiguration should have comment or be unexported (golint)
  • Line 58: warning: exported method TagExif9101ComponentsConfiguration.EncoderName should have comment or be unexported (golint)
  • Line 66: warning: exported type CodecExif9101ComponentsConfiguration should have comment or be unexported (golint)
  • Line 69: warning: exported method CodecExif9101ComponentsConfiguration.Encode should have comment or be unexported (golint)
  • Line 84: warning: exported method CodecExif9101ComponentsConfiguration.Decode should have comment or be unexported (golint)

• go-exif/v2/common/ifd.go
  • Line 16: warning: exported var ErrChildIfdNotMapped should have comment or be unexported (golint)
  • Line 410: warning: exported function NewIfdTag should have comment or be unexported (golint)
  • Line 467: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 647: warning: comment on exported var IfdGpsInfoStandardIfdIdentity should be of the form "IfdGpsInfoStandardIfdIdentity ..." (golint)
  • Line 655: warning: exported var IfdPathStandard should have comment or be unexported (golint)

• go-exif/ifd_enumerate.go
  • Line 22: warning: exported var ErrNoThumbnail should have comment or be unexported (golint)
  • Line 28: warning: exported var ValidGpsVersions should have comment or be unexported (golint)
  • Line 59: warning: exported function NewIfdTagEnumerator should have comment or be unexported (golint)
  • Line 121: warning: exported type IfdEnumerate should have comment or be unexported (golint)
  • Line 130: warning: exported function NewIfdEnumerate should have comment or be unexported (golint)
  • Line 213: warning: exported method IfdEnumerate.GetValueContext should have comment or be unexported (golint)
  • Line 293: warning: comment on exported type RawTagWalk should be of the form "RawTagWalk ..." (with optional leading article) (golint)
  • Line 303: warning: exported type RawTagWalkLegacyWrapper should have comment or be unexported (golint)
  • Line 307: warning: exported method RawTagWalkLegacyWrapper.Visit should have comment or be unexported (golint)
  • Line 536: warning: exported method Ifd.ChildWithIfdPath should have comment or be unexported (golint)
  • Line 553: warning: exported method Ifd.TagValue should have comment or be unexported (golint)
  • Line 566: warning: exported method Ifd.TagValueBytes should have comment or be unexported (golint)
  • Line 635: warning: exported method Ifd.Thumbnail should have comment or be unexported (golint)
  • Line 1000: warning: exported type ParsedTagVisitor should have comment or be unexported (golint)
  • Line 1002: warning: exported method Ifd.EnumerateTagsRecursively should have comment or be unexported (golint)
  • Line 1026: warning: exported method Ifd.GetValueContext should have comment or be unexported (golint)
  • Line 1033: warning: exported type QueuedIfd should have comment or be unexported (golint)
  • Line 1050: warning: exported type IfdIndex should have comment or be unexported (golint)
  • Line 1057: warning: comment on exported method IfdEnumerate.Collect should be of the form "Collect ..." (golint)
  • Line 1158: warning: don't use underscores in Go names; var list_ should be list (golint)
  • Line 1294: warning: exported function FindIfdFromRootIfd should have comment or be unexported (golint)

• go-exif/v2/undefined/exif_iop_0002_interop_version.go
  • Line 11: warning: exported type Tag0002InteropVersion should have comment or be unexported (golint)
  • Line 15: warning: exported method Tag0002InteropVersion.EncoderName should have comment or be unexported (golint)
  • Line 23: warning: exported type Codec0002InteropVersion should have comment or be unexported (golint)
  • Line 26: warning: exported method Codec0002InteropVersion.Encode should have comment or be unexported (golint)
  • Line 41: warning: exported method Codec0002InteropVersion.Decode should have comment or be unexported (golint)

• go-exif/v3/data_layer.go
  • Line 10: warning: exported type ExifBlobSeeker should have comment or be unexported (golint)
  • Line 21: warning: exported function NewExifReadSeeker should have comment or be unexported (golint)
  • Line 27: warning: exported function NewExifReadSeekerWithBytes should have comment or be unexported (golint)
  • Line 34: warning: comment on exported method ExifReadSeeker.GetReadSeeker should be of the form "GetReadSeeker ..." (golint)

• go-exif/v3/exif.go
  • Line 42: warning: exported var ExifBigEndianSignature should have comment or be unexported (golint)
  • Line 47: warning: exported var ErrNoExif should have comment or be unexported (golint)
  • Line 222: warning: exported type ExifHeader should have comment or be unexported (golint)

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• go-exif/v3/common/type.go
  • Line 176: warning: cyclomatic complexity 26 of function FormatFromType() is high (> 15) (gocyclo)

• go-exif/v2/exif_test.go
  • Line 239: warning: cyclomatic complexity 34 of function TestCollect() is high (> 15) (gocyclo)

• go-exif/v2/ifd_builder_encode_test.go
  • Line 351: warning: cyclomatic complexity 20 of function Test_IfdByteEncoder_encodeTagToBytes_childIfd__withAllocate() is high (> 15) (gocyclo)

• go-exif/v3/ifd_enumerate.go
  • Line 429: warning: cyclomatic complexity 23 of function (*IfdEnumerate).parseIfd() is high (> 15) (gocyclo)
  • Line 1102: warning: cyclomatic complexity 20 of function (*Ifd).GpsInfo() is high (> 15) (gocyclo)

• go-exif/v3/command/exif-read-tool/main.go
  • Line 66: warning: cyclomatic complexity 18 of function main() is high (> 15) (gocyclo)

• go-exif/v2/exif-read-tool/main.go
  • Line 64: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

• go-exif/v2/common/type.go
  • Line 156: warning: cyclomatic complexity 30 of function FormatFromType() is high (> 15) (gocyclo)

• go-exif/v2/ifd_builder_test.go
  • Line 1619: warning: cyclomatic complexity 21 of function TestIfdBuilder_NewIfdBuilderFromExistingChain_RealData() is high (> 15) (gocyclo)
  • Line 2244: warning: cyclomatic complexity 17 of function TestGetOrCreateIbFromRootIb__Child() is high (> 15) (gocyclo)

• go-exif/v3/ifd_builder_test.go
  • Line 1571: warning: cyclomatic complexity 21 of function TestIfdBuilder_NewIfdBuilderFromExistingChain_RealData() is high (> 15) (gocyclo)
  • Line 2178: warning: cyclomatic complexity 17 of function TestGetOrCreateIbFromRootIb__Child() is high (> 15) (gocyclo)

• go-exif/v2/ifd_builder.go
  • Line 993: warning: cyclomatic complexity 24 of function (*IfdBuilder).AddTagsFromExisting() is high (> 15) (gocyclo)

• go-exif/v3/ifd_builder.go
  • Line 993: warning: cyclomatic complexity 24 of function (*IfdBuilder).AddTagsFromExisting() is high (> 15) (gocyclo)

• go-exif/v2/ifd_enumerate.go
  • Line 967: warning: cyclomatic complexity 20 of function (*Ifd).GpsInfo() is high (> 15) (gocyclo)
  • Line 372: warning: cyclomatic complexity 19 of function (*IfdEnumerate).parseIfd() is high (> 15) (gocyclo)

• go-exif/v3/exif_test.go
  • Line 242: warning: cyclomatic complexity 34 of function TestCollect() is high (> 15) (gocyclo)

• go-exif/v3/ifd_builder_encode_test.go
  • Line 343: warning: cyclomatic complexity 20 of function Test_IfdByteEncoder_encodeTagToBytes_childIfd__withAllocate() is high (> 15) (gocyclo)

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

• go-exif/type_encode_test.go
  • Line 32: warning: ineffectual assignment to err (ineffassign)
  • Line 65: warning: ineffectual assignment to err (ineffassign)
  • Line 97: warning: ineffectual assignment to err (ineffassign)
  • Line 132: warning: ineffectual assignment to err (ineffassign)
  • Line 167: warning: ineffectual assignment to err (ineffassign)
  • Line 228: warning: ineffectual assignment to err (ineffassign)
  • Line 263: warning: ineffectual assignment to err (ineffassign)
  • Line 324: warning: ineffectual assignment to err (ineffassign)

• go-exif/exif_test.go
  • Line 87: warning: ineffectual assignment to valueString (ineffassign)

• go-exif/ifd_builder_test.go
  • Line 1656: warning: ineffectual assignment to thumbnailData (ineffassign)
  • Line 1704: warning: ineffectual assignment to updatedExif (ineffassign)

• go-exif/ifd_enumerate.go
  • Line 1329: warning: ineffectual assignment to i (ineffassign)

• go-exif/ifd_enumerate_test.go
  • Line 105: warning: ineffectual assignment to err (ineffassign)
  • Line 153: warning: ineffectual assignment to err (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!