gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• signatory/pkg/signatory/signatory_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• signatory/pkg/tezos/message_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• signatory/pkg/tezos/message.go
  • Line 208: warning: cyclomatic complexity 82 of function parseOperation() is high (> 15) (gocyclo)
  • Line 747: warning: cyclomatic complexity 24 of function parseBlockHeader() is high (> 15) (gocyclo)

• signatory/pkg/utils/utils.go
  • Line 17: warning: cyclomatic complexity 18 of function readString() is high (> 15) (gocyclo)
  • Line 84: warning: cyclomatic complexity 18 of function ParseMap() is high (> 15) (gocyclo)

• signatory/pkg/vault/azure/azure.go
  • Line 163: warning: cyclomatic complexity 18 of function (*azureIterator).Next() is high (> 15) (gocyclo)

• signatory/pkg/vault/cloudkms/cloudkms.go
  • Line 260: warning: cyclomatic complexity 17 of function (*Vault).Import() is high (> 15) (gocyclo)
  • Line 102: warning: cyclomatic complexity 16 of function (*cloudKMSIterator).Next() is high (> 15) (gocyclo)

golint78%

Golint is a linter for Go source code.

• signatory/pkg/vault/vault.go
  • Line 62: warning: exported function RegisterVault should have comment or be unexported (golint)

• signatory/cmd/commands/list.go
  • Line 28: warning: exported function NewListCommand should have comment or be unexported (golint)

• signatory/pkg/metrics/buildinfo.go
  • Line 10: warning: exported var GitRevision should have comment or be unexported (golint)

• signatory/pkg/metrics/vaultmetrics.go
  • Line 11: warning: exported type HttpError should have comment or be unexported (golint)

• signatory/pkg/errors/errors.go
  • Line 7: warning: exported type HTTPError should have comment or be unexported (golint)
  • Line 19: warning: exported function Wrap should have comment or be unexported (golint)
  • Line 26: warning: exported function New should have comment or be unexported (golint)

• signatory/pkg/config/config.go
  • Line 53: warning: exported function Validator should have comment or be unexported (golint)

• signatory/pkg/utils/options.go
  • Line 9: warning: exported type Options should have comment or be unexported (golint)
  • Line 11: warning: exported method Options.GetString should have comment or be unexported (golint)
  • Line 39: warning: exported method Options.GetInt should have comment or be unexported (golint)
  • Line 53: warning: exported method Options.GetBool should have comment or be unexported (golint)

• signatory/pkg/server/server.go
  • Line 100: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• signatory/cmd/commands/import.go
  • Line 12: warning: exported function NewImportCommand should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign95%

IneffAssign detects ineffectual assignments in Go code.

• signatory/pkg/vault/cloudkms/cloudkms.go
  • Line 238: warning: ineffectual assignment to err (ineffassign)

• signatory/pkg/vault/yubi/yubi.go
  • Line 122: warning: ineffectual assignment to err (ineffassign)
  • Line 149: warning: ineffectual assignment to err (ineffassign)
  • Line 188: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• signatory/pkg/vault/cloudkms/cloudkms.go
  • Line 62: warning: "returnd" is a misspelling of "returned" (misspell)