Preparing report...

Report for github.com/edgexfoundry/device-mqtt-go

A+    Excellent!    Found 6 issues across 11 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo81%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint63%

Golint is a linter for Go source code.

    • device-mqtt-go/version.go
    • Line 7: warning: don't use an underscore in package name (golint)
    • Line 9: warning: comment on exported var Version should be of the form "Version ..." (golint)
    • device-mqtt-go/internal/driver/driver.go
    • Line 31: warning: exported type Config should have comment or be unexported (golint)
    • Line 48: warning: exported type Driver should have comment or be unexported (golint)
    • Line 55: warning: exported function NewProtocolDriver should have comment or be unexported (golint)
    • Line 62: warning: exported method Driver.Initialize should have comment or be unexported (golint)
    • Line 91: warning: exported method Driver.DisconnectDevice should have comment or be unexported (golint)
    • Line 96: warning: exported method Driver.HandleReadCommands should have comment or be unexported (golint)
    • Line 187: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 194: warning: exported method Driver.HandleWriteCommands should have comment or be unexported (golint)
    • Line 254: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 290: warning: exported method Driver.Stop should have comment or be unexported (golint)
    • Line 463: warning: exported method Driver.AddDevice should have comment or be unexported (golint)
    • Line 468: warning: exported method Driver.UpdateDevice should have comment or be unexported (golint)
    • Line 473: warning: exported method Driver.RemoveDevice should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell81%

Misspell Finds commonly misspelled English words