Report for github.com/edgexfoundry/device-sdk-go
A+ Excellent! Found 41 issues across 74 files
gofmt95%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
device-sdk-go/internal/cache/profiles_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
device-sdk-go/internal/application/command_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
device-sdk-go/pkg/service/async_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo97%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
device-sdk-go/internal/application/command.go
- Line 385: warning: cyclomatic complexity 62 of function createCommandValueFromDeviceResource() is high (> 15) (gocyclo)
- Line 285: warning: cyclomatic complexity 19 of function (*CommandProcessor).WriteDeviceCommand() is high (> 15) (gocyclo)
-
-
device-sdk-go/pkg/models/commandvalue.go
- Line 434: warning: cyclomatic complexity 28 of function validate() is high (> 15) (gocyclo)
golint48%
Golint is a linter for Go source code.
-
-
device-sdk-go/pkg/models/manager.go
- Line 8: warning: exported type AutoEventManager should have comment or be unexported (golint)
-
-
device-sdk-go/internal/container/client.go
- Line 14: warning: exported var MessagingClientName should have comment or be unexported (golint)
- Line 16: warning: exported function MessagingClientFrom should have comment or be unexported (golint)
-
-
device-sdk-go/internal/autoevent/executor.go
- Line 27: warning: exported type Executor should have comment or be unexported (golint)
-
-
device-sdk-go/internal/provision/profiles.go
- Line 33: warning: exported function LoadProfiles should have comment or be unexported (golint)
-
-
device-sdk-go/internal/controller/http/correlation/handler.go
- Line 15: warning: exported function IdFromContext should have comment or be unexported (golint)
-
-
device-sdk-go/internal/cache/profiles.go
- Line 21: warning: exported type ProfileCache should have comment or be unexported (golint)
- Line 214: warning: exported function Profiles should have comment or be unexported (golint)
-
-
device-sdk-go/internal/clients/clients.go
- Line 13: warning: exported type EdgeXClients should have comment or be unexported (golint)
-
-
device-sdk-go/version.go
- Line 9: warning: comment on exported var Version should be of the form "Version ..." (golint)
-
-
device-sdk-go/internal/autodiscovery/discovery.go
- Line 25: warning: exported function DiscoveryWrapper should have comment or be unexported (golint)
-
-
device-sdk-go/internal/autoevent/manager.go
- Line 31: warning: exported function BootstrapHandler should have comment or be unexported (golint)
-
-
device-sdk-go/internal/cache/devices.go
- Line 21: warning: exported type DeviceCache should have comment or be unexported (golint)
- Line 142: warning: exported function CheckProfileNotUsed should have comment or be unexported (golint)
- Line 152: warning: exported function Devices should have comment or be unexported (golint)
-
-
device-sdk-go/internal/provision/devices.go
- Line 31: warning: exported function LoadDevices should have comment or be unexported (golint)
-
-
device-sdk-go/example/driver/simpledriver.go
- Line 8: warning: package comment should be of the form "Package driver ..." (golint)
- Line 32: warning: exported type SimpleDriver should have comment or be unexported (golint)
-
-
device-sdk-go/internal/transformer/transformresult.go
- Line 31: warning: exported const Overflow should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: exported function TransformReadResult should have comment or be unexported (golint)
-
-
device-sdk-go/internal/controller/http/command.go
- Line 28: warning: exported method RestController.Command should have comment or be unexported (golint)
-
-
device-sdk-go/example/config/configuration.go
- Line 27: warning: comment on exported type ServiceConfig should be of the form "ServiceConfig ..." (with optional leading article) (golint)
-
-
device-sdk-go/internal/transformer/transformparam.go
- Line 19: warning: exported function TransformWriteParameter should have comment or be unexported (golint)
-
-
device-sdk-go/pkg/service/service.go
- Line 9: warning: package comment should be of the form "Package service ..." (golint)
- Line 60: warning: exported type DeviceService should have comment or be unexported (golint)
- Line 82: warning: exported method DeviceService.Initialize should have comment or be unexported (golint)
- Line 112: warning: exported method DeviceService.UpdateFromContainer should have comment or be unexported (golint)
- Line 141: warning: exported method DeviceService.DeviceDiscovery should have comment or be unexported (golint)
-
-
device-sdk-go/internal/common/utils.go
- Line 27: warning: exported function UpdateLastConnected should have comment or be unexported (golint)
- Line 41: warning: exported function UpdateOperatingState should have comment or be unexported (golint)
- Line 54: warning: exported function SendEvent should have comment or be unexported (golint)
-
-
device-sdk-go/internal/messaging/messaging.go
- Line 35: warning: exported function BootstrapHandler should have comment or be unexported (golint)
-
-
device-sdk-go/internal/controller/http/discovery.go
- Line 20: warning: exported method RestController.Discovery should have comment or be unexported (golint)
-
-
device-sdk-go/internal/controller/http/restrouter.go
- Line 29: warning: exported type RestController should have comment or be unexported (golint)
- Line 36: warning: exported function NewRestController should have comment or be unexported (golint)
- Line 46: warning: exported method RestController.InitRestRoutes should have comment or be unexported (golint)
- Line 79: warning: exported method RestController.AddRoute should have comment or be unexported (golint)
- Line 90: warning: exported method RestController.Router should have comment or be unexported (golint)
-
-
device-sdk-go/internal/telemetry/linux_cpu.go
- Line 25: warning: exported function PollCpu should have comment or be unexported (golint)
- Line 34: warning: exported function AvgCpuUsage should have comment or be unexported (golint)
-
-
device-sdk-go/internal/telemetry/telemetry.go
- Line 26: warning: comment on exported type SystemUsage should be of the form "SystemUsage ..." (with optional leading article) (golint)
- Line 43: warning: exported type CpuUsage should have comment or be unexported (golint)
- Line 53: warning: exported function NewSystemUsage should have comment or be unexported (golint)
- Line 76: warning: context.Context should be the first parameter of a function (golint)
- Line 76: warning: exported function StartCpuUsageAverage should have comment or be unexported (golint)
-
-
device-sdk-go/pkg/models/protocoldriver.go
- Line 8: warning: package comment should be of the form "Package models ..." (golint)
-
-
device-sdk-go/internal/application/command.go
- Line 33: warning: exported type CommandProcessor should have comment or be unexported (golint)
- Line 42: warning: exported function NewCommandProcessor should have comment or be unexported (golint)
- Line 56: warning: exported function CommandHandler should have comment or be unexported (golint)
- Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 108: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 114: warning: exported method CommandProcessor.ReadDeviceResource should have comment or be unexported (golint)
- Line 161: warning: exported method CommandProcessor.ReadDeviceCommand should have comment or be unexported (golint)
- Line 221: warning: exported method CommandProcessor.WriteDeviceResource should have comment or be unexported (golint)
- Line 285: warning: exported method CommandProcessor.WriteDeviceCommand should have comment or be unexported (golint)
-
-
device-sdk-go/internal/common/consts.go
- Line 12: warning: exported const EnvInstanceName should have comment (or a comment on this block) or be unexported (golint)
-
-
device-sdk-go/internal/autodiscovery/autodiscovery.go
- Line 22: warning: exported function BootstrapHandler should have comment or be unexported (golint)
-
-
device-sdk-go/internal/cache/provisionwatcher.go
- Line 20: warning: exported type ProvisionWatcherCache should have comment or be unexported (golint)
- Line 138: warning: exported function ProvisionWatchers should have comment or be unexported (golint)
-
-
device-sdk-go/internal/controller/http/correlation/middleware.go
- Line 20: warning: exported function ManageHeader should have comment or be unexported (golint)
- Line 32: warning: exported function LoggingMiddleware should have comment or be unexported (golint)
- Line 48: warning: exported function RequestLimitMiddleware should have comment or be unexported (golint)
-
-
device-sdk-go/internal/transformer/transform.go
- Line 29: warning: exported function CommandValuesToEventDTO should have comment or be unexported (golint)
- Line 132: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
device-sdk-go/pkg/service/init.go
- Line 34: warning: exported method Bootstrap.BootstrapHandler should have comment or be unexported (golint)
-
-
device-sdk-go/pkg/service/main.go
- Line 32: warning: context.Context should be the first parameter of a function (golint)
- Line 32: warning: exported function Main should have comment or be unexported (golint)
-
-
device-sdk-go/internal/clients/init.go
- Line 29: warning: exported function BootstrapHandler should have comment or be unexported (golint)
-
-
device-sdk-go/internal/controller/http/callback.go
- Line 22: warning: exported method RestController.DeleteDevice should have comment or be unexported (golint)
- Line 35: warning: exported method RestController.AddDevice should have comment or be unexported (golint)
- Line 56: warning: exported method RestController.UpdateDevice should have comment or be unexported (golint)
- Line 77: warning: exported method RestController.UpdateProfile should have comment or be unexported (golint)
- Line 99: warning: exported method RestController.DeleteProvisionWatcher should have comment or be unexported (golint)
- Line 112: warning: exported method RestController.AddProvisionWatcher should have comment or be unexported (golint)
- Line 133: warning: exported method RestController.UpdateProvisionWatcher should have comment or be unexported (golint)
- Line 154: warning: exported method RestController.UpdateDeviceService should have comment or be unexported (golint)
-
-
device-sdk-go/pkg/startup/bootstrap.go
- Line 17: warning: exported function Bootstrap should have comment or be unexported (golint)
-
-
device-sdk-go/pkg/models/commandvalue.go
- Line 19: warning: comment on exported const MaxBinaryBytes should be of the form "MaxBinaryBytes ..." (golint)
-
-
device-sdk-go/internal/application/callback.go
- Line 25: warning: exported function UpdateProfile should have comment or be unexported (golint)
- Line 42: warning: exported function AddDevice should have comment or be unexported (golint)
- Line 72: warning: exported function UpdateDevice should have comment or be unexported (golint)
- Line 84: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 121: warning: exported function DeleteDevice should have comment or be unexported (golint)
- Line 165: warning: exported function AddProvisionWatcher should have comment or be unexported (golint)
- Line 178: warning: exported function UpdateProvisionWatcher should have comment or be unexported (golint)
- Line 189: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 210: warning: exported function DeleteProvisionWatcher should have comment or be unexported (golint)
- Line 221: warning: exported function UpdateDeviceService should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell98%
Misspell Finds commonly misspelled English words
-
-
device-sdk-go/pkg/models/commandvalue.go
- Line 81: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 96: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 111: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 126: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 141: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 156: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 171: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 186: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 201: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 216: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 231: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 246: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 261: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 276: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 291: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 306: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 321: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 336: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 351: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 366: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 381: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 396: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 411: warning: "transfrom" is a misspelling of "transform" (misspell)
- Line 426: warning: "transfrom" is a misspelling of "transform" (misspell)