gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• internal/pkg/telemetry/windows_cpu.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/security/pipedhexreader/pipedhexreader_linux_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/security/fileprovider/tokenconfig_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/security/secretstore/tokenprovider_linux_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/pkg/db/mongo/client_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/pkg/telemetry/linux_cpu.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/security/secretstore/password_linux_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/pkg/telemetry/unimplemented_cpu.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• internal/pkg/db/redis/client_integration_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint45%

Golint is a linter for Go source code.

• internal/pkg/db/redis/models/db_command.go
  • Line 17: warning: exported type Adder should have comment or be unexported (golint)
  • Line 21: warning: exported type Remover should have comment or be unexported (golint)

• internal/pkg/v2/utils/http.go
  • Line 21: warning: context.Context should be the first parameter of a function (golint)
  • Line 21: warning: exported function WriteHttpHeader should have comment or be unexported (golint)
  • Line 27: warning: exported function ParseGetAllObjectsRequestQueryString should have comment or be unexported (golint)
  • Line 42: warning: comment on exported function ParseQueryStringToInt should be of the form "ParseQueryStringToInt ..." (golint)
  • Line 66: warning: comment on exported function ParseQueryStringToStrings should be of the form "ParseQueryStringToStrings ..." (golint)

• internal/core/metadata/v2/controller/http/device.go
  • Line 31: warning: exported type DeviceController should have comment or be unexported (golint)
  • Line 44: warning: exported method DeviceController.AddDevice should have comment or be unexported (golint)
  • Line 97: warning: exported method DeviceController.DeleteDeviceById should have comment or be unexported (golint)
  • Line 127: warning: exported method DeviceController.DeleteDeviceByName should have comment or be unexported (golint)
  • Line 157: warning: exported method DeviceController.DevicesByServiceName should have comment or be unexported (golint)
  • Line 195: warning: exported method DeviceController.DeviceIdExists should have comment or be unexported (golint)
  • Line 225: warning: exported method DeviceController.DeviceNameExists should have comment or be unexported (golint)
  • Line 255: warning: exported method DeviceController.PatchDevice should have comment or be unexported (golint)
  • Line 303: warning: exported method DeviceController.AllDevices should have comment or be unexported (golint)
  • Line 338: warning: exported method DeviceController.DeviceByName should have comment or be unexported (golint)

• internal/pkg/common/util.go
  • Line 12: warning: exported function MakeTimestamp should have comment or be unexported (golint)

• internal/security/secrets/mocks/custom.go
  • Line 19: warning: exported function CreateValidX509ConfigMock should have comment or be unexported (golint)

• internal/core/command/errors/types.go
  • Line 5: warning: exported type ErrDeviceLocked should have comment or be unexported (golint)
  • Line 13: warning: exported function NewErrDeviceLocked should have comment or be unexported (golint)
  • Line 17: warning: exported type ErrCommandNotAssociatedWithDevice should have comment or be unexported (golint)
  • Line 26: warning: exported function NewErrCommandNotAssociatedWithDevice should have comment or be unexported (golint)

• internal/pkg/correlation/models/event.go
  • Line 23: warning: exported type Event should have comment or be unexported (golint)
  • Line 30: warning: comment on exported method Event.ToContract should be of the form "ToContract ..." (golint)
  • Line 49: warning: exported method Event.MarshalJSON should have comment or be unexported (golint)

• internal/pkg/v2/infrastructure/redis/client.go
  • Line 25: warning: exported type Client should have comment or be unexported (golint)
  • Line 30: warning: exported function NewClient should have comment or be unexported (golint)
  • Line 91: warning: comment on exported method Client.AddDeviceProfile should be of the form "AddDeviceProfile ..." (golint)
  • Line 285: warning: comment on exported method Client.AddDevice should be of the form "AddDevice ..." (golint)
  • Line 297: warning: comment on exported method Client.UpdateEventPushedById should be of the form "UpdateEventPushedById ..." (golint)

• internal/core/metadata/rest_deviceprofile.go
  • Line 560: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/support/scheduler/operators/intervalaction/get.go
  • Line 25: warning: comment on exported type IntervalActionsExecutor should be of the form "IntervalActionsExecutor ..." (with optional leading article) (golint)
  • Line 49: warning: comment on exported function NewAllExecutor should be of the form "NewAllExecutor ..." (golint)

• internal/support/scheduler/operators/interval/delete.go
  • Line 30: warning: exported type ScrubExecutor should have comment or be unexported (golint)
  • Line 153: warning: comment on exported function NewScrubExecutor should be of the form "NewScrubExecutor ..." (golint)

• internal/core/data/config/config.go
  • Line 1: warning: package comment should be of the form "Package config ..." (golint)
  • Line 22: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 33: warning: exported type WritableInfo should have comment or be unexported (golint)

• internal/pkg/db/redis/device_service.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/core/data/interfaces/db.go
  • Line 1: warning: package comment should be of the form "Package interfaces ..." (golint)
  • Line 22: warning: exported type DBClient should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/command.go
  • Line 23: warning: comment on exported type Response should be of the form "Response ..." (with optional leading article) (golint)
  • Line 32: warning: comment on exported type Get should be of the form "Get ..." (with optional leading article) (golint)
  • Line 41: warning: comment on exported type Put should be of the form "Put ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported type CommandProfile should be of the form "CommandProfile ..." (with optional leading article) (golint)
  • Line 60: warning: exported method CommandProfile.ToContract should have comment or be unexported (golint)
  • Line 91: warning: exported method CommandProfile.FromContract should have comment or be unexported (golint)
  • Line 121: warning: exported method Command.TimestampForUpdate should have comment or be unexported (golint)
  • Line 125: warning: exported method Command.TimestampForAdd should have comment or be unexported (golint)
  • Line 130: warning: comment on exported type Command should be of the form "Command ..." (with optional leading article) (golint)
  • Line 144: warning: exported method Command.ToContract should have comment or be unexported (golint)
  • Line 157: warning: exported method Command.FromContract should have comment or be unexported (golint)

• internal/pkg/db/test/db_scheduler.go
  • Line 17: warning: exported function TestSchedulerDB should have comment or be unexported (golint)

• internal/pkg/db/redis/metadata.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)
  • Line 28: warning: comment on exported method Client.GetAllDeviceReports should be of the form "GetAllDeviceReports ..." (golint)
  • Line 49: warning: exported method Client.GetDeviceReportByName should have comment or be unexported (golint)
  • Line 79: warning: exported method Client.GetDeviceReportByDeviceName should have comment or be unexported (golint)
  • Line 83: warning: exported method Client.GetDeviceReportById should have comment or be unexported (golint)
  • Line 92: warning: exported method Client.GetDeviceReportsByScheduleEventName should have comment or be unexported (golint)
  • Line 96: warning: exported method Client.GetDeviceReportsByAction should have comment or be unexported (golint)
  • Line 100: warning: exported method Client.AddDeviceReport should have comment or be unexported (golint)
  • Line 107: warning: exported method Client.UpdateDeviceReport should have comment or be unexported (golint)
  • Line 120: warning: exported method Client.DeleteDeviceReportById should have comment or be unexported (golint)
  • Line 183: warning: comment on exported method Client.AddDevice should be of the form "AddDevice ..." (golint)
  • Line 191: warning: exported method Client.UpdateDevice should have comment or be unexported (golint)
  • Line 204: warning: exported method Client.DeleteDeviceById should have comment or be unexported (golint)
  • Line 211: warning: exported method Client.GetAllDevices should have comment or be unexported (golint)
  • Line 231: warning: exported method Client.GetDevicesByProfileId should have comment or be unexported (golint)
  • Line 235: warning: exported method Client.GetDeviceById should have comment or be unexported (golint)
  • Line 244: warning: exported method Client.GetDeviceByName should have comment or be unexported (golint)
  • Line 253: warning: exported method Client.GetDevicesByServiceId should have comment or be unexported (golint)
  • Line 257: warning: exported method Client.GetDevicesWithLabel should have comment or be unexported (golint)
  • Line 362: warning: comment on exported method Client.GetDeviceProfileById should be of the form "GetDeviceProfileById ..." (golint)
  • Line 372: warning: exported method Client.GetAllDeviceProfiles should have comment or be unexported (golint)
  • Line 392: warning: exported method Client.GetDeviceProfilesByModel should have comment or be unexported (golint)
  • Line 396: warning: exported method Client.GetDeviceProfilesWithLabel should have comment or be unexported (golint)
  • Line 400: warning: exported method Client.GetDeviceProfilesByManufacturerModel should have comment or be unexported (golint)
  • Line 404: warning: exported method Client.GetDeviceProfilesByManufacturer should have comment or be unexported (golint)
  • Line 408: warning: exported method Client.GetDeviceProfileByName should have comment or be unexported (golint)
  • Line 438: warning: exported method Client.AddDeviceProfile should have comment or be unexported (golint)
  • Line 445: warning: exported method Client.UpdateDeviceProfile should have comment or be unexported (golint)
  • Line 458: warning: exported method Client.DeleteDeviceProfileById should have comment or be unexported (golint)
  • Line 529: warning: comment on exported method Client.UpdateAddressable should be of the form "UpdateAddressable ..." (golint)
  • Line 544: warning: exported method Client.AddAddressable should have comment or be unexported (golint)
  • Line 551: warning: exported method Client.GetAddressableById should have comment or be unexported (golint)
  • Line 560: warning: exported method Client.GetAddressableByName should have comment or be unexported (golint)
  • Line 569: warning: exported method Client.GetAddressablesByTopic should have comment or be unexported (golint)
  • Line 573: warning: exported method Client.GetAddressablesByPort should have comment or be unexported (golint)
  • Line 577: warning: exported method Client.GetAddressablesByPublisher should have comment or be unexported (golint)
  • Line 581: warning: exported method Client.GetAddressablesByAddress should have comment or be unexported (golint)
  • Line 585: warning: exported method Client.GetAddressables should have comment or be unexported (golint)
  • Line 605: warning: exported method Client.DeleteAddressableById should have comment or be unexported (golint)
  • Line 702: warning: comment on exported method Client.GetDeviceServiceByName should be of the form "GetDeviceServiceByName ..." (golint)
  • Line 712: warning: exported method Client.GetDeviceServiceById should have comment or be unexported (golint)
  • Line 721: warning: exported method Client.GetAllDeviceServices should have comment or be unexported (golint)
  • Line 741: warning: exported method Client.GetDeviceServicesByAddressableId should have comment or be unexported (golint)
  • Line 760: warning: exported method Client.GetDeviceServicesWithLabel should have comment or be unexported (golint)
  • Line 779: warning: exported method Client.AddDeviceService should have comment or be unexported (golint)
  • Line 786: warning: exported method Client.UpdateDeviceService should have comment or be unexported (golint)
  • Line 802: warning: exported method Client.DeleteDeviceServiceById should have comment or be unexported (golint)
  • Line 898: warning: comment on exported method Client.GetAllProvisionWatchers should be of the form "GetAllProvisionWatchers ..." (golint)
  • Line 919: warning: exported method Client.GetProvisionWatcherByName should have comment or be unexported (golint)
  • Line 928: warning: exported method Client.GetProvisionWatchersByIdentifier should have comment or be unexported (golint)
  • Line 932: warning: exported method Client.GetProvisionWatchersByServiceId should have comment or be unexported (golint)
  • Line 936: warning: exported method Client.GetProvisionWatchersByProfileId should have comment or be unexported (golint)
  • Line 940: warning: exported method Client.GetProvisionWatcherById should have comment or be unexported (golint)
  • Line 969: warning: exported method Client.AddProvisionWatcher should have comment or be unexported (golint)
  • Line 976: warning: exported method Client.UpdateProvisionWatcher should have comment or be unexported (golint)
  • Line 989: warning: exported method Client.DeleteProvisionWatcherById should have comment or be unexported (golint)
  • Line 1104: warning: comment on exported method Client.GetAllCommands should be of the form "GetAllCommands ..." (golint)
  • Line 1125: warning: exported method Client.GetCommandById should have comment or be unexported (golint)
  • Line 1134: warning: exported method Client.GetCommandByNameAndDeviceId should have comment or be unexported (golint)
  • Line 1156: warning: exported method Client.GetCommandsByName should have comment or be unexported (golint)
  • Line 1204: warning: exported method Client.GetCommandsByDeviceId should have comment or be unexported (golint)
  • Line 1243: warning: exported method Client.ScrubMetadata should have comment or be unexported (golint)

• internal/core/data/main.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 45: warning: exported function Main should have comment or be unexported (golint)

• internal/support/scheduler/errors/types.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 21: warning: comment on exported type ErrIntervalNotFound should be of the form "ErrIntervalNotFound ..." (with optional leading article) (golint)
  • Line 30: warning: exported function NewErrIntervalNotFound should have comment or be unexported (golint)
  • Line 34: warning: exported type ErrIntervalNameInUse should have comment or be unexported (golint)
  • Line 42: warning: exported function NewErrIntervalNameInUse should have comment or be unexported (golint)
  • Line 46: warning: exported type ErrIntervalStillUsedByIntervalActions should have comment or be unexported (golint)
  • Line 54: warning: exported function NewErrIntervalStillInUse should have comment or be unexported (golint)
  • Line 58: warning: comment on exported type ErrIntervalActionNotFound should be of the form "ErrIntervalActionNotFound ..." (with optional leading article) (golint)
  • Line 67: warning: exported function NewErrIntervalActionNotFound should have comment or be unexported (golint)
  • Line 71: warning: exported type ErrIntervalActionTargetNameRequired should have comment or be unexported (golint)
  • Line 79: warning: exported function NewErrIntervalActionTargetNameRequired should have comment or be unexported (golint)
  • Line 83: warning: exported type ErrIntervalActionNameInUse should have comment or be unexported (golint)
  • Line 91: warning: exported function NewErrIntervalActionNameInUse should have comment or be unexported (golint)
  • Line 95: warning: exported type ErrInvalidTimeFormat should have comment or be unexported (golint)
  • Line 103: warning: exported function NewErrInvalidTimeFormat should have comment or be unexported (golint)
  • Line 107: warning: exported type ErrInvalidFrequencyFormat should have comment or be unexported (golint)
  • Line 115: warning: exported function NewErrInvalidFrequencyFormat should have comment or be unexported (golint)
  • Line 119: warning: exported type ErrInvalidCronFormat should have comment or be unexported (golint)
  • Line 127: warning: exported function NewErrInvalidCronFormat should have comment or be unexported (golint)
  • Line 131: warning: exported type ErrDbNotFound should have comment or be unexported (golint)
  • Line 138: warning: exported function NewErrDbNotFound should have comment or be unexported (golint)
  • Line 142: warning: exported type ErrLimitExceeded should have comment or be unexported (golint)
  • Line 150: warning: exported function NewErrLimitExceeded should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/get_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• internal/core/data/device.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 105: warning: context.Context should be the first parameter of a function (golint)

• internal/core/metadata/operators/addressable/add.go
  • Line 1: warning: package comment should be of the form "Package addressable ..." (golint)
  • Line 25: warning: exported type AddExecutor should have comment or be unexported (golint)
  • Line 51: warning: comment on exported function NewAddExecutor should be of the form "NewAddExecutor ..." (golint)

• internal/core/metadata/v2/controller/http/deviceservice.go
  • Line 31: warning: exported type DeviceServiceController should have comment or be unexported (golint)
  • Line 44: warning: exported method DeviceServiceController.AddDeviceService should have comment or be unexported (golint)
  • Line 98: warning: exported method DeviceServiceController.DeviceServiceByName should have comment or be unexported (golint)
  • Line 127: warning: exported method DeviceServiceController.PatchDeviceService should have comment or be unexported (golint)
  • Line 175: warning: exported method DeviceServiceController.DeleteDeviceServiceById should have comment or be unexported (golint)
  • Line 205: warning: exported method DeviceServiceController.DeleteDeviceServiceByName should have comment or be unexported (golint)
  • Line 235: warning: exported method DeviceServiceController.AllDeviceServices should have comment or be unexported (golint)

• internal/security/secrets/config/config.go
  • Line 21: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 27: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 31: warning: exported type SecretsSetupInfo should have comment or be unexported (golint)

• internal/core/metadata/v2/io/deviceservice.go
  • Line 22: warning: comment on exported function NewDeviceServiceRequestReader should be of the form "NewDeviceServiceRequestReader ..." (golint)

• internal/core/data/utils.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)

• internal/core/metadata/errors/types.go
  • Line 21: warning: exported type ErrLimitExceeded should have comment or be unexported (golint)
  • Line 29: warning: exported function NewErrLimitExceeded should have comment or be unexported (golint)
  • Line 33: warning: exported type ErrDuplicateName should have comment or be unexported (golint)
  • Line 41: warning: exported function NewErrDuplicateName should have comment or be unexported (golint)
  • Line 45: warning: exported type ErrEmptyAddressableName should have comment or be unexported (golint)
  • Line 52: warning: exported function NewErrEmptyAddressableName should have comment or be unexported (golint)
  • Line 56: warning: exported type ErrAddressableNotFound should have comment or be unexported (golint)
  • Line 70: warning: exported function NewErrAddressableNotFound should have comment or be unexported (golint)
  • Line 74: warning: exported type ErrAddressableInUse should have comment or be unexported (golint)
  • Line 82: warning: exported function NewErrAddressableInUse should have comment or be unexported (golint)
  • Line 86: warning: exported type ErrBadRequest should have comment or be unexported (golint)
  • Line 94: warning: exported function NewErrBadRequest should have comment or be unexported (golint)
  • Line 98: warning: exported type ErrItemNotFound should have comment or be unexported (golint)
  • Line 106: warning: exported function NewErrItemNotFound should have comment or be unexported (golint)
  • Line 110: warning: exported type ErrDeviceProfileNotFound should have comment or be unexported (golint)
  • Line 119: warning: exported function NewErrDeviceProfileNotFound should have comment or be unexported (golint)
  • Line 126: warning: exported type ErrDeviceProfileInvalidState should have comment or be unexported (golint)
  • Line 136: warning: exported function NewErrDeviceProfileInvalidState should have comment or be unexported (golint)
  • Line 144: warning: exported type ErrEmptyDeviceProfileName should have comment or be unexported (golint)
  • Line 151: warning: exported function NewErrEmptyDeviceProfileName should have comment or be unexported (golint)
  • Line 155: warning: exported type ErrEmptyFile should have comment or be unexported (golint)
  • Line 163: warning: exported function NewErrEmptyFile should have comment or be unexported (golint)
  • Line 169: warning: exported type ErrNameCollision should have comment or be unexported (golint)
  • Line 179: warning: exported function NewErrNameCollision should have comment or be unexported (golint)
  • Line 187: warning: exported type ErrDeviceProfileMarshalJson should have comment or be unexported (golint)
  • Line 195: warning: exported function NewErrDeviceProfileMarshalJson should have comment or be unexported (golint)

• internal/core/data/v2/io/event.go
  • Line 22: warning: comment on exported function NewEventRequestReader should be of the form "NewEventRequestReader ..." (golint)

• internal/security/fileprovider/mocks/mock.go
  • Line 26: warning: exported type MockTokenProvider should have comment or be unexported (golint)
  • Line 37: warning: exported method MockTokenProvider.SetConfiguration should have comment or be unexported (golint)

• internal/pkg/errorconcept/device.go
  • Line 24: warning: exported var Device should have comment or be unexported (golint)

• internal/security/secrets/test/test.go
  • Line 18: warning: exported const VaultJSONPkiSetupExists should have comment (or a comment on this block) or be unexported (golint)

• internal/support/logging/logger/mongo/mongo.go
  • Line 26: warning: exported type Logger should have comment or be unexported (golint)
  • Line 57: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 75: warning: exported method Logger.CloseSession should have comment or be unexported (golint)
  • Line 82: warning: exported method Logger.Add should have comment or be unexported (golint)
  • Line 137: warning: exported method Logger.Remove should have comment or be unexported (golint)
  • Line 155: warning: exported method Logger.Find should have comment or be unexported (golint)

• internal/security/proxy/kongParameters.go
  • Line 1: warning: package comment should be of the form "Package proxy ..." (golint)
  • Line 20: warning: exported type KongService should have comment or be unexported (golint)
  • Line 43: warning: exported type KongRoute should have comment or be unexported (golint)
  • Line 48: warning: exported type KongOAuth2Plugin should have comment or be unexported (golint)
  • Line 57: warning: exported type KongConsumerOauth2 should have comment or be unexported (golint)
  • Line 64: warning: exported type KongOuath2TokenRequest should have comment or be unexported (golint)
  • Line 71: warning: exported type KongOauth2Token should have comment or be unexported (golint)
  • Line 77: warning: exported type KongACLPlugin should have comment or be unexported (golint)
  • Line 82: warning: exported type KongBasicAuthPlugin should have comment or be unexported (golint)
  • Line 87: warning: exported type CertInfo should have comment or be unexported (golint)
  • Line 93: warning: exported type JWTCred should have comment or be unexported (golint)
  • Line 101: warning: exported type KongJWTClaims should have comment or be unexported (golint)
  • Line 107: warning: exported type Item should have comment or be unexported (golint)
  • Line 111: warning: exported type DataCollect should have comment or be unexported (golint)

• internal/security/proxy/service.go
  • Line 1: warning: package comment should be of the form "Package proxy ..." (golint)
  • Line 40: warning: exported type CertUploadErrorType should have comment or be unexported (golint)
  • Line 43: warning: exported const CertExisting should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: exported type CertError should have comment or be unexported (golint)
  • Line 59: warning: exported type Service should have comment or be unexported (golint)
  • Line 67: warning: exported function NewService should have comment or be unexported (golint)
  • Line 81: warning: exported method Service.CheckProxyServiceStatus should have comment or be unexported (golint)
  • Line 85: warning: exported method Service.CheckSecretServiceStatus should have comment or be unexported (golint)
  • Line 113: warning: exported method Service.ResetProxy should have comment or be unexported (golint)
  • Line 131: warning: exported method Service.Init should have comment or be unexported (golint)

• internal/pkg/encoding.go
  • Line 1: warning: package comment should be of the form "Package pkg ..." (golint)
  • Line 24: warning: exported function Encode should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/subscription.go
  • Line 25: warning: comment on exported type Subscription should be of the form "Subscription ..." (with optional leading article) (golint)
  • Line 42: warning: exported method Subscription.ToContract should have comment or be unexported (golint)
  • Line 65: warning: exported method Subscription.FromContract should have comment or be unexported (golint)
  • Line 90: warning: exported method Subscription.TimestampForUpdate should have comment or be unexported (golint)
  • Line 94: warning: exported method Subscription.TimestampForAdd should have comment or be unexported (golint)

• internal/core/data/event.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 38: warning: exported const ChecksumAlgoMD5 should have comment (or a comment on this block) or be unexported (golint)
  • Line 50: warning: context.Context should be the first parameter of a function (golint)
  • Line 101: warning: context.Context should be the first parameter of a function (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 154: warning: context.Context should be the first parameter of a function (golint)
  • Line 233: warning: context.Context should be the first parameter of a function (golint)
  • Line 259: warning: context.Context should be the first parameter of a function (golint)
  • Line 280: warning: context.Context should be the first parameter of a function (golint)

• internal/core/data/router_test.go
  • Line 49: warning: error var TestError should have name of the form ErrFoo (golint)

• internal/support/notifications/config/config.go
  • Line 22: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 33: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 38: warning: exported type SmtpInfo should have comment or be unexported (golint)
  • Line 48: warning: comment on exported method SmtpInfo.CheckUsername should be of the form "CheckUsername ..." (golint)

• internal/support/notifications/operators/notification/delete.go
  • Line 90: warning: comment on exported function NewDeleteByAgeExecutor should be of the form "NewDeleteByAgeExecutor ..." (golint)

• internal/core/data/v2/application/device.go
  • Line 19: warning: context.Context should be the first parameter of a function (golint)

• internal/pkg/db/mongo/models/provisionwatcher.go
  • Line 24: warning: comment on exported type ProvisionWatcher should be of the form "ProvisionWatcher ..." (with optional leading article) (golint)
  • Line 42: warning: exported method ProvisionWatcher.ToContract should have comment or be unexported (golint)
  • Line 80: warning: exported method ProvisionWatcher.FromContract should have comment or be unexported (golint)
  • Line 121: warning: exported method ProvisionWatcher.TimestampForUpdate should have comment or be unexported (golint)
  • Line 125: warning: exported method ProvisionWatcher.TimestampForAdd should have comment or be unexported (golint)

• internal/pkg/db/redis/device.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/pkg/db/redis/scheduler.go
  • Line 28: warning: comment on exported method Client.Intervals should be of the form "Intervals ..." (golint)
  • Line 49: warning: comment on exported method Client.IntervalsWithLimit should be of the form "IntervalsWithLimit ..." (golint)
  • Line 72: warning: comment on exported method Client.IntervalByName should be of the form "IntervalByName ..." (golint)
  • Line 81: warning: comment on exported method Client.IntervalById should be of the form "IntervalById ..." (golint)
  • Line 101: warning: comment on exported method Client.AddInterval should be of the form "AddInterval ..." (golint)
  • Line 134: warning: comment on exported method Client.UpdateInterval should be of the form "UpdateInterval ..." (golint)
  • Line 168: warning: comment on exported method Client.DeleteIntervalById should be of the form "DeleteIntervalById ..." (golint)
  • Line 190: warning: comment on exported method Client.ScrubAllIntervals should be of the form "ScrubAllIntervals ..." (golint)
  • Line 207: warning: comment on exported method Client.IntervalActions should be of the form "IntervalActions ..." (golint)
  • Line 228: warning: comment on exported method Client.IntervalActionsWithLimit should be of the form "IntervalActionsWithLimit ..." (golint)
  • Line 251: warning: comment on exported method Client.IntervalActionsByIntervalName should be of the form "IntervalActionsByIntervalName ..." (golint)
  • Line 273: warning: comment on exported method Client.IntervalActionsByTarget should be of the form "IntervalActionsByTarget ..." (golint)
  • Line 295: warning: comment on exported method Client.IntervalActionById should be of the form "IntervalActionById ..." (golint)
  • Line 315: warning: comment on exported method Client.IntervalActionByName should be of the form "IntervalActionByName ..." (golint)
  • Line 324: warning: comment on exported method Client.AddIntervalAction should be of the form "AddIntervalAction ..." (golint)
  • Line 357: warning: comment on exported method Client.UpdateIntervalAction should be of the form "UpdateIntervalAction ..." (golint)
  • Line 391: warning: comment on exported method Client.DeleteIntervalActionById should be of the form "DeleteIntervalActionById ..." (golint)
  • Line 413: warning: comment on exported method Client.ScrubAllIntervalActions should be of the form "ScrubAllIntervalActions ..." (golint)

• internal/system/agent/setconfig/set.go
  • Line 30: warning: comment on exported type SetExecutor should be of the form "SetExecutor ..." (with optional leading article) (golint)

• internal/support/notifications/init.go
  • Line 1: warning: package comment should be of the form "Package notifications ..." (golint)

• internal/support/notifications/rest_subscription.go
  • Line 131: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/pkg/db/mongo/models/interval_action.go
  • Line 9: warning: comment on exported type IntervalAction should be of the form "IntervalAction ..." (with optional leading article) (golint)
  • Line 33: warning: exported method IntervalAction.ToContract should have comment or be unexported (golint)
  • Line 61: warning: exported method IntervalAction.FromContract should have comment or be unexported (golint)
  • Line 88: warning: exported method IntervalAction.TimestampForUpdate should have comment or be unexported (golint)
  • Line 92: warning: exported method IntervalAction.TimestampForAdd should have comment or be unexported (golint)

• internal/pkg/errorconcept/common.go
  • Line 26: warning: exported var Common should have comment or be unexported (golint)
  • Line 30: warning: don't use underscores in Go names; struct field ContractInvalid_StatusBadRequest should be ContractInvalidStatusBadRequest (golint)
  • Line 34: warning: don't use underscores in Go names; struct field InvalidRequest_StatusBadRequest should be InvalidRequestStatusBadRequest (golint)
  • Line 35: warning: don't use underscores in Go names; struct field InvalidRequest_StatusServiceUnavailable should be InvalidRequestStatusServiceUnavailable (golint)
  • Line 39: warning: don't use underscores in Go names; struct field RetrieveError_StatusInternalServer should be RetrieveErrorStatusInternalServer (golint)
  • Line 40: warning: don't use underscores in Go names; struct field RetrieveError_StatusServiceUnavailable should be RetrieveErrorStatusServiceUnavailable (golint)
  • Line 41: warning: don't use underscores in Go names; struct field UpdateError_StatusInternalServer should be UpdateErrorStatusInternalServer (golint)
  • Line 42: warning: don't use underscores in Go names; struct field UpdateError_StatusServiceUnavailable should be UpdateErrorStatusServiceUnavailable (golint)
  • Line 45: warning: don't use underscores in Go names; type contractInvalid_StatusBadRequest should be contractInvalidStatusBadRequest (golint)
  • Line 104: warning: don't use underscores in Go names; type invalidRequest_BadRequest should be invalidRequestBadRequest (golint)
  • Line 118: warning: don't use underscores in Go names; type invalidRequest_StatusServiceUnavailable should be invalidRequestStatusServiceUnavailable (golint)
  • Line 177: warning: don't use underscores in Go names; type retrieveError_StatusInternalServer should be retrieveErrorStatusInternalServer (golint)
  • Line 191: warning: don't use underscores in Go names; type retrieveError_ServiceUnavailable should be retrieveErrorServiceUnavailable (golint)
  • Line 205: warning: don't use underscores in Go names; type updateError_StatusInternalServer should be updateErrorStatusInternalServer (golint)
  • Line 219: warning: don't use underscores in Go names; type updateError_StatusServiceUnavailable should be updateErrorStatusServiceUnavailable (golint)

• internal/security/secrets/command/cache/cache.go
  • Line 34: warning: exported const CommandName should have comment or be unexported (golint)
  • Line 36: warning: exported type Command should have comment or be unexported (golint)
  • Line 42: warning: exported function NewCommand should have comment or be unexported (golint)

• internal/core/metadata/init.go
  • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)

• internal/pkg/db/mongo/models/addressable.go
  • Line 34: warning: comment on exported type Addressable should be of the form "Addressable ..." (with optional leading article) (golint)
  • Line 55: warning: exported method Addressable.ToContract should have comment or be unexported (golint)
  • Line 80: warning: exported method Addressable.FromContract should have comment or be unexported (golint)
  • Line 103: warning: exported method Addressable.TimestampForUpdate should have comment or be unexported (golint)
  • Line 107: warning: exported method Addressable.TimestampForAdd should have comment or be unexported (golint)

• internal/core/metadata/utils.go
  • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)

• internal/core/metadata/operators/device/update.go
  • Line 27: warning: exported type DeviceUpdateExecutor should have comment or be unexported (golint)
  • Line 38: warning: exported function NewUpdateDevice should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/device.go
  • Line 25: warning: comment on exported type Device should be of the form "Device ..." (with optional leading article) (golint)
  • Line 49: warning: exported method Device.ToContract should have comment or be unexported (golint)
  • Line 107: warning: exported method Device.FromContract should have comment or be unexported (golint)
  • Line 157: warning: exported method Device.TimestampForUpdate should have comment or be unexported (golint)
  • Line 161: warning: exported method Device.TimestampForAdd should have comment or be unexported (golint)

• internal/security/secrets/contract/directoryhandler.go
  • Line 17: warning: exported type DirectoryHandler should have comment or be unexported (golint)

• internal/support/scheduler/operators/interval/update.go
  • Line 1: warning: package comment should be of the form "Package interval ..." (golint)
  • Line 24: warning: exported type UpdateExecutor should have comment or be unexported (golint)
  • Line 83: warning: comment on exported function NewUpdateExecutor should be of the form "NewUpdateExecutor ..." (golint)

• internal/core/metadata/operators/device/request.go
  • Line 25: warning: exported type RequestType should have comment or be unexported (golint)
  • Line 28: warning: exported const Mock should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type Requester should have comment or be unexported (golint)
  • Line 46: warning: context.Context should be the first parameter of a function (golint)
  • Line 46: warning: exported function NewRequester should have comment or be unexported (golint)

• internal/support/notifications/interfaces/db.go
  • Line 23: warning: exported type DatabaseType should have comment or be unexported (golint)
  • Line 25: warning: exported const MONGO should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported type DBClient should have comment or be unexported (golint)
  • Line 79: warning: exported type DBConfiguration should have comment or be unexported (golint)
  • Line 92: warning: exported var ErrNotFound should have comment or be unexported (golint)
  • Line 93: warning: exported var ErrUnsupportedDatabase should have comment or be unexported (golint)
  • Line 94: warning: exported var ErrInvalidObjectId should have comment or be unexported (golint)
  • Line 95: warning: exported var ErrNotUnique should have comment or be unexported (golint)
  • Line 96: warning: exported var ErrSlugEmpty should have comment or be unexported (golint)

• internal/system/result.go
  • Line 19: warning: exported const Metrics should have comment or be unexported (golint)

• internal/core/data/operators/value_descriptor/get_test.go
  • Line 17: warning: don't use an underscore in package name (golint)

• internal/pkg/container/errorHandler.go
  • Line 23: warning: comment on exported var ErrorHandlerName should be of the form "ErrorHandlerName ..." (golint)

• internal/core/data/v2/controller/http/event.go
  • Line 27: warning: exported type EventController should have comment or be unexported (golint)
  • Line 40: warning: exported method EventController.AddEvent should have comment or be unexported (golint)
  • Line 97: warning: exported method EventController.EventById should have comment or be unexported (golint)
  • Line 131: warning: exported method EventController.DeleteEventById should have comment or be unexported (golint)
  • Line 162: warning: exported method EventController.EventTotalCount should have comment or be unexported (golint)
  • Line 188: warning: exported method EventController.EventCountByDevice should have comment or be unexported (golint)
  • Line 218: warning: exported method EventController.UpdateEventPushedById should have comment or be unexported (golint)
  • Line 258: warning: exported method EventController.AllEvents should have comment or be unexported (golint)
  • Line 293: warning: exported method EventController.EventsByDeviceName should have comment or be unexported (golint)

• internal/support/scheduler/schedule.go
  • Line 40: warning: exported function StartTicker should have comment or be unexported (golint)
  • Line 48: warning: exported function StopTicker should have comment or be unexported (golint)
  • Line 95: warning: exported type QueueClient should have comment or be unexported (golint)
  • Line 99: warning: comment on exported function NewSchedulerQueueClient should be of the form "NewSchedulerQueueClient ..." (golint)
  • Line 106: warning: exported method QueueClient.Connect should have comment or be unexported (golint)
  • Line 109: warning: exported method QueueClient.QueryIntervalByID should have comment or be unexported (golint)
  • Line 125: warning: exported method QueueClient.QueryIntervalByName should have comment or be unexported (golint)
  • Line 141: warning: exported method QueueClient.AddIntervalToQueue should have comment or be unexported (golint)
  • Line 168: warning: exported method QueueClient.UpdateIntervalInQueue should have comment or be unexported (golint)
  • Line 195: warning: exported method QueueClient.RemoveIntervalInQueue should have comment or be unexported (golint)
  • Line 218: warning: exported method QueueClient.QueryIntervalActionByID should have comment or be unexported (golint)
  • Line 244: warning: exported method QueueClient.QueryIntervalActionByName should have comment or be unexported (golint)
  • Line 282: warning: exported method QueueClient.AddIntervalActionToQueue should have comment or be unexported (golint)
  • Line 324: warning: exported method QueueClient.UpdateIntervalActionQueue should have comment or be unexported (golint)
  • Line 399: warning: exported method QueueClient.RemoveIntervalActionQueue should have comment or be unexported (golint)

• internal/core/metadata/v2/infrastructure/interfaces/db.go
  • Line 13: warning: exported type DBClient should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/deviceprofile.go
  • Line 29: warning: comment on exported type PropertyValue should be of the form "PropertyValue ..." (with optional leading article) (golint)
  • Line 50: warning: comment on exported type Units should be of the form "Units ..." (with optional leading article) (golint)
  • Line 59: warning: comment on exported type ProfileProperty should be of the form "ProfileProperty ..." (with optional leading article) (golint)
  • Line 67: warning: comment on exported type DeviceResource should be of the form "DeviceResource ..." (with optional leading article) (golint)
  • Line 78: warning: comment on exported type ResourceOperation should be of the form "ResourceOperation ..." (with optional leading article) (golint)
  • Line 93: warning: comment on exported type ProfileResource should be of the form "ProfileResource ..." (with optional leading article) (golint)
  • Line 102: warning: comment on exported type DeviceProfile should be of the form "DeviceProfile ..." (with optional leading article) (golint)
  • Line 121: warning: exported method DeviceProfile.ToContract should have comment or be unexported (golint)
  • Line 209: warning: exported method DeviceProfile.FromContract should have comment or be unexported (golint)
  • Line 302: warning: exported method DeviceProfile.TimestampForUpdate should have comment or be unexported (golint)
  • Line 306: warning: exported method DeviceProfile.TimestampForAdd should have comment or be unexported (golint)

• internal/pkg/db/redis/notifications.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)
  • Line 25: warning: comment on exported method Client.AddNotification should be of the form "AddNotification ..." (golint)
  • Line 37: warning: exported method Client.UpdateNotification should have comment or be unexported (golint)
  • Line 49: warning: comment on exported method Client.GetNotifications should be of the form "GetNotifications ..." (golint)
  • Line 67: warning: exported method Client.GetNotificationById should have comment or be unexported (golint)
  • Line 78: warning: exported method Client.GetNotificationBySlug should have comment or be unexported (golint)
  • Line 93: warning: exported method Client.GetNotificationBySender should have comment or be unexported (golint)
  • Line 110: warning: exported method Client.GetNotificationsByLabels should have comment or be unexported (golint)
  • Line 137: warning: exported method Client.GetNotificationsByStartEnd should have comment or be unexported (golint)
  • Line 153: warning: exported method Client.GetNotificationsByStart should have comment or be unexported (golint)
  • Line 169: warning: exported method Client.GetNotificationsByEnd should have comment or be unexported (golint)
  • Line 185: warning: exported method Client.GetNewNotifications should have comment or be unexported (golint)
  • Line 203: warning: exported method Client.GetNewNormalNotifications should have comment or be unexported (golint)
  • Line 221: warning: exported method Client.MarkNotificationProcessed should have comment or be unexported (golint)
  • Line 229: warning: exported method Client.DeleteNotificationById should have comment or be unexported (golint)
  • Line 246: warning: exported method Client.DeleteNotificationBySlug should have comment or be unexported (golint)
  • Line 293: warning: comment on exported method Client.AddSubscription should be of the form "AddSubscription ..." (golint)
  • Line 306: warning: exported method Client.UpdateSubscription should have comment or be unexported (golint)
  • Line 320: warning: exported method Client.GetSubscriptions should have comment or be unexported (golint)
  • Line 337: warning: exported method Client.GetSubscriptionById should have comment or be unexported (golint)
  • Line 349: warning: exported method Client.DeleteSubscriptionById should have comment or be unexported (golint)
  • Line 356: warning: exported method Client.GetSubscriptionBySlug should have comment or be unexported (golint)
  • Line 367: warning: exported method Client.GetSubscriptionByReceiver should have comment or be unexported (golint)
  • Line 384: warning: exported method Client.GetSubscriptionByCategories should have comment or be unexported (golint)
  • Line 406: warning: exported method Client.GetSubscriptionByLabels should have comment or be unexported (golint)
  • Line 428: warning: exported method Client.GetSubscriptionByCategoriesLabels should have comment or be unexported (golint)
  • Line 453: warning: exported method Client.DeleteSubscriptionBySlug should have comment or be unexported (golint)
  • Line 466: warning: comment on exported method Client.AddTransmission should be of the form "AddTransmission ..." (golint)
  • Line 479: warning: exported method Client.UpdateTransmission should have comment or be unexported (golint)
  • Line 492: warning: exported method Client.GetTransmissionsByNotificationSlug should have comment or be unexported (golint)
  • Line 499: warning: exported method Client.GetTransmissionsByNotificationSlugAndStartEnd should have comment or be unexported (golint)
  • Line 506: warning: exported method Client.GetTransmissionsByStartEnd should have comment or be unexported (golint)
  • Line 523: warning: exported method Client.GetTransmissionsByStart should have comment or be unexported (golint)
  • Line 540: warning: exported method Client.GetTransmissionById should have comment or be unexported (golint)
  • Line 551: warning: exported method Client.GetTransmissionsByEnd should have comment or be unexported (golint)
  • Line 568: warning: exported method Client.GetTransmissionsByStatus should have comment or be unexported (golint)
  • Line 633: warning: comment on exported method Client.CleanupOld should be of the form "CleanupOld ..." (golint)

• internal/security/secretstore/certs.go
  • Line 34: warning: exported type CertCollect should have comment or be unexported (golint)
  • Line 38: warning: exported type CertPair should have comment or be unexported (golint)
  • Line 43: warning: exported type Certs should have comment or be unexported (golint)
  • Line 53: warning: exported function NewCerts should have comment or be unexported (golint)
  • Line 130: warning: exported method Certs.AlreadyinStore should have comment or be unexported (golint)
  • Line 152: warning: exported method Certs.ReadFrom should have comment or be unexported (golint)
  • Line 173: warning: exported method Certs.UploadToStore should have comment or be unexported (golint)

• internal/security/secretstore/constants.go
  • Line 21: warning: exported const VaultToken should have comment (or a comment on this block) or be unexported (golint)
  • Line 24: warning: comment on exported const TokenCreatorPolicy should be of the form "TokenCreatorPolicy ..." (golint)

• internal/pkg/correlation/middleware.go
  • Line 14: warning: exported var LoggingClient should have comment or be unexported (golint)
  • Line 16: warning: exported function ManageHeader should have comment or be unexported (golint)
  • Line 28: warning: exported function OnResponseComplete should have comment or be unexported (golint)
  • Line 39: warning: exported function OnRequestBegin should have comment or be unexported (golint)

• internal/pkg/db/redis/scripts.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/support/notifications/enums/database.go
  • Line 1: warning: package comment should be of the form "Package enums ..." (golint)
  • Line 21: warning: exported type DATABASE should have comment or be unexported (golint)
  • Line 24: warning: exported const INVALID should have comment (or a comment on this block) or be unexported (golint)

• internal/security/secretstore/init.go
  • Line 46: warning: exported type Bootstrap should have comment or be unexported (golint)
  • Line 51: warning: exported function NewBootstrap should have comment or be unexported (golint)

• internal/security/secretstore/password.go
  • Line 60: warning: exported type CredCollect should have comment or be unexported (golint)
  • Line 64: warning: exported type UserPasswordPair should have comment or be unexported (golint)
  • Line 69: warning: exported type Cred should have comment or be unexported (golint)
  • Line 77: warning: exported function NewCred should have comment or be unexported (golint)
  • Line 93: warning: exported method Cred.AlreadyInStore should have comment or be unexported (golint)
  • Line 181: warning: exported method Cred.UploadToStore should have comment or be unexported (golint)

• internal/pkg/db/interfaces/db.go
  • Line 23: warning: exported type DBClient should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/db.go
  • Line 15: warning: don't use an underscore in package name (golint)

• internal/pkg/errorconcept/device_report.go
  • Line 23: warning: exported var DeviceReport should have comment or be unexported (golint)

• internal/support/notifications/errors/types.go
  • Line 22: warning: exported type ErrNotificationNotFound should have comment or be unexported (golint)
  • Line 30: warning: exported function NewErrNotificationNotFound should have comment or be unexported (golint)
  • Line 34: warning: exported type ErrSubscriptionNotFound should have comment or be unexported (golint)
  • Line 42: warning: exported function NewErrSubscriptionNotFound should have comment or be unexported (golint)
  • Line 46: warning: exported type ErrInvalidEmailAddresses should have comment or be unexported (golint)
  • Line 56: warning: exported function NewErrInvalidEmailAddresses should have comment or be unexported (golint)

• internal/core/data/errors/types.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 23: warning: exported type ErrCBORNotSupported should have comment or be unexported (golint)
  • Line 30: warning: exported type ErrEventNotFound should have comment or be unexported (golint)
  • Line 38: warning: exported function NewErrEventNotFound should have comment or be unexported (golint)
  • Line 42: warning: exported type ErrValueDescriptorInvalid should have comment or be unexported (golint)
  • Line 51: warning: exported function NewErrValueDescriptorInvalid should have comment or be unexported (golint)
  • Line 55: warning: exported type ErrValueDescriptorNotFound should have comment or be unexported (golint)
  • Line 63: warning: exported function NewErrValueDescriptorNotFound should have comment or be unexported (golint)
  • Line 67: warning: exported type ErrUnsupportedDatabase should have comment or be unexported (golint)
  • Line 75: warning: exported function NewErrUnsupportedDatabase should have comment or be unexported (golint)
  • Line 79: warning: exported type ErrUnsupportedPublisher should have comment or be unexported (golint)
  • Line 87: warning: exported function NewErrUnsupportedPublisher should have comment or be unexported (golint)
  • Line 91: warning: exported type ErrValueDescriptorInUse should have comment or be unexported (golint)
  • Line 99: warning: exported function NewErrValueDescriptorInUse should have comment or be unexported (golint)
  • Line 103: warning: exported type ErrValueDescriptorsInUse should have comment or be unexported (golint)
  • Line 111: warning: exported function NewErrValueDescriptorsInUse should have comment or be unexported (golint)
  • Line 115: warning: exported type ErrDuplicateValueDescriptorName should have comment or be unexported (golint)
  • Line 123: warning: exported function NewErrDuplicateValueDescriptorName should have comment or be unexported (golint)
  • Line 127: warning: exported type ErrLimitExceeded should have comment or be unexported (golint)
  • Line 135: warning: exported function NewErrLimitExceeded should have comment or be unexported (golint)
  • Line 139: warning: exported type ErrJsonDecoding should have comment or be unexported (golint)
  • Line 147: warning: exported function NewErrJsonDecoding should have comment or be unexported (golint)
  • Line 151: warning: exported type ErrDbNotFound should have comment or be unexported (golint)
  • Line 158: warning: exported function NewErrDbNotFound should have comment or be unexported (golint)
  • Line 162: warning: exported type ErrInvalidId should have comment or be unexported (golint)
  • Line 170: warning: exported function NewErrInvalidId should have comment or be unexported (golint)

• internal/core/data/v2/mocks/device.go
  • Line 91: warning: exported function MetadataDeviceClientFrom should have comment or be unexported (golint)

• internal/pkg/version.go
  • Line 1: warning: package comment should be of the form "Package pkg ..." (golint)
  • Line 23: warning: comment on exported function VersionHandler should be of the form "VersionHandler ..." (golint)

• internal/pkg/db/mongo/models/reading.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 28: warning: comment on exported type Reading should be of the form "Reading ..." (with optional leading article) (golint)
  • Line 46: warning: exported method Reading.ToContract should have comment or be unexported (golint)
  • Line 68: warning: exported method Reading.FromContract should have comment or be unexported (golint)
  • Line 89: warning: exported method Reading.TimestampForUpdate should have comment or be unexported (golint)
  • Line 93: warning: exported method Reading.TimestampForAdd should have comment or be unexported (golint)

• internal/pkg/db/redis/queries.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/support/logging/filter/criteria.go
  • Line 15: warning: exported type Criteria should have comment or be unexported (golint)
  • Line 36: warning: exported method Criteria.Match should have comment or be unexported (golint)

• internal/system/agent/executor/const.go
  • Line 18: warning: exported const MetricsMechanism should have comment (or a comment on this block) or be unexported (golint)

• internal/support/logging/init.go
  • Line 32: warning: exported const PersistenceDB should have comment (or a comment on this block) or be unexported (golint)
  • Line 40: warning: exported type ServiceInit should have comment or be unexported (golint)
  • Line 46: warning: exported function NewServiceInit should have comment or be unexported (golint)
  • Line 68: warning: exported method ServiceInit.BootstrapHandler should have comment or be unexported (golint)

• internal/pkg/db/mongo/metadata.go
  • Line 32: warning: exported method MongoClient.GetAllDeviceReports should have comment or be unexported (golint)
  • Line 36: warning: exported method MongoClient.GetDeviceReportByName should have comment or be unexported (golint)
  • Line 40: warning: exported method MongoClient.GetDeviceReportByDeviceName should have comment or be unexported (golint)
  • Line 44: warning: exported method MongoClient.GetDeviceReportById should have comment or be unexported (golint)
  • Line 52: warning: exported method MongoClient.GetDeviceReportsByAction should have comment or be unexported (golint)
  • Line 85: warning: exported method MongoClient.AddDeviceReport should have comment or be unexported (golint)
  • Line 112: warning: exported method MongoClient.UpdateDeviceReport should have comment or be unexported (golint)
  • Line 133: warning: exported method MongoClient.DeleteDeviceReportById should have comment or be unexported (golint)
  • Line 137: warning: comment on exported method MongoClient.AddDevice should be of the form "AddDevice ..." (golint)
  • Line 169: warning: exported method MongoClient.UpdateDevice should have comment or be unexported (golint)
  • Line 190: warning: exported method MongoClient.DeleteDeviceById should have comment or be unexported (golint)
  • Line 198: warning: exported method MongoClient.GetAllDevices should have comment or be unexported (golint)
  • Line 202: warning: exported method MongoClient.GetDevicesByProfileId should have comment or be unexported (golint)
  • Line 210: warning: exported method MongoClient.GetDeviceById should have comment or be unexported (golint)
  • Line 218: warning: exported method MongoClient.GetDeviceByName should have comment or be unexported (golint)
  • Line 222: warning: exported method MongoClient.GetDevicesByServiceId should have comment or be unexported (golint)
  • Line 230: warning: exported method MongoClient.GetDevicesWithLabel should have comment or be unexported (golint)
  • Line 269: warning: exported method MongoClient.DBRefToDeviceProfile should have comment or be unexported (golint)
  • Line 279: warning: exported method MongoClient.DeviceProfileToDBRef should have comment or be unexported (golint)
  • Line 294: warning: exported method MongoClient.GetDeviceProfileById should have comment or be unexported (golint)
  • Line 310: warning: exported method MongoClient.GetAllDeviceProfiles should have comment or be unexported (golint)
  • Line 314: warning: exported method MongoClient.GetDeviceProfilesByModel should have comment or be unexported (golint)
  • Line 318: warning: exported method MongoClient.GetDeviceProfilesWithLabel should have comment or be unexported (golint)
  • Line 322: warning: exported method MongoClient.GetDeviceProfilesByManufacturerModel should have comment or be unexported (golint)
  • Line 326: warning: exported method MongoClient.GetDeviceProfilesByManufacturer should have comment or be unexported (golint)
  • Line 330: warning: exported method MongoClient.GetDeviceProfileByName should have comment or be unexported (golint)
  • Line 372: warning: exported method MongoClient.AddDeviceProfile should have comment or be unexported (golint)
  • Line 402: warning: exported method MongoClient.UpdateDeviceProfile should have comment or be unexported (golint)
  • Line 423: warning: exported method MongoClient.DeleteDeviceProfileById should have comment or be unexported (golint)
  • Line 429: warning: exported method MongoClient.DBRefToAddressable should have comment or be unexported (golint)
  • Line 439: warning: exported method MongoClient.AddressableToDBRef should have comment or be unexported (golint)
  • Line 455: warning: exported method MongoClient.UpdateAddressable should have comment or be unexported (golint)
  • Line 476: warning: exported method MongoClient.GetAddressables should have comment or be unexported (golint)
  • Line 492: warning: exported method MongoClient.GetAddressableById should have comment or be unexported (golint)
  • Line 508: warning: exported method MongoClient.AddAddressable should have comment or be unexported (golint)
  • Line 537: warning: exported method MongoClient.GetAddressableByName should have comment or be unexported (golint)
  • Line 553: warning: exported method MongoClient.GetAddressablesByTopic should have comment or be unexported (golint)
  • Line 557: warning: exported method MongoClient.GetAddressablesByPort should have comment or be unexported (golint)
  • Line 561: warning: exported method MongoClient.GetAddressablesByPublisher should have comment or be unexported (golint)
  • Line 565: warning: exported method MongoClient.GetAddressablesByAddress should have comment or be unexported (golint)
  • Line 581: warning: exported method MongoClient.DeleteAddressableById should have comment or be unexported (golint)
  • Line 598: warning: exported method MongoClient.DBRefToDeviceService should have comment or be unexported (golint)
  • Line 608: warning: exported method MongoClient.DeviceServiceToDBRef should have comment or be unexported (golint)
  • Line 623: warning: exported method MongoClient.GetDeviceServiceByName should have comment or be unexported (golint)
  • Line 631: warning: exported method MongoClient.GetDeviceServiceById should have comment or be unexported (golint)
  • Line 647: warning: exported method MongoClient.GetAllDeviceServices should have comment or be unexported (golint)
  • Line 651: warning: exported method MongoClient.GetDeviceServicesByAddressableId should have comment or be unexported (golint)
  • Line 659: warning: exported method MongoClient.GetDeviceServicesWithLabel should have comment or be unexported (golint)
  • Line 712: warning: exported method MongoClient.AddDeviceService should have comment or be unexported (golint)
  • Line 730: warning: exported method MongoClient.UpdateDeviceService should have comment or be unexported (golint)
  • Line 751: warning: exported method MongoClient.DeleteDeviceServiceById should have comment or be unexported (golint)
  • Line 774: warning: comment on exported method MongoClient.GetAllProvisionWatchers should be of the form "GetAllProvisionWatchers ..." (golint)
  • Line 779: warning: exported method MongoClient.GetProvisionWatcherByName should have comment or be unexported (golint)
  • Line 783: warning: exported method MongoClient.GetProvisionWatchersByIdentifier should have comment or be unexported (golint)
  • Line 787: warning: exported method MongoClient.GetProvisionWatchersByServiceId should have comment or be unexported (golint)
  • Line 795: warning: exported method MongoClient.GetProvisionWatchersByProfileId should have comment or be unexported (golint)
  • Line 803: warning: exported method MongoClient.GetProvisionWatcherById should have comment or be unexported (golint)
  • Line 817: warning: exported method MongoClient.GetProvisionWatcher should have comment or be unexported (golint)
  • Line 866: warning: exported method MongoClient.AddProvisionWatcher should have comment or be unexported (golint)
  • Line 923: warning: exported method MongoClient.UpdateProvisionWatcher should have comment or be unexported (golint)
  • Line 962: warning: exported method MongoClient.DeleteProvisionWatcherById should have comment or be unexported (golint)
  • Line 968: warning: exported method MongoClient.GetAllCommands should have comment or be unexported (golint)
  • Line 972: warning: exported method MongoClient.GetCommandById should have comment or be unexported (golint)
  • Line 980: warning: exported method MongoClient.GetCommandsByName should have comment or be unexported (golint)
  • Line 984: warning: exported method MongoClient.GetCommandsByDeviceId should have comment or be unexported (golint)
  • Line 991: warning: exported method MongoClient.GetCommandByNameAndDeviceId should have comment or be unexported (golint)
  • Line 1052: warning: comment on exported method MongoClient.ScrubMetadata should be of the form "ScrubMetadata ..." (golint)

• internal/security/proxy/consumer.go
  • Line 1: warning: package comment should be of the form "Package proxy ..." (golint)
  • Line 36: warning: exported type Consumer should have comment or be unexported (golint)
  • Line 43: warning: exported function NewConsumer should have comment or be unexported (golint)
  • Line 57: warning: exported method Consumer.Delete should have comment or be unexported (golint)
  • Line 62: warning: exported method Consumer.Create should have comment or be unexported (golint)
  • Line 90: warning: exported method Consumer.AssociateWithGroup should have comment or be unexported (golint)
  • Line 127: warning: exported method Consumer.CreateToken should have comment or be unexported (golint)

• internal/core/metadata/operators/command/get.go
  • Line 28: warning: comment on exported type DeviceIdExecutor should be of the form "DeviceIdExecutor ..." (with optional leading article) (golint)
  • Line 38: warning: exported function NewDeviceIdExecutor should have comment or be unexported (golint)
  • Line 46: warning: comment on exported type CommandAllExecutor should be of the form "CommandAllExecutor ..." (with optional leading article) (golint)
  • Line 56: warning: exported function NewCommandLoadAll should have comment or be unexported (golint)
  • Line 73: warning: comment on exported type CommandByIdExecutor should be of the form "CommandByIdExecutor ..." (with optional leading article) (golint)
  • Line 83: warning: exported function NewCommandById should have comment or be unexported (golint)
  • Line 95: warning: comment on exported type CommandsByNameExecutor should be of the form "CommandsByNameExecutor ..." (with optional leading article) (golint)
  • Line 105: warning: exported function NewCommandsByName should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/value_descriptor.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 21: warning: comment on exported type ValueDescriptorUpdater should be of the form "ValueDescriptorUpdater ..." (with optional leading article) (golint)

• internal/pkg/correlation/handler.go
  • Line 8: warning: exported function FromContext should have comment or be unexported (golint)

• internal/core/command/put.go
  • Line 30: warning: context.Context should be the first parameter of a function (golint)

• internal/system/agent/direct/const.go
  • Line 18: warning: exported const MetricsMechanism should have comment (or a comment on this block) or be unexported (golint)

• internal/core/data/operators/value_descriptor/get.go
  • Line 17: warning: don't use an underscore in package name (golint)

• internal/core/metadata/operators/device/notify.go
  • Line 34: warning: exported type Notifier should have comment or be unexported (golint)
  • Line 50: warning: context.Context should be the first parameter of a function (golint)
  • Line 50: warning: exported function NewNotifier should have comment or be unexported (golint)

• internal/pkg/v2/infrastructure/redis/device.go
  • Line 22: warning: exported const DeviceCollection should have comment (or a comment on this block) or be unexported (golint)

• internal/pkg/v2/infrastructure/redis/device_service.go
  • Line 20: warning: exported const DeviceServiceCollection should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/interval.go
  • Line 23: warning: comment on exported type Interval should be of the form "Interval ..." (with optional leading article) (golint)
  • Line 40: warning: exported method Interval.ToContract should have comment or be unexported (golint)
  • Line 58: warning: exported method Interval.FromContract should have comment or be unexported (golint)
  • Line 78: warning: exported method Interval.TimestampForUpdate should have comment or be unexported (golint)
  • Line 82: warning: exported method Interval.TimestampForAdd should have comment or be unexported (golint)

• internal/core/command/get.go
  • Line 31: warning: context.Context should be the first parameter of a function (golint)

• internal/pkg/errorconcept/command.go
  • Line 23: warning: exported var Command should have comment or be unexported (golint)

• internal/security/secrets/command/import/import_test.go
  • Line 17: warning: don't use an underscore in package name (golint)

• internal/pkg/db/redis/object.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/core/metadata/operators/device/db.go
  • Line 7: warning: exported type DeviceAdder should have comment or be unexported (golint)
  • Line 13: warning: exported type DeviceServiceLoader should have comment or be unexported (golint)
  • Line 18: warning: exported type DeviceLoader should have comment or be unexported (golint)
  • Line 23: warning: exported type DeviceUpdater should have comment or be unexported (golint)
  • Line 31: warning: exported type DeviceProfileLoader should have comment or be unexported (golint)

• internal/pkg/db/mongo/data.go
  • Line 1: warning: package comment should be of the form "Package mongo ..." (golint)
  • Line 33: warning: comment on exported method MongoClient.Events should be of the form "Events ..." (golint)
  • Line 41: warning: comment on exported method MongoClient.EventsWithLimit should be of the form "EventsWithLimit ..." (golint)
  • Line 48: warning: comment on exported method MongoClient.AddEvent should be of the form "AddEvent ..." (golint)
  • Line 101: warning: comment on exported method MongoClient.UpdateEvent should be of the form "UpdateEvent ..." (golint)
  • Line 116: warning: comment on exported method MongoClient.EventById should be of the form "EventById ..." (golint)
  • Line 148: warning: comment on exported method MongoClient.EventCount should be of the form "EventCount ..." (golint)
  • Line 160: warning: comment on exported method MongoClient.EventCountByDeviceId should be of the form "EventCountByDeviceId ..." (golint)
  • Line 173: warning: comment on exported method MongoClient.DeleteEventById should be of the form "DeleteEventById ..." (golint)
  • Line 198: warning: comment on exported method MongoClient.EventsForDeviceLimit should be of the form "EventsForDeviceLimit ..." (golint)
  • Line 203: warning: comment on exported method MongoClient.EventsForDevice should be of the form "EventsForDevice ..." (golint)
  • Line 208: warning: comment on exported method MongoClient.EventsByCreationTime should be of the form "EventsByCreationTime ..." (golint)
  • Line 218: warning: comment on exported method MongoClient.EventsOlderThanAge should be of the form "EventsOlderThanAge ..." (golint)
  • Line 224: warning: comment on exported method MongoClient.EventsPushed should be of the form "EventsPushed ..." (golint)
  • Line 229: warning: comment on exported method MongoClient.ScrubAllEvents should be of the form "ScrubAllEvents ..." (golint)
  • Line 279: warning: exported method MongoClient.DBRefToReading should have comment or be unexported (golint)
  • Line 286: warning: exported method MongoClient.ReadingToDBRef should have comment or be unexported (golint)
  • Line 305: warning: comment on exported method MongoClient.Readings should be of the form "Readings ..." (golint)
  • Line 319: warning: comment on exported method MongoClient.AddReading should be of the form "AddReading ..." (golint)
  • Line 339: warning: comment on exported method MongoClient.UpdateReading should be of the form "UpdateReading ..." (golint)
  • Line 355: warning: comment on exported method MongoClient.ReadingById should be of the form "ReadingById ..." (golint)
  • Line 380: warning: comment on exported method MongoClient.ReadingCount should be of the form "ReadingCount ..." (golint)
  • Line 392: warning: comment on exported method MongoClient.DeleteReadingById should be of the form "DeleteReadingById ..." (golint)
  • Line 397: warning: exported method MongoClient.DeleteReadingsByDevice should have comment or be unexported (golint)
  • Line 405: warning: comment on exported method MongoClient.ReadingsByDevice should be of the form "ReadingsByDevice ..." (golint)
  • Line 411: warning: comment on exported method MongoClient.ReadingsByValueDescriptor should be of the form "ReadingsByValueDescriptor ..." (golint)
  • Line 417: warning: comment on exported method MongoClient.ReadingsByValueDescriptorNames should be of the form "ReadingsByValueDescriptorNames ..." (golint)
  • Line 422: warning: comment on exported method MongoClient.ReadingsByCreationTime should be of the form "ReadingsByCreationTime ..." (golint)
  • Line 428: warning: comment on exported method MongoClient.ReadingsByDeviceAndValueDescriptor should be of the form "ReadingsByDeviceAndValueDescriptor ..." (golint)
  • Line 478: warning: comment on exported method MongoClient.AddValueDescriptor should be of the form "AddValueDescriptor ..." (golint)
  • Line 511: warning: comment on exported method MongoClient.ValueDescriptors should be of the form "ValueDescriptors ..." (golint)
  • Line 517: warning: comment on exported method MongoClient.UpdateValueDescriptor should be of the form "UpdateValueDescriptor ..." (golint)
  • Line 546: warning: comment on exported method MongoClient.DeleteValueDescriptorById should be of the form "DeleteValueDescriptorById ..." (golint)
  • Line 553: warning: comment on exported method MongoClient.ValueDescriptorByName should be of the form "ValueDescriptorByName ..." (golint)
  • Line 563: warning: comment on exported method MongoClient.ValueDescriptorsByName should be of the form "ValueDescriptorsByName ..." (golint)
  • Line 579: warning: comment on exported method MongoClient.ValueDescriptorById should be of the form "ValueDescriptorById ..." (golint)
  • Line 594: warning: comment on exported method MongoClient.ValueDescriptorsByUomLabel should be of the form "ValueDescriptorsByUomLabel ..." (golint)
  • Line 599: warning: comment on exported method MongoClient.ValueDescriptorsByLabel should be of the form "ValueDescriptorsByLabel ..." (golint)
  • Line 604: warning: comment on exported method MongoClient.ValueDescriptorsByType should be of the form "ValueDescriptorsByType ..." (golint)
  • Line 609: warning: comment on exported method MongoClient.ScrubAllValueDescriptors should be of the form "ScrubAllValueDescriptors ..." (golint)

• internal/pkg/telemetry/linux_cpu.go
  • Line 25: warning: exported function PollCpu should have comment or be unexported (golint)
  • Line 34: warning: exported function AvgCpuUsage should have comment or be unexported (golint)

• internal/support/logging/config/config.go
  • Line 1: warning: package comment should be of the form "Package config ..." (golint)
  • Line 20: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 29: warning: exported type WritableInfo should have comment or be unexported (golint)

• internal/support/scheduler/interval_action.go
  • Line 264: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 296: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/pkg/db/test/db_notifications.go
  • Line 18: warning: exported function TestNotificationsDB should have comment or be unexported (golint)

• internal/core/data/valuedescriptor.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 111: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 130: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 149: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 265: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 349: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/support/scheduler/interfaces/scheduler_queue.go
  • Line 1: warning: package comment should be of the form "Package interfaces ..." (golint)
  • Line 20: warning: exported type SchedulerQueueClient should have comment or be unexported (golint)

• internal/support/scheduler/operators/interval/get.go
  • Line 23: warning: exported type IdExecutor should have comment or be unexported (golint)
  • Line 27: warning: exported type CollectionExecutor should have comment or be unexported (golint)
  • Line 84: warning: exported function NewAllExecutor should have comment or be unexported (golint)
  • Line 91: warning: exported function NewIdExecutor should have comment or be unexported (golint)
  • Line 98: warning: exported function NewNameExecutor should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/update.go
  • Line 1: warning: don't use an underscore in package name (golint)

• internal/core/metadata/operators/device_service/db.go
  • Line 15: warning: don't use an underscore in package name (golint)
  • Line 21: warning: exported type DeviceServiceLoader should have comment or be unexported (golint)
  • Line 31: warning: exported type DeviceServiceUpdater should have comment or be unexported (golint)

• internal/security/fileprovider/init.go
  • Line 37: warning: exported type Bootstrap should have comment or be unexported (golint)
  • Line 41: warning: exported function NewBootstrap should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/add_test.go
  • Line 15: warning: don't use an underscore in package name (golint)

• internal/core/metadata/operators/device/events.go
  • Line 3: warning: exported type DeviceEvent should have comment or be unexported (golint)

• internal/core/metadata/operators/device_service/update.go
  • Line 15: warning: don't use an underscore in package name (golint)

• internal/pkg/errorconcept/value_descriptors.go
  • Line 23: warning: exported var ValueDescriptors should have comment or be unexported (golint)

• internal/security/secrets/command/import/import.go
  • Line 17: warning: don't use an underscore in package name (golint)
  • Line 30: warning: exported const CommandName should have comment or be unexported (golint)
  • Line 32: warning: exported type Command should have comment or be unexported (golint)
  • Line 37: warning: exported function NewCommand should have comment or be unexported (golint)

• internal/security/fileprovider/types.go
  • Line 19: warning: exported type TokenFileProviderInfo should have comment or be unexported (golint)

• internal/support/scheduler/operators/intervalaction/db.go
  • Line 1: warning: package comment should be of the form "Package intervalaction ..." (golint)
  • Line 21: warning: comment on exported type IntervalActionLoader should be of the form "IntervalActionLoader ..." (with optional leading article) (golint)
  • Line 30: warning: comment on exported type IntervalActionWriter should be of the form "IntervalActionWriter ..." (with optional leading article) (golint)
  • Line 36: warning: exported type SchedulerQueueLoader should have comment or be unexported (golint)

• internal/core/metadata/operators/addressable/update.go
  • Line 1: warning: package comment should be of the form "Package addressable ..." (golint)
  • Line 23: warning: exported type UpdateExecutor should have comment or be unexported (golint)
  • Line 98: warning: comment on exported function NewUpdateExecutor should be of the form "NewUpdateExecutor ..." (golint)

• internal/core/metadata/v2/router.go
  • Line 16: warning: exported function LoadRestRoutes should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/delete.go
  • Line 1: warning: don't use an underscore in package name (golint)

• internal/pkg/db/mongo/scheduler.go
  • Line 1: warning: package comment should be of the form "Package mongo ..." (golint)
  • Line 29: warning: exported method MongoClient.Intervals should have comment or be unexported (golint)
  • Line 33: warning: comment on exported method MongoClient.IntervalsWithLimit should be of the form "IntervalsWithLimit ..." (golint)
  • Line 40: warning: comment on exported method MongoClient.IntervalByName should be of the form "IntervalByName ..." (golint)
  • Line 55: warning: comment on exported method MongoClient.IntervalById should be of the form "IntervalById ..." (golint)
  • Line 73: warning: comment on exported method MongoClient.AddInterval should be of the form "AddInterval ..." (golint)
  • Line 101: warning: comment on exported method MongoClient.UpdateInterval should be of the form "UpdateInterval ..." (golint)
  • Line 115: warning: comment on exported method MongoClient.DeleteIntervalById should be of the form "DeleteIntervalById ..." (golint)
  • Line 123: warning: comment on exported method MongoClient.IntervalActions should be of the form "IntervalActions ..." (golint)
  • Line 130: warning: comment on exported method MongoClient.IntervalActionsWithLimit should be of the form "IntervalActionsWithLimit ..." (golint)
  • Line 137: warning: comment on exported method MongoClient.IntervalActionsByIntervalName should be of the form "IntervalActionsByIntervalName ..." (golint)
  • Line 144: warning: comment on exported method MongoClient.IntervalActionsByTarget should be of the form "IntervalActionsByTarget ..." (golint)
  • Line 151: warning: comment on exported method MongoClient.IntervalActionById should be of the form "IntervalActionById ..." (golint)
  • Line 170: warning: comment on exported method MongoClient.IntervalActionByName should be of the form "IntervalActionByName ..." (golint)
  • Line 186: warning: comment on exported method MongoClient.AddIntervalAction should be of the form "AddIntervalAction ..." (golint)
  • Line 213: warning: comment on exported method MongoClient.UpdateIntervalAction should be of the form "UpdateIntervalAction ..." (golint)
  • Line 227: warning: comment on exported method MongoClient.DeleteIntervalActionById should be of the form "DeleteIntervalActionById ..." (golint)
  • Line 319: warning: comment on exported method MongoClient.ScrubAllIntervalActions should be of the form "ScrubAllIntervalActions ..." (golint)
  • Line 338: warning: comment on exported method MongoClient.ScrubAllIntervals should be of the form "ScrubAllIntervals ..." (golint)

• internal/security/redis/main.go
  • Line 36: warning: exported function Main should have comment or be unexported (golint)

• internal/security/secretstoreclient/mocks/mock.go
  • Line 20: warning: should not use dot imports (golint)
  • Line 24: warning: exported type MockSecretStoreClient should have comment or be unexported (golint)
  • Line 28: warning: exported method MockSecretStoreClient.HealthCheck should have comment or be unexported (golint)
  • Line 34: warning: exported method MockSecretStoreClient.Init should have comment or be unexported (golint)
  • Line 40: warning: exported method MockSecretStoreClient.Unseal should have comment or be unexported (golint)
  • Line 46: warning: exported method MockSecretStoreClient.InstallPolicy should have comment or be unexported (golint)
  • Line 52: warning: exported method MockSecretStoreClient.CreateToken should have comment or be unexported (golint)
  • Line 58: warning: exported method MockSecretStoreClient.ListAccessors should have comment or be unexported (golint)
  • Line 64: warning: exported method MockSecretStoreClient.RevokeAccessor should have comment or be unexported (golint)
  • Line 70: warning: exported method MockSecretStoreClient.LookupAccessor should have comment or be unexported (golint)
  • Line 76: warning: exported method MockSecretStoreClient.LookupSelf should have comment or be unexported (golint)
  • Line 82: warning: exported method MockSecretStoreClient.RevokeSelf should have comment or be unexported (golint)
  • Line 88: warning: exported method MockSecretStoreClient.RegenRootToken should have comment or be unexported (golint)
  • Line 94: warning: exported method MockSecretStoreClient.CheckSecretEngineInstalled should have comment or be unexported (golint)
  • Line 100: warning: exported method MockSecretStoreClient.EnableKVSecretEngine should have comment or be unexported (golint)

• internal/support/notifications/operators/subscription/add.go
  • Line 21: warning: exported type AddExecutor should have comment or be unexported (golint)
  • Line 38: warning: exported function NewAddExecutor should have comment or be unexported (golint)

• internal/support/notifications/operators/subscription/get.go
  • Line 23: warning: exported type IdExecutor should have comment or be unexported (golint)
  • Line 27: warning: exported type CollectionExecutor should have comment or be unexported (golint)
  • Line 92: warning: exported function NewAllExecutor should have comment or be unexported (golint)
  • Line 98: warning: exported function NewIdExecutor should have comment or be unexported (golint)
  • Line 105: warning: exported function NewSlugExecutor should have comment or be unexported (golint)
  • Line 112: warning: exported function NewCategoriesExecutor should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/delete_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• internal/core/data/reading.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 84: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 125: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 198: warning: context.Context should be the first parameter of a function (golint)

• internal/security/fileprovider/tokenconfig.go
  • Line 60: warning: exported type TokenConfFile should have comment or be unexported (golint)
  • Line 62: warning: exported type FilePermissions should have comment or be unexported (golint)
  • Line 68: warning: exported type ServiceKey should have comment or be unexported (golint)
  • Line 75: warning: exported function LoadTokenConfig should have comment or be unexported (golint)

• internal/core/data/v2/application/event.go
  • Line 29: warning: comment on exported function AddEvent should be of the form "AddEvent ..." (golint)
  • Line 31: warning: context.Context should be the first parameter of a function (golint)
  • Line 65: warning: context.Context should be the first parameter of a function (golint)
  • Line 96: warning: exported function EventById should have comment or be unexported (golint)
  • Line 116: warning: comment on exported function DeleteEventById should be of the form "DeleteEventById ..." (golint)
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 139: warning: exported function EventTotalCount should have comment or be unexported (golint)
  • Line 150: warning: exported function EventCountByDevice should have comment or be unexported (golint)
  • Line 167: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/pkg/db/redis/models/interval.go
  • Line 23: warning: exported const IntervalKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported type Interval should have comment or be unexported (golint)
  • Line 33: warning: exported function NewInterval should have comment or be unexported (golint)
  • Line 38: warning: exported method Interval.Add should have comment or be unexported (golint)
  • Line 51: warning: exported method Interval.Remove should have comment or be unexported (golint)

• internal/security/redis/config/config.go
  • Line 1: warning: package comment should be of the form "Package config ..." (golint)

• internal/core/metadata/rest_deviceservice_test.go
  • Line 50: warning: error var testError should have name of the form errFoo (golint)

• internal/system/agent/interfaces/config.go
  • Line 23: warning: exported type GetConfig should have comment or be unexported (golint)
  • Line 27: warning: exported type SetConfig should have comment or be unexported (golint)

• internal/system/agent/interfaces/executor.go
  • Line 17: warning: exported type CommandExecutor should have comment or be unexported (golint)

• internal/core/metadata/v2/application/deviceservice.go
  • Line 25: warning: comment on exported function AddDeviceService should be of the form "AddDeviceService ..." (golint)
  • Line 27: warning: context.Context should be the first parameter of a function (golint)
  • Line 47: warning: context.Context should be the first parameter of a function (golint)
  • Line 61: warning: context.Context should be the first parameter of a function (golint)
  • Line 103: warning: context.Context should be the first parameter of a function (golint)
  • Line 120: warning: context.Context should be the first parameter of a function (golint)
  • Line 133: warning: context.Context should be the first parameter of a function (golint)

• internal/core/metadata/operators/device_profile/update_test.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 13: warning: error var TestError should have name of the form ErrFoo (golint)

• internal/security/secrets/contract/command.go
  • Line 18: warning: exported const StatusCodeExitNormal should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported type Command should have comment or be unexported (golint)

• internal/security/secrets/certificates/interface.go
  • Line 25: warning: exported type CertificateType should have comment or be unexported (golint)
  • Line 28: warning: exported const RootCertificate should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type CertificateGenerator should have comment or be unexported (golint)
  • Line 36: warning: exported function NewCertificateGenerator should have comment or be unexported (golint)

• internal/support/logging/main.go
  • Line 36: warning: exported function Main should have comment or be unexported (golint)

• internal/security/proxy/token.go
  • Line 24: warning: exported type UserTokenPair should have comment or be unexported (golint)
  • Line 29: warning: exported method UserTokenPair.Save should have comment or be unexported (golint)

• internal/support/scheduler/main.go
  • Line 43: warning: exported function Main should have comment or be unexported (golint)

• internal/core/command/device.go
  • Line 98: warning: context.Context should be the first parameter of a function (golint)

• internal/security/pipedhexreader/mocks/mock.go
  • Line 13: warning: exported type MockPipedHexReader should have comment or be unexported (golint)
  • Line 17: warning: exported method MockPipedHexReader.ReadHexBytesFromExe should have comment or be unexported (golint)

• internal/pkg/errorconcept/provision_watcher.go
  • Line 24: warning: exported var ProvisionWatcher should have comment or be unexported (golint)
  • Line 28: warning: don't use underscores in Go names; struct field DeleteError_StatusInternalServer should be DeleteErrorStatusInternalServer (golint)
  • Line 29: warning: don't use underscores in Go names; struct field DeviceProfileNotFound_StatusConflict should be DeviceProfileNotFoundStatusConflict (golint)
  • Line 30: warning: don't use underscores in Go names; struct field DeviceProfileNotFound_StatusNotFound should be DeviceProfileNotFoundStatusNotFound (golint)
  • Line 31: warning: don't use underscores in Go names; struct field DeviceServiceNotFound_StatusConflict should be DeviceServiceNotFoundStatusConflict (golint)
  • Line 32: warning: don't use underscores in Go names; struct field DeviceServiceNotFound_StatusNotFound should be DeviceServiceNotFoundStatusNotFound (golint)
  • Line 38: warning: don't use underscores in Go names; struct field RetrieveError_StatusNotFound should be RetrieveErrorStatusNotFound (golint)
  • Line 41: warning: don't use underscores in Go names; type provisionWatcherDeleteError_StatusInternalServer should be provisionWatcherDeleteErrorStatusInternalServer (golint)
  • Line 55: warning: don't use underscores in Go names; type provisionWatcherDeviceProfileNotFound_StatusConflict should be provisionWatcherDeviceProfileNotFoundStatusConflict (golint)
  • Line 69: warning: don't use underscores in Go names; type provisionWatcherDeviceProfileNotFound_StatusNotFound should be provisionWatcherDeviceProfileNotFoundStatusNotFound (golint)
  • Line 83: warning: don't use underscores in Go names; type provisionWatcherDeviceServiceNotFound_StatusConflict should be provisionWatcherDeviceServiceNotFoundStatusConflict (golint)
  • Line 97: warning: don't use underscores in Go names; type provisionWatcherDeviceServiceNotFound_StatusNotFound should be provisionWatcherDeviceServiceNotFoundStatusNotFound (golint)
  • Line 182: warning: don't use underscores in Go names; type provisionWatcherRetrieveError_StatusNotFound should be provisionWatcherRetrieveErrorStatusNotFound (golint)

• internal/pkg/v2/infrastructure/redis/device_profile.go
  • Line 21: warning: exported const DeviceProfileCollection should have comment or be unexported (golint)

• internal/core/metadata/main.go
  • Line 44: warning: exported function Main should have comment or be unexported (golint)

• internal/support/notifications/operators/subscription/update.go
  • Line 21: warning: exported type UpdateExecutor should have comment or be unexported (golint)
  • Line 35: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 45: warning: exported function NewUpdateExecutor should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/channel.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 19: warning: comment on exported type Channel should be of the form "Channel ..." (with optional leading article) (golint)
  • Line 28: warning: exported method Channel.ToContract should have comment or be unexported (golint)
  • Line 35: warning: exported method Channel.FromContract should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/notification.go
  • Line 24: warning: comment on exported type Notification should be of the form "Notification ..." (with optional leading article) (golint)
  • Line 44: warning: exported method Notification.ToContract should have comment or be unexported (golint)
  • Line 67: warning: exported method Notification.FromContract should have comment or be unexported (golint)
  • Line 90: warning: exported method Notification.TimestampForUpdate should have comment or be unexported (golint)
  • Line 94: warning: exported method Notification.TimestampForAdd should have comment or be unexported (golint)

• internal/security/fileprovider/config/config.go
  • Line 25: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 32: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 37: warning: exported type TokenFileProviderInfo should have comment or be unexported (golint)

• internal/pkg/errorconcept/db.go
  • Line 24: warning: exported var Database should have comment or be unexported (golint)

• internal/core/data/domain_events.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 23: warning: comment on exported type DeviceLastReported should be of the form "DeviceLastReported ..." (with optional leading article) (golint)
  • Line 28: warning: comment on exported type DeviceServiceLastReported should be of the form "DeviceServiceLastReported ..." (with optional leading article) (golint)

• internal/security/secretstore/vmkencryption.go
  • Line 56: warning: exported type VMKEncryption should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/deviceservice.go
  • Line 29: warning: comment on exported type DeviceService should be of the form "DeviceService ..." (with optional leading article) (golint)
  • Line 48: warning: exported method DeviceService.ToContract should have comment or be unexported (golint)
  • Line 75: warning: exported method DeviceService.FromContract should have comment or be unexported (golint)
  • Line 113: warning: exported method DeviceService.TimestampForUpdate should have comment or be unexported (golint)
  • Line 113: warning: receiver name s should be consistent with previous receiver name ds for DeviceService (golint)
  • Line 117: warning: exported method DeviceService.TimestampForAdd should have comment or be unexported (golint)
  • Line 117: warning: receiver name s should be consistent with previous receiver name ds for DeviceService (golint)

• internal/pkg/db/test/db_data.go
  • Line 724: warning: exported function TestDataDB should have comment or be unexported (golint)
  • Line 737: warning: exported function BenchmarkDB should have comment or be unexported (golint)

• internal/pkg/db/redis/util.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/support/logging/interfaces/persistence.go
  • Line 23: warning: exported type Persistence should have comment or be unexported (golint)

• internal/core/data/const.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)
  • Line 17: warning: exported const SCRUB should have comment (or a comment on this block) or be unexported (golint)

• internal/security/secrets/seed/seed.go
  • Line 30: warning: exported type RSAKeySize should have comment or be unexported (golint)
  • Line 33: warning: exported const RSA_1024 should have comment (or a comment on this block) or be unexported (golint)
  • Line 48: warning: exported type EllipticCurve should have comment or be unexported (golint)
  • Line 51: warning: exported const EC_224 should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: exported function NewCertificateSeed should have comment or be unexported (golint)

• internal/core/metadata/rest_device.go
  • Line 352: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 567: warning: context.Context should be the first parameter of a function (golint)
  • Line 787: warning: context.Context should be the first parameter of a function (golint)
  • Line 993: warning: context.Context should be the first parameter of a function (golint)
  • Line 1040: warning: context.Context should be the first parameter of a function (golint)
  • Line 1066: warning: context.Context should be the first parameter of a function (golint)

• internal/pkg/errorconcept/default.go
  • Line 21: warning: exported var Default should have comment or be unexported (golint)

• internal/pkg/db/redis/provision_watcher.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/security/secretstore/tokenprovider.go
  • Line 30: warning: exported const OneShotProvider should have comment or be unexported (golint)
  • Line 32: warning: exported type TokenProvider should have comment or be unexported (golint)

• internal/support/scheduler/loader.go
  • Line 25: warning: comment on exported function LoadScheduler should be of the form "LoadScheduler ..." (golint)

• internal/core/metadata/interfaces/db.go
  • Line 1: warning: package comment should be of the form "Package interfaces ..." (golint)
  • Line 20: warning: exported type DBClient should have comment or be unexported (golint)

• internal/core/metadata/operators/addressable/db.go
  • Line 1: warning: package comment should be of the form "Package addressable ..." (golint)

• internal/security/kdf/mocks/mock.go
  • Line 13: warning: exported type MockKeyDeriver should have comment or be unexported (golint)
  • Line 17: warning: exported method MockKeyDeriver.DeriveKey should have comment or be unexported (golint)

• internal/security/proxy/resource.go
  • Line 30: warning: exported type Resource should have comment or be unexported (golint)
  • Line 37: warning: exported function NewResource should have comment or be unexported (golint)
  • Line 51: warning: exported method Resource.Remove should have comment or be unexported (golint)

• internal/core/metadata/operators/device_service/get_test.go
  • Line 15: warning: don't use an underscore in package name (golint)

• internal/pkg/telemetry/telemetry.go
  • Line 28: warning: exported type SystemUsage should have comment or be unexported (golint)
  • Line 42: warning: exported type CpuUsage should have comment or be unexported (golint)
  • Line 51: warning: exported function NewSystemUsage should have comment or be unexported (golint)

• internal/pkg/db/redis/client.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)
  • Line 40: warning: exported type CoreDataClient should have comment or be unexported (golint)
  • Line 45: warning: exported function NewCoreDataClient should have comment or be unexported (golint)
  • Line 62: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)

• internal/support/scheduler/schedulecontext.go
  • Line 17: warning: exported type IntervalContext should have comment or be unexported (golint)
  • Line 29: warning: exported method IntervalContext.Reset should have comment or be unexported (golint)
  • Line 87: warning: exported method IntervalContext.IsComplete should have comment or be unexported (golint)
  • Line 91: warning: exported method IntervalContext.UpdateIterations should have comment or be unexported (golint)
  • Line 97: warning: exported method IntervalContext.UpdateNextTime should have comment or be unexported (golint)
  • Line 103: warning: exported method IntervalContext.GetInfo should have comment or be unexported (golint)

• internal/core/command/const.go
  • Line 18: warning: exported const ID should have comment (or a comment on this block) or be unexported (golint)

• internal/core/command/utils.go
  • Line 18: warning: context.Context should be the first parameter of a function (golint)

• internal/security/redis/handlers.go
  • Line 34: warning: exported type Handler should have comment or be unexported (golint)
  • Line 40: warning: exported function NewHandler should have comment or be unexported (golint)

• internal/security/secrets/helper/helper.go
  • Line 39: warning: exported const EnvXdgRuntimeDir should have comment (or a comment on this block) or be unexported (golint)
  • Line 47: warning: exported function CopyFile should have comment or be unexported (golint)
  • Line 87: warning: exported function CreateDirectoryIfNotExists should have comment or be unexported (golint)
  • Line 94: warning: exported function IsDirEmpty should have comment or be unexported (golint)
  • Line 111: warning: exported function CopyDir should have comment or be unexported (golint)
  • Line 145: warning: exported function Deploy should have comment or be unexported (golint)
  • Line 152: warning: exported function SecureEraseFile should have comment or be unexported (golint)
  • Line 185: warning: exported function CheckIfFileExists should have comment or be unexported (golint)
  • Line 193: warning: exported function CheckDirExistsAndIsWritable should have comment or be unexported (golint)
  • Line 248: warning: exported function GetWorkDir should have comment or be unexported (golint)
  • Line 268: warning: exported function GetCertConfigDir should have comment or be unexported (golint)
  • Line 284: warning: exported function GetCacheDir should have comment or be unexported (golint)
  • Line 302: warning: exported function GetDeployDir should have comment or be unexported (golint)

• internal/security/secretstoreclient/const.go
  • Line 1: warning: package comment should be of the form "Package secretstoreclient ..." (golint)
  • Line 20: warning: exported const VaultToken should have comment (or a comment on this block) or be unexported (golint)

• internal/security/secretstoreclient/vault.go
  • Line 38: warning: exported function NewSecretStoreClient should have comment or be unexported (golint)

• internal/security/proxy/main.go
  • Line 39: warning: exported function Main should have comment or be unexported (golint)

• internal/core/command/interfaces/db.go
  • Line 7: warning: exported type DBClient should have comment or be unexported (golint)

• internal/core/metadata/operators/device/add.go
  • Line 26: warning: exported type DeviceCreator should have comment or be unexported (golint)
  • Line 36: warning: exported function NewAddDevice should have comment or be unexported (golint)

• internal/security/secrets/main.go
  • Line 34: warning: exported function Main should have comment or be unexported (golint)

• internal/pkg/db/redis/data.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)
  • Line 37: warning: exported const DeletedEventsCollection should have comment (or a comment on this block) or be unexported (golint)
  • Line 43: warning: comment on exported method Client.Events should be of the form "Events ..." (golint)
  • Line 66: warning: comment on exported method Client.EventsWithLimit should be of the form "EventsWithLimit ..." (golint)
  • Line 87: warning: comment on exported method Client.AddEvent should be of the form "AddEvent ..." (golint)
  • Line 103: warning: comment on exported method Client.UpdateEvent should be of the form "UpdateEvent ..." (golint)
  • Line 137: warning: comment on exported method Client.EventById should be of the form "EventById ..." (golint)
  • Line 177: warning: comment on exported method Client.EventCount should be of the form "EventCount ..." (golint)
  • Line 190: warning: comment on exported method Client.EventCountByDeviceId should be of the form "EventCountByDeviceId ..." (golint)
  • Line 203: warning: comment on exported method Client.DeleteEventById should be of the form "DeleteEventById ..." (golint)
  • Line 337: warning: comment on exported method Client.EventsForDeviceLimit should be of the form "EventsForDeviceLimit ..." (golint)
  • Line 358: warning: comment on exported method Client.EventsForDevice should be of the form "EventsForDevice ..." (golint)
  • Line 370: warning: comment on exported method Client.EventsByCreationTime should be of the form "EventsByCreationTime ..." (golint)
  • Line 392: warning: comment on exported method Client.ReadingsByDeviceAndValueDescriptor should be of the form "ReadingsByDeviceAndValueDescriptor ..." (golint)
  • Line 428: warning: comment on exported method Client.EventsOlderThanAge should be of the form "EventsOlderThanAge ..." (golint)
  • Line 438: warning: comment on exported method Client.EventsPushed should be of the form "EventsPushed ..." (golint)
  • Line 457: warning: comment on exported method Client.ScrubAllEvents should be of the form "ScrubAllEvents ..." (golint)
  • Line 475: warning: comment on exported method Client.Readings should be of the form "Readings ..." (golint)
  • Line 497: warning: comment on exported method Client.AddReading should be of the form "AddReading ..." (golint)
  • Line 512: warning: comment on exported method Client.UpdateReading should be of the form "UpdateReading ..." (golint)
  • Line 551: warning: comment on exported method Client.ReadingById should be of the form "ReadingById ..." (golint)
  • Line 567: warning: comment on exported method Client.ReadingCount should be of the form "ReadingCount ..." (golint)
  • Line 580: warning: comment on exported method Client.DeleteReadingById should be of the form "DeleteReadingById ..." (golint)
  • Line 702: warning: comment on exported method Client.ReadingsByDevice should be of the form "ReadingsByDevice ..." (golint)
  • Line 727: warning: comment on exported method Client.ReadingsByValueDescriptor should be of the form "ReadingsByValueDescriptor ..." (golint)
  • Line 751: warning: comment on exported method Client.ReadingsByValueDescriptorNames should be of the form "ReadingsByValueDescriptorNames ..." (golint)
  • Line 788: warning: comment on exported method Client.ReadingsByCreationTime should be of the form "ReadingsByCreationTime ..." (golint)
  • Line 813: warning: comment on exported method Client.AddValueDescriptor should be of the form "AddValueDescriptor ..." (golint)
  • Line 831: warning: comment on exported method Client.ValueDescriptors should be of the form "ValueDescriptors ..." (golint)
  • Line 853: warning: comment on exported method Client.UpdateValueDescriptor should be of the form "UpdateValueDescriptor ..." (golint)
  • Line 886: warning: comment on exported method Client.DeleteValueDescriptorById should be of the form "DeleteValueDescriptorById ..." (golint)
  • Line 901: warning: comment on exported method Client.ValueDescriptorByName should be of the form "ValueDescriptorByName ..." (golint)
  • Line 917: warning: comment on exported method Client.ValueDescriptorsByName should be of the form "ValueDescriptorsByName ..." (golint)
  • Line 939: warning: comment on exported method Client.ValueDescriptorById should be of the form "ValueDescriptorById ..." (golint)
  • Line 955: warning: comment on exported method Client.ValueDescriptorsByUomLabel should be of the form "ValueDescriptorsByUomLabel ..." (golint)
  • Line 978: warning: comment on exported method Client.ValueDescriptorsByLabel should be of the form "ValueDescriptorsByLabel ..." (golint)
  • Line 1001: warning: comment on exported method Client.ValueDescriptorsByType should be of the form "ValueDescriptorsByType ..." (golint)
  • Line 1024: warning: comment on exported method Client.ScrubAllValueDescriptors should be of the form "ScrubAllValueDescriptors ..." (golint)

• internal/support/scheduler/interfaces/db.go
  • Line 1: warning: package comment should be of the form "Package interfaces ..." (golint)
  • Line 20: warning: exported type DBClient should have comment or be unexported (golint)

• internal/core/data/operators/value_descriptor/db.go
  • Line 17: warning: don't use an underscore in package name (golint)

• internal/core/metadata/operators/addressable/get.go
  • Line 15: warning: package comment should be of the form "Package addressable ..." (golint)
  • Line 27: warning: exported type AddressableAllExecutor should have comment or be unexported (golint)
  • Line 37: warning: exported function NewAddressableLoadAll should have comment or be unexported (golint)
  • Line 55: warning: exported type IdExecutor should have comment or be unexported (golint)
  • Line 68: warning: exported function NewIdExecutor should have comment or be unexported (golint)
  • Line 75: warning: exported type NameExecutor should have comment or be unexported (golint)
  • Line 88: warning: exported function NewNameExecutor should have comment or be unexported (golint)

• internal/core/metadata/v2/io/deviceprofile.go
  • Line 28: warning: comment on exported function NewDeviceProfileRequestReader should be of the form "NewDeviceProfileRequestReader ..." (golint)

• internal/pkg/v2/infrastructure/redis/reading.go
  • Line 23: warning: exported const ReadingsCollection should have comment (or a comment on this block) or be unexported (golint)

• internal/security/secretstore/config/config.go
  • Line 24: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 31: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 36: warning: exported type Database should have comment or be unexported (golint)

• internal/support/scheduler/utils.go
  • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)

• internal/security/fileprovider/main.go
  • Line 37: warning: exported function Main should have comment or be unexported (golint)

• internal/core/metadata/operators/device_profile/value_descriptor_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• internal/pkg/db/mongo/models/transmission.go
  • Line 24: warning: exported type TransmissionRecord should have comment or be unexported (golint)
  • Line 30: warning: comment on exported type Transmission should be of the form "Transmission ..." (with optional leading article) (golint)
  • Line 47: warning: exported method Transmission.ToContract should have comment or be unexported (golint)
  • Line 74: warning: exported method Transmission.FromContract should have comment or be unexported (golint)
  • Line 103: warning: exported method Transmission.TimestampForUpdate should have comment or be unexported (golint)
  • Line 107: warning: exported method Transmission.TimestampForAdd should have comment or be unexported (golint)

• internal/core/metadata/rest_deviceservice.go
  • Line 389: warning: context.Context should be the first parameter of a function (golint)

• internal/core/metadata/router.go
  • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)

• internal/support/scheduler/operators/interval/add.go
  • Line 1: warning: package comment should be of the form "Package interval ..." (golint)
  • Line 21: warning: exported type AddExecutor should have comment or be unexported (golint)
  • Line 55: warning: comment on exported function NewAddExecutor should be of the form "NewAddExecutor ..." (golint)

• internal/system/agent/main.go
  • Line 40: warning: exported function Main should have comment or be unexported (golint)

• internal/core/metadata/operators/addressable/delete.go
  • Line 24: warning: exported type DeleteExecutor should have comment or be unexported (golint)
  • Line 73: warning: comment on exported function NewDeleteByIdExecutor should be of the form "NewDeleteByIdExecutor ..." (golint)
  • Line 81: warning: comment on exported function NewDeleteByNameExecutor should be of the form "NewDeleteByNameExecutor ..." (golint)

• internal/core/metadata/operators/device_profile/get.go
  • Line 15: warning: don't use an underscore in package name (golint)
  • Line 31: warning: comment on exported type GetProfileExecutor should be of the form "GetProfileExecutor ..." (with optional leading article) (golint)

• internal/core/metadata/operators/device/get.go
  • Line 26: warning: exported type DeviceAllExecutor should have comment or be unexported (golint)
  • Line 36: warning: exported function NewDeviceLoadAll should have comment or be unexported (golint)

• internal/pkg/errorconcept/const.go
  • Line 18: warning: exported const METHOD_NOT_ALLOWED should have comment (or a comment on this block) or be unexported (golint)

• internal/pkg/v2/infrastructure/redis/event.go
  • Line 21: warning: exported const EventsCollection should have comment (or a comment on this block) or be unexported (golint)

• internal/system/agent/setconfig/executor-stub.go
  • Line 32: warning: exported type StubSet should have comment or be unexported (golint)
  • Line 38: warning: exported function NewStubSet should have comment or be unexported (golint)
  • Line 44: warning: comment on exported method StubSet.Do should be of the form "Do ..." (golint)

• internal/core/data/v2/router.go
  • Line 16: warning: exported function LoadRestRoutes should have comment or be unexported (golint)

• internal/pkg/v2/interfaces/db.go
  • Line 8: warning: exported type DBClient should have comment or be unexported (golint)

• internal/pkg/errorconcept/cbor.go
  • Line 23: warning: exported var CBOR should have comment or be unexported (golint)

• internal/pkg/db/redis/event.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/core/metadata/const.go
  • Line 1: warning: package comment should be of the form "Package metadata ..." (golint)
  • Line 17: warning: comment on exported const ID should be of the form "ID ..." (golint)
  • Line 19: warning: exported const NAME should have comment (or a comment on this block) or be unexported (golint)

• internal/core/metadata/v2/application/deviceprofile.go
  • Line 24: warning: comment on exported function AddDeviceProfile should be of the form "AddDeviceProfile ..." (golint)
  • Line 26: warning: context.Context should be the first parameter of a function (golint)
  • Line 45: warning: comment on exported function UpdateDeviceProfile should be of the form "UpdateDeviceProfile ..." (golint)
  • Line 47: warning: context.Context should be the first parameter of a function (golint)
  • Line 65: warning: context.Context should be the first parameter of a function (golint)
  • Line 79: warning: context.Context should be the first parameter of a function (golint)
  • Line 96: warning: context.Context should be the first parameter of a function (golint)

• internal/pkg/db/mongo/client.go
  • Line 40: warning: comment on exported function NewClient should be of the form "NewClient ..." (golint)
  • Line 67: warning: exported method MongoClient.CloseSession should have comment or be unexported (golint)

• internal/support/scheduler/operators/intervalaction/add.go
  • Line 1: warning: package comment should be of the form "Package intervalaction ..." (golint)
  • Line 21: warning: exported type AddExecutor should have comment or be unexported (golint)
  • Line 40: warning: comment on exported function NewAddExecutor should be of the form "NewAddExecutor ..." (golint)

• internal/support/notifications/utils.go
  • Line 31: warning: exported const ExceededMaxResultCount should have comment (or a comment on this block) or be unexported (golint)

• internal/support/scheduler/const.go
  • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
  • Line 18: warning: comment on exported const ID should be of the form "ID ..." (golint)
  • Line 20: warning: exported const NAME should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported const ContentTypeKey should be of the form "ContentTypeKey ..." (golint)

• internal/core/metadata/operators/command/db.go
  • Line 7: warning: exported type CommandLoader should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/devicereport.go
  • Line 23: warning: comment on exported type DeviceReport should be of the form "DeviceReport ..." (with optional leading article) (golint)
  • Line 38: warning: exported method DeviceReport.ToContract should have comment or be unexported (golint)
  • Line 57: warning: exported method DeviceReport.FromContract should have comment or be unexported (golint)
  • Line 74: warning: exported method DeviceReport.TimestampForUpdate should have comment or be unexported (golint)
  • Line 78: warning: exported method DeviceReport.TimestampForAdd should have comment or be unexported (golint)

• internal/core/data/init.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)

• internal/support/logging/logger/file/file.go
  • Line 23: warning: exported type Logger should have comment or be unexported (golint)
  • Line 29: warning: exported function NewLogger should have comment or be unexported (golint)
  • Line 59: warning: exported method Logger.CloseSession should have comment or be unexported (golint)
  • Line 65: warning: exported method Logger.Add should have comment or be unexported (golint)
  • Line 83: warning: exported method Logger.Remove should have comment or be unexported (golint)
  • Line 130: warning: exported method Logger.Find should have comment or be unexported (golint)

• internal/security/secretstoreclient/requestor.go
  • Line 35: warning: exported type HTTPSRequestor should have comment or be unexported (golint)
  • Line 44: warning: exported function NewRequestor should have comment or be unexported (golint)

• internal/security/proxy/requestor.go
  • Line 1: warning: package comment should be of the form "Package proxy ..." (golint)
  • Line 30: warning: exported function NewRequestor should have comment or be unexported (golint)

• internal/security/secretstore/passwordprovider.go
  • Line 20: warning: exported type PasswordProvider should have comment or be unexported (golint)

• internal/pkg/db/redis/models/interval_action.go
  • Line 23: warning: exported const IntervalActionKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: exported type IntervalAction should have comment or be unexported (golint)
  • Line 35: warning: exported function NewIntervalAction should have comment or be unexported (golint)
  • Line 40: warning: exported method IntervalAction.Add should have comment or be unexported (golint)
  • Line 57: warning: exported method IntervalAction.Remove should have comment or be unexported (golint)

• internal/security/proxy/config/config.go
  • Line 26: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 37: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 42: warning: exported type KongUrlInfo should have comment or be unexported (golint)
  • Line 50: warning: exported method KongUrlInfo.GetProxyBaseURL should have comment or be unexported (golint)
  • Line 58: warning: exported method KongUrlInfo.GetSecureURL should have comment or be unexported (golint)
  • Line 66: warning: exported type KongAuthInfo should have comment or be unexported (golint)
  • Line 73: warning: exported type KongAclInfo should have comment or be unexported (golint)
  • Line 78: warning: exported type SecretServiceInfo should have comment or be unexported (golint)
  • Line 88: warning: exported method SecretServiceInfo.GetSecretSvcBaseURL should have comment or be unexported (golint)

• internal/security/secrets/command/generate/generate.go
  • Line 31: warning: exported const CommandName should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported type Command should have comment or be unexported (golint)
  • Line 49: warning: exported function NewCommand should have comment or be unexported (golint)
  • Line 59: warning: exported method Command.Execute should have comment or be unexported (golint)
  • Line 90: warning: exported method Command.GeneratePkis should have comment or be unexported (golint)

• internal/security/proxy/init.go
  • Line 34: warning: exported type Bootstrap should have comment or be unexported (golint)
  • Line 43: warning: exported function NewBootstrap should have comment or be unexported (golint)

• internal/security/secrets/init.go
  • Line 34: warning: exported type Bootstrap should have comment or be unexported (golint)
  • Line 38: warning: exported function NewBootstrap should have comment or be unexported (golint)
  • Line 85: warning: exported method Bootstrap.ExitStatusCode should have comment or be unexported (golint)

• internal/core/data/router.go
  • Line 1: warning: package comment should be of the form "Package data ..." (golint)

• internal/security/secretstoreclient/types.go
  • Line 23: warning: exported type SecretServiceInfo should have comment or be unexported (golint)
  • Line 45: warning: exported method SecretServiceInfo.GetSecretSvcBaseURL should have comment or be unexported (golint)

• internal/core/metadata/v2/application/device.go
  • Line 25: warning: comment on exported function AddDevice should be of the form "AddDevice ..." (golint)
  • Line 27: warning: context.Context should be the first parameter of a function (golint)
  • Line 89: warning: context.Context should be the first parameter of a function (golint)
  • Line 136: warning: context.Context should be the first parameter of a function (golint)

• internal/core/metadata/operators/device_profile/add.go
  • Line 15: warning: don't use an underscore in package name (golint)
  • Line 57: warning: comment on exported function NewAddDeviceProfileExecutor should be of the form "NewAddDeviceProfileExecutor ..." (golint)

• internal/core/command/main.go
  • Line 43: warning: exported function Main should have comment or be unexported (golint)

• internal/core/metadata/v2/io/device.go
  • Line 22: warning: comment on exported function NewDeviceRequestReader should be of the form "NewDeviceRequestReader ..." (golint)

• internal/core/metadata/v2/controller/http/deviceprofile.go
  • Line 27: warning: exported type DeviceProfileController should have comment or be unexported (golint)
  • Line 40: warning: exported method DeviceProfileController.AddDeviceProfile should have comment or be unexported (golint)
  • Line 91: warning: exported method DeviceProfileController.UpdateDeviceProfile should have comment or be unexported (golint)
  • Line 140: warning: exported method DeviceProfileController.AddDeviceProfileByYaml should have comment or be unexported (golint)
  • Line 188: warning: exported method DeviceProfileController.UpdateDeviceProfileByYaml should have comment or be unexported (golint)
  • Line 234: warning: exported method DeviceProfileController.DeviceProfileByName should have comment or be unexported (golint)
  • Line 263: warning: exported method DeviceProfileController.DeleteDeviceProfileById should have comment or be unexported (golint)
  • Line 293: warning: exported method DeviceProfileController.DeleteDeviceProfileByName should have comment or be unexported (golint)
  • Line 323: warning: exported method DeviceProfileController.AllDeviceProfiles should have comment or be unexported (golint)

• internal/pkg/db/mongo/notifications.go
  • Line 26: warning: exported const NOTIFICATION_COLLECTION should have comment (or a comment on this block) or be unexported (golint)
  • Line 36: warning: exported method MongoClient.GetNotifications should have comment or be unexported (golint)
  • Line 40: warning: exported method MongoClient.GetNotificationById should have comment or be unexported (golint)
  • Line 48: warning: exported method MongoClient.GetNotificationBySlug should have comment or be unexported (golint)
  • Line 52: warning: exported method MongoClient.GetNotificationBySender should have comment or be unexported (golint)
  • Line 56: warning: exported method MongoClient.GetNotificationsByLabels should have comment or be unexported (golint)
  • Line 60: warning: exported method MongoClient.GetNotificationsByStartEnd should have comment or be unexported (golint)
  • Line 64: warning: exported method MongoClient.GetNotificationsByStart should have comment or be unexported (golint)
  • Line 68: warning: exported method MongoClient.GetNotificationsByEnd should have comment or be unexported (golint)
  • Line 72: warning: exported method MongoClient.GetNewNotifications should have comment or be unexported (golint)
  • Line 76: warning: exported method MongoClient.GetNewNormalNotifications should have comment or be unexported (golint)
  • Line 80: warning: exported method MongoClient.AddNotification should have comment or be unexported (golint)
  • Line 103: warning: exported method MongoClient.UpdateNotification should have comment or be unexported (golint)
  • Line 107: warning: exported method MongoClient.MarkNotificationProcessed should have comment or be unexported (golint)
  • Line 112: warning: exported method MongoClient.DeleteNotificationById should have comment or be unexported (golint)
  • Line 120: warning: exported method MongoClient.DeleteNotificationBySlug should have comment or be unexported (golint)
  • Line 128: warning: exported method MongoClient.DeleteNotificationsOld should have comment or be unexported (golint)
  • Line 215: warning: exported method MongoClient.GetSubscriptionBySlug should have comment or be unexported (golint)
  • Line 219: warning: exported method MongoClient.GetSubscriptionByCategories should have comment or be unexported (golint)
  • Line 223: warning: exported method MongoClient.GetSubscriptionByLabels should have comment or be unexported (golint)
  • Line 227: warning: exported method MongoClient.GetSubscriptionByCategoriesLabels should have comment or be unexported (golint)
  • Line 231: warning: exported method MongoClient.GetSubscriptionByReceiver should have comment or be unexported (golint)
  • Line 235: warning: exported method MongoClient.GetSubscriptionById should have comment or be unexported (golint)
  • Line 243: warning: exported method MongoClient.DeleteSubscriptionById should have comment or be unexported (golint)
  • Line 247: warning: exported method MongoClient.AddSubscription should have comment or be unexported (golint)
  • Line 270: warning: exported method MongoClient.UpdateSubscription should have comment or be unexported (golint)
  • Line 282: warning: exported method MongoClient.DeleteSubscriptionBySlug should have comment or be unexported (golint)
  • Line 290: warning: comment on exported method MongoClient.GetSubscriptions should be of the form "GetSubscriptions ..." (golint)
  • Line 339: warning: exported method MongoClient.AddTransmission should have comment or be unexported (golint)
  • Line 358: warning: exported method MongoClient.UpdateTransmission should have comment or be unexported (golint)
  • Line 370: warning: exported method MongoClient.DeleteTransmission should have comment or be unexported (golint)
  • Line 376: warning: exported method MongoClient.GetTransmissionById should have comment or be unexported (golint)
  • Line 384: warning: exported method MongoClient.GetTransmissionsByNotificationSlug should have comment or be unexported (golint)
  • Line 388: warning: exported method MongoClient.GetTransmissionsByNotificationSlugAndStartEnd should have comment or be unexported (golint)
  • Line 392: warning: exported method MongoClient.GetTransmissionsByStartEnd should have comment or be unexported (golint)
  • Line 396: warning: exported method MongoClient.GetTransmissionsByStart should have comment or be unexported (golint)
  • Line 400: warning: exported method MongoClient.GetTransmissionsByEnd should have comment or be unexported (golint)
  • Line 404: warning: exported method MongoClient.GetTransmissionsByStatus should have comment or be unexported (golint)
  • Line 463: warning: exported method MongoClient.Cleanup should have comment or be unexported (golint)
  • Line 467: warning: exported method MongoClient.CleanupOld should have comment or be unexported (golint)

• internal/pkg/v2/infrastructure/redis/dbcommands.go
  • Line 29: warning: exported const InfiniteMin should have comment (or a comment on this block) or be unexported (golint)

• internal/security/secrets/contract/flagset.go
  • Line 19: warning: exported type FlagSet should have comment or be unexported (golint)

• internal/security/proxy/const.go
  • Line 1: warning: package comment should be of the form "Package proxy ..." (golint)
  • Line 19: warning: exported const ServicesPath should have comment (or a comment on this block) or be unexported (golint)

• internal/security/secretstore/main.go
  • Line 41: warning: exported function Main should have comment or be unexported (golint)

• internal/support/notifications/const.go
  • Line 20: warning: comment on exported var ESCALATIONSUBSCRIPTIONSLUG should be of the form "ESCALATIONSUBSCRIPTIONSLUG ..." (golint)
  • Line 22: warning: exported var ESCALATIONPREFIX should have comment or be unexported (golint)
  • Line 25: warning: comment on exported var START should be of the form "START ..." (golint)

• internal/core/data/v2/infrastructure/interfaces/db.go
  • Line 13: warning: exported type DBClient should have comment or be unexported (golint)

• internal/pkg/db/db.go
  • Line 29: warning: exported const RedisDB should have comment (or a comment on this block) or be unexported (golint)
  • Line 31: warning: comment on exported const EventsCollection should be of the form "EventsCollection ..." (golint)
  • Line 36: warning: comment on exported const ExportCollection should be of the form "ExportCollection ..." (golint)
  • Line 39: warning: comment on exported const LogsCollection should be of the form "LogsCollection ..." (golint)
  • Line 42: warning: comment on exported const Device should be of the form "Device ..." (golint)
  • Line 53: warning: comment on exported const Notification should be of the form "Notification ..." (golint)
  • Line 60: warning: exported var ErrNotFound should have comment or be unexported (golint)
  • Line 69: warning: exported type Configuration should have comment or be unexported (golint)
  • Line 80: warning: exported function MakeTimestamp should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/event.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 26: warning: comment on exported type Event should be of the form "Event ..." (with optional leading article) (golint)
  • Line 41: warning: exported method Event.ToContract should have comment or be unexported (golint)
  • Line 65: warning: exported method Event.FromContract should have comment or be unexported (golint)
  • Line 96: warning: exported method Event.TimestampForUpdate should have comment or be unexported (golint)
  • Line 100: warning: exported method Event.TimestampForAdd should have comment or be unexported (golint)

• internal/support/scheduler/config/config.go
  • Line 23: warning: comment on exported type ConfigurationStruct should be of the form "ConfigurationStruct ..." (with optional leading article) (golint)
  • Line 36: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 41: warning: exported type IntervalInfo should have comment or be unexported (golint)
  • Line 57: warning: exported type IntervalActionInfo should have comment or be unexported (golint)
  • Line 78: warning: comment on exported method IntervalActionInfo.URL should be of the form "URL ..." (golint)

• internal/core/metadata/config/config.go
  • Line 21: warning: comment on exported type ConfigurationStruct should be of the form "ConfigurationStruct ..." (with optional leading article) (golint)
  • Line 33: warning: exported type WritableInfo should have comment or be unexported (golint)
  • Line 38: warning: comment on exported type NotificationInfo should be of the form "NotificationInfo ..." (with optional leading article) (golint)

• internal/pkg/errorconcept/device_service.go
  • Line 23: warning: exported var DeviceService should have comment or be unexported (golint)
  • Line 29: warning: don't use underscores in Go names; struct field InvalidRequest_StatusInternalServer should be InvalidRequestStatusInternalServer (golint)
  • Line 63: warning: don't use underscores in Go names; type deviceServiceInvalidRequest_StatusInternalServer should be deviceServiceInvalidRequestStatusInternalServer (golint)

• internal/pkg/errorconcept/event.go
  • Line 22: warning: exported var Events should have comment or be unexported (golint)

• internal/pkg/db/test/db_metadata.go
  • Line 21: warning: exported function TestMetadataDB should have comment or be unexported (golint)

• internal/pkg/db/redis/device_profile.go
  • Line 1: warning: package comment should be of the form "Package redis ..." (golint)

• internal/security/secretstore/tokenmaintenance.go
  • Line 45: warning: exported type RevokeFunc should have comment or be unexported (golint)
  • Line 47: warning: exported type TokenMaintenance should have comment or be unexported (golint)

• internal/constants.go
  • Line 1: warning: package comment should be of the form "Package internal ..." (golint)
  • Line 17: warning: exported const BootTimeoutDefault should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: exported const ConfigProviderEnvVar should have comment (or a comment on this block) or be unexported (golint)

• internal/core/data/io.go
  • Line 93: warning: should not use basic type string as key in context.WithValue (golint)

• internal/core/metadata/rest_command_test.go
  • Line 217: warning: error var unExpectedError should have name of the form errFoo (golint)

• internal/core/metadata/rest_deviceprofile_test.go
  • Line 1453: warning: context.Context should be the first parameter of a function (golint)

• internal/pkg/errorconcept/addressable.go
  • Line 23: warning: exported var Addressable should have comment or be unexported (golint)
  • Line 29: warning: don't use underscores in Go names; struct field InvalidRequest_StatusInternalServer should be InvalidRequestStatusInternalServer (golint)
  • Line 78: warning: don't use underscores in Go names; type addressableInvalidRequest_StatusInternalServer should be addressableInvalidRequestStatusInternalServer (golint)

• internal/security/secrets/directory/directory.go
  • Line 30: warning: exported function NewHandler should have comment or be unexported (golint)

• internal/system/agent/executor/executor-stub.go
  • Line 36: warning: exported type Stub should have comment or be unexported (golint)
  • Line 43: warning: exported function NewStub should have comment or be unexported (golint)

• internal/pkg/db/mongo/models/value_descriptor.go
  • Line 1: warning: package comment should be of the form "Package models ..." (golint)
  • Line 22: warning: comment on exported type ValueDescriptor should be of the form "ValueDescriptor ..." (with optional leading article) (golint)
  • Line 44: warning: exported method ValueDescriptor.ToContract should have comment or be unexported (golint)
  • Line 73: warning: exported method ValueDescriptor.FromContract should have comment or be unexported (golint)

• internal/pkg/errorconcept/device_profile.go
  • Line 24: warning: exported var DeviceProfile should have comment or be unexported (golint)
  • Line 28: warning: don't use underscores in Go names; struct field ContractInvalid_StatusConflict should be ContractInvalidStatusConflict (golint)
  • Line 31: warning: don't use underscores in Go names; struct field InvalidState_StatusBadRequest should be InvalidStateStatusBadRequest (golint)
  • Line 32: warning: don't use underscores in Go names; struct field InvalidState_StatusConflict should be InvalidStateStatusConflict (golint)
  • Line 38: warning: don't use underscores in Go names; struct field UnmarshalYaml_StatusInternalServer should be UnmarshalYamlStatusInternalServer (golint)
  • Line 39: warning: don't use underscores in Go names; struct field UnmarshalYaml_StatusServiceUnavailable should be UnmarshalYamlStatusServiceUnavailable (golint)
  • Line 42: warning: don't use underscores in Go names; type deviceProfileContractInvalid_StatusConflict should be deviceProfileContractInvalidStatusConflict (golint)
  • Line 88: warning: don't use underscores in Go names; type deviceProfileInvalidState_StatusBadRequest should be deviceProfileInvalidStateStatusBadRequest (golint)
  • Line 103: warning: don't use underscores in Go names; type deviceProfileInvalidState_StatusConflict should be deviceProfileInvalidStateStatusConflict (golint)
  • Line 190: warning: don't use underscores in Go names; type deviceProfileUnmarshalYaml_StatusInternalServer should be deviceProfileUnmarshalYamlStatusInternalServer (golint)
  • Line 204: warning: don't use underscores in Go names; type deviceProfileUnmarshalYaml_StatusServiceUnavailable should be deviceProfileUnmarshalYamlStatusServiceUnavailable (golint)

• internal/support/notifications/operators/notification/get.go
  • Line 23: warning: exported type IdExecutor should have comment or be unexported (golint)
  • Line 27: warning: exported type CollectionExecutor should have comment or be unexported (golint)
  • Line 165: warning: exported function NewIdExecutor should have comment or be unexported (golint)
  • Line 172: warning: exported function NewSlugExecutor should have comment or be unexported (golint)
  • Line 179: warning: exported function NewSenderExecutor should have comment or be unexported (golint)
  • Line 187: warning: exported function NewStartExecutor should have comment or be unexported (golint)
  • Line 195: warning: exported function NewEndExecutor should have comment or be unexported (golint)
  • Line 203: warning: exported function NewStartEndExecutor should have comment or be unexported (golint)
  • Line 212: warning: exported function NewLabelsExecutor should have comment or be unexported (golint)
  • Line 220: warning: exported function NewGetNewestExecutor should have comment or be unexported (golint)

• internal/support/scheduler/operators/interval/db.go
  • Line 1: warning: package comment should be of the form "Package interval ..." (golint)
  • Line 71: warning: exported type IntervalActionLoader should have comment or be unexported (golint)

• internal/system/executor/docker.go
  • Line 24: warning: exported const Start should have comment (or a comment on this block) or be unexported (golint)

• internal/support/notifications/rest_notification_test.go
  • Line 58: warning: error var testError should have name of the form errFoo (golint)

• internal/core/metadata/operators/device_service/update_test.go
  • Line 15: warning: don't use an underscore in package name (golint)

• internal/support/notifications/main.go
  • Line 20: warning: package comment should be of the form "Package notifications ..." (golint)
  • Line 49: warning: exported function Main should have comment or be unexported (golint)

• version.go
  • Line 11: warning: comment on exported var Version should be of the form "Version ..." (golint)

• internal/interface.go
  • Line 5: warning: exported type HttpCaller should have comment or be unexported (golint)

• internal/core/metadata/operators/device_service/get.go
  • Line 15: warning: don't use an underscore in package name (golint)
  • Line 98: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 124: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 148: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• internal/pkg/errorconcept/handler.go
  • Line 23: warning: exported type ErrorConceptType should have comment or be unexported (golint)
  • Line 29: warning: exported type Handler should have comment or be unexported (golint)
  • Line 33: warning: exported type ErrorHandler should have comment or be unexported (golint)
  • Line 39: warning: exported function NewErrorHandler should have comment or be unexported (golint)

• internal/security/redis/constants.go
  • Line 19: warning: exported const SecretStore should have comment or be unexported (golint)
  • Line 20: warning: exported const Confdir should have comment or be unexported (golint)
  • Line 21: warning: exported const ConfigFileName should have comment or be unexported (golint)
  • Line 22: warning: exported const VaultToken should have comment or be unexported (golint)

• internal/system/agent/config/config.go
  • Line 21: warning: exported type ConfigurationClients should have comment or be unexported (golint)
  • Line 23: warning: exported type ConfigurationStruct should have comment or be unexported (golint)
  • Line 35: warning: exported type WritableInfo should have comment or be unexported (golint)

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• internal/security/secrets/certificates/tls.go
  • Line 41: warning: cyclomatic complexity 17 of function (tlsCertGenerator).Generate() is high (> 15) (gocyclo)

• internal/core/metadata/rest_provisionwatcher.go
  • Line 38: warning: cyclomatic complexity 17 of function restAddProvisionWatcher() is high (> 15) (gocyclo)

• internal/pkg/db/redis/metadata.go
  • Line 996: warning: cyclomatic complexity 17 of function addProvisionWatcher() is high (> 15) (gocyclo)

• internal/support/notifications/sending_service.go
  • Line 239: warning: cyclomatic complexity 16 of function smtpSend() is high (> 15) (gocyclo)

• internal/pkg/db/test/db_data.go
  • Line 75: warning: cyclomatic complexity 54 of function testDBReadings() is high (> 15) (gocyclo)
  • Line 291: warning: cyclomatic complexity 52 of function testDBEvents() is high (> 15) (gocyclo)
  • Line 503: warning: cyclomatic complexity 39 of function testDBValueDescriptors() is high (> 15) (gocyclo)

• internal/pkg/db/test/db_notifications.go
  • Line 36: warning: cyclomatic complexity 31 of function testDBNotification() is high (> 15) (gocyclo)
  • Line 254: warning: cyclomatic complexity 16 of function testDBTransmission() is high (> 15) (gocyclo)

• internal/core/metadata/operators/device_profile/value_descriptor.go
  • Line 87: warning: cyclomatic complexity 19 of function (updateValueDescriptor).Execute() is high (> 15) (gocyclo)

• internal/core/metadata/operators/addressable/update.go
  • Line 33: warning: cyclomatic complexity 18 of function (addressUpdate).Execute() is high (> 15) (gocyclo)

• internal/core/metadata/operators/device/update.go
  • Line 42: warning: cyclomatic complexity 16 of function (updateDevice).Execute() is high (> 15) (gocyclo)

• internal/support/scheduler/schedulercontext_test.go
  • Line 54: warning: cyclomatic complexity 16 of function TestRet() is high (> 15) (gocyclo)

• internal/pkg/db/test/db_metadata.go
  • Line 320: warning: cyclomatic complexity 35 of function testDBAddressables() is high (> 15) (gocyclo)
  • Line 910: warning: cyclomatic complexity 31 of function testDBDevice() is high (> 15) (gocyclo)
  • Line 770: warning: cyclomatic complexity 31 of function testDBDeviceProfile() is high (> 15) (gocyclo)
  • Line 1034: warning: cyclomatic complexity 31 of function testDBProvisionWatcher() is high (> 15) (gocyclo)
  • Line 663: warning: cyclomatic complexity 23 of function testDBDeviceReport() is high (> 15) (gocyclo)
  • Line 559: warning: cyclomatic complexity 23 of function testDBDeviceService() is high (> 15) (gocyclo)
  • Line 479: warning: cyclomatic complexity 17 of function testDBCommand() is high (> 15) (gocyclo)

• internal/support/scheduler/rest_intervalaction.go
  • Line 109: warning: cyclomatic complexity 19 of function intervalActionHandler() is high (> 15) (gocyclo)

• internal/security/secretstore/init.go
  • Line 59: warning: cyclomatic complexity 52 of function (*Bootstrap).BootstrapHandler() is high (> 15) (gocyclo)

• internal/security/fileprovider/provider.go
  • Line 71: warning: cyclomatic complexity 28 of function (*fileTokenProvider).Run() is high (> 15) (gocyclo)

• internal/support/scheduler/interval_action.go
  • Line 79: warning: cyclomatic complexity 23 of function updateIntervalAction() is high (> 15) (gocyclo)

• internal/core/data/valuedescriptor.go
  • Line 273: warning: cyclomatic complexity 19 of function updateValueDescriptor() is high (> 15) (gocyclo)

• internal/pkg/db/test/db_scheduler.go
  • Line 159: warning: cyclomatic complexity 31 of function testDBIntervalAction() is high (> 15) (gocyclo)
  • Line 58: warning: cyclomatic complexity 23 of function testDBInterval() is high (> 15) (gocyclo)

• internal/support/logging/router.go
  • Line 73: warning: cyclomatic complexity 23 of function getCriteria() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!