Preparing report...

Report for github.com/edgexfoundry/go-mod-secrets

(v0.0.33)

A+    Excellent!    Found 13 issues across 24 files

Tweet

gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • pkg/providers/vault/client_test.go
    • Line 374: warning: cyclomatic complexity 19 of function TestHttpSecretStoreManager_SetValue() is high (> 15) (gocyclo)
    • Line 117: warning: cyclomatic complexity 16 of function TestHttpSecretStoreManager_GetValue() is high (> 15) (gocyclo)

golint54%

Golint is a linter for Go source code.

    • pkg/providers/vault/models.go
    • Line 17: warning: exported type TokenLookupMetadata should have comment or be unexported (golint)
    • Line 24: warning: exported type TokenLookupResponse should have comment or be unexported (golint)
    • pkg/listener/poll.go
    • Line 86: warning: exported method InMemoryCacheListener.SetSecrets should have comment or be unexported (golint)
    • pkg/keys/constants.go
    • Line 1: warning: package comment should be of the form "Package keys ..." (golint)
    • Line 5: warning: exported const DatabaseUsername should have comment (or a comment on this block) or be unexported (golint)
    • pkg/errors.go
    • Line 1: warning: package comment should be of the form "Package pkg ..." (golint)
    • pkg/providers/vault/client.go
    • Line 39: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 57: warning: exported method Client.RefreshToken should have comment or be unexported (golint)
    • Line 159: warning: exported method Client.GetTokenLookupResponseData should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell95%

Misspell Finds commonly misspelled English words

    • pkg/listener/poll_test.go
    • Line 253: warning: "ocurred" is a misspelling of "occurred" (misspell)
    • Line 285: warning: "ocurred" is a misspelling of "occurred" (misspell)
    • Line 316: warning: "ocurred" is a misspelling of "occurred" (misspell)
    • Line 322: warning: "ocurred" is a misspelling of "occurred" (misspell)
    • Line 371: warning: "ocurred" is a misspelling of "occurred" (misspell)