Preparing report...

Report for github.com/ekara-platform/engine

A+    Excellent!    Found 31 issues across 123 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint76%

Golint is a linter for Go source code.

    • engine/engine.go
    • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • engine/model/task.go
    • Line 41: warning: exported method Task.DescType should have comment or be unexported (golint)
    • Line 45: warning: exported method Task.DescName should have comment or be unexported (golint)
    • Line 49: warning: exported method Task.Parameters should have comment or be unexported (golint)
    • Line 53: warning: exported method Task.EnvVars should have comment or be unexported (golint)
    • Line 57: warning: exported method Task.ComponentId should have comment or be unexported (golint)
    • Line 60: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 65: warning: exported method Task.Component should have comment or be unexported (golint)
    • Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • engine/model/template_context.go
    • Line 14: warning: comment on exported type TemplateContext should be of the form "TemplateContext ..." (with optional leading article) (golint)
    • Line 45: warning: exported method TemplateContext.Clone should have comment or be unexported (golint)
    • Line 67: warning: exported method TemplateContext.Execute should have comment or be unexported (golint)
    • engine/model/envvars.go
    • Line 11: warning: comment on exported function CreateEmptyEnvVars should be of the form "CreateEmptyEnvVars ..." (golint)
    • Line 16: warning: exported function CreateEnvVars should have comment or be unexported (golint)
    • Line 24: warning: exported method EnvVars.Override should have comment or be unexported (golint)
    • engine/model/orchestrator.go
    • Line 29: warning: exported method Orchestrator.EnvVars should have comment or be unexported (golint)
    • Line 33: warning: exported method Orchestrator.Parameters should have comment or be unexported (golint)
    • Line 45: warning: exported method Orchestrator.ComponentId should have comment or be unexported (golint)
    • Line 49: warning: exported method Orchestrator.Component should have comment or be unexported (golint)
    • Line 53: warning: exported method Orchestrator.DescType should have comment or be unexported (golint)
    • Line 57: warning: exported method Orchestrator.DescName should have comment or be unexported (golint)
    • engine/action/runtime_context.go
    • Line 11: warning: exported type RuntimeContext should have comment or be unexported (golint)
    • Line 22: warning: comment on exported function CreateRuntimeContext should be of the form "CreateRuntimeContext ..." (golint)
    • engine/ansible/inventory.go
    • Line 9: warning: exported type Inventory should have comment or be unexported (golint)
    • Line 14: warning: exported type Host should have comment or be unexported (golint)
    • Line 19: warning: exported type Group should have comment or be unexported (golint)
    • Line 25: warning: exported type InventoryVars should have comment or be unexported (golint)
    • Line 28: warning: exported method Inventory.UnmarshalAnsibleInventory should have comment or be unexported (golint)
    • engine/util/feedback.go
    • Line 10: warning: exported const FeedbackPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type FeedbackNotifier should have comment or be unexported (golint)
    • Line 22: warning: exported type FeedbackUpdate should have comment or be unexported (golint)
    • Line 63: warning: exported function CreateLoggingProgressNotifier should have comment or be unexported (golint)
    • engine/util/launch_context_mock.go
    • Line 23: warning: exported function CreateMockLaunchContext should have comment or be unexported (golint)
    • Line 28: warning: exported function CreateMockLaunchContextWithData should have comment or be unexported (golint)
    • Line 36: warning: exported function CreateMockLaunchContextWithDataAndFolder should have comment or be unexported (golint)
    • Line 50: warning: comment on exported method MockLaunchContext.Skipping should be of the form "Skipping ..." (golint)
    • Line 60: warning: comment on exported method MockLaunchContext.Feedback should be of the form "Feedback ..." (golint)
    • Line 90: warning: comment on exported method MockLaunchContext.ExternalVars should be of the form "ExternalVars ..." (golint)
    • engine/util/tester.go
    • Line 12: warning: exported type EkaraComponentTester should have comment or be unexported (golint)
    • Line 16: warning: exported function CreateComponentTester should have comment or be unexported (golint)
    • Line 25: warning: exported method EkaraComponentTester.Init should have comment or be unexported (golint)
    • Line 33: warning: exported method EkaraComponentTester.Env should have comment or be unexported (golint)
    • Line 37: warning: exported method EkaraComponentTester.AssertParam should have comment or be unexported (golint)
    • Line 42: warning: exported method EkaraComponentTester.AssertEnvVar should have comment or be unexported (golint)
    • Line 47: warning: exported function CreateFakeComponent should have comment or be unexported (golint)
    • engine/util/constant.go
    • Line 20: warning: comment on exported const StarterVerbosityVariableKey should be of the form "StarterVerbosityVariableKey ..." (golint)
    • engine/action/do_destroy.go
    • Line 20: warning: exported method DestroyResult.IsSuccess should have comment or be unexported (golint)
    • Line 24: warning: exported method DestroyResult.FromJson should have comment or be unexported (golint)
    • Line 32: warning: exported method DestroyResult.AsJson should have comment or be unexported (golint)
    • engine/model/provider.go
    • Line 43: warning: exported method Provider.DescType should have comment or be unexported (golint)
    • Line 47: warning: exported method Provider.DescName should have comment or be unexported (golint)
    • Line 51: warning: exported method Provider.EnvVars should have comment or be unexported (golint)
    • Line 55: warning: exported method Provider.Parameters should have comment or be unexported (golint)
    • Line 59: warning: exported method Provider.Proxy should have comment or be unexported (golint)
    • Line 63: warning: exported method Provider.ComponentId should have comment or be unexported (golint)
    • Line 67: warning: exported method Provider.Component should have comment or be unexported (golint)
    • engine/model/const.go
    • Line 8: warning: comment on exported const ParentComponentSuffix should be of the form "ParentComponentSuffix ..." (golint)
    • engine/model/environment.go
    • Line 63: warning: exported method Environment.Merge should have comment or be unexported (golint)
    • Line 79: warning: exported method Environment.IsReferenced should have comment or be unexported (golint)
    • Line 123: warning: exported method Environment.DescType should have comment or be unexported (golint)
    • Line 127: warning: exported method Environment.DescName should have comment or be unexported (golint)
    • Line 131: warning: exported method Environment.Validate should have comment or be unexported (golint)
    • engine/model/node.go
    • Line 30: warning: exported type NodeHooks should have comment or be unexported (golint)
    • Line 41: warning: exported method NodeSet.DescType should have comment or be unexported (golint)
    • Line 45: warning: exported method NodeSet.DescName should have comment or be unexported (golint)
    • Line 62: warning: exported method NodeHooks.HasTasks should have comment or be unexported (golint)
    • engine/model/stack.go
    • Line 30: warning: exported type StackHooks should have comment or be unexported (golint)
    • Line 56: warning: exported method Stack.EnvVars should have comment or be unexported (golint)
    • Line 60: warning: exported method Stack.Parameters should have comment or be unexported (golint)
    • Line 64: warning: exported method Stack.DescType should have comment or be unexported (golint)
    • Line 68: warning: exported method Stack.DescName should have comment or be unexported (golint)
    • Line 72: warning: exported method Stack.ComponentId should have comment or be unexported (golint)
    • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 80: warning: exported method Stack.Component should have comment or be unexported (golint)
    • Line 83: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 185: warning: exported method StackHooks.HasTasks should have comment or be unexported (golint)
    • engine/action/action.go
    • Line 23: warning: exported type Result should have comment or be unexported (golint)
    • Line 51: warning: exported function All should have comment or be unexported (golint)
    • Line 61: warning: comment on exported method Action.Execute should be of the form "Execute ..." (golint)
    • engine/model/params.go
    • Line 11: warning: comment on exported type Parameterized should be of the form "Parameterized ..." (with optional leading article) (golint)
    • Line 61: warning: comment on exported method Parameters.Override should be of the form "Override ..." (golint)
    • engine/model/provider_ref.go
    • Line 37: warning: exported method ProviderRef.Resolve should have comment or be unexported (golint)
    • Line 48: warning: exported method ProviderRef.ComponentId should have comment or be unexported (golint)
    • Line 52: warning: exported method ProviderRef.Component should have comment or be unexported (golint)
    • Line 55: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign99%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!