gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• go-ethercore/eth/fetcher/tx_fetcher.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• go-ethercore/params/version.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• go-ethercore/eth/downloader/downloader_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• go-ethercore/core/tx_pool_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo84%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• go-ethercore/cmd/bootnode/main.go
  • Line 37: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)

• go-ethercore/whisper/whisperv6/message_test.go
  • Line 218: warning: cyclomatic complexity 17 of function singleEnvelopeOpenTest() is high (> 15) (gocyclo)

• go-ethercore/ethdb/dbtest/testsuite.go
  • Line 30: warning: cyclomatic complexity 45 of function TestDatabaseSuite() is high (> 15) (gocyclo)

• go-ethercore/whisper/whisperv6/whisper_test.go
  • Line 262: warning: cyclomatic complexity 51 of function TestWhisperSymKeyManagement() is high (> 15) (gocyclo)
  • Line 144: warning: cyclomatic complexity 32 of function TestWhisperIdentityManagement() is high (> 15) (gocyclo)
  • Line 31: warning: cyclomatic complexity 21 of function TestWhisperBasic() is high (> 15) (gocyclo)
  • Line 832: warning: cyclomatic complexity 17 of function TestBloom() is high (> 15) (gocyclo)
  • Line 518: warning: cyclomatic complexity 16 of function TestCustomization() is high (> 15) (gocyclo)

• go-ethercore/whisper/whisperv6/filter_test.go
  • Line 633: warning: cyclomatic complexity 26 of function TestWatchers() is high (> 15) (gocyclo)
  • Line 283: warning: cyclomatic complexity 23 of function TestMatchEnvelope() is high (> 15) (gocyclo)
  • Line 425: warning: cyclomatic complexity 16 of function TestMatchMessageSym() is high (> 15) (gocyclo)

• go-ethercore/core/state/state_test.go
  • Line 204: warning: cyclomatic complexity 17 of function compareStateObjects() is high (> 15) (gocyclo)

• go-ethercore/les/server_handler.go
  • Line 177: warning: cyclomatic complexity 139 of function (*serverHandler).handleMsg() is high (> 15) (gocyclo)

• go-ethercore/eth/fetcher/tx_fetcher_test.go
  • Line 1253: warning: cyclomatic complexity 87 of function testTransactionFetcher() is high (> 15) (gocyclo)

• go-ethercore/consensus/ethash/sealer.go
  • Line 51: warning: cyclomatic complexity 18 of function (*Ethash).Seal() is high (> 15) (gocyclo)
  • Line 267: warning: cyclomatic complexity 17 of function (*remoteSealer).loop() is high (> 15) (gocyclo)

• go-ethercore/core/tx_pool_test.go
  • Line 564: warning: cyclomatic complexity 28 of function TestTransactionPostponing() is high (> 15) (gocyclo)
  • Line 1152: warning: cyclomatic complexity 24 of function TestTransactionPoolRepricing() is high (> 15) (gocyclo)
  • Line 1335: warning: cyclomatic complexity 20 of function TestTransactionPoolUnderpricing() is high (> 15) (gocyclo)
  • Line 1655: warning: cyclomatic complexity 19 of function testTransactionJournaling() is high (> 15) (gocyclo)
  • Line 469: warning: cyclomatic complexity 19 of function TestTransactionDropping() is high (> 15) (gocyclo)
  • Line 1572: warning: cyclomatic complexity 17 of function TestTransactionReplacement() is high (> 15) (gocyclo)
  • Line 1506: warning: cyclomatic complexity 17 of function TestTransactionDeduplication() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/bind/topics.go
  • Line 117: warning: cyclomatic complexity 23 of function parseTopics() is high (> 15) (gocyclo)
  • Line 32: warning: cyclomatic complexity 22 of function makeTopics() is high (> 15) (gocyclo)

• go-ethercore/tests/fuzzers/txfetcher/txfetcher_fuzzer.go
  • Line 51: warning: cyclomatic complexity 29 of function Fuzz() is high (> 15) (gocyclo)

• go-ethercore/rlp/encode.go
  • Line 318: warning: cyclomatic complexity 18 of function makeWriter() is high (> 15) (gocyclo)

• go-ethercore/cmd/geth/main.go
  • Line 319: warning: cyclomatic complexity 27 of function startNode() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_netstats.go
  • Line 201: warning: cyclomatic complexity 29 of function (serverStats).render() is high (> 15) (gocyclo)
  • Line 73: warning: cyclomatic complexity 23 of function (*wizard).gatherStats() is high (> 15) (gocyclo)

• go-ethercore/tests/fuzzers/trie/trie-fuzzer.go
  • Line 136: warning: cyclomatic complexity 16 of function runRandTest() is high (> 15) (gocyclo)

• go-ethercore/core/rawdb/freezer.go
  • Line 254: warning: cyclomatic complexity 25 of function (*freezer).freeze() is high (> 15) (gocyclo)

• go-ethercore/les/costtracker.go
  • Line 244: warning: cyclomatic complexity 26 of function (*costTracker).gfLoop() is high (> 15) (gocyclo)

• go-ethercore/les/fetcher.go
  • Line 253: warning: cyclomatic complexity 24 of function (*lightFetcher).announce() is high (> 15) (gocyclo)
  • Line 138: warning: cyclomatic complexity 21 of function (*lightFetcher).syncLoop() is high (> 15) (gocyclo)
  • Line 627: warning: cyclomatic complexity 17 of function (*lightFetcher).checkAnnouncedHeaders() is high (> 15) (gocyclo)

• go-ethercore/consensus/clique/snapshot.go
  • Line 185: warning: cyclomatic complexity 28 of function (*Snapshot).apply() is high (> 15) (gocyclo)

• go-ethercore/eth/backend.go
  • Line 117: warning: cyclomatic complexity 23 of function New() is high (> 15) (gocyclo)

• go-ethercore/core/blockchain_test.go
  • Line 590: warning: cyclomatic complexity 28 of function TestFastVsFullChains() is high (> 15) (gocyclo)
  • Line 1889: warning: cyclomatic complexity 20 of function testInsertKnownChainData() is high (> 15) (gocyclo)
  • Line 983: warning: cyclomatic complexity 19 of function TestLogRebirth() is high (> 15) (gocyclo)
  • Line 818: warning: cyclomatic complexity 17 of function TestChainTxReorgs() is high (> 15) (gocyclo)
  • Line 376: warning: cyclomatic complexity 17 of function testReorg() is high (> 15) (gocyclo)
  • Line 1318: warning: cyclomatic complexity 17 of function TestEIP155Transition() is high (> 15) (gocyclo)
  • Line 707: warning: cyclomatic complexity 16 of function TestLightVsFastVsFullChainHeads() is high (> 15) (gocyclo)

• go-ethercore/miner/stress_clique.go
  • Line 47: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• go-ethercore/params/config.go
  • Line 548: warning: cyclomatic complexity 16 of function (*ChainConfig).checkCompatible() is high (> 15) (gocyclo)

• go-ethercore/cmd/evm/staterunner.go
  • Line 51: warning: cyclomatic complexity 17 of function stateTestCmd() is high (> 15) (gocyclo)

• go-ethercore/core/types/receipt_test.go
  • Line 155: warning: cyclomatic complexity 19 of function TestDeriveFields() is high (> 15) (gocyclo)

• go-ethercore/core/rawdb/freezer_reinit.go
  • Line 36: warning: cyclomatic complexity 18 of function InitDatabaseFromFreezer() is high (> 15) (gocyclo)

• go-ethercore/miner/worker.go
  • Line 826: warning: cyclomatic complexity 29 of function (*worker).commitNewWork() is high (> 15) (gocyclo)
  • Line 404: warning: cyclomatic complexity 28 of function (*worker).mainLoop() is high (> 15) (gocyclo)
  • Line 292: warning: cyclomatic complexity 22 of function (*worker).newWorkLoop() is high (> 15) (gocyclo)
  • Line 712: warning: cyclomatic complexity 21 of function (*worker).commitTransactions() is high (> 15) (gocyclo)

• go-ethercore/p2p/simulations/http_test.go
  • Line 593: warning: cyclomatic complexity 33 of function TestHTTPSnapshot() is high (> 15) (gocyclo)
  • Line 474: warning: cyclomatic complexity 16 of function (*expectEvents).expect() is high (> 15) (gocyclo)

• go-ethercore/p2p/dial.go
  • Line 223: warning: cyclomatic complexity 23 of function (*dialScheduler).loop() is high (> 15) (gocyclo)

• go-ethercore/p2p/server.go
  • Line 690: warning: cyclomatic complexity 20 of function (*Server).run() is high (> 15) (gocyclo)
  • Line 536: warning: cyclomatic complexity 17 of function (*Server).setupDiscovery() is high (> 15) (gocyclo)

• go-ethercore/cmd/clef/main.go
  • Line 429: warning: cyclomatic complexity 17 of function signer() is high (> 15) (gocyclo)

• go-ethercore/internal/jsre/pretty.go
  • Line 122: warning: cyclomatic complexity 18 of function (ppctx).printObject() is high (> 15) (gocyclo)

• go-ethercore/p2p/discover/v4_udp.go
  • Line 530: warning: cyclomatic complexity 22 of function (*UDPv4).loop() is high (> 15) (gocyclo)

• go-ethercore/cmd/faucet/faucet.go
  • Line 310: warning: cyclomatic complexity 50 of function (*faucet).apiHandler() is high (> 15) (gocyclo)
  • Line 96: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• go-ethercore/cmd/wnode/main.go
  • Line 175: warning: cyclomatic complexity 24 of function initialize() is high (> 15) (gocyclo)
  • Line 325: warning: cyclomatic complexity 20 of function configureNode() is high (> 15) (gocyclo)

• go-ethercore/eth/handler.go
  • Line 377: warning: cyclomatic complexity 116 of function (*ProtocolManager).handleMsg() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/pack_test.go
  • Line 631: warning: cyclomatic complexity 16 of function TestMethodPack() is high (> 15) (gocyclo)

• go-ethercore/p2p/simulations/network_test.go
  • Line 38: warning: cyclomatic complexity 49 of function TestSnapshot() is high (> 15) (gocyclo)
  • Line 289: warning: cyclomatic complexity 21 of function TestNetworkSimulation() is high (> 15) (gocyclo)

• go-ethercore/whisper/whisperv6/api.go
  • Line 337: warning: cyclomatic complexity 26 of function (*PublicWhisperAPI).Messages() is high (> 15) (gocyclo)
  • Line 232: warning: cyclomatic complexity 20 of function (*PublicWhisperAPI).Post() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_intro.go
  • Line 47: warning: cyclomatic complexity 28 of function (*wizard).run() is high (> 15) (gocyclo)

• go-ethercore/eth/handler_test.go
  • Line 276: warning: cyclomatic complexity 22 of function testGetNodeData() is high (> 15) (gocyclo)

• go-ethercore/les/clientpool.go
  • Line 210: warning: cyclomatic complexity 17 of function (*clientPool).connect() is high (> 15) (gocyclo)

• go-ethercore/eth/downloader/downloader_test.go
  • Line 984: warning: cyclomatic complexity 16 of function testInvalidHeaderRollback() is high (> 15) (gocyclo)
  • Line 516: warning: cyclomatic complexity 16 of function testThrottling() is high (> 15) (gocyclo)

• go-ethercore/internal/ethapi/api.go
  • Line 760: warning: cyclomatic complexity 25 of function DoCall() is high (> 15) (gocyclo)
  • Line 1375: warning: cyclomatic complexity 16 of function (*SendTxArgs).setDefaults() is high (> 15) (gocyclo)
  • Line 886: warning: cyclomatic complexity 16 of function DoEstimateGas() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/unpack.go
  • Line 192: warning: cyclomatic complexity 19 of function toGoType() is high (> 15) (gocyclo)

• go-ethercore/p2p/testing/protocolsession.go
  • Line 112: warning: cyclomatic complexity 19 of function (*ProtocolSession).expect() is high (> 15) (gocyclo)

• go-ethercore/rpc/subscription_test.go
  • Line 49: warning: cyclomatic complexity 16 of function TestSubscriptions() is high (> 15) (gocyclo)

• go-ethercore/core/state/statedb_test.go
  • Line 568: warning: cyclomatic complexity 21 of function TestCopyCopyCommitCopy() is high (> 15) (gocyclo)
  • Line 496: warning: cyclomatic complexity 17 of function TestCopyCommitCopy() is high (> 15) (gocyclo)

• go-ethercore/p2p/simulations/network.go
  • Line 956: warning: cyclomatic complexity 21 of function (*Network).Load() is high (> 15) (gocyclo)

• go-ethercore/consensus/clique/snapshot_test.go
  • Line 99: warning: cyclomatic complexity 27 of function TestClique() is high (> 15) (gocyclo)

• go-ethercore/les/clientpool_test.go
  • Line 81: warning: cyclomatic complexity 18 of function testClientPool() is high (> 15) (gocyclo)

• go-ethercore/eth/filters/api.go
  • Line 459: warning: cyclomatic complexity 26 of function (*FilterCriteria).UnmarshalJSON() is high (> 15) (gocyclo)

• go-ethercore/accounts/usbwallet/wallet.go
  • Line 304: warning: cyclomatic complexity 28 of function (*wallet).selfDerive() is high (> 15) (gocyclo)

• go-ethercore/tests/rlp_test_util.go
  • Line 124: warning: cyclomatic complexity 16 of function checkDecodeFromJSON() is high (> 15) (gocyclo)

• go-ethercore/eth/downloader/queue.go
  • Line 803: warning: cyclomatic complexity 17 of function (*queue).deliver() is high (> 15) (gocyclo)
  • Line 682: warning: cyclomatic complexity 17 of function (*queue).DeliverHeaders() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_ethstats.go
  • Line 28: warning: cyclomatic complexity 19 of function (*wizard).deployEthstats() is high (> 15) (gocyclo)

• go-ethercore/eth/fetcher/block_fetcher.go
  • Line 301: warning: cyclomatic complexity 71 of function (*BlockFetcher).loop() is high (> 15) (gocyclo)

• go-ethercore/les/retrieve.go
  • Line 310: warning: cyclomatic complexity 16 of function (*sentReq).tryRequest() is high (> 15) (gocyclo)

• go-ethercore/mobile/android_test.go
  • Line 157: warning: cyclomatic complexity 18 of function TestAndroid() is high (> 15) (gocyclo)

• go-ethercore/p2p/discv5/ticket.go
  • Line 758: warning: cyclomatic complexity 18 of function (*topicRadius).recalcRadius() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_dashboard.go
  • Line 27: warning: cyclomatic complexity 34 of function (*wizard).deployDashboard() is high (> 15) (gocyclo)

• go-ethercore/cmd/utils/cmd.go
  • Line 88: warning: cyclomatic complexity 17 of function ImportChain() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_node.go
  • Line 30: warning: cyclomatic complexity 25 of function (*wizard).deployNode() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/bind/bind.go
  • Line 50: warning: cyclomatic complexity 31 of function Bind() is high (> 15) (gocyclo)

• go-ethercore/les/sync_test.go
  • Line 43: warning: cyclomatic complexity 18 of function testCheckpointSyncing() is high (> 15) (gocyclo)
  • Line 135: warning: cyclomatic complexity 16 of function testMissOracleBackend() is high (> 15) (gocyclo)

• go-ethercore/ethclient/ethclient.go
  • Line 97: warning: cyclomatic complexity 21 of function (*Client).getBlock() is high (> 15) (gocyclo)

• go-ethercore/console/console.go
  • Line 341: warning: cyclomatic complexity 19 of function (*Console).Interactive() is high (> 15) (gocyclo)
  • Line 417: warning: cyclomatic complexity 16 of function countIndents() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/ssh.go
  • Line 49: warning: cyclomatic complexity 21 of function dial() is high (> 15) (gocyclo)

• go-ethercore/eth/api_tracer.go
  • Line 140: warning: cyclomatic complexity 41 of function (*PrivateDebugAPI).traceChain() is high (> 15) (gocyclo)
  • Line 526: warning: cyclomatic complexity 19 of function (*PrivateDebugAPI).standardTraceBlockToFile() is high (> 15) (gocyclo)

• go-ethercore/core/chain_indexer.go
  • Line 301: warning: cyclomatic complexity 20 of function (*ChainIndexer).updateLoop() is high (> 15) (gocyclo)

• go-ethercore/accounts/usbwallet/trezor.go
  • Line 276: warning: cyclomatic complexity 19 of function (*trezorDriver).trezorExchange() is high (> 15) (gocyclo)

• go-ethercore/ethstats/ethstats.go
  • Line 137: warning: cyclomatic complexity 30 of function (*Service).loop() is high (> 15) (gocyclo)
  • Line 280: warning: cyclomatic complexity 17 of function (*Service).readLoop() is high (> 15) (gocyclo)

• go-ethercore/cmd/abigen/main.go
  • Line 123: warning: cyclomatic complexity 31 of function abigen() is high (> 15) (gocyclo)

• go-ethercore/cmd/evm/runner.go
  • Line 100: warning: cyclomatic complexity 35 of function runCmd() is high (> 15) (gocyclo)

• go-ethercore/core/vm/evm.go
  • Line 383: warning: cyclomatic complexity 24 of function (*EVM).create() is high (> 15) (gocyclo)
  • Line 189: warning: cyclomatic complexity 17 of function (*EVM).Call() is high (> 15) (gocyclo)

• go-ethercore/contracts/checkpointoracle/oracle_test.go
  • Line 167: warning: cyclomatic complexity 16 of function TestCheckpointRegister() is high (> 15) (gocyclo)

• go-ethercore/console/bridge.go
  • Line 101: warning: cyclomatic complexity 23 of function (*bridge).OpenWallet() is high (> 15) (gocyclo)

• go-ethercore/consensus/clique/clique.go
  • Line 245: warning: cyclomatic complexity 22 of function (*Clique).verifyHeader() is high (> 15) (gocyclo)
  • Line 348: warning: cyclomatic complexity 21 of function (*Clique).snapshot() is high (> 15) (gocyclo)
  • Line 584: warning: cyclomatic complexity 16 of function (*Clique).Seal() is high (> 15) (gocyclo)

• go-ethercore/les/peer.go
  • Line 575: warning: cyclomatic complexity 36 of function (*peer).Handshake() is high (> 15) (gocyclo)

• go-ethercore/les/client_handler.go
  • Line 146: warning: cyclomatic complexity 34 of function (*clientHandler).handleMsg() is high (> 15) (gocyclo)

• go-ethercore/les/sync.go
  • Line 90: warning: cyclomatic complexity 20 of function (*clientHandler).synchronise() is high (> 15) (gocyclo)

• go-ethercore/core/dao_test.go
  • Line 31: warning: cyclomatic complexity 22 of function TestDAOForkRangeExtradata() is high (> 15) (gocyclo)

• go-ethercore/core/bloombits/matcher.go
  • Line 260: warning: cyclomatic complexity 30 of function (*Matcher).subMatch() is high (> 15) (gocyclo)
  • Line 382: warning: cyclomatic complexity 25 of function (*Matcher).distributor() is high (> 15) (gocyclo)

• go-ethercore/trie/trie.go
  • Line 280: warning: cyclomatic complexity 25 of function (*Trie).delete() is high (> 15) (gocyclo)
  • Line 188: warning: cyclomatic complexity 19 of function (*Trie).insert() is high (> 15) (gocyclo)

• go-ethercore/cmd/geth/retesteth.go
  • Line 275: warning: cyclomatic complexity 26 of function (*RetestethAPI).SetChainParams() is high (> 15) (gocyclo)
  • Line 459: warning: cyclomatic complexity 20 of function (*RetestethAPI).mineBlock() is high (> 15) (gocyclo)
  • Line 743: warning: cyclomatic complexity 16 of function (*RetestethAPI).StorageRangeAt() is high (> 15) (gocyclo)

• go-ethercore/ethdb/leveldb/leveldb.go
  • Line 243: warning: cyclomatic complexity 41 of function (*Database).meter() is high (> 15) (gocyclo)

• go-ethercore/p2p/simulations/mocker.go
  • Line 103: warning: cyclomatic complexity 16 of function probabilistic() is high (> 15) (gocyclo)

• go-ethercore/les/serverpool.go
  • Line 298: warning: cyclomatic complexity 37 of function (*serverPool).eventLoop() is high (> 15) (gocyclo)

• go-ethercore/eth/downloader/statesync.go
  • Line 92: warning: cyclomatic complexity 17 of function (*Downloader).runStateSync() is high (> 15) (gocyclo)

• go-ethercore/log/format.go
  • Line 365: warning: cyclomatic complexity 19 of function escapeString() is high (> 15) (gocyclo)

• go-ethercore/node/node.go
  • Line 162: warning: cyclomatic complexity 17 of function (*Node).Start() is high (> 15) (gocyclo)

• go-ethercore/whisper/whisperv6/whisper.go
  • Line 674: warning: cyclomatic complexity 27 of function (*Whisper).runMessageLoop() is high (> 15) (gocyclo)

• go-ethercore/core/vm/gas_table.go
  • Line 96: warning: cyclomatic complexity 17 of function gasSStore() is high (> 15) (gocyclo)

• go-ethercore/eth/protocol_test.go
  • Line 281: warning: cyclomatic complexity 19 of function testSendTransactions() is high (> 15) (gocyclo)

• go-ethercore/eth/api_test.go
  • Line 64: warning: cyclomatic complexity 16 of function TestAccountRange() is high (> 15) (gocyclo)

• go-ethercore/p2p/testing/protocoltester.go
  • Line 208: warning: cyclomatic complexity 17 of function expectMsgs() is high (> 15) (gocyclo)

• go-ethercore/mobile/geth.go
  • Line 103: warning: cyclomatic complexity 17 of function NewNode() is high (> 15) (gocyclo)

• go-ethercore/metrics/ewma_test.go
  • Line 155: warning: cyclomatic complexity 17 of function TestEWMA15() is high (> 15) (gocyclo)
  • Line 86: warning: cyclomatic complexity 17 of function TestEWMA5() is high (> 15) (gocyclo)
  • Line 17: warning: cyclomatic complexity 17 of function TestEWMA1() is high (> 15) (gocyclo)

• go-ethercore/p2p/discv5/net.go
  • Line 354: warning: cyclomatic complexity 53 of function (*Network).loop() is high (> 15) (gocyclo)
  • Line 863: warning: cyclomatic complexity 28 of function init() is high (> 15) (gocyclo)
  • Line 1139: warning: cyclomatic complexity 18 of function (*Network).handleQueryEvent() is high (> 15) (gocyclo)

• go-ethercore/whisper/whisperv6/peer.go
  • Line 79: warning: cyclomatic complexity 17 of function (*Peer).handshake() is high (> 15) (gocyclo)

• go-ethercore/accounts/scwallet/wallet.go
  • Line 440: warning: cyclomatic complexity 25 of function (*Wallet).selfDerive() is high (> 15) (gocyclo)
  • Line 338: warning: cyclomatic complexity 17 of function (*Wallet).Open() is high (> 15) (gocyclo)

• go-ethercore/internal/jsre/jsre.go
  • Line 106: warning: cyclomatic complexity 19 of function (*JSRE).runEventLoop() is high (> 15) (gocyclo)

• go-ethercore/core/rawdb/database.go
  • Line 223: warning: cyclomatic complexity 36 of function InspectDatabase() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_genesis.go
  • Line 39: warning: cyclomatic complexity 16 of function (*wizard).makeGenesis() is high (> 15) (gocyclo)

• go-ethercore/accounts/usbwallet/hub.go
  • Line 134: warning: cyclomatic complexity 22 of function (*Hub).refreshWallets() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/argument.go
  • Line 131: warning: cyclomatic complexity 19 of function unpack() is high (> 15) (gocyclo)

• go-ethercore/cmd/checkpoint-admin/exec.go
  • Line 125: warning: cyclomatic complexity 18 of function sign() is high (> 15) (gocyclo)

• go-ethercore/consensus/ethash/consensus.go
  • Line 249: warning: cyclomatic complexity 16 of function (*Ethash).verifyHeader() is high (> 15) (gocyclo)

• go-ethercore/crypto/blake2b/blake2b_test.go
  • Line 154: warning: cyclomatic complexity 18 of function testHashes2X() is high (> 15) (gocyclo)

• go-ethercore/core/rawdb/freezer_table.go
  • Line 199: warning: cyclomatic complexity 19 of function (*freezerTable).repair() is high (> 15) (gocyclo)

• go-ethercore/les/api.go
  • Line 120: warning: cyclomatic complexity 18 of function (*PrivateLightServerAPI).setParams() is high (> 15) (gocyclo)
  • Line 211: warning: cyclomatic complexity 17 of function (*PrivateLightServerAPI).Benchmark() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/abi_test.go
  • Line 810: warning: cyclomatic complexity 19 of function TestUnpackIntoMapNamingConflict() is high (> 15) (gocyclo)

• go-ethercore/cmd/utils/flags.go
  • Line 1458: warning: cyclomatic complexity 43 of function SetEthConfig() is high (> 15) (gocyclo)
  • Line 1129: warning: cyclomatic complexity 28 of function SetP2PConfig() is high (> 15) (gocyclo)

• go-ethercore/core/vm/interpreter.go
  • Line 133: warning: cyclomatic complexity 33 of function (*EVMInterpreter).Run() is high (> 15) (gocyclo)

• go-ethercore/eth/fetcher/tx_fetcher.go
  • Line 346: warning: cyclomatic complexity 76 of function (*TxFetcher).loop() is high (> 15) (gocyclo)

• go-ethercore/eth/downloader/downloader.go
  • Line 701: warning: cyclomatic complexity 45 of function (*Downloader).findAncestor() is high (> 15) (gocyclo)
  • Line 1185: warning: cyclomatic complexity 44 of function (*Downloader).fetchParts() is high (> 15) (gocyclo)
  • Line 1359: warning: cyclomatic complexity 41 of function (*Downloader).processHeaders() is high (> 15) (gocyclo)
  • Line 911: warning: cyclomatic complexity 35 of function (*Downloader).fetchHeaders() is high (> 15) (gocyclo)
  • Line 416: warning: cyclomatic complexity 24 of function (*Downloader).syncWithPeer() is high (> 15) (gocyclo)
  • Line 1574: warning: cyclomatic complexity 22 of function (*Downloader).processFastSyncContent() is high (> 15) (gocyclo)
  • Line 348: warning: cyclomatic complexity 17 of function (*Downloader).synchronise() is high (> 15) (gocyclo)

• go-ethercore/tests/block_test_util.go
  • Line 208: warning: cyclomatic complexity 16 of function validateHeader() is high (> 15) (gocyclo)

• go-ethercore/eth/filters/api_test.go
  • Line 28: warning: cyclomatic complexity 40 of function TestUnmarshalJSONNewFilterArgs() is high (> 15) (gocyclo)

• go-ethercore/core/blockchain.go
  • Line 983: warning: cyclomatic complexity 55 of function (*BlockChain).InsertReceiptChain() is high (> 15) (gocyclo)
  • Line 1504: warning: cyclomatic complexity 47 of function (*BlockChain).insertChain() is high (> 15) (gocyclo)
  • Line 1898: warning: cyclomatic complexity 33 of function (*BlockChain).reorg() is high (> 15) (gocyclo)
  • Line 1303: warning: cyclomatic complexity 29 of function (*BlockChain).writeBlockWithState() is high (> 15) (gocyclo)
  • Line 185: warning: cyclomatic complexity 21 of function NewBlockChain() is high (> 15) (gocyclo)
  • Line 1778: warning: cyclomatic complexity 21 of function (*BlockChain).insertSideChain() is high (> 15) (gocyclo)

• go-ethercore/les/api_test.go
  • Line 94: warning: cyclomatic complexity 48 of function testCapacityAPI() is high (> 15) (gocyclo)

• go-ethercore/les/distributor.go
  • Line 192: warning: cyclomatic complexity 18 of function (*requestDistributor).nextRequest() is high (> 15) (gocyclo)

• go-ethercore/eth/filters/filter_test.go
  • Line 98: warning: cyclomatic complexity 18 of function TestFilters() is high (> 15) (gocyclo)

• go-ethercore/accounts/keystore/account_cache.go
  • Line 233: warning: cyclomatic complexity 16 of function (*accountCache).scanAccounts() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/unpack_test.go
  • Line 738: warning: cyclomatic complexity 36 of function TestUnmarshal() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/type.go
  • Line 67: warning: cyclomatic complexity 29 of function NewType() is high (> 15) (gocyclo)
  • Line 236: warning: cyclomatic complexity 16 of function (Type).pack() is high (> 15) (gocyclo)

• go-ethercore/p2p/simulations/mocker_test.go
  • Line 33: warning: cyclomatic complexity 25 of function TestMocker() is high (> 15) (gocyclo)

• go-ethercore/trie/database.go
  • Line 585: warning: cyclomatic complexity 17 of function (*Database).Cap() is high (> 15) (gocyclo)

• go-ethercore/eth/filters/filter_system.go
  • Line 443: warning: cyclomatic complexity 16 of function (*EventSystem).eventLoop() is high (> 15) (gocyclo)

• go-ethercore/core/tx_pool.go
  • Line 1248: warning: cyclomatic complexity 21 of function (*TxPool).truncatePending() is high (> 15) (gocyclo)
  • Line 328: warning: cyclomatic complexity 17 of function (*TxPool).loop() is high (> 15) (gocyclo)
  • Line 582: warning: cyclomatic complexity 16 of function (*TxPool).add() is high (> 15) (gocyclo)

• go-ethercore/accounts/abi/reflect.go
  • Line 144: warning: cyclomatic complexity 17 of function mapArgNamesToStructFields() is high (> 15) (gocyclo)

• go-ethercore/p2p/simulations/http.go
  • Line 382: warning: cyclomatic complexity 18 of function (*Server).StreamNetworkEvents() is high (> 15) (gocyclo)

• go-ethercore/core/genesis.go
  • Line 158: warning: cyclomatic complexity 22 of function SetupGenesisBlockWithOverride() is high (> 15) (gocyclo)

• go-ethercore/miner/worker_test.go
  • Line 428: warning: cyclomatic complexity 16 of function testAdjustInterval() is high (> 15) (gocyclo)

• go-ethercore/p2p/message_test.go
  • Line 90: warning: cyclomatic complexity 19 of function TestEOFSignal() is high (> 15) (gocyclo)

• go-ethercore/cmd/puppeth/wizard_faucet.go
  • Line 29: warning: cyclomatic complexity 21 of function (*wizard).deployFaucet() is high (> 15) (gocyclo)

golint77%

Golint is a linter for Go source code.

• go-ethercore/consensus/ethash/consensus.go
  • Line 747: warning: comment on exported function GetBlockWinnerRewardByEra should be of the form "GetBlockWinnerRewardByEra ..." (golint)

• go-ethercore/eth/downloader/events.go
  • Line 21: warning: exported type DoneEvent should have comment or be unexported (golint)
  • Line 24: warning: exported type StartEvent should have comment or be unexported (golint)
  • Line 25: warning: exported type FailedEvent should have comment or be unexported (golint)

• go-ethercore/internal/jsre/pretty.go
  • Line 37: warning: exported var FunctionColor should have comment or be unexported (golint)

• go-ethercore/core/headerchain.go
  • Line 225: warning: exported method HeaderChain.ValidateHeaderChain should have comment or be unexported (golint)
  • Line 363: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 462: warning: exported method HeaderChain.GetCanonicalHash should have comment or be unexported (golint)

• go-ethercore/params/version.go
  • Line 24: warning: exported const VersionMajor should have comment (or a comment on this block) or be unexported (golint)
  • Line 59: warning: exported function VersionWithCommit should have comment or be unexported (golint)

• go-ethercore/tests/fuzzers/trie/trie-fuzzer.go
  • Line 75: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 86: warning: exported function Generate should have comment or be unexported (golint)
  • Line 125: warning: exported function Fuzz should have comment or be unexported (golint)

• go-ethercore/accounts/external/backend.go
  • Line 36: warning: exported type ExternalBackend should have comment or be unexported (golint)
  • Line 40: warning: exported method ExternalBackend.Wallets should have comment or be unexported (golint)
  • Line 44: warning: exported function NewExternalBackend should have comment or be unexported (golint)
  • Line 54: warning: exported method ExternalBackend.Subscribe should have comment or be unexported (golint)
  • Line 72: warning: exported function NewExternalSigner should have comment or be unexported (golint)
  • Line 90: warning: exported method ExternalSigner.URL should have comment or be unexported (golint)
  • Line 97: warning: exported method ExternalSigner.Status should have comment or be unexported (golint)
  • Line 101: warning: exported method ExternalSigner.Open should have comment or be unexported (golint)
  • Line 105: warning: exported method ExternalSigner.Close should have comment or be unexported (golint)
  • Line 109: warning: exported method ExternalSigner.Accounts should have comment or be unexported (golint)
  • Line 131: warning: exported method ExternalSigner.Contains should have comment or be unexported (golint)
  • Line 142: warning: exported method ExternalSigner.Derive should have comment or be unexported (golint)
  • Line 146: warning: exported method ExternalSigner.SelfDerive should have comment or be unexported (golint)
  • Line 171: warning: exported method ExternalSigner.SignText should have comment or be unexported (golint)
  • Line 183: warning: exported method ExternalSigner.SignTx should have comment or be unexported (golint)
  • Line 206: warning: exported method ExternalSigner.SignTextWithPassphrase should have comment or be unexported (golint)
  • Line 210: warning: exported method ExternalSigner.SignTxWithPassphrase should have comment or be unexported (golint)
  • Line 213: warning: exported method ExternalSigner.SignDataWithPassphrase should have comment or be unexported (golint)

• go-ethercore/accounts/accounts.go
  • Line 39: warning: exported const MimetypeDataWithValidator should have comment (or a comment on this block) or be unexported (golint)
  • Line 213: warning: comment on exported const WalletDropped should be of the form "WalletDropped ..." (golint)

• go-ethercore/p2p/enode/nodedb.go
  • Line 443: warning: comment on exported method DB.Close should be of the form "Close ..." (golint)

• go-ethercore/les/client.go
  • Line 49: warning: exported type LightEthereum should have comment or be unexported (golint)
  • Line 71: warning: exported function New should have comment or be unexported (golint)
  • Line 156: warning: exported type LightDummyAPI should have comment or be unexported (golint)
  • Line 213: warning: exported method LightEthereum.ResetWithGenesisBlock should have comment or be unexported (golint)
  • Line 217: warning: exported method LightEthereum.BlockChain should have comment or be unexported (golint)
  • Line 218: warning: exported method LightEthereum.TxPool should have comment or be unexported (golint)
  • Line 219: warning: exported method LightEthereum.Engine should have comment or be unexported (golint)
  • Line 220: warning: exported method LightEthereum.LesVersion should have comment or be unexported (golint)
  • Line 221: warning: exported method LightEthereum.Downloader should have comment or be unexported (golint)
  • Line 222: warning: exported method LightEthereum.EventMux should have comment or be unexported (golint)
  • Line 274: warning: comment on exported method LightEthereum.SetContractBackend should be of the form "SetContractBackend ..." (golint)

• go-ethercore/les/balance.go
  • Line 145: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/crypto/bn256/cloudflare/bn256.go
  • Line 54: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 63: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 72: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 81: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 90: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 99: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 124: warning: receiver name e should be consistent with previous receiver name g for G1 (golint)
  • Line 342: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 351: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 360: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 369: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 378: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 385: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 427: warning: receiver name e should be consistent with previous receiver name g for GT (golint)

• go-ethercore/signer/core/auditlog.go
  • Line 28: warning: exported type AuditLogger should have comment or be unexported (golint)
  • Line 33: warning: exported method AuditLogger.List should have comment or be unexported (golint)
  • Line 41: warning: exported method AuditLogger.New should have comment or be unexported (golint)
  • Line 45: warning: exported method AuditLogger.SignTransaction should have comment or be unexported (golint)
  • Line 63: warning: exported method AuditLogger.SignData should have comment or be unexported (golint)
  • Line 71: warning: exported method AuditLogger.SignTypedData should have comment or be unexported (golint)
  • Line 79: warning: exported method AuditLogger.EcRecover should have comment or be unexported (golint)
  • Line 87: warning: exported method AuditLogger.Version should have comment or be unexported (golint)
  • Line 95: warning: exported function NewAuditLogger should have comment or be unexported (golint)

• go-ethercore/consensus/ethash/ethash.go
  • Line 45: warning: exported var ErrInvalidDumpMagic should have comment or be unexported (golint)
  • Line 397: warning: exported const ModeNormal should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/log/format.go
  • Line 54: warning: exported type Format should have comment or be unexported (golint)

• go-ethercore/core/genesis.go
  • Line 69: warning: exported method GenesisAlloc.UnmarshalJSON should have comment or be unexported (golint)
  • Line 158: warning: exported function SetupGenesisBlockWithOverride should have comment or be unexported (golint)
  • Line 401: warning: comment on exported function DefaultEtherCorePoAGenesisBlock should be of the form "DefaultEtherCorePoAGenesisBlock ..." (golint)
  • Line 413: warning: comment on exported function DefaultEtherCoreTestGenesisBlock should be of the form "DefaultEtherCoreTestGenesisBlock ..." (golint)

• go-ethercore/tests/fuzzers/rlp/rlp_fuzzer.go
  • Line 39: warning: exported function Fuzz should have comment or be unexported (golint)

• go-ethercore/core/asm/asm.go
  • Line 17: warning: package comment should be of the form "Package asm ..." (golint)
  • Line 37: warning: comment on exported function NewInstructionIterator should be of the form "NewInstructionIterator ..." (golint)
  • Line 102: warning: comment on exported function PrintDisassembled should be of the form "PrintDisassembled ..." (golint)
  • Line 120: warning: comment on exported function Disassemble should be of the form "Disassemble ..." (golint)

• go-ethercore/ethclient/ethclient.go
  • Line 45: warning: exported function DialContext should have comment or be unexported (golint)
  • Line 58: warning: exported method Client.Close should have comment or be unexported (golint)
  • Line 64: warning: comment on exported method Client.ChainID should be of the form "ChainID ..." (golint)

• go-ethercore/eth/filters/filter_system.go
  • Line 55: warning: comment on exported const LastIndexSubscription should be of the form "LastIndexSubscription ..." (golint)

• go-ethercore/light/txpool.go
  • Line 449: warning: comment on exported method TxPool.AddBatch should be of the form "AddBatch ..." (golint)

• go-ethercore/signer/rules/rules.go
  • Line 34: warning: don't use underscores in Go names; var BigNumber_JS should be BigNumberJS (golint)
  • Line 34: warning: exported var BigNumber_JS should have comment or be unexported (golint)
  • Line 56: warning: exported function NewRuleEvaluator should have comment or be unexported (golint)

• go-ethercore/whisper/mailserver/mailserver.go
  • Line 42: warning: exported type DBKey should have comment or be unexported (golint)

• go-ethercore/trie/committer.go
  • Line 109: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 118: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 132: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• go-ethercore/common/prque/lazyqueue.go
  • Line 50: warning: exported type PriorityCallback should have comment or be unexported (golint)
  • Line 51: warning: exported type MaxPriorityCallback should have comment or be unexported (golint)

• go-ethercore/accounts/abi/argument.go
  • Line 34: warning: exported type Arguments should have comment or be unexported (golint)
  • Line 36: warning: exported type ArgumentMarshaling should have comment or be unexported (golint)
  • Line 95: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 118: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/eth/api_tracer.go
  • Line 404: warning: comment on exported method PrivateDebugAPI.TraceBadBlock should be of the form "TraceBadBlock ..." (golint)

• go-ethercore/eth/handler.go
  • Line 63: warning: exported type ProtocolManager should have comment or be unexported (golint)
  • Line 259: warning: exported method ProtocolManager.Start should have comment or be unexported (golint)
  • Line 276: warning: exported method ProtocolManager.Stop should have comment or be unexported (golint)

• go-ethercore/metrics/librato/librato.go
  • Line 24: warning: exported type Reporter should have comment or be unexported (golint)
  • Line 35: warning: exported function NewReporter should have comment or be unexported (golint)
  • Line 39: warning: exported function Librato should have comment or be unexported (golint)
  • Line 43: warning: exported method Reporter.Run should have comment or be unexported (golint)
  • Line 83: warning: exported method Reporter.BuildRequest should have comment or be unexported (golint)

• go-ethercore/cmd/utils/flags.go
  • Line 70: warning: exported var CommandHelpTemplate should have comment or be unexported (golint)
  • Line 140: warning: comment on exported var DataDirFlag should be of the form "DataDirFlag ..." (golint)
  • Line 146: warning: exported var AncientFlag should have comment or be unexported (golint)
  • Line 256: warning: comment on exported var LightLegacyServFlag should be of the form "LightLegacyServFlag ..." (golint)
  • Line 301: warning: comment on exported var EthashCacheDirFlag should be of the form "EthashCacheDirFlag ..." (golint)
  • Line 331: warning: comment on exported var TxPoolLocalsFlag should be of the form "TxPoolLocalsFlag ..." (golint)
  • Line 385: warning: comment on exported var CacheFlag should be of the form "CacheFlag ..." (golint)
  • Line 410: warning: comment on exported var MiningEnabledFlag should be of the form "MiningEnabledFlag ..." (golint)
  • Line 481: warning: comment on exported var UnlockedAccountFlag should be of the form "UnlockedAccountFlag ..." (golint)
  • Line 509: warning: comment on exported var EthStatsURLFlag should be of the form "EthStatsURLFlag ..." (golint)
  • Line 522: warning: comment on exported var IPCDisabledFlag should be of the form "IPCDisabledFlag ..." (golint)
  • Line 617: warning: comment on exported var MaxPeersFlag should be of the form "MaxPeersFlag ..." (golint)
  • Line 678: warning: comment on exported var JSpathFlag should be of the form "JSpathFlag ..." (golint)
  • Line 685: warning: comment on exported var GpoBlocksFlag should be of the form "GpoBlocksFlag ..." (golint)
  • Line 715: warning: comment on exported var MetricsEnabledFlag should be of the form "MetricsEnabledFlag ..." (golint)
  • Line 748: warning: comment on exported var MetricsInfluxDBTagsFlag should be of the form "MetricsInfluxDBTagsFlag ..." (golint)
  • Line 1129: warning: exported function SetP2PConfig should have comment or be unexported (golint)
  • Line 1678: warning: exported function SetupMetrics should have comment or be unexported (golint)
  • Line 1699: warning: exported function SplitTagsFlag should have comment or be unexported (golint)
  • Line 1733: warning: exported function MakeGenesis should have comment or be unexported (golint)

• go-ethercore/crypto/crypto.go
  • Line 151: warning: exported function FromECDSAPub should have comment or be unexported (golint)
  • Line 193: warning: exported function GenerateKey should have comment or be unexported (golint)
  • Line 212: warning: exported function PubkeyToAddress should have comment or be unexported (golint)

• go-ethercore/internal/debug/flags.go
  • Line 23: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 36: warning: exported var Memsize should have comment or be unexported (golint)
  • Line 145: warning: exported function StartPProf should have comment or be unexported (golint)

• go-ethercore/internal/build/util.go
  • Line 35: warning: exported var DryRunFlag should have comment or be unexported (golint)
  • Line 50: warning: exported function MustRunCommand should have comment or be unexported (golint)

• go-ethercore/eth/protocol.go
  • Line 77: warning: exported const ErrMsgTooLarge should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/p2p/discover/v4_udp.go
  • Line 70: warning: don't use underscores in Go names; const p_pingV4 should be pPingV4 (golint)
  • Line 71: warning: don't use underscores in Go names; const p_pongV4 should be pPongV4 (golint)
  • Line 72: warning: don't use underscores in Go names; const p_findnodeV4 should be pFindnodeV4 (golint)
  • Line 73: warning: don't use underscores in Go names; const p_neighborsV4 should be pNeighborsV4 (golint)
  • Line 74: warning: don't use underscores in Go names; const p_enrRequestV4 should be pEnrRequestV4 (golint)
  • Line 75: warning: don't use underscores in Go names; const p_enrResponseV4 should be pEnrResponseV4 (golint)
  • Line 260: warning: exported function ListenV4 should have comment or be unexported (golint)

• go-ethercore/core/tx_pool.go
  • Line 130: warning: exported const TxStatusUnknown should have comment (or a comment on this block) or be unexported (golint)
  • Line 765: warning: comment on exported method TxPool.AddRemotesSync should be of the form "AddRemotesSync ..." (golint)

• go-ethercore/rpc/testservice_test.go
  • Line 85: warning: error should be the last type when returning multiple items (golint)

• go-ethercore/core/asm/lexer.go
  • Line 56: warning: exported const Numbers should have comment (or a comment on this block) or be unexported (golint)
  • Line 96: warning: comment on exported function Lex should be of the form "Lex ..." (golint)

• go-ethercore/core/types/transaction.go
  • Line 35: warning: exported var ErrInvalidSig should have comment or be unexported (golint)
  • Line 38: warning: exported type Transaction should have comment or be unexported (golint)
  • Line 74: warning: exported function NewTransaction should have comment or be unexported (golint)
  • Line 78: warning: exported function NewContractCreation should have comment or be unexported (golint)
  • Line 175: warning: exported method Transaction.Data should have comment or be unexported (golint)
  • Line 176: warning: exported method Transaction.Gas should have comment or be unexported (golint)
  • Line 177: warning: exported method Transaction.GasPrice should have comment or be unexported (golint)
  • Line 178: warning: exported method Transaction.Value should have comment or be unexported (golint)
  • Line 179: warning: exported method Transaction.Nonce should have comment or be unexported (golint)
  • Line 180: warning: exported method Transaction.CheckNonce should have comment or be unexported (golint)
  • Line 311: warning: exported method TxByPrice.Push should have comment or be unexported (golint)
  • Line 315: warning: exported method TxByPrice.Pop should have comment or be unexported (golint)
  • Line 399: warning: exported function NewMessage should have comment or be unexported (golint)
  • Line 412: warning: exported method Message.From should have comment or be unexported (golint)
  • Line 413: warning: exported method Message.To should have comment or be unexported (golint)
  • Line 414: warning: exported method Message.GasPrice should have comment or be unexported (golint)
  • Line 415: warning: exported method Message.Value should have comment or be unexported (golint)
  • Line 416: warning: exported method Message.Gas should have comment or be unexported (golint)
  • Line 417: warning: exported method Message.Nonce should have comment or be unexported (golint)
  • Line 418: warning: exported method Message.Data should have comment or be unexported (golint)
  • Line 419: warning: exported method Message.CheckNonce should have comment or be unexported (golint)

• go-ethercore/rpc/types.go
  • Line 63: warning: exported type BlockNumber should have comment or be unexported (golint)
  • Line 66: warning: exported const PendingBlockNumber should have comment (or a comment on this block) or be unexported (golint)
  • Line 106: warning: exported method BlockNumber.Int64 should have comment or be unexported (golint)
  • Line 110: warning: exported type BlockNumberOrHash should have comment or be unexported (golint)
  • Line 116: warning: exported method BlockNumberOrHash.UnmarshalJSON should have comment or be unexported (golint)
  • Line 156: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 171: warning: exported method BlockNumberOrHash.Number should have comment or be unexported (golint)
  • Line 178: warning: exported method BlockNumberOrHash.Hash should have comment or be unexported (golint)
  • Line 185: warning: exported function BlockNumberOrHashWithNumber should have comment or be unexported (golint)
  • Line 193: warning: exported function BlockNumberOrHashWithHash should have comment or be unexported (golint)

• go-ethercore/mobile/ethereum.go
  • Line 50: warning: exported method CallMsg.GetFrom should have comment or be unexported (golint)
  • Line 51: warning: exported method CallMsg.GetGas should have comment or be unexported (golint)
  • Line 52: warning: exported method CallMsg.GetGasPrice should have comment or be unexported (golint)
  • Line 53: warning: exported method CallMsg.GetValue should have comment or be unexported (golint)
  • Line 54: warning: exported method CallMsg.GetData should have comment or be unexported (golint)
  • Line 55: warning: exported method CallMsg.GetTo should have comment or be unexported (golint)
  • Line 62: warning: exported method CallMsg.SetFrom should have comment or be unexported (golint)
  • Line 63: warning: exported method CallMsg.SetGas should have comment or be unexported (golint)
  • Line 64: warning: exported method CallMsg.SetGasPrice should have comment or be unexported (golint)
  • Line 65: warning: exported method CallMsg.SetValue should have comment or be unexported (golint)
  • Line 66: warning: exported method CallMsg.SetData should have comment or be unexported (golint)
  • Line 67: warning: exported method CallMsg.SetTo should have comment or be unexported (golint)
  • Line 81: warning: exported method SyncProgress.GetStartingBlock should have comment or be unexported (golint)
  • Line 82: warning: exported method SyncProgress.GetCurrentBlock should have comment or be unexported (golint)
  • Line 83: warning: exported method SyncProgress.GetHighestBlock should have comment or be unexported (golint)
  • Line 84: warning: exported method SyncProgress.GetPulledStates should have comment or be unexported (golint)
  • Line 85: warning: exported method SyncProgress.GetKnownStates should have comment or be unexported (golint)
  • Line 139: warning: exported method FilterQuery.GetFromBlock should have comment or be unexported (golint)
  • Line 140: warning: exported method FilterQuery.GetToBlock should have comment or be unexported (golint)
  • Line 141: warning: exported method FilterQuery.GetAddresses should have comment or be unexported (golint)
  • Line 142: warning: exported method FilterQuery.GetTopics should have comment or be unexported (golint)
  • Line 144: warning: exported method FilterQuery.SetFromBlock should have comment or be unexported (golint)
  • Line 145: warning: exported method FilterQuery.SetToBlock should have comment or be unexported (golint)
  • Line 146: warning: exported method FilterQuery.SetAddresses should have comment or be unexported (golint)
  • Line 147: warning: exported method FilterQuery.SetTopics should have comment or be unexported (golint)

• go-ethercore/mobile/vm.go
  • Line 33: warning: exported method Log.GetAddress should have comment or be unexported (golint)
  • Line 34: warning: exported method Log.GetTopics should have comment or be unexported (golint)
  • Line 35: warning: exported method Log.GetData should have comment or be unexported (golint)
  • Line 36: warning: exported method Log.GetBlockNumber should have comment or be unexported (golint)
  • Line 37: warning: exported method Log.GetTxHash should have comment or be unexported (golint)
  • Line 38: warning: exported method Log.GetTxIndex should have comment or be unexported (golint)
  • Line 39: warning: exported method Log.GetBlockHash should have comment or be unexported (golint)
  • Line 40: warning: exported method Log.GetIndex should have comment or be unexported (golint)

• go-ethercore/metrics/histogram.go
  • Line 3: warning: comment on exported type Histogram should be of the form "Histogram ..." (with optional leading article) (golint)

• go-ethercore/p2p/enode/idscheme.go
  • Line 31: warning: comment on exported var ValidSchemes should be of the form "ValidSchemes ..." (golint)
  • Line 36: warning: exported var ValidSchemesForTesting should have comment or be unexported (golint)
  • Line 41: warning: comment on exported type V4ID should be of the form "V4ID ..." (with optional leading article) (golint)
  • Line 64: warning: exported method V4ID.Verify should have comment or be unexported (golint)
  • Line 80: warning: exported method V4ID.NodeAddr should have comment or be unexported (golint)
  • Line 95: warning: exported method Secp256k1.ENRKey should have comment or be unexported (golint)
  • Line 143: warning: exported method NullID.Verify should have comment or be unexported (golint)
  • Line 147: warning: exported method NullID.NodeAddr should have comment or be unexported (golint)
  • Line 153: warning: exported function SignNull should have comment or be unexported (golint)

• go-ethercore/signer/core/uiapi.go
  • Line 34: warning: comment on exported type UIServerAPI should be of the form "UIServerAPI ..." (with optional leading article) (golint)
  • Line 51: warning: comment on exported method UIServerAPI.ListAccounts should be of the form "ListAccounts ..." (golint)
  • Line 186: warning: receiver name api should be consistent with previous receiver name s for UIServerAPI (golint)

• go-ethercore/les/odr_requests.go
  • Line 48: warning: exported type LesOdrRequest should have comment or be unexported (golint)
  • Line 55: warning: exported function LesRequest should have comment or be unexported (golint)
  • Line 96: warning: comment on exported method BlockRequest.Validate should be of the form "Validate ..." (golint)
  • Line 152: warning: comment on exported method ReceiptsRequest.Validate should be of the form "Validate ..." (golint)
  • Line 183: warning: exported type ProofReq should have comment or be unexported (golint)
  • Line 189: warning: comment on exported type TrieRequest should be of the form "TrieRequest ..." (with optional leading article) (golint)
  • Line 214: warning: comment on exported method TrieRequest.Validate should be of the form "Validate ..." (golint)
  • Line 238: warning: exported type CodeReq should have comment or be unexported (golint)
  • Line 243: warning: comment on exported type CodeRequest should be of the form "CodeRequest ..." (with optional leading article) (golint)
  • Line 267: warning: comment on exported method CodeRequest.Validate should be of the form "Validate ..." (golint)
  • Line 302: warning: exported type HelperTrieReq should have comment or be unexported (golint)
  • Line 309: warning: exported type HelperTrieResps should have comment or be unexported (golint)
  • Line 314: warning: comment on exported type ChtRequest should be of the form "ChtRequest ..." (with optional leading article) (golint)
  • Line 330: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 349: warning: comment on exported method ChtRequest.Validate should be of the form "Validate ..." (golint)
  • Line 407: warning: exported type BloomReq should have comment or be unexported (golint)
  • Line 411: warning: comment on exported type BloomRequest should be of the form "BloomRequest ..." (with optional leading article) (golint)
  • Line 450: warning: comment on exported method BloomRequest.Validate should be of the form "Validate ..." (golint)
  • Line 507: warning: comment on exported method TxStatusRequest.Validate should be of the form "Validate ..." (golint)

• go-ethercore/eth/downloader/downloader.go
  • Line 41: warning: exported var MaxHashFetch should have comment or be unexported (golint)
  • Line 95: warning: exported type Downloader should have comment or be unexported (golint)

• go-ethercore/eth/api_backend.go
  • Line 53: warning: exported method EthAPIBackend.CurrentBlock should have comment or be unexported (golint)
  • Line 57: warning: exported method EthAPIBackend.SetHead should have comment or be unexported (golint)
  • Line 62: warning: exported method EthAPIBackend.HeaderByNumber should have comment or be unexported (golint)
  • Line 75: warning: exported method EthAPIBackend.HeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 92: warning: exported method EthAPIBackend.HeaderByHash should have comment or be unexported (golint)
  • Line 96: warning: exported method EthAPIBackend.BlockByNumber should have comment or be unexported (golint)
  • Line 109: warning: exported method EthAPIBackend.BlockByHash should have comment or be unexported (golint)
  • Line 113: warning: exported method EthAPIBackend.BlockByNumberOrHash should have comment or be unexported (golint)
  • Line 134: warning: exported method EthAPIBackend.StateAndHeaderByNumber should have comment or be unexported (golint)
  • Line 152: warning: exported method EthAPIBackend.StateAndHeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 173: warning: exported method EthAPIBackend.GetReceipts should have comment or be unexported (golint)
  • Line 177: warning: exported method EthAPIBackend.GetLogs should have comment or be unexported (golint)
  • Line 189: warning: exported method EthAPIBackend.GetTd should have comment or be unexported (golint)
  • Line 193: warning: exported method EthAPIBackend.GetEVM should have comment or be unexported (golint)
  • Line 201: warning: exported method EthAPIBackend.SubscribeRemovedLogsEvent should have comment or be unexported (golint)
  • Line 205: warning: exported method EthAPIBackend.SubscribePendingLogsEvent should have comment or be unexported (golint)
  • Line 209: warning: exported method EthAPIBackend.SubscribeChainEvent should have comment or be unexported (golint)
  • Line 213: warning: exported method EthAPIBackend.SubscribeChainHeadEvent should have comment or be unexported (golint)
  • Line 217: warning: exported method EthAPIBackend.SubscribeChainSideEvent should have comment or be unexported (golint)
  • Line 221: warning: exported method EthAPIBackend.SubscribeLogsEvent should have comment or be unexported (golint)
  • Line 225: warning: exported method EthAPIBackend.SendTx should have comment or be unexported (golint)
  • Line 229: warning: exported method EthAPIBackend.GetPoolTransactions should have comment or be unexported (golint)
  • Line 241: warning: exported method EthAPIBackend.GetPoolTransaction should have comment or be unexported (golint)
  • Line 245: warning: exported method EthAPIBackend.GetTransaction should have comment or be unexported (golint)
  • Line 250: warning: exported method EthAPIBackend.GetPoolNonce should have comment or be unexported (golint)
  • Line 254: warning: exported method EthAPIBackend.Stats should have comment or be unexported (golint)
  • Line 258: warning: exported method EthAPIBackend.TxPoolContent should have comment or be unexported (golint)
  • Line 262: warning: exported method EthAPIBackend.SubscribeNewTxsEvent should have comment or be unexported (golint)
  • Line 266: warning: exported method EthAPIBackend.Downloader should have comment or be unexported (golint)
  • Line 270: warning: exported method EthAPIBackend.ProtocolVersion should have comment or be unexported (golint)
  • Line 274: warning: exported method EthAPIBackend.SuggestPrice should have comment or be unexported (golint)
  • Line 278: warning: exported method EthAPIBackend.ChainDb should have comment or be unexported (golint)
  • Line 282: warning: exported method EthAPIBackend.EventMux should have comment or be unexported (golint)
  • Line 286: warning: exported method EthAPIBackend.AccountManager should have comment or be unexported (golint)
  • Line 290: warning: exported method EthAPIBackend.ExtRPCEnabled should have comment or be unexported (golint)
  • Line 294: warning: exported method EthAPIBackend.RPCGasCap should have comment or be unexported (golint)
  • Line 298: warning: exported method EthAPIBackend.BloomStatus should have comment or be unexported (golint)
  • Line 303: warning: exported method EthAPIBackend.ServiceFilter should have comment or be unexported (golint)

• go-ethercore/tests/block_test_util.go
  • Line 97: warning: exported method BlockTest.Run should have comment or be unexported (golint)

• go-ethercore/core/asm/compiler.go
  • Line 42: warning: comment on exported function NewCompiler should be of the form "NewCompiler ..." (golint)

• go-ethercore/eth/filters/filter.go
  • Line 33: warning: exported type Backend should have comment or be unexported (golint)

• go-ethercore/log/root.go
  • Line 9: warning: exported var StdoutHandler should have comment or be unexported (golint)

• go-ethercore/tests/fuzzers/keystore/keystore-fuzzer.go
  • Line 25: warning: exported function Fuzz should have comment or be unexported (golint)

• go-ethercore/metrics/runtime.go
  • Line 55: warning: comment on exported function CaptureRuntimeMemStats should be of the form "CaptureRuntimeMemStats ..." (golint)
  • Line 63: warning: comment on exported function CaptureRuntimeMemStatsOnce should be of the form "CaptureRuntimeMemStatsOnce ..." (golint)
  • Line 145: warning: comment on exported function RegisterRuntimeMemStats should be of the form "RegisterRuntimeMemStats ..." (golint)

• go-ethercore/rlp/encode.go
  • Line 28: warning: comment on exported var EmptyString should be of the form "EmptyString ..." (golint)
  • Line 31: warning: exported var EmptyList should have comment or be unexported (golint)

• go-ethercore/les/api.go
  • Line 190: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 332: warning: comment on exported method PrivateLightAPI.GetCheckpoint should be of the form "GetCheckpoint ..." (golint)

• go-ethercore/core/types/transaction_signing.go
  • Line 31: warning: exported var ErrInvalidChainId should have comment or be unexported (golint)
  • Line 105: warning: comment on exported type EIP155Signer should be of the form "EIP155Signer ..." (with optional leading article) (golint)
  • Line 110: warning: exported function NewEIP155Signer should have comment or be unexported (golint)
  • Line 120: warning: exported method EIP155Signer.Equal should have comment or be unexported (golint)
  • Line 127: warning: exported method EIP155Signer.Sender should have comment or be unexported (golint)
  • Line 167: warning: comment on exported type HomesteadSigner should be of the form "HomesteadSigner ..." (with optional leading article) (golint)
  • Line 171: warning: exported method HomesteadSigner.Equal should have comment or be unexported (golint)
  • Line 178: warning: receiver name hs should be consistent with previous receiver name s for HomesteadSigner (golint)
  • Line 182: warning: exported method HomesteadSigner.Sender should have comment or be unexported (golint)
  • Line 182: warning: receiver name hs should be consistent with previous receiver name s for HomesteadSigner (golint)
  • Line 186: warning: exported type FrontierSigner should have comment or be unexported (golint)
  • Line 188: warning: exported method FrontierSigner.Equal should have comment or be unexported (golint)
  • Line 195: warning: receiver name fs should be consistent with previous receiver name s for FrontierSigner (golint)
  • Line 207: warning: receiver name fs should be consistent with previous receiver name s for FrontierSigner (golint)
  • Line 218: warning: exported method FrontierSigner.Sender should have comment or be unexported (golint)
  • Line 218: warning: receiver name fs should be consistent with previous receiver name s for FrontierSigner (golint)

• go-ethercore/consensus/ethash/api.go
  • Line 86: warning: comment on exported method API.SubmitHashRate should be of the form "SubmitHashRate ..." (golint)

• go-ethercore/crypto/bn256/google/constants.go
  • Line 19: warning: comment on exported var P should be of the form "P ..." (golint)

• go-ethercore/metrics/librato/client.go
  • Line 11: warning: exported const Operations should have comment or be unexported (golint)
  • Line 12: warning: exported const OperationsShort should have comment or be unexported (golint)
  • Line 14: warning: exported type LibratoClient should have comment or be unexported (golint)
  • Line 58: warning: exported type Measurement should have comment or be unexported (golint)
  • Line 59: warning: exported type Metric should have comment or be unexported (golint)
  • Line 61: warning: exported type Batch should have comment or be unexported (golint)
  • Line 68: warning: exported method LibratoClient.PostMetrics should have comment or be unexported (golint)

• go-ethercore/mobile/p2p.go
  • Line 32: warning: exported method NodeInfo.GetID should have comment or be unexported (golint)
  • Line 33: warning: exported method NodeInfo.GetName should have comment or be unexported (golint)
  • Line 34: warning: exported method NodeInfo.GetEnode should have comment or be unexported (golint)
  • Line 35: warning: exported method NodeInfo.GetIP should have comment or be unexported (golint)
  • Line 36: warning: exported method NodeInfo.GetDiscoveryPort should have comment or be unexported (golint)
  • Line 37: warning: exported method NodeInfo.GetListenerPort should have comment or be unexported (golint)
  • Line 38: warning: exported method NodeInfo.GetListenerAddress should have comment or be unexported (golint)
  • Line 39: warning: exported method NodeInfo.GetProtocols should have comment or be unexported (golint)
  • Line 52: warning: exported method PeerInfo.GetID should have comment or be unexported (golint)
  • Line 53: warning: exported method PeerInfo.GetName should have comment or be unexported (golint)
  • Line 54: warning: exported method PeerInfo.GetCaps should have comment or be unexported (golint)
  • Line 55: warning: exported method PeerInfo.GetLocalAddress should have comment or be unexported (golint)
  • Line 56: warning: exported method PeerInfo.GetRemoteAddress should have comment or be unexported (golint)

• go-ethercore/p2p/peer.go
  • Line 38: warning: exported var ErrShuttingDown should have comment or be unexported (golint)
  • Line 196: warning: exported method Peer.Log should have comment or be unexported (golint)

• go-ethercore/p2p/discv5/net.go
  • Line 275: warning: exported method Network.RegisterTopic should have comment or be unexported (golint)
  • Line 291: warning: exported method Network.SearchTopic should have comment or be unexported (golint)

• go-ethercore/p2p/discv5/node.go
  • Line 254: warning: comment on exported method NodeID.GoString should be of the form "GoString ..." (golint)

• go-ethercore/cmd/geth/retesteth.go
  • Line 70: warning: exported type RetestethTestAPI should have comment or be unexported (golint)
  • Line 79: warning: exported type RetestethEthAPI should have comment or be unexported (golint)
  • Line 89: warning: exported type RetestethDebugAPI should have comment or be unexported (golint)
  • Line 101: warning: exported type RetestWeb3API should have comment or be unexported (golint)
  • Line 105: warning: exported type RetestethAPI should have comment or be unexported (golint)
  • Line 119: warning: exported type ChainParams should have comment or be unexported (golint)
  • Line 126: warning: exported type CParamsParams should have comment or be unexported (golint)
  • Line 149: warning: exported type CParamsGenesis should have comment or be unexported (golint)
  • Line 160: warning: exported type CParamsAccount should have comment or be unexported (golint)
  • Line 168: warning: exported type CPAccountPrecompiled should have comment or be unexported (golint)
  • Line 174: warning: exported type CPAPrecompiledLinear should have comment or be unexported (golint)
  • Line 179: warning: exported type AccountRangeResult should have comment or be unexported (golint)
  • Line 184: warning: exported type StorageRangeResult should have comment or be unexported (golint)
  • Line 189: warning: exported type SRItem should have comment or be unexported (golint)
  • Line 194: warning: exported type NoRewardEngine should have comment or be unexported (golint)
  • Line 199: warning: exported method NoRewardEngine.Author should have comment or be unexported (golint)
  • Line 203: warning: exported method NoRewardEngine.VerifyHeader should have comment or be unexported (golint)
  • Line 207: warning: exported method NoRewardEngine.VerifyHeaders should have comment or be unexported (golint)
  • Line 211: warning: exported method NoRewardEngine.VerifyUncles should have comment or be unexported (golint)
  • Line 215: warning: exported method NoRewardEngine.VerifySeal should have comment or be unexported (golint)
  • Line 219: warning: exported method NoRewardEngine.Prepare should have comment or be unexported (golint)
  • Line 232: warning: exported method NoRewardEngine.Finalize should have comment or be unexported (golint)
  • Line 242: warning: exported method NoRewardEngine.FinalizeAndAssemble should have comment or be unexported (golint)
  • Line 246: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 255: warning: exported method NoRewardEngine.Seal should have comment or be unexported (golint)
  • Line 259: warning: exported method NoRewardEngine.SealHash should have comment or be unexported (golint)
  • Line 263: warning: exported method NoRewardEngine.CalcDifficulty should have comment or be unexported (golint)
  • Line 267: warning: exported method NoRewardEngine.APIs should have comment or be unexported (golint)
  • Line 271: warning: exported method NoRewardEngine.Close should have comment or be unexported (golint)
  • Line 275: warning: exported method RetestethAPI.SetChainParams should have comment or be unexported (golint)
  • Line 420: warning: exported method RetestethAPI.SendRawTransaction should have comment or be unexported (golint)
  • Line 442: warning: exported method RetestethAPI.MineBlocks should have comment or be unexported (golint)
  • Line 562: warning: exported method RetestethAPI.ModifyTimestamp should have comment or be unexported (golint)
  • Line 567: warning: exported method RetestethAPI.ImportRawBlock should have comment or be unexported (golint)
  • Line 579: warning: exported method RetestethAPI.RewindToBlock should have comment or be unexported (golint)
  • Line 591: warning: exported method RetestethAPI.GetLogHash should have comment or be unexported (golint)
  • Line 595: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 598: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 604: warning: exported method RetestethAPI.BlockNumber should have comment or be unexported (golint)
  • Line 608: warning: exported method RetestethAPI.GetBlockByNumber should have comment or be unexported (golint)
  • Line 622: warning: exported method RetestethAPI.GetBlockByHash should have comment or be unexported (golint)
  • Line 636: warning: exported method RetestethAPI.AccountRange should have comment or be unexported (golint)
  • Line 715: warning: exported method RetestethAPI.GetBalance should have comment or be unexported (golint)
  • Line 725: warning: exported method RetestethAPI.GetCode should have comment or be unexported (golint)
  • Line 734: warning: exported method RetestethAPI.GetTransactionCount should have comment or be unexported (golint)
  • Line 743: warning: exported method RetestethAPI.StorageRangeAt should have comment or be unexported (golint)
  • Line 837: warning: exported method RetestethAPI.ClientVersion should have comment or be unexported (golint)

• go-ethercore/crypto/secp256k1/secp256.go
  • Line 43: warning: exported var ErrInvalidMsgLen should have comment or be unexported (golint)

• go-ethercore/tests/vm_test_util.go
  • Line 42: warning: exported method VMTest.UnmarshalJSON should have comment or be unexported (golint)
  • Line 81: warning: exported method VMTest.Run should have comment or be unexported (golint)

• go-ethercore/core/types/bloom9.go
  • Line 71: warning: exported method Bloom.Bytes should have comment or be unexported (golint)
  • Line 75: warning: exported method Bloom.Test should have comment or be unexported (golint)
  • Line 79: warning: exported method Bloom.TestBytes should have comment or be unexported (golint)
  • Line 94: warning: exported function CreateBloom should have comment or be unexported (golint)
  • Line 103: warning: exported function LogsBloom should have comment or be unexported (golint)
  • Line 129: warning: exported var Bloom9 should have comment or be unexported (golint)
  • Line 131: warning: exported function BloomLookup should have comment or be unexported (golint)

• go-ethercore/metrics/metrics.go
  • Line 1: warning: package comment should be of the form "Package metrics ..." (golint)

• go-ethercore/rlp/encode_test.go
  • Line 40: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/rpc/client.go
  • Line 35: warning: exported var ErrClientQuit should have comment or be unexported (golint)
  • Line 188: warning: comment on exported function ClientFromContext should be of the form "ClientFromContext ..." (golint)
  • Line 322: warning: comment on exported method Client.BatchCallContext should be of the form "BatchCallContext ..." (golint)
  • Line 394: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/accounts/abi/bind/backend.go
  • Line 35: warning: comment on exported var ErrNoPendingState should be of the form "ErrNoPendingState ..." (golint)
  • Line 39: warning: comment on exported var ErrNoCodeAfterDeploy should be of the form "ErrNoCodeAfterDeploy ..." (golint)

• go-ethercore/cmd/evm/main.go
  • Line 35: warning: exported var DebugFlag should have comment or be unexported (golint)

• go-ethercore/rlp/decode.go
  • Line 36: warning: error var EOL should have name of the form ErrFoo (golint)
  • Line 39: warning: exported var ErrExpectedString should have comment or be unexported (golint)
  • Line 510: warning: exported const Byte should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/les/server.go
  • Line 39: warning: exported type LesServer should have comment or be unexported (golint)
  • Line 59: warning: exported function NewLesServer should have comment or be unexported (golint)
  • Line 130: warning: exported method LesServer.APIs should have comment or be unexported (golint)
  • Line 153: warning: exported method LesServer.Protocols should have comment or be unexported (golint)
  • Line 211: warning: exported method LesServer.SetBloomBitsIndexer should have comment or be unexported (golint)
  • Line 215: warning: comment on exported method LesServer.SetContractBackend should be of the form "SetContractBackend ..." (golint)

• go-ethercore/miner/miner.go
  • Line 69: warning: exported function New should have comment or be unexported (golint)
  • Line 122: warning: exported method Miner.Start should have comment or be unexported (golint)
  • Line 133: warning: exported method Miner.Stop should have comment or be unexported (golint)
  • Line 138: warning: exported method Miner.Close should have comment or be unexported (golint)
  • Line 143: warning: exported method Miner.Mining should have comment or be unexported (golint)
  • Line 147: warning: exported method Miner.HashRate should have comment or be unexported (golint)
  • Line 154: warning: exported method Miner.SetExtra should have comment or be unexported (golint)
  • Line 181: warning: exported method Miner.SetEtherbase should have comment or be unexported (golint)
  • Line 188: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• go-ethercore/signer/core/api.go
  • Line 128: warning: exported function StartClefAccountManager should have comment or be unexported (golint)
  • Line 218: warning: comment on exported type ListRequest should be of the form "ListRequest ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type ListResponse should be of the form "ListResponse ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type Message should be of the form "Message ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type NewAccountRequest should be of the form "NewAccountRequest ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type NewAccountResponse should be of the form "NewAccountResponse ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type SignDataRequest should be of the form "SignDataRequest ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type SignDataResponse should be of the form "SignDataResponse ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type StartupInfo should be of the form "StartupInfo ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type UserInputRequest should be of the form "UserInputRequest ..." (with optional leading article) (golint)
  • Line 218: warning: comment on exported type UserInputResponse should be of the form "UserInputResponse ..." (with optional leading article) (golint)
  • Line 272: warning: exported var ErrRequestDenied should have comment or be unexported (golint)
  • Line 567: warning: comment on exported method SignerAPI.Version should be of the form "Version ..." (golint)

• go-ethercore/p2p/enr/entries.go
  • Line 61: warning: exported method TCP.ENRKey should have comment or be unexported (golint)
  • Line 63: warning: comment on exported type TCP6 should be of the form "TCP6 ..." (with optional leading article) (golint)
  • Line 66: warning: exported method TCP6.ENRKey should have comment or be unexported (golint)
  • Line 71: warning: exported method UDP.ENRKey should have comment or be unexported (golint)
  • Line 73: warning: comment on exported type UDP6 should be of the form "UDP6 ..." (with optional leading article) (golint)
  • Line 76: warning: exported method UDP6.ENRKey should have comment or be unexported (golint)
  • Line 81: warning: exported const IDv4 should have comment or be unexported (golint)
  • Line 83: warning: exported method ID.ENRKey should have comment or be unexported (golint)
  • Line 90: warning: exported method IP.ENRKey should have comment or be unexported (golint)
  • Line 122: warning: exported method IPv4.ENRKey should have comment or be unexported (golint)
  • Line 147: warning: exported method IPv6.ENRKey should have comment or be unexported (golint)

• go-ethercore/core/events.go
  • Line 33: warning: exported type ChainEvent should have comment or be unexported (golint)
  • Line 39: warning: exported type ChainSideEvent should have comment or be unexported (golint)
  • Line 43: warning: exported type ChainHeadEvent should have comment or be unexported (golint)

• go-ethercore/p2p/enode/node.go
  • Line 125: warning: comment on exported method Node.TCP should be of the form "TCP ..." (golint)
  • Line 203: warning: comment on exported method ID.GoString should be of the form "GoString ..." (golint)

• go-ethercore/p2p/simulations/connect.go
  • Line 27: warning: exported var ErrNodeNotFound should have comment or be unexported (golint)

• go-ethercore/rpc/constants_unix.go
  • Line 32: warning: don't use underscores in Go names; var max_path_size should be maxPathSize (golint)

• go-ethercore/eth/gasprice/gasprice.go
  • Line 34: warning: exported type Config should have comment or be unexported (golint)

• go-ethercore/light/odr_util.go
  • Line 33: warning: exported function GetHeaderByNumber should have comment or be unexported (golint)
  • Line 82: warning: exported function GetCanonicalHash should have comment or be unexported (golint)
  • Line 102: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 258: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 271: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 280: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• go-ethercore/p2p/discv5/topic.go
  • Line 37: warning: exported type Topic should have comment or be unexported (golint)

• go-ethercore/p2p/discv5/udp.go
  • Line 34: warning: exported const Version should have comment or be unexported (golint)

• go-ethercore/graphql/graphql.go
  • Line 55: warning: exported method Account.Address should have comment or be unexported (golint)
  • Line 59: warning: exported method Account.Balance should have comment or be unexported (golint)
  • Line 67: warning: exported method Account.TransactionCount should have comment or be unexported (golint)
  • Line 75: warning: exported method Account.Code should have comment or be unexported (golint)
  • Line 83: warning: exported method Account.Storage should have comment or be unexported (golint)
  • Line 98: warning: exported method Log.Transaction should have comment or be unexported (golint)
  • Line 102: warning: exported method Log.Account should have comment or be unexported (golint)
  • Line 110: warning: exported method Log.Index should have comment or be unexported (golint)
  • Line 114: warning: exported method Log.Topics should have comment or be unexported (golint)
  • Line 118: warning: exported method Log.Data should have comment or be unexported (golint)
  • Line 151: warning: exported method Transaction.Hash should have comment or be unexported (golint)
  • Line 155: warning: exported method Transaction.InputData should have comment or be unexported (golint)
  • Line 163: warning: exported method Transaction.Gas should have comment or be unexported (golint)
  • Line 171: warning: exported method Transaction.GasPrice should have comment or be unexported (golint)
  • Line 179: warning: exported method Transaction.Value should have comment or be unexported (golint)
  • Line 187: warning: exported method Transaction.Nonce should have comment or be unexported (golint)
  • Line 195: warning: exported method Transaction.To should have comment or be unexported (golint)
  • Line 211: warning: exported method Transaction.From should have comment or be unexported (golint)
  • Line 229: warning: exported method Transaction.Block should have comment or be unexported (golint)
  • Line 236: warning: exported method Transaction.Index should have comment or be unexported (golint)
  • Line 262: warning: exported method Transaction.Status should have comment or be unexported (golint)
  • Line 271: warning: exported method Transaction.GasUsed should have comment or be unexported (golint)
  • Line 280: warning: exported method Transaction.CumulativeGasUsed should have comment or be unexported (golint)
  • Line 289: warning: exported method Transaction.CreatedContract should have comment or be unexported (golint)
  • Line 301: warning: exported method Transaction.Logs should have comment or be unexported (golint)
  • Line 317: warning: exported method Transaction.R should have comment or be unexported (golint)
  • Line 326: warning: exported method Transaction.S should have comment or be unexported (golint)
  • Line 335: warning: exported method Transaction.V should have comment or be unexported (golint)
  • Line 344: warning: exported type BlockType should have comment or be unexported (golint)
  • Line 418: warning: exported method Block.Number should have comment or be unexported (golint)
  • Line 427: warning: exported method Block.Hash should have comment or be unexported (golint)
  • Line 438: warning: exported method Block.GasLimit should have comment or be unexported (golint)
  • Line 446: warning: exported method Block.GasUsed should have comment or be unexported (golint)
  • Line 454: warning: exported method Block.Parent should have comment or be unexported (golint)
  • Line 472: warning: exported method Block.Difficulty should have comment or be unexported (golint)
  • Line 480: warning: exported method Block.Timestamp should have comment or be unexported (golint)
  • Line 488: warning: exported method Block.Nonce should have comment or be unexported (golint)
  • Line 496: warning: exported method Block.MixHash should have comment or be unexported (golint)
  • Line 504: warning: exported method Block.TransactionsRoot should have comment or be unexported (golint)
  • Line 512: warning: exported method Block.StateRoot should have comment or be unexported (golint)
  • Line 520: warning: exported method Block.ReceiptsRoot should have comment or be unexported (golint)
  • Line 528: warning: exported method Block.OmmerHash should have comment or be unexported (golint)
  • Line 536: warning: exported method Block.OmmerCount should have comment or be unexported (golint)
  • Line 545: warning: exported method Block.Ommers should have comment or be unexported (golint)
  • Line 562: warning: exported method Block.ExtraData should have comment or be unexported (golint)
  • Line 570: warning: exported method Block.LogsBloom should have comment or be unexported (golint)
  • Line 578: warning: exported method Block.TotalDifficulty should have comment or be unexported (golint)
  • Line 614: warning: exported method Block.Miner should have comment or be unexported (golint)
  • Line 626: warning: exported method Block.TransactionCount should have comment or be unexported (golint)
  • Line 635: warning: exported method Block.Transactions should have comment or be unexported (golint)
  • Line 653: warning: exported method Block.TransactionAt should have comment or be unexported (golint)
  • Line 672: warning: exported method Block.OmmerAt should have comment or be unexported (golint)
  • Line 727: warning: exported method Block.Logs should have comment or be unexported (golint)
  • Line 751: warning: exported method Block.Account should have comment or be unexported (golint)
  • Line 785: warning: exported method CallResult.Data should have comment or be unexported (golint)
  • Line 789: warning: exported method CallResult.GasUsed should have comment or be unexported (golint)
  • Line 793: warning: exported method CallResult.Status should have comment or be unexported (golint)
  • Line 797: warning: exported method Block.Call should have comment or be unexported (golint)
  • Line 818: warning: exported method Block.EstimateGas should have comment or be unexported (golint)
  • Line 831: warning: exported type Pending should have comment or be unexported (golint)
  • Line 835: warning: exported method Pending.TransactionCount should have comment or be unexported (golint)
  • Line 840: warning: exported method Pending.Transactions should have comment or be unexported (golint)
  • Line 857: warning: exported method Pending.Account should have comment or be unexported (golint)
  • Line 868: warning: exported method Pending.Call should have comment or be unexported (golint)
  • Line 884: warning: exported method Pending.EstimateGas should have comment or be unexported (golint)
  • Line 896: warning: exported method Resolver.Block should have comment or be unexported (golint)
  • Line 933: warning: exported method Resolver.Blocks should have comment or be unexported (golint)
  • Line 959: warning: exported method Resolver.Pending should have comment or be unexported (golint)
  • Line 963: warning: exported method Resolver.Transaction should have comment or be unexported (golint)
  • Line 978: warning: exported method Resolver.SendRawTransaction should have comment or be unexported (golint)
  • Line 1007: warning: exported method Resolver.Logs should have comment or be unexported (golint)
  • Line 1030: warning: exported method Resolver.GasPrice should have comment or be unexported (golint)
  • Line 1035: warning: exported method Resolver.ProtocolVersion should have comment or be unexported (golint)
  • Line 1044: warning: exported method SyncState.StartingBlock should have comment or be unexported (golint)
  • Line 1048: warning: exported method SyncState.CurrentBlock should have comment or be unexported (golint)
  • Line 1052: warning: exported method SyncState.HighestBlock should have comment or be unexported (golint)
  • Line 1056: warning: exported method SyncState.PulledStates should have comment or be unexported (golint)
  • Line 1061: warning: exported method SyncState.KnownStates should have comment or be unexported (golint)

• go-ethercore/signer/core/signed_data.go
  • Line 44: warning: exported type SigFormat should have comment or be unexported (golint)
  • Line 50: warning: exported var IntendedValidator should have comment or be unexported (golint)
  • Line 68: warning: exported type ValidatorData should have comment or be unexported (golint)
  • Line 73: warning: exported type TypedData should have comment or be unexported (golint)
  • Line 80: warning: exported type Type should have comment or be unexported (golint)
  • Line 106: warning: exported type Types should have comment or be unexported (golint)
  • Line 108: warning: exported type TypePriority should have comment or be unexported (golint)
  • Line 113: warning: exported type TypedDataMessage should have comment or be unexported (golint)
  • Line 115: warning: exported type TypedDataDomain should have comment or be unexported (golint)
  • Line 268: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 271: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 289: warning: comment on exported function SignTextValidator should be of the form "SignTextValidator ..." (golint)
  • Line 581: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 771: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 777: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 790: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• go-ethercore/light/trie.go
  • Line 32: warning: exported function NewState should have comment or be unexported (golint)
  • Line 37: warning: exported function NewStateDatabase should have comment or be unexported (golint)

• go-ethercore/mobile/bind.go
  • Line 40: warning: exported type MobileSigner should have comment or be unexported (golint)
  • Line 44: warning: exported method MobileSigner.Sign should have comment or be unexported (golint)
  • Line 62: warning: exported method CallOpts.IsPending should have comment or be unexported (golint)
  • Line 63: warning: exported method CallOpts.GetGasLimit should have comment or be unexported (golint)
  • Line 69: warning: exported method CallOpts.SetPending should have comment or be unexported (golint)
  • Line 70: warning: exported method CallOpts.SetGasLimit should have comment or be unexported (golint)
  • Line 71: warning: exported method CallOpts.SetContext should have comment or be unexported (golint)
  • Line 84: warning: comment on exported function NewKeyedTransactOpts should be of the form "NewKeyedTransactOpts ..." (golint)
  • Line 108: warning: exported method TransactOpts.GetFrom should have comment or be unexported (golint)
  • Line 109: warning: exported method TransactOpts.GetNonce should have comment or be unexported (golint)
  • Line 110: warning: exported method TransactOpts.GetValue should have comment or be unexported (golint)
  • Line 111: warning: exported method TransactOpts.GetGasPrice should have comment or be unexported (golint)
  • Line 112: warning: exported method TransactOpts.GetGasLimit should have comment or be unexported (golint)
  • Line 121: warning: exported method TransactOpts.SetFrom should have comment or be unexported (golint)
  • Line 122: warning: exported method TransactOpts.SetNonce should have comment or be unexported (golint)
  • Line 123: warning: exported method TransactOpts.SetSigner should have comment or be unexported (golint)
  • Line 132: warning: exported method TransactOpts.SetValue should have comment or be unexported (golint)
  • Line 133: warning: exported method TransactOpts.SetGasPrice should have comment or be unexported (golint)
  • Line 134: warning: exported method TransactOpts.SetGasLimit should have comment or be unexported (golint)
  • Line 135: warning: exported method TransactOpts.SetContext should have comment or be unexported (golint)
  • Line 178: warning: exported method BoundContract.GetAddress should have comment or be unexported (golint)
  • Line 179: warning: exported method BoundContract.GetDeployer should have comment or be unexported (golint)

• go-ethercore/p2p/testing/protocoltester.go
  • Line 272: warning: exported type WrappedMsg should have comment or be unexported (golint)
  • Line 278: warning: exported function Wrap should have comment or be unexported (golint)

• go-ethercore/tests/state_test_util.go
  • Line 54: warning: exported method StateTest.UnmarshalJSON should have comment or be unexported (golint)
  • Line 129: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 207: warning: exported function MakePreState should have comment or be unexported (golint)

• go-ethercore/rpc/http.go
  • Line 257: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 258: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 259: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 261: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 264: warning: should not use basic type string as key in context.WithValue (golint)

• go-ethercore/core/vm/logger_json.go
  • Line 29: warning: exported type JSONLogger should have comment or be unexported (golint)
  • Line 44: warning: exported method JSONLogger.CaptureStart should have comment or be unexported (golint)

• go-ethercore/internal/ethapi/backend.go
  • Line 89: warning: exported function GetAPIs should have comment or be unexported (golint)

• go-ethercore/p2p/simulations/network.go
  • Line 37: warning: exported var DialBanTimeout should have comment or be unexported (golint)
  • Line 457: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 475: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 654: warning: comment on exported method Network.InitConn should be of the form "InitConn ..." (golint)
  • Line 894: warning: exported method Network.SnapshotWithServices should have comment or be unexported (golint)
  • Line 1101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/les/server_handler.go
  • Line 47: warning: exported const MaxHeaderFetch should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/rpc/server.go
  • Line 28: warning: exported const MetadataApi should have comment or be unexported (golint)

• go-ethercore/light/postprocess.go
  • Line 105: warning: exported var ChtTablePrefix should have comment or be unexported (golint)
  • Line 228: warning: exported var BloomTrieTablePrefix should have comment or be unexported (golint)

• go-ethercore/metrics/counter.go
  • Line 7: warning: comment on exported type Counter should be of the form "Counter ..." (with optional leading article) (golint)

• go-ethercore/p2p/server.go
  • Line 374: warning: comment on exported method Server.SubscribeEvents should be of the form "SubscribeEvents ..." (golint)

• go-ethercore/les/protocol.go
  • Line 45: warning: comment on exported var ProtocolLengths should be of the form "ProtocolLengths ..." (golint)
  • Line 49: warning: exported const NetworkId should have comment (or a comment on this block) or be unexported (golint)
  • Line 98: warning: exported const ErrMsgTooLarge should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/cmd/utils/cmd.go
  • Line 66: warning: exported function StartNode should have comment or be unexported (golint)
  • Line 88: warning: exported function ImportChain should have comment or be unexported (golint)

• go-ethercore/signer/storage/storage.go
  • Line 29: warning: exported type Storage should have comment or be unexported (golint)
  • Line 72: warning: exported function NewEphemeralStorage should have comment or be unexported (golint)
  • Line 82: warning: exported method NoStorage.Put should have comment or be unexported (golint)
  • Line 83: warning: exported method NoStorage.Del should have comment or be unexported (golint)
  • Line 84: warning: exported method NoStorage.Get should have comment or be unexported (golint)

• go-ethercore/p2p/enr/enr.go
  • Line 46: warning: exported const SizeLimit should have comment or be unexported (golint)
  • Line 49: warning: exported var ErrInvalidSig should have comment or be unexported (golint)
  • Line 68: warning: exported method SchemeMap.Verify should have comment or be unexported (golint)
  • Line 76: warning: exported method SchemeMap.NodeAddr should have comment or be unexported (golint)

• go-ethercore/p2p/simulations/adapters/exec.go
  • Line 524: warning: exported method SnapshotAPI.Snapshot should have comment or be unexported (golint)

• go-ethercore/p2p/peer_error.go
  • Line 57: warning: exported type DiscReason should have comment or be unexported (golint)
  • Line 60: warning: exported const DiscRequested should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/cmd/evm/internal/compiler/compiler.go
  • Line 26: warning: exported function Compile should have comment or be unexported (golint)

• go-ethercore/crypto/blake2b/blake2b.go
  • Line 26: warning: comment on exported const BlockSize should be of the form "BlockSize ..." (golint)
  • Line 28: warning: comment on exported const Size should be of the form "Size ..." (golint)
  • Line 30: warning: comment on exported const Size384 should be of the form "Size384 ..." (golint)
  • Line 32: warning: comment on exported const Size256 should be of the form "Size256 ..." (golint)

• go-ethercore/core/types/derive_sha.go
  • Line 27: warning: exported type DerivableList should have comment or be unexported (golint)
  • Line 32: warning: exported function DeriveSha should have comment or be unexported (golint)

• go-ethercore/event/event.go
  • Line 174: warning: exported method TypeMuxSubscription.Chan should have comment or be unexported (golint)
  • Line 178: warning: exported method TypeMuxSubscription.Unsubscribe should have comment or be unexported (golint)
  • Line 183: warning: exported method TypeMuxSubscription.Closed should have comment or be unexported (golint)

• go-ethercore/internal/ethapi/addrlock.go
  • Line 25: warning: exported type AddrLocker should have comment or be unexported (golint)

• go-ethercore/light/lightchain.go
  • Line 222: warning: exported method LightChain.StateCache should have comment or be unexported (golint)
  • Line 447: warning: receiver name bc should be consistent with previous receiver name lc for LightChain (golint)

• go-ethercore/node/defaults.go
  • Line 31: warning: exported const DefaultHTTPHost should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/core/state_transition.go
  • Line 34: warning: comment on exported type StateTransition should be of the form "StateTransition ..." (with optional leading article) (golint)

• go-ethercore/common/prque/prque.go
  • Line 24: warning: comment on exported type Prque should be of the form "Prque ..." (with optional leading article) (golint)
  • Line 34: warning: comment on exported method Prque.Push should be of the form "Push ..." (golint)
  • Line 45: warning: comment on exported method Prque.Pop should be of the form "Pop ..." (golint)
  • Line 52: warning: comment on exported method Prque.PopItem should be of the form "PopItem ..." (golint)
  • Line 65: warning: comment on exported method Prque.Empty should be of the form "Empty ..." (golint)
  • Line 70: warning: comment on exported method Prque.Size should be of the form "Size ..." (golint)
  • Line 75: warning: comment on exported method Prque.Reset should be of the form "Reset ..." (golint)

• go-ethercore/core/state/state_object.go
  • Line 34: warning: exported type Code should have comment or be unexported (golint)
  • Line 40: warning: exported type Storage should have comment or be unexported (golint)
  • Line 50: warning: exported method Storage.Copy should have comment or be unexported (golint)

• go-ethercore/whisper/whisperv6/peer.go
  • Line 255: warning: exported function MakeFullNodeBloom should have comment or be unexported (golint)

• go-ethercore/params/protocol_params.go
  • Line 22: warning: exported const GasLimitBoundDivisor should have comment (or a comment on this block) or be unexported (golint)
  • Line 82: warning: comment on exported const CallGasFrontier should be of the form "CallGasFrontier ..." (golint)
  • Line 97: warning: comment on exported const ExpByteFrontier should be of the form "ExpByteFrontier ..." (golint)
  • Line 101: warning: comment on exported const ExtcodeCopyBaseFrontier should be of the form "ExtcodeCopyBaseFrontier ..." (golint)
  • Line 135: warning: exported var DifficultyBoundDivisor should have comment or be unexported (golint)

• go-ethercore/metrics/sample.go
  • Line 13: warning: comment on exported type Sample should be of the form "Sample ..." (with optional leading article) (golint)
  • Line 217: warning: comment on exported method NilSample.Snapshot should be of the form "Snapshot ..." (golint)
  • Line 271: warning: comment on exported function SamplePercentile should be of the form "SamplePercentile ..." (golint)
  • Line 305: warning: exported function NewSampleSnapshot should have comment or be unexported (golint)
  • Line 397: warning: comment on exported type UniformSample should be of the form "UniformSample ..." (with optional leading article) (golint)

• go-ethercore/p2p/nat/nat.go
  • Line 32: warning: comment on exported type Interface should be of the form "Interface ..." (with optional leading article) (golint)
  • Line 134: warning: exported method ExtIP.ExternalIP should have comment or be unexported (golint)
  • Line 139: warning: exported method ExtIP.AddMapping should have comment or be unexported (golint)
  • Line 140: warning: exported method ExtIP.DeleteMapping should have comment or be unexported (golint)
  • Line 223: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/node/errors.go
  • Line 27: warning: exported var ErrDatadirUsed should have comment or be unexported (golint)

• go-ethercore/p2p/enode/urlv4.go
  • Line 169: warning: exported method Node.URLv4 should have comment or be unexported (golint)

• go-ethercore/console/bridge.go
  • Line 146: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/internal/debug/trace.go
  • Line 50: warning: comment on exported method HandlerT.StopGoTrace should be of the form "StopGoTrace ..." (golint)

• go-ethercore/p2p/simulations/simulation.go
  • Line 116: warning: exported type Step should have comment or be unexported (golint)
  • Line 128: warning: exported type Expectation should have comment or be unexported (golint)
  • Line 142: warning: exported type StepResult should have comment or be unexported (golint)

• go-ethercore/accounts/keystore/keystore.go
  • Line 44: warning: exported var ErrLocked should have comment or be unexported (golint)

• go-ethercore/log/logger.go
  • Line 18: warning: exported type Lvl should have comment or be unexported (golint)
  • Line 21: warning: exported const LvlCrit should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/core/state/statedb.go
  • Line 60: warning: comment on exported type StateDB should be of the form "StateDB ..." (with optional leading article) (golint)
  • Line 108: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 158: warning: exported method StateDB.AddLog should have comment or be unexported (golint)
  • Line 169: warning: exported method StateDB.GetLogs should have comment or be unexported (golint)
  • Line 173: warning: exported method StateDB.Logs should have comment or be unexported (golint)
  • Line 225: warning: comment on exported method StateDB.GetBalance should be of the form "GetBalance ..." (golint)
  • Line 234: warning: exported method StateDB.GetNonce should have comment or be unexported (golint)
  • Line 253: warning: exported method StateDB.GetCode should have comment or be unexported (golint)
  • Line 261: warning: exported method StateDB.GetCodeSize should have comment or be unexported (golint)
  • Line 276: warning: exported method StateDB.GetCodeHash should have comment or be unexported (golint)
  • Line 300: warning: comment on exported method StateDB.GetStorageProof should be of the form "GetStorageProof ..." (golint)
  • Line 337: warning: exported method StateDB.HasSuicided should have comment or be unexported (golint)
  • Line 365: warning: exported method StateDB.SetBalance should have comment or be unexported (golint)
  • Line 372: warning: exported method StateDB.SetNonce should have comment or be unexported (golint)
  • Line 379: warning: exported method StateDB.SetCode should have comment or be unexported (golint)
  • Line 386: warning: exported method StateDB.SetState should have comment or be unexported (golint)
  • Line 498: warning: comment on exported method StateDB.GetOrNewStateObject should be of the form "GetOrNewStateObject ..." (golint)
  • Line 540: warning: exported method StateDB.ForEachStorage should have comment or be unexported (golint)
  • Line 540: warning: receiver name db should be consistent with previous receiver name s for StateDB (golint)

• go-ethercore/internal/cmdtest/test_cmd.go
  • Line 38: warning: exported function NewTestCmd should have comment or be unexported (golint)
  • Line 42: warning: exported type TestCmd should have comment or be unexported (golint)
  • Line 89: warning: exported method TestCmd.SetTemplateFunc should have comment or be unexported (golint)
  • Line 187: warning: exported method TestCmd.WaitExit should have comment or be unexported (golint)
  • Line 191: warning: exported method TestCmd.Interrupt should have comment or be unexported (golint)
  • Line 218: warning: exported method TestCmd.CloseStdin should have comment or be unexported (golint)
  • Line 222: warning: exported method TestCmd.Kill should have comment or be unexported (golint)

• go-ethercore/light/txpool_test.go
  • Line 39: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 43: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 50: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• go-ethercore/metrics/resetting_timer.go
  • Line 10: warning: comment on exported const InitialResettingTimerSliceCap should be of the form "InitialResettingTimerSliceCap ..." (golint)
  • Line 120: warning: comment on exported method StandardResettingTimer.Time should be of the form "Time ..." (golint)
  • Line 127: warning: comment on exported method StandardResettingTimer.Update should be of the form "Update ..." (golint)
  • Line 134: warning: comment on exported method StandardResettingTimer.UpdateSince should be of the form "UpdateSince ..." (golint)

• go-ethercore/p2p/discv5/table.go
  • Line 40: warning: exported type Table should have comment or be unexported (golint)

• go-ethercore/tests/difficulty_test_util.go
  • Line 32: warning: exported type DifficultyTest should have comment or be unexported (golint)
  • Line 50: warning: exported method DifficultyTest.Run should have comment or be unexported (golint)

• go-ethercore/core/vm/runtime/env.go
  • Line 24: warning: exported function NewEnv should have comment or be unexported (golint)

• go-ethercore/crypto/ecies/params.go
  • Line 49: warning: exported var DefaultCurve should have comment or be unexported (golint)
  • Line 54: warning: exported type ECIESParams should have comment or be unexported (golint)
  • Line 69: warning: exported var ECIES_AES128_SHA256 should have comment or be unexported (golint)
  • Line 109: warning: exported function AddParamsForCurve should have comment or be unexported (golint)

• go-ethercore/internal/build/archive.go
  • Line 30: warning: exported type Archive should have comment or be unexported (golint)
  • Line 44: warning: exported function NewArchive should have comment or be unexported (golint)
  • Line 107: warning: exported type ZipArchive should have comment or be unexported (golint)
  • Line 113: warning: exported function NewZipArchive should have comment or be unexported (golint)
  • Line 117: warning: exported method ZipArchive.Directory should have comment or be unexported (golint)
  • Line 122: warning: exported method ZipArchive.Header should have comment or be unexported (golint)
  • Line 136: warning: exported method ZipArchive.Close should have comment or be unexported (golint)
  • Line 143: warning: exported type TarballArchive should have comment or be unexported (golint)
  • Line 150: warning: exported function NewTarballArchive should have comment or be unexported (golint)
  • Line 156: warning: exported method TarballArchive.Directory should have comment or be unexported (golint)
  • Line 165: warning: exported method TarballArchive.Header should have comment or be unexported (golint)
  • Line 177: warning: exported method TarballArchive.Close should have comment or be unexported (golint)
  • Line 187: warning: exported function ExtractTarballArchive should have comment or be unexported (golint)

• go-ethercore/log/doc.go
  • Line 1: warning: package comment should be of the form "Package log ..." (golint)

• go-ethercore/metrics/debug.go
  • Line 22: warning: comment on exported function CaptureDebugGCStats should be of the form "CaptureDebugGCStats ..." (golint)
  • Line 30: warning: comment on exported function CaptureDebugGCStatsOnce should be of the form "CaptureDebugGCStatsOnce ..." (golint)
  • Line 53: warning: comment on exported function RegisterDebugGCStats should be of the form "RegisterDebugGCStats ..." (golint)

• go-ethercore/metrics/timer.go
  • Line 8: warning: comment on exported type Timer should be of the form "Timer ..." (with optional leading article) (golint)
  • Line 221: warning: comment on exported method StandardTimer.Time should be of the form "Time ..." (golint)
  • Line 228: warning: comment on exported method StandardTimer.Update should be of the form "Update ..." (golint)
  • Line 236: warning: comment on exported method StandardTimer.UpdateSince should be of the form "UpdateSince ..." (golint)

• go-ethercore/les/benchmark.go
  • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/accounts/keystore/key.go
  • Line 42: warning: exported type Key should have comment or be unexported (golint)
  • Line 81: warning: exported type CryptoJSON should have comment or be unexported (golint)
  • Line 94: warning: exported method Key.MarshalJSON should have comment or be unexported (golint)
  • Line 105: warning: exported method Key.UnmarshalJSON should have comment or be unexported (golint)

• go-ethercore/core/types/block.go
  • Line 36: warning: exported var EmptyRootHash should have comment or be unexported (golint)
  • Line 173: warning: comment on exported type StorageBlock should be of the form "StorageBlock ..." (with optional leading article) (golint)
  • Line 279: warning: comment on exported method StorageBlock.DecodeRLP should be of the form "DecodeRLP ..." (golint)
  • Line 291: warning: exported method Block.Uncles should have comment or be unexported (golint)
  • Line 292: warning: exported method Block.Transactions should have comment or be unexported (golint)
  • Line 294: warning: exported method Block.Transaction should have comment or be unexported (golint)
  • Line 303: warning: exported method Block.Number should have comment or be unexported (golint)
  • Line 304: warning: exported method Block.GasLimit should have comment or be unexported (golint)
  • Line 305: warning: exported method Block.GasUsed should have comment or be unexported (golint)
  • Line 306: warning: exported method Block.Difficulty should have comment or be unexported (golint)
  • Line 307: warning: exported method Block.Time should have comment or be unexported (golint)
  • Line 309: warning: exported method Block.NumberU64 should have comment or be unexported (golint)
  • Line 310: warning: exported method Block.MixDigest should have comment or be unexported (golint)
  • Line 311: warning: exported method Block.Nonce should have comment or be unexported (golint)
  • Line 312: warning: exported method Block.Bloom should have comment or be unexported (golint)
  • Line 313: warning: exported method Block.Coinbase should have comment or be unexported (golint)
  • Line 314: warning: exported method Block.Root should have comment or be unexported (golint)
  • Line 315: warning: exported method Block.ParentHash should have comment or be unexported (golint)
  • Line 316: warning: exported method Block.TxHash should have comment or be unexported (golint)
  • Line 317: warning: exported method Block.ReceiptHash should have comment or be unexported (golint)
  • Line 318: warning: exported method Block.UncleHash should have comment or be unexported (golint)
  • Line 319: warning: exported method Block.Extra should have comment or be unexported (golint)
  • Line 321: warning: exported method Block.Header should have comment or be unexported (golint)
  • Line 351: warning: exported function CalcUncleHash should have comment or be unexported (golint)
  • Line 395: warning: exported type Blocks should have comment or be unexported (golint)

• go-ethercore/signer/core/stdioui.go
  • Line 27: warning: exported type StdIOUI should have comment or be unexported (golint)
  • Line 31: warning: exported function NewStdIOUI should have comment or be unexported (golint)
  • Line 40: warning: exported method StdIOUI.RegisterUIServer should have comment or be unexported (golint)
  • Line 63: warning: exported method StdIOUI.ApproveTx should have comment or be unexported (golint)
  • Line 69: warning: exported method StdIOUI.ApproveSignData should have comment or be unexported (golint)
  • Line 75: warning: exported method StdIOUI.ApproveListing should have comment or be unexported (golint)
  • Line 81: warning: exported method StdIOUI.ApproveNewAccount should have comment or be unexported (golint)
  • Line 87: warning: exported method StdIOUI.ShowError should have comment or be unexported (golint)
  • Line 94: warning: exported method StdIOUI.ShowInfo should have comment or be unexported (golint)
  • Line 100: warning: exported method StdIOUI.OnApprovedTx should have comment or be unexported (golint)
  • Line 107: warning: exported method StdIOUI.OnSignerStartup should have comment or be unexported (golint)
  • Line 113: warning: exported method StdIOUI.OnInputRequired should have comment or be unexported (golint)

• go-ethercore/p2p/simulations/test.go
  • Line 34: warning: exported function NewNoopService should have comment or be unexported (golint)
  • Line 40: warning: exported method NoopService.Protocols should have comment or be unexported (golint)
  • Line 65: warning: exported method NoopService.APIs should have comment or be unexported (golint)
  • Line 69: warning: exported method NoopService.Start should have comment or be unexported (golint)
  • Line 73: warning: exported method NoopService.Stop should have comment or be unexported (golint)
  • Line 77: warning: exported function VerifyRing should have comment or be unexported (golint)
  • Line 96: warning: exported function VerifyChain should have comment or be unexported (golint)
  • Line 115: warning: exported function VerifyFull should have comment or be unexported (golint)
  • Line 133: warning: exported function VerifyStar should have comment or be unexported (golint)

• go-ethercore/eth/downloader/modes.go
  • Line 25: warning: exported const FullSync should have comment (or a comment on this block) or be unexported (golint)
  • Line 30: warning: exported method SyncMode.IsValid should have comment or be unexported (golint)
  • Line 48: warning: exported method SyncMode.MarshalText should have comment or be unexported (golint)
  • Line 61: warning: exported method SyncMode.UnmarshalText should have comment or be unexported (golint)

• go-ethercore/p2p/testing/peerpool.go
  • Line 27: warning: exported type TestPeer should have comment or be unexported (golint)
  • Line 38: warning: exported function NewTestPeerPool should have comment or be unexported (golint)
  • Line 42: warning: exported method TestPeerPool.Add should have comment or be unexported (golint)
  • Line 50: warning: exported method TestPeerPool.Remove should have comment or be unexported (golint)
  • Line 56: warning: exported method TestPeerPool.Has should have comment or be unexported (golint)
  • Line 63: warning: exported method TestPeerPool.Get should have comment or be unexported (golint)

• go-ethercore/les/odr.go
  • Line 39: warning: exported function NewLesOdr should have comment or be unexported (golint)
  • Line 86: warning: exported const MsgBlockBodies should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/crypto/secp256k1/curve.go
  • Line 89: warning: exported method BitCurve.Params should have comment or be unexported (golint)
  • Line 241: warning: exported method BitCurve.ScalarMult should have comment or be unexported (golint)

• go-ethercore/eth/backend.go
  • Line 57: warning: exported type LesServer should have comment or be unexported (golint)
  • Line 102: warning: exported method Ethereum.AddLesServer should have comment or be unexported (golint)
  • Line 107: warning: comment on exported method Ethereum.SetContractBackend should be of the form "SetContractBackend ..." (golint)
  • Line 348: warning: exported method Ethereum.ResetWithGenesisBlock should have comment or be unexported (golint)
  • Line 352: warning: exported method Ethereum.Etherbase should have comment or be unexported (golint)
  • Line 498: warning: exported method Ethereum.IsMining should have comment or be unexported (golint)
  • Line 499: warning: exported method Ethereum.Miner should have comment or be unexported (golint)
  • Line 501: warning: exported method Ethereum.AccountManager should have comment or be unexported (golint)
  • Line 502: warning: exported method Ethereum.BlockChain should have comment or be unexported (golint)
  • Line 503: warning: exported method Ethereum.TxPool should have comment or be unexported (golint)
  • Line 504: warning: exported method Ethereum.EventMux should have comment or be unexported (golint)
  • Line 505: warning: exported method Ethereum.Engine should have comment or be unexported (golint)
  • Line 506: warning: exported method Ethereum.ChainDb should have comment or be unexported (golint)
  • Line 507: warning: exported method Ethereum.IsListening should have comment or be unexported (golint)
  • Line 508: warning: exported method Ethereum.EthVersion should have comment or be unexported (golint)
  • Line 509: warning: exported method Ethereum.NetVersion should have comment or be unexported (golint)
  • Line 510: warning: exported method Ethereum.Downloader should have comment or be unexported (golint)
  • Line 511: warning: exported method Ethereum.Synced should have comment or be unexported (golint)
  • Line 512: warning: exported method Ethereum.ArchiveMode should have comment or be unexported (golint)

• go-ethercore/crypto/bn256/cloudflare/gfp12.go
  • Line 113: warning: receiver name c should be consistent with previous receiver name e for gfP12 (golint)

• go-ethercore/internal/web3ext/web3ext.go
  • Line 17: warning: package comment should be of the form "Package web3ext ..." (golint)
  • Line 20: warning: exported var Modules should have comment or be unexported (golint)
  • Line 38: warning: exported const ChequebookJs should have comment or be unexported (golint)
  • Line 69: warning: exported const CliqueJs should have comment or be unexported (golint)
  • Line 120: warning: exported const EthashJs should have comment or be unexported (golint)
  • Line 148: warning: exported const AdminJs should have comment or be unexported (golint)
  • Line 226: warning: exported const DebugJs should have comment or be unexported (golint)
  • Line 468: warning: exported const EthJs should have comment or be unexported (golint)
  • Line 564: warning: exported const MinerJs should have comment or be unexported (golint)
  • Line 609: warning: exported const NetJs should have comment or be unexported (golint)
  • Line 622: warning: exported const PersonalJs should have comment or be unexported (golint)
  • Line 678: warning: exported const RpcJs should have comment or be unexported (golint)
  • Line 691: warning: exported const ShhJs should have comment or be unexported (golint)
  • Line 711: warning: exported const SwarmfsJs should have comment or be unexported (golint)
  • Line 735: warning: exported const TxpoolJs should have comment or be unexported (golint)
  • Line 762: warning: exported const AccountingJs should have comment or be unexported (golint)
  • Line 806: warning: exported const LESJs should have comment or be unexported (golint)

• go-ethercore/mobile/interface.go
  • Line 45: warning: exported method Interface.SetBool should have comment or be unexported (golint)
  • Line 46: warning: exported method Interface.SetBools should have comment or be unexported (golint)
  • Line 47: warning: exported method Interface.SetString should have comment or be unexported (golint)
  • Line 48: warning: exported method Interface.SetStrings should have comment or be unexported (golint)
  • Line 49: warning: exported method Interface.SetBinary should have comment or be unexported (golint)
  • Line 50: warning: exported method Interface.SetBinaries should have comment or be unexported (golint)
  • Line 51: warning: exported method Interface.SetAddress should have comment or be unexported (golint)
  • Line 52: warning: exported method Interface.SetAddresses should have comment or be unexported (golint)
  • Line 53: warning: exported method Interface.SetHash should have comment or be unexported (golint)
  • Line 54: warning: exported method Interface.SetHashes should have comment or be unexported (golint)
  • Line 55: warning: exported method Interface.SetInt8 should have comment or be unexported (golint)
  • Line 56: warning: exported method Interface.SetInt16 should have comment or be unexported (golint)
  • Line 57: warning: exported method Interface.SetInt32 should have comment or be unexported (golint)
  • Line 58: warning: exported method Interface.SetInt64 should have comment or be unexported (golint)
  • Line 59: warning: exported method Interface.SetInt8s should have comment or be unexported (golint)
  • Line 66: warning: exported method Interface.SetInt16s should have comment or be unexported (golint)
  • Line 73: warning: exported method Interface.SetInt32s should have comment or be unexported (golint)
  • Line 80: warning: exported method Interface.SetInt64s should have comment or be unexported (golint)
  • Line 87: warning: exported method Interface.SetUint8 should have comment or be unexported (golint)
  • Line 88: warning: exported method Interface.SetUint16 should have comment or be unexported (golint)
  • Line 89: warning: exported method Interface.SetUint32 should have comment or be unexported (golint)
  • Line 90: warning: exported method Interface.SetUint64 should have comment or be unexported (golint)
  • Line 91: warning: exported method Interface.SetUint8s should have comment or be unexported (golint)
  • Line 98: warning: exported method Interface.SetUint16s should have comment or be unexported (golint)
  • Line 105: warning: exported method Interface.SetUint32s should have comment or be unexported (golint)
  • Line 112: warning: exported method Interface.SetUint64s should have comment or be unexported (golint)
  • Line 119: warning: exported method Interface.SetBigInt should have comment or be unexported (golint)
  • Line 120: warning: exported method Interface.SetBigInts should have comment or be unexported (golint)
  • Line 122: warning: exported method Interface.SetDefaultBool should have comment or be unexported (golint)
  • Line 123: warning: exported method Interface.SetDefaultBools should have comment or be unexported (golint)
  • Line 124: warning: exported method Interface.SetDefaultString should have comment or be unexported (golint)
  • Line 125: warning: exported method Interface.SetDefaultStrings should have comment or be unexported (golint)
  • Line 126: warning: exported method Interface.SetDefaultBinary should have comment or be unexported (golint)
  • Line 127: warning: exported method Interface.SetDefaultBinaries should have comment or be unexported (golint)
  • Line 128: warning: exported method Interface.SetDefaultAddress should have comment or be unexported (golint)
  • Line 129: warning: exported method Interface.SetDefaultAddresses should have comment or be unexported (golint)
  • Line 130: warning: exported method Interface.SetDefaultHash should have comment or be unexported (golint)
  • Line 131: warning: exported method Interface.SetDefaultHashes should have comment or be unexported (golint)
  • Line 132: warning: exported method Interface.SetDefaultInt8 should have comment or be unexported (golint)
  • Line 133: warning: exported method Interface.SetDefaultInt8s should have comment or be unexported (golint)
  • Line 134: warning: exported method Interface.SetDefaultInt16 should have comment or be unexported (golint)
  • Line 135: warning: exported method Interface.SetDefaultInt16s should have comment or be unexported (golint)
  • Line 136: warning: exported method Interface.SetDefaultInt32 should have comment or be unexported (golint)
  • Line 137: warning: exported method Interface.SetDefaultInt32s should have comment or be unexported (golint)
  • Line 138: warning: exported method Interface.SetDefaultInt64 should have comment or be unexported (golint)
  • Line 139: warning: exported method Interface.SetDefaultInt64s should have comment or be unexported (golint)
  • Line 140: warning: exported method Interface.SetDefaultUint8 should have comment or be unexported (golint)
  • Line 141: warning: exported method Interface.SetDefaultUint8s should have comment or be unexported (golint)
  • Line 142: warning: exported method Interface.SetDefaultUint16 should have comment or be unexported (golint)
  • Line 143: warning: exported method Interface.SetDefaultUint16s should have comment or be unexported (golint)
  • Line 144: warning: exported method Interface.SetDefaultUint32 should have comment or be unexported (golint)
  • Line 145: warning: exported method Interface.SetDefaultUint32s should have comment or be unexported (golint)
  • Line 146: warning: exported method Interface.SetDefaultUint64 should have comment or be unexported (golint)
  • Line 147: warning: exported method Interface.SetDefaultUint64s should have comment or be unexported (golint)
  • Line 148: warning: exported method Interface.SetDefaultBigInt should have comment or be unexported (golint)
  • Line 149: warning: exported method Interface.SetDefaultBigInts should have comment or be unexported (golint)
  • Line 151: warning: exported method Interface.GetBool should have comment or be unexported (golint)
  • Line 152: warning: exported method Interface.GetBools should have comment or be unexported (golint)
  • Line 153: warning: exported method Interface.GetString should have comment or be unexported (golint)
  • Line 154: warning: exported method Interface.GetStrings should have comment or be unexported (golint)
  • Line 155: warning: exported method Interface.GetBinary should have comment or be unexported (golint)
  • Line 156: warning: exported method Interface.GetBinaries should have comment or be unexported (golint)
  • Line 157: warning: exported method Interface.GetAddress should have comment or be unexported (golint)
  • Line 158: warning: exported method Interface.GetAddresses should have comment or be unexported (golint)
  • Line 159: warning: exported method Interface.GetHash should have comment or be unexported (golint)
  • Line 160: warning: exported method Interface.GetHashes should have comment or be unexported (golint)
  • Line 161: warning: exported method Interface.GetInt8 should have comment or be unexported (golint)
  • Line 162: warning: exported method Interface.GetInt16 should have comment or be unexported (golint)
  • Line 163: warning: exported method Interface.GetInt32 should have comment or be unexported (golint)
  • Line 164: warning: exported method Interface.GetInt64 should have comment or be unexported (golint)
  • Line 165: warning: exported method Interface.GetInt8s should have comment or be unexported (golint)
  • Line 173: warning: exported method Interface.GetInt16s should have comment or be unexported (golint)
  • Line 181: warning: exported method Interface.GetInt32s should have comment or be unexported (golint)
  • Line 189: warning: exported method Interface.GetInt64s should have comment or be unexported (golint)
  • Line 197: warning: exported method Interface.GetUint8 should have comment or be unexported (golint)
  • Line 200: warning: exported method Interface.GetUint16 should have comment or be unexported (golint)
  • Line 203: warning: exported method Interface.GetUint32 should have comment or be unexported (golint)
  • Line 206: warning: exported method Interface.GetUint64 should have comment or be unexported (golint)
  • Line 209: warning: exported method Interface.GetUint8s should have comment or be unexported (golint)
  • Line 217: warning: exported method Interface.GetUint16s should have comment or be unexported (golint)
  • Line 225: warning: exported method Interface.GetUint32s should have comment or be unexported (golint)
  • Line 233: warning: exported method Interface.GetUint64s should have comment or be unexported (golint)
  • Line 241: warning: exported method Interface.GetBigInt should have comment or be unexported (golint)
  • Line 242: warning: exported method Interface.GetBigInts should have comment or be unexported (golint)

• go-ethercore/metrics/healthcheck.go
  • Line 3: warning: comment on exported type Healthcheck should be of the form "Healthcheck ..." (with optional leading article) (golint)

• go-ethercore/tests/fuzzers/txfetcher/txfetcher_fuzzer.go
  • Line 51: warning: exported function Fuzz should have comment or be unexported (golint)

• go-ethercore/signer/core/types.go
  • Line 30: warning: exported type ValidationInfo should have comment or be unexported (golint)
  • Line 34: warning: exported type ValidationMessages should have comment or be unexported (golint)
  • Line 39: warning: exported const WARN should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported method ValidationMessages.Crit should have comment or be unexported (golint)
  • Line 47: warning: exported method ValidationMessages.Warn should have comment or be unexported (golint)
  • Line 50: warning: exported method ValidationMessages.Info should have comment or be unexported (golint)
  • Line 55: warning: receiver name v should be consistent with previous receiver name vs for ValidationMessages (golint)

• go-ethercore/accounts/abi/unpack.go
  • Line 221: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/core/vm/runtime/runtime_test.go
  • Line 155: warning: don't use underscores in Go names; func benchmarkEVM_Create should be benchmarkEVMCreate (golint)

• go-ethercore/rpc/subscription.go
  • Line 38: warning: comment on exported var ErrSubscriptionNotFound should be of the form "ErrSubscriptionNotFound ..." (golint)

• go-ethercore/crypto/bn256/google/bn256.go
  • Line 168: warning: comment on exported function RandomG2 should be of the form "RandomG2 ..." (golint)
  • Line 226: warning: receiver name n should be consistent with previous receiver name e for G2 (golint)
  • Line 309: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 318: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 327: warning: receiver name e should be consistent with previous receiver name g for GT (golint)
  • Line 336: warning: receiver name n should be consistent with previous receiver name g for GT (golint)
  • Line 374: warning: receiver name e should be consistent with previous receiver name g for GT (golint)

• go-ethercore/crypto/bn256/google/gfp12.go
  • Line 133: warning: receiver name c should be consistent with previous receiver name e for gfP12 (golint)

• go-ethercore/crypto/bn256/google/gfp2.go
  • Line 105: warning: receiver name c should be consistent with previous receiver name e for gfP2 (golint)

• go-ethercore/internal/ethapi/api.go
  • Line 215: warning: comment on exported method PrivateAccountAPI.ListAccounts should be of the form "ListAccounts ..." (golint)
  • Line 541: warning: comment on exported type AccountResult should be of the form "AccountResult ..." (with optional leading article) (golint)
  • Line 551: warning: exported type StorageResult should have comment or be unexported (golint)
  • Line 760: warning: exported function DoCall should have comment or be unexported (golint)
  • Line 886: warning: exported function DoEstimateGas should have comment or be unexported (golint)

• go-ethercore/eth/config.go
  • Line 89: warning: exported type Config should have comment or be unexported (golint)

• go-ethercore/params/bootnodes.go
  • Line 101: warning: comment on exported var KnownDNSNetworks should be of the form "KnownDNSNetworks ..." (golint)

• go-ethercore/accounts/abi/bind/bind.go
  • Line 41: warning: exported const LangGo should have comment (or a comment on this block) or be unexported (golint)
  • Line 604: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• go-ethercore/contracts/checkpointoracle/oracle_test.go
  • Line 282: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
  • Line 305: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• go-ethercore/signer/core/cliui.go
  • Line 33: warning: exported type CommandlineUI should have comment or be unexported (golint)
  • Line 38: warning: exported function NewCommandlineUI should have comment or be unexported (golint)
  • Line 42: warning: exported method CommandlineUI.RegisterUIServer should have comment or be unexported (golint)
  • Line 61: warning: exported method CommandlineUI.OnInputRequired should have comment or be unexported (golint)
  • Line 207: warning: exported method CommandlineUI.OnApprovedTx should have comment or be unexported (golint)
  • Line 216: warning: exported method CommandlineUI.OnSignerStartup should have comment or be unexported (golint)

• go-ethercore/les/flowcontrol/manager.go
  • Line 157: warning: comment on exported method ClientManager.SetCapacityLimits should be of the form "SetCapacityLimits ..." (golint)

• go-ethercore/internal/build/env.go
  • Line 30: warning: comment on exported var GitCommitFlag should be of the form "GitCommitFlag ..." (golint)
  • Line 32: warning: exported var GitBranchFlag should have comment or be unexported (golint)

• go-ethercore/tests/fuzzers/whisperv6/whisper-fuzzer.go
  • Line 27: warning: exported type MessageParams should have comment or be unexported (golint)
  • Line 35: warning: comment on exported function Fuzz should be of the form "Fuzz ..." (golint)

• go-ethercore/metrics/syslog.go
  • Line 11: warning: comment on exported function Syslog should be of the form "Syslog ..." (golint)

• go-ethercore/p2p/simulations/http.go
  • Line 367: warning: comment on exported method Server.GetMockers should be of the form "GetMockers ..." (golint)
  • Line 722: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 737: warning: should not use basic type string as key in context.WithValue (golint)

• go-ethercore/cmd/utils/customflags.go
  • Line 33: warning: comment on exported type DirectoryString should be of the form "DirectoryString ..." (with optional leading article) (golint)
  • Line 42: warning: exported method DirectoryString.Set should have comment or be unexported (golint)
  • Line 47: warning: comment on exported type DirectoryFlag should be of the form "DirectoryFlag ..." (with optional leading article) (golint)
  • Line 60: warning: comment on exported method DirectoryFlag.Apply should be of the form "Apply ..." (golint)
  • Line 68: warning: exported method DirectoryFlag.GetName should have comment or be unexported (golint)
  • Line 72: warning: exported method DirectoryFlag.Set should have comment or be unexported (golint)
  • Line 84: warning: exported type TextMarshaler should have comment or be unexported (golint)
  • Line 114: warning: exported method TextMarshalerFlag.GetName should have comment or be unexported (golint)
  • Line 122: warning: exported method TextMarshalerFlag.Apply should have comment or be unexported (golint)
  • Line 165: warning: exported method BigFlag.GetName should have comment or be unexported (golint)
  • Line 173: warning: exported method BigFlag.Apply should have comment or be unexported (golint)

• go-ethercore/core/vm/memory.go
  • Line 72: warning: comment on exported method Memory.GetCopy should be of the form "GetCopy ..." (golint)

• go-ethercore/consensus/ethash/progpow_test.go
  • Line 65: warning: don't use underscores in Go names; var expCdag0_to_15 should be expCdag0To15 (golint)
  • Line 71: warning: don't use underscores in Go names; var expCdag4080_to_4095 should be expCdag4080To4095 (golint)

• go-ethercore/metrics/gauge_float64.go
  • Line 5: warning: comment on exported type GaugeFloat64 should be of the form "GaugeFloat64 ..." (with optional leading article) (golint)
  • Line 41: warning: comment on exported function NewFunctionalGaugeFloat64 should be of the form "NewFunctionalGaugeFloat64 ..." (golint)
  • Line 49: warning: comment on exported function NewRegisteredFunctionalGaugeFloat64 should be of the form "NewRegisteredFunctionalGaugeFloat64 ..." (golint)
  • Line 73: warning: comment on exported type NilGaugeFloat64 should be of the form "NilGaugeFloat64 ..." (with optional leading article) (golint)

• go-ethercore/internal/jsre/jsre.go
  • Line 69: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 230: warning: comment on exported method JSRE.Stop should be of the form "Stop ..." (golint)
  • Line 239: warning: comment on exported method JSRE.Exec should be of the form "Exec ..." (golint)

• go-ethercore/mobile/shhclient.go
  • Line 42: warning: comment on exported method WhisperClient.GetInfo should be of the form "GetInfo ..." (golint)
  • Line 64: warning: comment on exported method WhisperClient.MarkTrustedPeer should be of the form "MarkTrustedPeer ..." (golint)
  • Line 138: warning: comment on exported type NewMessageHandler should be of the form "NewMessageHandler ..." (with optional leading article) (golint)

• go-ethercore/core/blockchain.go
  • Line 85: warning: exported const TriesInMemory should have comment (or a comment on this block) or be unexported (golint)
  • Line 892: warning: exported const NonStatTy should have comment (or a comment on this block) or be unexported (golint)

• go-ethercore/metrics/ewma.go
  • Line 9: warning: comment on exported type EWMA should be of the form "EWMA ..." (with optional leading article) (golint)

• go-ethercore/p2p/simulations/adapters/inproc.go
  • Line 58: warning: exported function NewTCPAdapter should have comment or be unexported (golint)

• go-ethercore/whisper/whisperv6/whisper.go
  • Line 1054: warning: exported function BloomFilterMatch should have comment or be unexported (golint)

• go-ethercore/interfaces.go
  • Line 30: warning: error var NotFound should have name of the form ErrFoo (golint)

• go-ethercore/accounts/keystore/passphrase.go
  • Line 140: warning: comment on exported function EncryptDataV3 should be of the form "EncryptDataV3 ..." (golint)
  • Line 239: warning: exported function DecryptDataV3 should have comment or be unexported (golint)

• go-ethercore/consensus/ethash/progpow.go
  • Line 320: warning: don't use underscores in Go names; var data_g should be dataG (golint)
  • Line 323: warning: don't use underscores in Go names; var dag_item should be dagItem (golint)

• go-ethercore/metrics/exp/exp.go
  • Line 1: warning: package comment should be of the form "Package exp ..." (golint)

• go-ethercore/mobile/types.go
  • Line 101: warning: exported method Header.GetParentHash should have comment or be unexported (golint)
  • Line 102: warning: exported method Header.GetUncleHash should have comment or be unexported (golint)
  • Line 103: warning: exported method Header.GetCoinbase should have comment or be unexported (golint)
  • Line 104: warning: exported method Header.GetRoot should have comment or be unexported (golint)
  • Line 105: warning: exported method Header.GetTxHash should have comment or be unexported (golint)
  • Line 106: warning: exported method Header.GetReceiptHash should have comment or be unexported (golint)
  • Line 107: warning: exported method Header.GetBloom should have comment or be unexported (golint)
  • Line 108: warning: exported method Header.GetDifficulty should have comment or be unexported (golint)
  • Line 109: warning: exported method Header.GetNumber should have comment or be unexported (golint)
  • Line 110: warning: exported method Header.GetGasLimit should have comment or be unexported (golint)
  • Line 111: warning: exported method Header.GetGasUsed should have comment or be unexported (golint)
  • Line 112: warning: exported method Header.GetTime should have comment or be unexported (golint)
  • Line 113: warning: exported method Header.GetExtra should have comment or be unexported (golint)
  • Line 114: warning: exported method Header.GetMixDigest should have comment or be unexported (golint)
  • Line 115: warning: exported method Header.GetNonce should have comment or be unexported (golint)
  • Line 116: warning: exported method Header.GetHash should have comment or be unexported (golint)
  • Line 172: warning: exported method Block.GetParentHash should have comment or be unexported (golint)
  • Line 173: warning: exported method Block.GetUncleHash should have comment or be unexported (golint)
  • Line 174: warning: exported method Block.GetCoinbase should have comment or be unexported (golint)
  • Line 175: warning: exported method Block.GetRoot should have comment or be unexported (golint)
  • Line 176: warning: exported method Block.GetTxHash should have comment or be unexported (golint)
  • Line 177: warning: exported method Block.GetReceiptHash should have comment or be unexported (golint)
  • Line 178: warning: exported method Block.GetBloom should have comment or be unexported (golint)
  • Line 179: warning: exported method Block.GetDifficulty should have comment or be unexported (golint)
  • Line 180: warning: exported method Block.GetNumber should have comment or be unexported (golint)
  • Line 181: warning: exported method Block.GetGasLimit should have comment or be unexported (golint)
  • Line 182: warning: exported method Block.GetGasUsed should have comment or be unexported (golint)
  • Line 183: warning: exported method Block.GetTime should have comment or be unexported (golint)
  • Line 184: warning: exported method Block.GetExtra should have comment or be unexported (golint)
  • Line 185: warning: exported method Block.GetMixDigest should have comment or be unexported (golint)
  • Line 186: warning: exported method Block.GetNonce should have comment or be unexported (golint)
  • Line 187: warning: exported method Block.GetHash should have comment or be unexported (golint)
  • Line 188: warning: exported method Block.GetHeader should have comment or be unexported (golint)
  • Line 189: warning: exported method Block.GetUncles should have comment or be unexported (golint)
  • Line 190: warning: exported method Block.GetTransactions should have comment or be unexported (golint)
  • Line 191: warning: exported method Block.GetTransaction should have comment or be unexported (golint)
  • Line 248: warning: exported method Transaction.GetData should have comment or be unexported (golint)
  • Line 249: warning: exported method Transaction.GetGas should have comment or be unexported (golint)
  • Line 250: warning: exported method Transaction.GetGasPrice should have comment or be unexported (golint)
  • Line 251: warning: exported method Transaction.GetValue should have comment or be unexported (golint)
  • Line 252: warning: exported method Transaction.GetNonce should have comment or be unexported (golint)
  • Line 254: warning: exported method Transaction.GetHash should have comment or be unexported (golint)
  • Line 255: warning: exported method Transaction.GetCost should have comment or be unexported (golint)
  • Line 257: warning: comment on exported method Transaction.GetSigHash should be of the form "GetSigHash ..." (golint)
  • Line 260: warning: comment on exported method Transaction.GetFrom should be of the form "GetFrom ..." (golint)
  • Line 270: warning: exported method Transaction.GetTo should have comment or be unexported (golint)
  • Line 277: warning: exported method Transaction.WithSignature should have comment or be unexported (golint)
  • Line 340: warning: exported method Receipt.GetStatus should have comment or be unexported (golint)
  • Line 341: warning: exported method Receipt.GetPostState should have comment or be unexported (golint)
  • Line 342: warning: exported method Receipt.GetCumulativeGasUsed should have comment or be unexported (golint)
  • Line 343: warning: exported method Receipt.GetBloom should have comment or be unexported (golint)
  • Line 344: warning: exported method Receipt.GetLogs should have comment or be unexported (golint)
  • Line 345: warning: exported method Receipt.GetTxHash should have comment or be unexported (golint)
  • Line 346: warning: exported method Receipt.GetContractAddress should have comment or be unexported (golint)
  • Line 347: warning: exported method Receipt.GetGasUsed should have comment or be unexported (golint)
  • Line 359: warning: exported function NewNewMessage should have comment or be unexported (golint)
  • Line 366: warning: exported method NewMessage.GetSymKeyID should have comment or be unexported (golint)
  • Line 367: warning: exported method NewMessage.SetSymKeyID should have comment or be unexported (golint)
  • Line 368: warning: exported method NewMessage.GetPublicKey should have comment or be unexported (golint)
  • Line 369: warning: exported method NewMessage.SetPublicKey should have comment or be unexported (golint)
  • Line 372: warning: exported method NewMessage.GetSig should have comment or be unexported (golint)
  • Line 373: warning: exported method NewMessage.SetSig should have comment or be unexported (golint)
  • Line 374: warning: exported method NewMessage.GetTTL should have comment or be unexported (golint)
  • Line 375: warning: exported method NewMessage.SetTTL should have comment or be unexported (golint)
  • Line 376: warning: exported method NewMessage.GetPayload should have comment or be unexported (golint)
  • Line 377: warning: exported method NewMessage.SetPayload should have comment or be unexported (golint)
  • Line 378: warning: exported method NewMessage.GetPowTime should have comment or be unexported (golint)
  • Line 379: warning: exported method NewMessage.SetPowTime should have comment or be unexported (golint)
  • Line 380: warning: exported method NewMessage.GetPowTarget should have comment or be unexported (golint)
  • Line 381: warning: exported method NewMessage.SetPowTarget should have comment or be unexported (golint)
  • Line 382: warning: exported method NewMessage.GetTargetPeer should have comment or be unexported (golint)
  • Line 383: warning: exported method NewMessage.SetTargetPeer should have comment or be unexported (golint)
  • Line 384: warning: exported method NewMessage.GetTopic should have comment or be unexported (golint)
  • Line 385: warning: exported method NewMessage.SetTopic should have comment or be unexported (golint)
  • Line 392: warning: exported method Message.GetSig should have comment or be unexported (golint)
  • Line 393: warning: exported method Message.GetTTL should have comment or be unexported (golint)
  • Line 394: warning: exported method Message.GetTimestamp should have comment or be unexported (golint)
  • Line 395: warning: exported method Message.GetPayload should have comment or be unexported (golint)
  • Line 396: warning: exported method Message.GetPoW should have comment or be unexported (golint)
  • Line 397: warning: exported method Message.GetHash should have comment or be unexported (golint)
  • Line 398: warning: exported method Message.GetDst should have comment or be unexported (golint)
  • Line 423: warning: exported function NewCriteria should have comment or be unexported (golint)
  • Line 432: warning: exported method Criteria.GetSymKeyID should have comment or be unexported (golint)
  • Line 433: warning: exported method Criteria.SetSymKeyID should have comment or be unexported (golint)
  • Line 434: warning: exported method Criteria.GetPrivateKeyID should have comment or be unexported (golint)
  • Line 435: warning: exported method Criteria.SetPrivateKeyID should have comment or be unexported (golint)
  • Line 436: warning: exported method Criteria.GetSig should have comment or be unexported (golint)
  • Line 437: warning: exported method Criteria.SetSig should have comment or be unexported (golint)
  • Line 438: warning: exported method Criteria.GetMinPow should have comment or be unexported (golint)
  • Line 439: warning: exported method Criteria.SetMinPow should have comment or be unexported (golint)

• go-ethercore/params/config.go
  • Line 290: warning: exported var TestChainConfig should have comment or be unexported (golint)
  • Line 426: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-ethercore/p2p/message.go
  • Line 73: warning: exported type MsgReader should have comment or be unexported (golint)
  • Line 77: warning: exported type MsgWriter should have comment or be unexported (golint)

• go-ethercore/tests/transaction_test_util.go
  • Line 47: warning: exported method TransactionTest.Run should have comment or be unexported (golint)

• go-ethercore/cmd/clef/main.go
  • Line 614: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 713: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 714: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 715: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 846: warning: should not use basic type string as key in context.WithValue (golint)

• go-ethercore/crypto/ecies/ecies.go
  • Line 45: warning: exported var ErrImport should have comment or be unexported (golint)
  • Line 61: warning: comment on exported method PublicKey.ExportECDSA should be of the form "ExportECDSA ..." (golint)
  • Line 66: warning: comment on exported function ImportECDSAPublic should be of the form "ImportECDSAPublic ..." (golint)
  • Line 82: warning: comment on exported method PrivateKey.ExportECDSA should be of the form "ExportECDSA ..." (golint)
  • Line 89: warning: comment on exported function ImportECDSA should be of the form "ImportECDSA ..." (golint)
  • Line 95: warning: comment on exported function GenerateKey should be of the form "GenerateKey ..." (golint)
  • Line 120: warning: comment on exported method PrivateKey.GenerateShared should be of the form "GenerateShared ..." (golint)
  • Line 141: warning: exported var ErrKeyDataTooLong should have comment or be unexported (golint)

• go-ethercore/les/api_backend.go
  • Line 42: warning: exported type LesApiBackend should have comment or be unexported (golint)
  • Line 48: warning: exported method LesApiBackend.ChainConfig should have comment or be unexported (golint)
  • Line 52: warning: exported method LesApiBackend.CurrentBlock should have comment or be unexported (golint)
  • Line 56: warning: exported method LesApiBackend.SetHead should have comment or be unexported (golint)
  • Line 61: warning: exported method LesApiBackend.HeaderByNumber should have comment or be unexported (golint)
  • Line 68: warning: exported method LesApiBackend.HeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 88: warning: exported method LesApiBackend.HeaderByHash should have comment or be unexported (golint)
  • Line 92: warning: exported method LesApiBackend.BlockByNumber should have comment or be unexported (golint)
  • Line 100: warning: exported method LesApiBackend.BlockByHash should have comment or be unexported (golint)
  • Line 104: warning: exported method LesApiBackend.BlockByNumberOrHash should have comment or be unexported (golint)
  • Line 124: warning: exported method LesApiBackend.StateAndHeaderByNumber should have comment or be unexported (golint)
  • Line 135: warning: exported method LesApiBackend.StateAndHeaderByNumberOrHash should have comment or be unexported (golint)
  • Line 152: warning: exported method LesApiBackend.GetReceipts should have comment or be unexported (golint)
  • Line 159: warning: exported method LesApiBackend.GetLogs should have comment or be unexported (golint)
  • Line 166: warning: exported method LesApiBackend.GetTd should have comment or be unexported (golint)
  • Line 170: warning: exported method LesApiBackend.GetEVM should have comment or be unexported (golint)
  • Line 176: warning: exported method LesApiBackend.SendTx should have comment or be unexported (golint)
  • Line 180: warning: exported method LesApiBackend.RemoveTx should have comment or be unexported (golint)
  • Line 184: warning: exported method LesApiBackend.GetPoolTransactions should have comment or be unexported (golint)
  • Line 188: warning: exported method LesApiBackend.GetPoolTransaction should have comment or be unexported (golint)
  • Line 192: warning: exported method LesApiBackend.GetTransaction should have comment or be unexported (golint)
  • Line 196: warning: exported method LesApiBackend.GetPoolNonce should have comment or be unexported (golint)
  • Line 200: warning: exported method LesApiBackend.Stats should have comment or be unexported (golint)
  • Line 204: warning: exported method LesApiBackend.TxPoolContent should have comment or be unexported (golint)
  • Line 208: warning: exported method LesApiBackend.SubscribeNewTxsEvent should have comment or be unexported (golint)
  • Line 212: warning: exported method LesApiBackend.SubscribeChainEvent should have comment or be unexported (golint)
  • Line 216: warning: exported method LesApiBackend.SubscribeChainHeadEvent should have comment or be unexported (golint)
  • Line 220: warning: exported method LesApiBackend.SubscribeChainSideEvent should have comment or be unexported (golint)
  • Line 224: warning: exported method LesApiBackend.SubscribeLogsEvent should have comment or be unexported (golint)
  • Line 228: warning: exported method LesApiBackend.SubscribePendingLogsEvent should have comment or be unexported (golint)
  • Line 235: warning: exported method LesApiBackend.SubscribeRemovedLogsEvent should have comment or be unexported (golint)
  • Line 239: warning: exported method LesApiBackend.Downloader should have comment or be unexported (golint)
  • Line 243: warning: exported method LesApiBackend.ProtocolVersion should have comment or be unexported (golint)
  • Line 247: warning: exported method LesApiBackend.SuggestPrice should have comment or be unexported (golint)
  • Line 251: warning: exported method LesApiBackend.ChainDb should have comment or be unexported (golint)
  • Line 255: warning: exported method LesApiBackend.AccountManager should have comment or be unexported (golint)
  • Line 259: warning: exported method LesApiBackend.ExtRPCEnabled should have comment or be unexported (golint)
  • Line 263: warning: exported method LesApiBackend.RPCGasCap should have comment or be unexported (golint)
  • Line 267: warning: exported method LesApiBackend.BloomStatus should have comment or be unexported (golint)
  • Line 275: warning: exported method LesApiBackend.ServiceFilter should have comment or be unexported (golint)

• go-ethercore/les/peer.go
  • Line 147: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 838: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• go-ethercore/metrics/log.go
  • Line 7: warning: exported type Logger should have comment or be unexported (golint)
  • Line 11: warning: exported function Log should have comment or be unexported (golint)
  • Line 15: warning: comment on exported function LogScaled should be of the form "LogScaled ..." (golint)

• go-ethercore/metrics/meter.go
  • Line 8: warning: comment on exported type Meter should be of the form "Meter ..." (with optional leading article) (golint)
  • Line 152: warning: comment on exported method NilMeter.Rate15 should be of the form "Rate15 ..." (golint)

• go-ethercore/metrics/registry.go
  • Line 53: warning: comment on exported type StandardRegistry should be of the form "StandardRegistry ..." (with optional leading article) (golint)
  • Line 60: warning: comment on exported function NewRegistry should be of the form "NewRegistry ..." (golint)
  • Line 65: warning: comment on exported method StandardRegistry.Each should be of the form "Each ..." (golint)
  • Line 79: warning: comment on exported method StandardRegistry.GetOrRegister should be of the form "GetOrRegister ..." (golint)
  • Line 104: warning: comment on exported method StandardRegistry.RunHealthchecks should be of the form "RunHealthchecks ..." (golint)
  • Line 184: warning: comment on exported method StandardRegistry.UnregisterAll should be of the form "UnregisterAll ..." (golint)
  • Line 228: warning: exported type PrefixedRegistry should have comment or be unexported (golint)
  • Line 233: warning: exported function NewPrefixedRegistry should have comment or be unexported (golint)
  • Line 240: warning: exported function NewPrefixedChildRegistry should have comment or be unexported (golint)
  • Line 247: warning: comment on exported method PrefixedRegistry.Each should be of the form "Each ..." (golint)
  • Line 279: warning: comment on exported method PrefixedRegistry.GetOrRegister should be of the form "GetOrRegister ..." (golint)
  • Line 293: warning: comment on exported method PrefixedRegistry.RunHealthchecks should be of the form "RunHealthchecks ..." (golint)
  • Line 309: warning: comment on exported method PrefixedRegistry.UnregisterAll should be of the form "UnregisterAll ..." (golint)
  • Line 315: warning: exported var DefaultRegistry should have comment or be unexported (golint)
  • Line 320: warning: comment on exported function Each should be of the form "Each ..." (golint)
  • Line 330: warning: comment on exported function GetOrRegister should be of the form "GetOrRegister ..." (golint)
  • Line 342: warning: comment on exported function MustRegister should be of the form "MustRegister ..." (golint)
  • Line 350: warning: comment on exported function RunHealthchecks should be of the form "RunHealthchecks ..." (golint)

• go-ethercore/p2p/simulations/mocker.go
  • Line 39: warning: comment on exported function LookupMocker should be of the form "LookupMocker ..." (golint)
  • Line 44: warning: comment on exported function GetMockerList should be of the form "GetMockerList ..." (golint)

• go-ethercore/metrics/gauge.go
  • Line 5: warning: comment on exported type Gauge should be of the form "Gauge ..." (with optional leading article) (golint)

• go-ethercore/metrics/json.go
  • Line 29: warning: exported method PrefixedRegistry.MarshalJSON should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• go-ethercore/consensus/ethash/progpow.go
  • Line 312: warning: ineffectual assignment to srcCounter (ineffassign)
  • Line 313: warning: ineffectual assignment to dstCounter (ineffassign)
  • Line 319: warning: ineffectual assignment to index (ineffassign)

misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)