Report for github.com/fcg-xvii/go-tools
A+ Excellent! Found 16 issues across 31 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-tools/sip/asterisk/ami/client.go
- Line 218: warning: cyclomatic complexity 17 of function (*client).Start() is high (> 15) (gocyclo)
golint48%
Golint is a linter for Go source code.
-
-
go-tools/containers/queue.go
- Line 8: warning: exported function NewQueue should have comment or be unexported (golint)
- Line 12: warning: exported type Queue should have comment or be unexported (golint)
- Line 18: warning: exported method Queue.Size should have comment or be unexported (golint)
- Line 22: warning: exported method Queue.Push should have comment or be unexported (golint)
- Line 35: warning: exported method Queue.Pop should have comment or be unexported (golint)
-
-
go-tools/store/string.go
- Line 5: warning: exported type StringCallCreate should have comment or be unexported (golint)
- Line 6: warning: exported type StringCallCreateMulti should have comment or be unexported (golint)
- Line 7: warning: exported type StringCallCheck should have comment or be unexported (golint)
- Line 9: warning: exported function StringFromMap should have comment or be unexported (golint)
- Line 16: warning: exported function StringNew should have comment or be unexported (golint)
- Line 23: warning: exported type StoreString should have comment or be unexported (golint)
- Line 32: warning: exported method StoreString.Delete should have comment or be unexported (golint)
- Line 38: warning: exported method StoreString.DeleteMulti should have comment or be unexported (golint)
- Line 56: warning: exported method StoreString.Set should have comment or be unexported (golint)
- Line 62: warning: exported method StoreString.SetMulti should have comment or be unexported (golint)
- Line 73: warning: exported method StoreString.Get should have comment or be unexported (golint)
- Line 80: warning: exported method StoreString.GetCreate should have comment or be unexported (golint)
- Line 96: warning: exported method StoreString.GetCreateMulti should have comment or be unexported (golint)
- Line 114: warning: exported method StoreString.GetCheck should have comment or be unexported (golint)
- Line 137: warning: exported method StoreString.Len should have comment or be unexported (golint)
- Line 144: warning: exported method StoreString.Keys should have comment or be unexported (golint)
- Line 154: warning: exported method StoreString.Clear should have comment or be unexported (golint)
- Line 160: warning: exported method StoreString.Map should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/conf.go
- Line 6: warning: don't use underscores in Go names; const max_client_uuid should be maxClientUUID (golint)
- Line 10: warning: exported var RequestTimeoutDefault should have comment or be unexported (golint)
-
-
go-tools/store/store.go
- Line 7: warning: exported type CallCreate should have comment or be unexported (golint)
- Line 8: warning: exported type CallCreateMulti should have comment or be unexported (golint)
- Line 9: warning: exported type CallCheck should have comment or be unexported (golint)
- Line 11: warning: exported function FromMap should have comment or be unexported (golint)
- Line 18: warning: exported function New should have comment or be unexported (golint)
- Line 25: warning: exported type Store should have comment or be unexported (golint)
- Line 34: warning: exported method Store.Delete should have comment or be unexported (golint)
- Line 40: warning: exported method Store.DeleteMulti should have comment or be unexported (golint)
- Line 58: warning: exported method Store.Set should have comment or be unexported (golint)
- Line 64: warning: exported method Store.SetMulti should have comment or be unexported (golint)
- Line 75: warning: exported method Store.Get should have comment or be unexported (golint)
- Line 82: warning: exported method Store.GetCreate should have comment or be unexported (golint)
- Line 98: warning: exported method Store.GetCreateMulti should have comment or be unexported (golint)
- Line 116: warning: exported method Store.GetCheck should have comment or be unexported (golint)
- Line 139: warning: exported method Store.Len should have comment or be unexported (golint)
- Line 146: warning: exported method Store.Keys should have comment or be unexported (golint)
- Line 156: warning: exported method Store.Clear should have comment or be unexported (golint)
- Line 162: warning: exported method Store.Map should have comment or be unexported (golint)
-
-
go-tools/json/jsonmap/jsonmap.go
- Line 136: warning: comment on exported method JSONMap.Slice should be of the form "Slice ..." (golint)
-
-
go-tools/sip/asterisk/ami/event_listener.go
- Line 5: warning: exported type EventListener should have comment or be unexported (golint)
-
-
go-tools/cache/cachemap.go
- Line 9: warning: exported type CallCreate should have comment or be unexported (golint)
- Line 10: warning: exported type CallCreateNew should have comment or be unexported (golint)
- Line 11: warning: exported type CallCheck should have comment or be unexported (golint)
- Line 13: warning: exported function NewMap should have comment or be unexported (golint)
- Line 25: warning: exported type CacheMap should have comment or be unexported (golint)
- Line 129: warning: exported method CacheMap.DeleteMulti should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/client.go
- Line 15: warning: exported type State should have comment or be unexported (golint)
- Line 18: warning: exported const StateStopped should have comment (or a comment on this block) or be unexported (golint)
- Line 45: warning: context.Context should be the first parameter of a function (golint)
- Line 45: warning: exported function New should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/event.go
- Line 15: warning: exported type Event should have comment or be unexported (golint)
- Line 20: warning: exported method Event.Name should have comment or be unexported (golint)
- Line 24: warning: exported method Event.UUID should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/response.go
- Line 12: warning: exported type Response should have comment or be unexported (golint)
- Line 16: warning: exported method Response.IsError should have comment or be unexported (golint)
- Line 20: warning: exported method Response.ErrorMessage should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/originate.go
- Line 13: warning: exported method Client.Originate should have comment or be unexported (golint)
- Line 35: warning: exported type OriginateRequest should have comment or be unexported (golint)
- Line 49: warning: exported method OriginateRequest.Request should have comment or be unexported (golint)
- Line 81: warning: exported type Originate should have comment or be unexported (golint)
- Line 124: warning: exported method Originate.IsFinished should have comment or be unexported (golint)
- Line 128: warning: exported method Originate.Events should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/request.go
- Line 9: warning: exported function InitRequest should have comment or be unexported (golint)
- Line 17: warning: exported type Request should have comment or be unexported (golint)
- Line 24: warning: exported method Request.SetParam should have comment or be unexported (golint)
- Line 30: warning: exported method Request.SetVariable should have comment or be unexported (golint)
- Line 37: warning: exported method Request.SetVariables should have comment or be unexported (golint)
-
-
go-tools/text/checker/checker.go
- Line 8: warning: exported type Type should have comment or be unexported (golint)
- Line 11: warning: exported const Undefined should have comment (or a comment on this block) or be unexported (golint)
- Line 34: warning: exported function Check should have comment or be unexported (golint)
- Line 44: warning: exported function CheckEmail should have comment or be unexported (golint)
- Line 48: warning: exported function CheckPhone should have comment or be unexported (golint)
-
-
go-tools/containers/concurrent/queue.go
- Line 9: warning: exported function NewQueue should have comment or be unexported (golint)
- Line 16: warning: exported type Queue should have comment or be unexported (golint)
- Line 21: warning: exported method Queue.Size should have comment or be unexported (golint)
- Line 28: warning: exported method Queue.Push should have comment or be unexported (golint)
- Line 34: warning: exported method Queue.Pop should have comment or be unexported (golint)
-
-
go-tools/database/nosql/nosql.go
- Line 60: warning: exported method NoSQL.CallObject should have comment or be unexported (golint)
-
-
go-tools/sip/asterisk/ami/action.go
- Line 8: warning: exported type ActionData should have comment or be unexported (golint)
- Line 23: warning: exported method ActionData.ActionID should have comment or be unexported (golint)
ineffassign87%
IneffAssign detects ineffectual assignments in Go code.
-
-
go-tools/store/store.go
- Line 121: warning: ineffectual assignment to key (ineffassign)
-
-
go-tools/store/string.go
- Line 119: warning: ineffectual assignment to key (ineffassign)
-
-
go-tools/cache/cachemap.go
- Line 190: warning: ineffectual assignment to key (ineffassign)
-
-
go-tools/sip/asterisk/ami/client.go
- Line 389: warning: ineffectual assignment to accepted (ineffassign)