Preparing report...

Report for github.com/fleetdm/fleet

A+    Excellent!    Found 219 issues across 409 files

Tweet

gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint52%

Golint is a linter for Go source code.

    • fleet/server/datastore/inmem/labels.go
    • Line 14: warning: exported method Datastore.NewLabel should have comment or be unexported (golint)
    • Line 31: warning: exported method Datastore.ListLabelsForHost should have comment or be unexported (golint)
    • Line 48: warning: exported method Datastore.LabelQueriesForHost should have comment or be unexported (golint)
    • Line 70: warning: exported method Datastore.RecordLabelQueryExecutions should have comment or be unexported (golint)
    • Line 107: warning: exported method Datastore.Label should have comment or be unexported (golint)
    • Line 118: warning: exported method Datastore.ListLabels should have comment or be unexported (golint)
    • Line 154: warning: exported method Datastore.SearchLabels should have comment or be unexported (golint)
    • Line 180: warning: exported method Datastore.ListHostsInLabel should have comment or be unexported (golint)
    • Line 195: warning: exported method Datastore.ListUniqueHostsInLabels should have comment or be unexported (golint)
    • Line 220: warning: exported method Datastore.SaveLabel should have comment or be unexported (golint)
    • fleet/server/kolide/queries.go
    • Line 13: warning: exported type QueryStore should have comment or be unexported (golint)
    • Line 39: warning: exported type QueryService should have comment or be unexported (golint)
    • Line 63: warning: exported type QueryPayload should have comment or be unexported (golint)
    • Line 69: warning: exported type Query should have comment or be unexported (golint)
    • Line 99: warning: exported const QueryKind should have comment (or a comment on this block) or be unexported (golint)
    • Line 102: warning: exported type QueryObject should have comment or be unexported (golint)
    • Line 107: warning: exported type QuerySpec should have comment or be unexported (golint)
    • Line 113: warning: exported function LoadQueriesFromYaml should have comment or be unexported (golint)
    • Line 134: warning: exported function WriteQueriesToYaml should have comment or be unexported (golint)
    • fleet/server/kolide/scheduled_queries.go
    • Line 10: warning: exported type ScheduledQueryStore should have comment or be unexported (golint)
    • Line 18: warning: exported type ScheduledQueryService should have comment or be unexported (golint)
    • Line 26: warning: exported type ScheduledQuery should have comment or be unexported (golint)
    • Line 44: warning: exported type ScheduledQueryPayload should have comment or be unexported (golint)
    • Line 56: warning: exported type ScheduledQueryStats should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/packs.go
    • Line 9: warning: exported method Datastore.PackByName should have comment or be unexported (golint)
    • Line 20: warning: exported method Datastore.NewPack should have comment or be unexported (golint)
    • Line 39: warning: exported method Datastore.SavePack should have comment or be unexported (golint)
    • Line 52: warning: exported method Datastore.Pack should have comment or be unexported (golint)
    • Line 64: warning: exported method Datastore.ListPacks should have comment or be unexported (golint)
    • Line 101: warning: exported method Datastore.AddLabelToPack should have comment or be unexported (golint)
    • Line 123: warning: exported method Datastore.AddHostToPack should have comment or be unexported (golint)
    • Line 146: warning: exported method Datastore.ListLabelsForPack should have comment or be unexported (golint)
    • Line 159: warning: exported method Datastore.RemoveLabelFromPack should have comment or be unexported (golint)
    • Line 178: warning: exported method Datastore.RemoveHostFromPack should have comment or be unexported (golint)
    • Line 197: warning: exported method Datastore.ListHostsInPack should have comment or be unexported (golint)
    • Line 253: warning: exported method Datastore.ListExplicitHostsInPack should have comment or be unexported (golint)
    • fleet/server/mock/datastore_query_results.go
    • Line 13: warning: exported type WriteResultFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type ReadChannelFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type HealthCheckFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type QueryResultStore should have comment or be unexported (golint)
    • Line 30: warning: exported method QueryResultStore.WriteResult should have comment or be unexported (golint)
    • Line 35: warning: exported method QueryResultStore.ReadChannel should have comment or be unexported (golint)
    • Line 40: warning: exported method QueryResultStore.HealthCheck should have comment or be unexported (golint)
    • fleet/server/kolide/osquery_options.go
    • Line 8: warning: exported type OsqueryOptionsStore should have comment or be unexported (golint)
    • Line 14: warning: exported type OsqueryOptionsService should have comment or be unexported (golint)
    • Line 19: warning: exported type OptionsObject should have comment or be unexported (golint)
    • Line 24: warning: exported type OptionsSpec should have comment or be unexported (golint)
    • Line 29: warning: exported type OptionsOverrides should have comment or be unexported (golint)
    • Line 34: warning: exported const OptionsKind should have comment (or a comment on this block) or be unexported (golint)
    • fleet/server/mock/datastore_appconfig.go
    • Line 9: warning: exported type NewAppConfigFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type AppConfigFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type SaveAppConfigFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type VerifyEnrollSecretFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type ApplyEnrollSecretSpecFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type GetEnrollSecretSpecFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type AppConfigStore should have comment or be unexported (golint)
    • Line 41: warning: exported method AppConfigStore.NewAppConfig should have comment or be unexported (golint)
    • Line 46: warning: exported method AppConfigStore.AppConfig should have comment or be unexported (golint)
    • Line 51: warning: exported method AppConfigStore.SaveAppConfig should have comment or be unexported (golint)
    • Line 56: warning: exported method AppConfigStore.VerifyEnrollSecret should have comment or be unexported (golint)
    • Line 61: warning: exported method AppConfigStore.ApplyEnrollSecretSpec should have comment or be unexported (golint)
    • Line 66: warning: exported method AppConfigStore.GetEnrollSecretSpec should have comment or be unexported (golint)
    • fleet/server/kolide/import_config.go
    • Line 12: warning: exported type ImportConfigService should have comment or be unexported (golint)
    • Line 23: warning: exported const OptionsSection should have comment (or a comment on this block) or be unexported (golint)
    • Line 37: warning: exported const PackDuplicate should have comment (or a comment on this block) or be unexported (golint)
    • Line 96: warning: exported const GlobPacks should have comment (or a comment on this block) or be unexported (golint)
    • Line 132: warning: comment on exported type DecoratorConfig should be of the form "DecoratorConfig ..." (with optional leading article) (golint)
    • Line 151: warning: exported type OptionNameToValueMap should have comment or be unexported (golint)
    • Line 152: warning: exported type QueryNameToQueryDetailsMap should have comment or be unexported (golint)
    • Line 153: warning: exported type PackNameMap should have comment or be unexported (golint)
    • Line 154: warning: exported type FIMCategoryToPaths should have comment or be unexported (golint)
    • Line 155: warning: exported type PackNameToPackDetails should have comment or be unexported (golint)
    • Line 230: warning: exported method OsQueryConfigInt.UnmarshalJSON should have comment or be unexported (golint)
    • fleet/server/mock/datastore_users_helpers.go
    • Line 5: warning: exported function UserByEmailWithUser should have comment or be unexported (golint)
    • Line 11: warning: exported function UserWithEmailNotFound should have comment or be unexported (golint)
    • Line 17: warning: exported function UserWithID should have comment or be unexported (golint)
    • fleet/server/kolide/targets.go
    • Line 8: warning: exported type TargetSearchResults should have comment or be unexported (golint)
    • Line 34: warning: exported type TargetService should have comment or be unexported (golint)
    • Line 45: warning: exported type TargetStore should have comment or be unexported (golint)
    • Line 55: warning: exported type TargetType should have comment or be unexported (golint)
    • Line 58: warning: exported const TargetLabel should have comment (or a comment on this block) or be unexported (golint)
    • Line 62: warning: exported type Target should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/password_reset.go
    • Line 8: warning: exported method Datastore.NewPasswordResetRequest should have comment or be unexported (golint)
    • Line 25: warning: exported method Datastore.SavePasswordResetRequest should have comment or be unexported (golint)
    • Line 48: warning: exported method Datastore.DeletePasswordResetRequest should have comment or be unexported (golint)
    • Line 57: warning: exported method Datastore.DeletePasswordResetRequestsForUser should have comment or be unexported (golint)
    • Line 69: warning: exported method Datastore.FindPassswordResetByID should have comment or be unexported (golint)
    • Line 83: warning: exported method Datastore.FindPassswordResetsByUserID should have comment or be unexported (golint)
    • Line 99: warning: exported method Datastore.FindPassswordResetByToken should have comment or be unexported (golint)
    • Line 114: warning: exported method Datastore.FindPassswordResetByTokenAndUserID should have comment or be unexported (golint)
    • fleet/server/kolide/datastore.go
    • Line 32: warning: exported type MigrationStatus should have comment or be unexported (golint)
    • Line 35: warning: exported const NoMigrationsCompleted should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: exported function IsNotFound should have comment or be unexported (golint)
    • Line 54: warning: comment on exported type AlreadyExistsError should be of the form "AlreadyExistsError ..." (with optional leading article) (golint)
    • Line 68: warning: exported function IsForeignKey should have comment or be unexported (golint)
    • Line 76: warning: exported type OptionalArg should have comment or be unexported (golint)
    • fleet/server/service/frontend.go
    • Line 22: warning: exported function ServeFrontend should have comment or be unexported (golint)
    • Line 51: warning: exported function ServeStaticAssets should have comment or be unexported (golint)
    • fleet/server/kolide/campaigns.go
    • Line 60: warning: exported const QueryWaiting should have comment (or a comment on this block) or be unexported (golint)
    • Line 91: warning: exported const ExecutionWaiting should have comment (or a comment on this block) or be unexported (golint)
    • fleet/server/mock/datastore_osquery_options.go
    • Line 13: warning: exported type ApplyOptionsFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type GetOptionsFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type OptionsForPlatformFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type OsqueryOptionsStore should have comment or be unexported (golint)
    • Line 30: warning: exported method OsqueryOptionsStore.ApplyOptions should have comment or be unexported (golint)
    • Line 35: warning: exported method OsqueryOptionsStore.GetOptions should have comment or be unexported (golint)
    • Line 40: warning: exported method OsqueryOptionsStore.OptionsForPlatform should have comment or be unexported (golint)
    • fleet/server/kolide/hosts.go
    • Line 11: warning: exported type HostStatus should have comment or be unexported (golint)
    • Line 38: warning: exported type HostStore should have comment or be unexported (golint)
    • Line 81: warning: exported type HostService should have comment or be unexported (golint)
    • Line 96: warning: exported type HostListOptions should have comment or be unexported (golint)
    • Line 108: warning: exported type Host should have comment or be unexported (golint)
    • Line 173: warning: exported const HostKind should have comment (or a comment on this block) or be unexported (golint)
    • Line 221: warning: exported method Host.IsNew should have comment or be unexported (golint)
    • fleet/server/mail/users.go
    • Line 8: warning: exported type ChangeEmailMailer should have comment or be unexported (golint)
    • Line 14: warning: exported method ChangeEmailMailer.Message should have comment or be unexported (golint)
    • Line 27: warning: exported type PasswordResetMailer should have comment or be unexported (golint)
    • Line 36: warning: exported method PasswordResetMailer.Message should have comment or be unexported (golint)
    • fleet/server/service/client.go
    • Line 25: warning: exported type Client should have comment or be unexported (golint)
    • Line 34: warning: exported type ClientOption should have comment or be unexported (golint)
    • Line 36: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 95: warning: exported function EnableClientDebug should have comment or be unexported (golint)
    • Line 132: warning: exported method Client.Do should have comment or be unexported (golint)
    • Line 141: warning: exported method Client.AuthenticatedDo should have comment or be unexported (golint)
    • Line 155: warning: exported method Client.SetToken should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/sessions.go
    • Line 9: warning: exported method Datastore.SessionByKey should have comment or be unexported (golint)
    • Line 21: warning: exported method Datastore.SessionByID should have comment or be unexported (golint)
    • Line 31: warning: exported method Datastore.ListSessionsForUser should have comment or be unexported (golint)
    • Line 45: warning: exported method Datastore.NewSession should have comment or be unexported (golint)
    • Line 59: warning: exported method Datastore.DestroySession should have comment or be unexported (golint)
    • Line 67: warning: exported method Datastore.DestroyAllSessionsForUser should have comment or be unexported (golint)
    • Line 76: warning: exported method Datastore.MarkSessionAccessed should have comment or be unexported (golint)
    • fleet/server/logging/mock/kinesis.go
    • Line 10: warning: exported type PutRecordsFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type DescribeStreamFunc should have comment or be unexported (golint)
    • Line 12: warning: exported type KinesisMock should have comment or be unexported (golint)
    • Line 21: warning: exported method KinesisMock.PutRecords should have comment or be unexported (golint)
    • Line 26: warning: exported method KinesisMock.DescribeStream should have comment or be unexported (golint)
    • fleet/server/mock/datastore_hosts.go
    • Line 13: warning: exported type NewHostFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type SaveHostFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type DeleteHostFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type HostFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type HostByIdentifierFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type ListHostsFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type EnrollHostFunc should have comment or be unexported (golint)
    • Line 27: warning: exported type AuthenticateHostFunc should have comment or be unexported (golint)
    • Line 29: warning: exported type MarkHostSeenFunc should have comment or be unexported (golint)
    • Line 31: warning: exported type MarkHostsSeenFunc should have comment or be unexported (golint)
    • Line 33: warning: exported type CleanupIncomingHostsFunc should have comment or be unexported (golint)
    • Line 35: warning: exported type SearchHostsFunc should have comment or be unexported (golint)
    • Line 37: warning: exported type GenerateHostStatusStatisticsFunc should have comment or be unexported (golint)
    • Line 39: warning: exported type DistributedQueriesForHostFunc should have comment or be unexported (golint)
    • Line 41: warning: exported type HostIDsByNameFunc should have comment or be unexported (golint)
    • Line 43: warning: exported type SaveHostAdditionalFunc should have comment or be unexported (golint)
    • Line 45: warning: exported type HostStore should have comment or be unexported (golint)
    • Line 95: warning: exported method HostStore.NewHost should have comment or be unexported (golint)
    • Line 100: warning: exported method HostStore.SaveHost should have comment or be unexported (golint)
    • Line 105: warning: exported method HostStore.DeleteHost should have comment or be unexported (golint)
    • Line 110: warning: exported method HostStore.Host should have comment or be unexported (golint)
    • Line 115: warning: exported method HostStore.HostByIdentifier should have comment or be unexported (golint)
    • Line 120: warning: exported method HostStore.ListHosts should have comment or be unexported (golint)
    • Line 125: warning: exported method HostStore.EnrollHost should have comment or be unexported (golint)
    • Line 130: warning: exported method HostStore.AuthenticateHost should have comment or be unexported (golint)
    • Line 135: warning: exported method HostStore.MarkHostSeen should have comment or be unexported (golint)
    • Line 140: warning: exported method HostStore.MarkHostsSeen should have comment or be unexported (golint)
    • Line 145: warning: exported method HostStore.CleanupIncomingHosts should have comment or be unexported (golint)
    • Line 150: warning: exported method HostStore.SearchHosts should have comment or be unexported (golint)
    • Line 155: warning: exported method HostStore.GenerateHostStatusStatistics should have comment or be unexported (golint)
    • Line 160: warning: exported method HostStore.DistributedQueriesForHost should have comment or be unexported (golint)
    • Line 165: warning: exported method HostStore.HostIDsByName should have comment or be unexported (golint)
    • Line 170: warning: exported method HostStore.SaveHostAdditional should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/queries.go
    • Line 10: warning: exported method Datastore.NewQuery should have comment or be unexported (golint)
    • Line 29: warning: exported method Datastore.SaveQuery should have comment or be unexported (golint)
    • Line 65: warning: exported method Datastore.Query should have comment or be unexported (golint)
    • Line 83: warning: exported method Datastore.ListQueries should have comment or be unexported (golint)
    • fleet/server/kolide/app.go
    • Line 62: warning: exported type SMTPAuthType should have comment or be unexported (golint)
    • Line 65: warning: exported const AuthTypeUserNamePassword should have comment (or a comment on this block) or be unexported (golint)
    • Line 80: warning: exported type SMTPAuthMethod should have comment or be unexported (golint)
    • Line 83: warning: exported const AuthMethodPlain should have comment (or a comment on this block) or be unexported (golint)
    • Line 173: warning: exported const AppConfigKind should have comment (or a comment on this block) or be unexported (golint)
    • Line 276: warning: exported type HostSettings should have comment or be unexported (golint)
    • Line 280: warning: exported type OrderDirection should have comment or be unexported (golint)
    • Line 283: warning: exported const OrderAscending should have comment (or a comment on this block) or be unexported (golint)
    • Line 316: warning: exported const EnrollSecretKind should have comment (or a comment on this block) or be unexported (golint)
    • fleet/server/mock/datastore_scheduled_queries.go
    • Line 9: warning: exported type ListScheduledQueriesInPackFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type NewScheduledQueryFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type SaveScheduledQueryFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type DeleteScheduledQueryFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type ScheduledQueryFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type ScheduledQueryStore should have comment or be unexported (golint)
    • Line 36: warning: exported method ScheduledQueryStore.ListScheduledQueriesInPack should have comment or be unexported (golint)
    • Line 41: warning: exported method ScheduledQueryStore.NewScheduledQuery should have comment or be unexported (golint)
    • Line 46: warning: exported method ScheduledQueryStore.SaveScheduledQuery should have comment or be unexported (golint)
    • Line 51: warning: exported method ScheduledQueryStore.DeleteScheduledQuery should have comment or be unexported (golint)
    • Line 56: warning: exported method ScheduledQueryStore.ScheduledQuery should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/carves.go
    • Line 13: warning: exported method Datastore.NewCarve should have comment or be unexported (golint)
    • Line 79: warning: exported method Datastore.CleanupCarves should have comment or be unexported (golint)
    • Line 157: warning: exported method Datastore.Carve should have comment or be unexported (golint)
    • Line 173: warning: exported method Datastore.CarveBySessionId should have comment or be unexported (golint)
    • Line 189: warning: exported method Datastore.CarveByName should have comment or be unexported (golint)
    • Line 205: warning: exported method Datastore.ListCarves should have comment or be unexported (golint)
    • Line 223: warning: exported method Datastore.NewBlock should have comment or be unexported (golint)
    • Line 249: warning: exported method Datastore.GetBlock should have comment or be unexported (golint)
    • fleet/server/mail/mail.go
    • Line 19: warning: exported function NewService should have comment or be unexported (golint)
    • Line 29: warning: exported function Test should have comment or be unexported (golint)
    • Line 49: warning: exported const PortSSL should have comment (or a comment on this block) or be unexported (golint)
    • Line 83: warning: exported function LoginAuth should have comment or be unexported (golint)
    • Line 245: warning: exported method SMTPTestMailer.Message should have comment or be unexported (golint)
    • fleet/server/mock/datastore_campaigns.go
    • Line 13: warning: exported type NewDistributedQueryCampaignFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type DistributedQueryCampaignFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type SaveDistributedQueryCampaignFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type DistributedQueryCampaignTargetIDsFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type NewDistributedQueryCampaignTargetFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type CleanupDistributedQueryCampaignsFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type CampaignStore should have comment or be unexported (golint)
    • Line 45: warning: exported method CampaignStore.NewDistributedQueryCampaign should have comment or be unexported (golint)
    • Line 50: warning: exported method CampaignStore.DistributedQueryCampaign should have comment or be unexported (golint)
    • Line 55: warning: exported method CampaignStore.SaveDistributedQueryCampaign should have comment or be unexported (golint)
    • Line 60: warning: exported method CampaignStore.DistributedQueryCampaignTargetIDs should have comment or be unexported (golint)
    • Line 65: warning: exported method CampaignStore.NewDistributedQueryCampaignTarget should have comment or be unexported (golint)
    • Line 70: warning: exported method CampaignStore.CleanupDistributedQueryCampaigns should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/scheduled_queries.go
    • Line 10: warning: exported method Datastore.ListScheduledQueriesInPack should have comment or be unexported (golint)
    • Line 42: warning: exported method Datastore.NewScheduledQuery should have comment or be unexported (golint)
    • Line 95: warning: exported method Datastore.SaveScheduledQuery should have comment or be unexported (golint)
    • Line 115: warning: exported method Datastore.DeleteScheduledQuery should have comment or be unexported (golint)
    • Line 119: warning: exported method Datastore.ScheduledQuery should have comment or be unexported (golint)
    • fleet/server/mock/datastore_packs.go
    • Line 9: warning: exported type ApplyPackSpecsFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type GetPackSpecsFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type GetPackSpecFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type NewPackFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type SavePackFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type DeletePackFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type PackFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type ListPacksFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type PackByNameFunc should have comment or be unexported (golint)
    • Line 27: warning: exported type AddLabelToPackFunc should have comment or be unexported (golint)
    • Line 29: warning: exported type RemoveLabelFromPackFunc should have comment or be unexported (golint)
    • Line 31: warning: exported type ListLabelsForPackFunc should have comment or be unexported (golint)
    • Line 33: warning: exported type AddHostToPackFunc should have comment or be unexported (golint)
    • Line 35: warning: exported type RemoveHostFromPackFunc should have comment or be unexported (golint)
    • Line 37: warning: exported type ListPacksForHostFunc should have comment or be unexported (golint)
    • Line 39: warning: exported type ListHostsInPackFunc should have comment or be unexported (golint)
    • Line 41: warning: exported type ListExplicitHostsInPackFunc should have comment or be unexported (golint)
    • Line 43: warning: exported type PackStore should have comment or be unexported (golint)
    • Line 96: warning: exported method PackStore.ApplyPackSpecs should have comment or be unexported (golint)
    • Line 101: warning: exported method PackStore.GetPackSpecs should have comment or be unexported (golint)
    • Line 106: warning: exported method PackStore.GetPackSpec should have comment or be unexported (golint)
    • Line 111: warning: exported method PackStore.NewPack should have comment or be unexported (golint)
    • Line 116: warning: exported method PackStore.SavePack should have comment or be unexported (golint)
    • Line 121: warning: exported method PackStore.DeletePack should have comment or be unexported (golint)
    • Line 126: warning: exported method PackStore.Pack should have comment or be unexported (golint)
    • Line 131: warning: exported method PackStore.ListPacks should have comment or be unexported (golint)
    • Line 136: warning: exported method PackStore.PackByName should have comment or be unexported (golint)
    • Line 141: warning: exported method PackStore.AddLabelToPack should have comment or be unexported (golint)
    • Line 146: warning: exported method PackStore.RemoveLabelFromPack should have comment or be unexported (golint)
    • Line 151: warning: exported method PackStore.ListLabelsForPack should have comment or be unexported (golint)
    • Line 156: warning: exported method PackStore.AddHostToPack should have comment or be unexported (golint)
    • Line 161: warning: exported method PackStore.RemoveHostFromPack should have comment or be unexported (golint)
    • Line 166: warning: exported method PackStore.ListPacksForHost should have comment or be unexported (golint)
    • Line 171: warning: exported method PackStore.ListHostsInPack should have comment or be unexported (golint)
    • Line 176: warning: exported method PackStore.ListExplicitHostsInPack should have comment or be unexported (golint)
    • fleet/server/kolide/sessions.go
    • Line 35: warning: exported type Auth should have comment or be unexported (golint)
    • Line 40: warning: exported type SessionService should have comment or be unexported (golint)
    • Line 63: warning: exported type SSOSession should have comment or be unexported (golint)
    • fleet/server/mock/datastore_users.go
    • Line 9: warning: exported type NewUserFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type UserFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type ListUsersFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type UserByEmailFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type UserByIDFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type SaveUserFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type PendingEmailChangeFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type ConfirmPendingEmailChangeFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type UserStore should have comment or be unexported (golint)
    • Line 51: warning: exported method UserStore.NewUser should have comment or be unexported (golint)
    • Line 56: warning: exported method UserStore.User should have comment or be unexported (golint)
    • Line 61: warning: exported method UserStore.ListUsers should have comment or be unexported (golint)
    • Line 66: warning: exported method UserStore.UserByEmail should have comment or be unexported (golint)
    • Line 71: warning: exported method UserStore.UserByID should have comment or be unexported (golint)
    • Line 76: warning: exported method UserStore.SaveUser should have comment or be unexported (golint)
    • Line 81: warning: exported method UserStore.PendingEmailChange should have comment or be unexported (golint)
    • Line 86: warning: exported method UserStore.ConfirmPendingEmailChange should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/mysql.go
    • Line 204: warning: exported method Datastore.Begin should have comment or be unexported (golint)
    • Line 208: warning: exported method Datastore.Name should have comment or be unexported (golint)
    • Line 212: warning: exported method Datastore.MigrateTables should have comment or be unexported (golint)
    • Line 216: warning: exported method Datastore.MigrateData should have comment or be unexported (golint)
    • Line 220: warning: exported method Datastore.MigrationStatus should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/migrations/data/20170314151620_FixCentosLabel.go
    • Line 13: warning: exported function Up_20170314151620 should have comment or be unexported (golint)
    • Line 13: warning: don't use underscores in Go names; func Up_20170314151620 should be Up20170314151620 (golint)
    • Line 15: warning: don't use underscores in Go names; var label_query should be labelQuery (golint)
    • Line 30: warning: exported function Down_20170314151620 should have comment or be unexported (golint)
    • Line 30: warning: don't use underscores in Go names; func Down_20170314151620 should be Down20170314151620 (golint)
    • fleet/server/mock/datastore_sessions.go
    • Line 9: warning: exported type SessionByKeyFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type SessionByIDFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type ListSessionsForUserFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type NewSessionFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type DestroySessionFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type DestroyAllSessionsForUserFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type MarkSessionAccessedFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type SessionStore should have comment or be unexported (golint)
    • Line 46: warning: exported method SessionStore.SessionByKey should have comment or be unexported (golint)
    • Line 51: warning: exported method SessionStore.SessionByID should have comment or be unexported (golint)
    • Line 56: warning: exported method SessionStore.ListSessionsForUser should have comment or be unexported (golint)
    • Line 61: warning: exported method SessionStore.NewSession should have comment or be unexported (golint)
    • Line 66: warning: exported method SessionStore.DestroySession should have comment or be unexported (golint)
    • Line 71: warning: exported method SessionStore.DestroyAllSessionsForUser should have comment or be unexported (golint)
    • Line 76: warning: exported method SessionStore.MarkSessionAccessed should have comment or be unexported (golint)
    • fleet/server/mock/datastore_carves.go
    • Line 13: warning: exported type NewCarveFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type UpdateCarveFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type CarveFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type ListCarvesFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type CarveBySessionIdFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type CarveByNameFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type NewBlockFunc should have comment or be unexported (golint)
    • Line 27: warning: exported type GetBlockFunc should have comment or be unexported (golint)
    • Line 29: warning: exported type CleanupCarvesFunc should have comment or be unexported (golint)
    • Line 31: warning: exported type CarveStore should have comment or be unexported (golint)
    • Line 60: warning: exported method CarveStore.NewCarve should have comment or be unexported (golint)
    • Line 65: warning: exported method CarveStore.UpdateCarve should have comment or be unexported (golint)
    • Line 70: warning: exported method CarveStore.Carve should have comment or be unexported (golint)
    • Line 75: warning: exported method CarveStore.ListCarves should have comment or be unexported (golint)
    • Line 80: warning: exported method CarveStore.CarveBySessionId should have comment or be unexported (golint)
    • Line 85: warning: exported method CarveStore.CarveByName should have comment or be unexported (golint)
    • Line 90: warning: exported method CarveStore.NewBlock should have comment or be unexported (golint)
    • Line 95: warning: exported method CarveStore.GetBlock should have comment or be unexported (golint)
    • Line 100: warning: exported method CarveStore.CleanupCarves should have comment or be unexported (golint)
    • fleet/server/mock/datastore_software.go
    • Line 9: warning: exported type SaveHostSoftwareFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type LoadHostSoftwareFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type SoftwareStore should have comment or be unexported (golint)
    • Line 21: warning: exported method SoftwareStore.SaveHostSoftware should have comment or be unexported (golint)
    • Line 26: warning: exported method SoftwareStore.LoadHostSoftware should have comment or be unexported (golint)
    • fleet/server/kolide/packs.go
    • Line 133: warning: exported const PackKind should have comment (or a comment on this block) or be unexported (golint)
    • Line 146: warning: exported type PackSpec should have comment or be unexported (golint)
    • Line 156: warning: exported type PackSpecTargets should have comment or be unexported (golint)
    • Line 160: warning: exported type PackSpecQuery should have comment or be unexported (golint)
    • Line 180: warning: exported type PackStats should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/campaigns.go
    • Line 11: warning: exported method Datastore.NewDistributedQueryCampaign should have comment or be unexported (golint)
    • Line 31: warning: exported method Datastore.DistributedQueryCampaign should have comment or be unexported (golint)
    • Line 43: warning: exported method Datastore.SaveDistributedQueryCampaign should have comment or be unexported (golint)
    • Line 66: warning: exported method Datastore.DistributedQueryCampaignTargetIDs should have comment or be unexported (golint)
    • Line 91: warning: exported method Datastore.NewDistributedQueryCampaignTarget should have comment or be unexported (golint)
    • Line 110: warning: exported method Datastore.CleanupDistributedQueryCampaigns should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/packs.go
    • Line 12: warning: exported method Datastore.ApplyPackSpecs should have comment or be unexported (golint)
    • Line 107: warning: exported method Datastore.GetPackSpecs should have comment or be unexported (golint)
    • Line 151: warning: exported method Datastore.GetPackSpec should have comment or be unexported (golint)
    • Line 200: warning: exported method Datastore.PackByName should have comment or be unexported (golint)
    • Line 323: warning: comment on exported method Datastore.RemoveLabelFromPack should be of the form "RemoveLabelFromPack ..." (golint)
    • Line 384: warning: exported method Datastore.ListPacksForHost should have comment or be unexported (golint)
    • Line 412: warning: exported method Datastore.ListHostsInPack should have comment or be unexported (golint)
    • Line 436: warning: exported method Datastore.ListExplicitHostsInPack should have comment or be unexported (golint)
    • fleet/server/service/client_errors.go
    • Line 8: warning: exported type SetupAlreadyErr should have comment or be unexported (golint)
    • Line 23: warning: exported type NotSetupErr should have comment or be unexported (golint)
    • Line 38: warning: exported type NotFoundErr should have comment or be unexported (golint)
    • Line 49: warning: receiver name n should be consistent with previous receiver name e for notFoundErr (golint)
    • fleet/server/mock/datastore_invites_helpers.go
    • Line 5: warning: exported function ReturnNewInivite should have comment or be unexported (golint)
    • Line 11: warning: exported function ReturnFakeInviteByEmail should have comment or be unexported (golint)
    • Line 17: warning: exported function ReturnFakeInviteByToken should have comment or be unexported (golint)
    • Line 23: warning: exported function ReturnInviteFuncNotFound should have comment or be unexported (golint)
    • Line 29: warning: exported function ReturnFakeInviteByID should have comment or be unexported (golint)
    • fleet/server/mock/datastore_labels.go
    • Line 13: warning: exported type ApplyLabelSpecsFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type GetLabelSpecsFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type GetLabelSpecFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type NewLabelFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type SaveLabelFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type DeleteLabelFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type LabelFunc should have comment or be unexported (golint)
    • Line 27: warning: exported type ListLabelsFunc should have comment or be unexported (golint)
    • Line 29: warning: exported type LabelQueriesForHostFunc should have comment or be unexported (golint)
    • Line 31: warning: exported type RecordLabelQueryExecutionsFunc should have comment or be unexported (golint)
    • Line 33: warning: exported type ListLabelsForHostFunc should have comment or be unexported (golint)
    • Line 35: warning: exported type ListHostsInLabelFunc should have comment or be unexported (golint)
    • Line 37: warning: exported type ListUniqueHostsInLabelsFunc should have comment or be unexported (golint)
    • Line 39: warning: exported type SearchLabelsFunc should have comment or be unexported (golint)
    • Line 41: warning: exported type LabelIDsByNameFunc should have comment or be unexported (golint)
    • Line 43: warning: exported type LabelStore should have comment or be unexported (golint)
    • Line 90: warning: exported method LabelStore.ApplyLabelSpecs should have comment or be unexported (golint)
    • Line 95: warning: exported method LabelStore.GetLabelSpecs should have comment or be unexported (golint)
    • Line 100: warning: exported method LabelStore.GetLabelSpec should have comment or be unexported (golint)
    • Line 105: warning: exported method LabelStore.NewLabel should have comment or be unexported (golint)
    • Line 110: warning: exported method LabelStore.SaveLabel should have comment or be unexported (golint)
    • Line 115: warning: exported method LabelStore.DeleteLabel should have comment or be unexported (golint)
    • Line 120: warning: exported method LabelStore.Label should have comment or be unexported (golint)
    • Line 125: warning: exported method LabelStore.ListLabels should have comment or be unexported (golint)
    • Line 130: warning: exported method LabelStore.LabelQueriesForHost should have comment or be unexported (golint)
    • Line 135: warning: exported method LabelStore.RecordLabelQueryExecutions should have comment or be unexported (golint)
    • Line 140: warning: exported method LabelStore.ListLabelsForHost should have comment or be unexported (golint)
    • Line 145: warning: exported method LabelStore.ListHostsInLabel should have comment or be unexported (golint)
    • Line 150: warning: exported method LabelStore.ListUniqueHostsInLabels should have comment or be unexported (golint)
    • Line 155: warning: exported method LabelStore.SearchLabels should have comment or be unexported (golint)
    • Line 160: warning: exported method LabelStore.LabelIDsByName should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/app_configs.go
    • Line 13: warning: exported method Datastore.NewAppConfig should have comment or be unexported (golint)
    • Line 21: warning: exported method Datastore.AppConfig should have comment or be unexported (golint)
    • Line 46: warning: exported method Datastore.ManageHostExpiryEvent should have comment or be unexported (golint)
    • Line 74: warning: exported method Datastore.SaveAppConfig should have comment or be unexported (golint)
    • Line 192: warning: exported method Datastore.VerifyEnrollSecret should have comment or be unexported (golint)
    • Line 205: warning: exported method Datastore.ApplyEnrollSecretSpec should have comment or be unexported (golint)
    • Line 225: warning: exported method Datastore.GetEnrollSecretSpec should have comment or be unexported (golint)
    • fleet/server/live_query/mock_live_query.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 8: warning: exported type MockLiveQuery should have comment or be unexported (golint)
    • Line 13: warning: exported method MockLiveQuery.RunQuery should have comment or be unexported (golint)
    • Line 18: warning: exported method MockLiveQuery.StopQuery should have comment or be unexported (golint)
    • Line 24: warning: exported method MockLiveQuery.QueriesForHost should have comment or be unexported (golint)
    • Line 29: warning: exported method MockLiveQuery.QueryCompletedByHost should have comment or be unexported (golint)
    • fleet/server/kolide/traits.go
    • Line 5: warning: comment on exported type CreateTimestamp should be of the form "CreateTimestamp ..." (with optional leading article) (golint)
    • Line 15: warning: exported type UpdateCreateTimestamps should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/labels.go
    • Line 13: warning: exported method Datastore.ApplyLabelSpecs should have comment or be unexported (golint)
    • Line 111: warning: exported method Datastore.GetLabelSpecs should have comment or be unexported (golint)
    • Line 131: warning: exported method Datastore.GetLabelSpec should have comment or be unexported (golint)
    • Line 210: warning: exported method Datastore.SaveLabel should have comment or be unexported (golint)
    • Line 264: warning: exported method Datastore.LabelQueriesForHost should have comment or be unexported (golint)
    • Line 317: warning: exported method Datastore.RecordLabelQueryExecutions should have comment or be unexported (golint)
    • Line 412: warning: exported method Datastore.ListUniqueHostsInLabels should have comment or be unexported (golint)
    • Line 585: warning: exported method Datastore.LabelIDsByName should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/password_reset.go
    • Line 9: warning: exported method Datastore.NewPasswordResetRequest should have comment or be unexported (golint)
    • Line 18: warning: exported method Datastore.SavePasswordResetRequest should have comment or be unexported (golint)
    • Line 30: warning: exported method Datastore.DeletePasswordResetRequest should have comment or be unexported (golint)
    • Line 42: warning: exported method Datastore.DeletePasswordResetRequestsForUser should have comment or be unexported (golint)
    • Line 54: warning: exported method Datastore.FindPassswordResetByID should have comment or be unexported (golint)
    • Line 65: warning: exported method Datastore.FindPassswordResetsByUserID should have comment or be unexported (golint)
    • Line 84: warning: exported method Datastore.FindPassswordResetByToken should have comment or be unexported (golint)
    • Line 97: warning: exported method Datastore.FindPassswordResetByTokenAndUserID should have comment or be unexported (golint)
    • fleet/server/mock/datastore_queries.go
    • Line 9: warning: exported type ApplyQueriesFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type NewQueryFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type SaveQueryFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type DeleteQueryFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type DeleteQueriesFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type QueryFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type ListQueriesFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type QueryByNameFunc should have comment or be unexported (golint)
    • Line 25: warning: exported type QueryStore should have comment or be unexported (golint)
    • Line 51: warning: exported method QueryStore.ApplyQueries should have comment or be unexported (golint)
    • Line 56: warning: exported method QueryStore.NewQuery should have comment or be unexported (golint)
    • Line 61: warning: exported method QueryStore.SaveQuery should have comment or be unexported (golint)
    • Line 66: warning: exported method QueryStore.DeleteQuery should have comment or be unexported (golint)
    • Line 71: warning: exported method QueryStore.DeleteQueries should have comment or be unexported (golint)
    • Line 76: warning: exported method QueryStore.Query should have comment or be unexported (golint)
    • Line 81: warning: exported method QueryStore.ListQueries should have comment or be unexported (golint)
    • Line 86: warning: exported method QueryStore.QueryByName should have comment or be unexported (golint)
    • fleet/server/logging/logging.go
    • Line 1: warning: package comment should be of the form "Package logging ..." (golint)
    • Line 13: warning: exported type OsqueryLogger should have comment or be unexported (golint)
    • Line 18: warning: exported function New should have comment or be unexported (golint)
    • fleet/server/sso/settings.go
    • Line 13: warning: exported type Metadata should have comment or be unexported (golint)
    • Line 19: warning: exported type IDPSSODescriptor should have comment or be unexported (golint)
    • Line 27: warning: exported type KeyDescriptor should have comment or be unexported (golint)
    • Line 33: warning: exported type NameIDFormat should have comment or be unexported (golint)
    • Line 38: warning: exported type SingleSignOnService should have comment or be unexported (golint)
    • Line 45: warning: exported const PasswordProtectedTransport should have comment (or a comment on this block) or be unexported (golint)
    • Line 49: warning: exported type Settings should have comment or be unexported (golint)
    • fleet/server/sso/types.go
    • Line 47: warning: exported type Issuer should have comment or be unexported (golint)
    • Line 52: warning: exported type NameIDPolicy should have comment or be unexported (golint)
    • Line 58: warning: exported type RequestedAuthnContext should have comment or be unexported (golint)
    • Line 65: warning: exported type AuthnContextClassRef should have comment or be unexported (golint)
    • Line 71: warning: exported type Signature should have comment or be unexported (golint)
    • Line 79: warning: exported type SignedInfo should have comment or be unexported (golint)
    • Line 86: warning: exported type SignatureValue should have comment or be unexported (golint)
    • Line 91: warning: exported type KeyInfo should have comment or be unexported (golint)
    • Line 96: warning: exported type CanonicalizationMethod should have comment or be unexported (golint)
    • Line 101: warning: exported type SignatureMethod should have comment or be unexported (golint)
    • Line 106: warning: exported type SamlsigReference should have comment or be unexported (golint)
    • Line 114: warning: exported type X509Data should have comment or be unexported (golint)
    • Line 119: warning: exported type Transforms should have comment or be unexported (golint)
    • Line 124: warning: exported type DigestMethod should have comment or be unexported (golint)
    • Line 129: warning: exported type DigestValue should have comment or be unexported (golint)
    • Line 133: warning: exported type X509Certificate should have comment or be unexported (golint)
    • Line 138: warning: exported type Transform should have comment or be unexported (golint)
    • Line 143: warning: exported type EntityDescriptor should have comment or be unexported (golint)
    • Line 154: warning: exported type Extensions should have comment or be unexported (golint)
    • Line 163: warning: exported type SPSSODescriptor should have comment or be unexported (golint)
    • Line 171: warning: exported type EntityAttributes should have comment or be unexported (golint)
    • Line 178: warning: exported type SPSSODescriptors should have comment or be unexported (golint)
    • Line 181: warning: exported type SingleLogoutService should have comment or be unexported (golint)
    • Line 186: warning: exported type AssertionConsumerService should have comment or be unexported (golint)
    • Line 193: warning: exported type Assertion should have comment or be unexported (golint)
    • Line 207: warning: exported type Conditions should have comment or be unexported (golint)
    • Line 213: warning: exported type Subject should have comment or be unexported (golint)
    • Line 219: warning: exported type SubjectConfirmation should have comment or be unexported (golint)
    • Line 225: warning: exported type Status should have comment or be unexported (golint)
    • Line 230: warning: exported type SubjectConfirmationData should have comment or be unexported (golint)
    • Line 236: warning: exported type NameID should have comment or be unexported (golint)
    • Line 242: warning: exported type StatusCode should have comment or be unexported (golint)
    • Line 247: warning: exported type AttributeValue should have comment or be unexported (golint)
    • Line 253: warning: exported type Attribute should have comment or be unexported (golint)
    • Line 261: warning: exported type AttributeStatement should have comment or be unexported (golint)
    • fleet/server/bindata/placeholder.go
    • Line 11: warning: exported function Asset should have comment or be unexported (golint)
    • Line 15: warning: exported function AssetDir should have comment or be unexported (golint)
    • Line 19: warning: exported function AssetInfo should have comment or be unexported (golint)
    • fleet/server/config/config_test.go
    • Line 33: warning: don't use underscores in Go names; var conf_index should be confIndex (golint)
    • Line 34: warning: don't use underscores in Go names; var conf_v should be confV (golint)
    • Line 35: warning: don't use underscores in Go names; var key_index should be keyIndex (golint)
    • Line 36: warning: don't use underscores in Go names; var key_v should be keyV (golint)
    • fleet/server/datastore/mysql/osquery_options.go
    • Line 20: warning: exported method Datastore.ApplyOptions should have comment or be unexported (golint)
    • Line 76: warning: exported method Datastore.GetOptions should have comment or be unexported (golint)
    • Line 106: warning: exported method Datastore.OptionsForPlatform should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/users.go
    • Line 82: warning: exported method Datastore.UserByEmail should have comment or be unexported (golint)
    • Line 86: warning: exported method Datastore.UserByID should have comment or be unexported (golint)
    • Line 90: warning: exported method Datastore.SaveUser should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/users.go
    • Line 10: warning: exported method Datastore.NewUser should have comment or be unexported (golint)
    • Line 26: warning: exported method Datastore.User should have comment or be unexported (golint)
    • Line 40: warning: exported method Datastore.ListUsers should have comment or be unexported (golint)
    • Line 81: warning: exported method Datastore.UserByEmail should have comment or be unexported (golint)
    • Line 95: warning: exported method Datastore.UserByID should have comment or be unexported (golint)
    • Line 106: warning: exported method Datastore.SaveUser should have comment or be unexported (golint)
    • fleet/server/live_query/redis_live_query.go
    • Line 1: warning: package comment should be of the form "Package live_query ..." (golint)
    • Line 24: warning: don't use an underscore in package name (golint)
    • Line 46: warning: comment on exported function NewRedisLiveQuery should be of the form "NewRedisLiveQuery ..." (golint)
    • fleet/server/logging/pubsub.go
    • Line 20: warning: exported type PubSubAttributes should have comment or be unexported (golint)
    • Line 26: warning: exported function NewPubSubLogWriter should have comment or be unexported (golint)
    • fleet/server/kolide/labels.go
    • Line 10: warning: exported type LabelStore should have comment or be unexported (golint)
    • Line 57: warning: exported type LabelService should have comment or be unexported (golint)
    • Line 93: warning: exported type LabelPayload should have comment or be unexported (golint)
    • Line 111: warning: exported method LabelType.MarshalJSON should have comment or be unexported (golint)
    • Line 122: warning: exported method LabelType.UnmarshalJSON should have comment or be unexported (golint)
    • Line 138: warning: comment on exported const LabelMembershipTypeDynamic should be of the form "LabelMembershipTypeDynamic ..." (golint)
    • Line 141: warning: comment on exported const LabelMembershipTypeManual should be of the form "LabelMembershipTypeManual ..." (golint)
    • Line 145: warning: exported method LabelMembershipType.MarshalJSON should have comment or be unexported (golint)
    • Line 156: warning: exported method LabelMembershipType.UnmarshalJSON should have comment or be unexported (golint)
    • Line 168: warning: exported type Label should have comment or be unexported (golint)
    • Line 181: warning: exported const LabelKind should have comment (or a comment on this block) or be unexported (golint)
    • Line 184: warning: exported type LabelQueryExecution should have comment or be unexported (golint)
    • Line 192: warning: exported type LabelSpec should have comment or be unexported (golint)
    • fleet/server/mock/errors.go
    • Line 3: warning: exported type Error should have comment or be unexported (golint)
    • Line 11: warning: comment on exported method Error.IsNotFound should be of the form "IsNotFound ..." (golint)
    • Line 16: warning: comment on exported method Error.IsExists should be of the form "IsExists ..." (golint)
    • fleet/server/datastore/mysql/hosts.go
    • Line 17: warning: exported method Datastore.NewHost should have comment or be unexported (golint)
    • Line 58: warning: comment on exported method Datastore.SaveHost should be of the form "SaveHost ..." (golint)
    • Line 256: warning: exported method Datastore.DeleteHost should have comment or be unexported (golint)
    • Line 264: warning: exported method Datastore.Host should have comment or be unexported (golint)
    • Line 283: warning: exported method Datastore.ListHosts should have comment or be unexported (golint)
    • Line 375: warning: exported method Datastore.CleanupIncomingHosts should have comment or be unexported (golint)
    • Line 388: warning: exported method Datastore.GenerateHostStatusStatistics should have comment or be unexported (golint)
    • Line 502: warning: exported method Datastore.AuthenticateHost should have comment or be unexported (golint)
    • Line 560: warning: exported method Datastore.MarkHostSeen should have comment or be unexported (golint)
    • Line 576: warning: exported method Datastore.MarkHostsSeen should have comment or be unexported (golint)
    • Line 703: warning: exported method Datastore.HostIDsByName should have comment or be unexported (golint)
    • Line 727: warning: exported method Datastore.HostByIdentifier should have comment or be unexported (golint)
    • Line 746: warning: exported method Datastore.SaveHostAdditional should have comment or be unexported (golint)
    • fleet/server/kolide/osquery.go
    • Line 8: warning: exported type OsqueryService should have comment or be unexported (golint)
    • Line 52: warning: exported type PermissiveQueryContent should have comment or be unexported (golint)
    • Line 60: warning: exported type PermissiveQueries should have comment or be unexported (golint)
    • Line 71: warning: exported type PermissivePackContent should have comment or be unexported (golint)
    • Line 82: warning: exported type PermissivePacks should have comment or be unexported (golint)
    • fleet/server/mock/datastore_invites.go
    • Line 9: warning: exported type NewInviteFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type ListInvitesFunc should have comment or be unexported (golint)
    • Line 13: warning: exported type InviteFunc should have comment or be unexported (golint)
    • Line 15: warning: exported type InviteByEmailFunc should have comment or be unexported (golint)
    • Line 17: warning: exported type InviteByTokenFunc should have comment or be unexported (golint)
    • Line 19: warning: exported type SaveInviteFunc should have comment or be unexported (golint)
    • Line 21: warning: exported type DeleteInviteFunc should have comment or be unexported (golint)
    • Line 23: warning: exported type InviteStore should have comment or be unexported (golint)
    • Line 46: warning: exported method InviteStore.NewInvite should have comment or be unexported (golint)
    • Line 51: warning: exported method InviteStore.ListInvites should have comment or be unexported (golint)
    • Line 56: warning: exported method InviteStore.Invite should have comment or be unexported (golint)
    • Line 61: warning: exported method InviteStore.InviteByEmail should have comment or be unexported (golint)
    • Line 66: warning: exported method InviteStore.InviteByToken should have comment or be unexported (golint)
    • Line 71: warning: exported method InviteStore.SaveInvite should have comment or be unexported (golint)
    • Line 76: warning: exported method InviteStore.DeleteInvite should have comment or be unexported (golint)
    • fleet/server/mock/service_osquery.go
    • Line 14: warning: exported type EnrollAgentFunc should have comment or be unexported (golint)
    • Line 16: warning: exported type AuthenticateHostFuncI should have comment or be unexported (golint)
    • Line 18: warning: exported type GetClientConfigFunc should have comment or be unexported (golint)
    • Line 20: warning: exported type GetDistributedQueriesFunc should have comment or be unexported (golint)
    • Line 22: warning: exported type SubmitDistributedQueryResultsFunc should have comment or be unexported (golint)
    • Line 24: warning: exported type SubmitStatusLogsFunc should have comment or be unexported (golint)
    • Line 26: warning: exported type SubmitResultLogsFunc should have comment or be unexported (golint)
    • Line 28: warning: exported type TLSService should have comment or be unexported (golint)
    • Line 51: warning: exported method TLSService.EnrollAgent should have comment or be unexported (golint)
    • Line 56: warning: exported method TLSService.AuthenticateHost should have comment or be unexported (golint)
    • Line 61: warning: exported method TLSService.GetClientConfig should have comment or be unexported (golint)
    • Line 66: warning: exported method TLSService.GetDistributedQueries should have comment or be unexported (golint)
    • Line 71: warning: exported method TLSService.SubmitDistributedQueryResults should have comment or be unexported (golint)
    • Line 76: warning: exported method TLSService.SubmitStatusLogs should have comment or be unexported (golint)
    • Line 81: warning: exported method TLSService.SubmitResultLogs should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/campaigns.go
    • Line 10: warning: exported method Datastore.NewDistributedQueryCampaign should have comment or be unexported (golint)
    • Line 20: warning: exported method Datastore.DistributedQueryCampaign should have comment or be unexported (golint)
    • Line 32: warning: exported method Datastore.SaveDistributedQueryCampaign should have comment or be unexported (golint)
    • Line 44: warning: exported method Datastore.DistributedQueryCampaignTargetIDs should have comment or be unexported (golint)
    • Line 65: warning: exported method Datastore.NewDistributedQueryCampaignTarget should have comment or be unexported (golint)
    • Line 75: warning: exported method Datastore.CleanupDistributedQueryCampaigns should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/sessions.go
    • Line 8: warning: exported method Datastore.SessionByKey should have comment or be unexported (golint)
    • Line 22: warning: exported method Datastore.SessionByID should have comment or be unexported (golint)
    • Line 37: warning: exported method Datastore.ListSessionsForUser should have comment or be unexported (golint)
    • Line 52: warning: exported method Datastore.NewSession should have comment or be unexported (golint)
    • Line 70: warning: exported method Datastore.DestroySession should have comment or be unexported (golint)
    • Line 79: warning: exported method Datastore.DestroyAllSessionsForUser should have comment or be unexported (golint)
    • Line 91: warning: exported method Datastore.MarkSessionAccessed should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/app.go
    • Line 5: warning: exported method Datastore.NewAppConfig should have comment or be unexported (golint)
    • Line 14: warning: exported method Datastore.AppConfig should have comment or be unexported (golint)
    • Line 25: warning: exported method Datastore.SaveAppConfig should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/inmem.go
    • Line 15: warning: exported type Datastore should have comment or be unexported (golint)
    • Line 41: warning: exported function New should have comment or be unexported (golint)
    • Line 59: warning: exported method Datastore.Begin should have comment or be unexported (golint)
    • Line 63: warning: exported method Datastore.Name should have comment or be unexported (golint)
    • Line 82: warning: exported method Datastore.MigrateTables should have comment or be unexported (golint)
    • Line 104: warning: exported method Datastore.MigrateData should have comment or be unexported (golint)
    • Line 116: warning: exported method Datastore.MigrationStatus should have comment or be unexported (golint)
    • Line 116: warning: receiver name m should be consistent with previous receiver name d for Datastore (golint)
    • Line 120: warning: exported method Datastore.Drop should have comment or be unexported (golint)
    • Line 124: warning: exported method Datastore.Initialize should have comment or be unexported (golint)
    • fleet/server/mock/datastore.go
    • Line 22: warning: exported type Store should have comment or be unexported (golint)
    • Line 41: warning: exported method Store.Drop should have comment or be unexported (golint)
    • Line 44: warning: exported method Store.MigrateTables should have comment or be unexported (golint)
    • Line 47: warning: exported method Store.MigrateData should have comment or be unexported (golint)
    • Line 50: warning: exported method Store.MigrationStatus should have comment or be unexported (golint)
    • Line 53: warning: exported method Store.Name should have comment or be unexported (golint)
    • Line 62: warning: exported method Store.Begin should have comment or be unexported (golint)
    • fleet/server/kolide/transactions.go
    • Line 3: warning: exported type Transactions should have comment or be unexported (golint)
    • Line 7: warning: exported type Transaction should have comment or be unexported (golint)
    • Line 12: warning: exported function HasTransaction should have comment or be unexported (golint)
    • fleet/server/mock/datastore_targets.go
    • Line 13: warning: exported type CountHostsInTargetsFunc should have comment or be unexported (golint)
    • Line 14: warning: exported type HostIDsInTargetsFunc should have comment or be unexported (golint)
    • Line 16: warning: exported type TargetStore should have comment or be unexported (golint)
    • Line 23: warning: exported method TargetStore.CountHostsInTargets should have comment or be unexported (golint)
    • Line 28: warning: exported method TargetStore.HostIDsInTargets should have comment or be unexported (golint)
    • fleet/server/datastore/mysql/queries.go
    • Line 12: warning: exported method Datastore.ApplyQueries should have comment or be unexported (golint)
    • Line 65: warning: exported method Datastore.QueryByName should have comment or be unexported (golint)
    • Line 208: warning: don't use underscores in Go names; var name_queries should be nameQueries (golint)
    • fleet/cmd/fleetctl/config.go
    • Line 23: warning: exported type Context should have comment or be unexported (golint)
    • Line 122: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • fleet/server/logging/mock/firehose.go
    • Line 10: warning: exported type PutRecordBatchFunc should have comment or be unexported (golint)
    • Line 11: warning: exported type DescribeDeliveryStreamFunc should have comment or be unexported (golint)
    • Line 12: warning: exported type FirehoseMock should have comment or be unexported (golint)
    • Line 21: warning: exported method FirehoseMock.PutRecordBatch should have comment or be unexported (golint)
    • Line 26: warning: exported method FirehoseMock.DescribeDeliveryStream should have comment or be unexported (golint)
    • fleet/server/datastore/inmem/hosts.go
    • Line 14: warning: exported method Datastore.NewHost should have comment or be unexported (golint)
    • Line 30: warning: exported method Datastore.SaveHost should have comment or be unexported (golint)
    • Line 42: warning: exported method Datastore.DeleteHost should have comment or be unexported (golint)
    • Line 51: warning: exported method Datastore.Host should have comment or be unexported (golint)
    • Line 63: warning: exported method Datastore.ListHosts should have comment or be unexported (golint)
    • Line 135: warning: exported method Datastore.GenerateHostStatusStatistics should have comment or be unexported (golint)
    • Line 158: warning: exported method Datastore.EnrollHost should have comment or be unexported (golint)
    • Line 190: warning: exported method Datastore.AuthenticateHost should have comment or be unexported (golint)
    • Line 203: warning: exported method Datastore.MarkHostSeen should have comment or be unexported (golint)
    • Line 217: warning: exported method Datastore.SearchHosts should have comment or be unexported (golint)
    • fleet/server/kolide/carves.go
    • Line 8: warning: exported type CarveStore should have comment or be unexported (golint)
    • Line 23: warning: exported type CarveService should have comment or be unexported (golint)
    • Line 31: warning: exported type CarveMetadata should have comment or be unexported (golint)
    • Line 61: warning: exported method CarveMetadata.BlocksComplete should have comment or be unexported (golint)
    • Line 65: warning: exported type CarveListOptions should have comment or be unexported (golint)
    • Line 72: warning: exported type CarveBeginPayload should have comment or be unexported (golint)
    • Line 80: warning: exported type CarveBlockPayload should have comment or be unexported (golint)
    • fleet/server/test/new_objects.go
    • Line 11: warning: exported function NewQuery should have comment or be unexported (golint)
    • Line 31: warning: exported function NewPack should have comment or be unexported (golint)
    • Line 43: warning: exported function NewCampaign should have comment or be unexported (golint)
    • Line 62: warning: exported function AddHostToCampaign should have comment or be unexported (golint)
    • Line 72: warning: exported function AddLabelToCampaign should have comment or be unexported (golint)
    • Line 82: warning: exported function AddAllHostsLabel should have comment or be unexported (golint)
    • Line 94: warning: exported function NewHost should have comment or be unexported (golint)
    • Line 113: warning: exported function NewUser should have comment or be unexported (golint)
    • Line 129: warning: exported function NewScheduledQuery should have comment or be unexported (golint)

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • fleet/cmd/fleetctl/apply.go
    • Line 35: warning: cyclomatic complexity 20 of function specGroupFromBytes() is high (> 15) (gocyclo)
    • Line 117: warning: cyclomatic complexity 17 of function applyCommand() is high (> 15) (gocyclo)

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell98%

Misspell Finds commonly misspelled English words