gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• flytectl/boilerplate/lyft/golang_support_tools/tools.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo99%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• flytectl/cmd/register/register_util.go
  • Line 123: warning: cyclomatic complexity 16 of function hydrateNode() is high (> 15) (gocyclo)

golint65%

Golint is a linter for Go source code.

• flytectl/pkg/printer/printer.go
  • Line 18: warning: comment on exported type OutputFormat should be of the form "OutputFormat ..." (with optional leading article) (golint)
  • Line 22: warning: exported const OutputFormatTABLE should have comment (or a comment on this block) or be unexported (golint)
  • Line 27: warning: exported function OutputFormats should have comment or be unexported (golint)
  • Line 35: warning: exported type Column should have comment or be unexported (golint)
  • Line 40: warning: exported type Printer should have comment or be unexported (golint)
  • Line 76: warning: exported method Printer.JSONToTable should have comment or be unexported (golint)
  • Line 109: warning: exported method Printer.Print should have comment or be unexported (golint)
  • Line 150: warning: exported type PrintableProto should have comment or be unexported (golint)
  • Line 158: warning: exported method PrintableProto.MarshalJSON should have comment or be unexported (golint)

• flytectl/cmd/get/matchable_attribute_util.go
  • Line 11: warning: exported function FetchAndUnDecorateMatchableAttr should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionqueueattribute/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/taskresourceattribute/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/update/interfaces/updater.go
  • Line 12: warning: exported type Updater should have comment or be unexported (golint)

• flytectl/cmd/core/cmd_ctx.go
  • Line 10: warning: exported type CommandContext should have comment or be unexported (golint)
  • Line 19: warning: exported function NewCommandContext should have comment or be unexported (golint)
  • Line 39: warning: exported method CommandContext.AdminClient should have comment or be unexported (golint)
  • Line 43: warning: exported method CommandContext.OutputPipe should have comment or be unexported (golint)
  • Line 47: warning: exported method CommandContext.InputPipe should have comment or be unexported (golint)
  • Line 51: warning: exported method CommandContext.AdminFetcherExt should have comment or be unexported (golint)
  • Line 55: warning: exported method CommandContext.AdminUpdaterExt should have comment or be unexported (golint)
  • Line 59: warning: exported method CommandContext.AdminDeleterExt should have comment or be unexported (golint)

• flytectl/cmd/root.go
  • Line 83: warning: exported function GenerateDocs should have comment or be unexported (golint)
  • Line 93: warning: exported function GenReSTTree should have comment or be unexported (golint)
  • Line 102: warning: exported function ExecuteCmd should have comment or be unexported (golint)

• flytectl/pkg/ext/deleter.go
  • Line 28: warning: exported method AdminDeleterExtClient.AdminServiceClient should have comment or be unexported (golint)

• flytectl/cmd/register/files.go
  • Line 21: warning: comment on exported type FilesConfig should be of the form "FilesConfig ..." (with optional leading article) (golint)

• flytectl/cmd/config/subcommand/plugin_override/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/core/cmd.go
  • Line 15: warning: exported type PFlagProvider should have comment or be unexported (golint)
  • Line 19: warning: exported type CommandEntry should have comment or be unexported (golint)
  • Line 28: warning: exported function AddCommands should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/clusterresourceattribute/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/update/matchable_attribute_util.go
  • Line 11: warning: exported function DecorateAndUpdateMatchableAttr should have comment or be unexported (golint)

• flytectl/pkg/ext/updater.go
  • Line 28: warning: exported method AdminUpdaterExtClient.AdminServiceClient should have comment or be unexported (golint)

• flytectl/cmd/get/execution.go
  • Line 58: warning: exported function ExecutionToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/get/project.go
  • Line 56: warning: exported function ProjectToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/plugin_override/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionqueueattribute/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/core/types.go
  • Line 5: warning: exported type CommandFunc should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionclusterlabel/update_config.go
  • Line 10: warning: exported var DefaultUpdateConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/matchable_attr_file_config_utils.go
  • Line 49: warning: exported function DumpTaskResourceAttr should have comment or be unexported (golint)

• flytectl/pkg/ext/attribute_match_fetcher.go
  • Line 10: warning: exported method AdminFetcherExtClient.FetchWorkflowAttributes should have comment or be unexported (golint)
  • Line 27: warning: exported method AdminFetcherExtClient.FetchProjectDomainAttributes should have comment or be unexported (golint)

• flytectl/clierrors/errors.go
  • Line 4: warning: exported var ErrInvalidStateUpdate should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/taskresourceattribute/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/taskresourceattribute/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionclusterlabel/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/pkg/adminutils/iterator.go
  • Line 11: warning: exported type NamedEntityIDLister should have comment or be unexported (golint)
  • Line 13: warning: exported type NamedEntityVisitor should have comment or be unexported (golint)
  • Line 15: warning: exported type ListRequest should have comment or be unexported (golint)
  • Line 21: warning: exported function IterateThroughAllNamedEntities should have comment or be unexported (golint)
  • Line 53: warning: exported function GetAllNamedEntities should have comment or be unexported (golint)
  • Line 65: warning: exported function NamedEntityToProtoMessage should have comment or be unexported (golint)

• flytectl/cmd/testutils/test_utils.go
  • Line 27: warning: exported var Err should have comment or be unexported (golint)
  • Line 39: warning: exported function Setup should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/clusterresourceattribute/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/cmd/update/named_entity.go
  • Line 19: warning: exported type NamedEntityConfig should have comment or be unexported (golint)
  • Line 25: warning: exported method NamedEntityConfig.UpdateNamedEntity should have comment or be unexported (golint)

• flytectl/pkg/pkce/token_cache_keyring.go
  • Line 18: warning: exported const KeyRingServiceUser should have comment (or a comment on this block) or be unexported (golint)
  • Line 22: warning: exported method TokenCacheKeyringProvider.SaveToken should have comment or be unexported (golint)
  • Line 41: warning: exported method TokenCacheKeyringProvider.GetToken should have comment or be unexported (golint)

• flytectl/pkg/ext/task_fetcher.go
  • Line 11: warning: exported method AdminFetcherExtClient.FetchAllVerOfTask should have comment or be unexported (golint)
  • Line 33: warning: exported method AdminFetcherExtClient.FetchTaskLatestVersion should have comment or be unexported (golint)
  • Line 46: warning: exported method AdminFetcherExtClient.FetchTaskVersion should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionclusterlabel/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/update/project.go
  • Line 16: warning: comment on exported type ProjectConfig should be of the form "ProjectConfig ..." (with optional leading article) (golint)

• flytectl/pkg/ext/execution_fetcher.go
  • Line 10: warning: exported method AdminFetcherExtClient.FetchExecution should have comment or be unexported (golint)

• flytectl/pkg/ext/fetcher.go
  • Line 59: warning: exported method AdminFetcherExtClient.AdminServiceClient should have comment or be unexported (golint)

• flytectl/cmd/register/register_util.go
  • Line 34: warning: exported type Result should have comment or be unexported (golint)
  • Line 214: warning: exported function DownloadFileFromHTTP should have comment or be unexported (golint)

• flytectl/pkg/ext/attribute_matcher_deleter.go
  • Line 9: warning: exported method AdminDeleterExtClient.DeleteWorkflowAttributes should have comment or be unexported (golint)
  • Line 19: warning: exported method AdminDeleterExtClient.DeleteProjectDomainAttributes should have comment or be unexported (golint)

• flytectl/cmd/get/launch_plan.go
  • Line 94: warning: comment on exported type LaunchPlanConfig should be of the form "LaunchPlanConfig ..." (with optional leading article) (golint)
  • Line 109: warning: exported function LaunchplanToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/workflow/workflow_config.go
  • Line 6: warning: exported var DefaultConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/executionqueueattribute/fetch_config.go
  • Line 5: warning: exported type AttrFetchConfig should have comment or be unexported (golint)
  • Line 9: warning: exported var DefaultFetchConfig should have comment or be unexported (golint)

• flytectl/pkg/adminutils/config.go
  • Line 15: warning: exported type Config should have comment or be unexported (golint)
  • Line 20: warning: exported function GetConfig should have comment or be unexported (golint)

• flytectl/cmd/create/execution.go
  • Line 103: warning: exported type ExecutionType should have comment or be unexported (golint)
  • Line 106: warning: exported const Task should have comment (or a comment on this block) or be unexported (golint)
  • Line 111: warning: exported type ExecutionParams should have comment or be unexported (golint)

• flytectl/cmd/create/serialization_utils.go
  • Line 8: warning: comment on exported function MakeLiteralForVariables should be of the form "MakeLiteralForVariables ..." (golint)
  • Line 20: warning: exported function MakeLiteralForParams should have comment or be unexported (golint)

• flytectl/pkg/ext/attribute_match_updater.go
  • Line 9: warning: exported method AdminUpdaterExtClient.UpdateWorkflowAttributes should have comment or be unexported (golint)
  • Line 21: warning: exported method AdminUpdaterExtClient.UpdateProjectDomainAttributes should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/plugin_override/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/cmd/config/subcommand/clusterresourceattribute/delete_config.go
  • Line 10: warning: exported var DefaultDelConfig should have comment or be unexported (golint)

• flytectl/pkg/commandutils/command_utils.go
  • Line 11: warning: exported function AskForConfirmation should have comment or be unexported (golint)

• flytectl/cmd/get/execution_util.go
  • Line 30: warning: exported function WriteExecConfigToFile should have comment or be unexported (golint)
  • Line 43: warning: exported function CreateAndWriteExecConfigForTask should have comment or be unexported (golint)
  • Line 52: warning: exported function CreateAndWriteExecConfigForWorkflow should have comment or be unexported (golint)
  • Line 61: warning: exported function TaskInputs should have comment or be unexported (golint)
  • Line 81: warning: exported function ParamMapForTask should have comment or be unexported (golint)
  • Line 97: warning: exported function WorkflowParams should have comment or be unexported (golint)
  • Line 108: warning: exported function ParamMapForWorkflow should have comment or be unexported (golint)

• flytectl/cmd/get/task.go
  • Line 93: warning: comment on exported type TaskConfig should be of the form "TaskConfig ..." (with optional leading article) (golint)
  • Line 109: warning: exported function TaskToProtoMessages should have comment or be unexported (golint)

• flytectl/cmd/get/workflow.go
  • Line 72: warning: exported function WorkflowToProtoMessages should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!