gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• flytepropeller/pkg/controller/nodes/task/resourcemanager/redis_resourcemanager_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• flytepropeller/pkg/controller/nodes/branch/comparator.go
  • Line 74: warning: cyclomatic complexity 16 of function Evaluate() is high (> 15) (gocyclo)

• flytepropeller/pkg/controller/controller.go
  • Line 317: warning: cyclomatic complexity 18 of function New() is high (> 15) (gocyclo)

• flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
  • Line 409: warning: cyclomatic complexity 17 of function NewPluginManager() is high (> 15) (gocyclo)

• flytepropeller/pkg/compiler/validators/interface.go
  • Line 36: warning: cyclomatic complexity 25 of function ValidateUnderlyingInterface() is high (> 15) (gocyclo)

• flytepropeller/pkg/compiler/validators/node.go
  • Line 118: warning: cyclomatic complexity 21 of function ValidateNode() is high (> 15) (gocyclo)

• flytepropeller/pkg/compiler/transformers/k8s/workflow.go
  • Line 140: warning: cyclomatic complexity 18 of function BuildFlyteWorkflow() is high (> 15) (gocyclo)

• flytepropeller/pkg/compiler/validators/bindings.go
  • Line 14: warning: cyclomatic complexity 20 of function validateBinding() is high (> 15) (gocyclo)

• flytepropeller/pkg/controller/handler.go
  • Line 167: warning: cyclomatic complexity 20 of function (*Propeller).Handle() is high (> 15) (gocyclo)

• flytepropeller/pkg/controller/nodes/dynamic/dynamic_workflow.go
  • Line 37: warning: cyclomatic complexity 16 of function (dynamicNodeTaskNodeHandler).buildDynamicWorkflowTemplate() is high (> 15) (gocyclo)

• flytepropeller/pkg/utils/literals.go
  • Line 178: warning: cyclomatic complexity 16 of function MakeDefaultLiteralForType() is high (> 15) (gocyclo)

• flytepropeller/pkg/controller/workflow/executor.go
  • Line 347: warning: cyclomatic complexity 18 of function (*workflowExecutor).HandleFlyteWorkflow() is high (> 15) (gocyclo)
  • Line 264: warning: cyclomatic complexity 17 of function (*workflowExecutor).TransitionToPhase() is high (> 15) (gocyclo)

• flytepropeller/pkg/compiler/transformers/k8s/node.go
  • Line 13: warning: cyclomatic complexity 25 of function buildNodeSpec() is high (> 15) (gocyclo)

golint46%

Golint is a linter for Go source code.

• flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
  • Line 53: warning: exported type PluginPhase should have comment or be unexported (golint)
  • Line 56: warning: exported const PluginPhaseNotStarted should have comment (or a comment on this block) or be unexported (golint)
  • Line 61: warning: exported type PluginState should have comment or be unexported (golint)
  • Line 65: warning: exported type PluginMetrics should have comment or be unexported (golint)
  • Line 87: warning: exported function IsK8sObjectNotExists should have comment or be unexported (golint)
  • Line 91: warning: comment on exported type PluginManager should be of the form "PluginManager ..." (with optional leading article) (golint)
  • Line 104: warning: exported method PluginManager.AddObjectMetadata should have comment or be unexported (golint)
  • Line 120: warning: exported method PluginManager.GetProperties should have comment or be unexported (golint)
  • Line 127: warning: exported method PluginManager.GetID should have comment or be unexported (golint)
  • Line 178: warning: exported method PluginManager.LaunchResource should have comment or be unexported (golint)
  • Line 241: warning: exported method PluginManager.CheckResourcePhase should have comment or be unexported (golint)
  • Line 304: warning: exported method PluginManager.Handle should have comment or be unexported (golint)
  • Line 324: warning: exported method PluginManager.Abort should have comment or be unexported (golint)
  • Line 348: warning: exported method PluginManager.ClearFinalizers should have comment or be unexported (golint)
  • Line 364: warning: exported method PluginManager.Finalize should have comment or be unexported (golint)
  • Line 398: warning: exported function NewPluginManagerWithBackOff should have comment or be unexported (golint)
  • Line 408: warning: comment on exported function NewPluginManager should be of the form "NewPluginManager ..." (golint)

• flytepropeller/pkg/utils/helpers.go
  • Line 5: warning: exported function CopyMap should have comment or be unexported (golint)
  • Line 16: warning: exported function GetSanitizedPrometheusKey should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go
  • Line 205: warning: exported function NewAdminLaunchPlanExecutor should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/branch/evaluator.go
  • Line 15: warning: exported const ErrorCodeUserProvidedError should have comment or be unexported (golint)
  • Line 16: warning: exported const ErrorCodeMalformedBranch should have comment or be unexported (golint)
  • Line 17: warning: exported const ErrorCodeCompilerError should have comment or be unexported (golint)
  • Line 19: warning: exported function EvaluateComparison should have comment or be unexported (golint)
  • Line 61: warning: exported function EvaluateBooleanExpression should have comment or be unexported (golint)
  • Line 82: warning: exported function EvaluateIfBlock should have comment or be unexported (golint)
  • Line 93: warning: comment on exported function DecideBranch should be of the form "DecideBranch ..." (golint)

• flytepropeller/pkg/controller/workflowstore/inmemory.go
  • Line 11: warning: exported type InmemoryWorkflowStore should have comment or be unexported (golint)
  • Line 15: warning: exported method InmemoryWorkflowStore.Create should have comment or be unexported (golint)
  • Line 28: warning: exported method InmemoryWorkflowStore.Delete should have comment or be unexported (golint)
  • Line 38: warning: exported method InmemoryWorkflowStore.Get should have comment or be unexported (golint)
  • Line 47: warning: exported method InmemoryWorkflowStore.UpdateStatus should have comment or be unexported (golint)
  • Line 68: warning: exported method InmemoryWorkflowStore.Update should have comment or be unexported (golint)
  • Line 73: warning: comment on exported function NewInMemoryWorkflowStore should be of the form "NewInMemoryWorkflowStore ..." (golint)

• flytepropeller/pkg/controller/nodes/task/k8s/plugin_collector.go
  • Line 21: warning: exported const KindKey should have comment or be unexported (golint)
  • Line 23: warning: comment on exported type ResourceLevelMonitor should be of the form "ResourceLevelMonitor ..." (with optional leading article) (golint)
  • Line 82: warning: exported method ResourceLevelMonitor.RunCollector should have comment or be unexported (golint)
  • Line 107: warning: exported method ResourceLevelMonitor.RunCollectorOnce should have comment or be unexported (golint)
  • Line 113: warning: comment on exported type ResourceMonitorIndex should be of the form "ResourceMonitorIndex ..." (with optional leading article) (golint)
  • Line 128: warning: exported method ResourceMonitorIndex.GetOrCreateResourceLevelMonitor should have comment or be unexported (golint)
  • Line 172: warning: exported function NewResourceMonitorIndex should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/printers/node.go
  • Line 22: warning: exported function ColorizeNodePhase should have comment or be unexported (golint)
  • Line 38: warning: exported function CalculateRuntime should have comment or be unexported (golint)
  • Line 48: warning: exported type NodePrinter should have comment or be unexported (golint)
  • Line 52: warning: exported method NodeStatusPrinter.BaseNodeInfo should have comment or be unexported (golint)
  • Line 61: warning: exported method NodeStatusPrinter.NodeInfo should have comment or be unexported (golint)
  • Line 72: warning: exported method NodePrinter.BranchNodeInfo should have comment or be unexported (golint)
  • Line 129: warning: exported method NodePrinter.PrintList should have comment or be unexported (golint)
  • Line 139: warning: exported type NodeStatusPrinter should have comment or be unexported (golint)
  • Line 142: warning: exported method NodeStatusPrinter.PrintRecursive should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/task_compiler.go
  • Line 86: warning: comment on exported function CompileTask should be of the form "CompileTask ..." (golint)

• flytepropeller/pkg/visualize/sort.go
  • Line 8: warning: exported type VisitStatus should have comment or be unexported (golint)
  • Line 11: warning: exported const NotVisited should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: exported type NodeVisitor should have comment or be unexported (golint)
  • Line 18: warning: exported function NewNodeVisitor should have comment or be unexported (golint)
  • Line 65: warning: exported function TopologicalSort should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/create.go
  • Line 44: warning: exported type CreateOpts should have comment or be unexported (golint)
  • Line 54: warning: exported function NewCreateCommand should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/output_resolver.go
  • Line 18: warning: exported type VarName should have comment or be unexported (golint)
  • Line 22: warning: exported type OutputResolver should have comment or be unexported (golint)
  • Line 28: warning: exported function CreateAliasMap should have comment or be unexported (golint)
  • Line 121: warning: comment on exported function NewRemoteFileOutputResolver should be of the form "NewRemoteFileOutputResolver ..." (golint)

• flytepropeller/pkg/webhook/k8s_secrets.go
  • Line 15: warning: exported const K8sPathDefaultDirEnvVar should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: exported var K8sSecretPathPrefix should have comment or be unexported (golint)
  • Line 37: warning: exported method K8sSecretInjector.ID should have comment or be unexported (golint)
  • Line 41: warning: exported method K8sSecretInjector.Inject should have comment or be unexported (golint)
  • Line 100: warning: exported function NewK8sSecretsInjector should have comment or be unexported (golint)

• flytepropeller/pkg/webhook/secrets.go
  • Line 18: warning: exported type SecretsMutator should have comment or be unexported (golint)
  • Line 22: warning: exported type SecretsInjector should have comment or be unexported (golint)
  • Line 27: warning: exported method SecretsMutator.ID should have comment or be unexported (golint)
  • Line 31: warning: exported method SecretsMutator.Mutate should have comment or be unexported (golint)
  • Line 55: warning: exported function NewSecretsMutator should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/errors/codes.go
  • Line 5: warning: exported type ErrorCode should have comment or be unexported (golint)
  • Line 8: warning: exported const UnknownError should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/controller/nodes/handler/node_exec_context.go
  • Line 20: warning: exported type TaskReader should have comment or be unexported (golint)
  • Line 26: warning: exported type SetupContext should have comment or be unexported (golint)
  • Line 32: warning: exported type NodeExecutionMetadata should have comment or be unexported (golint)
  • Line 44: warning: exported type NodeExecutionContext should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/identifier.go
  • Line 10: warning: exported type Identifier should have comment or be unexported (golint)
  • Line 14: warning: exported method Identifier.UnmarshalJSON should have comment or be unexported (golint)
  • Line 19: warning: exported method Identifier.MarshalJSON should have comment or be unexported (golint)
  • Line 27: warning: exported method Identifier.DeepCopyInto should have comment or be unexported (golint)
  • Line 31: warning: exported type WorkflowExecutionIdentifier should have comment or be unexported (golint)
  • Line 35: warning: exported method WorkflowExecutionIdentifier.DeepCopyInto should have comment or be unexported (golint)
  • Line 39: warning: exported type TaskExecutionIdentifier should have comment or be unexported (golint)
  • Line 43: warning: exported method TaskExecutionIdentifier.DeepCopyInto should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/config/config.go
  • Line 11: warning: exported type Type should have comment or be unexported (golint)
  • Line 14: warning: exported const TypeNoop should have comment (or a comment on this block) or be unexported (golint)
  • Line 28: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 35: warning: comment on exported type RedisConfig should be of the form "RedisConfig ..." (with optional leading article) (golint)
  • Line 46: warning: comment on exported function GetConfig should be of the form "GetConfig ..." (golint)
  • Line 51: warning: exported function SetConfig should have comment or be unexported (golint)

• flytepropeller/pkg/webhook/utils.go
  • Line 24: warning: exported function CreateEnvVarForSecret should have comment or be unexported (golint)
  • Line 38: warning: exported function CreateVolumeForSecret should have comment or be unexported (golint)
  • Line 55: warning: exported function CreateVolumeMountForSecret should have comment or be unexported (golint)
  • Line 63: warning: exported function UpdateVolumeMounts should have comment or be unexported (golint)
  • Line 73: warning: exported function UpdateEnvVars should have comment or be unexported (golint)

• flytepropeller/pkg/controller/config/config.go
  • Line 150: warning: exported type CompositeQueueType should have comment or be unexported (golint)
  • Line 153: warning: exported const CompositeQueueSimple should have comment (or a comment on this block) or be unexported (golint)
  • Line 166: warning: exported type WorkqueueType should have comment or be unexported (golint)
  • Line 169: warning: exported const WorkqueueTypeDefault should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/controller/executors/node_lookup.go
  • Line 23: warning: comment on exported function NewNodeLookup should be of the form "NewNodeLookup ..." (golint)
  • Line 48: warning: comment on exported function NewTestNodeLookup should be of the form "NewTestNodeLookup ..." (golint)

• flytepropeller/pkg/controller/workflowstore/passthrough.go
  • Line 104: warning: exported function NewPassthroughWorkflowStore should have comment or be unexported (golint)

• flytepropeller/pkg/webhook/config.go
  • Line 19: warning: exported type Config should have comment or be unexported (golint)
  • Line 27: warning: exported function GetConfig should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/validators/condition.go
  • Line 35: warning: exported function ValidateBooleanExpression should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/errors/config.go
  • Line 3: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
  • Line 15: warning: comment on exported function SetConfig should be of the form "SetConfig ..." (golint)
  • Line 20: warning: comment on exported function GetConfig should be of the form "GetConfig ..." (golint)
  • Line 25: warning: exported function SetIncludeSource should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/launchplan/noop.go
  • Line 42: warning: exported function NewFailFastLaunchPlanExecutor should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/subworkflow.go
  • Line 3: warning: exported type WorkflowNodeSpec should have comment or be unexported (golint)
  • Line 17: warning: exported method WorkflowNodeSpec.GetLaunchPlanRefID should have comment or be unexported (golint)
  • Line 21: warning: exported method WorkflowNodeSpec.GetSubWorkflowRef should have comment or be unexported (golint)

• flytepropeller/pkg/utils/failing_datastore.go
  • Line 11: warning: exported type FailingRawStore should have comment or be unexported (golint)
  • Line 14: warning: exported method FailingRawStore.CopyRaw should have comment or be unexported (golint)
  • Line 18: warning: exported method FailingRawStore.GetBaseContainerFQN should have comment or be unexported (golint)
  • Line 22: warning: exported method FailingRawStore.Head should have comment or be unexported (golint)
  • Line 26: warning: exported method FailingRawStore.ReadRaw should have comment or be unexported (golint)
  • Line 30: warning: exported method FailingRawStore.WriteRaw should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/executor.go
  • Line 1: warning: package comment should be of the form "Package nodes ..." (golint)
  • Line 912: warning: exported function NewExecutor should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/common/index.go
  • Line 9: warning: comment on exported type NodeIndex should be of the form "NodeIndex ..." (with optional leading article) (golint)
  • Line 12: warning: comment on exported type TaskIndex should be of the form "TaskIndex ..." (with optional leading article) (golint)
  • Line 15: warning: exported type WorkflowIndex should have comment or be unexported (golint)
  • Line 17: warning: comment on exported type AdjacencyList should be of the form "AdjacencyList ..." (with optional leading article) (golint)
  • Line 20: warning: exported type StringAdjacencyList should have comment or be unexported (golint)
  • Line 22: warning: comment on exported method AdjacencyList.ToMapOfLists should be of the form "ToMapOfLists ..." (golint)
  • Line 32: warning: comment on exported function NewTaskIndex should be of the form "NewTaskIndex ..." (golint)
  • Line 43: warning: comment on exported function NewNodeIndex should be of the form "NewNodeIndex ..." (golint)
  • Line 53: warning: exported function NewWorkflowIndex should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/start/handler.go
  • Line 32: warning: exported function New should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/k8s/task_exec_context.go
  • Line 16: warning: exported method TaskExecutionContext.TaskExecutionMetadata should have comment or be unexported (golint)
  • Line 36: warning: exported method TaskExecutionMetadata.GetLabels should have comment or be unexported (golint)
  • Line 40: warning: exported method TaskExecutionMetadata.GetAnnotations should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/workflow_status.go
  • Line 16: warning: exported type WorkflowStatus should have comment or be unexported (golint)
  • Line 42: warning: exported function IsWorkflowPhaseTerminal should have comment or be unexported (golint)
  • Line 46: warning: exported method WorkflowStatus.SetMessage should have comment or be unexported (golint)
  • Line 50: warning: exported method WorkflowStatus.UpdatePhase should have comment or be unexported (golint)
  • Line 73: warning: exported method WorkflowStatus.GetExecutionError should have comment or be unexported (golint)
  • Line 80: warning: exported method WorkflowStatus.IncFailedAttempts should have comment or be unexported (golint)
  • Line 84: warning: exported method WorkflowStatus.GetPhase should have comment or be unexported (golint)
  • Line 88: warning: exported method WorkflowStatus.GetStartedAt should have comment or be unexported (golint)
  • Line 92: warning: exported method WorkflowStatus.GetStoppedAt should have comment or be unexported (golint)
  • Line 96: warning: exported method WorkflowStatus.GetLastUpdatedAt should have comment or be unexported (golint)
  • Line 100: warning: exported method WorkflowStatus.IsTerminated should have comment or be unexported (golint)
  • Line 104: warning: exported method WorkflowStatus.GetMessage should have comment or be unexported (golint)
  • Line 108: warning: exported method WorkflowStatus.GetNodeExecutionStatus should have comment or be unexported (golint)
  • Line 160: warning: exported method WorkflowStatus.ConstructNodeDataDir should have comment or be unexported (golint)
  • Line 164: warning: exported method WorkflowStatus.GetDataDir should have comment or be unexported (golint)
  • Line 168: warning: exported method WorkflowStatus.SetDataDir should have comment or be unexported (golint)
  • Line 172: warning: exported method WorkflowStatus.GetOutputReference should have comment or be unexported (golint)
  • Line 176: warning: exported method WorkflowStatus.SetOutputReference should have comment or be unexported (golint)
  • Line 180: warning: exported method WorkflowStatus.Equals should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflowstore/config.go
  • Line 9: warning: exported type Policy should have comment or be unexported (golint)
  • Line 36: warning: exported function GetConfig should have comment or be unexported (golint)
  • Line 40: warning: exported function SetConfig should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/printers/workflow.go
  • Line 15: warning: exported function ColorizeWorkflowPhase should have comment or be unexported (golint)
  • Line 29: warning: exported function CalculateWorkflowRuntime should have comment or be unexported (golint)
  • Line 39: warning: exported type ContextualWorkflow should have comment or be unexported (golint)
  • Line 45: warning: exported method ContextualWorkflow.GetExecutionConfig should have comment or be unexported (golint)
  • Line 50: warning: exported type WorkflowPrinter should have comment or be unexported (golint)
  • Line 53: warning: exported method WorkflowPrinter.Print should have comment or be unexported (golint)
  • Line 68: warning: exported method WorkflowPrinter.PrintSubWorkflow should have comment or be unexported (golint)
  • Line 84: warning: exported method WorkflowPrinter.PrintShort should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflow/errors/codes.go
  • Line 3: warning: exported type ErrorCode should have comment or be unexported (golint)
  • Line 6: warning: exported const IllegalStateError should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/pre_post_execution.go
  • Line 23: warning: exported method Handler.CheckCatalogCache should have comment or be unexported (golint)
  • Line 74: warning: exported method Handler.ValidateOutputAndCacheAdd should have comment or be unexported (golint)

• flytepropeller/pkg/webhook/pod.go
  • Line 1: warning: package comment should be of the form "Package webhook ..." (golint)
  • Line 64: warning: exported type MutatorConfig should have comment or be unexported (golint)
  • Line 69: warning: exported type Mutator should have comment or be unexported (golint)
  • Line 74: warning: exported method PodMutator.InjectClient should have comment or be unexported (golint)
  • Line 84: warning: exported method PodMutator.Handle should have comment or be unexported (golint)
  • Line 110: warning: exported method PodMutator.Mutate should have comment or be unexported (golint)
  • Line 136: warning: exported method PodMutator.Register should have comment or be unexported (golint)
  • Line 147: warning: exported method PodMutator.GetMutatePath should have comment or be unexported (golint)
  • Line 161: warning: exported method PodMutator.CreateMutationWebhookConfiguration should have comment or be unexported (golint)
  • Line 222: warning: exported function NewPodMutator should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/common/reader.go
  • Line 7: warning: exported type NodeID should have comment or be unexported (golint)
  • Line 8: warning: exported type TaskID should have comment or be unexported (golint)
  • Line 9: warning: exported type WorkflowID should have comment or be unexported (golint)
  • Line 10: warning: exported type LaunchPlanID should have comment or be unexported (golint)
  • Line 11: warning: exported type TaskIDKey should have comment or be unexported (golint)
  • Line 12: warning: exported type WorkflowIDKey should have comment or be unexported (golint)
  • Line 14: warning: comment on exported type Workflow should be of the form "Workflow ..." (with optional leading article) (golint)
  • Line 29: warning: comment on exported type Node should be of the form "Node ..." (with optional leading article) (golint)
  • Line 45: warning: comment on exported type Task should be of the form "Task ..." (with optional leading article) (golint)
  • Line 52: warning: exported type InterfaceProvider should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/validators/node.go
  • Line 1: warning: package comment should be of the form "Package validators ..." (golint)
  • Line 56: warning: exported type EdgeInfo should have comment or be unexported (golint)
  • Line 61: warning: exported function ValidateBranchNode should have comment or be unexported (golint)
  • Line 118: warning: exported function ValidateNode should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/util.go
  • Line 13: warning: exported function GetChildWorkflowExecutionID should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/noop_resourcemanager.go
  • Line 9: warning: exported const NoopResourceManagerID should have comment or be unexported (golint)
  • Line 11: warning: exported type NoopResourceManagerBuilder should have comment or be unexported (golint)
  • Line 14: warning: exported method NoopResourceManagerBuilder.GetID should have comment or be unexported (golint)
  • Line 18: warning: exported method NoopResourceManagerBuilder.GetResourceRegistrar should have comment or be unexported (golint)
  • Line 25: warning: exported method NoopResourceManagerBuilder.RegisterResourceQuota should have comment or be unexported (golint)
  • Line 29: warning: exported method NoopResourceManagerBuilder.BuildResourceManager should have comment or be unexported (golint)
  • Line 33: warning: exported type NoopResourceManager should have comment or be unexported (golint)
  • Line 36: warning: exported method NoopResourceManager.GetID should have comment or be unexported (golint)
  • Line 40: warning: exported method NoopResourceManager.AllocateResource should have comment or be unexported (golint)
  • Line 46: warning: exported method NoopResourceManager.ReleaseResource should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflowstore/resource_version_caching.go
  • Line 115: warning: exported function NewResourceVersionCachingStore should have comment or be unexported (golint)

• flytepropeller/pkg/controller/executors/kube.go
  • Line 14: warning: comment on exported type Client should be of the form "Client ..." (with optional leading article) (golint)
  • Line 47: warning: exported type FallbackClientBuilder should have comment or be unexported (golint)
  • Line 51: warning: exported method FallbackClientBuilder.WithUncached should have comment or be unexported (golint)
  • Line 56: warning: exported method FallbackClientBuilder.Build should have comment or be unexported (golint)
  • Line 73: warning: comment on exported function NewFallbackClientBuilder should be of the form "NewFallbackClientBuilder ..." (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/launchplan/adminconfig.go
  • Line 36: warning: exported function GetAdminConfig should have comment or be unexported (golint)

• flytepropeller/cmd/controller/cmd/webhook.go
  • Line 29: warning: exported const PodNameEnvVar should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/controller/composite_workqueue.go
  • Line 46: warning: exported method SimpleWorkQueue.Start should have comment or be unexported (golint)
  • Line 49: warning: exported method SimpleWorkQueue.ShutdownAll should have comment or be unexported (golint)
  • Line 53: warning: exported method SimpleWorkQueue.AddToSubQueue should have comment or be unexported (golint)
  • Line 57: warning: exported method SimpleWorkQueue.AddToSubQueueAfter should have comment or be unexported (golint)
  • Line 61: warning: exported method SimpleWorkQueue.AddToSubQueueRateLimited should have comment or be unexported (golint)
  • Line 80: warning: exported method BatchingWorkQueue.Start should have comment or be unexported (golint)
  • Line 131: warning: exported method BatchingWorkQueue.ShutdownAll should have comment or be unexported (golint)
  • Line 136: warning: exported method BatchingWorkQueue.AddToSubQueue should have comment or be unexported (golint)
  • Line 140: warning: exported method BatchingWorkQueue.AddToSubQueueAfter should have comment or be unexported (golint)
  • Line 144: warning: exported method BatchingWorkQueue.AddToSubQueueRateLimited should have comment or be unexported (golint)
  • Line 148: warning: exported function NewCompositeWorkQueue should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflowstore/iface.go
  • Line 11: warning: exported type PriorityClass should have comment or be unexported (golint)
  • Line 14: warning: exported const PriorityClassCritical should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/transformer.go
  • Line 16: warning: exported function ToTransitionType should have comment or be unexported (golint)
  • Line 23: warning: exported function ToTaskEventPhase should have comment or be unexported (golint)
  • Line 72: warning: exported type ToTaskExecutionEventInputs should have comment or be unexported (golint)
  • Line 84: warning: exported function ToTaskExecutionEvent should have comment or be unexported (golint)
  • Line 148: warning: exported function GetTaskExecutionIdentifier should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/common/builder.go
  • Line 1: warning: package comment should be of the form "Package common ..." (golint)
  • Line 10: warning: exported const StartNodeID should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: comment on exported type WorkflowBuilder should be of the form "WorkflowBuilder ..." (with optional leading article) (golint)
  • Line 26: warning: comment on exported type NodeBuilder should be of the form "NodeBuilder ..." (with optional leading article) (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/error.go
  • Line 10: warning: comment on exported type ExecutionError should be of the form "ExecutionError ..." (with optional leading article) (golint)
  • Line 15: warning: exported method ExecutionError.UnmarshalJSON should have comment or be unexported (golint)
  • Line 20: warning: exported method ExecutionError.MarshalJSON should have comment or be unexported (golint)
  • Line 31: warning: exported method ExecutionError.DeepCopyInto should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/node_status.go
  • Line 19: warning: exported type MutableStruct should have comment or be unexported (golint)
  • Line 23: warning: exported method MutableStruct.SetDirty should have comment or be unexported (golint)
  • Line 27: warning: comment on exported method MutableStruct.ResetDirty should be of the form "ResetDirty ..." (golint)
  • Line 32: warning: exported method MutableStruct.IsDirty should have comment or be unexported (golint)
  • Line 36: warning: exported type BranchNodeStatus should have comment or be unexported (golint)
  • Line 42: warning: exported method BranchNodeStatus.GetPhase should have comment or be unexported (golint)
  • Line 46: warning: exported method BranchNodeStatus.SetBranchNodeError should have comment or be unexported (golint)
  • Line 51: warning: exported method BranchNodeStatus.SetBranchNodeSuccess should have comment or be unexported (golint)
  • Line 57: warning: exported method BranchNodeStatus.GetFinalizedNode should have comment or be unexported (golint)
  • Line 61: warning: exported method BranchNodeStatus.Equals should have comment or be unexported (golint)
  • Line 81: warning: exported type DynamicNodePhase should have comment or be unexported (golint)
  • Line 84: warning: comment on exported const DynamicNodePhaseNone should be of the form "DynamicNodePhaseNone ..." (golint)
  • Line 86: warning: comment on exported const DynamicNodePhaseExecuting should be of the form "DynamicNodePhaseExecuting ..." (golint)
  • Line 88: warning: comment on exported const DynamicNodePhaseFailing should be of the form "DynamicNodePhaseFailing ..." (golint)
  • Line 90: warning: comment on exported const DynamicNodePhaseParentFinalizing should be of the form "DynamicNodePhaseParentFinalizing ..." (golint)
  • Line 92: warning: comment on exported const DynamicNodePhaseParentFinalized should be of the form "DynamicNodePhaseParentFinalized ..." (golint)
  • Line 96: warning: exported type DynamicNodeStatus should have comment or be unexported (golint)
  • Line 103: warning: exported method DynamicNodeStatus.GetDynamicNodePhase should have comment or be unexported (golint)
  • Line 107: warning: exported method DynamicNodeStatus.GetDynamicNodeReason should have comment or be unexported (golint)
  • Line 111: warning: exported method DynamicNodeStatus.GetExecutionError should have comment or be unexported (golint)
  • Line 118: warning: exported method DynamicNodeStatus.SetDynamicNodeReason should have comment or be unexported (golint)
  • Line 125: warning: exported method DynamicNodeStatus.SetDynamicNodePhase should have comment or be unexported (golint)
  • Line 132: warning: exported method DynamicNodeStatus.SetExecutionError should have comment or be unexported (golint)
  • Line 140: warning: exported method DynamicNodeStatus.Equals should have comment or be unexported (golint)
  • Line 150: warning: exported type WorkflowNodePhase should have comment or be unexported (golint)
  • Line 153: warning: exported const WorkflowNodePhaseUndefined should have comment (or a comment on this block) or be unexported (golint)
  • Line 158: warning: exported type WorkflowNodeStatus should have comment or be unexported (golint)
  • Line 164: warning: exported method WorkflowNodeStatus.SetExecutionError should have comment or be unexported (golint)
  • Line 171: warning: exported method WorkflowNodeStatus.GetExecutionError should have comment or be unexported (golint)
  • Line 175: warning: exported method WorkflowNodeStatus.GetWorkflowNodePhase should have comment or be unexported (golint)
  • Line 179: warning: exported method WorkflowNodeStatus.SetWorkflowNodePhase should have comment or be unexported (golint)
  • Line 186: warning: exported type NodeStatus should have comment or be unexported (golint)
  • Line 220: warning: exported method NodeStatus.IsDirty should have comment or be unexported (golint)
  • Line 265: warning: exported method NodeStatus.GetBranchStatus should have comment or be unexported (golint)
  • Line 272: warning: exported method NodeStatus.GetWorkflowStatus should have comment or be unexported (golint)
  • Line 279: warning: exported method NodeStatus.GetTaskStatus should have comment or be unexported (golint)
  • Line 286: warning: exported method NodeStatus.VisitNodeStatuses should have comment or be unexported (golint)
  • Line 292: warning: exported method NodeStatus.GetDynamicNodeStatus should have comment or be unexported (golint)
  • Line 299: warning: exported method NodeStatus.ClearWorkflowStatus should have comment or be unexported (golint)
  • Line 304: warning: exported method NodeStatus.ClearTaskStatus should have comment or be unexported (golint)
  • Line 309: warning: exported method NodeStatus.ClearLastAttemptStartedAt should have comment or be unexported (golint)
  • Line 314: warning: exported method NodeStatus.ClearSubNodeStatus should have comment or be unexported (golint)
  • Line 319: warning: exported method NodeStatus.GetLastUpdatedAt should have comment or be unexported (golint)
  • Line 323: warning: exported method NodeStatus.GetLastAttemptStartedAt should have comment or be unexported (golint)
  • Line 327: warning: exported method NodeStatus.GetAttempts should have comment or be unexported (golint)
  • Line 331: warning: exported method NodeStatus.GetSystemFailures should have comment or be unexported (golint)
  • Line 335: warning: exported method NodeStatus.SetCached should have comment or be unexported (golint)
  • Line 340: warning: exported method NodeStatus.IsCached should have comment or be unexported (golint)
  • Line 344: warning: exported method NodeStatus.IncrementAttempts should have comment or be unexported (golint)
  • Line 350: warning: exported method NodeStatus.IncrementSystemFailures should have comment or be unexported (golint)
  • Line 356: warning: exported method NodeStatus.GetOrCreateDynamicNodeStatus should have comment or be unexported (golint)
  • Line 367: warning: exported method NodeStatus.ClearDynamicNodeStatus should have comment or be unexported (golint)
  • Line 372: warning: exported method NodeStatus.GetOrCreateBranchStatus should have comment or be unexported (golint)
  • Line 383: warning: exported method NodeStatus.GetWorkflowNodeStatus should have comment or be unexported (golint)
  • Line 391: warning: exported method NodeStatus.GetPhase should have comment or be unexported (golint)
  • Line 395: warning: exported method NodeStatus.GetMessage should have comment or be unexported (golint)
  • Line 399: warning: exported function IsPhaseTerminal should have comment or be unexported (golint)
  • Line 403: warning: exported method NodeStatus.GetOrCreateTaskStatus should have comment or be unexported (golint)
  • Line 414: warning: exported method NodeStatus.UpdatePhase should have comment or be unexported (golint)
  • Line 459: warning: exported method NodeStatus.GetStartedAt should have comment or be unexported (golint)
  • Line 463: warning: exported method NodeStatus.GetStoppedAt should have comment or be unexported (golint)
  • Line 467: warning: exported method NodeStatus.GetQueuedAt should have comment or be unexported (golint)
  • Line 471: warning: exported method NodeStatus.GetParentNodeID should have comment or be unexported (golint)
  • Line 475: warning: exported method NodeStatus.GetParentTaskID should have comment or be unexported (golint)
  • Line 482: warning: exported method NodeStatus.SetParentNodeID should have comment or be unexported (golint)
  • Line 489: warning: exported method NodeStatus.SetParentTaskID should have comment or be unexported (golint)
  • Line 500: warning: exported method NodeStatus.GetOrCreateWorkflowStatus should have comment or be unexported (golint)
  • Line 511: warning: exported method NodeStatus.GetTaskNodeStatus should have comment or be unexported (golint)
  • Line 520: warning: exported method NodeStatus.GetNodeExecutionStatus should have comment or be unexported (golint)
  • Line 578: warning: exported method NodeStatus.IsTerminated should have comment or be unexported (golint)
  • Line 582: warning: exported method NodeStatus.GetDataDir should have comment or be unexported (golint)
  • Line 586: warning: exported method NodeStatus.SetDataDir should have comment or be unexported (golint)
  • Line 590: warning: exported method NodeStatus.GetOutputDir should have comment or be unexported (golint)
  • Line 594: warning: exported method NodeStatus.SetOutputDir should have comment or be unexported (golint)
  • Line 598: warning: exported method NodeStatus.Equals should have comment or be unexported (golint)
  • Line 668: warning: exported method NodeStatus.GetExecutionError should have comment or be unexported (golint)
  • Line 675: warning: comment on exported method CustomState.DeepCopyInto should be of the form "DeepCopyInto ..." (golint)
  • Line 692: warning: exported method CustomState.DeepCopy should have comment or be unexported (golint)
  • Line 702: warning: exported type TaskNodeStatus should have comment or be unexported (golint)
  • Line 712: warning: exported method TaskNodeStatus.GetBarrierClockTick should have comment or be unexported (golint)
  • Line 716: warning: exported method TaskNodeStatus.SetBarrierClockTick should have comment or be unexported (golint)
  • Line 721: warning: exported method TaskNodeStatus.SetPluginState should have comment or be unexported (golint)
  • Line 726: warning: exported method TaskNodeStatus.SetLastPhaseUpdatedAt should have comment or be unexported (golint)
  • Line 730: warning: exported method TaskNodeStatus.SetPluginStateVersion should have comment or be unexported (golint)
  • Line 735: warning: exported method TaskNodeStatus.GetPluginState should have comment or be unexported (golint)
  • Line 739: warning: exported method TaskNodeStatus.GetPluginStateVersion should have comment or be unexported (golint)
  • Line 743: warning: exported method TaskNodeStatus.SetPhase should have comment or be unexported (golint)
  • Line 748: warning: exported method TaskNodeStatus.SetPhaseVersion should have comment or be unexported (golint)
  • Line 753: warning: exported method TaskNodeStatus.GetPhase should have comment or be unexported (golint)
  • Line 757: warning: exported method TaskNodeStatus.GetLastPhaseUpdatedAt should have comment or be unexported (golint)
  • Line 761: warning: exported method TaskNodeStatus.GetPhaseVersion should have comment or be unexported (golint)
  • Line 765: warning: exported method TaskNodeStatus.UpdatePhase should have comment or be unexported (golint)
  • Line 774: warning: exported method TaskNodeStatus.DeepCopyInto should have comment or be unexported (golint)
  • Line 790: warning: exported method TaskNodeStatus.DeepCopy should have comment or be unexported (golint)
  • Line 800: warning: exported method TaskNodeStatus.Equals should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/branch/handler.go
  • Line 244: warning: exported function New should have comment or be unexported (golint)

• flytepropeller/pkg/controller/controller.go
  • Line 78: warning: comment on exported method Controller.Run should be of the form "Run ..." (golint)
  • Line 191: warning: comment on exported type ResourceLevelMonitor should be of the form "ResourceLevelMonitor ..." (with optional leading article) (golint)
  • Line 252: warning: exported method ResourceLevelMonitor.RunCollector should have comment or be unexported (golint)
  • Line 271: warning: exported function NewResourceLevelMonitor should have comment or be unexported (golint)
  • Line 316: warning: comment on exported function New should be of the form "New ..." (golint)

• flytepropeller/pkg/compiler/validators/interface.go
  • Line 11: warning: comment on exported function ValidateInterface should be of the form "ValidateInterface ..." (golint)
  • Line 35: warning: comment on exported function ValidateUnderlyingInterface should be of the form "ValidateUnderlyingInterface ..." (golint)

• flytepropeller/pkg/controller/nodes/task/fakeplugins/next_phase_state_plugin.go
  • Line 14: warning: exported type NextPhaseState should have comment or be unexported (golint)
  • Line 23: warning: exported type NextPhaseStatePlugin should have comment or be unexported (golint)
  • Line 28: warning: exported method NextPhaseStatePlugin.GetID should have comment or be unexported (golint)
  • Line 32: warning: exported method NextPhaseStatePlugin.GetProperties should have comment or be unexported (golint)
  • Line 36: warning: exported method NextPhaseStatePlugin.Handle should have comment or be unexported (golint)
  • Line 77: warning: exported method NextPhaseStatePlugin.Abort should have comment or be unexported (golint)
  • Line 81: warning: exported method NextPhaseStatePlugin.Finalize should have comment or be unexported (golint)
  • Line 85: warning: exported function NewPhaseBasedPlugin should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/compile.go
  • Line 16: warning: exported type CompileOpts should have comment or be unexported (golint)
  • Line 25: warning: exported function NewCompileCommand should have comment or be unexported (golint)

• flytepropeller/cmd/controller/cmd/root.go
  • Line 1: warning: package comment should be of the form "Package cmd ..." (golint)

• flytepropeller/pkg/controller/nodes/common/utils.go
  • Line 13: warning: comment on exported function GenerateUniqueID should be of the form "GenerateUniqueID ..." (golint)
  • Line 29: warning: comment on exported function CreateParentInfo should be of the form "CreateParentInfo ..." (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/branch.go
  • Line 10: warning: exported type Error should have comment or be unexported (golint)
  • Line 14: warning: exported method Error.UnmarshalJSON should have comment or be unexported (golint)
  • Line 19: warning: exported method Error.MarshalJSON should have comment or be unexported (golint)
  • Line 39: warning: exported type BooleanExpression should have comment or be unexported (golint)
  • Line 43: warning: exported method BooleanExpression.MarshalJSON should have comment or be unexported (golint)
  • Line 55: warning: exported method BooleanExpression.UnmarshalJSON should have comment or be unexported (golint)
  • Line 67: warning: exported type IfBlock should have comment or be unexported (golint)
  • Line 72: warning: exported method IfBlock.GetCondition should have comment or be unexported (golint)
  • Line 76: warning: exported method IfBlock.GetThenNode should have comment or be unexported (golint)
  • Line 80: warning: exported type BranchNodeSpec should have comment or be unexported (golint)
  • Line 87: warning: exported method BranchNodeSpec.GetIf should have comment or be unexported (golint)
  • Line 91: warning: exported method BranchNodeSpec.GetElse should have comment or be unexported (golint)
  • Line 95: warning: exported method BranchNodeSpec.GetElseIf should have comment or be unexported (golint)
  • Line 103: warning: exported method BranchNodeSpec.GetElseFail should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/root.go
  • Line 32: warning: exported type RootOptions should have comment or be unexported (golint)
  • Line 42: warning: exported method RootOptions.GetTimeoutSeconds should have comment or be unexported (golint)
  • Line 62: warning: exported method RootOptions.ConfigureClient should have comment or be unexported (golint)
  • Line 81: warning: comment on exported function NewFlyteCommand should be of the form "NewFlyteCommand ..." (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/resourcemanager_util.go
  • Line 16: warning: exported function GetResourceManagerBuilderByType should have comment or be unexported (golint)

• flytepropeller/pkg/controller/executors/mocks/fake.go
  • Line 8: warning: exported function NewFakeKubeClient should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/codex/gob_codec.go
  • Line 8: warning: exported type GobStateCodec should have comment or be unexported (golint)
  • Line 11: warning: exported method GobStateCodec.Encode should have comment or be unexported (golint)
  • Line 16: warning: exported method GobStateCodec.Decode should have comment or be unexported (golint)

• flytepropeller/pkg/visualize/nodeq.go
  • Line 5: warning: exported type NodeQ should have comment or be unexported (golint)
  • Line 7: warning: exported method NodeQ.Enqueue should have comment or be unexported (golint)
  • Line 11: warning: exported method NodeQ.HasNext should have comment or be unexported (golint)
  • Line 15: warning: exported method NodeQ.Remaining should have comment or be unexported (golint)
  • Line 19: warning: exported method NodeQ.Peek should have comment or be unexported (golint)
  • Line 27: warning: exported method NodeQ.Deque should have comment or be unexported (golint)
  • Line 33: warning: exported function NewNodeNameQ should have comment or be unexported (golint)

• flytepropeller/pkg/utils/k8s.go
  • Line 18: warning: exported var NotTheOwnerError should have comment or be unexported (golint)
  • Line 25: warning: exported function ToK8sEnvVar should have comment or be unexported (golint)
  • Line 33: warning: comment on exported function ToK8sResourceList should be of the form "ToK8sResourceList ..." (golint)
  • Line 65: warning: exported function ToK8sResourceRequirements should have comment or be unexported (golint)
  • Line 83: warning: exported function GetWorkflowIDFromOwner should have comment or be unexported (golint)
  • Line 93: warning: exported function GetProtoTime should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/config/config.go
  • Line 17: warning: exported const SectionKey should have comment or be unexported (golint)
  • Line 38: warning: exported type Config should have comment or be unexported (golint)
  • Line 46: warning: exported type BarrierConfig should have comment or be unexported (golint)
  • Line 52: warning: exported type TaskPluginConfig should have comment or be unexported (golint)
  • Line 58: warning: exported type BackOffConfig should have comment or be unexported (golint)
  • Line 63: warning: exported type PluginID should have comment or be unexported (golint)
  • Line 64: warning: exported type TaskType should have comment or be unexported (golint)
  • Line 66: warning: comment on exported type PluginsConfigMeta should be of the form "PluginsConfigMeta ..." (with optional leading article) (golint)
  • Line 79: warning: exported method TaskPluginConfig.GetEnabledPlugins should have comment or be unexported (golint)
  • Line 120: warning: exported function GetConfig should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/launchplan/errors.go
  • Line 7: warning: exported type ErrorCode should have comment or be unexported (golint)
  • Line 10: warning: exported const RemoteErrorAlreadyExists should have comment (or a comment on this block) or be unexported (golint)
  • Line 16: warning: comment on exported function IsAlreadyExists should be of the form "IsAlreadyExists ..." (golint)
  • Line 21: warning: comment on exported function IsUserError should be of the form "IsUserError ..." (golint)
  • Line 26: warning: comment on exported function IsNotFound should be of the form "IsNotFound ..." (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/delete.go
  • Line 12: warning: exported type DeleteOpts should have comment or be unexported (golint)
  • Line 20: warning: exported function NewDeleteCommand should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/backoff/handler.go
  • Line 65: warning: exported type ComputeResourceCeilings should have comment or be unexported (golint)
  • Line 112: warning: exported method ComputeResourceAwareBackOffHandler.IsActive should have comment or be unexported (golint)
  • Line 121: warning: comment on exported method ComputeResourceAwareBackOffHandler.Handle should be of the form "Handle ..." (golint)
  • Line 188: warning: exported function IsResourceQuotaExceeded should have comment or be unexported (golint)
  • Line 192: warning: exported function IsBackOffError should have comment or be unexported (golint)
  • Line 196: warning: exported function GetComputeResourceAndQuantityRequested should have comment or be unexported (golint)
  • Line 231: warning: exported function IsBackoffError should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/typing/variable.go
  • Line 11: warning: exported type Variable should have comment or be unexported (golint)
  • Line 16: warning: comment on exported function ParseVarName should be of the form "ParseVarName ..." (golint)

• flytepropeller/pkg/controller/executors/dag_structure.go
  • Line 9: warning: comment on exported type DAGStructure should be of the form "DAGStructure ..." (with optional leading article) (golint)
  • Line 18: warning: exported type DAGStructureWithStartNode should have comment or be unexported (golint)
  • Line 40: warning: comment on exported function NewLeafNodeDAGStructure should be of the form "NewLeafNodeDAGStructure ..." (golint)

• flytepropeller/pkg/controller/executors/execution_context.go
  • Line 7: warning: exported type TaskDetailsGetter should have comment or be unexported (golint)
  • Line 11: warning: exported type SubWorkflowGetter should have comment or be unexported (golint)
  • Line 15: warning: exported type ImmutableExecutionContext should have comment or be unexported (golint)
  • Line 22: warning: exported type ParentInfoGetter should have comment or be unexported (golint)
  • Line 26: warning: exported type ImmutableParentInfo should have comment or be unexported (golint)
  • Line 31: warning: exported type ControlFlow should have comment or be unexported (golint)
  • Line 36: warning: exported type ExecutionContext should have comment or be unexported (golint)
  • Line 84: warning: exported function NewExecutionContextWithTasksGetter should have comment or be unexported (golint)
  • Line 88: warning: exported function NewExecutionContextWithWorkflowGetter should have comment or be unexported (golint)
  • Line 92: warning: exported function NewExecutionContextWithParentInfo should have comment or be unexported (golint)
  • Line 96: warning: exported function NewExecutionContext should have comment or be unexported (golint)
  • Line 106: warning: exported function NewParentInfo should have comment or be unexported (golint)
  • Line 113: warning: exported function InitializeControlFlow should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/workflow_compiler.go
  • Line 1: warning: package comment should be of the form "Package compiler ..." (golint)
  • Line 292: warning: comment on exported function CompileWorkflow should be of the form "CompileWorkflow ..." (golint)

• flytepropeller/pkg/controller/workers.go
  • Line 17: warning: exported type Handler should have comment or be unexported (golint)
  • Line 33: warning: exported type WorkerPool should have comment or be unexported (golint)
  • Line 119: warning: exported method WorkerPool.Initialize should have comment or be unexported (golint)
  • Line 162: warning: exported function NewWorkerPool should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/resolve.go
  • Line 13: warning: exported function ResolveBindingData should have comment or be unexported (golint)
  • Line 90: warning: exported function Resolve should have comment or be unexported (golint)

• flytepropeller/pkg/utils/error_codes.go
  • Line 3: warning: exported const ErrorCodeUser should have comment or be unexported (golint)
  • Line 4: warning: exported const ErrorCodeSystem should have comment or be unexported (golint)
  • Line 5: warning: exported const ErrorCodeUnknown should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/end/handler.go
  • Line 52: warning: exported function New should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/register.go
  • Line 10: warning: exported const FlyteWorkflowKind should have comment or be unexported (golint)
  • Line 15: warning: comment on exported function Kind should be of the form "Kind ..." (golint)
  • Line 26: warning: exported var SchemeBuilder should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/redis_client.go
  • Line 14: warning: exported type RedisClient should have comment or be unexported (golint)
  • Line 29: warning: exported type Redis should have comment or be unexported (golint)
  • Line 33: warning: exported method Redis.SCard should have comment or be unexported (golint)
  • Line 37: warning: exported method Redis.SIsMember should have comment or be unexported (golint)
  • Line 41: warning: exported method Redis.SAdd should have comment or be unexported (golint)
  • Line 45: warning: exported method Redis.SRem should have comment or be unexported (golint)
  • Line 49: warning: exported method Redis.SMembers should have comment or be unexported (golint)
  • Line 53: warning: exported method Redis.Ping should have comment or be unexported (golint)
  • Line 57: warning: exported function NewRedisClient should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/resourceconstraints.go
  • Line 8: warning: exported type ResourceConstraint should have comment or be unexported (golint)
  • Line 16: warning: exported type BaseResourceConstraint should have comment or be unexported (golint)
  • Line 20: warning: exported method BaseResourceConstraint.IsAllowed should have comment or be unexported (golint)
  • Line 24: warning: exported type FullyQualifiedResourceConstraint should have comment or be unexported (golint)
  • Line 29: warning: exported method FullyQualifiedResourceConstraint.IsAllowed should have comment or be unexported (golint)

• flytepropeller/pkg/controller/executors/node.go
  • Line 14: warning: comment on exported type NodePhase should be of the form "NodePhase ..." (with optional leading article) (golint)
  • Line 18: warning: comment on exported const NodePhasePending should be of the form "NodePhasePending ..." (golint)
  • Line 20: warning: comment on exported const NodePhaseQueued should be of the form "NodePhaseQueued ..." (golint)
  • Line 22: warning: comment on exported const NodePhaseRunning should be of the form "NodePhaseRunning ..." (golint)
  • Line 24: warning: comment on exported const NodePhaseSuccess should be of the form "NodePhaseSuccess ..." (golint)
  • Line 27: warning: comment on exported const NodePhaseComplete should be of the form "NodePhaseComplete ..." (golint)
  • Line 30: warning: comment on exported const NodePhaseFailed should be of the form "NodePhaseFailed ..." (golint)
  • Line 32: warning: comment on exported const NodePhaseUndefined should be of the form "NodePhaseUndefined ..." (golint)
  • Line 34: warning: comment on exported const NodePhaseTimingOut should be of the form "NodePhaseTimingOut ..." (golint)
  • Line 36: warning: comment on exported const NodePhaseTimedOut should be of the form "NodePhaseTimedOut ..." (golint)
  • Line 62: warning: comment on exported type Node should be of the form "Node ..." (with optional leading article) (golint)
  • Line 84: warning: comment on exported type NodeStatus should be of the form "NodeStatus ..." (with optional leading article) (golint)
  • Line 90: warning: exported method NodeStatus.IsComplete should have comment or be unexported (golint)
  • Line 94: warning: exported method NodeStatus.HasFailed should have comment or be unexported (golint)
  • Line 98: warning: exported method NodeStatus.HasTimedOut should have comment or be unexported (golint)
  • Line 102: warning: exported method NodeStatus.PartiallyComplete should have comment or be unexported (golint)
  • Line 106: warning: exported var NodeStatusPending should have comment or be unexported (golint)
  • Line 107: warning: exported var NodeStatusQueued should have comment or be unexported (golint)
  • Line 108: warning: exported var NodeStatusRunning should have comment or be unexported (golint)
  • Line 109: warning: exported var NodeStatusSuccess should have comment or be unexported (golint)
  • Line 110: warning: exported var NodeStatusComplete should have comment or be unexported (golint)
  • Line 111: warning: exported var NodeStatusUndefined should have comment or be unexported (golint)
  • Line 112: warning: exported var NodeStatusTimedOut should have comment or be unexported (golint)
  • Line 114: warning: exported function NodeStatusFailed should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/handler/iface.go
  • Line 9: warning: comment on exported type Node should be of the form "Node ..." (with optional leading article) (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/execution_config.go
  • Line 5: warning: comment on exported type RawOutputDataConfig should be of the form "RawOutputDataConfig ..." (with optional leading article) (golint)
  • Line 13: warning: exported method RawOutputDataConfig.DeepCopyInto should have comment or be unexported (golint)
  • Line 17: warning: comment on exported type ExecutionConfig should be of the form "ExecutionConfig ..." (with optional leading article) (golint)
  • Line 25: warning: exported type TaskPluginOverride should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/plugin_config.go
  • Line 16: warning: exported function WranglePluginsAndGenerateFinalList should have comment or be unexported (golint)

• flytepropeller/pkg/controller/executors/workflow.go
  • Line 9: warning: exported type Workflow should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/validators/bindings.go
  • Line 102: warning: exported function ValidateBindings should have comment or be unexported (golint)

• flytepropeller/pkg/controller/finalizer.go
  • Line 5: warning: exported const FinalizerKey should have comment or be unexported (golint)
  • Line 11: warning: comment on exported function SetFinalizerIfEmpty should be of the form "SetFinalizerIfEmpty ..." (golint)
  • Line 18: warning: comment on exported function IsDeleted should be of the form "IsDeleted ..." (golint)
  • Line 23: warning: comment on exported function ResetFinalizers should be of the form "ResetFinalizers ..." (golint)
  • Line 28: warning: comment on exported function FinalizersIdentical should be of the form "FinalizersIdentical ..." (golint)
  • Line 33: warning: comment on exported function HasFinalizer should be of the form "HasFinalizer ..." (golint)

• flytepropeller/pkg/controller/nodes/task/catalog/datacatalog/datacatalog.go
  • Line 29: warning: comment on exported type CatalogClient should be of the form "CatalogClient ..." (with optional leading article) (golint)
  • Line 35: warning: comment on exported method CatalogClient.GetDataset should be of the form "GetDataset ..." (golint)
  • Line 55: warning: comment on exported method CatalogClient.GetArtifactByTag should be of the form "GetArtifactByTag ..." (golint)
  • Line 139: warning: exported method CatalogClient.CreateDataset should have comment or be unexported (golint)
  • Line 165: warning: exported method CatalogClient.CreateArtifact should have comment or be unexported (golint)
  • Line 193: warning: comment on exported method CatalogClient.Put should be of the form "Put ..." (golint)
  • Line 267: warning: comment on exported function NewDataCatalog should be of the form "NewDataCatalog ..." (golint)

• flytepropeller/pkg/compiler/errors/compiler_errors.go
  • Line 10: warning: comment on exported const CycleDetected should be of the form "CycleDetected ..." (golint)
  • Line 13: warning: comment on exported const BranchNodeIDNotFound should be of the form "BranchNodeIDNotFound ..." (golint)
  • Line 16: warning: comment on exported const BranchNodeHasNoCondition should be of the form "BranchNodeHasNoCondition ..." (golint)
  • Line 19: warning: comment on exported const BranchNodeHasNoDefault should be of the form "BranchNodeHasNoDefault ..." (golint)
  • Line 22: warning: comment on exported const ValueRequired should be of the form "ValueRequired ..." (golint)
  • Line 25: warning: comment on exported const NodeReferenceNotFound should be of the form "NodeReferenceNotFound ..." (golint)
  • Line 28: warning: comment on exported const TaskReferenceNotFound should be of the form "TaskReferenceNotFound ..." (golint)
  • Line 31: warning: comment on exported const WorkflowReferenceNotFound should be of the form "WorkflowReferenceNotFound ..." (golint)
  • Line 34: warning: comment on exported const VariableNameNotFound should be of the form "VariableNameNotFound ..." (golint)
  • Line 37: warning: comment on exported const DuplicateAlias should be of the form "DuplicateAlias ..." (golint)
  • Line 40: warning: comment on exported const DuplicateNodeID should be of the form "DuplicateNodeID ..." (golint)
  • Line 43: warning: comment on exported const MismatchingTypes should be of the form "MismatchingTypes ..." (golint)
  • Line 46: warning: comment on exported const MismatchingBindings should be of the form "MismatchingBindings ..." (golint)
  • Line 49: warning: comment on exported const MismatchingInterfaces should be of the form "MismatchingInterfaces ..." (golint)
  • Line 52: warning: comment on exported const InconsistentTypes should be of the form "InconsistentTypes ..." (golint)
  • Line 55: warning: comment on exported const ParameterBoundMoreThanOnce should be of the form "ParameterBoundMoreThanOnce ..." (golint)
  • Line 58: warning: comment on exported const ParameterNotBound should be of the form "ParameterNotBound ..." (golint)
  • Line 61: warning: comment on exported const NoEntryNodeFound should be of the form "NoEntryNodeFound ..." (golint)
  • Line 64: warning: comment on exported const UnreachableNodes should be of the form "UnreachableNodes ..." (golint)
  • Line 67: warning: comment on exported const UnrecognizedValue should be of the form "UnrecognizedValue ..." (golint)
  • Line 70: warning: comment on exported const WorkflowBuildError should be of the form "WorkflowBuildError ..." (golint)
  • Line 73: warning: comment on exported const ValueCollision should be of the form "ValueCollision ..." (golint)
  • Line 76: warning: comment on exported const SyntaxError should be of the form "SyntaxError ..." (golint)
  • Line 79: warning: comment on exported const NoNodesFound should be of the form "NoNodesFound ..." (golint)
  • Line 83: warning: exported function NewBranchNodeNotSpecified should have comment or be unexported (golint)
  • Line 91: warning: exported function NewBranchNodeHasNoCondition should have comment or be unexported (golint)
  • Line 99: warning: exported function NewBranchNodeHasNoDefault should have comment or be unexported (golint)
  • Line 107: warning: exported function NewValueRequiredErr should have comment or be unexported (golint)
  • Line 115: warning: exported function NewParameterNotBoundErr should have comment or be unexported (golint)
  • Line 123: warning: exported function NewNodeReferenceNotFoundErr should have comment or be unexported (golint)
  • Line 131: warning: exported function NewWorkflowReferenceNotFoundErr should have comment or be unexported (golint)
  • Line 139: warning: exported function NewTaskReferenceNotFoundErr should have comment or be unexported (golint)
  • Line 147: warning: exported function NewVariableNameNotFoundErr should have comment or be unexported (golint)
  • Line 155: warning: exported function NewParameterBoundMoreThanOnceErr should have comment or be unexported (golint)
  • Line 163: warning: exported function NewDuplicateAliasErr should have comment or be unexported (golint)
  • Line 171: warning: exported function NewDuplicateIDFoundErr should have comment or be unexported (golint)
  • Line 179: warning: exported function NewMismatchingTypesErr should have comment or be unexported (golint)
  • Line 188: warning: exported function NewMismatchingBindingsErr should have comment or be unexported (golint)
  • Line 196: warning: exported function NewMismatchingInterfacesErr should have comment or be unexported (golint)
  • Line 204: warning: exported function NewInconsistentTypesErr should have comment or be unexported (golint)
  • Line 212: warning: exported function NewWorkflowHasNoEntryNodeErr should have comment or be unexported (golint)
  • Line 220: warning: exported function NewCycleDetectedInWorkflowErr should have comment or be unexported (golint)
  • Line 228: warning: exported function NewUnreachableNodesErr should have comment or be unexported (golint)
  • Line 236: warning: exported function NewUnrecognizedValueErr should have comment or be unexported (golint)
  • Line 244: warning: exported function NewWorkflowBuildError should have comment or be unexported (golint)
  • Line 248: warning: exported function NewValueCollisionError should have comment or be unexported (golint)
  • Line 256: warning: exported function NewSyntaxError should have comment or be unexported (golint)
  • Line 263: warning: exported function NewNoNodesFoundErr should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/backoff/handler_map.go
  • Line 5: warning: exported type HandlerMap should have comment or be unexported (golint)
  • Line 9: warning: exported method HandlerMap.Set should have comment or be unexported (golint)
  • Line 13: warning: exported method HandlerMap.Get should have comment or be unexported (golint)

• flytepropeller/pkg/controller/handler.go
  • Line 57: warning: comment on exported function RecordSystemError should be of the form "RecordSystemError ..." (golint)
  • Line 67: warning: comment on exported type Propeller should be of the form "Propeller ..." (with optional leading article) (golint)
  • Line 75: warning: comment on exported method Propeller.Initialize should be of the form "Initialize ..." (golint)

• flytepropeller/pkg/utils/secrets/marshaler.go
  • Line 17: warning: exported const PodLabel should have comment (or a comment on this block) or be unexported (golint)
  • Line 54: warning: exported function MarshalSecretsToMapStrings should have comment or be unexported (golint)
  • Line 72: warning: exported function UnmarshalStringMapToSecrets should have comment or be unexported (golint)

• flytepropeller/pkg/utils/encoder.go
  • Line 12: warning: exported var Base32Encoder should have comment or be unexported (golint)
  • Line 14: warning: comment on exported function FixedLengthUniqueID should be of the form "FixedLengthUniqueID ..." (golint)
  • Line 33: warning: comment on exported function FixedLengthUniqueIDForParts should be of the form "FixedLengthUniqueIDForParts ..." (golint)

• flytepropeller/pkg/controller/nodes/task/taskexec_context.go
  • Line 32: warning: exported const IDMaxLength should have comment or be unexported (golint)
  • Line 33: warning: exported const DefaultMaxAttempts should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/requirements.go
  • Line 9: warning: exported type TaskIdentifier should have comment or be unexported (golint)
  • Line 10: warning: exported type LaunchPlanRefIdentifier should have comment or be unexported (golint)
  • Line 12: warning: comment on exported type WorkflowExecutionRequirements should be of the form "WorkflowExecutionRequirements ..." (with optional leading article) (golint)
  • Line 19: warning: comment on exported method WorkflowExecutionRequirements.GetRequiredTaskIds should be of the form "GetRequiredTaskIds ..." (golint)
  • Line 24: warning: comment on exported method WorkflowExecutionRequirements.GetRequiredLaunchPlanIds should be of the form "GetRequiredLaunchPlanIds ..." (golint)
  • Line 29: warning: comment on exported function GetRequirements should be of the form "GetRequirements ..." (golint)

• flytepropeller/pkg/controller/nodes/task/catalog/noop_catalog.go
  • Line 13: warning: exported type NOOPCatalog should have comment or be unexported (golint)
  • Line 16: warning: exported method NOOPCatalog.Get should have comment or be unexported (golint)
  • Line 20: warning: exported method NOOPCatalog.Put should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/subworkflow.go
  • Line 24: warning: comment on exported function GetSubWorkflow should be of the form "GetSubWorkflow ..." (golint)

• flytepropeller/pkg/controller/nodes/dynamic/handler.go
  • Line 33: warning: exported type TaskNodeHandler should have comment or be unexported (golint)
  • Line 300: warning: exported function New should have comment or be unexported (golint)

• flytepropeller/pkg/visualize/visualize.go
  • Line 48: warning: comment on exported function WorkflowToGraphViz should be of the form "WorkflowToGraphViz ..." (golint)
  • Line 142: warning: exported function ToGraphViz should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/validators/utils.go
  • Line 120: warning: exported function UnionDistinctVariableMaps should have comment or be unexported (golint)
  • Line 140: warning: comment on exported function LiteralTypeForLiteral should be of the form "LiteralTypeForLiteral ..." (golint)
  • Line 185: warning: comment on exported function LiteralToBinding should be of the form "LiteralToBinding ..." (golint)

• flytepropeller/pkg/controller/nodes/handler/transition_info.go
  • Line 13: warning: exported type EPhase should have comment or be unexported (golint)
  • Line 16: warning: exported const EPhaseUndefined should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: exported method EPhase.IsTerminal should have comment or be unexported (golint)
  • Line 36: warning: exported type DynamicNodeInfo should have comment or be unexported (golint)
  • Line 39: warning: exported type WorkflowNodeInfo should have comment or be unexported (golint)
  • Line 43: warning: exported type BranchNodeInfo should have comment or be unexported (golint)
  • Line 46: warning: comment on exported type TaskNodeInfo should be of the form "TaskNodeInfo ..." (with optional leading article) (golint)
  • Line 51: warning: exported type OutputInfo should have comment or be unexported (golint)
  • Line 55: warning: exported type ExecutionInfo should have comment or be unexported (golint)
  • Line 63: warning: exported type PhaseInfo should have comment or be unexported (golint)
  • Line 71: warning: exported method PhaseInfo.GetPhase should have comment or be unexported (golint)
  • Line 75: warning: exported method PhaseInfo.GetOccurredAt should have comment or be unexported (golint)
  • Line 79: warning: exported method PhaseInfo.GetErr should have comment or be unexported (golint)
  • Line 83: warning: exported method PhaseInfo.GetInfo should have comment or be unexported (golint)
  • Line 87: warning: exported method PhaseInfo.GetReason should have comment or be unexported (golint)
  • Line 91: warning: exported method PhaseInfo.WithInfo should have comment or be unexported (golint)
  • Line 101: warning: exported var PhaseInfoUndefined should have comment or be unexported (golint)
  • Line 113: warning: exported function PhaseInfoNotReady should have comment or be unexported (golint)
  • Line 117: warning: exported function PhaseInfoQueued should have comment or be unexported (golint)
  • Line 121: warning: exported function PhaseInfoRunning should have comment or be unexported (golint)
  • Line 125: warning: exported function PhaseInfoDynamicRunning should have comment or be unexported (golint)
  • Line 129: warning: exported function PhaseInfoSuccess should have comment or be unexported (golint)
  • Line 133: warning: exported function PhaseInfoSkip should have comment or be unexported (golint)
  • Line 137: warning: exported function PhaseInfoTimedOut should have comment or be unexported (golint)
  • Line 152: warning: exported function PhaseInfoFailure should have comment or be unexported (golint)
  • Line 156: warning: exported function PhaseInfoFailureErr should have comment or be unexported (golint)
  • Line 160: warning: exported function PhaseInfoFailingErr should have comment or be unexported (golint)
  • Line 164: warning: exported function PhaseInfoRetryableFailure should have comment or be unexported (golint)
  • Line 168: warning: exported function PhaseInfoRetryableFailureErr should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/secretmanager/secrets.go
  • Line 25: warning: exported method FileEnvSecretManager.Get should have comment or be unexported (golint)
  • Line 83: warning: exported function NewFileEnvSecretManager should have comment or be unexported (golint)

• flytepropeller/pkg/controller/completed_workflows.go
  • Line 16: warning: comment on exported function IgnoreCompletedWorkflowsLabelSelector should be of the form "IgnoreCompletedWorkflowsLabelSelector ..." (golint)
  • Line 30: warning: comment on exported function CompletedWorkflowsLabelSelector should be of the form "CompletedWorkflowsLabelSelector ..." (golint)
  • Line 39: warning: exported function SetCompletedLabel should have comment or be unexported (golint)
  • Line 47: warning: exported function HasCompletedLabel should have comment or be unexported (golint)
  • Line 57: warning: comment on exported function CalculateHoursToDelete should be of the form "CalculateHoursToDelete ..." (golint)
  • Line 76: warning: comment on exported function CompletedWorkflowsSelectorOutsideRetentionPeriod should be of the form "CompletedWorkflowsSelectorOutsideRetentionPeriod ..." (golint)

• flytepropeller/pkg/controller/nodes/handler_factory.go
  • Line 27: warning: exported type HandlerFactory should have comment or be unexported (golint)
  • Line 53: warning: exported function NewHandlerFactory should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/future_file_reader.go
  • Line 21: warning: exported type FutureFileReader should have comment or be unexported (golint)
  • Line 29: warning: exported method FutureFileReader.Exists should have comment or be unexported (golint)
  • Line 49: warning: exported method FutureFileReader.CacheExists should have comment or be unexported (golint)
  • Line 57: warning: exported method FutureFileReader.Cache should have comment or be unexported (golint)
  • Line 65: warning: exported type CacheContents should have comment or be unexported (golint)
  • Line 70: warning: exported method FutureFileReader.RetrieveCache should have comment or be unexported (golint)
  • Line 85: warning: exported function NewRemoteFutureFileReader should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/iface.go
  • Line 26: warning: exported type CustomState should have comment or be unexported (golint)
  • Line 27: warning: exported type WorkflowID should have comment or be unexported (golint)
  • Line 28: warning: exported type TaskID should have comment or be unexported (golint)
  • Line 29: warning: exported type NodeID should have comment or be unexported (golint)
  • Line 30: warning: exported type LaunchPlanRefID should have comment or be unexported (golint)
  • Line 31: warning: exported type ExecutionID should have comment or be unexported (golint)
  • Line 40: warning: exported type DataReference should have comment or be unexported (golint)
  • Line 43: warning: comment on exported const NodeKindTask should be of the form "NodeKindTask ..." (golint)
  • Line 45: warning: exported const NodeKindBranch should have comment (or a comment on this block) or be unexported (golint)
  • Line 55: warning: exported const NodePhaseNotYetStarted should have comment (or a comment on this block) or be unexported (golint)
  • Line 104: warning: exported const WorkflowPhaseReady should have comment (or a comment on this block) or be unexported (golint)
  • Line 144: warning: comment on exported type BranchNodePhase should be of the form "BranchNodePhase ..." (with optional leading article) (golint)
  • Line 148: warning: exported const BranchNodeNotYetEvaluated should have comment (or a comment on this block) or be unexported (golint)
  • Line 165: warning: comment on exported type WorkflowOnFailurePolicy should be of the form "WorkflowOnFailurePolicy ..." (with optional leading article) (golint)
  • Line 168: warning: exported method WorkflowOnFailurePolicy.MarshalJSON should have comment or be unexported (golint)
  • Line 172: warning: exported method WorkflowOnFailurePolicy.UnmarshalJSON should have comment or be unexported (golint)
  • Line 183: warning: exported function WorkflowOnFailurePolicyString should have comment or be unexported (golint)
  • Line 194: warning: comment on exported type ExecutableTask should be of the form "ExecutableTask ..." (with optional leading article) (golint)
  • Line 200: warning: comment on exported type ExecutableIfBlock should be of the form "ExecutableIfBlock ..." (with optional leading article) (golint)
  • Line 206: warning: comment on exported type ExecutableBranchNodeStatus should be of the form "ExecutableBranchNodeStatus ..." (with optional leading article) (golint)
  • Line 212: warning: exported type MutableBranchNodeStatus should have comment or be unexported (golint)
  • Line 220: warning: comment on exported type ExecutableDynamicNodeStatus should be of the form "ExecutableDynamicNodeStatus ..." (with optional leading article) (golint)
  • Line 227: warning: exported type MutableDynamicNodeStatus should have comment or be unexported (golint)
  • Line 236: warning: comment on exported type ExecutableBranchNode should be of the form "ExecutableBranchNode ..." (with optional leading article) (golint)
  • Line 245: warning: exported type ExecutableWorkflowNodeStatus should have comment or be unexported (golint)
  • Line 250: warning: exported type MutableWorkflowNodeStatus should have comment or be unexported (golint)
  • Line 257: warning: exported type Mutable should have comment or be unexported (golint)
  • Line 261: warning: exported type MutableNodeStatus should have comment or be unexported (golint)
  • Line 290: warning: exported type ExecutionTimeInfo should have comment or be unexported (golint)
  • Line 296: warning: comment on exported type ExecutableNodeStatus should be of the form "ExecutableNodeStatus ..." (with optional leading article) (golint)
  • Line 319: warning: exported type ExecutableSubWorkflowNodeStatus should have comment or be unexported (golint)
  • Line 323: warning: exported type MutableSubWorkflowNodeStatus should have comment or be unexported (golint)
  • Line 329: warning: exported type ExecutableTaskNodeStatus should have comment or be unexported (golint)
  • Line 338: warning: exported type MutableTaskNodeStatus should have comment or be unexported (golint)
  • Line 349: warning: comment on exported type ExecutableWorkflowNode should be of the form "ExecutableWorkflowNode ..." (with optional leading article) (golint)
  • Line 355: warning: exported type BaseNode should have comment or be unexported (golint)
  • Line 360: warning: comment on exported type ExecutableNode should be of the form "ExecutableNode ..." (with optional leading article) (golint)
  • Line 379: warning: comment on exported type ExecutableWorkflowStatus should be of the form "ExecutableWorkflowStatus ..." (with optional leading article) (golint)
  • Line 397: warning: exported type NodeGetter should have comment or be unexported (golint)
  • Line 401: warning: exported type BaseWorkflow should have comment or be unexported (golint)
  • Line 411: warning: exported type BaseWorkflowWithStatus should have comment or be unexported (golint)
  • Line 416: warning: comment on exported type ExecutableSubWorkflow should be of the form "ExecutableSubWorkflow ..." (with optional leading article) (golint)
  • Line 446: warning: exported type TaskDetailsGetter should have comment or be unexported (golint)
  • Line 450: warning: exported type SubWorkflowGetter should have comment or be unexported (golint)
  • Line 454: warning: exported type MetaExtended should have comment or be unexported (golint)
  • Line 461: warning: comment on exported type ExecutableWorkflow should be of the form "ExecutableWorkflow ..." (with optional leading article) (golint)
  • Line 469: warning: exported type NodeStatusGetter should have comment or be unexported (golint)
  • Line 473: warning: exported type NodeStatusMap should have comment or be unexported (golint)
  • Line 475: warning: exported type NodeStatusVisitFn should have comment or be unexported (golint)
  • Line 477: warning: exported type NodeStatusVisitor should have comment or be unexported (golint)
  • Line 481: warning: comment on exported type EnqueueWorkflow should be of the form "EnqueueWorkflow ..." (with optional leading article) (golint)
  • Line 484: warning: exported function GetOutputsFile should have comment or be unexported (golint)
  • Line 488: warning: exported function GetInputsFile should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflow/errors/errors.go
  • Line 11: warning: exported type ErrorMessage should have comment or be unexported (golint)
  • Line 13: warning: exported type WorkflowError should have comment or be unexported (golint)
  • Line 24: warning: exported type WorkflowErrorWithCause should have comment or be unexported (golint)
  • Line 33: warning: exported method WorkflowErrorWithCause.Cause should have comment or be unexported (golint)
  • Line 45: warning: exported function Errorf should have comment or be unexported (golint)
  • Line 49: warning: exported function Wrapf should have comment or be unexported (golint)
  • Line 56: warning: exported function Matches should have comment or be unexported (golint)
  • Line 64: warning: exported function GetErrorCode should have comment or be unexported (golint)

• flytepropeller/cmd/controller/cmd/init_certs.go
  • Line 32: warning: exported const CaCertKey should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/backoff/atomic_time.go
  • Line 13: warning: comment on exported method AtomicTime.Load should be of the form "Load ..." (golint)
  • Line 18: warning: comment on exported method AtomicTime.Store should be of the form "Store ..." (golint)
  • Line 23: warning: comment on exported function NewAtomicTime should be of the form "NewAtomicTime ..." (golint)

• flytepropeller/pkg/controller/nodes/task/catalog/datacatalog/transformer.go
  • Line 34: warning: comment on exported function GenerateTaskOutputsFromArtifact should be of the form "GenerateTaskOutputsFromArtifact ..." (golint)
  • Line 119: warning: comment on exported function GenerateArtifactTagName should be of the form "GenerateArtifactTagName ..." (golint)
  • Line 135: warning: comment on exported function GenerateDatasetIDForTask should be of the form "GenerateDatasetIDForTask ..." (golint)
  • Line 153: warning: exported function DatasetIDToIdentifier should have comment or be unexported (golint)
  • Line 170: warning: comment on exported function GetDatasetMetadataForSource should be of the form "GetDatasetMetadataForSource ..." (golint)
  • Line 187: warning: exported function GetArtifactMetadataForSource should have comment or be unexported (golint)
  • Line 202: warning: comment on exported function GetSourceFromMetadata should be of the form "GetSourceFromMetadata ..." (golint)
  • Line 234: warning: comment on exported function EventCatalogMetadata should be of the form "EventCatalogMetadata ..." (golint)
  • Line 256: warning: comment on exported function GetOrDefault should be of the form "GetOrDefault ..." (golint)

• flytepropeller/pkg/controller/nodes/node_exec_context.go
  • Line 22: warning: exported const NodeIDLabel should have comment or be unexported (golint)
  • Line 23: warning: exported const TaskNameLabel should have comment or be unexported (golint)
  • Line 24: warning: exported const NodeInterruptibleLabel should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/predicate.go
  • Line 15: warning: comment on exported type PredicatePhase should be of the form "PredicatePhase ..." (with optional leading article) (golint)
  • Line 19: warning: comment on exported const PredicatePhaseNotReady should be of the form "PredicatePhaseNotReady ..." (golint)
  • Line 21: warning: comment on exported const PredicatePhaseReady should be of the form "PredicatePhaseReady ..." (golint)
  • Line 23: warning: comment on exported const PredicatePhaseSkip should be of the form "PredicatePhaseSkip ..." (golint)
  • Line 25: warning: comment on exported const PredicatePhaseUndefined should be of the form "PredicatePhaseUndefined ..." (golint)
  • Line 41: warning: exported function CanExecute should have comment or be unexported (golint)
  • Line 94: warning: exported function GetParentNodeMaxEndTime should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/admin.go
  • Line 8: warning: comment on exported type LaunchPlanInterfaceProvider should be of the form "LaunchPlanInterfaceProvider ..." (with optional leading article) (golint)
  • Line 19: warning: exported method LaunchPlanInterfaceProvider.GetID should have comment or be unexported (golint)
  • Line 22: warning: exported method LaunchPlanInterfaceProvider.GetExpectedInputs should have comment or be unexported (golint)
  • Line 26: warning: exported method LaunchPlanInterfaceProvider.GetExpectedOutputs should have comment or be unexported (golint)
  • Line 30: warning: exported function NewLaunchPlanInterfaceProvider should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/branch/comparator.go
  • Line 74: warning: exported function Evaluate should have comment or be unexported (golint)
  • Line 117: warning: exported function Evaluate1 should have comment or be unexported (golint)
  • Line 124: warning: exported function Evaluate2 should have comment or be unexported (golint)
  • Line 131: warning: exported function EvaluateLiterals should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/secretmanager/config.go
  • Line 7: warning: exported const SectionKey should have comment or be unexported (golint)
  • Line 18: warning: exported type Config should have comment or be unexported (golint)
  • Line 23: warning: exported function GetConfig should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/resourcemanager.go
  • Line 16: warning: exported type TokenPrefix should have comment or be unexported (golint)
  • Line 17: warning: exported type Token should have comment or be unexported (golint)
  • Line 46: warning: exported function ComposeTokenPrefix should have comment or be unexported (golint)
  • Line 50: warning: comment on exported type Resource should be of the form "Resource ..." (with optional leading article) (golint)
  • Line 57: warning: exported type Metrics should have comment or be unexported (golint)
  • Line 61: warning: exported type Builder should have comment or be unexported (golint)
  • Line 67: warning: comment on exported type Proxy should be of the form "Proxy ..." (with optional leading article) (golint)
  • Line 80: warning: exported type TaskResourceManager should have comment or be unexported (golint)
  • Line 85: warning: exported method Proxy.ComposeResourceConstraint should have comment or be unexported (golint)
  • Line 96: warning: exported method Proxy.AllocateResource should have comment or be unexported (golint)
  • Line 113: warning: exported method Proxy.ReleaseResource should have comment or be unexported (golint)
  • Line 121: warning: exported method Proxy.GetResourcePoolInfo should have comment or be unexported (golint)
  • Line 129: warning: exported function GetTaskResourceManager should have comment or be unexported (golint)
  • Line 139: warning: comment on exported type ResourceRegistrarProxy should be of the form "ResourceRegistrarProxy ..." (with optional leading article) (golint)
  • Line 145: warning: exported method ResourceRegistrarProxy.RegisterResourceQuota should have comment or be unexported (golint)
  • Line 150: warning: exported type BaseResourceManager should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/errors/error.go
  • Line 1: warning: package comment should be of the form "Package errors ..." (golint)
  • Line 7: warning: exported type ErrorCode should have comment or be unexported (golint)
  • Line 9: warning: comment on exported type CompileError should be of the form "CompileError ..." (with optional leading article) (golint)
  • Line 17: warning: comment on exported type CompileErrorWithCause should be of the form "CompileErrorWithCause ..." (with optional leading article) (golint)
  • Line 23: warning: comment on exported type CompileErrors should be of the form "CompileErrors ..." (with optional leading article) (golint)
  • Line 39: warning: comment on exported method CompileError.Code should be of the form "Code ..." (golint)
  • Line 122: warning: comment on exported function NewCompileErrors should be of the form "NewCompileErrors ..." (golint)

• flytepropeller/pkg/controller/nodes/handler/state.go
  • Line 15: warning: exported type TaskNodeState should have comment or be unexported (golint)
  • Line 24: warning: exported type BranchNodeState should have comment or be unexported (golint)
  • Line 29: warning: exported type DynamicNodePhase should have comment or be unexported (golint)
  • Line 31: warning: exported type DynamicNodeState should have comment or be unexported (golint)
  • Line 37: warning: exported type WorkflowNodeState should have comment or be unexported (golint)
  • Line 42: warning: exported type NodeStateWriter should have comment or be unexported (golint)
  • Line 49: warning: exported type NodeStateReader should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/handler/transition.go
  • Line 3: warning: exported type TransitionType should have comment or be unexported (golint)
  • Line 6: warning: exported const TransitionTypeEphemeral should have comment (or a comment on this block) or be unexported (golint)
  • Line 10: warning: exported type Transition should have comment or be unexported (golint)
  • Line 15: warning: exported method Transition.Type should have comment or be unexported (golint)
  • Line 19: warning: exported method Transition.Info should have comment or be unexported (golint)
  • Line 23: warning: exported method Transition.WithInfo should have comment or be unexported (golint)
  • Line 28: warning: exported var UnknownTransition should have comment or be unexported (golint)
  • Line 30: warning: exported function DoTransition should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/plugin_state_manager.go
  • Line 13: warning: exported type CodecVersion should have comment or be unexported (golint)
  • Line 16: warning: exported const GobCodecVersion should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/webhook/global_secrets.go
  • Line 15: warning: exported type GlobalSecretProvider should have comment or be unexported (golint)
  • Line 26: warning: exported method GlobalSecrets.ID should have comment or be unexported (golint)
  • Line 30: warning: exported method GlobalSecrets.Inject should have comment or be unexported (golint)
  • Line 72: warning: exported function NewGlobalSecrets should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/tasks.go
  • Line 10: warning: exported type TaskSpec should have comment or be unexported (golint)
  • Line 14: warning: exported method TaskSpec.TaskType should have comment or be unexported (golint)
  • Line 18: warning: exported method TaskSpec.CoreTask should have comment or be unexported (golint)
  • Line 22: warning: exported method TaskSpec.DeepCopyInto should have comment or be unexported (golint)
  • Line 28: warning: exported method TaskSpec.MarshalJSON should have comment or be unexported (golint)
  • Line 36: warning: exported method TaskSpec.UnmarshalJSON should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/visualize.go
  • Line 12: warning: exported type VisualizeOpts should have comment or be unexported (golint)
  • Line 16: warning: exported function NewVisualizeCommand should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/resourcemanager/redis_resourcemanager.go
  • Line 18: warning: comment on exported const RedisSetKeyPrefix should be of the form "RedisSetKeyPrefix ..." (golint)
  • Line 22: warning: exported type RedisResourceManagerBuilder should have comment or be unexported (golint)
  • Line 28: warning: exported method RedisResourceManagerBuilder.GetID should have comment or be unexported (golint)
  • Line 32: warning: exported method RedisResourceManagerBuilder.GetResourceRegistrar should have comment or be unexported (golint)
  • Line 39: warning: exported method RedisResourceManagerBuilder.RegisterResourceQuota should have comment or be unexported (golint)
  • Line 67: warning: exported method RedisResourceManagerBuilder.BuildResourceManager should have comment or be unexported (golint)
  • Line 95: warning: exported function NewRedisResourceManagerBuilder should have comment or be unexported (golint)
  • Line 105: warning: exported type RedisResourceManager should have comment or be unexported (golint)
  • Line 111: warning: exported type RedisResourceManagerMetrics should have comment or be unexported (golint)
  • Line 118: warning: exported method RedisResourceManagerMetrics.GetScope should have comment or be unexported (golint)
  • Line 160: warning: exported function NewRedisResourceManagerMetrics should have comment or be unexported (golint)
  • Line 174: warning: exported method RedisResourceManager.GetID should have comment or be unexported (golint)
  • Line 213: warning: exported method RedisResourceManager.AllocateResource should have comment or be unexported (golint)
  • Line 274: warning: exported method RedisResourceManager.ReleaseResource should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/remote_workflow_store.go
  • Line 17: warning: exported type RemoteFileWorkflowStore should have comment or be unexported (golint)
  • Line 21: warning: exported method RemoteFileWorkflowStore.Exists should have comment or be unexported (golint)
  • Line 31: warning: exported method RemoteFileWorkflowStore.PutFlyteWorkflowCRD should have comment or be unexported (golint)
  • Line 40: warning: exported method RemoteFileWorkflowStore.PutCompiledFlyteWorkflow should have comment or be unexported (golint)
  • Line 64: warning: exported method RemoteFileWorkflowStore.GetWorkflowCRD should have comment or be unexported (golint)
  • Line 74: warning: exported method RemoteFileWorkflowStore.GetCompiledWorkflow should have comment or be unexported (golint)
  • Line 80: warning: exported function NewRemoteWorkflowStore should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go
  • Line 15: warning: exported type OutputVarMap should have comment or be unexported (golint)
  • Line 19: warning: exported method OutputVarMap.MarshalJSON should have comment or be unexported (golint)
  • Line 28: warning: exported method OutputVarMap.UnmarshalJSON should have comment or be unexported (golint)
  • Line 40: warning: exported type Binding should have comment or be unexported (golint)
  • Line 44: warning: exported method Binding.UnmarshalJSON should have comment or be unexported (golint)
  • Line 49: warning: exported method Binding.MarshalJSON should have comment or be unexported (golint)
  • Line 65: warning: comment on exported type RetryStrategy should be of the form "RetryStrategy ..." (with optional leading article) (golint)
  • Line 74: warning: exported type Alias should have comment or be unexported (golint)
  • Line 85: warning: exported type NodeMetadata should have comment or be unexported (golint)
  • Line 89: warning: exported method NodeMetadata.DeepCopyInto should have comment or be unexported (golint)
  • Line 95: warning: exported type NodeSpec should have comment or be unexported (golint)
  • Line 149: warning: exported method NodeSpec.GetName should have comment or be unexported (golint)
  • Line 153: warning: exported method NodeSpec.GetRetryStrategy should have comment or be unexported (golint)
  • Line 157: warning: exported method NodeSpec.GetExecutionDeadline should have comment or be unexported (golint)
  • Line 164: warning: exported method NodeSpec.GetActiveDeadline should have comment or be unexported (golint)
  • Line 171: warning: exported method NodeSpec.IsInterruptible should have comment or be unexported (golint)
  • Line 175: warning: exported method NodeSpec.GetConfig should have comment or be unexported (golint)
  • Line 179: warning: exported method NodeSpec.GetResources should have comment or be unexported (golint)
  • Line 183: warning: exported method NodeSpec.GetOutputAlias should have comment or be unexported (golint)
  • Line 187: warning: exported method NodeSpec.GetWorkflowNode should have comment or be unexported (golint)
  • Line 194: warning: exported method NodeSpec.GetBranchNode should have comment or be unexported (golint)
  • Line 201: warning: exported method NodeSpec.GetTaskID should have comment or be unexported (golint)
  • Line 205: warning: exported method NodeSpec.GetKind should have comment or be unexported (golint)
  • Line 209: warning: exported method NodeSpec.GetID should have comment or be unexported (golint)
  • Line 213: warning: exported method NodeSpec.IsStartNode should have comment or be unexported (golint)
  • Line 217: warning: exported method NodeSpec.IsEndNode should have comment or be unexported (golint)
  • Line 221: warning: exported method NodeSpec.GetInputBindings should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflow/executor.go
  • Line 37: warning: exported type Status should have comment or be unexported (golint)
  • Line 42: warning: exported var StatusReady should have comment or be unexported (golint)
  • Line 43: warning: exported var StatusRunning should have comment or be unexported (golint)
  • Line 44: warning: exported var StatusSucceeding should have comment or be unexported (golint)
  • Line 45: warning: exported var StatusSuccess should have comment or be unexported (golint)
  • Line 47: warning: exported function StatusFailureNode should have comment or be unexported (golint)
  • Line 51: warning: exported function StatusFailing should have comment or be unexported (golint)
  • Line 55: warning: exported function StatusFailed should have comment or be unexported (golint)
  • Line 479: warning: exported function NewExecutor should have comment or be unexported (golint)

• flytepropeller/pkg/utils/bindings.go
  • Line 5: warning: exported function MakeBindingDataPromise should have comment or be unexported (golint)
  • Line 16: warning: exported function MakeBindingPromise should have comment or be unexported (golint)
  • Line 23: warning: exported function MakeBindingDataCollection should have comment or be unexported (golint)
  • Line 33: warning: exported type Pair should have comment or be unexported (golint)
  • Line 38: warning: exported function NewPair should have comment or be unexported (golint)
  • Line 42: warning: exported function MakeBindingDataMap should have comment or be unexported (golint)
  • Line 56: warning: exported function MakePrimitiveBindingData should have comment or be unexported (golint)
  • Line 72: warning: exported function MustMakePrimitiveBindingData should have comment or be unexported (golint)
  • Line 80: warning: exported function MakeBinding should have comment or be unexported (golint)

• flytepropeller/pkg/controller/garbage_collector.go
  • Line 28: warning: comment on exported type GarbageCollector should be of the form "GarbageCollector ..." (with optional leading article) (golint)
  • Line 115: warning: comment on exported method GarbageCollector.StartGC should be of the form "StartGC ..." (golint)
  • Line 126: warning: exported function NewGarbageCollector should have comment or be unexported (golint)

• flytepropeller/pkg/utils/literals.go
  • Line 12: warning: exported function MakePrimitive should have comment or be unexported (golint)
  • Line 65: warning: exported function MustMakePrimitive should have comment or be unexported (golint)
  • Line 73: warning: exported function MakePrimitiveLiteral should have comment or be unexported (golint)
  • Line 89: warning: exported function MustMakePrimitiveLiteral should have comment or be unexported (golint)
  • Line 97: warning: exported function MakeLiteralForMap should have comment or be unexported (golint)
  • Line 110: warning: exported function MakeLiteralForCollection should have comment or be unexported (golint)
  • Line 130: warning: exported function MakeBinaryLiteral should have comment or be unexported (golint)
  • Line 144: warning: exported function MakeLiteral should have comment or be unexported (golint)
  • Line 170: warning: exported function MustMakeDefaultLiteralForType should have comment or be unexported (golint)
  • Line 178: warning: exported function MakeDefaultLiteralForType should have comment or be unexported (golint)
  • Line 253: warning: exported function MustMakeLiteral should have comment or be unexported (golint)
  • Line 262: warning: exported function MakeLiteralMap should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/barrier.go
  • Line 13: warning: exported type BarrierKey should have comment or be unexported (golint)
  • Line 15: warning: exported type PluginCallLog should have comment or be unexported (golint)
  • Line 19: warning: exported type BarrierTransition should have comment or be unexported (golint)
  • Line 24: warning: exported var NoBarrierTransition should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/handler.go
  • Line 58: warning: exported type MetricKey should have comment or be unexported (golint)
  • Line 149: warning: comment on exported type PluginRegistryIface should be of the form "PluginRegistryIface ..." (with optional leading article) (golint)
  • Line 158: warning: exported type Handler should have comment or be unexported (golint)
  • Line 175: warning: exported method Handler.FinalizeRequired should have comment or be unexported (golint)
  • Line 189: warning: exported method Handler.Setup should have comment or be unexported (golint)
  • Line 283: warning: exported method Handler.ResolvePlugin should have comment or be unexported (golint)
  • Line 466: warning: exported method Handler.Handle should have comment or be unexported (golint)
  • Line 650: warning: exported method Handler.Abort should have comment or be unexported (golint)
  • Line 713: warning: exported method Handler.Finalize should have comment or be unexported (golint)
  • Line 741: warning: exported function New should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/errors/errors.go
  • Line 10: warning: exported type ErrorMessage should have comment or be unexported (golint)
  • Line 12: warning: exported type NodeError should have comment or be unexported (golint)
  • Line 18: warning: exported method NodeError.Code should have comment or be unexported (golint)
  • Line 26: warning: exported type NodeErrorWithCause should have comment or be unexported (golint)
  • Line 31: warning: exported method NodeErrorWithCause.Code should have comment or be unexported (golint)
  • Line 53: warning: exported method NodeErrorWithCause.Cause should have comment or be unexported (golint)
  • Line 65: warning: exported function Errorf should have comment or be unexported (golint)
  • Line 69: warning: exported function Wrapf should have comment or be unexported (golint)
  • Line 76: warning: exported function Matches should have comment or be unexported (golint)
  • Line 84: warning: exported function GetErrorCode should have comment or be unexported (golint)
  • Line 104: warning: exported type ErrorCollection should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/task/catalog/config.go
  • Line 15: warning: exported const ConfigSectionKey should have comment or be unexported (golint)
  • Line 25: warning: exported type DiscoveryType should have comment or be unexported (golint)
  • Line 28: warning: exported const NoOpDiscoveryType should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported type Config should have comment or be unexported (golint)
  • Line 39: warning: comment on exported function GetConfig should be of the form "GetConfig ..." (golint)
  • Line 44: warning: exported function NewCatalogClient should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/launchplan/launchplan.go
  • Line 12: warning: comment on exported type LaunchContext should be of the form "LaunchContext ..." (with optional leading article) (golint)
  • Line 23: warning: comment on exported type Executor should be of the form "Executor ..." (with optional leading article) (golint)
  • Line 38: warning: exported type Reader should have comment or be unexported (golint)
  • Line 43: warning: exported type FlyteAdmin should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/subworkflow/handler.go
  • Line 128: warning: exported function New should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/transformers.go
  • Line 23: warning: exported function ToNodeExecOutput should have comment or be unexported (golint)
  • Line 33: warning: exported function ToNodeExecWorkflowNodeMetadata should have comment or be unexported (golint)
  • Line 44: warning: exported function ToNodeExecTaskNodeMetadata should have comment or be unexported (golint)
  • Line 53: warning: exported function ToNodeExecEventPhase should have comment or be unexported (golint)
  • Line 72: warning: exported function ToNodeExecutionEvent should have comment or be unexported (golint)
  • Line 149: warning: exported function ToNodePhase should have comment or be unexported (golint)
  • Line 173: warning: exported function ToK8sTime should have comment or be unexported (golint)
  • Line 177: warning: exported function UpdateNodeStatus should have comment or be unexported (golint)

• flytepropeller/pkg/controller/nodes/var_name_parser.go
  • Line 11: warning: comment on exported function ParseVarName should be of the form "ParseVarName ..." (golint)

• flytepropeller/hack/tools.go
  • Line 1: warning: package comment should be of the form "Package tools ..." (golint)

• flytepropeller/pkg/apis/flyteworkflow/v1alpha1/workflow.go
  • Line 18: warning: exported const StartNodeID should have comment or be unexported (golint)
  • Line 19: warning: exported const EndNodeID should have comment or be unexported (golint)
  • Line 24: warning: comment on exported type FlyteWorkflow should be of the form "FlyteWorkflow ..." (with optional leading article) (golint)
  • Line 64: warning: exported method FlyteWorkflow.GetSecurityContext should have comment or be unexported (golint)
  • Line 68: warning: exported method FlyteWorkflow.GetEventVersion should have comment or be unexported (golint)
  • Line 75: warning: exported method FlyteWorkflow.GetExecutionConfig should have comment or be unexported (golint)
  • Line 79: warning: exported type WorkflowMeta should have comment or be unexported (golint)
  • Line 83: warning: exported type EventVersion should have comment or be unexported (golint)
  • Line 86: warning: exported const EventVersion0 should have comment (or a comment on this block) or be unexported (golint)
  • Line 91: warning: exported type NodeDefaults should have comment or be unexported (golint)
  • Line 96: warning: exported var FlyteWorkflowGVK should have comment or be unexported (golint)
  • Line 98: warning: exported method FlyteWorkflow.GetOwnerReference should have comment or be unexported (golint)
  • Line 107: warning: exported method FlyteWorkflow.GetTask should have comment or be unexported (golint)
  • Line 115: warning: exported method FlyteWorkflow.GetExecutionStatus should have comment or be unexported (golint)
  • Line 121: warning: exported method FlyteWorkflow.GetK8sWorkflowID should have comment or be unexported (golint)
  • Line 128: warning: exported method FlyteWorkflow.GetExecutionID should have comment or be unexported (golint)
  • Line 132: warning: exported method FlyteWorkflow.FindSubWorkflow should have comment or be unexported (golint)
  • Line 140: warning: exported method FlyteWorkflow.GetNodeExecutionStatus should have comment or be unexported (golint)
  • Line 144: warning: exported method FlyteWorkflow.GetServiceAccountName should have comment or be unexported (golint)
  • Line 148: warning: exported method FlyteWorkflow.IsInterruptible should have comment or be unexported (golint)
  • Line 152: warning: exported method FlyteWorkflow.GetRawOutputDataConfig should have comment or be unexported (golint)
  • Line 156: warning: exported type Inputs should have comment or be unexported (golint)
  • Line 160: warning: exported method Inputs.UnmarshalJSON should have comment or be unexported (golint)
  • Line 165: warning: exported method Inputs.MarshalJSON should have comment or be unexported (golint)
  • Line 184: warning: exported type Connections should have comment or be unexported (golint)
  • Line 189: warning: exported method Connections.UnmarshalJSON should have comment or be unexported (golint)
  • Line 207: warning: exported method Connections.MarshalJSON should have comment or be unexported (golint)
  • Line 244: warning: exported method WorkflowSpec.StartNode should have comment or be unexported (golint)
  • Line 252: warning: exported method WorkflowSpec.GetID should have comment or be unexported (golint)
  • Line 256: warning: exported method WorkflowSpec.ToNode should have comment or be unexported (golint)
  • Line 264: warning: exported method WorkflowSpec.FromNode should have comment or be unexported (golint)
  • Line 273: warning: exported method WorkflowSpec.GetOnFailurePolicy should have comment or be unexported (golint)
  • Line 277: warning: exported method WorkflowSpec.GetOutputs should have comment or be unexported (golint)
  • Line 281: warning: exported method WorkflowSpec.GetNode should have comment or be unexported (golint)
  • Line 286: warning: exported method WorkflowSpec.GetConnections should have comment or be unexported (golint)
  • Line 290: warning: exported method WorkflowSpec.GetOutputBindings should have comment or be unexported (golint)
  • Line 294: warning: exported method WorkflowSpec.GetOnFailureNode should have comment or be unexported (golint)
  • Line 301: warning: exported method WorkflowSpec.GetNodes should have comment or be unexported (golint)
  • Line 309: warning: comment on exported type FlyteWorkflowList should be of the form "FlyteWorkflowList ..." (with optional leading article) (golint)

• flytepropeller/pkg/controller/nodes/task/backoff/controller.go
  • Line 25: warning: exported method Controller.GetOrCreateHandler should have comment or be unexported (golint)
  • Line 51: warning: exported method Controller.GetBackOffHandler should have comment or be unexported (golint)
  • Line 55: warning: exported function ComposeResourceKey should have comment or be unexported (golint)
  • Line 59: warning: exported function NewController should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workqueue.go
  • Line 16: warning: exported function NewWorkQueue should have comment or be unexported (golint)

• flytepropeller/pkg/apis/flyteworkflow/register.go
  • Line 4: warning: exported const GroupName should have comment (or a comment on this block) or be unexported (golint)

• flytepropeller/pkg/compiler/common/id_set.go
  • Line 9: warning: exported type Empty should have comment or be unexported (golint)
  • Line 10: warning: exported type Identifier should have comment or be unexported (golint)
  • Line 11: warning: exported type IdentifierSet should have comment or be unexported (golint)
  • Line 13: warning: comment on exported function NewIdentifierSet should be of the form "NewIdentifierSet ..." (golint)

• flytepropeller/pkg/controller/nodes/task/fakeplugins/task_replayer_plugin.go
  • Line 10: warning: exported type HandleResponse should have comment or be unexported (golint)
  • Line 15: warning: exported function NewHandleTransition should have comment or be unexported (golint)
  • Line 22: warning: exported function NewHandleError should have comment or be unexported (golint)
  • Line 35: warning: comment on exported type ReplayerPlugin should be of the form "ReplayerPlugin ..." (with optional leading article) (golint)
  • Line 47: warning: exported method ReplayerPlugin.GetID should have comment or be unexported (golint)
  • Line 51: warning: exported method ReplayerPlugin.GetProperties should have comment or be unexported (golint)
  • Line 55: warning: exported method ReplayerPlugin.Handle should have comment or be unexported (golint)
  • Line 72: warning: exported method ReplayerPlugin.Abort should have comment or be unexported (golint)
  • Line 88: warning: exported method ReplayerPlugin.Finalize should have comment or be unexported (golint)
  • Line 104: warning: exported method ReplayerPlugin.VerifyAllCallsCompleted should have comment or be unexported (golint)
  • Line 122: warning: exported function NewReplayer should have comment or be unexported (golint)

• flytepropeller/pkg/controller/workflowstore/factory.go
  • Line 12: warning: exported function NewWorkflowStore should have comment or be unexported (golint)

• flytepropeller/pkg/compiler/transformers/k8s/workflow.go
  • Line 1: warning: package comment should be of the form "Package k8s ..." (golint)
  • Line 16: warning: exported const ExecutionIDLabel should have comment or be unexported (golint)
  • Line 17: warning: exported const WorkflowNameLabel should have comment or be unexported (golint)
  • Line 29: warning: comment on exported function WorkflowIDAsString should be of the form "WorkflowIDAsString ..." (golint)
  • Line 60: warning: exported function WorkflowNameFromID should have comment or be unexported (golint)
  • Line 139: warning: comment on exported function BuildFlyteWorkflow should be of the form "BuildFlyteWorkflow ..." (golint)

• flytepropeller/pkg/compiler/validators/typing.go
  • Line 152: warning: exported function AreTypesCastable should have comment or be unexported (golint)

• flytepropeller/cmd/kubectl-flyte/cmd/get.go
  • Line 19: warning: exported type GetOpts should have comment or be unexported (golint)
  • Line 27: warning: exported function NewGetCommand should have comment or be unexported (golint)
  • Line 158: warning: exported function Header should have comment or be unexported (golint)
  • Line 188: warning: exported type SortableNSDist should have comment or be unexported (golint)

• flytepropeller/pkg/utils/assert/literals.go
  • Line 11: warning: exported function EqualPrimitive should have comment or be unexported (golint)
  • Line 29: warning: exported function EqualScalar should have comment or be unexported (golint)
  • Line 45: warning: exported function EqualLiterals should have comment or be unexported (golint)
  • Line 63: warning: exported function EqualLiteralMap should have comment or be unexported (golint)
  • Line 74: warning: exported function EqualLiteralCollection should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

• flytepropeller/pkg/webhook/pod.go
  • Line 114: warning: ineffectual assignment to tempChanged (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!