Go Report Card

Preparing report...

Report for github.com/foxdalas/nodeup

A    Great!    Found 21 issues across 23 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint8%

Golint is a linter for Go source code.

    • nodeup/pkg/chef/type.go
    • Line 9: warning: exported type Chef should have comment or be unexported (golint)
    • Line 20: warning: exported type Config should have comment or be unexported (golint)
    • Line 27: warning: exported type Hosts should have comment or be unexported (golint)
    • Line 32: warning: exported type Bootstrap should have comment or be unexported (golint)
    • Line 36: warning: exported type ChefClient should have comment or be unexported (golint)
    • nodeup/pkg/nodeup_const/interfaces.go
    • Line 7: warning: exported type NodeUP should have comment or be unexported (golint)
    • Line 12: warning: exported type Openstack should have comment or be unexported (golint)
    • Line 16: warning: exported type Ssh should have comment or be unexported (golint)
    • Line 19: warning: exported type ChefClient should have comment or be unexported (golint)
    • nodeup/pkg/chef/chef.go
    • Line 12: warning: exported function New should have comment or be unexported (golint)
    • Line 96: warning: exported method Chef.Log should have comment or be unexported (golint)
    • Line 101: warning: exported function NewChefClient should have comment or be unexported (golint)
    • Line 140: warning: exported method ChefClient.CleanupNode should have comment or be unexported (golint)
    • Line 163: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 174: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • nodeup/pkg/nodeup/nodeup.go
    • Line 26: warning: exported function New should have comment or be unexported (golint)
    • Line 35: warning: exported method NodeUP.Init should have comment or be unexported (golint)
    • Line 183: warning: exported method NodeUP.Stop should have comment or be unexported (golint)
    • Line 189: warning: exported method NodeUP.Log should have comment or be unexported (golint)
    • Line 193: warning: exported method NodeUP.Version should have comment or be unexported (golint)
    • Line 229: warning: exported method NodeUP.GetAddress should have comment or be unexported (golint)
    • Line 251: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 305: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 457: warning: exported method NodeUP.DeleteWhitespaces should have comment or be unexported (golint)
    • nodeup/pkg/rest/type.go
    • Line 9: warning: exported type Echo should have comment or be unexported (golint)
    • Line 15: warning: exported type SetupHost should have comment or be unexported (golint)
    • Line 21: warning: exported type WebSocketLog should have comment or be unexported (golint)
    • Line 31: warning: exported type Progress should have comment or be unexported (golint)
    • Line 36: warning: exported type SimpleResponse should have comment or be unexported (golint)
    • Line 41: warning: exported type HypervisorName should have comment or be unexported (golint)
    • nodeup/pkg/ssh/ssh.go
    • Line 16: warning: exported function New should have comment or be unexported (golint)
    • Line 58: warning: exported method Ssh.Log should have comment or be unexported (golint)
    • Line 63: warning: receiver name s should be consistent with previous receiver name o for Ssh (golint)
    • Line 71: warning: exported method Ssh.RunCommand should have comment or be unexported (golint)
    • Line 71: warning: receiver name s should be consistent with previous receiver name o for Ssh (golint)
    • Line 91: warning: exported method Ssh.RunCommandPipe should have comment or be unexported (golint)
    • Line 91: warning: receiver name s should be consistent with previous receiver name o for Ssh (golint)
    • Line 115: warning: exported method Ssh.TransferFile should have comment or be unexported (golint)
    • Line 115: warning: receiver name s should be consistent with previous receiver name o for Ssh (golint)
    • nodeup/pkg/openstack/type.go
    • Line 13: warning: exported type Openstack should have comment or be unexported (golint)
    • Line 24: warning: exported type Server should have comment or be unexported (golint)
    • Line 99: warning: exported type Fault should have comment or be unexported (golint)
    • nodeup/main.go
    • Line 7: warning: exported var AppVersion should have comment or be unexported (golint)
    • Line 8: warning: exported var AppGitCommit should have comment or be unexported (golint)
    • Line 9: warning: exported var AppGitState should have comment or be unexported (golint)
    • Line 11: warning: exported function Version should have comment or be unexported (golint)
    • nodeup/pkg/cmd/cmd.go
    • Line 19: warning: exported function Run should have comment or be unexported (golint)
    • Line 161: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 173: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 185: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 193: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 220: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • nodeup/pkg/openstack/openstack.go
    • Line 27: warning: exported function New should have comment or be unexported (golint)
    • Line 150: warning: exported method Openstack.CreateSever should have comment or be unexported (golint)
    • Line 259: warning: exported method Openstack.GetServer should have comment or be unexported (golint)
    • Line 268: warning: exported method Openstack.GetServerDetail should have comment or be unexported (golint)
    • Line 278: warning: exported method Openstack.GetHypervisors should have comment or be unexported (golint)
    • Line 292: warning: exported method Openstack.GetHypervisorInfo should have comment or be unexported (golint)
    • Line 302: warning: exported method Openstack.GetHypervisorStatistics should have comment or be unexported (golint)
    • Line 311: warning: exported method Openstack.GetServers should have comment or be unexported (golint)
    • Line 326: warning: exported method Openstack.GetFlavors should have comment or be unexported (golint)
    • Line 344: warning: exported method Openstack.GetFlavorInfo should have comment or be unexported (golint)
    • Line 354: warning: exported method Openstack.StartServer should have comment or be unexported (golint)
    • Line 358: warning: exported method Openstack.StopServer should have comment or be unexported (golint)
    • Line 362: warning: comment on exported method Openstack.HypervisorScheduler should be of the form "HypervisorScheduler ..." (golint)
    • Line 382: warning: exported method Openstack.GetHypervisorWithSensitiveCriteria should have comment or be unexported (golint)
    • Line 398: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 404: warning: exported method Openstack.DeleteServer should have comment or be unexported (golint)
    • Line 415: warning: exported method Openstack.DeleteIfError should have comment or be unexported (golint)
    • Line 423: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 428: warning: exported method Openstack.IDFromName should have comment or be unexported (golint)
    • Line 469: warning: exported method Openstack.Migrate should have comment or be unexported (golint)
    • Line 480: warning: exported method Openstack.MigrateHost should have comment or be unexported (golint)
    • nodeup/pkg/rest/rest.go
    • Line 15: warning: exported function Init should have comment or be unexported (golint)
    • Line 79: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • nodeup/pkg/nodeup/type.go
    • Line 10: warning: exported type NodeUP should have comment or be unexported (golint)
    • Line 78: warning: exported type Interfaces should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!