Report for github.com/franela/goblin
A+ Excellent! Found 4 issues across 12 files
gofmt91%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
goblin/mono_reporter.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint66%
Golint is a linter for Go source code.
-
-
goblin/resolver.go
- Line 8: warning: exported function ResolveStack should have comment or be unexported (golint)
-
-
goblin/goblin.go
- Line 13: warning: exported type Done should have comment or be unexported (golint)
- Line 15: warning: exported type Runnable should have comment or be unexported (golint)
- Line 19: warning: exported type Itable should have comment or be unexported (golint)
- Line 24: warning: exported method G.Describe should have comment or be unexported (golint)
- Line 46: warning: exported method G.Timeout should have comment or be unexported (golint)
- Line 51: warning: exported type Describe should have comment or be unexported (golint)
- Line 120: warning: exported type Failure should have comment or be unexported (golint)
- Line 126: warning: exported type It should have comment or be unexported (golint)
- Line 168: warning: exported type Xit should have comment or be unexported (golint)
- Line 204: warning: exported function Goblin should have comment or be unexported (golint)
- Line 271: warning: exported type G should have comment or be unexported (golint)
- Line 283: warning: exported method G.SetReporter should have comment or be unexported (golint)
- Line 287: warning: exported method G.It should have comment or be unexported (golint)
- Line 301: warning: exported method G.Xit should have comment or be unexported (golint)
- Line 326: warning: exported method G.Before should have comment or be unexported (golint)
- Line 330: warning: exported method G.BeforeEach should have comment or be unexported (golint)
- Line 334: warning: exported method G.JustBeforeEach should have comment or be unexported (golint)
- Line 338: warning: exported method G.After should have comment or be unexported (golint)
- Line 342: warning: exported method G.AfterEach should have comment or be unexported (golint)
- Line 346: warning: exported method G.Assert should have comment or be unexported (golint)
- Line 377: warning: exported method G.Fail should have comment or be unexported (golint)
- Line 382: warning: exported method G.FailNow should have comment or be unexported (golint)
- Line 386: warning: exported method G.Failf should have comment or be unexported (golint)
- Line 391: warning: exported method G.Fatalf should have comment or be unexported (golint)
- Line 396: warning: exported method G.Errorf should have comment or be unexported (golint)
- Line 401: warning: exported method G.Helper should have comment or be unexported (golint)
-
-
goblin/mono_reporter.go
- Line 5: warning: exported type Monochrome should have comment or be unexported (golint)
- Line 8: warning: exported method Monochrome.Red should have comment or be unexported (golint)
- Line 8: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 12: warning: exported method Monochrome.Gray should have comment or be unexported (golint)
- Line 12: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 16: warning: exported method Monochrome.Cyan should have comment or be unexported (golint)
- Line 16: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 20: warning: exported method Monochrome.WithCheck should have comment or be unexported (golint)
- Line 20: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 24: warning: exported method Monochrome.Green should have comment or be unexported (golint)
- Line 24: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 28: warning: exported method Monochrome.Yellow should have comment or be unexported (golint)
- Line 28: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
-
-
goblin/reporting.go
- Line 11: warning: exported type Reporter should have comment or be unexported (golint)
- Line 24: warning: exported type TextFancier should have comment or be unexported (golint)
- Line 33: warning: exported type DetailedReporter should have comment or be unexported (golint)
- Line 41: warning: exported method DetailedReporter.SetTextFancier should have comment or be unexported (golint)
- Line 45: warning: exported type TerminalFancier should have comment or be unexported (golint)
- Line 48: warning: exported method TerminalFancier.Red should have comment or be unexported (golint)
- Line 48: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 52: warning: exported method TerminalFancier.Gray should have comment or be unexported (golint)
- Line 52: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 56: warning: exported method TerminalFancier.Cyan should have comment or be unexported (golint)
- Line 56: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 60: warning: exported method TerminalFancier.Green should have comment or be unexported (golint)
- Line 60: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 64: warning: exported method TerminalFancier.Yellow should have comment or be unexported (golint)
- Line 64: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 68: warning: exported method TerminalFancier.WithCheck should have comment or be unexported (golint)
- Line 68: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
- Line 76: warning: exported method DetailedReporter.Failure should have comment or be unexported (golint)
- Line 88: warning: exported method DetailedReporter.BeginDescribe should have comment or be unexported (golint)
- Line 94: warning: exported method DetailedReporter.EndDescribe should have comment or be unexported (golint)
- Line 98: warning: exported method DetailedReporter.ItTook should have comment or be unexported (golint)
- Line 105: warning: exported method DetailedReporter.ItFailed should have comment or be unexported (golint)
- Line 110: warning: exported method DetailedReporter.ItPassed should have comment or be unexported (golint)
- Line 115: warning: exported method DetailedReporter.ItIsPending should have comment or be unexported (golint)
- Line 120: warning: exported method DetailedReporter.ItIsExcluded should have comment or be unexported (golint)
- Line 125: warning: exported method DetailedReporter.Begin should have comment or be unexported (golint)
- Line 128: warning: exported method DetailedReporter.End should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!