Go Report Card

Preparing report...

Report for github.com/franizus/iso8583

A+    Excellent!    Found 39 issues across 67 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint41%

Golint is a linter for Go source code.

    • iso8583/specs/builder.go
    • Line 86: warning: exported var Builder should have comment or be unexported (golint)
    • Line 88: warning: exported type MessageSpecBuilder should have comment or be unexported (golint)
    • iso8583/network/ascii_4bytes_header.go
    • Line 16: warning: exported function NewASCII4BytesHeader should have comment or be unexported (golint)
    • Line 20: warning: exported method ASCII4BytesHeader.SetLength should have comment or be unexported (golint)
    • Line 24: warning: exported method ASCII4BytesHeader.Length should have comment or be unexported (golint)
    • Line 28: warning: exported method ASCII4BytesHeader.WriteTo should have comment or be unexported (golint)
    • Line 32: warning: exported method ASCII4BytesHeader.ReadFrom should have comment or be unexported (golint)
    • iso8583/network/binary_2bytes.go
    • Line 10: warning: exported type Binary2Bytes should have comment or be unexported (golint)
    • Line 14: warning: exported function NewBinary2BytesHeader should have comment or be unexported (golint)
    • Line 18: warning: exported method Binary2Bytes.SetLength should have comment or be unexported (golint)
    • Line 28: warning: exported method Binary2Bytes.Length should have comment or be unexported (golint)
    • Line 32: warning: exported method Binary2Bytes.WriteTo should have comment or be unexported (golint)
    • Line 41: warning: exported method Binary2Bytes.ReadFrom should have comment or be unexported (golint)
    • iso8583/message.go
    • Line 12: warning: exported type Message should have comment or be unexported (golint)
    • Line 24: warning: exported function NewMessage should have comment or be unexported (golint)
    • Line 34: warning: exported method Message.Data should have comment or be unexported (golint)
    • Line 38: warning: exported method Message.SetData should have comment or be unexported (golint)
    • Line 59: warning: exported method Message.Bitmap should have comment or be unexported (golint)
    • Line 71: warning: exported method Message.MTI should have comment or be unexported (golint)
    • Line 76: warning: exported method Message.GetSpec should have comment or be unexported (golint)
    • Line 80: warning: exported method Message.Field should have comment or be unexported (golint)
    • Line 88: warning: exported method Message.BinaryField should have comment or be unexported (golint)
    • Line 96: warning: exported method Message.GetMTI should have comment or be unexported (golint)
    • Line 101: warning: exported method Message.GetString should have comment or be unexported (golint)
    • Line 109: warning: exported method Message.GetBytes should have comment or be unexported (golint)
    • Line 117: warning: exported method Message.GetField should have comment or be unexported (golint)
    • Line 121: warning: comment on exported method Message.GetFields should be of the form "GetFields ..." (golint)
    • Line 130: warning: exported method Message.Pack should have comment or be unexported (golint)
    • Line 164: warning: exported method Message.Unpack should have comment or be unexported (golint)
    • Line 217: warning: exported method Message.MarshalJSON should have comment or be unexported (golint)
    • iso8583/version.go
    • Line 1: warning: package comment should be of the form "Package iso8583 ..." (golint)
    • Line 4: warning: exported var Version should have comment or be unexported (golint)
    • iso8583/padding/left.go
    • Line 8: warning: exported var Left should have comment or be unexported (golint)
    • Line 14: warning: exported function NewLeftPadder should have comment or be unexported (golint)
    • iso8583/field/numeric.go
    • Line 11: warning: exported type Numeric should have comment or be unexported (golint)
    • Line 17: warning: exported function NewNumeric should have comment or be unexported (golint)
    • Line 23: warning: exported function NewNumericValue should have comment or be unexported (golint)
    • Line 29: warning: exported method Numeric.Spec should have comment or be unexported (golint)
    • Line 33: warning: exported method Numeric.SetSpec should have comment or be unexported (golint)
    • Line 37: warning: exported method Numeric.SetBytes should have comment or be unexported (golint)
    • Line 45: warning: exported method Numeric.Bytes should have comment or be unexported (golint)
    • Line 53: warning: exported method Numeric.Pack should have comment or be unexported (golint)
    • Line 73: warning: comment on exported method Numeric.Unpack should be of the form "Unpack ..." (golint)
    • Line 110: warning: exported method Numeric.SetData should have comment or be unexported (golint)
    • Line 127: warning: exported method Numeric.MarshalJSON should have comment or be unexported (golint)
    • iso8583/constant.go
    • Line 34: warning: comment on exported const IssuerResponseToFinancialAdvice should be of the form "IssuerResponseToFinancialAdvice ..." (golint)
    • Line 40: warning: comment on exported const BatchUploadResponse should be of the form "BatchUploadResponse ..." (golint)
    • Line 46: warning: comment on exported const AcquirerReversalAdvice should be of the form "AcquirerReversalAdvice ..." (golint)
    • Line 49: warning: comment on exported const AcquirerReversalAdviceResponse should be of the form "AcquirerReversalAdviceResponse ..." (golint)
    • iso8583/utils/bitmap.go
    • Line 9: warning: exported type Bitmap should have comment or be unexported (golint)
    • Line 17: warning: exported function NewBitmap should have comment or be unexported (golint)
    • Line 28: warning: exported function NewBitmapFromData should have comment or be unexported (golint)
    • Line 34: warning: exported method Bitmap.IsSet should have comment or be unexported (golint)
    • Line 39: warning: exported method Bitmap.Set should have comment or be unexported (golint)
    • Line 46: warning: exported method Bitmap.Bytes should have comment or be unexported (golint)
    • Line 50: warning: comment on exported method Bitmap.Len should be of the form "Len ..." (golint)
    • Line 58: warning: don't use underscores in Go names; range var byte_ should be byte (golint)
    • iso8583/field/spec.go
    • Line 11: warning: exported type Spec should have comment or be unexported (golint)
    • Line 23: warning: exported function NewSpec should have comment or be unexported (golint)
    • Line 32: warning: comment on exported method Spec.CreateMessageFields should be of the form "CreateMessageFields ..." (golint)
    • iso8583/prefix/prefixer.go
    • Line 3: warning: exported type Prefixer should have comment or be unexported (golint)
    • Line 23: warning: exported type Prefixers should have comment or be unexported (golint)
    • Line 31: warning: exported type PrefixerBuilder should have comment or be unexported (golint)
    • iso8583/field/binary.go
    • Line 10: warning: exported type Binary should have comment or be unexported (golint)
    • Line 16: warning: exported function NewBinary should have comment or be unexported (golint)
    • Line 22: warning: exported function NewBinaryValue should have comment or be unexported (golint)
    • Line 28: warning: exported method Binary.Spec should have comment or be unexported (golint)
    • Line 32: warning: exported method Binary.SetSpec should have comment or be unexported (golint)
    • Line 36: warning: exported method Binary.SetBytes should have comment or be unexported (golint)
    • Line 41: warning: exported method Binary.Bytes should have comment or be unexported (golint)
    • Line 49: warning: exported method Binary.Pack should have comment or be unexported (golint)
    • Line 69: warning: exported method Binary.Unpack should have comment or be unexported (golint)
    • Line 94: warning: exported method Binary.SetData should have comment or be unexported (golint)
    • Line 111: warning: exported method Binary.MarshalJSON should have comment or be unexported (golint)
    • iso8583/network/vml_header.go
    • Line 15: warning: exported const MaxMessageLength should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: exported type VMLH should have comment or be unexported (golint)
    • Line 27: warning: exported function NewVMLHeader should have comment or be unexported (golint)
    • Line 31: warning: exported method VMLH.SetLength should have comment or be unexported (golint)
    • Line 41: warning: exported method VMLH.Length should have comment or be unexported (golint)
    • Line 45: warning: exported method VMLH.WriteTo should have comment or be unexported (golint)
    • Line 70: warning: exported method VMLH.ReadFrom should have comment or be unexported (golint)
    • iso8583/cmd/iso8583/describe.go
    • Line 38: warning: exported function Describe should have comment or be unexported (golint)
    • Line 47: warning: exported function DescribeWithSpecFile should have comment or be unexported (golint)
    • iso8583/field/bitmap.go
    • Line 17: warning: exported type Bitmap should have comment or be unexported (golint)
    • Line 23: warning: exported function NewBitmap should have comment or be unexported (golint)
    • Line 30: warning: exported method Bitmap.Spec should have comment or be unexported (golint)
    • Line 34: warning: exported method Bitmap.SetSpec should have comment or be unexported (golint)
    • Line 38: warning: exported method Bitmap.SetBytes should have comment or be unexported (golint)
    • Line 43: warning: exported method Bitmap.Bytes should have comment or be unexported (golint)
    • Line 51: warning: exported method Bitmap.Pack should have comment or be unexported (golint)
    • Line 111: warning: exported method Bitmap.SetData should have comment or be unexported (golint)
    • Line 128: warning: exported method Bitmap.Reset should have comment or be unexported (golint)
    • Line 132: warning: exported method Bitmap.Set should have comment or be unexported (golint)
    • Line 136: warning: exported method Bitmap.IsSet should have comment or be unexported (golint)
    • Line 140: warning: exported method Bitmap.Len should have comment or be unexported (golint)
    • Line 181: warning: comment on exported method Bitmap.MarshalJSON should be of the form "MarshalJSON ..." (golint)
    • iso8583/field/ordered_map.go
    • Line 10: warning: comment on exported type OrderedMap should be of the form "OrderedMap ..." (with optional leading article) (golint)
    • Line 13: warning: exported method OrderedMap.MarshalJSON should have comment or be unexported (golint)
    • iso8583/message_spec.go
    • Line 9: warning: exported type MessageSpec should have comment or be unexported (golint)
    • Line 14: warning: comment on exported method MessageSpec.CreateMessageFields should be of the form "CreateMessageFields ..." (golint)
    • iso8583/field/string.go
    • Line 10: warning: exported type String should have comment or be unexported (golint)
    • Line 16: warning: exported function NewString should have comment or be unexported (golint)
    • Line 22: warning: exported function NewStringValue should have comment or be unexported (golint)
    • Line 28: warning: exported method String.Spec should have comment or be unexported (golint)
    • Line 32: warning: exported method String.SetSpec should have comment or be unexported (golint)
    • Line 36: warning: exported method String.SetBytes should have comment or be unexported (golint)
    • Line 41: warning: exported method String.Bytes should have comment or be unexported (golint)
    • Line 49: warning: exported method String.Pack should have comment or be unexported (golint)
    • Line 75: warning: exported method String.Unpack should have comment or be unexported (golint)
    • Line 100: warning: exported method String.SetData should have comment or be unexported (golint)
    • Line 117: warning: exported method String.MarshalJSON should have comment or be unexported (golint)
    • iso8583/network/bcd_2bytes.go
    • Line 13: warning: comment on exported type BCD2BytesHeader should be of the form "BCD2BytesHeader ..." (with optional leading article) (golint)
    • Line 18: warning: exported function NewBCD2BytesHeader should have comment or be unexported (golint)
    • Line 22: warning: exported method BCD2BytesHeader.SetLength should have comment or be unexported (golint)
    • Line 26: warning: exported method BCD2BytesHeader.Length should have comment or be unexported (golint)
    • Line 30: warning: exported method BCD2BytesHeader.WriteTo should have comment or be unexported (golint)
    • Line 39: warning: exported method BCD2BytesHeader.ReadFrom should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!