Preparing report...

Report for github.com/fullstorydev/hauser

A+    Excellent!    Found 16 issues across 24 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint33%

Golint is a linter for Go source code.

    • hauser/testing/mockclient.go
    • Line 27: warning: exported type MockDataExportClient should have comment or be unexported (golint)
    • Line 34: warning: exported function NewMockDataExportClient should have comment or be unexported (golint)
    • Line 103: warning: exported method MockDataExportClient.CreateExport should have comment or be unexported (golint)
    • Line 110: warning: exported method MockDataExportClient.GetExportProgress should have comment or be unexported (golint)
    • Line 118: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 138: warning: exported method MockDataExportClient.GetExport should have comment or be unexported (golint)
    • hauser/testing/mockdatabase.go
    • Line 11: warning: exported type MockDatabase should have comment or be unexported (golint)
    • Line 19: warning: exported method MockDatabase.InitExportTable should have comment or be unexported (golint)
    • Line 29: warning: exported method MockDatabase.ApplyExportSchema should have comment or be unexported (golint)
    • Line 40: warning: exported function NewMockDatabase should have comment or be unexported (golint)
    • Line 55: warning: exported method MockDatabase.LastSyncPoint should have comment or be unexported (golint)
    • Line 65: warning: exported method MockDatabase.SaveSyncPoint should have comment or be unexported (golint)
    • Line 70: warning: exported method MockDatabase.LoadToWarehouse should have comment or be unexported (golint)
    • Line 75: warning: exported method MockDatabase.ValueToString should have comment or be unexported (golint)
    • Line 84: warning: exported method MockDatabase.GetExportTableColumns should have comment or be unexported (golint)
    • hauser/warehouse/bigquery.go
    • Line 23: warning: exported type BigQuery should have comment or be unexported (golint)
    • Line 31: warning: exported function NewBigQuery should have comment or be unexported (golint)
    • Line 57: warning: exported method BigQuery.LastSyncPoint should have comment or be unexported (golint)
    • Line 105: warning: exported method BigQuery.SaveSyncPoint should have comment or be unexported (golint)
    • Line 128: warning: exported method BigQuery.LoadToWarehouse should have comment or be unexported (golint)
    • Line 194: warning: exported method BigQuery.InitExportTable should have comment or be unexported (golint)
    • Line 234: warning: exported method BigQuery.ApplyExportSchema should have comment or be unexported (golint)
    • Line 285: warning: exported method BigQuery.ValueToString should have comment or be unexported (golint)
    • hauser/internal/service.go
    • Line 43: warning: exported type HauserService should have comment or be unexported (golint)
    • Line 53: warning: exported function NewHauserService should have comment or be unexported (golint)
    • Line 121: warning: exported method HauserService.LoadBundles should have comment or be unexported (golint)
    • Line 231: warning: exported method HauserService.BackoffOnError should have comment or be unexported (golint)
    • Line 247: warning: exported method HauserService.Init should have comment or be unexported (golint)
    • Line 254: warning: exported method HauserService.InitDatabase should have comment or be unexported (golint)
    • Line 291: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 362: warning: exported method HauserService.Run should have comment or be unexported (golint)
    • hauser/config/config.go
    • Line 16: warning: exported const DefaultExportDelay should have comment (or a comment on this block) or be unexported (golint)
    • Line 22: warning: exported type Provider should have comment or be unexported (golint)
    • Line 25: warning: exported const LocalProvider should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: exported type Config should have comment or be unexported (golint)
    • Line 69: warning: exported type Header should have comment or be unexported (golint)
    • Line 74: warning: exported type StorageConfig should have comment or be unexported (golint)
    • Line 78: warning: exported type S3Config should have comment or be unexported (golint)
    • Line 87: warning: exported type RedshiftConfig should have comment or be unexported (golint)
    • Line 101: warning: exported type GCSConfig should have comment or be unexported (golint)
    • Line 108: warning: exported type BigQueryConfig should have comment or be unexported (golint)
    • Line 116: warning: exported type Duration should have comment or be unexported (golint)
    • Line 120: warning: exported type LocalConfig should have comment or be unexported (golint)
    • Line 130: warning: exported method Duration.UnmarshalText should have comment or be unexported (golint)
    • Line 136: warning: exported function Load should have comment or be unexported (golint)
    • Line 154: warning: exported function Validate should have comment or be unexported (golint)
    • Line 204: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • hauser/client/export.go
    • Line 12: warning: exported type ExportError should have comment or be unexported (golint)
    • Line 22: warning: don't use underscores in Go names; const exportType_Event should be exportTypeEvent (golint)
    • Line 26: warning: don't use underscores in Go names; const exportFormat_Json should be exportFormatJSON (golint)
    • Line 50: warning: exported method Client.CreateExport should have comment or be unexported (golint)
    • Line 86: warning: exported method Client.GetExportProgress should have comment or be unexported (golint)
    • Line 97: warning: exported method Client.GetExport should have comment or be unexported (golint)
    • hauser/warehouse/schema.go
    • Line 9: warning: exported type BaseExportFields should have comment or be unexported (golint)
    • Line 62: warning: comment on exported type MobileFields should be of the form "MobileFields ..." (with optional leading article) (golint)
    • Line 108: warning: exported method WarehouseField.IsTime should have comment or be unexported (golint)
    • Line 112: warning: exported type Schema should have comment or be unexported (golint)
    • Line 114: warning: exported method Schema.Equals should have comment or be unexported (golint)
    • Line 126: warning: exported method Schema.IsCompatibleWith should have comment or be unexported (golint)
    • Line 167: warning: exported method Schema.GetFullStoryFields should have comment or be unexported (golint)
    • Line 183: warning: exported function IndexField should have comment or be unexported (golint)
    • Line 203: warning: exported method Schema.GetMissingFieldsFor should have comment or be unexported (golint)
    • Line 213: warning: exported function MakeSchema should have comment or be unexported (golint)
    • hauser/testing/mockstorage.go
    • Line 14: warning: exported type MockStorage should have comment or be unexported (golint)
    • Line 23: warning: exported function NewMockStorage should have comment or be unexported (golint)
    • Line 32: warning: exported method MockStorage.LastSyncPoint should have comment or be unexported (golint)
    • Line 42: warning: exported method MockStorage.SaveSyncPoint should have comment or be unexported (golint)
    • Line 47: warning: exported method MockStorage.SaveFile should have comment or be unexported (golint)
    • Line 56: warning: exported method MockStorage.ReadFile should have comment or be unexported (golint)
    • Line 59: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 64: warning: exported method MockStorage.DeleteFile should have comment or be unexported (golint)
    • Line 69: warning: exported method MockStorage.GetFileReference should have comment or be unexported (golint)
    • Line 73: warning: exported method MockStorage.GetFilePrefix should have comment or be unexported (golint)
    • hauser/warehouse/s3.go
    • Line 19: warning: exported type S3Storage should have comment or be unexported (golint)
    • Line 25: warning: exported function NewS3Storage should have comment or be unexported (golint)
    • Line 31: warning: exported method S3Storage.LastSyncPoint should have comment or be unexported (golint)
    • Line 35: warning: exported method S3Storage.SaveSyncPoint should have comment or be unexported (golint)
    • Line 39: warning: exported method S3Storage.SaveFile should have comment or be unexported (golint)
    • Line 53: warning: exported method S3Storage.ReadFile should have comment or be unexported (golint)
    • Line 72: warning: exported method S3Storage.DeleteFile should have comment or be unexported (golint)
    • Line 89: warning: exported method S3Storage.GetFileReference should have comment or be unexported (golint)
    • Line 94: warning: exported method S3Storage.GetFilePrefix should have comment or be unexported (golint)
    • hauser/warehouse/warehouse.go
    • Line 20: warning: exported var ErrFileNotFound should have comment or be unexported (golint)
    • Line 23: warning: exported type Syncable should have comment or be unexported (golint)
    • Line 28: warning: exported type Storage should have comment or be unexported (golint)
    • Line 37: warning: exported type Database should have comment or be unexported (golint)
    • Line 54: warning: exported const RFC3339Micro should have comment or be unexported (golint)
    • Line 56: warning: exported type ValueToStringFn should have comment or be unexported (golint)
    • Line 80: warning: exported method SyncViaStorageMixin.LastSyncPoint should have comment or be unexported (golint)
    • Line 93: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 98: warning: exported method SyncViaStorageMixin.SaveSyncPoint should have comment or be unexported (golint)
    • hauser/warehouse/redshift.go
    • Line 17: warning: exported type Redshift should have comment or be unexported (golint)
    • Line 48: warning: exported function NewRedshift should have comment or be unexported (golint)
    • Line 99: warning: exported method Redshift.ValueToString should have comment or be unexported (golint)
    • Line 116: warning: exported method Redshift.MakeRedshiftConnection should have comment or be unexported (golint)
    • Line 148: warning: exported method Redshift.LoadToWarehouse should have comment or be unexported (golint)
    • Line 193: warning: exported method Redshift.InitExportTable should have comment or be unexported (golint)
    • Line 212: warning: exported method Redshift.ApplyExportSchema should have comment or be unexported (golint)
    • Line 264: warning: exported method Redshift.SaveSyncPoint should have comment or be unexported (golint)
    • Line 282: warning: exported method Redshift.DeleteExportRecordsAfter should have comment or be unexported (golint)
    • Line 294: warning: exported method Redshift.LastSyncPoint should have comment or be unexported (golint)
    • Line 328: warning: exported method Redshift.RemoveOrphanedRecords should have comment or be unexported (golint)
    • hauser/core/core.go
    • Line 14: warning: exported function NewHauser should have comment or be unexported (golint)
    • Line 18: warning: exported function MakeStorage should have comment or be unexported (golint)
    • Line 36: warning: exported function MakeDatabase should have comment or be unexported (golint)
    • hauser/testing/testutils/testutils.go
    • Line 8: warning: exported function Assert should have comment or be unexported (golint)
    • Line 15: warning: exported function Equals should have comment or be unexported (golint)
    • Line 24: warning: exported function StrSliceEquals should have comment or be unexported (golint)
    • hauser/warehouse/gcs.go
    • Line 13: warning: exported type GCSStorage should have comment or be unexported (golint)
    • Line 20: warning: exported function NewGCSStorage should have comment or be unexported (golint)
    • Line 27: warning: exported method GCSStorage.LastSyncPoint should have comment or be unexported (golint)
    • Line 31: warning: exported method GCSStorage.SaveSyncPoint should have comment or be unexported (golint)
    • Line 35: warning: exported method GCSStorage.SaveFile should have comment or be unexported (golint)
    • Line 43: warning: exported method GCSStorage.ReadFile should have comment or be unexported (golint)
    • Line 51: warning: exported method GCSStorage.DeleteFile should have comment or be unexported (golint)
    • Line 58: warning: exported method GCSStorage.GetFileReference should have comment or be unexported (golint)
    • Line 62: warning: exported method GCSStorage.GetFilePrefix should have comment or be unexported (golint)
    • hauser/warehouse/localdisk.go
    • Line 15: warning: exported type LocalDisk should have comment or be unexported (golint)
    • Line 21: warning: exported function NewLocalDisk should have comment or be unexported (golint)
    • Line 39: warning: exported method LocalDisk.LastSyncPoint should have comment or be unexported (golint)
    • Line 43: warning: exported method LocalDisk.SaveSyncPoint should have comment or be unexported (golint)
    • Line 47: warning: exported method LocalDisk.SaveFile should have comment or be unexported (golint)
    • Line 68: warning: exported method LocalDisk.ReadFile should have comment or be unexported (golint)
    • Line 76: warning: exported method LocalDisk.GetFileReference should have comment or be unexported (golint)
    • Line 80: warning: exported method LocalDisk.GetFilePrefix should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!