gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• fybrik/pkg/taxonomy/model/base/model_policy_manager_request_action.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_policy_manager_response.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_resource.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_resource_columns.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_result_item.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_action.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_action_type.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• fybrik/pkg/taxonomy/model/base/model_policy_manager_request.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• fybrik/manager/main.go
  • Line 52: warning: cyclomatic complexity 20 of function run() is high (> 15) (gocyclo)

• fybrik/manager/controllers/app/plotter_controller.go
  • Line 120: warning: cyclomatic complexity 23 of function (*PlotterReconciler).reconcile() is high (> 15) (gocyclo)

• fybrik/manager/controllers/motion/streamtransfer_controller.go
  • Line 32: warning: cyclomatic complexity 23 of function (*StreamTransferReconciler).Reconcile() is high (> 15) (gocyclo)

• fybrik/manager/controllers/app/m4dapplication_controller.go
  • Line 264: warning: cyclomatic complexity 22 of function (*M4DApplicationReconciler).reconcile() is high (> 15) (gocyclo)
  • Line 52: warning: cyclomatic complexity 16 of function (*M4DApplicationReconciler).Reconcile() is high (> 15) (gocyclo)

• fybrik/manager/controllers/app/blueprint_controller.go
  • Line 225: warning: cyclomatic complexity 20 of function (*BlueprintReconciler).reconcile() is high (> 15) (gocyclo)

• fybrik/manager/apis/motion/v1alpha1/batchtransfer_webhook.go
  • Line 183: warning: cyclomatic complexity 28 of function validateDataStore() is high (> 15) (gocyclo)
  • Line 42: warning: cyclomatic complexity 18 of function (*BatchTransfer).Default() is high (> 15) (gocyclo)

• fybrik/pkg/multicluster/razee/razee_cluster_manager.go
  • Line 144: warning: cyclomatic complexity 21 of function (*ClusterManager).CreateBlueprint() is high (> 15) (gocyclo)

• fybrik/pkg/taxonomy/compile/merge.go
  • Line 39: warning: cyclomatic complexity 25 of function mergeSchemaRef() is high (> 15) (gocyclo)

• fybrik/manager/controllers/motion/batchtransfer_controller.go
  • Line 45: warning: cyclomatic complexity 27 of function (*BatchTransferReconciler).Reconcile() is high (> 15) (gocyclo)

golint70%

Golint is a linter for Go source code.

• fybrik/manager/controllers/app/modules/moduleinterface.go
  • Line 239: warning: comment on exported function CatalogDatasetToDataDetails should be of the form "CatalogDatasetToDataDetails ..." (golint)

• fybrik/connectors/katalog/pkg/connector/connector.go
  • Line 1: warning: package comment should be of the form "Package connector ..." (golint)
  • Line 16: warning: exported function Start should have comment or be unexported (golint)

• fybrik/manager/apis/app/v1alpha1/blueprint_types.go
  • Line 220: warning: exported const BlueprintNamespaceLabel should have comment (or a comment on this block) or be unexported (golint)

• fybrik/manager/apis/app/v1alpha1/m4dapplication_types.go
  • Line 229: warning: exported const ApplicationClusterLabel should have comment (or a comment on this block) or be unexported (golint)

• fybrik/manager/apis/app/v1alpha1/m4dapplication_webhook.go
  • Line 18: warning: exported method M4DApplication.SetupWebhookWithManager should have comment or be unexported (golint)

• fybrik/pkg/vault/vault_dummy.go
  • Line 21: warning: exported method Dummy.LinkPolicyToIdentity should have comment or be unexported (golint)
  • Line 25: warning: exported method Dummy.RemovePolicyFromIdentity should have comment or be unexported (golint)
  • Line 29: warning: exported method Dummy.WritePolicy should have comment or be unexported (golint)
  • Line 33: warning: exported method Dummy.DeletePolicy should have comment or be unexported (golint)
  • Line 37: warning: exported method Dummy.Mount should have comment or be unexported (golint)
  • Line 41: warning: exported method Dummy.DeleteSecret should have comment or be unexported (golint)
  • Line 46: warning: exported method Dummy.GetSecret should have comment or be unexported (golint)
  • Line 53: warning: exported method Dummy.AddSecret should have comment or be unexported (golint)
  • Line 62: warning: exported method Dummy.AddSecretFromStruct should have comment or be unexported (golint)

• fybrik/manager/apis/motion/v1alpha1/batchtransfer_webhook.go
  • Line 27: warning: exported method BatchTransfer.SetupWebhookWithManager should have comment or be unexported (golint)
  • Line 38: warning: exported const DefaultFailedJobHistoryLimit should have comment or be unexported (golint)
  • Line 39: warning: exported const DefaultSuccessfulJobHistoryLimit should have comment or be unexported (golint)

• fybrik/test/services/datacatalog/datacatalogstub.go
  • Line 17: warning: exported const PORT should have comment (or a comment on this block) or be unexported (golint)

• fybrik/manager/controllers/motion/batchtransfer_controller.go
  • Line 21: warning: comment on exported type Reconciler should be of the form "Reconciler ..." (with optional leading article) (golint)
  • Line 38: warning: comment on exported method BatchTransferReconciler.Reconcile should be of the form "Reconcile ..." (golint)
  • Line 165: warning: comment on exported method BatchTransferReconciler.SetupWithManager should be of the form "SetupWithManager ..." (golint)

• fybrik/connectors/opa/lib/catalog_reader.go
  • Line 23: warning: exported function NewCatalogReader should have comment or be unexported (golint)
  • Line 27: warning: comment on exported method CatalogReader.GetDatasetsMetadataFromCatalog should be of the form "GetDatasetsMetadataFromCatalog ..." (golint)
  • Line 60: warning: exported method CatalogReader.GetDatasetMetadata should have comment or be unexported (golint)

• fybrik/pkg/serde/arbitrary.go
  • Line 12: warning: comment on exported type Arbitrary should be of the form "Arbitrary ..." (with optional leading article) (golint)
  • Line 18: warning: exported function NewArbitrary should have comment or be unexported (golint)
  • Line 24: warning: exported method Arbitrary.DeepCopyInto should have comment or be unexported (golint)
  • Line 30: warning: exported method Arbitrary.UnmarshalJSON should have comment or be unexported (golint)
  • Line 37: warning: exported method Arbitrary.MarshalJSON should have comment or be unexported (golint)
  • Line 41: warning: exported method Arbitrary.Into should have comment or be unexported (golint)

• fybrik/connectors/katalog/pkg/connector/catalog.go
  • Line 1: warning: package comment should be of the form "Package connector ..." (golint)
  • Line 25: warning: exported type DataCatalogService should have comment or be unexported (golint)
  • Line 31: warning: exported method DataCatalogService.GetDatasetInfo should have comment or be unexported (golint)

• fybrik/manager/controllers/motion/motion_controllers.go
  • Line 14: warning: comment on exported function SetupMotionControllers should be of the form "SetupMotionControllers ..." (golint)

• fybrik/cmd/taxonomy_compile.go
  • Line 1: warning: package comment should be of the form "Package cmd ..." (golint)

• fybrik/pkg/multicluster/razee/razee_cluster_manager.go
  • Line 41: warning: exported type ClusterManager should have comment or be unexported (golint)
  • Line 48: warning: exported method ClusterManager.GetClusters should have comment or be unexported (golint)
  • Line 102: warning: exported method ClusterManager.GetBlueprint should have comment or be unexported (golint)
  • Line 138: warning: exported type Collection should have comment or be unexported (golint)
  • Line 144: warning: exported method ClusterManager.CreateBlueprint should have comment or be unexported (golint)
  • Line 246: warning: exported method ClusterManager.UpdateBlueprint should have comment or be unexported (golint)
  • Line 299: warning: exported method ClusterManager.DeleteBlueprint should have comment or be unexported (golint)
  • Line 340: warning: exported function NewRazeeLocalManager should have comment or be unexported (golint)
  • Line 366: warning: exported function NewRazeeOAuthManager should have comment or be unexported (golint)
  • Line 392: warning: exported function NewSatConfManager should have comment or be unexported (golint)

• fybrik/manager/apis/motion/v1alpha1/doc.go
  • Line 4: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• fybrik/manager/controllers/utils/configuration.go
  • Line 47: warning: exported function SetIfNotSet should have comment or be unexported (golint)
  • Line 55: warning: exported function DefaultTestConfiguration should have comment or be unexported (golint)

• fybrik/pkg/multicluster/dummy/dummy_manager.go
  • Line 13: warning: comment on exported type ClusterManager should be of the form "ClusterManager ..." (with optional leading article) (golint)
  • Line 18: warning: exported method ClusterManager.GetClusters should have comment or be unexported (golint)
  • Line 27: warning: exported method ClusterManager.GetBlueprint should have comment or be unexported (golint)
  • Line 35: warning: exported method ClusterManager.CreateBlueprint should have comment or be unexported (golint)
  • Line 40: warning: exported method ClusterManager.UpdateBlueprint should have comment or be unexported (golint)
  • Line 45: warning: exported method ClusterManager.DeleteBlueprint should have comment or be unexported (golint)

• fybrik/manager/controllers/mockup/datacatalog.go
  • Line 16: warning: comment on exported type DataCatalogDummy should be of the form "DataCatalogDummy ..." (with optional leading article) (golint)
  • Line 24: warning: exported method DataCatalogDummy.GetDatasetInfo should have comment or be unexported (golint)
  • Line 43: warning: exported method DataCatalogDummy.Close should have comment or be unexported (golint)
  • Line 47: warning: exported function NewTestCatalog should have comment or be unexported (golint)

• fybrik/pkg/connectors/clients/policymanager.go
  • Line 18: warning: exported function MergePoliciesDecisions should have comment or be unexported (golint)

• fybrik/connectors/opa/lib/opa_reader.go
  • Line 15: warning: exported type OpaReader should have comment or be unexported (golint)
  • Line 19: warning: exported function NewOpaReader should have comment or be unexported (golint)
  • Line 23: warning: exported method OpaReader.GetOPADecisions should have comment or be unexported (golint)
  • Line 100: warning: comment on exported function GetOPAOperationDecision should be of the form "GetOPAOperationDecision ..." (golint)

• fybrik/manager/controllers/motion/batchtransfer_controller_jobs.go
  • Line 20: warning: comment on exported function VolumeConfiguration should be of the form "VolumeConfiguration ..." (golint)
  • Line 230: warning: comment on exported method BatchTransferReconciler.CreateBatchJob should be of the form "CreateBatchJob ..." (golint)
  • Line 248: warning: comment on exported method BatchTransferReconciler.CreateSecret should be of the form "CreateSecret ..." (golint)

• fybrik/test/services/pilot/catalog-credential-mock/mockup_pilot_catalog_con.go
  • Line 30: warning: exported function GetMetadata should have comment or be unexported (golint)

• fybrik/pkg/taxonomy/schema.go
  • Line 41: warning: exported function ValidateDraft4 should have comment or be unexported (golint)
  • Line 48: warning: exported function ValidateStructural should have comment or be unexported (golint)

• fybrik/manager/apis/motion/v1alpha1/streamtransfer_types.go
  • Line 93: warning: comment on exported type StreamStatus should be of the form "StreamStatus ..." (with optional leading article) (golint)
  • Line 129: warning: exported const StreamtransferFinalizer should have comment or be unexported (golint)
  • Line 130: warning: exported const StreamtransferBinary should have comment or be unexported (golint)
  • Line 141: warning: exported method StreamTransfer.HasStarted should have comment or be unexported (golint)
  • Line 145: warning: exported method StreamTransfer.HasFinalizer should have comment or be unexported (golint)
  • Line 149: warning: exported method StreamTransfer.AddFinalizer should have comment or be unexported (golint)
  • Line 153: warning: exported method StreamTransfer.RemoveFinalizer should have comment or be unexported (golint)
  • Line 157: warning: exported method StreamTransfer.FinalizerPodName should have comment or be unexported (golint)
  • Line 161: warning: exported method StreamTransfer.FinalizerPodKey should have comment or be unexported (golint)
  • Line 168: warning: exported method StreamTransfer.ObjectKey should have comment or be unexported (golint)
  • Line 175: warning: exported method StreamTransfer.GetImage should have comment or be unexported (golint)
  • Line 179: warning: exported method StreamTransfer.GetImagePullPolicy should have comment or be unexported (golint)

• fybrik/manager/apis/motion/v1alpha1/streamtransfer_webhook.go
  • Line 19: warning: exported method StreamTransfer.SetupWebhookWithManager should have comment or be unexported (golint)

• fybrik/connectors/opa/lib/evaluate_opa.go
  • Line 60: warning: exported function EvaluatePoliciesOnInput should have comment or be unexported (golint)

• fybrik/manager/controllers/utils/test_utils.go
  • Line 15: warning: comment on exported function NewScheme should be of the form "NewScheme ..." (golint)

• fybrik/pkg/multicluster/multi_cluster_manager.go
  • Line 12: warning: exported type ClusterLister should have comment or be unexported (golint)
  • Line 16: warning: exported type ClusterManager should have comment or be unexported (golint)
  • Line 24: warning: exported type ClusterMetadata should have comment or be unexported (golint)
  • Line 30: warning: exported type Cluster should have comment or be unexported (golint)

• fybrik/connectors/katalog/pkg/connector/types.go
  • Line 1: warning: package comment should be of the form "Package connector ..." (golint)
  • Line 12: warning: exported type Asset should have comment or be unexported (golint)

• fybrik/connectors/katalog/pkg/connector/utils.go
  • Line 1: warning: package comment should be of the form "Package connector ..." (golint)

• fybrik/manager/apis/motion/v1alpha1/groupversion_info.go
  • Line 4: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• fybrik/pkg/taxonomy/model/additionalprops.go
  • Line 20: warning: exported method AdditionalPropertiesType.UnmarshalJSON should have comment or be unexported (golint)
  • Line 37: warning: exported method AdditionalPropertiesType.MarshalJSON should have comment or be unexported (golint)

• fybrik/manager/apis/app/v1alpha1/vault_types.go
  • Line 6: warning: comment on exported type Vault should be of the form "Vault ..." (with optional leading article) (golint)

• fybrik/connectors/opa/testutil/helper.go
  • Line 24: warning: exported var EnvValues should have comment or be unexported (golint)
  • Line 30: warning: exported function GetEnvironment should have comment or be unexported (golint)
  • Line 41: warning: exported function GetApplicationContext should have comment or be unexported (golint)
  • Line 58: warning: exported function ConstructRemoveColumn should have comment or be unexported (golint)
  • Line 63: warning: exported function ConstructEncryptColumn should have comment or be unexported (golint)
  • Line 68: warning: exported function ConstructRedactColumn should have comment or be unexported (golint)
  • Line 73: warning: exported function EnsureDeepEqualDecisions should have comment or be unexported (golint)
  • Line 77: warning: exported function GetExpectedOpaDecisions should have comment or be unexported (golint)
  • Line 126: warning: exported function GetCatalogInfo should have comment or be unexported (golint)
  • Line 155: warning: exported function MockCatalogConnector should have comment or be unexported (golint)
  • Line 178: warning: exported function MockOpaServer should have comment or be unexported (golint)

• fybrik/manager/controllers/utils/utils.go
  • Line 91: warning: comment on exported function GetReleaseName should be of the form "GetReleaseName ..." (golint)
  • Line 96: warning: comment on exported function GetReleaseNameByStepName should be of the form "GetReleaseNameByStepName ..." (golint)
  • Line 102: warning: comment on exported function GenerateModuleEndpointFQDN should be of the form "GenerateModuleEndpointFQDN ..." (golint)
  • Line 107: warning: comment on exported function K8sConformName should be of the form "K8sConformName ..." (golint)
  • Line 114: warning: comment on exported function HelmConformName should be of the form "HelmConformName ..." (golint)
  • Line 119: warning: comment on exported function CreateStepName should be of the form "CreateStepName ..." (golint)
  • Line 125: warning: comment on exported function ShortenedName should be of the form "ShortenedName ..." (golint)
  • Line 141: warning: exported function ListeningAddress should have comment or be unexported (golint)

• fybrik/manager/controllers/motion/streamtransfer_controller.go
  • Line 132: warning: exported method StreamTransferReconciler.SetupWithManager should have comment or be unexported (golint)

• fybrik/manager/controllers/motion/streamtransfer_deployment.go
  • Line 21: warning: comment on exported method StreamTransferReconciler.CreateDeployment should be of the form "CreateDeployment ..." (golint)
  • Line 164: warning: comment on exported method StreamTransferReconciler.CreatePVC should be of the form "CreatePVC ..." (golint)
  • Line 199: warning: comment on exported method StreamTransferReconciler.CreateSecret should be of the form "CreateSecret ..." (golint)

• fybrik/pkg/helm/helm.go
  • Line 50: warning: exported function ChartRef should have comment or be unexported (golint)
  • Line 146: warning: exported function NewEmptyFake should have comment or be unexported (golint)
  • Line 153: warning: exported function NewFake should have comment or be unexported (golint)

• fybrik/manager/apis/app/v1alpha1/m4dmodule_types.go
  • Line 90: warning: exported type ModuleAPI should have comment or be unexported (golint)

• fybrik/manager/apis/motion/v1alpha1/batchtransfer_types.go
  • Line 109: warning: comment on exported type DataStore should be of the form "DataStore ..." (with optional leading article) (golint)
  • Line 140: warning: comment on exported type Database should be of the form "Database ..." (with optional leading article) (golint)
  • Line 168: warning: comment on exported type Cloudant should be of the form "Cloudant ..." (with optional leading article) (golint)
  • Line 194: warning: comment on exported type S3 should be of the form "S3 ..." (with optional leading article) (golint)
  • Line 240: warning: comment on exported type Kafka should be of the form "Kafka ..." (with optional leading article) (golint)
  • Line 325: warning: comment on exported type Transformation should be of the form "Transformation ..." (with optional leading article) (golint)
  • Line 344: warning: comment on exported type Action should be of the form "Action ..." (with optional leading article) (golint)
  • Line 357: warning: comment on exported type DataFlowType should be of the form "DataFlowType ..." (with optional leading article) (golint)
  • Line 366: warning: comment on exported type DataType should be of the form "DataType ..." (with optional leading article) (golint)
  • Line 375: warning: comment on exported type WriteOperation should be of the form "WriteOperation ..." (with optional leading article) (golint)
  • Line 385: warning: exported type Spark should have comment or be unexported (golint)
  • Line 466: warning: comment on exported type BatchStatus should be of the form "BatchStatus ..." (with optional leading article) (golint)
  • Line 507: warning: exported const BatchtransferFinalizer should have comment (or a comment on this block) or be unexported (golint)
  • Line 519: warning: comment on exported type Transfer should be of the form "Transfer ..." (with optional leading article) (golint)
  • Line 541: warning: exported method BatchTransfer.IsCronJob should have comment or be unexported (golint)
  • Line 545: warning: exported method BatchTransfer.HasStarted should have comment or be unexported (golint)
  • Line 551: warning: exported method BatchTransfer.HasFinalizer should have comment or be unexported (golint)
  • Line 555: warning: exported method BatchTransfer.AddFinalizer should have comment or be unexported (golint)
  • Line 559: warning: exported method BatchTransfer.RemoveFinalizer should have comment or be unexported (golint)
  • Line 563: warning: exported method BatchTransfer.FinalizerPodName should have comment or be unexported (golint)
  • Line 567: warning: exported method BatchTransfer.FinalizerPodKey should have comment or be unexported (golint)
  • Line 574: warning: exported method BatchTransfer.ObjectKey should have comment or be unexported (golint)
  • Line 581: warning: exported method BatchTransfer.GetImage should have comment or be unexported (golint)
  • Line 585: warning: exported method BatchTransfer.GetImagePullPolicy should have comment or be unexported (golint)

• fybrik/test/services/policymanager/serverpolicymanager.go
  • Line 17: warning: exported const PORT should have comment (or a comment on this block) or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!