gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• gardener-extension-provider-vsphere/charts/imagevector.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gardener-extension-provider-vsphere/pkg/controller/controlplane/valuesprovider_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• gardener-extension-provider-vsphere/pkg/controller/controlplane/valuesprovider.go
  • Line 422: warning: cyclomatic complexity 22 of function (*valuesProvider).getConfigChartValues() is high (> 15) (gocyclo)

• gardener-extension-provider-vsphere/pkg/controller/worker/machines.go
  • Line 99: warning: cyclomatic complexity 19 of function (*workerDelegate).generateMachineConfig() is high (> 15) (gocyclo)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/task/tasks_advanced_dhcp.go
  • Line 206: warning: cyclomatic complexity 20 of function (*advancedDHCPServerTask).Ensure() is high (> 15) (gocyclo)
  • Line 406: warning: cyclomatic complexity 19 of function (*advancedDHCPIPPoolTask).Ensure() is high (> 15) (gocyclo)
  • Line 308: warning: cyclomatic complexity 16 of function (*advancedDHCPPortTask).Ensure() is high (> 15) (gocyclo)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/validation/cloudprofile.go
  • Line 34: warning: cyclomatic complexity 50 of function ValidateCloudProfileConfig() is high (> 15) (gocyclo)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/validation/controlplane.go
  • Line 112: warning: cyclomatic complexity 22 of function OverwriteLoadBalancerClasses() is high (> 15) (gocyclo)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/v1alpha1/zz_generated.conversion.go
  • Line 37: warning: cyclomatic complexity 51 of function RegisterConversions() is high (> 15) (gocyclo)

golint80%

Golint is a linter for Go source code.

• gardener-extension-provider-vsphere/pkg/cmd/infra-cli/create.go
  • Line 18: warning: don't use an underscore in package name (golint)
  • Line 29: warning: exported function CreateInfrastructure should have comment or be unexported (golint)
  • Line 52: warning: exported function GetNSXTVersion should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/ensurer/ensurer.go
  • Line 47: warning: exported type ShootContext should have comment or be unexported (golint)
  • Line 82: warning: exported function NewNSXTInfrastructureEnsurer should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/task/taskhelper.go
  • Line 204: warning: exported function TryRecover should have comment or be unexported (golint)
  • Line 301: warning: exported function LookupIPPoolIDByName should have comment or be unexported (golint)
  • Line 328: warning: exported function CheckShootAuthorizationByTags should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/task/tasks.go
  • Line 42: warning: exported function NewLookupTier0GatewayTask should have comment or be unexported (golint)
  • Line 87: warning: exported function NewLookupEdgeClusterTask should have comment or be unexported (golint)
  • Line 119: warning: exported function NewLookupTransportZoneTask should have comment or be unexported (golint)
  • Line 151: warning: exported function NewLookupSNATIPPoolTask should have comment or be unexported (golint)
  • Line 178: warning: exported function NewTier1GatewayTask should have comment or be unexported (golint)
  • Line 295: warning: exported function NewTier1GatewayLocaleServiceTask should have comment or be unexported (golint)
  • Line 391: warning: exported function NewSegmentTask should have comment or be unexported (golint)
  • Line 584: warning: exported function NewSNATIPAddressAllocationTask should have comment or be unexported (golint)
  • Line 651: warning: exported function NewSNATIPAddressRealizationTask should have comment or be unexported (golint)
  • Line 677: warning: exported function NewSNATRuleTask should have comment or be unexported (golint)
  • Line 769: warning: exported function NewDHCPServerConfigTask should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/types_cloudprofile.go
  • Line 185: warning: exported const LoadBalancerDefaultClassName should have comment (or a comment on this block) or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/types_infrastructure.go
  • Line 22: warning: don't use underscores in Go names; const Ensurer_Version1_NSXT25 should be EnsurerVersion1NSXT25 (golint)
  • Line 22: warning: exported const Ensurer_Version1_NSXT25 should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: don't use underscores in Go names; const Ensurer_Version2_NSXT30 should be EnsurerVersion2NSXT30 (golint)
  • Line 26: warning: exported var SupportedEnsurerVersions should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/cmd/infra-cli/config_file.go
  • Line 18: warning: don't use an underscore in package name (golint)
  • Line 49: warning: exported function BuildConfigFile should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/task/interface.go
  • Line 30: warning: exported type EnsurerContext should have comment or be unexported (golint)
  • Line 46: warning: exported type Task should have comment or be unexported (golint)
  • Line 54: warning: exported type RecoverableTask should have comment or be unexported (golint)
  • Line 60: warning: exported type RecoverableAdvancedTask should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/infraspec.go
  • Line 28: warning: exported const ScopeGarden should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: exported method NSXTInfraSpec.FullClusterName should have comment or be unexported (golint)
  • Line 38: warning: exported method NSXTInfraSpec.CreateCommonTags should have comment or be unexported (golint)
  • Line 45: warning: exported method NSXTInfraSpec.CreateTags should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/credentials.go
  • Line 29: warning: exported type UserPass should have comment or be unexported (golint)
  • Line 46: warning: exported method Credentials.VsphereMCM should have comment or be unexported (golint)
  • Line 53: warning: exported method Credentials.VsphereCCM should have comment or be unexported (golint)
  • Line 60: warning: exported method Credentials.VsphereCSI should have comment or be unexported (golint)
  • Line 67: warning: exported method Credentials.NSXT_LBAdmin should have comment or be unexported (golint)
  • Line 67: warning: don't use underscores in Go names; method NSXT_LBAdmin should be NSXTLBAdmin (golint)
  • Line 74: warning: exported method Credentials.NSXT_NetworkEngineer should have comment or be unexported (golint)
  • Line 74: warning: don't use underscores in Go names; method NSXT_NetworkEngineer should be NSXTNetworkEngineer (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/task/helpers.go
  • Line 37: warning: exported function RandomStringWithCharset should have comment or be unexported (golint)
  • Line 45: warning: exported function RandomString should have comment or be unexported (golint)
  • Line 172: warning: exported function IdFromPath should have comment or be unexported (golint)
  • Line 178: warning: exported function TagsToMap should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/interface.go
  • Line 22: warning: exported type NSXTInfraSpec should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/validation/controlplane.go
  • Line 97: warning: exported function HasRelevantControlPlaneConfigUpdates should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/utils/utils.go
  • Line 20: warning: exported function IsEmptyString should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/helpers/helpers.go
  • Line 26: warning: exported function NewNSXTConfig should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/types.go
  • Line 59: warning: comment on exported const UsernameMCM should be of the form "UsernameMCM ..." (golint)
  • Line 61: warning: comment on exported const PasswordMCM should be of the form "PasswordMCM ..." (golint)
  • Line 63: warning: comment on exported const UsernameCCM should be of the form "UsernameCCM ..." (golint)
  • Line 65: warning: comment on exported const PasswordCCM should be of the form "PasswordCCM ..." (golint)
  • Line 67: warning: comment on exported const UsernameCSI should be of the form "UsernameCSI ..." (golint)
  • Line 69: warning: comment on exported const PasswordCSI should be of the form "PasswordCSI ..." (golint)
  • Line 76: warning: comment on exported const NSXTPassword should be of the form "NSXTPassword ..." (golint)

• gardener-extension-provider-vsphere/pkg/cmd/infra-cli/destroy.go
  • Line 18: warning: don't use an underscore in package name (golint)
  • Line 33: warning: exported function DestroyInfrastructure should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/cmd/infra-cli/ippools.go
  • Line 18: warning: don't use an underscore in package name (golint)
  • Line 44: warning: exported function CreateIPPool should have comment or be unexported (golint)
  • Line 181: warning: exported function DeleteIPPool should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/validator/secret_handler.go
  • Line 36: warning: comment on exported type Secret should be of the form "Secret ..." (with optional leading article) (golint)

• gardener-extension-provider-vsphere/charts/imagevector.go
  • Line 22: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)

• gardener-extension-provider-vsphere/pkg/apis/vsphere/helper/scheme.go
  • Line 52: warning: exported function GetCloudProfileConfigFromProfile should have comment or be unexported (golint)
  • Line 67: warning: exported function GetCloudProfileConfig should have comment or be unexported (golint)
  • Line 81: warning: exported function GetControlPlaneConfig should have comment or be unexported (golint)
  • Line 91: warning: exported function GetInfrastructureStatus should have comment or be unexported (golint)
  • Line 102: warning: comment on exported function GetInfrastructureConfig should be of the form "GetInfrastructureConfig ..." (golint)
  • Line 115: warning: exported function DecodeControlPlaneConfig should have comment or be unexported (golint)
  • Line 124: warning: exported function DecodeInfrastructureConfig should have comment or be unexported (golint)
  • Line 133: warning: exported function DecodeCloudProfileConfig should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/ensurer/vapilogger.go
  • Line 31: warning: exported function NewLogrBridge should have comment or be unexported (golint)

• gardener-extension-provider-vsphere/pkg/vsphere/infrastructure/task/tasks_advanced_dhcp.go
  • Line 35: warning: exported function NewAdvancedLookupLogicalSwitchTask should have comment or be unexported (golint)
  • Line 66: warning: exported function NewAdvancedDHCPProfileTask should have comment or be unexported (golint)
  • Line 152: warning: exported function NewAdvancedDHCPServerTask should have comment or be unexported (golint)
  • Line 300: warning: exported function NewAdvancedDHCPPortTask should have comment or be unexported (golint)
  • Line 398: warning: exported function NewAdvancedDHCPIPPoolTask should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!