Go Report Card

Preparing report...

Report for github.com/gardener/test-infra

A+    Excellent!    Found 197 issues across 420 files

Tweet
Last refresh:

Refresh now

gofmt99%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint56%

Golint is a linter for Go source code.

    • test-infra/pkg/util/cmdutil/viper/viper.go
    • Line 27: warning: exported const KeyAnnotation should have comment (or a comment on this block) or be unexported (golint)
    • Line 119: warning: exported var ViperHelper should have comment or be unexported (golint)
    • Line 121: warning: exported function SetViper should have comment or be unexported (golint)
    • Line 125: warning: exported function InitFlags should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/ui/auth/auth.go
    • Line 39: warning: exported type Provider should have comment or be unexported (golint)
    • Line 59: warning: exported type AuthContext should have comment or be unexported (golint)
    • Line 72: warning: exported function NewGitHubOAuth should have comment or be unexported (golint)
    • test-infra/pkg/testrun_renderer/templates/shoots.go
    • Line 26: warning: exported const ConfigSeedName should have comment (or a comment on this block) or be unexported (golint)
    • Line 46: warning: exported var ConfigControlplaneProviderPath should have comment or be unexported (golint)
    • Line 66: warning: exported function GetStepDeleteShoot should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/ui/pages/command_help.go
    • Line 28: warning: exported var AuthorizationTooltip should have comment or be unexported (golint)
    • Line 35: warning: exported type CommandHelpItem should have comment or be unexported (golint)
    • Line 42: warning: exported type CommandHelpDetailedItem should have comment or be unexported (golint)
    • Line 49: warning: exported function NewCommandHelpPage should have comment or be unexported (golint)
    • Line 69: warning: exported function NewCommandDetailedHelpPage should have comment or be unexported (golint)
    • test-infra/cmd/elasticsearch/cmd/precompute/query.go
    • Line 26: warning: exported type BulkResponse should have comment or be unexported (golint)
    • Line 31: warning: exported type BulkItem should have comment or be unexported (golint)
    • Line 35: warning: exported type BulkItemIndex should have comment or be unexported (golint)
    • Line 43: warning: exported type BulkItemIndexError should have comment or be unexported (golint)
    • Line 48: warning: exported type QueryResponse should have comment or be unexported (golint)
    • Line 53: warning: exported type Hits should have comment or be unexported (golint)
    • Line 58: warning: exported type Total should have comment or be unexported (golint)
    • Line 62: warning: exported type Result should have comment or be unexported (golint)
    • Line 68: warning: exported function BuildBulkUpdateQuery should have comment or be unexported (golint)
    • Line 85: warning: exported function BuildScrollQueryInitial should have comment or be unexported (golint)
    • Line 128: warning: exported function BuildScrollQueryNextPage should have comment or be unexported (golint)
    • test-infra/pkg/testmachinery/prepare/types.go
    • Line 6: warning: exported const PrepareConfigPath should have comment (or a comment on this block) or be unexported (golint)
    • Line 9: warning: comment on exported type Definition should be of the form "Definition ..." (with optional leading article) (golint)
    • Line 23: warning: comment on exported type Repository should be of the form "Repository ..." (with optional leading article) (golint)
    • test-infra/pkg/testrunner/telemetry/telemetry.go
    • Line 34: warning: exported type Telemetry should have comment or be unexported (golint)
    • Line 46: warning: exported function New should have comment or be unexported (golint)
    • Line 152: warning: exported method Telemetry.StartWithConfig should have comment or be unexported (golint)
    • Line 196: warning: comment on exported method Telemetry.ShootsLen should be of the form "ShootsLen ..." (golint)
    • test-infra/pkg/apis/testmachinery/v1beta1/constants.go
    • Line 18: warning: comment on exported const TestMachineryKubeconfigName should be of the form "TestMachineryKubeconfigName ..." (golint)
    • Line 21: warning: comment on exported const HostKubeconfigName should be of the form "HostKubeconfigName ..." (golint)
    • Line 24: warning: comment on exported const GardenerKubeconfigName should be of the form "GardenerKubeconfigName ..." (golint)
    • test-infra/pkg/shoot-telemetry/analyse/figures.go
    • Line 24: warning: exported type Figures should have comment or be unexported (golint)
    • Line 38: warning: exported type FiguresResponseTimeDuration should have comment or be unexported (golint)
    • Line 46: warning: exported type FiguresDowntimePeriods should have comment or be unexported (golint)
    • Line 54: warning: exported method Figures.CalculateDownPeriodStatistics should have comment or be unexported (golint)
    • Line 87: warning: exported method Figures.CalculateResponseTimeStatistics should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/github/request.go
    • Line 17: warning: exported method GenericRequestEvent.GetRepositoryKey should have comment or be unexported (golint)
    • Line 21: warning: exported method GenericRequestEvent.GetRepositoryName should have comment or be unexported (golint)
    • Line 25: warning: exported method GenericRequestEvent.GetOwnerName should have comment or be unexported (golint)
    • Line 29: warning: exported method GenericRequestEvent.GetMessage should have comment or be unexported (golint)
    • Line 33: warning: exported method GenericRequestEvent.GetAuthorName should have comment or be unexported (golint)
    • test-infra/integration-tests/e2e/util/util.go
    • Line 32: warning: exported function DownloadFile should have comment or be unexported (golint)
    • Line 49: warning: exported function RunCmd should have comment or be unexported (golint)
    • Line 99: warning: exported function GetGroupMapOfRegexMatches should have comment or be unexported (golint)
    • Line 110: warning: exported function GetFilesByPattern should have comment or be unexported (golint)
    • Line 126: warning: exported type CmdOutput should have comment or be unexported (golint)
    • Line 131: warning: comment on exported function CommandExists should be of the form "CommandExists ..." (golint)
    • Line 139: warning: exported function ReadLinesFromFile should have comment or be unexported (golint)
    • Line 165: warning: exported function Copy should have comment or be unexported (golint)
    • Line 190: warning: exported function DumpShootLogs should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/hook/handler.go
    • Line 37: warning: exported type Handler should have comment or be unexported (golint)
    • Line 44: warning: exported function New should have comment or be unexported (golint)
    • Line 77: warning: exported method Handler.HandleWebhook should have comment or be unexported (golint)
    • test-infra/pkg/util/cmdvalues/duration.go
    • Line 22: warning: exported type DurationValue should have comment or be unexported (golint)
    • Line 26: warning: exported function NewDurationValue should have comment or be unexported (golint)
    • Line 35: warning: exported method DurationValue.Type should have comment or be unexported (golint)
    • Line 39: warning: exported method DurationValue.Set should have comment or be unexported (golint)
    • test-infra/pkg/apis/config/v1beta1/defaults.go
    • Line 32: warning: don't use underscores in Go names; func SetDefaults_Configuration should be SetDefaultsConfiguration (golint)
    • Line 47: warning: don't use underscores in Go names; func SetDefaults_ControllerConfig should be SetDefaultsControllerConfig (golint)
    • Line 66: warning: don't use underscores in Go names; func SetDefaults_TestMachineryConfiguration should be SetDefaultsTestMachineryConfiguration (golint)
    • Line 82: warning: comment on exported function SetDefaults_ReservedExcessCapacity should be of the form "SetDefaults_ReservedExcessCapacity ..." (golint)
    • Line 83: warning: don't use underscores in Go names; func SetDefaults_ReservedExcessCapacity should be SetDefaultsReservedExcessCapacity (golint)
    • Line 107: warning: don't use underscores in Go names; func SetDefaults_Webserver should be SetDefaultsWebserver (golint)
    • Line 117: warning: don't use underscores in Go names; func SetDefaults_GitHubBot should be SetDefaultsGitHubBot (golint)
    • Line 127: warning: don't use underscores in Go names; func SetDefaults_Dashboard should be SetDefaultsDashboard (golint)
    • Line 138: warning: don't use underscores in Go names; func SetDefaults_GitHubAuthentication should be SetDefaultsGitHubAuthentication (golint)
    • test-infra/pkg/apis/config/v1beta1/bot.go
    • Line 24: warning: comment on exported type BotConfiguration should be of the form "BotConfiguration ..." (with optional leading article) (golint)
    • Line 67: warning: exported const GitHubAuthProvider should have comment (or a comment on this block) or be unexported (golint)
    • Line 87: warning: exported type GitHubAuthentication should have comment or be unexported (golint)
    • Line 97: warning: exported type OAuth should have comment or be unexported (golint)
    • test-infra/pkg/util/machine_image.go
    • Line 12: warning: comment on exported function GetLatestMachineImageVersion should be of the form "GetLatestMachineImageVersion ..." (golint)
    • Line 61: warning: exported function GetMachineImage should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/tests/tests.go
    • Line 34: warning: exported type Runs should have comment or be unexported (golint)
    • Line 40: warning: exported type Run should have comment or be unexported (golint)
    • Line 45: warning: exported function NewRuns should have comment or be unexported (golint)
    • Line 86: warning: exported method Runs.Add should have comment or be unexported (golint)
    • Line 102: warning: exported method Runs.Remove should have comment or be unexported (golint)
    • Line 113: warning: comment on exported type TestConfig should be of the form "TestConfig ..." (with optional leading article) (golint)
    • test-infra/pkg/testrun_renderer/templates/gardensetup.go
    • Line 31: warning: exported const GardenCredentialsSecretName should have comment (or a comment on this block) or be unexported (golint)
    • Line 34: warning: exported type GardenerConfig should have comment or be unexported (golint)
    • Line 41: warning: exported function GetStepCreateGardener should have comment or be unexported (golint)
    • Line 73: warning: exported function GetStepDeleteGardener should have comment or be unexported (golint)
    • Line 91: warning: exported function AppendGardenerConfig should have comment or be unexported (golint)
    • Line 142: warning: exported function GetCreateGardenerConfig should have comment or be unexported (golint)
    • test-infra/pkg/util/testrun.go
    • Line 55: warning: exported function IsSystemStep should have comment or be unexported (golint)
    • Line 65: warning: comment on exported function ResumeTestrun should be of the form "ResumeTestrun ..." (golint)
    • test-infra/pkg/common/error/error.go
    • Line 19: warning: comment on exported type CommonReason should be of the form "CommonReason ..." (with optional leading article) (golint)
    • Line 23: warning: comment on exported const ReasonUnknown should be of the form "ReasonUnknown ..." (golint)
    • Line 26: warning: comment on exported const ReasonTimeout should be of the form "ReasonTimeout ..." (golint)
    • Line 29: warning: comment on exported const ReasonNotCreated should be of the form "ReasonNotCreated ..." (golint)
    • Line 32: warning: comment on exported const ReasonNotRendered should be of the form "ReasonNotRendered ..." (golint)
    • Line 35: warning: comment on exported const ReasonNotFound should be of the form "ReasonNotFound ..." (golint)
    • Line 38: warning: comment on exported const ReasonWrongType should be of the form "ReasonWrongType ..." (golint)
    • Line 73: warning: comment on exported function NewNotRenderedError should be of the form "NewNotRenderedError ..." (golint)
    • test-infra/pkg/util/cmdvalues/cloudprovider.go
    • Line 24: warning: exported type CloudProviderValue should have comment or be unexported (golint)
    • Line 29: warning: exported function NewCloudProviderValue should have comment or be unexported (golint)
    • Line 47: warning: exported method CloudProviderValue.Type should have comment or be unexported (golint)
    • Line 51: warning: exported method CloudProviderValue.Set should have comment or be unexported (golint)
    • test-infra/pkg/apis/telemetry/v1beta1/constants.go
    • Line 17: warning: exported type TelemetryPhase should have comment or be unexported (golint)
    • Line 20: warning: exported const TelemetryPhaseInit should have comment (or a comment on this block) or be unexported (golint)
    • Line 27: warning: exported const AnnotationStop should have comment (or a comment on this block) or be unexported (golint)
    • test-infra/pkg/logger/logger.go
    • Line 25: warning: exported var Log should have comment or be unexported (golint)
    • Line 90: warning: exported function New should have comment or be unexported (golint)
    • Line 106: warning: exported function SetLogger should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/tests/status.go
    • Line 36: warning: exported const GitHubCtxPrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported var GitHubState should have comment or be unexported (golint)
    • Line 50: warning: exported type StatusUpdater should have comment or be unexported (golint)
    • Line 63: warning: exported function NewStatusUpdater should have comment or be unexported (golint)
    • Line 72: warning: exported function NewStatusUpdaterFromCommentID should have comment or be unexported (golint)
    • Line 86: warning: exported method StatusUpdater.Init should have comment or be unexported (golint)
    • Line 100: warning: exported method StatusUpdater.GetCommentID should have comment or be unexported (golint)
    • Line 152: warning: exported function FormatInitStatus should have comment or be unexported (golint)
    • Line 157: warning: exported function FormatStatus should have comment or be unexported (golint)
    • test-infra/pkg/apis/config/bot.go
    • Line 24: warning: comment on exported type BotConfiguration should be of the form "BotConfiguration ..." (with optional leading article) (golint)
    • Line 67: warning: exported const GitHubAuthProvider should have comment (or a comment on this block) or be unexported (golint)
    • Line 87: warning: exported type GitHubAuthentication should have comment or be unexported (golint)
    • Line 97: warning: exported type OAuth should have comment or be unexported (golint)
    • test-infra/pkg/testmachinery/testflow/node/nodelist.go
    • Line 14: warning: comment on exported method Set.Copy should be of the form "Copy ..." (golint)
    • Line 51: warning: exported method Set.Iterate should have comment or be unexported (golint)
    • Line 64: warning: exported method Set.IterateInverse should have comment or be unexported (golint)
    • Line 118: warning: comment on exported method Set.Remove should be of the form "Remove ..." (golint)
    • Line 164: warning: comment on exported method Set.ClearParents should be of the form "ClearParents ..." (golint)
    • test-infra/pkg/testrunner/list.go
    • Line 68: warning: comment on exported method RunList.Run should be of the form "Run ..." (golint)
    • Line 148: warning: comment on exported method RunList.RenderTable should be of the form "RenderTable ..." (golint)
    • test-infra/integration-tests/e2e/util/sets/string.go
    • Line 13: warning: exported type Empty should have comment or be unexported (golint)
    • Line 15: warning: comment on exported type StringSet should be of the form "StringSet ..." (with optional leading article) (golint)
    • Line 32: warning: exported method StringSet.GetMatchingOfSet should have comment or be unexported (golint)
    • Line 44: warning: exported method StringSet.GetMatching should have comment or be unexported (golint)
    • Line 54: warning: exported method StringSet.GetMatchingForTestcase should have comment or be unexported (golint)
    • Line 85: warning: exported method StringSet.DeleteMatchingSet should have comment or be unexported (golint)
    • Line 93: warning: exported method StringSet.DeleteMatching should have comment or be unexported (golint)
    • Line 114: warning: receiver name s1 should be consistent with previous receiver name s for StringSet (golint)
    • Line 166: warning: comment on exported method StringSet.PopAny should be of the form "PopAny ..." (golint)
    • Line 187: warning: exported method StringSet.WriteToFile should have comment or be unexported (golint)
    • test-infra/pkg/testrunner/result/status-uploader.go
    • Line 33: warning: comment on exported function UploadStatusToGithub should be of the form "UploadStatusToGithub ..." (golint)
    • Line 464: warning: comment on exported function MarkTestrunsAsUploadedToGithub should be of the form "MarkTestrunsAsUploadedToGithub ..." (golint)
    • Line 481: warning: exported type ComponentExtended should have comment or be unexported (golint)
    • Line 512: warning: exported type AssetOverview should have comment or be unexported (golint)
    • Line 516: warning: exported method AssetOverview.Get should have comment or be unexported (golint)
    • Line 525: warning: exported method AssetOverview.Contains should have comment or be unexported (golint)
    • Line 529: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 534: warning: exported type AssetOverviewItem should have comment or be unexported (golint)
    • test-infra/pkg/hostscheduler/constants.go
    • Line 26: warning: exported function ShootKubeconfigSecretName should have comment or be unexported (golint)
    • Line 30: warning: exported function HostKubeconfigPath should have comment or be unexported (golint)
    • Line 37: warning: exported function HostConfigFilePath should have comment or be unexported (golint)
    • test-infra/pkg/testrunner/util.go
    • Line 33: warning: exported function GetArgoURL should have comment or be unexported (golint)
    • Line 104: warning: comment on exported function GetHostURLFromIngress should be of the form "GetHostURLFromIngress ..." (golint)
    • test-infra/pkg/tm-bot/ui/pages/status.go
    • Line 39: warning: exported type IconWithTooltip should have comment or be unexported (golint)
    • Line 45: warning: exported var PhaseIcon should have comment or be unexported (golint)
    • Line 124: warning: exported function NewPRStatusPage should have comment or be unexported (golint)
    • Line 162: warning: exported function NewPRStatusDetailPage should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/github/types.go
    • Line 30: warning: exported type Manager should have comment or be unexported (golint)
    • Line 111: warning: exported const AuthorizationAll should have comment (or a comment on this block) or be unexported (golint)
    • Line 122: warning: exported const EventActionTypeCreated should have comment (or a comment on this block) or be unexported (golint)
    • Line 131: warning: exported const UserTypeUser should have comment (or a comment on this block) or be unexported (golint)
    • Line 136: warning: comment on exported type State should be of the form "State ..." (with optional leading article) (golint)
    • Line 140: warning: exported const StateError should have comment (or a comment on this block) or be unexported (golint)
    • Line 150: warning: exported const MembershipRoleAdmin should have comment (or a comment on this block) or be unexported (golint)
    • Line 159: warning: exported const MembershipStatusActive should have comment (or a comment on this block) or be unexported (golint)
    • Line 166: warning: exported const ContentTypeFile should have comment (or a comment on this block) or be unexported (golint)
    • test-infra/pkg/util/cmdvalues/hostprovider.go
    • Line 22: warning: exported type HostProviderValue should have comment or be unexported (golint)
    • Line 26: warning: exported function NewHostProviderValue should have comment or be unexported (golint)
    • Line 40: warning: exported method HostProviderValue.Type should have comment or be unexported (golint)
    • Line 44: warning: exported method HostProviderValue.Set should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/plugins/xkcd/xkcd.go
    • Line 46: warning: exported function New should have comment or be unexported (golint)
    • Line 59: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 63: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 67: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 71: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 75: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 79: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • test-infra/pkg/testmachinery/testdefinition/artifactset.go
    • Line 17: warning: exported type ArtifactSet should have comment or be unexported (golint)
    • Line 21: warning: exported method ArtifactSet.Add should have comment or be unexported (golint)
    • Line 25: warning: exported method ArtifactSet.Has should have comment or be unexported (golint)
    • Line 30: warning: exported method ArtifactSet.Copy should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/plugins/skip/skip.go
    • Line 33: warning: exported function New should have comment or be unexported (golint)
    • Line 44: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 48: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 52: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 56: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 60: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 64: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • test-infra/pkg/testrunner/result/collector.go
    • Line 32: warning: exported function New should have comment or be unexported (golint)
    • Line 51: warning: exported method Collector.PreRunShoots should have comment or be unexported (golint)
    • Line 82: warning: exported method Collector.PreRunGardener should have comment or be unexported (golint)
    • test-infra/integration-tests/e2e/kubetest/desc_generator.go
    • Line 21: warning: exported const FalsePositivesDescFile should have comment (or a comment on this block) or be unexported (golint)
    • Line 31: warning: exported var GeneratedRunDescPath should have comment or be unexported (golint)
    • Line 32: warning: exported var AllTestcasesFilePath should have comment or be unexported (golint)
    • Line 35: warning: exported function Generate should have comment or be unexported (golint)
    • Line 187: warning: exported function UnmarshalDescription should have comment or be unexported (golint)
    • Line 199: warning: exported function UnmarshalJunitXMLResult should have comment or be unexported (golint)
    • Line 230: warning: exported type TestcaseDesc should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/plugins/plugins.go
    • Line 75: warning: exported type Plugins should have comment or be unexported (golint)
    • Line 89: warning: exported function New should have comment or be unexported (golint)
    • Line 121: warning: exported method Plugins.Get should have comment or be unexported (golint)
    • Line 188: warning: exported function UpdateState should have comment or be unexported (golint)
    • test-infra/test/framework/types.go
    • Line 25: warning: exported const TestNamespacePrefix should have comment (or a comment on this block) or be unexported (golint)
    • Line 29: warning: exported var CoreSecrets should have comment or be unexported (golint)
    • Line 34: warning: comment on exported type Config should be of the form "Config ..." (with optional leading article) (golint)
    • Line 56: warning: exported type OperationState should have comment or be unexported (golint)
    • test-infra/pkg/util/cmdvalues/cloudproviderarray.go
    • Line 24: warning: exported type CloudProviderArrayValue should have comment or be unexported (golint)
    • Line 31: warning: exported function NewCloudProviderArrayValue should have comment or be unexported (golint)
    • Line 50: warning: exported method CloudProviderArrayValue.Type should have comment or be unexported (golint)
    • Line 54: warning: exported method CloudProviderArrayValue.Set should have comment or be unexported (golint)
    • test-infra/pkg/testrun_renderer/templates/templates.go
    • Line 23: warning: exported var TestInfraLocationName should have comment or be unexported (golint)
    • Line 24: warning: exported var DefaultLocationSetName should have comment or be unexported (golint)
    • Line 26: warning: exported var TestInfraLocation should have comment or be unexported (golint)
    • Line 38: warning: exported function GetDefaultLocationsSet should have comment or be unexported (golint)
    • test-infra/cmd/testrunner/cmd/gardener_telemetry/update.go
    • Line 1: warning: don't use an underscore in package name (golint)
    • Line 19: warning: context.Context should be the first parameter of a function (golint)
    • Line 19: warning: exported function GetUnhealthyShoots should have comment or be unexported (golint)
    • Line 53: warning: context.Context should be the first parameter of a function (golint)
    • Line 53: warning: exported function WaitForGardenerUpdate should have comment or be unexported (golint)
    • test-infra/pkg/testmachinery/config/set.go
    • Line 19: warning: exported function NewSet should have comment or be unexported (golint)
    • Line 27: warning: exported method Set.List should have comment or be unexported (golint)
    • Line 37: warning: exported method Set.RawList should have comment or be unexported (golint)
    • Line 47: warning: exported method Set.Copy should have comment or be unexported (golint)
    • test-infra/test/utils/mocks.go
    • Line 26: warning: exported type LocationsMock should have comment or be unexported (golint)
    • Line 34: warning: exported method LocationsMock.GetTestDefinitions should have comment or be unexported (golint)
    • Line 51: warning: exported var EmptyMockLocation should have comment or be unexported (golint)
    • Line 57: warning: exported type TDLocationMock should have comment or be unexported (golint)
    • Line 61: warning: exported method TDLocationMock.Name should have comment or be unexported (golint)
    • Line 65: warning: exported method TDLocationMock.Type should have comment or be unexported (golint)
    • Line 69: warning: exported method TDLocationMock.GitInfo should have comment or be unexported (golint)
    • Line 73: warning: exported method TDLocationMock.SetTestDefs should have comment or be unexported (golint)
    • Line 77: warning: exported method TDLocationMock.GetLocation should have comment or be unexported (golint)
    • test-infra/pkg/util/strconf/strconf.go
    • Line 35: warning: exported const String should have comment (or a comment on this block) or be unexported (golint)
    • Line 103: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 107: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • test-infra/pkg/testmachinery/controller/watch/eventbus.go
    • Line 32: warning: exported type TestrunChannel should have comment or be unexported (golint)
    • Line 34: warning: exported type EventBusHandle should have comment or be unexported (golint)
    • Line 36: warning: exported type EventBus should have comment or be unexported (golint)
    • Line 58: warning: exported function NewEventBus should have comment or be unexported (golint)
    • test-infra/pkg/apis/telemetry/v1beta1/types.go
    • Line 29: warning: comment on exported type ShootsMeasurement should be of the form "ShootsMeasurement ..." (with optional leading article) (golint)
    • Line 41: warning: comment on exported type ShootsMeasurementList should be of the form "ShootsMeasurementList ..." (with optional leading article) (golint)
    • Line 92: warning: exported type ResponseTimeDuration should have comment or be unexported (golint)
    • Line 100: warning: exported type DowntimePeriods should have comment or be unexported (golint)
    • test-infra/pkg/util/util.go
    • Line 276: warning: comment on exported function CreateKubeconfigFromInternal should be of the form "CreateKubeconfigFromInternal ..." (golint)
    • Line 364: warning: comment on exported function IsLastElementOfBucket should be of the form "IsLastElementOfBucket ..." (golint)
    • Line 474: warning: exported type ESHits should have comment or be unexported (golint)
    • test-infra/integration-tests/e2e/kubetest/xml_junit_result.go
    • Line 12: warning: exported method JunitXMLResult.CalculateAdditionalFields should have comment or be unexported (golint)
    • Line 16: warning: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (golint)
    • Line 46: warning: exported type JunitXMLResult should have comment or be unexported (golint)
    • Line 57: warning: exported type TestcaseResult should have comment or be unexported (golint)
    • test-infra/test/framework/operation.go
    • Line 58: warning: exported method Operation.S3Endpoint should have comment or be unexported (golint)
    • Line 112: warning: exported method Operation.RunTestrunUntilCompleted should have comment or be unexported (golint)
    • Line 116: warning: exported method Operation.RunTestrun should have comment or be unexported (golint)
    • test-infra/pkg/util/slack-table-post.go
    • Line 34: warning: exported const StatusSymbolSuccess should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported type TableItems should have comment or be unexported (golint)
    • Line 43: warning: exported type TableItem should have comment or be unexported (golint)
    • Line 48: warning: exported type ItemMeta should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/github/ghval/ghval.go
    • Line 28: warning: exported const String should have comment (or a comment on this block) or be unexported (golint)
    • Line 32: warning: exported type StringOrGitHubValue should have comment or be unexported (golint)
    • Line 56: warning: exported method StringOrGitHubValue.UnmarshalJSON should have comment or be unexported (golint)
    • Line 80: warning: exported method StringOrGitHubValue.Value should have comment or be unexported (golint)
    • test-infra/pkg/tm-bot/plugins/echo/echo.go
    • Line 32: warning: exported function New should have comment or be unexported (golint)
    • Line 40: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 44: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 48: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 52: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 56: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • Line 60: warning: receiver name should not be an underscore, omit the name if it is unused (golint)
    • test-infra/pkg/tm-bot/tests/testrunner.go
    • Line 34: warning: exported method Runs.CreateTestrun should have comment or be unexported (golint)
    • Line 51: warning: context.Context should be the first parameter of a function (golint)
    • Line 51: warning: exported method Runs.Watch should have comment or be unexported (golint)
    • test-infra/pkg/testmachinery/config.go
    • Line 31: warning: exported type Phase should have comment or be unexported (golint)
    • Line 37: warning: comment on exported const PhaseExit should be of the form "PhaseExit ..." (golint)
    • Line 42: warning: comment on exported const TM_KUBECONFIG_PATH_NAME should be of the form "TM_KUBECONFIG_PATH_NAME ..." (golint)
    • Line 54: warning: comment on exported const TM_REPO_PATH_NAME should be of the form "TM_REPO_PATH_NAME ..." (golint)
    • Line 63: warning: comment on exported const TM_EXPORT_PATH_NAME should be of the form "TM_EXPORT_PATH_NAME ..." (golint)
    • Line 84: warning: comment on exported const WorkerPoolTaintLabelName should be of the form "WorkerPoolTaintLabelName ..." (golint)
    • Line 87: warning: comment on exported const PauseTemplateName should be of the form "PauseTemplateName ..." (golint)
    • Line 108: warning: comment on exported type GitHubConfig should be of the form "GitHubConfig ..." (with optional leading article) (golint)
    • Line 114: warning: comment on exported type GitHubSecrets should be of the form "GitHubSecrets ..." (with optional leading article) (golint)
    • Line 192: warning: comment on exported method TmConfiguration.Copy should be of the form "Copy ..." (golint)
    • test-infra/pkg/testmachinery/testdefinition/testdefinition.go
    • Line 42: warning: exported var DefaultActiveDeadlineSeconds should have comment or be unexported (golint)
    • Line 141: warning: comment on exported method TestDefinition.Copy should be of the form "Copy ..." (golint)
    • Line 157: warning: exported method TestDefinition.SetName should have comment or be unexported (golint)
    • Line 161: warning: exported method TestDefinition.GetName should have comment or be unexported (golint)
    • Line 165: warning: exported method TestDefinition.SetSuspend should have comment or be unexported (golint)
    • Line 169: warning: exported method TestDefinition.GetTemplate should have comment or be unexported (golint)
    • Line 269: warning: exported method TestDefinition.GetConfig should have comment or be unexported (golint)
    • Line 333: warning: exported method TestDefinition.AddVolumeFromConfig should have comment or be unexported (golint)
    • Line 342: warning: comment on exported method TestDefinition.AddAnnotation should be of the form "AddAnnotation ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign99%

IneffAssign detects ineffectual assignments in Go code.

misspell96%

Misspell Finds commonly misspelled English words