Preparing report...

Report for github.com/genofire/yaja

A+    Excellent!    Found 34 issues across 84 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint64%

Golint is a linter for Go source code.

    • yaja/server/server.go
    • Line 18: warning: exported type Server should have comment or be unexported (golint)
    • Line 32: warning: exported method Server.Start should have comment or be unexported (golint)
    • Line 113: warning: exported method Server.DomainRegisterAllowed should have comment or be unexported (golint)
    • Line 126: warning: exported method Server.Close should have comment or be unexported (golint)
    • yaja/model/buddy.go
    • Line 4: warning: exported const SubscriptionNone should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported type Buddy should have comment or be unexported (golint)
    • Line 19: warning: exported type Bookmark should have comment or be unexported (golint)
    • yaja/daemon/tester/status.go
    • Line 14: warning: exported type Status should have comment or be unexported (golint)
    • Line 30: warning: exported function NewStatus should have comment or be unexported (golint)
    • Line 40: warning: exported method Status.Disconnect should have comment or be unexported (golint)
    • yaja/xmpp/iq/roster.go
    • Line 25: warning: comment on exported type RosterSubscriptionType should be of the form "RosterSubscriptionType ..." (with optional leading article) (golint)
    • yaja/client/client.go
    • Line 33: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 41: warning: exported method Client.Connect should have comment or be unexported (golint)
    • Line 75: warning: receiver name c should be consistent with previous receiver name client for Client (golint)
    • yaja/server/extension/presence.go
    • Line 10: warning: exported type Presence should have comment or be unexported (golint)
    • Line 16: warning: exported method Presence.Spaces should have comment or be unexported (golint)
    • Line 18: warning: exported method Presence.Process should have comment or be unexported (golint)
    • yaja/server/utils/client.go
    • Line 13: warning: exported type Client should have comment or be unexported (golint)
    • Line 27: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 41: warning: exported method Client.SetConnecting should have comment or be unexported (golint)
    • Line 61: warning: exported method Client.OnClose should have comment or be unexported (golint)
    • Line 65: warning: exported method Client.Close should have comment or be unexported (golint)
    • yaja/daemon/tester/output.go
    • Line 12: warning: exported type Output should have comment or be unexported (golint)
    • Line 18: warning: exported type Link should have comment or be unexported (golint)
    • Line 27: warning: exported method Tester.Output should have comment or be unexported (golint)
    • yaja/client/start.go
    • Line 10: warning: exported var DefaultChannelSize should have comment or be unexported (golint)
    • Line 12: warning: exported method Client.Start should have comment or be unexported (golint)
    • Line 127: warning: exported method Client.SendRecv should have comment or be unexported (golint)
    • Line 151: warning: exported method Client.Recv should have comment or be unexported (golint)
    • yaja/client/tls.go
    • Line 5: warning: exported method Client.TLSConnectionState should have comment or be unexported (golint)
    • yaja/database/main.go
    • Line 13: warning: exported type State should have comment or be unexported (golint)
    • Line 18: warning: exported method State.AddAccount should have comment or be unexported (golint)
    • Line 53: warning: exported method State.Authenticate should have comment or be unexported (golint)
    • Line 60: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 72: warning: exported method State.GetAccount should have comment or be unexported (golint)
    • Line 78: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • yaja/model/account.go
    • Line 10: warning: exported type Domain should have comment or be unexported (golint)
    • Line 16: warning: exported method Domain.GetJID should have comment or be unexported (golint)
    • Line 22: warning: exported method Domain.UpdateAccount should have comment or be unexported (golint)
    • Line 33: warning: exported type Account should have comment or be unexported (golint)
    • Line 41: warning: exported function NewAccount should have comment or be unexported (golint)
    • Line 54: warning: exported method Account.GetJID should have comment or be unexported (golint)
    • Line 61: warning: exported method Account.ValidatePassword should have comment or be unexported (golint)
    • yaja/server/extension/main.go
    • Line 9: warning: exported type Extensions should have comment or be unexported (golint)
    • Line 11: warning: exported type Extension should have comment or be unexported (golint)
    • Line 16: warning: exported method Extensions.Spaces should have comment or be unexported (golint)
    • Line 23: warning: exported method Extensions.Process should have comment or be unexported (golint)
    • yaja/xmpp/utils.go
    • Line 11: warning: exported function XMLStartElementToString should have comment or be unexported (golint)
    • Line 23: warning: exported function XMLChildrenString should have comment or be unexported (golint)
    • Line 49: warning: exported function CreateCookie should have comment or be unexported (golint)
    • Line 56: warning: exported function CreateCookieString should have comment or be unexported (golint)
    • yaja/server/extension/iq.go
    • Line 10: warning: exported type IQExtensions should have comment or be unexported (golint)
    • Line 12: warning: exported type IQExtension should have comment or be unexported (golint)
    • Line 18: warning: exported method IQExtensions.Spaces should have comment or be unexported (golint)
    • Line 26: warning: exported method IQExtensions.Process should have comment or be unexported (golint)
    • yaja/server/extension/iq_ping.go
    • Line 9: warning: exported type IQPing should have comment or be unexported (golint)
    • Line 13: warning: exported method IQPing.Spaces should have comment or be unexported (golint)
    • Line 15: warning: exported method IQPing.Get should have comment or be unexported (golint)
    • yaja/server/extension/message.go
    • Line 9: warning: exported type Message should have comment or be unexported (golint)
    • Line 15: warning: exported method Message.Spaces should have comment or be unexported (golint)
    • Line 17: warning: exported method Message.Process should have comment or be unexported (golint)
    • yaja/daemon/tester/tester.go
    • Line 14: warning: exported type Tester should have comment or be unexported (golint)
    • Line 25: warning: exported function NewTester should have comment or be unexported (golint)
    • Line 32: warning: exported method Tester.Start should have comment or be unexported (golint)
    • Line 54: warning: exported method Tester.Close should have comment or be unexported (golint)
    • Line 60: warning: exported method Tester.Connect should have comment or be unexported (golint)
    • Line 122: warning: exported method Tester.CheckStatus should have comment or be unexported (golint)
    • yaja/client/comm.go
    • Line 25: warning: exported method Client.Decode should have comment or be unexported (golint)
    • Line 29: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 38: warning: exported method Client.ReadDecode should have comment or be unexported (golint)
    • Line 73: warning: exported method Client.Send should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!