gofmt95%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• terraform-provider-consulclient/provider/resource_consul_acl.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• terraform-provider-consulclient/provider/data_source_consul_agent_self.go
  • Line 772: warning: cyclomatic complexity 148 of function dataSourceConsulAgentSelfRead() is high (> 15) (gocyclo)

• terraform-provider-consulclient/provider/config.go
  • Line 27: warning: cyclomatic complexity 18 of function (*ProviderConfig).GetResolvedConfig() is high (> 15) (gocyclo)

• terraform-provider-consulclient/provider/resource_consul_keys.go
  • Line 154: warning: cyclomatic complexity 17 of function resourceConsulKeysUpdate() is high (> 15) (gocyclo)

golint80%

Golint is a linter for Go source code.

• terraform-provider-consulclient/provider/acl_client.go
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• terraform-provider-consulclient/provider/config.go
  • Line 16: warning: exported type ProviderConfig should have comment or be unexported (golint)
  • Line 27: warning: exported method ProviderConfig.GetResolvedConfig should have comment or be unexported (golint)
  • Line 84: warning: comment on exported method ProviderConfig.NewClient should be of the form "NewClient ..." (golint)

• terraform-provider-consulclient/provider/resource_consul_catalog_entry.go
  • Line 241: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• terraform-provider-consulclient/provider/resource_consul_node.go
  • Line 129: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign71%

IneffAssign detects ineffectual assignments in Go code.

• terraform-provider-consulclient/provider/config.go
  • Line 12: warning: cannot find package "." in: (ineffassign)
  • Line 13: warning: cannot find package "." in: (ineffassign)
  • Line 12: warning: could not import github.com/hashicorp/terraform/helper/schema (invalid package name: "") (ineffassign)
  • Line 13: warning: could not import github.com/mitchellh/mapstructure (invalid package name: "") (ineffassign)
  • Line 8: warning: "net/http" imported but not used (ineffassign)

• terraform-provider-consulclient/provider/provider.go
  • Line 8: warning: cannot find package "." in: (ineffassign)
  • Line 8: warning: could not import github.com/hashicorp/terraform/terraform (invalid package name: "") (ineffassign)

• terraform-provider-consulclient/main.go
  • Line 10: warning: cannot find package "." in: (ineffassign)
  • Line 8: warning: cannot find package "." in: (ineffassign)
  • Line 8: warning: could not import github.com/hashicorp/terraform/plugin (invalid package name: "") (ineffassign)
  • Line 10: warning: could not import github.com/giacomocariello/terraform-provider-consulclient/provider (invalid package name: "") (ineffassign)

• terraform-provider-consulclient/provider/acl_client.go
  • Line 10: warning: cannot find package "." in: (ineffassign)
  • Line 10: warning: could not import github.com/hashicorp/consul/api (invalid package name: "") (ineffassign)

• terraform-provider-consulclient/provider/data_source_consul_agent_self.go
  • Line 11: warning: cannot find package "." in: (ineffassign)
  • Line 11: warning: could not import github.com/hashicorp/errwrap (invalid package name: "") (ineffassign)

• terraform-provider-consulclient/provider/resource_consul_catalog_entry.go
  • Line 13: warning: cannot find package "." in: (ineffassign)
  • Line 13: warning: could not import github.com/hashicorp/terraform/helper/hashcode (invalid package name: "") (ineffassign)

misspell95%

Misspell Finds commonly misspelled English words

• terraform-provider-consulclient/provider/resource_consul_keys.go
  • Line 281: warning: "compatibilty" is a misspelling of "compatibility" (misspell)