Preparing report...

Report for github.com/gimlet-io/gimlet-cli

(v0.12.2)

A+    Excellent!    Found 25 issues across 55 files

Tweet

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint56%

Golint is a linter for Go source code.

    • pkg/commands/artifact/list.go
    • Line 191: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 203: warning: exported function RenderGitVersion should have comment or be unexported (golint)
    • pkg/commands/stack/template.go
    • Line 25: warning: exported type StackRef should have comment or be unexported (golint)
    • Line 29: warning: exported type StackConfig should have comment or be unexported (golint)
    • Line 34: warning: exported function GenerateFromStackYaml should have comment or be unexported (golint)
    • Line 81: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 240: warning: exported function IsVersionLocked should have comment or be unexported (golint)
    • Line 246: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 265: warning: exported function LatestVersion should have comment or be unexported (golint)
    • Line 312: warning: exported function VersionsSince should have comment or be unexported (golint)
    • Line 363: warning: exported function CurrentVersion should have comment or be unexported (golint)
    • Line 377: warning: exported function RepoUrlWithoutVersion should have comment or be unexported (golint)
    • pkg/commands/stack/configure.go
    • Line 30: warning: exported var ConfigureCmd should have comment or be unexported (golint)
    • Line 143: warning: exported type Component should have comment or be unexported (golint)
    • Line 154: warning: exported type StackDefinition should have comment or be unexported (golint)
    • Line 164: warning: exported function StackDefinitionFromRepo should have comment or be unexported (golint)
    • Line 176: warning: exported function Configure should have comment or be unexported (golint)
    • pkg/commands/stack/generate.go
    • Line 19: warning: exported var GenerateCmd should have comment or be unexported (golint)
    • Line 164: warning: should omit 2nd value from range; this loop is equivalent to `for path := range ...` (golint)
    • pkg/commands/commands.go
    • Line 12: warning: don't use underscores in Go names; const File_RW_RW_R should be FileRWRWR (golint)
    • Line 12: warning: exported const File_RW_RW_R should have comment or be unexported (golint)
    • Line 13: warning: don't use underscores in Go names; const Dir_RWX_RX_R should be DirRWXRXR (golint)
    • Line 13: warning: exported const Dir_RWX_RX_R should have comment or be unexported (golint)
    • Line 15: warning: exported function Run should have comment or be unexported (golint)
    • Line 28: warning: exported function InputFiles should have comment or be unexported (golint)
    • Line 38: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 60: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • pkg/commands/stack/web/web.go
    • Line 3: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 5: warning: comment on exported var BundleJs should be of the form "BundleJs ..." (golint)
    • Line 8: warning: comment on exported var LicenseTxt should be of the form "LicenseTxt ..." (golint)
    • Line 11: warning: comment on exported var IndexHtml should be of the form "IndexHtml ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign96%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!