Go Report Card

Preparing report...

Report for github.com/goki/gopix

A    Great!    Found 11 issues across 15 files

Tweet
Last refresh:

Refresh now

gofmt86%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo73%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • gopix/imgrid/imgrid.go
    • Line 1177: warning: cyclomatic complexity 21 of function (*ImgGrid).KeyInputActive() is high (> 15) (gocyclo)
    • Line 702: warning: cyclomatic complexity 21 of function (*ImgGrid).SelectIdxAction() is high (> 15) (gocyclo)
    • gopix/picinfo/exif.go
    • Line 119: warning: cyclomatic complexity 60 of function (*Info).ParseRawExif() is high (> 15) (gocyclo)
    • Line 315: warning: cyclomatic complexity 22 of function (*Info).UpdateExif() is high (> 15) (gocyclo)

golint33%

Golint is a linter for Go source code.

    • gopix/picinfo/info.go
    • Line 40: warning: exported method Info.Defaults should have comment or be unexported (golint)
    • Line 160: warning: exported const OrientationsN should have comment (or a comment on this block) or be unexported (golint)
    • Line 165: warning: don't use underscores in Go names; var KiT_Orientations should be KiTOrientations (golint)
    • Line 165: warning: exported var KiT_Orientations should have comment or be unexported (golint)
    • Line 167: warning: exported method Orientations.MarshalJSON should have comment or be unexported (golint)
    • Line 168: warning: exported method Orientations.UnmarshalJSON should have comment or be unexported (golint)
    • Line 172: warning: receiver name or should be consistent with previous receiver name ev for Orientations (golint)
    • Line 215: warning: receiver name or should be consistent with previous receiver name ev for Orientations (golint)
    • gopix/gopix/filetree.go
    • Line 92: warning: don't use underscores in Go names; var KiT_FileTreeView should be KiTFileTreeView (golint)
    • Line 92: warning: exported var KiT_FileTreeView should have comment or be unexported (golint)
    • Line 94: warning: exported var FileTreeViewProps should have comment or be unexported (golint)
    • gopix/gopix/imgview.go
    • Line 25: warning: don't use underscores in Go names; var KiT_ImgView should be KiTImgView (golint)
    • Line 25: warning: exported var KiT_ImgView should have comment or be unexported (golint)
    • Line 32: warning: exported method ImgView.KeyInput should have comment or be unexported (golint)
    • Line 82: warning: exported method ImgView.ConnectEvents2D should have comment or be unexported (golint)
    • Line 86: warning: exported method ImgView.ImgViewEvents should have comment or be unexported (golint)
    • Line 95: warning: exported var ImgViewProps should have comment or be unexported (golint)
    • gopix/gopix/pixview.go
    • Line 49: warning: don't use underscores in Go names; var KiT_PixView should be KiTPixView (golint)
    • Line 49: warning: exported var KiT_PixView should have comment or be unexported (golint)
    • Line 299: warning: exported method PixView.Render2D should have comment or be unexported (golint)
    • Line 312: warning: exported method PixView.ImgGridCtxtMenu should have comment or be unexported (golint)
    • Line 951: warning: exported var PixViewProps should have comment or be unexported (golint)
    • gopix/gopix/pprog.go
    • Line 23: warning: exported function ProgInc should have comment or be unexported (golint)
    • Line 33: warning: exported method PProg.Start should have comment or be unexported (golint)
    • Line 41: warning: exported method PProg.UpdtBar should have comment or be unexported (golint)
    • gopix/gopix/thumbs.go
    • Line 28: warning: exported const ThumbMaxSize should have comment or be unexported (golint)
    • Line 116: warning: exported method PixView.InfoUpdtThr should have comment or be unexported (golint)
    • Line 465: warning: exported method PixView.CleanAllInfoThr should have comment or be unexported (golint)
    • Line 564: warning: exported method PixView.CleanDupesThr should have comment or be unexported (golint)
    • gopix/imgview/imgview.go
    • Line 31: warning: don't use underscores in Go names; var KiT_ImgView should be KiTImgView (golint)
    • Line 31: warning: exported var KiT_ImgView should have comment or be unexported (golint)
    • Line 102: warning: exported method ImgView.ConnectEvents2D should have comment or be unexported (golint)
    • Line 106: warning: exported method ImgView.ImgViewEvents should have comment or be unexported (golint)
    • Line 115: warning: exported method ImgView.ImgViewMouseEvents should have comment or be unexported (golint)
    • Line 134: warning: exported method ImgView.KeyInput should have comment or be unexported (golint)
    • Line 166: warning: exported var ImgViewProps should have comment or be unexported (golint)
    • gopix/imgrid/imgrid.go
    • Line 46: warning: don't use underscores in Go names; var KiT_ImgGrid should be KiTImgGrid (golint)
    • Line 46: warning: exported var KiT_ImgGrid should have comment or be unexported (golint)
    • Line 60: warning: exported method ImgGrid.NumImages should have comment or be unexported (golint)
    • Line 117: warning: exported method ImgGrid.SetScrollMax should have comment or be unexported (golint)
    • Line 185: warning: exported const ImgGridSignalsN should have comment (or a comment on this block) or be unexported (golint)
    • Line 214: warning: exported method ImgGrid.Layout2D should have comment or be unexported (golint)
    • Line 258: warning: exported method ImgGrid.RenderSelected should have comment or be unexported (golint)
    • Line 291: warning: exported method ImgGrid.Render2D should have comment or be unexported (golint)
    • Line 311: warning: exported method ImgGrid.ConnectEvents2D should have comment or be unexported (golint)
    • Line 315: warning: exported method ImgGrid.ImgGridEvents should have comment or be unexported (golint)
    • Line 641: warning: exported method ImgGrid.ResetSelectedIdxs should have comment or be unexported (golint)
    • Line 649: warning: should omit 2nd value from range; this loop is equivalent to `for r := range ...` (golint)
    • Line 739: warning: should omit 2nd value from range; this loop is equivalent to `for r := range ...` (golint)
    • Line 1136: warning: exported method ImgGrid.StdCtxtMenu should have comment or be unexported (golint)
    • Line 1164: warning: exported method ImgGrid.ItemCtxtMenu should have comment or be unexported (golint)
    • Line 1177: warning: exported method ImgGrid.KeyInputActive should have comment or be unexported (golint)
    • Line 1256: warning: exported var ImgGridProps should have comment or be unexported (golint)
    • gopix/picinfo/exif.go
    • Line 577: warning: exported function ExifDateParser should have comment or be unexported (golint)
    • Line 617: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 635: warning: don't use underscores in Go names; var len_ should be len (golint)
    • Line 646: warning: comment on exported type IfdEntry should be of the form "IfdEntry ..." (with optional leading article) (golint)
    • Line 660: warning: exported method IfdEntry.ToInt should have comment or be unexported (golint)
    • Line 689: warning: exported method IfdEntry.ToFloat should have comment or be unexported (golint)
    • Line 718: warning: exported method IfdEntry.ToFloats should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign86%

IneffAssign detects ineffectual assignments in Go code.

    • gopix/picinfo/exif.go
    • Line 138: warning: cannot use ifdPath (variable of type string) as *exifcommon.IfdIdentity value in argument to ti.Get (ineffassign)
    • Line 165: warning: IfdStandard not declared by package exifcommon (ineffassign)
    • Line 514: warning: ExifPrefix not declared by package jpegstructure (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!