Report for github.com/graphite-ng/carbon-relay-ng
A+ Excellent! Found 69 issues across 91 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo91%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
carbon-relay-ng/imperatives/imperatives.go
- Line 1124: warning: cyclomatic complexity 60 of function readDestination() is high (> 15) (gocyclo)
- Line 629: warning: cyclomatic complexity 58 of function readAddRouteKafkaMdm() is high (> 15) (gocyclo)
- Line 230: warning: cyclomatic complexity 44 of function readAddAgg() is high (> 15) (gocyclo)
- Line 477: warning: cyclomatic complexity 41 of function readAddRouteGrafanaNet() is high (> 15) (gocyclo)
- Line 830: warning: cyclomatic complexity 30 of function readAddRoutePubSub() is high (> 15) (gocyclo)
- Line 977: warning: cyclomatic complexity 22 of function readModDest() is high (> 15) (gocyclo)
- Line 1315: warning: cyclomatic complexity 18 of function readRouteOpts() is high (> 15) (gocyclo)
- Line 1045: warning: cyclomatic complexity 18 of function readModRoute() is high (> 15) (gocyclo)
- Line 357: warning: cyclomatic complexity 16 of function readAddBlack() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/route/kafkamdm.go
- Line 150: warning: cyclomatic complexity 23 of function (*KafkaMdm).run() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/aggregator/aggregator_test.go
- Line 221: warning: cyclomatic complexity 18 of function benchmarkAggregator() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/table/table.go
- Line 696: warning: cyclomatic complexity 57 of function (*Table).InitRoutes() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/cmd/carbon-relay-ng/carbon-relay-ng.go
- Line 90: warning: cyclomatic complexity 30 of function main() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/destination/destination.go
- Line 265: warning: cyclomatic complexity 30 of function (*Destination).relay() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/matcher/matcher.go
- Line 69: warning: cyclomatic complexity 17 of function (*Matcher).Match() is high (> 15) (gocyclo)
-
-
carbon-relay-ng/input/pickle.go
- Line 28: warning: cyclomatic complexity 32 of function (*Pickle).Handle() is high (> 15) (gocyclo)
golint27%
Golint is a linter for Go source code.
-
-
carbon-relay-ng/statsmt/out_graphite.go
- Line 21: warning: exported type GraphiteMetric should have comment or be unexported (golint)
- Line 26: warning: exported type Graphite should have comment or be unexported (golint)
- Line 34: warning: exported function NewGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/cfg/cfg.go
- Line 10: warning: exported type Config should have comment or be unexported (golint)
- Line 11: warning: don't use underscores in Go names; struct field Listen_addr should be ListenAddr (golint)
- Line 12: warning: don't use underscores in Go names; struct field Plain_read_timeout should be PlainReadTimeout (golint)
- Line 13: warning: don't use underscores in Go names; struct field Pickle_addr should be PickleAddr (golint)
- Line 14: warning: don't use underscores in Go names; struct field Pickle_read_timeout should be PickleReadTimeout (golint)
- Line 15: warning: don't use underscores in Go names; struct field Admin_addr should be AdminAddr (golint)
- Line 16: warning: don't use underscores in Go names; struct field Http_addr should be HTTPAddr (golint)
- Line 17: warning: don't use underscores in Go names; struct field Spool_dir should be SpoolDir (golint)
- Line 19: warning: don't use underscores in Go names; struct field Max_procs should be MaxProcs (golint)
- Line 20: warning: don't use underscores in Go names; struct field First_only should be FirstOnly (golint)
- Line 23: warning: don't use underscores in Go names; struct field Log_level should be LogLevel (golint)
- Line 25: warning: don't use underscores in Go names; struct field Bad_metrics_max_age should be BadMetricsMaxAge (golint)
- Line 26: warning: don't use underscores in Go names; struct field Pid_file should be PidFile (golint)
- Line 27: warning: don't use underscores in Go names; struct field Validation_level_legacy should be ValidationLevelLegacy (golint)
- Line 28: warning: don't use underscores in Go names; struct field Validation_level_m20 should be ValidationLevelM20 (golint)
- Line 29: warning: don't use underscores in Go names; struct field Validate_order should be ValidateOrder (golint)
- Line 36: warning: exported function NewConfig should have comment or be unexported (golint)
- Line 49: warning: exported type Duration should have comment or be unexported (golint)
- Line 53: warning: exported method Duration.UnmarshalText should have comment or be unexported (golint)
- Line 59: warning: exported type Aggregation should have comment or be unexported (golint)
- Line 75: warning: exported type Route should have comment or be unexported (golint)
- Line 130: warning: exported type Rewriter should have comment or be unexported (golint)
- Line 137: warning: exported type Amqp should have comment or be unexported (golint)
- Line 138: warning: don't use underscores in Go names; struct field Amqp_enabled should be AmqpEnabled (golint)
- Line 139: warning: don't use underscores in Go names; struct field Amqp_host should be AmqpHost (golint)
- Line 140: warning: don't use underscores in Go names; struct field Amqp_port should be AmqpPort (golint)
- Line 141: warning: don't use underscores in Go names; struct field Amqp_vhost should be AmqpVhost (golint)
- Line 142: warning: don't use underscores in Go names; struct field Amqp_user should be AmqpUser (golint)
- Line 143: warning: don't use underscores in Go names; struct field Amqp_password should be AmqpPassword (golint)
- Line 144: warning: don't use underscores in Go names; struct field Amqp_exchange should be AmqpExchange (golint)
- Line 145: warning: don't use underscores in Go names; struct field Amqp_queue should be AmqpQueue (golint)
- Line 146: warning: don't use underscores in Go names; struct field Amqp_key should be AmqpKey (golint)
- Line 147: warning: don't use underscores in Go names; struct field Amqp_durable should be AmqpDurable (golint)
- Line 148: warning: don't use underscores in Go names; struct field Amqp_exclusive should be AmqpExclusive (golint)
- Line 151: warning: exported type Init should have comment or be unexported (golint)
- Line 156: warning: don't use underscores in Go names; struct field Graphite_addr should be GraphiteAddr (golint)
- Line 157: warning: don't use underscores in Go names; struct field Graphite_interval should be GraphiteInterval (golint)
-
-
carbon-relay-ng/validate/ordered.go
- Line 20: warning: exported function Ordered should have comment or be unexported (golint)
-
-
carbon-relay-ng/input/plain.go
- Line 10: warning: exported type Plain should have comment or be unexported (golint)
- Line 14: warning: exported function NewPlain should have comment or be unexported (golint)
- Line 18: warning: exported method Plain.Kind should have comment or be unexported (golint)
- Line 22: warning: exported method Plain.Handle should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/memory_reporter.go
- Line 17: warning: exported function NewMemoryReporter should have comment or be unexported (golint)
- Line 39: warning: exported method MemoryReporter.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/metric.go
- Line 9: warning: exported type Datapoint should have comment or be unexported (golint)
- Line 15: warning: exported function ParseDataPoint should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/counter64.go
- Line 8: warning: exported type Counter64 should have comment or be unexported (golint)
- Line 12: warning: exported function NewCounter64 should have comment or be unexported (golint)
- Line 16: warning: exported method Counter64.SetUint64 should have comment or be unexported (golint)
- Line 20: warning: exported method Counter64.Inc should have comment or be unexported (golint)
- Line 24: warning: exported method Counter64.AddUint64 should have comment or be unexported (golint)
- Line 28: warning: exported method Counter64.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/gauge64.go
- Line 8: warning: exported type Gauge64 should have comment or be unexported (golint)
- Line 10: warning: exported function NewGauge64 should have comment or be unexported (golint)
- Line 15: warning: exported method Gauge64.Inc should have comment or be unexported (golint)
- Line 19: warning: exported method Gauge64.Dec should have comment or be unexported (golint)
- Line 23: warning: exported method Gauge64.AddUint64 should have comment or be unexported (golint)
- Line 27: warning: exported method Gauge64.DecUint64 should have comment or be unexported (golint)
- Line 31: warning: exported method Gauge64.Add should have comment or be unexported (golint)
- Line 43: warning: exported method Gauge64.Set should have comment or be unexported (golint)
- Line 47: warning: exported method Gauge64.SetUint64 should have comment or be unexported (golint)
- Line 51: warning: exported method Gauge64.ReportGraphite should have comment or be unexported (golint)
- Line 57: warning: exported method Gauge64.Peek should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/init.go
- Line 1: warning: package comment should be of the form "Package statsmt ..." (golint)
- Line 12: warning: exported var Register should have comment or be unexported (golint)
- Line 18: warning: exported function Clear should have comment or be unexported (golint)
-
-
carbon-relay-ng/stats/metrics_wrapper.go
- Line 17: warning: exported function New should have comment or be unexported (golint)
- Line 30: warning: exported function Counter should have comment or be unexported (golint)
- Line 35: warning: exported function Gauge should have comment or be unexported (golint)
- Line 40: warning: exported function Timer should have comment or be unexported (golint)
- Line 50: warning: exported function Histogram should have comment or be unexported (golint)
-
-
carbon-relay-ng/persister/whisper_schema.go
- Line 1: warning: package comment should be of the form "Package persister ..." (golint)
-
-
carbon-relay-ng/nsqd/diskqueue.go
- Line 130: warning: exported method DiskQueue.Delete should have comment or be unexported (golint)
-
-
carbon-relay-ng/input/pickle.go
- Line 16: warning: exported type Pickle should have comment or be unexported (golint)
- Line 20: warning: exported function NewPickle should have comment or be unexported (golint)
- Line 24: warning: exported method Pickle.Kind should have comment or be unexported (golint)
- Line 28: warning: exported method Pickle.Handle should have comment or be unexported (golint)
-
-
carbon-relay-ng/route/cloudwatch.go
- Line 21: warning: comment on exported type CloudWatch should be of the form "CloudWatch ..." (with optional leading article) (golint)
-
-
carbon-relay-ng/route/grafananet.go
- Line 31: warning: exported type GrafanaNet should have comment or be unexported (golint)
- Line 297: warning: exported method GrafanaNet.Flush should have comment or be unexported (golint)
- Line 351: warning: exported method GrafanaNet.Shutdown should have comment or be unexported (golint)
- Line 362: warning: exported method GrafanaNet.Snapshot should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/slowchan.go
- Line 7: warning: comment on exported function NewSlowChan should be of the form "NewSlowChan ..." (golint)
-
-
carbon-relay-ng/ui/web/web.go
- Line 314: warning: exported function Start should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/meter32.go
- Line 17: warning: exported type Meter32 should have comment or be unexported (golint)
- Line 28: warning: exported function NewMeter32 should have comment or be unexported (golint)
- Line 45: warning: exported method Meter32.Value should have comment or be unexported (golint)
- Line 49: warning: exported method Meter32.Values should have comment or be unexported (golint)
- Line 53: warning: exported method Meter32.ValueUint32 should have comment or be unexported (golint)
- Line 74: warning: exported method Meter32.ValuesUint32 should have comment or be unexported (golint)
- Line 95: warning: exported method Meter32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/timediff_reporter.go
- Line 8: warning: comment on exported type TimeDiffReporter32 should be of the form "TimeDiffReporter32 ..." (with optional leading article) (golint)
- Line 14: warning: exported function NewTimeDiffReporter32 should have comment or be unexported (golint)
- Line 21: warning: exported method TimeDiffReporter32.Set should have comment or be unexported (golint)
- Line 25: warning: exported method TimeDiffReporter32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/aggregator/aggregator.go
- Line 16: warning: exported type Aggregator should have comment or be unexported (golint)
- Line 61: warning: exported function NewMocked should have comment or be unexported (golint)
- Line 97: warning: exported type TsSlice should have comment or be unexported (golint)
- Line 126: warning: exported method Aggregator.AddOrCreate should have comment or be unexported (golint)
- Line 220: warning: exported method Aggregator.Shutdown should have comment or be unexported (golint)
- Line 225: warning: exported method Aggregator.AddMaybe should have comment or be unexported (golint)
- Line 246: warning: exported type CacheEntry should have comment or be unexported (golint)
- Line 353: warning: comment on exported method Aggregator.Snapshot should be of the form "Snapshot ..." (golint)
-
-
carbon-relay-ng/cmd/carbon-relay-ng/carbon-relay-ng_test.go
- Line 57: warning: don't use underscores in Go names; func parameter spool_dir should be spoolDir (golint)
- Line 379: warning: don't use underscores in Go names; var expected_template should be expectedTemplate (golint)
-
-
carbon-relay-ng/input/timeout_conn.go
- Line 14: warning: exported function NewTimeoutConn should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/gauge32.go
- Line 8: warning: exported type Gauge32 should have comment or be unexported (golint)
- Line 12: warning: exported function NewGauge32 should have comment or be unexported (golint)
- Line 16: warning: exported method Gauge32.Inc should have comment or be unexported (golint)
- Line 20: warning: exported method Gauge32.Dec should have comment or be unexported (golint)
- Line 24: warning: exported method Gauge32.AddUint32 should have comment or be unexported (golint)
- Line 28: warning: exported method Gauge32.DecUint32 should have comment or be unexported (golint)
- Line 32: warning: exported method Gauge32.Add should have comment or be unexported (golint)
- Line 44: warning: exported method Gauge32.Set should have comment or be unexported (golint)
- Line 48: warning: exported method Gauge32.SetUint32 should have comment or be unexported (golint)
- Line 52: warning: exported method Gauge32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/conn.go
- Line 16: warning: don't use underscores in Go names; var keepsafe_initial_cap should be keepsafeInitialCap (golint)
- Line 20: warning: don't use underscores in Go names; var keepsafe_keep_duration should be keepsafeKeepDuration (golint)
- Line 66: warning: exported function NewConn should have comment or be unexported (golint)
- Line 174: warning: exported method Conn.HandleData should have comment or be unexported (golint)
- Line 281: warning: exported method Conn.Flush should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/out_devnull.go
- Line 7: warning: exported function NewDevnull should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/write.go
- Line 8: warning: exported function WriteFloat64 should have comment or be unexported (golint)
- Line 18: warning: exported function WriteUint32 should have comment or be unexported (golint)
- Line 28: warning: exported function WriteUint64 should have comment or be unexported (golint)
- Line 38: warning: exported function WriteInt32 should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/latencyhistogram15s32.go
- Line 10: warning: comment on exported type LatencyHistogram15s32 should be of the form "LatencyHistogram15s32 ..." (with optional leading article) (golint)
- Line 17: warning: exported function NewLatencyHistogram15s32 should have comment or be unexported (golint)
- Line 25: warning: exported method LatencyHistogram15s32.Value should have comment or be unexported (golint)
- Line 30: warning: exported method LatencyHistogram15s32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/rewriter/rewriter.go
- Line 28: warning: comment on exported function New should be of the form "New ..." (golint)
-
-
carbon-relay-ng/table/table.go
- Line 27: warning: exported type TableConfig should have comment or be unexported (golint)
- Line 28: warning: don't use underscores in Go names; struct field Validation_level_legacy should be ValidationLevelLegacy (golint)
- Line 29: warning: don't use underscores in Go names; struct field Validation_level_m20 should be ValidationLevelM20 (golint)
- Line 30: warning: don't use underscores in Go names; struct field Validate_order should be ValidateOrder (golint)
- Line 37: warning: exported type Table should have comment or be unexported (golint)
- Line 50: warning: exported type TableSnapshot should have comment or be unexported (golint)
- Line 58: warning: exported function New should have comment or be unexported (golint)
- Line 90: warning: exported method Table.GetIn should have comment or be unexported (golint)
- Line 94: warning: exported method Table.GetSpoolDir should have comment or be unexported (golint)
- Line 98: warning: comment on exported method Table.IncNumInvalid should be of the form "IncNumInvalid ..." (golint)
- Line 105: warning: exported method Table.Bad should have comment or be unexported (golint)
- Line 114: warning: don't use underscores in Go names; var buf_copy should be bufCopy (golint)
- Line 201: warning: comment on exported method Table.Snapshot should be of the form "Snapshot ..." (golint)
- Line 228: warning: exported method Table.GetRoute should have comment or be unexported (golint)
- Line 248: warning: exported method Table.AddBlacklist should have comment or be unexported (golint)
- Line 256: warning: exported method Table.AddAggregator should have comment or be unexported (golint)
- Line 264: warning: exported method Table.AddRewriter should have comment or be unexported (golint)
- Line 272: warning: exported method Table.Flush should have comment or be unexported (golint)
- Line 283: warning: exported method Table.Shutdown should have comment or be unexported (golint)
- Line 298: warning: exported method Table.DelAggregator should have comment or be unexported (golint)
- Line 317: warning: exported method Table.DelBlacklist should have comment or be unexported (golint)
- Line 329: warning: exported method Table.DelDestination should have comment or be unexported (golint)
- Line 337: warning: exported method Table.DelRewriter should have comment or be unexported (golint)
- Line 352: warning: comment on exported method Table.DelRoute should be of the form "DelRoute ..." (golint)
- Line 382: warning: exported method Table.UpdateDestination should have comment or be unexported (golint)
- Line 390: warning: exported method Table.UpdateRoute should have comment or be unexported (golint)
- Line 398: warning: exported method Table.Print should have comment or be unexported (golint)
- Line 554: warning: exported function InitFromConfig should have comment or be unexported (golint)
- Line 590: warning: exported method Table.InitBadMetrics should have comment or be unexported (golint)
- Line 601: warning: exported method Table.InitCmd should have comment or be unexported (golint)
- Line 614: warning: exported method Table.InitBlacklist should have comment or be unexported (golint)
- Line 657: warning: exported method Table.InitAggregation should have comment or be unexported (golint)
- Line 682: warning: exported method Table.InitRewrite should have comment or be unexported (golint)
- Line 696: warning: exported method Table.InitRoutes should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/destination.go
- Line 28: warning: exported type Destination should have comment or be unexported (golint)
- Line 105: warning: exported method Destination.Match should have comment or be unexported (golint)
- Line 111: warning: comment on exported method Destination.Update should be of the form "Update ..." (golint)
- Line 162: warning: exported method Destination.UpdateMatcher should have comment or be unexported (golint)
- Line 168: warning: exported method Destination.GetMatcher should have comment or be unexported (golint)
- Line 174: warning: comment on exported method Destination.Snapshot should be of the form "Snapshot ..." (golint)
- Line 187: warning: exported method Destination.Run should have comment or be unexported (golint)
- Line 215: warning: exported method Destination.Flush should have comment or be unexported (golint)
- Line 220: warning: exported method Destination.Shutdown should have comment or be unexported (golint)
- Line 257: warning: exported method Destination.WaitOnline should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/pickle.go
- Line 11: warning: exported function Pickle should have comment or be unexported (golint)
-
-
carbon-relay-ng/route/consistent_hashing.go
- Line 37: warning: exported type ConsistentHasher should have comment or be unexported (golint)
- Line 51: warning: exported function NewConsistentHasher should have comment or be unexported (golint)
- Line 55: warning: exported function NewConsistentHasherReplicaCount should have comment or be unexported (golint)
- Line 63: warning: exported method ConsistentHasher.AddDestination should have comment or be unexported (golint)
-
-
carbon-relay-ng/route/scram.go
- Line 10: warning: exported var SHA256 should have comment or be unexported (golint)
- Line 11: warning: exported var SHA512 should have comment or be unexported (golint)
- Line 13: warning: exported type XDGSCRAMClient should have comment or be unexported (golint)
- Line 19: warning: exported method XDGSCRAMClient.Begin should have comment or be unexported (golint)
- Line 28: warning: exported method XDGSCRAMClient.Step should have comment or be unexported (golint)
- Line 33: warning: exported method XDGSCRAMClient.Done should have comment or be unexported (golint)
-
-
carbon-relay-ng/telnet/telnet.go
- Line 20: warning: exported type Req should have comment or be unexported (golint)
- Line 29: warning: exported function HandleFunc should have comment or be unexported (golint)
- Line 41: warning: exported function ListenAndServe should have comment or be unexported (golint)
- Line 73: warning: don't use underscores in Go names; var clean_cmd should be cleanCmd (golint)
-
-
carbon-relay-ng/destination/keepsafe.go
- Line 22: warning: exported function NewKeepSafe should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/spool.go
- Line 12: warning: comment on exported type Spool should be of the form "Spool ..." (with optional leading article) (golint)
- Line 37: warning: comment on exported function NewSpool should be of the form "NewSpool ..." (golint)
- Line 68: warning: comment on exported method Spool.Writer should be of the form "Writer ..." (golint)
- Line 104: warning: exported method Spool.Ingest should have comment or be unexported (golint)
- Line 110: warning: exported method Spool.Buffer should have comment or be unexported (golint)
- Line 125: warning: exported method Spool.Close should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/counter32.go
- Line 8: warning: exported type Counter32 should have comment or be unexported (golint)
- Line 12: warning: exported function NewCounter32 should have comment or be unexported (golint)
- Line 16: warning: exported method Counter32.SetUint32 should have comment or be unexported (golint)
- Line 20: warning: exported method Counter32.Inc should have comment or be unexported (golint)
- Line 24: warning: exported method Counter32.Add should have comment or be unexported (golint)
- Line 28: warning: exported method Counter32.AddUint32 should have comment or be unexported (golint)
- Line 32: warning: exported method Counter32.Peek should have comment or be unexported (golint)
- Line 36: warning: exported method Counter32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/util/util.go
- Line 5: warning: comment on exported function AddrToPath should be of the form "AddrToPath ..." (golint)
- Line 13: warning: comment on exported function Key should be of the form "Key ..." (golint)
-
-
carbon-relay-ng/ui/telnet/telnet.go
- Line 42: warning: don't use underscores in Go names; func parameter write_first should be writeFirst (golint)
- Line 117: warning: exported function Start should have comment or be unexported (golint)
-
-
carbon-relay-ng/validate/validate.go
- Line 9: warning: exported type LevelLegacy should have comment or be unexported (golint)
- Line 13: warning: exported method LevelLegacy.MarshalJSON should have comment or be unexported (golint)
- Line 17: warning: exported method LevelLegacy.UnmarshalText should have comment or be unexported (golint)
- Line 17: warning: receiver name l should be consistent with previous receiver name m for LevelLegacy (golint)
- Line 32: warning: exported type LevelM20 should have comment or be unexported (golint)
- Line 36: warning: exported method LevelM20.MarshalJSON should have comment or be unexported (golint)
- Line 40: warning: exported method LevelM20.UnmarshalText should have comment or be unexported (golint)
- Line 40: warning: receiver name l should be consistent with previous receiver name m for LevelM20 (golint)
-
-
carbon-relay-ng/statsmt/counterrate32.go
- Line 15: warning: exported function NewCounterRate32 should have comment or be unexported (golint)
- Line 22: warning: exported method CounterRate32.SetUint32 should have comment or be unexported (golint)
- Line 26: warning: exported method CounterRate32.Inc should have comment or be unexported (golint)
- Line 30: warning: exported method CounterRate32.Add should have comment or be unexported (golint)
- Line 34: warning: exported method CounterRate32.AddUint32 should have comment or be unexported (golint)
- Line 38: warning: exported method CounterRate32.Peek should have comment or be unexported (golint)
- Line 42: warning: exported method CounterRate32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/nsqd/message.go
- Line 11: warning: exported const MsgIDLength should have comment or be unexported (golint)
- Line 13: warning: exported type MessageID should have comment or be unexported (golint)
- Line 15: warning: exported type Message should have comment or be unexported (golint)
- Line 28: warning: exported function NewMessage should have comment or be unexported (golint)
- Line 36: warning: exported method Message.WriteTo should have comment or be unexported (golint)
-
-
carbon-relay-ng/input/init.go
- Line 5: warning: exported type Plugin should have comment or be unexported (golint)
- Line 20: warning: exported type Dispatcher should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/latencyhistogram12h32.go
- Line 9: warning: comment on exported type LatencyHistogram12h32 should be of the form "LatencyHistogram12h32 ..." (with optional leading article) (golint)
- Line 15: warning: exported function NewLatencyHistogram12h32 should have comment or be unexported (golint)
- Line 23: warning: exported method LatencyHistogram12h32.Value should have comment or be unexported (golint)
- Line 27: warning: exported method LatencyHistogram12h32.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/route/route.go
- Line 14: warning: exported type Config should have comment or be unexported (golint)
- Line 37: warning: exported type Route should have comment or be unexported (golint)
- Line 50: warning: exported type Snapshot should have comment or be unexported (golint)
- Line 65: warning: exported type SendAllMatch should have comment or be unexported (golint)
- Line 69: warning: exported type SendFirstMatch should have comment or be unexported (golint)
- Line 73: warning: exported type ConsistentHashing should have comment or be unexported (golint)
- Line 95: warning: exported function NewConsistentHashing should have comment or be unexported (golint)
- Line 111: warning: exported method SendAllMatch.Dispatch should have comment or be unexported (golint)
- Line 123: warning: exported method SendFirstMatch.Dispatch should have comment or be unexported (golint)
- Line 136: warning: exported method ConsistentHashing.Dispatch should have comment or be unexported (golint)
- Line 202: warning: exported method SendAllMatch.Snapshot should have comment or be unexported (golint)
- Line 206: warning: exported method SendFirstMatch.Snapshot should have comment or be unexported (golint)
- Line 210: warning: exported method ConsistentHashing.Snapshot should have comment or be unexported (golint)
- Line 263: warning: exported method ConsistentHashing.Add should have comment or be unexported (golint)
- Line 285: warning: exported method ConsistentHashing.DelDestination should have comment or be unexported (golint)
- Line 351: warning: exported method ConsistentHashing.Update should have comment or be unexported (golint)
- Line 375: warning: exported method ConsistentHashing.UpdateDestination should have comment or be unexported (golint)
- Line 391: warning: exported method ConsistentHashing.UpdateMatcher should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/kafka.go
- Line 8: warning: exported function NewKafka should have comment or be unexported (golint)
- Line 23: warning: exported function NewKafkaPartition should have comment or be unexported (golint)
-
-
carbon-relay-ng/route/kafkamdm.go
- Line 23: warning: exported type KafkaMdm should have comment or be unexported (golint)
- Line 274: warning: exported method KafkaMdm.Dispatch should have comment or be unexported (golint)
- Line 279: warning: exported method KafkaMdm.Flush should have comment or be unexported (golint)
- Line 285: warning: exported method KafkaMdm.Shutdown should have comment or be unexported (golint)
- Line 291: warning: exported method KafkaMdm.Snapshot should have comment or be unexported (golint)
-
-
carbon-relay-ng/persister/init.go
- Line 1: warning: package comment should be of the form "Package persister ..." (golint)
-
-
carbon-relay-ng/aggregator/processor.go
- Line 20: warning: exported function NewAvg should have comment or be unexported (golint)
- Line 27: warning: exported method Avg.Add should have comment or be unexported (golint)
- Line 32: warning: exported method Avg.Flush should have comment or be unexported (golint)
- Line 43: warning: exported function NewCount should have comment or be unexported (golint)
- Line 49: warning: exported method Count.Add should have comment or be unexported (golint)
- Line 53: warning: exported method Count.Flush should have comment or be unexported (golint)
- Line 65: warning: exported function NewDelta should have comment or be unexported (golint)
- Line 72: warning: exported method Delta.Add should have comment or be unexported (golint)
- Line 81: warning: exported method Delta.Flush should have comment or be unexported (golint)
- Line 95: warning: exported function NewDerive should have comment or be unexported (golint)
- Line 104: warning: exported method Derive.Add should have comment or be unexported (golint)
- Line 115: warning: exported method Derive.Flush should have comment or be unexported (golint)
- Line 129: warning: exported function NewLast should have comment or be unexported (golint)
- Line 135: warning: exported method Last.Add should have comment or be unexported (golint)
- Line 139: warning: exported method Last.Flush should have comment or be unexported (golint)
- Line 150: warning: exported function NewMax should have comment or be unexported (golint)
- Line 156: warning: exported method Max.Add should have comment or be unexported (golint)
- Line 162: warning: exported method Max.Flush should have comment or be unexported (golint)
- Line 173: warning: exported function NewMin should have comment or be unexported (golint)
- Line 179: warning: exported method Min.Add should have comment or be unexported (golint)
- Line 185: warning: exported method Min.Flush should have comment or be unexported (golint)
- Line 197: warning: exported function NewStdev should have comment or be unexported (golint)
- Line 204: warning: exported method Stdev.Add should have comment or be unexported (golint)
- Line 209: warning: exported method Stdev.Flush should have comment or be unexported (golint)
- Line 231: warning: exported function NewPercentiles should have comment or be unexported (golint)
- Line 245: warning: exported method Percentiles.Add should have comment or be unexported (golint)
- Line 249: warning: comment on exported method Percentiles.Flush should be of the form "Flush ..." (golint)
- Line 287: warning: exported function NewSum should have comment or be unexported (golint)
- Line 293: warning: exported method Sum.Add should have comment or be unexported (golint)
- Line 297: warning: exported method Sum.Flush should have comment or be unexported (golint)
- Line 303: warning: exported type Processor should have comment or be unexported (golint)
- Line 312: warning: exported function GetProcessorConstructor should have comment or be unexported (golint)
-
-
carbon-relay-ng/destination/bufwriter.go
- Line 1: warning: package comment should be of the form "Package destination ..." (golint)
- Line 33: warning: comment on exported function NewWriter should be of the form "NewWriter ..." (golint)
-
-
carbon-relay-ng/input/amqp.go
- Line 39: warning: exported function NewAMQP should have comment or be unexported (golint)
- Line 58: warning: exported method Amqp.Name should have comment or be unexported (golint)
- Line 62: warning: exported method Amqp.Start should have comment or be unexported (golint)
- Line 108: warning: exported method Amqp.Stop should have comment or be unexported (golint)
-
-
carbon-relay-ng/matcher/matcher.go
- Line 9: warning: exported type Matcher should have comment or be unexported (golint)
- Line 22: warning: exported function New should have comment or be unexported (golint)
-
-
carbon-relay-ng/cmd/carbon-relay-ng/carbon-relay-ng.go
- Line 39: warning: don't use underscores in Go names; var config_file should be configFile (golint)
- Line 41: warning: don't use underscores in Go names; var to_dispatch should be toDispatch (golint)
- Line 50: warning: exported var Version should have comment or be unexported (golint)
- Line 62: warning: don't use underscores in Go names; func parameter config_file should be configFile (golint)
- Line 107: warning: don't use underscores in Go names; var config_str should be configStr (golint)
-
-
carbon-relay-ng/route/grafananet_response.go
- Line 3: warning: exported type MetricsResponse should have comment or be unexported (golint)
- Line 9: warning: exported type ValidationError should have comment or be unexported (golint)
-
-
carbon-relay-ng/cmd/carbon-relay-ng/testEndpoint_test.go
- Line 313: warning: don't use underscores in Go names; var buf_copy should be bufCopy (golint)
-
-
carbon-relay-ng/util/limiter.go
- Line 15: warning: exported method Limiter.Add should have comment or be unexported (golint)
- Line 19: warning: exported method Limiter.Done should have comment or be unexported (golint)
-
-
carbon-relay-ng/input/listen.go
- Line 41: warning: exported method Listener.Start should have comment or be unexported (golint)
- Line 173: warning: don't use underscores in Go names; var udp_addr should be udpAddr (golint)
- Line 216: warning: exported method Listener.Name should have comment or be unexported (golint)
- Line 220: warning: exported method Listener.Stop should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/bool.go
- Line 8: warning: exported type Bool should have comment or be unexported (golint)
- Line 12: warning: exported function NewBool should have comment or be unexported (golint)
- Line 16: warning: exported method Bool.SetTrue should have comment or be unexported (golint)
- Line 20: warning: exported method Bool.SetFalse should have comment or be unexported (golint)
- Line 24: warning: exported method Bool.Set should have comment or be unexported (golint)
- Line 32: warning: exported method Bool.Peek should have comment or be unexported (golint)
- Line 39: warning: exported method Bool.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/process_reporter.go
- Line 16: warning: exported function NewProcessReporter should have comment or be unexported (golint)
- Line 37: warning: exported method ProcessReporter.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/go-whisper/whisper.go
- Line 1: warning: package comment should be of the form "Package whisper ..." (golint)
- Line 14: warning: exported const PointSize should have comment (or a comment on this block) or be unexported (golint)
- Line 61: warning: comment on exported function ParseRetentionDef should be of the form "ParseRetentionDef ..." (golint)
- Line 89: warning: exported function ParseRetentionDefs should have comment or be unexported (golint)
- Line 130: warning: comment on exported type Retention should be of the form "Retention ..." (with optional leading article) (golint)
- Line 141: warning: exported method Retention.MaxRetention should have comment or be unexported (golint)
- Line 145: warning: exported method Retention.Size should have comment or be unexported (golint)
- Line 149: warning: exported method Retention.SecondsPerPoint should have comment or be unexported (golint)
- Line 153: warning: exported method Retention.NumberOfPoints should have comment or be unexported (golint)
- Line 157: warning: exported function NewRetention should have comment or be unexported (golint)
- Line 164: warning: exported type Retentions should have comment or be unexported (golint)
- Line 166: warning: exported method Retentions.Len should have comment or be unexported (golint)
- Line 170: warning: exported method Retentions.Swap should have comment or be unexported (golint)
-
-
carbon-relay-ng/aggregator/init.go
- Line 20: warning: exported function InitMetrics should have comment or be unexported (golint)
- Line 25: warning: exported type RangeTracker should have comment or be unexported (golint)
- Line 33: warning: exported function NewRangeTracker should have comment or be unexported (golint)
- Line 43: warning: exported method RangeTracker.Run should have comment or be unexported (golint)
- Line 63: warning: exported method RangeTracker.Sample should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/registry.go
- Line 21: warning: exported function NewRegistry should have comment or be unexported (golint)
- Line 27: warning: exported method Registry.GetOrAdd should have comment or be unexported (golint)
- Line 41: warning: exported method Registry.List should have comment or be unexported (golint)
- Line 51: warning: exported method Registry.Clear should have comment or be unexported (golint)
-
-
carbon-relay-ng/badmetrics/badMetrics.go
- Line 8: warning: exported type BadMetrics should have comment or be unexported (golint)
- Line 16: warning: exported type Record should have comment or be unexported (golint)
- Line 31: warning: comment on exported function New should be of the form "New ..." (golint)
- Line 46: warning: exported method BadMetrics.Get should have comment or be unexported (golint)
- Line 53: warning: exported method BadMetrics.Add should have comment or be unexported (golint)
-
-
carbon-relay-ng/aggregator/aggregator_reporter.go
- Line 24: warning: exported function NewAggregatorReporter should have comment or be unexported (golint)
- Line 39: warning: exported method AggregatorReporter.ReportGraphite should have comment or be unexported (golint)
-
-
carbon-relay-ng/imperatives/imperatives.go
- Line 182: warning: exported type Table should have comment or be unexported (golint)
- Line 194: warning: exported function Apply should have comment or be unexported (golint)
- Line 1301: warning: exported function ParseDestinations should have comment or be unexported (golint)
-
-
carbon-relay-ng/statsmt/range32.go
- Line 21: warning: exported function NewRange32 should have comment or be unexported (golint)
- Line 28: warning: exported method Range32.Value should have comment or be unexported (golint)
- Line 32: warning: exported method Range32.ValueUint32 should have comment or be unexported (golint)
- Line 44: warning: exported method Range32.ReportGraphite should have comment or be unexported (golint)
ineffassign98%
IneffAssign detects ineffectual assignments in Go code.
-
-
carbon-relay-ng/input/listen_test.go
- Line 82: warning: ineffectual assignment to err (ineffassign)
- Line 121: warning: ineffectual assignment to err (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
carbon-relay-ng/input/manager/manager.go
- Line 10: warning: "successfull" is a misspelling of "successful" (misspell)
-
-
carbon-relay-ng/matcher/matcher.go
- Line 98: warning: "criterias" is a misspelling of "criteria" (misspell)