Report for github.com/grokify/gophonenumbers
A+ Excellent! Found 16 issues across 19 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint15%
Golint is a linter for Go source code.
-
-
gophonenumbers/number_lookup.go
- Line 13: warning: exported type Source should have comment or be unexported (golint)
- Line 16: warning: exported const Ekata should have comment (or a comment on this block) or be unexported (golint)
- Line 21: warning: exported type NumberLookup should have comment or be unexported (golint)
- Line 31: warning: exported type Carrier should have comment or be unexported (golint)
- Line 39: warning: exported function NewNumberLookupNumverify should have comment or be unexported (golint)
- Line 57: warning: exported function NewNumberLookupTwilio should have comment or be unexported (golint)
- Line 70: warning: exported function TwilioCarrierToCommon should have comment or be unexported (golint)
- Line 78: warning: exported function SortLookupsDesc should have comment or be unexported (golint)
-
-
gophonenumbers/set.go
- Line 13: warning: exported type NumbersSet should have comment or be unexported (golint)
- Line 17: warning: exported function NewNumbersSet should have comment or be unexported (golint)
- Line 21: warning: exported method NumbersSet.AddNumber should have comment or be unexported (golint)
- Line 34: warning: exported method NumbersSet.AddLookup should have comment or be unexported (golint)
- Line 49: warning: exported method NumbersSet.Inflate should have comment or be unexported (golint)
- Line 62: warning: exported method NumbersSet.AreaCodes should have comment or be unexported (golint)
- Line 66: warning: exported function NumbersSetAreaCodesNANP should have comment or be unexported (golint)
- Line 81: warning: exported function NumbersSetNumbersE164 should have comment or be unexported (golint)
-
-
gophonenumbers/set_export.go
- Line 11: warning: exported function NumbersSetToTable should have comment or be unexported (golint)
-
-
gophonenumbers/twilio/client.go
- Line 17: warning: exported const LookupEndpoint should have comment (or a comment on this block) or be unexported (golint)
- Line 21: warning: exported var EnvTwilioAccountSid should have comment or be unexported (golint)
- Line 25: warning: exported type Client should have comment or be unexported (golint)
- Line 31: warning: exported function NewClient should have comment or be unexported (golint)
- Line 47: warning: exported method Params.Encode should have comment or be unexported (golint)
- Line 63: warning: exported method Client.Validate should have comment or be unexported (golint)
- Line 95: warning: exported type NumberInfo should have comment or be unexported (golint)
- Line 105: warning: exported type Carrier should have comment or be unexported (golint)
-
-
gophonenumbers/twilio/examples/get_one/main.go
- Line 16: warning: exported type Options should have comment or be unexported (golint)
-
-
gophonenumbers/areacode.go
- Line 7: warning: comment on exported function ParseAreaCodeString should be of the form "ParseAreaCodeString ..." (golint)
-
-
gophonenumbers/number_components.go
- Line 12: warning: exported type Components should have comment or be unexported (golint)
- Line 22: warning: exported function ParseE164 should have comment or be unexported (golint)
-
-
gophonenumbers/numverify/client.go
- Line 16: warning: exported const CountriesEndpoint should have comment (or a comment on this block) or be unexported (golint)
- Line 20: warning: exported var EnvNumverifyAccessKey should have comment or be unexported (golint)
- Line 22: warning: exported type Client should have comment or be unexported (golint)
- Line 26: warning: exported function NewClient should have comment or be unexported (golint)
- Line 30: warning: comment on exported method Client.Validate should be of the form "Validate ..." (golint)
- Line 106: warning: exported method Params.MapStringSlice should have comment or be unexported (golint)
- Line 115: warning: exported type ResponseSuccess should have comment or be unexported (golint)
- Line 128: warning: exported type ResponseError should have comment or be unexported (golint)
- Line 133: warning: exported type Error should have comment or be unexported (golint)
- Line 139: warning: exported type Country should have comment or be unexported (golint)
- Line 144: warning: exported type Response should have comment or be unexported (golint)
-
-
gophonenumbers/apps/parsenumber/main.go
- Line 13: warning: exported const ExampleBadNumber should have comment or be unexported (golint)
- Line 15: warning: exported type Options should have comment or be unexported (golint)
-
-
gophonenumbers/phonenumber.go
- Line 10: warning: exported type PhoneNumber should have comment or be unexported (golint)
- Line 14: warning: exported method PhoneNumber.GetRegionCode should have comment or be unexported (golint)
- Line 18: warning: exported method PhoneNumber.GetCountryCode should have comment or be unexported (golint)
- Line 22: warning: exported method PhoneNumber.GetNumberE164 should have comment or be unexported (golint)
- Line 26: warning: exported method PhoneNumber.GetNumberE164Uint should have comment or be unexported (golint)
- Line 39: warning: exported method PhoneNumber.GetAreaCode should have comment or be unexported (golint)
- Line 47: warning: exported method PhoneNumber.GetAreaCodeString should have comment or be unexported (golint)
- Line 59: warning: exported method PhoneNumber.Meta should have comment or be unexported (golint)
-
-
gophonenumbers/tofrom_numbers.go
- Line 9: warning: exported type Direction should have comment or be unexported (golint)
- Line 12: warning: exported const To should have comment (or a comment on this block) or be unexported (golint)
- Line 16: warning: exported type ToFromNumbersSets should have comment or be unexported (golint)
- Line 21: warning: exported type ToFromNumbersSetsStats should have comment or be unexported (golint)
- Line 28: warning: exported function NewToFromNumbersSets should have comment or be unexported (golint)
- Line 33: warning: exported type ToFromNumbersSet should have comment or be unexported (golint)
- Line 38: warning: exported function NewToFromNumbersSet should have comment or be unexported (golint)
- Line 44: warning: exported method ToFromNumbersSet.AddNumber should have comment or be unexported (golint)
- Line 51: warning: exported method ToFromNumbersSets.AddNumber should have comment or be unexported (golint)
- Line 86: warning: exported method ToFromNumbersSets.Stats should have comment or be unexported (golint)
-
-
gophonenumbers/common/common.go
- Line 8: warning: exported function BuildFilename should have comment or be unexported (golint)
-
-
gophonenumbers/number.go
- Line 12: warning: exported const CarrierATT should have comment (or a comment on this block) or be unexported (golint)
- Line 18: warning: exported type LineType should have comment or be unexported (golint)
- Line 21: warning: exported const LineLocal should have comment (or a comment on this block) or be unexported (golint)
- Line 26: warning: exported type NumberInfo should have comment or be unexported (golint)
- Line 35: warning: exported function NewNumberInfo should have comment or be unexported (golint)
- Line 42: warning: exported method NumberInfo.Inflate should have comment or be unexported (golint)
- Line 110: warning: exported method NumberInfo.InflateComponents should have comment or be unexported (golint)
- Line 114: warning: exported function E164Atoi should have comment or be unexported (golint)
-
-
gophonenumbers/twilio/set.go
- Line 19: warning: exported var MultiLimit should have comment or be unexported (golint)
- Line 28: warning: exported function NewMultiResults should have comment or be unexported (golint)
- Line 34: warning: exported method MultiResults.Inflate should have comment or be unexported (golint)
- Line 47: warning: exported method MultiResults.AddResponses should have comment or be unexported (golint)
- Line 57: warning: exported method MultiResults.GetNumberInfo should have comment or be unexported (golint)
- Line 65: warning: exported method MultiResults.NumbersSuccess should have comment or be unexported (golint)
- Line 85: warning: exported function GetWriteValidationMulti should have comment or be unexported (golint)
- Line 136: warning: exported function NewMultiResultsFiles should have comment or be unexported (golint)
-
-
gophonenumbers/read_files.go
- Line 10: warning: exported function ReadLookupsNumverify should have comment or be unexported (golint)
- Line 38: warning: exported function ReadLookupsTwilio should have comment or be unexported (golint)
-
-
gophonenumbers/numverify/set.go
- Line 19: warning: exported var MultiLimit should have comment or be unexported (golint)
- Line 27: warning: exported function NewMultiResults should have comment or be unexported (golint)
- Line 33: warning: exported method MultiResults.Inflate should have comment or be unexported (golint)
- Line 46: warning: exported method MultiResults.AddResponses should have comment or be unexported (golint)
- Line 56: warning: exported method MultiResults.NumbersSuccess should have comment or be unexported (golint)
- Line 78: warning: exported function GetWriteValidationMulti should have comment or be unexported (golint)
- Line 131: warning: exported function ReadFilesMultiResults should have comment or be unexported (golint)
- Line 164: warning: exported function GetNumbers should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!