Report for github.com/hadyn/coffee
A Great! Found 11 issues across 21 files
gofmt85%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
coffee/cli/coffee/sprite.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
coffee/jagex/sprite/sprite.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
coffee/jagex/sprite/sprite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo95%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
coffee/jagex/file_index.go
- Line 40: warning: cyclomatic complexity 20 of function DecodeFileIndex() is high (> 15) (gocyclo)
golint61%
Golint is a linter for Go source code.
-
-
coffee/jagex/sprite/sprite.go
- Line 11: warning: exported const TransparentPixel should have comment (or a comment on this block) or be unexported (golint)
- Line 14: warning: exported type PixelEncoding should have comment or be unexported (golint)
- Line 17: warning: exported const HorizontalEncoding should have comment (or a comment on this block) or be unexported (golint)
- Line 21: warning: exported type Sprite should have comment or be unexported (golint)
- Line 32: warning: exported method Sprite.ToImage should have comment or be unexported (golint)
- Line 59: warning: exported type Group should have comment or be unexported (golint)
- Line 70: warning: exported function DecodeGroup should have comment or be unexported (golint)
- Line 143: warning: exported method Group.Get should have comment or be unexported (golint)
-
-
coffee/cli/coffee/root.go
- Line 18: warning: exported function Execute should have comment or be unexported (golint)
-
-
coffee/jagex/buffer.go
- Line 12: warning: exported method ReadBuffer.GetUint8 should have comment or be unexported (golint)
- Line 19: warning: exported method ReadBuffer.GetUint8AsInt should have comment or be unexported (golint)
- Line 23: warning: exported method ReadBuffer.GetUint16 should have comment or be unexported (golint)
- Line 30: warning: exported method ReadBuffer.GetUint16AsInt should have comment or be unexported (golint)
- Line 34: warning: exported method ReadBuffer.GetUint24 should have comment or be unexported (golint)
- Line 41: warning: exported method ReadBuffer.GetUint24AsInt should have comment or be unexported (golint)
- Line 45: warning: exported method ReadBuffer.GetUint32 should have comment or be unexported (golint)
- Line 52: warning: exported method ReadBuffer.GetUint32AsInt should have comment or be unexported (golint)
- Line 56: warning: exported method ReadBuffer.GetUint64 should have comment or be unexported (golint)
- Line 88: warning: comment on exported method ReadBuffer.Copy should be of the form "Copy ..." (golint)
-
-
coffee/jagex/file_archive.go
- Line 17: warning: exported type ArchiveCompression should have comment or be unexported (golint)
- Line 20: warning: exported const ArchiveCompressionNone should have comment (or a comment on this block) or be unexported (golint)
- Line 25: warning: exported method ArchiveCompression.Check should have comment or be unexported (golint)
- Line 34: warning: exported method ArchiveCompression.HeaderLength should have comment or be unexported (golint)
- Line 45: warning: exported method ArchiveCompression.AsByte should have comment or be unexported (golint)
- Line 47: warning: exported function DecompressFileArchive should have comment or be unexported (golint)
- Line 101: warning: exported function DecryptFileArchive should have comment or be unexported (golint)
- Line 122: warning: exported function FileArchiveLength should have comment or be unexported (golint)
-
-
coffee/jagex/file_cache.go
- Line 16: warning: exported type CacheReader should have comment or be unexported (golint)
- Line 23: warning: exported function NewCacheReader should have comment or be unexported (golint)
-
-
coffee/jagex/file_group.go
- Line 3: warning: exported type MultipartFile should have comment or be unexported (golint)
- Line 7: warning: exported method MultipartFile.Collapse should have comment or be unexported (golint)
- Line 20: warning: exported method MultipartFile.CollapsedLength should have comment or be unexported (golint)
- Line 27: warning: exported function DecodeFileGroup should have comment or be unexported (golint)
-
-
coffee/jagex/file_index.go
- Line 8: warning: exported type FileIndexFlags should have comment or be unexported (golint)
- Line 11: warning: exported const IndexFlagNamed should have comment (or a comment on this block) or be unexported (golint)
- Line 19: warning: exported type FileIndex should have comment or be unexported (golint)
- Line 24: warning: exported type FileGroupEntry should have comment or be unexported (golint)
- Line 31: warning: exported type FileEntry should have comment or be unexported (golint)
- Line 35: warning: exported type NamedEntryIndex should have comment or be unexported (golint)
- Line 40: warning: exported function DecodeFileIndex should have comment or be unexported (golint)
- Line 144: warning: exported method FileIndex.Size should have comment or be unexported (golint)
- Line 154: warning: exported method FileIndex.FindGroupID should have comment or be unexported (golint)
- Line 175: warning: exported method FileIndex.FindGroup should have comment or be unexported (golint)
- Line 183: warning: exported method FileIndex.FindFileID should have comment or be unexported (golint)
- Line 193: warning: exported method FileIndex.NamedIndex should have comment or be unexported (golint)
- Line 222: warning: exported method FileGroupEntry.FileIDs should have comment or be unexported (golint)
- Line 230: warning: exported method FileGroupEntry.Size should have comment or be unexported (golint)
- Line 240: warning: exported method FileGroupEntry.FindFileID should have comment or be unexported (golint)
- Line 257: warning: exported method NamedEntryIndex.LookupGroupID should have comment or be unexported (golint)
- Line 262: warning: exported method NamedEntryIndex.LookupFileID should have comment or be unexported (golint)
-
-
coffee/jagex/dbj2/dbj2.go
- Line 9: warning: exported function New should have comment or be unexported (golint)
- Line 14: warning: exported function Sum should have comment or be unexported (golint)
ineffassign95%
IneffAssign detects ineffectual assignments in Go code.
-
-
coffee/cli/coffee/index.go
- Line 52: warning: ineffectual assignment to err (ineffassign)