gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo77%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• hcbridge/cmd/controller/main.go
  • Line 152: warning: cyclomatic complexity 22 of function CreateIPPool() is high (> 15) (gocyclo)

• hcbridge/pkg/types/hcpool.go
  • Line 27: warning: cyclomatic complexity 23 of function (*NSIPPool).Canonicalize() is high (> 15) (gocyclo)

• hcbridge/pkg/utils/network_linux.go
  • Line 67: warning: cyclomatic complexity 28 of function DoNetworking() is high (> 15) (gocyclo)

• hcbridge/cmd/cni/bridge/bridge.go
  • Line 382: warning: cyclomatic complexity 42 of function cmdAdd() is high (> 15) (gocyclo)
  • Line 753: warning: cyclomatic complexity 26 of function cmdCheck() is high (> 15) (gocyclo)

• hcbridge/cmd/cni/macvlan/macvlan.go
  • Line 149: warning: cyclomatic complexity 17 of function cmdAdd() is high (> 15) (gocyclo)

• hcbridge/pkg/allocator/allocator.go
  • Line 161: warning: cyclomatic complexity 20 of function (*IPAllocator).getServiceSpecIP() is high (> 15) (gocyclo)

golint62%

Golint is a linter for Go source code.

• hcbridge/cmd/ha/garp.go
  • Line 33: warning: exported function GetNotifyArp should have comment or be unexported (golint)
  • Line 62: warning: exported type NetlinkListener should have comment or be unexported (golint)
  • Line 67: warning: exported function ListenNetlink should have comment or be unexported (golint)
  • Line 95: warning: exported method NetlinkListener.ReadMsgs should have comment or be unexported (golint)
  • Line 115: warning: exported function PrintLinkMsg should have comment or be unexported (golint)

• hcbridge/cmd/cni/macvlan/macvlan.go
  • Line 42: warning: exported const IPv4InterfaceArpProxySysctlTemplate should have comment (or a comment on this block) or be unexported (golint)

• hcbridge/pkg/conf/macvlanconf.go
  • Line 5: warning: exported type NetConf should have comment or be unexported (golint)

• hcbridge/pkg/vlan/vlan.go
  • Line 11: warning: exported function GetVLANLink should have comment or be unexported (golint)

• hcbridge/pkg/cniextend/cniextend.go
  • Line 13: warning: exported type VlanResult should have comment or be unexported (golint)
  • Line 18: warning: exported method VlanResult.Vlan should have comment or be unexported (golint)
  • Line 22: warning: exported method VlanResult.ConvertToResult should have comment or be unexported (golint)
  • Line 27: warning: exported method VlanResult.Print should have comment or be unexported (golint)
  • Line 36: warning: exported function ExecAdd should have comment or be unexported (golint)
  • Line 61: warning: exported function ExecPluginWithVlanResult should have comment or be unexported (golint)

• hcbridge/pkg/types/config.go
  • Line 107: warning: exported type IPAMEnvArgs should have comment or be unexported (golint)

• hcbridge/pkg/types/constant.go
  • Line 6: warning: don't use underscores in Go names; const NS_POOL_Key should be NSPOOLKey (golint)
  • Line 8: warning: don't use underscores in Go names; const NS_POOL_Key_Prefix should be NSPOOLKeyPrefix (golint)
  • Line 10: warning: don't use underscores in Go names; const Servicce_Pool_Key should be ServiccePoolKey (golint)
  • Line 12: warning: don't use underscores in Go names; const Servicce_Pool_Key_Prefix should be ServiccePoolKeyPrefix (golint)
  • Line 14: warning: don't use underscores in Go names; const Pod_Key should be PodKey (golint)
  • Line 16: warning: don't use underscores in Go names; const Pod_Key_Prefix should be PodKeyPrefix (golint)
  • Line 28: warning: don't use underscores in Go names; const Service_Key_Prefix should be ServiceKeyPrefix (golint)
  • Line 30: warning: don't use underscores in Go names; const Service_Key should be ServiceKey (golint)

• hcbridge/pkg/allocator/allocator.go
  • Line 317: warning: exported method IPAllocator.GetIPWithoutSvcPoolPolicy should have comment or be unexported (golint)
  • Line 397: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• hcbridge/pkg/utils/intf.go
  • Line 9: warning: exported function GetNodeMaster should have comment or be unexported (golint)
  • Line 24: warning: exported function GetNodeIP should have comment or be unexported (golint)

• hcbridge/pkg/utils/network_linux.go
  • Line 1: warning: package comment should be of the form "Package utils ..." (golint)
  • Line 41: warning: exported var DefaultRoutes should have comment or be unexported (golint)
  • Line 59: warning: exported function Min should have comment or be unexported (golint)
  • Line 438: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign88%

IneffAssign detects ineffectual assignments in Go code.

• hcbridge/pkg/allocator/allocator.go
  • Line 372: warning: ineffectual assignment to err (ineffassign)

• hcbridge/pkg/utils/intf.go
  • Line 37: warning: ineffectual assignment to err (ineffassign)

• hcbridge/pkg/utils/utils_test.go
  • Line 16: warning: ineffectual assignment to err (ineffassign)
  • Line 18: warning: ineffectual assignment to err (ineffassign)
  • Line 72: warning: ineffectual assignment to routerList (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!