Preparing report...

Report for github.com/hazlorlabs/hsc-core

(v0.0.0-20211119234143-eac5ff733da7)

A+    Excellent!    Found 45 issues across 198 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • hsc-core/app/export.go
    • Line 66: warning: cyclomatic complexity 17 of function (*EthermintApp).prepForZeroHeightGenesis() is high (> 15) (gocyclo)

golint79%

Golint is a linter for Go source code.

    • hsc-core/types/hdpath.go
    • Line 16: warning: exported type HDPathIterator should have comment or be unexported (golint)
    • Line 19: warning: comment on exported function NewHDPathIterator should be of the form "NewHDPathIterator ..." (golint)
    • hsc-core/rpc/ethereum/types/utils.go
    • Line 125: warning: exported type DataError should have comment or be unexported (golint)
    • Line 143: warning: exported type SDKTxLogs should have comment or be unexported (golint)
    • Line 147: warning: exported const LogRevertedFlag should have comment or be unexported (golint)
    • Line 149: warning: exported function ErrRevertedWith should have comment or be unexported (golint)
    • Line 168: warning: comment on exported function NewRPCTransaction should be of the form "NewRPCTransaction ..." (golint)
    • hsc-core/rpc/ethereum/backend/backend.go
    • Line 233: warning: exported method EVMBackend.EthBlockFromTm should have comment or be unexported (golint)
    • Line 596: warning: exported method EVMBackend.GetLogsByNumber should have comment or be unexported (golint)
    • Line 732: warning: exported method EVMBackend.SendTransaction should have comment or be unexported (golint)
    • Line 885: warning: comment on exported method EVMBackend.RPCTxFeeCap should be of the form "RPCTxFeeCap ..." (golint)
    • Line 903: warning: exported method EVMBackend.RPCMinGasPrice should have comment or be unexported (golint)
    • hsc-core/x/evm/types/utils.go
    • Line 17: warning: exported var EmptyCodeHash should have comment or be unexported (golint)
    • Line 46: warning: comment on exported function DecodeTransactionLogs should be of the form "DecodeTransactionLogs ..." (golint)
    • hsc-core/rpc/websockets.go
    • Line 35: warning: exported type WebsocketsServer should have comment or be unexported (golint)
    • Line 39: warning: exported type SubscriptionResponseJSON should have comment or be unexported (golint)
    • Line 45: warning: exported type SubscriptionNotification should have comment or be unexported (golint)
    • Line 51: warning: exported type SubscriptionResult should have comment or be unexported (golint)
    • Line 56: warning: exported type ErrorResponseJSON should have comment or be unexported (golint)
    • Line 62: warning: exported type ErrorMessageJSON should have comment or be unexported (golint)
    • Line 76: warning: exported function NewWebsocketsServer should have comment or be unexported (golint)
    • hsc-core/x/evm/module.go
    • Line 71: warning: exported method AppModuleBasic.RegisterGRPCGatewayRoutes should have comment or be unexported (golint)
    • Line 123: warning: comment on exported method AppModule.RegisterServices should be of the form "RegisterServices ..." (golint)
    • hsc-core/client/debug/debug.go
    • Line 42: warning: exported function PubkeyCmd should have comment or be unexported (golint)
    • Line 68: warning: exported function AddrCmd should have comment or be unexported (golint)
    • Line 103: warning: exported function RawBytesCmd should have comment or be unexported (golint)
    • hsc-core/testutil/network/network.go
    • Line 197: warning: exported type CLILogger should have comment or be unexported (golint)
    • Line 201: warning: exported method CLILogger.Log should have comment or be unexported (golint)
    • Line 205: warning: exported method CLILogger.Logf should have comment or be unexported (golint)
    • Line 209: warning: exported function NewCLILogger should have comment or be unexported (golint)
    • hsc-core/app/ante/eth.go
    • Line 654: warning: exported function NewEthSetUpContextDecorator should have comment or be unexported (golint)
    • Line 658: warning: exported method EthSetupContextDecorator.AnteHandle should have comment or be unexported (golint)
    • hsc-core/app/app.go
    • Line 663: warning: exported method EthermintApp.RegisterTxService should have comment or be unexported (golint)
    • Line 667: warning: exported method EthermintApp.RegisterTendermintService should have comment or be unexported (golint)
    • hsc-core/x/feemarket/types/params.go
    • Line 11: warning: exported const DefaultBaseFeeChangeDenominator should have comment (or a comment on this block) or be unexported (golint)
    • Line 83: warning: exported method Params.IsBaseFeeEnabled should have comment or be unexported (golint)
    • hsc-core/x/feemarket/module.go
    • Line 71: warning: exported method AppModuleBasic.RegisterGRPCGatewayRoutes should have comment or be unexported (golint)
    • Line 115: warning: comment on exported method AppModule.RegisterServices should be of the form "RegisterServices ..." (golint)
    • hsc-core/x/evm/types/codec.go
    • Line 12: warning: exported var ModuleCdc should have comment or be unexported (golint)
    • Line 15: warning: exported type ExtensionOptionsEthereumTxI should have comment or be unexported (golint)
    • Line 40: warning: comment on exported function PackTxData should be of the form "PackTxData ..." (golint)
    • hsc-core/tests/rpc/utils.go
    • Line 21: warning: exported type Request should have comment or be unexported (golint)
    • Line 28: warning: exported type Error should have comment or be unexported (golint)
    • Line 34: warning: exported type Response should have comment or be unexported (golint)
    • Line 40: warning: exported var HOST should have comment or be unexported (golint)
    • Line 42: warning: exported function GetAddress should have comment or be unexported (golint)
    • Line 57: warning: exported function CreateRequest should have comment or be unexported (golint)
    • Line 66: warning: exported function Call should have comment or be unexported (golint)
    • Line 97: warning: exported function CallWithError should have comment or be unexported (golint)
    • Line 137: warning: comment on exported function HexToBigInt should be of the form "HexToBigInt ..." (golint)
    • Line 145: warning: comment on exported function SendTestTransaction should be of the form "SendTestTransaction ..." (golint)
    • Line 165: warning: comment on exported function DeployTestContract should be of the form "DeployTestContract ..." (golint)
    • Line 190: warning: exported function DeployTestContractWithFunction should have comment or be unexported (golint)
    • Line 233: warning: exported function GetTransactionReceipt should have comment or be unexported (golint)
    • Line 244: warning: exported function WaitForReceipt should have comment or be unexported (golint)
    • Line 257: warning: exported function GetNonce should have comment or be unexported (golint)
    • Line 270: warning: exported function UnlockAllAccounts should have comment or be unexported (golint)
    • hsc-core/log/handler.go
    • Line 14: warning: comment on exported type Handler should be of the form "Handler ..." (with optional leading article) (golint)
    • Line 19: warning: exported function NewHandler should have comment or be unexported (golint)
    • Line 42: warning: exported function EthLogLvlToZerolog should have comment or be unexported (golint)
    • hsc-core/x/evm/types/params.go
    • Line 18: warning: exported const DefaultEVMDenom should have comment (or a comment on this block) or be unexported (golint)
    • Line 139: warning: exported function IsLondon should have comment or be unexported (golint)
    • hsc-core/version/version.go
    • Line 9: warning: exported var AppVersion should have comment or be unexported (golint)
    • Line 26: warning: exported function Version should have comment or be unexported (golint)
    • hsc-core/server/util.go
    • Line 19: warning: comment on exported function AddCommands should be of the form "AddCommands ..." (golint)
    • Line 45: warning: exported function ConnectTmWS should have comment or be unexported (golint)
    • Line 73: warning: exported function MountGRPCWebServices should have comment or be unexported (golint)
    • hsc-core/rpc/ethereum/types/block.go
    • Line 27: warning: exported const EthPendingBlockNumber should have comment (or a comment on this block) or be unexported (golint)
    • Line 33: warning: exported const BlockParamEarliest should have comment (or a comment on this block) or be unexported (golint)
    • Line 127: warning: exported method BlockNumberOrHash.UnmarshalJSON should have comment or be unexported (golint)
    • hsc-core/server/config/config.go
    • Line 31: warning: exported const DefaultGasCap should have comment (or a comment on this block) or be unexported (golint)
    • Line 38: warning: comment on exported const DefaultTxFeeCap should be of the form "DefaultTxFeeCap ..." (golint)
    • hsc-core/rpc/ethereum/namespaces/eth/api.go
    • Line 104: warning: exported method PublicAPI.QueryClient should have comment or be unexported (golint)
    • Line 108: warning: exported method PublicAPI.Ctx should have comment or be unexported (golint)
    • Line 213: warning: exported method PublicAPI.FeeHistory should have comment or be unexported (golint)
    • hsc-core/x/evm/keeper/keeper.go
    • Line 257: warning: comment on exported method Keeper.AddLogTransient should be of the form "AddLogTransient ..." (golint)
    • Line 311: warning: exported method Keeper.DeleteState should have comment or be unexported (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!