Report for github.com/hellodudu/Ultimate
A+ Excellent! Found 27 issues across 53 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint50%
Golint is a linter for Go source code.
-
-
Ultimate/internal/rpc_presure/rpc_presure.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 43: warning: exported type RPCPresure should have comment or be unexported (golint)
- Line 59: warning: exported function New should have comment or be unexported (golint)
- Line 188: warning: exported method RPCPresure.Exit should have comment or be unexported (golint)
-
-
Ultimate/utils/xml_loader.go
- Line 11: warning: exported type XmlEntityClient should have comment or be unexported (golint)
- Line 25: warning: exported type XmlLoader should have comment or be unexported (golint)
- Line 29: warning: exported function NewXmlLoader should have comment or be unexported (golint)
-
-
Ultimate/internal/utils/wait_group_wrapper.go
- Line 9: warning: exported type WaitGroupWrapper should have comment or be unexported (golint)
- Line 13: warning: exported method WaitGroupWrapper.Wrap should have comment or be unexported (golint)
-
-
Ultimate/game-service/define/net_define.go
- Line 3: warning: comment on exported type BaseNetMsg should be of the form "BaseNetMsg ..." (with optional leading article) (golint)
- Line 9: warning: comment on exported type TransferNetMsg should be of the form "TransferNetMsg ..." (with optional leading article) (golint)
-
-
Ultimate/iface/idatastore.go
- Line 7: warning: exported type IDatastore should have comment or be unexported (golint)
- Line 14: warning: comment on exported type TableGlobal should be of the form "TableGlobal ..." (with optional leading article) (golint)
-
-
Ultimate/iface/igame.go
- Line 8: warning: exported type IGameMgr should have comment or be unexported (golint)
- Line 34: warning: exported type IInvite should have comment or be unexported (golint)
-
-
Ultimate/game-service/game/game_mgr.go
- Line 30: warning: exported function NewGameMgr should have comment or be unexported (golint)
- Line 58: warning: exported method GameMgr.Invite should have comment or be unexported (golint)
- Line 62: warning: exported method GameMgr.Run should have comment or be unexported (golint)
- Line 72: warning: exported method GameMgr.GetInvite should have comment or be unexported (golint)
- Line 76: warning: exported method GameMgr.AddPlayerInfoList should have comment or be unexported (golint)
- Line 89: warning: exported method GameMgr.AddPlayerInfo should have comment or be unexported (golint)
- Line 96: warning: exported method GameMgr.AddGuildInfoList should have comment or be unexported (golint)
- Line 110: warning: exported method GameMgr.AddGuildInfo should have comment or be unexported (golint)
- Line 117: warning: exported method GameMgr.GetPlayerInfoByID should have comment or be unexported (golint)
- Line 128: warning: exported method GameMgr.GetGuildInfoByID should have comment or be unexported (golint)
- Line 139: warning: exported method GameMgr.GetArenaSeasonData should have comment or be unexported (golint)
- Line 152: warning: exported method GameMgr.GetArenaChampion should have comment or be unexported (golint)
- Line 166: warning: exported method GameMgr.GetArenaMatchingList should have comment or be unexported (golint)
- Line 179: warning: exported method GameMgr.GetArenaRecordReqList should have comment or be unexported (golint)
- Line 192: warning: exported method GameMgr.GetArenaRecord should have comment or be unexported (golint)
- Line 205: warning: exported method GameMgr.GetArenaRankList should have comment or be unexported (golint)
- Line 218: warning: exported method GameMgr.ArenaAPIRequestRank should have comment or be unexported (golint)
- Line 231: warning: exported method GameMgr.ArenaSaveChampion should have comment or be unexported (golint)
- Line 244: warning: exported method GameMgr.ArenaWeekEnd should have comment or be unexported (golint)
- Line 257: warning: exported method GameMgr.ArenaMatching should have comment or be unexported (golint)
- Line 262: warning: exported method GameMgr.ArenaAddRecord should have comment or be unexported (golint)
- Line 267: warning: exported method GameMgr.ArenaBattleResult should have comment or be unexported (golint)
- Line 272: warning: exported method GameMgr.ArenaGetRank should have comment or be unexported (golint)
- Line 282: warning: exported method GameMgr.GetArenaDataNum should have comment or be unexported (golint)
- Line 294: warning: exported method GameMgr.GetArenaRecordNum should have comment or be unexported (golint)
-
-
Ultimate/internal/rpc_presure/options.go
- Line 1: warning: don't use an underscore in package name (golint)
- Line 3: warning: exported type Options should have comment or be unexported (golint)
- Line 7: warning: exported function NewOptions should have comment or be unexported (golint)
-
-
Ultimate/utils/log/logger.go
- Line 14: warning: exported var Logger should have comment or be unexported (golint)
- Line 16: warning: exported function InitLogger should have comment or be unexported (golint)
-
-
Ultimate/game-service/db/datastore.go
- Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 15: warning: exported type Datastore should have comment or be unexported (golint)
- Line 25: warning: exported function NewDatastore should have comment or be unexported (golint)
- Line 49: warning: exported method Datastore.DB should have comment or be unexported (golint)
- Line 53: warning: exported method Datastore.TableGlobal should have comment or be unexported (golint)
- Line 57: warning: exported method Datastore.Run should have comment or be unexported (golint)
- Line 69: warning: exported method Datastore.Stop should have comment or be unexported (golint)
-
-
Ultimate/game-service/world/world.go
- Line 19: warning: exported var WrapHandlerSize should have comment or be unexported (golint)
- Line 20: warning: exported var AsyncHandlerSize should have comment or be unexported (golint)
- Line 49: warning: exported function NewWorld should have comment or be unexported (golint)
-
-
Ultimate/utils/task/task.go
- Line 5: warning: exported type TaskReqInfo should have comment or be unexported (golint)
- Line 12: warning: exported method TaskReqInfo.SetID should have comment or be unexported (golint)
- Line 16: warning: exported method TaskReqInfo.GetID should have comment or be unexported (golint)
- Line 20: warning: exported method TaskReqInfo.Call should have comment or be unexported (golint)
- Line 24: warning: exported type Tasker should have comment or be unexported (golint)
- Line 41: warning: exported function NewTask should have comment or be unexported (golint)
-
-
Ultimate/utils/global/global.go
- Line 74: warning: exported function GetIniMgr should have comment or be unexported (golint)
-
-
Ultimate/iface/iworld.go
- Line 7: warning: exported type IWorldMgr should have comment or be unexported (golint)
- Line 19: warning: exported type IWorld should have comment or be unexported (golint)
-
-
Ultimate/utils/ini.go
- Line 7: warning: exported type IniMgr should have comment or be unexported (golint)
- Line 11: warning: exported function NewIniMgr should have comment or be unexported (golint)
- Line 31: warning: comment on exported method IniMgr.GetIniValue should be of the form "GetIniValue ..." (golint)
-
-
Ultimate/arena-service/db/datastore.go
- Line 9: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 16: warning: exported type Datastore should have comment or be unexported (golint)
- Line 26: warning: exported function NewDatastore should have comment or be unexported (golint)
- Line 53: warning: exported method Datastore.DB should have comment or be unexported (golint)
- Line 57: warning: exported method Datastore.TableGlobal should have comment or be unexported (golint)
- Line 61: warning: exported method Datastore.Run should have comment or be unexported (golint)
- Line 73: warning: exported method Datastore.Stop should have comment or be unexported (golint)
-
-
Ultimate/iface/iserver.go
- Line 3: warning: exported type IMsgParser should have comment or be unexported (golint)
-
-
Ultimate/iface/itcp.go
- Line 3: warning: exported type ITCPConn should have comment or be unexported (golint)
-
-
Ultimate/game-service/world/world_mgr.go
- Line 15: warning: exported type WorldMgr should have comment or be unexported (golint)
- Line 27: warning: exported function NewWorldMgr should have comment or be unexported (golint)
- Line 40: warning: exported method WorldMgr.Stop should have comment or be unexported (golint)
- Line 52: warning: exported method WorldMgr.AddWorld should have comment or be unexported (golint)
- Line 91: warning: exported method WorldMgr.AddWorldRef should have comment or be unexported (golint)
- Line 105: warning: exported method WorldMgr.GetWorldByID should have comment or be unexported (golint)
- Line 115: warning: exported method WorldMgr.GetWorldByCon should have comment or be unexported (golint)
- Line 124: warning: exported method WorldMgr.DisconnectWorld should have comment or be unexported (golint)
- Line 142: warning: exported method WorldMgr.KickWorld should have comment or be unexported (golint)
- Line 163: warning: exported method WorldMgr.BroadCast should have comment or be unexported (golint)
- Line 174: warning: exported method WorldMgr.Run should have comment or be unexported (golint)
-
-
Ultimate/arena-service/arena/arena_handler.go
- Line 19: warning: comment on exported method RPCHandler.GetPlayerInfoByID should be of the form "GetPlayerInfoByID ..." (golint)
- Line 27: warning: comment on exported method RPCHandler.GetSeasonData should be of the form "GetSeasonData ..." (golint)
- Line 36: warning: exported method RPCHandler.GetChampion should have comment or be unexported (golint)
- Line 41: warning: exported method RPCHandler.GetRank should have comment or be unexported (golint)
- Line 46: warning: exported method RPCHandler.GetArenaDataNum should have comment or be unexported (golint)
- Line 51: warning: exported method RPCHandler.GetRecordNum should have comment or be unexported (golint)
- Line 56: warning: exported method RPCHandler.GetMatchingList should have comment or be unexported (golint)
- Line 61: warning: exported method RPCHandler.GetRecordReqList should have comment or be unexported (golint)
- Line 70: warning: exported method RPCHandler.GetRecordByID should have comment or be unexported (golint)
- Line 77: warning: exported method RPCHandler.GetRankListByPage should have comment or be unexported (golint)
- Line 86: warning: exported method RPCHandler.SaveChampion should have comment or be unexported (golint)
- Line 92: warning: exported method RPCHandler.WeekEnd should have comment or be unexported (golint)
-
-
Ultimate/iface/itask.go
- Line 3: warning: exported type TaskCallback should have comment or be unexported (golint)
- Line 5: warning: exported type IDispatcher should have comment or be unexported (golint)
- Line 10: warning: exported type ITaskReqInfo should have comment or be unexported (golint)
-
-
Ultimate/iface/iultimate.go
- Line 3: warning: exported type IUltimate should have comment or be unexported (golint)
-
-
Ultimate/utils/crc32.go
- Line 49: warning: exported function Crc32 should have comment or be unexported (golint)
-
-
Ultimate/utils/functions.go
- Line 10: warning: error var ExceptionErr should have name of the form ErrFoo (golint)
- Line 10: warning: exported var ExceptionErr should have comment or be unexported (golint)
- Line 12: warning: exported function CaptureException should have comment or be unexported (golint)
-
-
Ultimate/arena-service/arena/arena.go
- Line 136: warning: exported method Arena.GetDataByID should have comment or be unexported (golint)
- Line 202: warning: exported method Arena.WeekEndTime should have comment or be unexported (golint)
- Line 745: warning: exported method Arena.SyncArenaSeason should have comment or be unexported (golint)
- Line 960: warning: exported method Arena.APIRequestRank should have comment or be unexported (golint)
-
-
Ultimate/utils/task/worker.go
- Line 3: warning: exported type Worker should have comment or be unexported (golint)
- Line 7: warning: exported method Worker.AddWork should have comment or be unexported (golint)
- Line 11: warning: exported method Worker.Work should have comment or be unexported (golint)
ineffassign96%
IneffAssign detects ineffectual assignments in Go code.
-
-
Ultimate/apps/json_request.go
- Line 44: warning: ineffectual assignment to err (ineffassign)
- Line 94: warning: ineffectual assignment to err (ineffassign)
-
-
Ultimate/arena-service/arena/arena.go
- Line 45: warning: ineffectual assignment to def (ineffassign)