Report for github.com/helm/chart-testing
A+ Excellent! Found 11 issues across 25 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo92%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
chart-testing/pkg/config/config.go
- Line 70: warning: cyclomatic complexity 30 of function LoadConfiguration() is high (> 15) (gocyclo)
-
-
chart-testing/pkg/chart/chart.go
- Line 293: warning: cyclomatic complexity 21 of function (*Testing).processCharts() is high (> 15) (gocyclo)
- Line 429: warning: cyclomatic complexity 16 of function (*Testing).LintChart() is high (> 15) (gocyclo)
golint56%
Golint is a linter for Go source code.
-
-
chart-testing/pkg/tool/kubectl.go
- Line 16: warning: exported type Kubectl should have comment or be unexported (golint)
- Line 20: warning: exported function NewKubectl should have comment or be unexported (golint)
- Line 128: warning: exported method Kubectl.WaitForDeployments should have comment or be unexported (golint)
- Line 161: warning: exported method Kubectl.GetPodsforDeployment should have comment or be unexported (golint)
- Line 183: warning: exported method Kubectl.GetPods should have comment or be unexported (golint)
- Line 193: warning: exported method Kubectl.GetEvents should have comment or be unexported (golint)
- Line 197: warning: exported method Kubectl.DescribePod should have comment or be unexported (golint)
- Line 201: warning: exported method Kubectl.Logs should have comment or be unexported (golint)
- Line 205: warning: exported method Kubectl.GetInitContainers should have comment or be unexported (golint)
- Line 209: warning: exported method Kubectl.GetContainers should have comment or be unexported (golint)
-
-
chart-testing/pkg/config/config.go
- Line 43: warning: exported type Configuration should have comment or be unexported (golint)
- Line 70: warning: exported function LoadConfiguration should have comment or be unexported (golint)
-
-
chart-testing/pkg/chart/chart.go
- Line 229: warning: exported type Testing should have comment or be unexported (golint)
- Line 863: warning: exported method Testing.PrintEventsPodDetailsAndLogs should have comment or be unexported (golint)
-
-
chart-testing/pkg/util/util.go
- Line 37: warning: exported type Maintainer should have comment or be unexported (golint)
- Line 42: warning: exported type ChartYaml should have comment or be unexported (golint)
- Line 49: warning: exported function Flatten should have comment or be unexported (golint)
- Line 79: warning: exported function StringSliceContains should have comment or be unexported (golint)
- Line 88: warning: exported function FileExists should have comment or be unexported (golint)
- Line 105: warning: exported type DirectoryLister should have comment or be unexported (golint)
- Line 126: warning: exported type ChartUtils should have comment or be unexported (golint)
- Line 128: warning: exported method ChartUtils.LookupChartDir should have comment or be unexported (golint)
- Line 174: warning: exported function CompareVersions should have comment or be unexported (golint)
- Line 186: warning: exported function BreakingChangeAllowed should have comment or be unexported (golint)
- Line 213: warning: comment on exported function PrintDelimiterLine should be of the form "PrintDelimiterLine ..." (golint)
- Line 218: warning: exported function PrintDelimiterLineToWriter should have comment or be unexported (golint)
- Line 226: warning: exported function SanitizeName should have comment or be unexported (golint)
- Line 237: warning: exported function GetRandomPort should have comment or be unexported (golint)
-
-
chart-testing/pkg/tool/account.go
- Line 25: warning: exported type AccountValidator should have comment or be unexported (golint)
- Line 29: warning: exported method AccountValidator.Validate should have comment or be unexported (golint)
-
-
chart-testing/pkg/tool/cmdexecutor.go
- Line 10: warning: exported type ProcessExecutor should have comment or be unexported (golint)
- Line 14: warning: exported type CmdTemplateExecutor should have comment or be unexported (golint)
- Line 18: warning: exported function NewCmdTemplateExecutor should have comment or be unexported (golint)
- Line 24: warning: exported method CmdTemplateExecutor.RunCommand should have comment or be unexported (golint)
-
-
chart-testing/ct/cmd/root.go
- Line 30: warning: exported function NewRootCmd should have comment or be unexported (golint)
-
-
chart-testing/pkg/exec/exec.go
- Line 29: warning: exported type ProcessExecutor should have comment or be unexported (golint)
- Line 33: warning: exported function NewProcessExecutor should have comment or be unexported (golint)
- Line 39: warning: exported method ProcessExecutor.RunProcessAndCaptureOutput should have comment or be unexported (golint)
- Line 43: warning: exported method ProcessExecutor.RunProcessAndCaptureStdout should have comment or be unexported (golint)
- Line 47: warning: exported method ProcessExecutor.RunProcessInDirAndCaptureOutput should have comment or be unexported (golint)
- Line 62: warning: exported method ProcessExecutor.RunProcessInDirAndCaptureStdout should have comment or be unexported (golint)
- Line 77: warning: exported method ProcessExecutor.RunProcess should have comment or be unexported (golint)
- Line 113: warning: exported method ProcessExecutor.CreateProcess should have comment or be unexported (golint)
- Line 128: warning: exported method ProcessExecutor.RunWithProxy should have comment or be unexported (golint)
-
-
chart-testing/pkg/tool/git.go
- Line 25: warning: exported type Git should have comment or be unexported (golint)
- Line 29: warning: exported function NewGit should have comment or be unexported (golint)
- Line 35: warning: exported method Git.FileExistsOnBranch should have comment or be unexported (golint)
- Line 41: warning: exported method Git.AddWorktree should have comment or be unexported (golint)
- Line 45: warning: exported method Git.RemoveWorktree should have comment or be unexported (golint)
- Line 49: warning: exported method Git.Show should have comment or be unexported (golint)
- Line 54: warning: exported method Git.MergeBase should have comment or be unexported (golint)
- Line 58: warning: exported method Git.ListChangedFilesInDirs should have comment or be unexported (golint)
- Line 70: warning: exported method Git.GetUrlForRemote should have comment or be unexported (golint)
- Line 74: warning: exported method Git.ValidateRepository should have comment or be unexported (golint)
-
-
chart-testing/pkg/tool/helm.go
- Line 23: warning: exported type Helm should have comment or be unexported (golint)
- Line 28: warning: exported function NewHelm should have comment or be unexported (golint)
- Line 35: warning: exported method Helm.AddRepo should have comment or be unexported (golint)
- Line 39: warning: exported method Helm.BuildDependencies should have comment or be unexported (golint)
- Line 43: warning: exported method Helm.LintWithValues should have comment or be unexported (golint)
- Line 52: warning: exported method Helm.InstallWithValues should have comment or be unexported (golint)
- Line 66: warning: exported method Helm.Upgrade should have comment or be unexported (golint)
- Line 75: warning: exported method Helm.Test should have comment or be unexported (golint)
- Line 79: warning: exported method Helm.DeleteRelease should have comment or be unexported (golint)
- Line 86: warning: exported method Helm.Version should have comment or be unexported (golint)
-
-
chart-testing/pkg/tool/linter.go
- Line 19: warning: exported type Linter should have comment or be unexported (golint)
- Line 23: warning: exported function NewLinter should have comment or be unexported (golint)
- Line 29: warning: exported method Linter.YamlLint should have comment or be unexported (golint)
- Line 33: warning: exported method Linter.Yamale should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!