Preparing report...

Report for github.com/hillu/go-archive-zip-crypto

A+    Excellent!    Found 7 issues across 11 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


golint63%

Golint is a linter for Go source code.

    • go-archive-zip-crypto/crypto.go
    • Line 22: warning: exported type EncryptionMethod should have comment or be unexported (golint)
    • Line 25: warning: exported const StandardEncryption should have comment (or a comment on this block) or be unexported (golint)
    • go-archive-zip-crypto/reader.go
    • Line 19: warning: exported var ErrFormat should have comment or be unexported (golint)
    • Line 24: warning: exported type Reader should have comment or be unexported (golint)
    • Line 31: warning: exported type ReadCloser should have comment or be unexported (golint)
    • Line 36: warning: exported type File should have comment or be unexported (golint)
    • go-archive-zip-crypto/struct.go
    • Line 280: warning: don't use underscores in Go names; const s_IFMT should be sIFMT (golint)
    • Line 281: warning: don't use underscores in Go names; const s_IFSOCK should be sIFSOCK (golint)
    • Line 282: warning: don't use underscores in Go names; const s_IFLNK should be sIFLNK (golint)
    • Line 283: warning: don't use underscores in Go names; const s_IFREG should be sIFREG (golint)
    • Line 284: warning: don't use underscores in Go names; const s_IFBLK should be sIFBLK (golint)
    • Line 285: warning: don't use underscores in Go names; const s_IFDIR should be sIFDIR (golint)
    • Line 286: warning: don't use underscores in Go names; const s_IFCHR should be sIFCHR (golint)
    • Line 287: warning: don't use underscores in Go names; const s_IFIFO should be sIFIFO (golint)
    • Line 288: warning: don't use underscores in Go names; const s_ISUID should be sISUID (golint)
    • Line 289: warning: don't use underscores in Go names; const s_ISGID should be sISGID (golint)
    • Line 290: warning: don't use underscores in Go names; const s_ISVTX should be sISVTX (golint)
    • go-archive-zip-crypto/zipcrypto.go
    • Line 9: warning: exported type ZipCrypto should have comment or be unexported (golint)
    • Line 14: warning: exported function NewZipCrypto should have comment or be unexported (golint)
    • Line 43: warning: exported method ZipCrypto.Encrypt should have comment or be unexported (golint)
    • Line 54: warning: exported method ZipCrypto.Decrypt should have comment or be unexported (golint)
    • Line 69: warning: exported function ZipCryptoDecryptor should have comment or be unexported (golint)
    • Line 105: warning: exported function ZipCryptoEncryptor should have comment or be unexported (golint)

gocyclo63%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • go-archive-zip-crypto/reader.go
    • Line 264: warning: cyclomatic complexity 36 of function readDirectoryHeader() is high (> 15) (gocyclo)
    • Line 482: warning: cyclomatic complexity 17 of function readDirectoryEnd() is high (> 15) (gocyclo)
    • go-archive-zip-crypto/writer.go
    • Line 255: warning: cyclomatic complexity 20 of function (*Writer).CreateHeader() is high (> 15) (gocyclo)
    • Line 76: warning: cyclomatic complexity 20 of function (*Writer).Close() is high (> 15) (gocyclo)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!