Preparing report...

Report for github.com/hybridapp-io/ham-placement

A+    Excellent!    Found 11 issues across 28 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint60%

Golint is a linter for Go source code.

    • ham-placement/pkg/apis/core/v1alpha1/placementrule_types.go
    • Line 23: warning: exported type AdvisorType should have comment or be unexported (golint)
    • Line 38: warning: exported const AdvisorTypeUnknown should have comment (or a comment on this block) or be unexported (golint)
    • Line 47: warning: exported const DefaultAdvisorWeight should have comment (or a comment on this block) or be unexported (golint)
    • Line 52: warning: exported type Advisor should have comment or be unexported (golint)
    • Line 71: warning: exported type ScoredObjectReference should have comment or be unexported (golint)
    • Line 77: warning: exported type Recommendation should have comment or be unexported (golint)
    • ham-placement/pkg/controller/placementrule/decisionmaker.go
    • Line 30: warning: exported type DecisionMaker should have comment or be unexported (golint)
    • Line 35: warning: exported type DefaultDecisionMaker should have comment or be unexported (golint)
    • Line 38: warning: exported method DefaultDecisionMaker.ResetDecisionMakingProcess should have comment or be unexported (golint)
    • Line 44: warning: exported method DefaultDecisionMaker.ContinueDecisionMakingProcess should have comment or be unexported (golint)
    • ham-placement/pkg/advisor/utils/utils.go
    • Line 30: warning: exported var EmptyRecommendatation should have comment or be unexported (golint)
    • Line 35: warning: exported function GenKey should have comment or be unexported (golint)
    • Line 39: warning: exported function MakeRecommendation should have comment or be unexported (golint)
    • Line 47: warning: exported function IsSameRecommendation should have comment or be unexported (golint)
    • Line 55: warning: exported function EqualRecommendations should have comment or be unexported (golint)
    • Line 78: warning: exported function EqualDecisions should have comment or be unexported (golint)
    • Line 102: warning: exported function GetAdvisor should have comment or be unexported (golint)
    • Line 122: warning: exported function Recommended should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!