Preparing report...

Report for github.com/hyperledger-labs/firefly

A+    Excellent!    Found 135 issues across 339 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint72%

Golint is a linter for Go source code.

    • firefly/pkg/fftypes/event.go
    • Line 65: warning: exported function NewEvent should have comment or be unexported (golint)
    • Line 76: warning: exported method Event.LocalSequence should have comment or be unexported (golint)
    • firefly/internal/publicstorage/ipfs/ipfs.go
    • Line 36: warning: exported type IPFS should have comment or be unexported (golint)
    • Line 50: warning: exported method IPFS.Name should have comment or be unexported (golint)
    • Line 54: warning: exported method IPFS.Init should have comment or be unexported (golint)
    • Line 73: warning: exported method IPFS.Capabilities should have comment or be unexported (golint)
    • Line 97: warning: exported method IPFS.PublishData should have comment or be unexported (golint)
    • Line 112: warning: exported method IPFS.RetrieveData should have comment or be unexported (golint)
    • firefly/internal/wsclient/wsclient.go
    • Line 35: warning: exported type WSAuthConfig should have comment or be unexported (golint)
    • Line 40: warning: exported type WSClient should have comment or be unexported (golint)
    • Line 68: warning: exported function New should have comment or be unexported (golint)
    • firefly/pkg/fftypes/namespace.go
    • Line 49: warning: exported method Namespace.Validate should have comment or be unexported (golint)
    • Line 68: warning: exported method Namespace.Topic should have comment or be unexported (golint)
    • Line 72: warning: exported method Namespace.SetBroadcastMessage should have comment or be unexported (golint)
    • firefly/internal/batch/batch_manager.go
    • Line 38: warning: exported function NewBatchManager should have comment or be unexported (golint)
    • Line 63: warning: exported type Manager should have comment or be unexported (golint)
    • Line 88: warning: exported type DispatchHandler should have comment or be unexported (golint)
    • Line 90: warning: exported type Options should have comment or be unexported (golint)
    • firefly/test/e2e/restclient.go
    • Line 30: warning: exported function GetNamespaces should have comment or be unexported (golint)
    • Line 36: warning: exported function BroadcastDatatype should have comment or be unexported (golint)
    • Line 69: warning: exported function GetData should have comment or be unexported (golint)
    • firefly/pkg/fftypes/bytyetypes.go
    • Line 33: warning: exported function NewRandB32 should have comment or be unexported (golint)
    • Line 39: warning: exported function HashResult should have comment or be unexported (golint)
    • Line 46: warning: exported method Bytes32.MarshalText should have comment or be unexported (golint)
    • Line 52: warning: exported method Bytes32.UnmarshalText should have comment or be unexported (golint)
    • Line 59: warning: exported function ParseBytes32 should have comment or be unexported (golint)
    • Line 125: warning: exported method Bytes32.Equals should have comment or be unexported (golint)
    • firefly/pkg/fftypes/namearray.go
    • Line 32: warning: exported method FFNameArray.Value should have comment or be unexported (golint)
    • Line 39: warning: exported method FFNameArray.Scan should have comment or be unexported (golint)
    • Line 72: warning: exported method FFNameArray.Validate should have comment or be unexported (golint)
    • firefly/pkg/fftypes/timeutils.go
    • Line 43: warning: exported function Now should have comment or be unexported (golint)
    • Line 48: warning: exported function ZeroTime should have comment or be unexported (golint)
    • Line 52: warning: exported function UnixTime should have comment or be unexported (golint)
    • Line 63: warning: exported method FFTime.MarshalJSON should have comment or be unexported (golint)
    • Line 70: warning: exported function ParseString should have comment or be unexported (golint)
    • Line 87: warning: exported method FFTime.UnixNano should have comment or be unexported (golint)
    • Line 94: warning: exported method FFTime.UnmarshalText should have comment or be unexported (golint)
    • Line 173: warning: exported method FFDuration.MarshalJSON should have comment or be unexported (golint)
    • Line 177: warning: exported method FFDuration.UnmarshalJSON should have comment or be unexported (golint)
    • firefly/test/e2e/stack.go
    • Line 24: warning: exported type Stack should have comment or be unexported (golint)
    • Line 28: warning: exported type Member should have comment or be unexported (golint)
    • Line 32: warning: exported function GetMemberPort should have comment or be unexported (golint)
    • firefly/pkg/fftypes/group.go
    • Line 28: warning: exported type GroupIdentity should have comment or be unexported (golint)
    • Line 35: warning: exported type Group should have comment or be unexported (golint)
    • Line 42: warning: exported type Members should have comment or be unexported (golint)
    • Line 44: warning: exported type Member should have comment or be unexported (golint)
    • Line 49: warning: exported type MemberInput should have comment or be unexported (golint)
    • Line 54: warning: exported method GroupIdentity.Hash should have comment or be unexported (golint)
    • Line 60: warning: exported method Group.Validate should have comment or be unexported (golint)
    • Line 96: warning: exported method Group.Seal should have comment or be unexported (golint)
    • Line 100: warning: exported method Group.Topic should have comment or be unexported (golint)
    • Line 104: warning: exported method Group.SetBroadcastMessage should have comment or be unexported (golint)
    • firefly/pkg/fftypes/typestring.go
    • Line 24: warning: exported type LowerCasedType should have comment or be unexported (golint)
    • Line 30: warning: exported method LowerCasedType.Lower should have comment or be unexported (golint)
    • Line 34: warning: exported method LowerCasedType.Equals should have comment or be unexported (golint)
    • Line 38: warning: exported method LowerCasedType.Value should have comment or be unexported (golint)
    • Line 42: warning: exported method LowerCasedType.UnmarshalText should have comment or be unexported (golint)
    • firefly/internal/database/ql/ql.go
    • Line 36: warning: exported type QL should have comment or be unexported (golint)
    • Line 40: warning: exported method QL.Init should have comment or be unexported (golint)
    • Line 45: warning: exported method QL.Name should have comment or be unexported (golint)
    • Line 49: warning: exported method QL.PlaceholderFormat should have comment or be unexported (golint)
    • Line 53: warning: exported method QL.UpdateInsertForSequenceReturn should have comment or be unexported (golint)
    • Line 58: warning: exported method QL.SequenceField should have comment or be unexported (golint)
    • Line 62: warning: exported method QL.Open should have comment or be unexported (golint)
    • Line 66: warning: exported method QL.GetMigrationDriver should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/pin_sql.go
    • Line 45: warning: exported method SQLCommon.UpsertPin should have comment or be unexported (golint)
    • Line 117: warning: exported method SQLCommon.GetPins should have comment or be unexported (golint)
    • Line 145: warning: exported method SQLCommon.SetPinDispatched should have comment or be unexported (golint)
    • Line 166: warning: exported method SQLCommon.DeletePin should have comment or be unexported (golint)
    • firefly/pkg/fftypes/byteable.go
    • Line 32: warning: exported method Byteable.UnmarshalJSON should have comment or be unexported (golint)
    • Line 42: warning: exported method Byteable.MarshalJSON should have comment or be unexported (golint)
    • Line 49: warning: exported method Byteable.Hash should have comment or be unexported (golint)
    • Line 59: warning: exported method Byteable.JSONObjectOk should have comment or be unexported (golint)
    • firefly/pkg/fftypes/idutils.go
    • Line 28: warning: exported function ShortID should have comment or be unexported (golint)
    • Line 32: warning: exported function SafeHashCompare should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/data_sql.go
    • Line 49: warning: exported method SQLCommon.UpsertData should have comment or be unexported (golint)
    • Line 152: warning: exported method SQLCommon.GetDataByID should have comment or be unexported (golint)
    • Line 183: warning: exported method SQLCommon.GetData should have comment or be unexported (golint)
    • Line 209: warning: exported method SQLCommon.GetDataRefs should have comment or be unexported (golint)
    • Line 239: warning: exported method SQLCommon.UpdateData should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/group_sql.go
    • Line 44: warning: exported method SQLCommon.UpsertGroup should have comment or be unexported (golint)
    • Line 215: warning: exported method SQLCommon.GetGroupByHash should have comment or be unexported (golint)
    • Line 271: warning: exported method SQLCommon.GetGroups should have comment or be unexported (golint)
    • Line 279: warning: exported method SQLCommon.UpdateGroup should have comment or be unexported (golint)
    • Line 283: warning: exported method SQLCommon.UpdateGroups should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/nextpin_sql.go
    • Line 41: warning: exported method SQLCommon.InsertNextPin should have comment or be unexported (golint)
    • Line 108: warning: exported method SQLCommon.GetNextPinByContextAndIdentity should have comment or be unexported (golint)
    • Line 115: warning: exported method SQLCommon.GetNextPinByHash should have comment or be unexported (golint)
    • Line 121: warning: exported method SQLCommon.GetNextPins should have comment or be unexported (golint)
    • Line 149: warning: exported method SQLCommon.UpdateNextPin should have comment or be unexported (golint)
    • Line 171: warning: exported method SQLCommon.DeleteNextPin should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/organization_sql.go
    • Line 46: warning: exported method SQLCommon.UpsertOrganization should have comment or be unexported (golint)
    • Line 160: warning: exported method SQLCommon.GetOrganizationByName should have comment or be unexported (golint)
    • Line 164: warning: exported method SQLCommon.GetOrganizationByIdentity should have comment or be unexported (golint)
    • Line 168: warning: exported method SQLCommon.GetOrganizationByID should have comment or be unexported (golint)
    • Line 172: warning: exported method SQLCommon.GetOrganizations should have comment or be unexported (golint)
    • Line 198: warning: exported method SQLCommon.UpdateOrganization should have comment or be unexported (golint)
    • firefly/internal/identity/onchain/onchain.go
    • Line 27: warning: exported type OnChain should have comment or be unexported (golint)
    • Line 32: warning: exported method OnChain.Name should have comment or be unexported (golint)
    • Line 36: warning: exported method OnChain.Init should have comment or be unexported (golint)
    • Line 42: warning: exported method OnChain.Start should have comment or be unexported (golint)
    • Line 46: warning: exported method OnChain.Capabilities should have comment or be unexported (golint)
    • Line 50: warning: exported method OnChain.Resolve should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/operation_sql.go
    • Line 52: warning: exported method SQLCommon.UpsertOperation should have comment or be unexported (golint)
    • Line 140: warning: exported method SQLCommon.GetOperationByID should have comment or be unexported (golint)
    • Line 165: warning: exported method SQLCommon.GetOperations should have comment or be unexported (golint)
    • Line 190: warning: exported method SQLCommon.UpdateOperation should have comment or be unexported (golint)
    • firefly/internal/dataexchange/dxhttps/dxhttps.go
    • Line 36: warning: exported type HTTPS should have comment or be unexported (golint)
    • Line 80: warning: exported method HTTPS.Name should have comment or be unexported (golint)
    • Line 84: warning: exported method HTTPS.Init should have comment or be unexported (golint)
    • Line 102: warning: exported method HTTPS.Start should have comment or be unexported (golint)
    • Line 106: warning: exported method HTTPS.Capabilities should have comment or be unexported (golint)
    • Line 110: warning: exported method HTTPS.GetEndpointInfo should have comment or be unexported (golint)
    • Line 120: warning: exported method HTTPS.AddPeer should have comment or be unexported (golint)
    • Line 130: warning: exported method HTTPS.UploadBLOB should have comment or be unexported (golint)
    • Line 140: warning: exported method HTTPS.DownloadBLOB should have comment or be unexported (golint)
    • Line 153: warning: exported method HTTPS.SendMessage should have comment or be unexported (golint)
    • Line 168: warning: exported method HTTPS.TransferBLOB should have comment or be unexported (golint)
    • firefly/pkg/fftypes/organization.go
    • Line 40: warning: exported method Organization.Validate should have comment or be unexported (golint)
    • Line 70: warning: exported method Organization.Topic should have comment or be unexported (golint)
    • Line 74: warning: exported method Organization.SetBroadcastMessage should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/datatype_sql.go
    • Line 48: warning: exported method SQLCommon.UpsertDatatype should have comment or be unexported (golint)
    • Line 154: warning: exported method SQLCommon.GetDatatypeByID should have comment or be unexported (golint)
    • Line 158: warning: exported method SQLCommon.GetDatatypeByName should have comment or be unexported (golint)
    • Line 162: warning: exported method SQLCommon.GetDatatypes should have comment or be unexported (golint)
    • Line 188: warning: exported method SQLCommon.UpdateDatatype should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/event_sql.go
    • Line 46: warning: exported method SQLCommon.UpsertEvent should have comment or be unexported (golint)
    • Line 125: warning: exported method SQLCommon.GetEventByID should have comment or be unexported (golint)
    • Line 152: warning: exported method SQLCommon.GetEvents should have comment or be unexported (golint)
    • Line 180: warning: exported method SQLCommon.UpdateEvent should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/message_sql.go
    • Line 58: warning: exported method SQLCommon.InsertMessageLocal should have comment or be unexported (golint)
    • Line 63: warning: exported method SQLCommon.UpsertMessage should have comment or be unexported (golint)
    • Line 293: warning: exported method SQLCommon.GetMessageByID should have comment or be unexported (golint)
    • Line 351: warning: exported method SQLCommon.GetMessages should have comment or be unexported (golint)
    • Line 361: warning: exported method SQLCommon.GetMessagesForData should have comment or be unexported (golint)
    • Line 377: warning: exported method SQLCommon.GetMessageRefs should have comment or be unexported (golint)
    • Line 399: warning: exported method SQLCommon.UpdateMessage should have comment or be unexported (golint)
    • Line 403: warning: exported method SQLCommon.UpdateMessages should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/subscription_sql.go
    • Line 52: warning: exported method SQLCommon.UpsertSubscription should have comment or be unexported (golint)
    • Line 188: warning: exported method SQLCommon.GetSubscriptionByID should have comment or be unexported (golint)
    • Line 192: warning: exported method SQLCommon.GetSubscriptionByName should have comment or be unexported (golint)
    • Line 196: warning: exported method SQLCommon.GetSubscriptions should have comment or be unexported (golint)
    • Line 222: warning: exported method SQLCommon.UpdateSubscription should have comment or be unexported (golint)
    • Line 247: warning: exported method SQLCommon.DeleteSubscriptionByID should have comment or be unexported (golint)
    • firefly/internal/database/sqlite/sqlite.go
    • Line 36: warning: exported type SQLite should have comment or be unexported (golint)
    • Line 40: warning: exported method SQLite.Init should have comment or be unexported (golint)
    • Line 45: warning: exported method SQLite.Name should have comment or be unexported (golint)
    • Line 49: warning: exported method SQLite.PlaceholderFormat should have comment or be unexported (golint)
    • Line 53: warning: exported method SQLite.UpdateInsertForSequenceReturn should have comment or be unexported (golint)
    • Line 57: warning: exported method SQLite.SequenceField should have comment or be unexported (golint)
    • Line 64: warning: exported method SQLite.Open should have comment or be unexported (golint)
    • Line 68: warning: exported method SQLite.GetMigrationDriver should have comment or be unexported (golint)
    • firefly/internal/blockchain/ethereum/ethereum.go
    • Line 43: warning: exported type Ethereum should have comment or be unexported (golint)
    • Line 103: warning: exported method Ethereum.Name should have comment or be unexported (golint)
    • Line 107: warning: exported method Ethereum.Init should have comment or be unexported (golint)
    • Line 150: warning: exported method Ethereum.Start should have comment or be unexported (golint)
    • Line 154: warning: exported method Ethereum.Capabilities should have comment or be unexported (golint)
    • Line 432: warning: exported method Ethereum.VerifyIdentitySyntax should have comment or be unexported (golint)
    • Line 445: warning: exported method Ethereum.SubmitBatchPin should have comment or be unexported (golint)
    • firefly/pkg/database/query_fields.go
    • Line 69: warning: exported type Field should have comment or be unexported (golint)
    • Line 73: warning: exported type StringField should have comment or be unexported (golint)
    • Line 119: warning: exported type UUIDField should have comment or be unexported (golint)
    • Line 158: warning: exported type Int64Field should have comment or be unexported (golint)
    • Line 189: warning: exported type TimeField should have comment or be unexported (golint)
    • Line 224: warning: exported type JSONField should have comment or be unexported (golint)
    • Line 246: warning: exported type FFNameArrayField should have comment or be unexported (golint)
    • Line 256: warning: exported type BoolField should have comment or be unexported (golint)
    • firefly/pkg/fftypes/uuid.go
    • Line 30: warning: exported function ParseUUID should have comment or be unexported (golint)
    • Line 39: warning: exported function MustParseUUID should have comment or be unexported (golint)
    • Line 44: warning: exported function NewUUID should have comment or be unexported (golint)
    • Line 56: warning: exported method UUID.MarshalText should have comment or be unexported (golint)
    • Line 60: warning: exported method UUID.UnmarshalText should have comment or be unexported (golint)
    • Line 64: warning: exported method UUID.MarshalBinary should have comment or be unexported (golint)
    • Line 68: warning: exported method UUID.UnmarshalBinary should have comment or be unexported (golint)
    • Line 72: warning: exported method UUID.Value should have comment or be unexported (golint)
    • Line 79: warning: exported method UUID.Scan should have comment or be unexported (golint)
    • Line 83: warning: exported method UUID.Equals should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/transaction_sql.go
    • Line 50: warning: exported method SQLCommon.UpsertTransaction should have comment or be unexported (golint)
    • Line 147: warning: exported method SQLCommon.GetTransactionByID should have comment or be unexported (golint)
    • Line 174: warning: exported method SQLCommon.GetTransactions should have comment or be unexported (golint)
    • Line 202: warning: exported method SQLCommon.UpdateTransaction should have comment or be unexported (golint)
    • firefly/internal/database/postgres/postgres.go
    • Line 36: warning: exported type Postgres should have comment or be unexported (golint)
    • Line 40: warning: exported method Postgres.Init should have comment or be unexported (golint)
    • Line 45: warning: exported method Postgres.Name should have comment or be unexported (golint)
    • Line 49: warning: exported method Postgres.PlaceholderFormat should have comment or be unexported (golint)
    • Line 53: warning: exported method Postgres.UpdateInsertForSequenceReturn should have comment or be unexported (golint)
    • Line 57: warning: exported method Postgres.SequenceField should have comment or be unexported (golint)
    • Line 64: warning: exported method Postgres.Open should have comment or be unexported (golint)
    • Line 68: warning: exported method Postgres.GetMigrationDriver should have comment or be unexported (golint)
    • firefly/pkg/events/plugin.go
    • Line 46: warning: exported type SubscriptionMatcher should have comment or be unexported (golint)
    • Line 48: warning: exported type Callbacks should have comment or be unexported (golint)
    • Line 72: warning: exported type Capabilities should have comment or be unexported (golint)
    • firefly/pkg/fftypes/datatype.go
    • Line 25: warning: exported type ValidatorType should have comment or be unexported (golint)
    • Line 47: warning: exported method Datatype.Validate should have comment or be unexported (golint)
    • Line 75: warning: exported method Datatype.Topic should have comment or be unexported (golint)
    • Line 79: warning: exported method Datatype.SetBroadcastMessage should have comment or be unexported (golint)
    • firefly/pkg/fftypes/jsondata.go
    • Line 50: warning: exported method JSONObject.GetString should have comment or be unexported (golint)
    • Line 55: warning: exported method JSONObject.GetStringOk should have comment or be unexported (golint)
    • Line 66: warning: exported method JSONObject.GetObject should have comment or be unexported (golint)
    • Line 71: warning: exported method JSONObject.GetObjectOk should have comment or be unexported (golint)
    • Line 82: warning: exported function ToJSONObjectArray should have comment or be unexported (golint)
    • Line 98: warning: exported function ToStringArray should have comment or be unexported (golint)
    • Line 114: warning: exported method JSONObject.GetObjectArray should have comment or be unexported (golint)
    • Line 119: warning: exported method JSONObject.GetObjectArrayOk should have comment or be unexported (golint)
    • Line 128: warning: exported method JSONObject.GetStringArray should have comment or be unexported (golint)
    • Line 133: warning: exported method JSONObject.GetStringArrayOk should have comment or be unexported (golint)
    • Line 152: warning: exported method JSONObject.Hash should have comment or be unexported (golint)
    • Line 182: warning: exported method JSONObjectArray.Value should have comment or be unexported (golint)
    • Line 191: warning: exported method JSONObjectArray.Hash should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/nonce_sql.go
    • Line 42: warning: exported method SQLCommon.UpsertNonceNext should have comment or be unexported (golint)
    • Line 115: warning: exported method SQLCommon.GetNonce should have comment or be unexported (golint)
    • Line 140: warning: exported method SQLCommon.GetNonces should have comment or be unexported (golint)
    • Line 166: warning: exported method SQLCommon.DeleteNonce should have comment or be unexported (golint)
    • firefly/internal/events/websockets/websockets.go
    • Line 32: warning: exported type WebSockets should have comment or be unexported (golint)
    • Line 41: warning: exported method WebSockets.Name should have comment or be unexported (golint)
    • Line 43: warning: exported method WebSockets.Init should have comment or be unexported (golint)
    • Line 61: warning: exported method WebSockets.Capabilities should have comment or be unexported (golint)
    • Line 65: warning: exported method WebSockets.DeliveryRequest should have comment or be unexported (golint)
    • Line 114: warning: exported method WebSockets.WaitClosed should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/node_sql.go
    • Line 49: warning: exported method SQLCommon.UpsertNode should have comment or be unexported (golint)
    • Line 166: warning: exported method SQLCommon.GetNode should have comment or be unexported (golint)
    • Line 170: warning: exported method SQLCommon.GetNodeByID should have comment or be unexported (golint)
    • Line 174: warning: exported method SQLCommon.GetNodes should have comment or be unexported (golint)
    • Line 200: warning: exported method SQLCommon.UpdateNode should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/offset_sql.go
    • Line 43: warning: exported method SQLCommon.UpsertOffset should have comment or be unexported (golint)
    • Line 126: warning: exported method SQLCommon.GetOffset should have comment or be unexported (golint)
    • Line 153: warning: exported method SQLCommon.GetOffsets should have comment or be unexported (golint)
    • Line 179: warning: exported method SQLCommon.UpdateOffset should have comment or be unexported (golint)
    • Line 201: warning: exported method SQLCommon.DeleteOffset should have comment or be unexported (golint)
    • firefly/internal/blockchain/utdbql/utdbql.go
    • Line 35: warning: exported type UTDBQL should have comment or be unexported (golint)
    • Line 61: warning: exported method UTDBQL.Name should have comment or be unexported (golint)
    • Line 65: warning: exported method UTDBQL.Init should have comment or be unexported (golint)
    • Line 96: warning: exported method UTDBQL.Capabilities should have comment or be unexported (golint)
    • Line 100: warning: exported method UTDBQL.Start should have comment or be unexported (golint)
    • Line 105: warning: exported method UTDBQL.VerifyIdentitySyntax should have comment or be unexported (golint)
    • Line 109: warning: exported method UTDBQL.SubmitBatchPin should have comment or be unexported (golint)
    • Line 183: warning: exported method UTDBQL.Close should have comment or be unexported (golint)
    • firefly/pkg/fftypes/node.go
    • Line 42: warning: exported method Node.Validate should have comment or be unexported (golint)
    • Line 60: warning: exported method Node.Topic should have comment or be unexported (golint)
    • Line 64: warning: exported method Node.SetBroadcastMessage should have comment or be unexported (golint)
    • firefly/pkg/fftypes/data.go
    • Line 28: warning: exported type DataRef should have comment or be unexported (golint)
    • Line 33: warning: exported type Data should have comment or be unexported (golint)
    • Line 44: warning: exported type DatatypeRef should have comment or be unexported (golint)
    • Line 56: warning: exported type DataRefs should have comment or be unexported (golint)
    • Line 58: warning: exported method DataRefs.Hash should have comment or be unexported (golint)
    • Line 64: warning: exported method Data.Seal should have comment or be unexported (golint)
    • firefly/pkg/fftypes/message.go
    • Line 111: warning: exported method MessageHeader.Hash should have comment or be unexported (golint)
    • Line 117: warning: exported method Message.Seal should have comment or be unexported (golint)
    • Line 139: warning: exported method Message.DupDataCheck should have comment or be unexported (golint)
    • Line 154: warning: exported method Message.Verify should have comment or be unexported (golint)
    • Line 178: warning: exported method Message.LocalSequence should have comment or be unexported (golint)
    • firefly/pkg/fftypes/batch.go
    • Line 28: warning: exported type Batch should have comment or be unexported (golint)
    • Line 41: warning: exported type BatchPayload should have comment or be unexported (golint)
    • Line 52: warning: exported method BatchPayload.Hash should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/batch_sql.go
    • Line 54: warning: exported method SQLCommon.UpsertBatch should have comment or be unexported (golint)
    • Line 155: warning: exported method SQLCommon.GetBatchByID should have comment or be unexported (golint)
    • Line 180: warning: exported method SQLCommon.GetBatches should have comment or be unexported (golint)
    • Line 206: warning: exported method SQLCommon.UpdateBatch should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/namespace_sql.go
    • Line 45: warning: exported method SQLCommon.UpsertNamespace should have comment or be unexported (golint)
    • Line 133: warning: exported method SQLCommon.GetNamespace should have comment or be unexported (golint)
    • Line 158: warning: exported method SQLCommon.GetNamespaces should have comment or be unexported (golint)
    • Line 184: warning: exported method SQLCommon.UpdateNamespace should have comment or be unexported (golint)
    • Line 206: warning: exported method SQLCommon.DeleteNamespace should have comment or be unexported (golint)
    • firefly/internal/database/sqlcommon/sqlcommon.go
    • Line 35: warning: exported type SQLCommon should have comment or be unexported (golint)
    • Line 49: warning: exported method SQLCommon.Init should have comment or be unexported (golint)
    • Line 71: warning: exported method SQLCommon.Capabilities should have comment or be unexported (golint)
    • Line 73: warning: exported method SQLCommon.RunAsGroup should have comment or be unexported (golint)
    • Line 284: warning: exported method SQLCommon.DB should have comment or be unexported (golint)
    • Line 288: warning: exported method SQLCommon.Close should have comment or be unexported (golint)
    • firefly/internal/log/log.go
    • Line 60: warning: exported function SetLevel should have comment or be unexported (golint)
    • Line 73: warning: exported type Formatting should have comment or be unexported (golint)
    • Line 89: warning: exported function SetFormatting should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign89%

IneffAssign detects ineffectual assignments in Go code.

    • firefly/internal/events/aggregator_test.go
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/broadcastmocks; to add it: (ineffassign)
    • Line 27: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 28: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/datamocks; to add it: (ineffassign)
    • Line 29: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/privatemessagingmocks; to add it: (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/broadcastmocks (invalid package name: "") (ineffassign)
    • Line 27: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • Line 28: warning: could not import github.com/hyperledger-labs/firefly/mocks/datamocks (invalid package name: "") (ineffassign)
    • Line 29: warning: could not import github.com/hyperledger-labs/firefly/mocks/privatemessagingmocks (invalid package name: "") (ineffassign)
    • firefly/internal/events/dx_callbacks_test.go
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • firefly/internal/broadcast/datatype_test.go
    • Line 24: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/datamocks; to add it: (ineffassign)
    • Line 24: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/datamocks (invalid package name: "") (ineffassign)
    • firefly/internal/networkmap/manager_test.go
    • Line 24: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/broadcastmocks; to add it: (ineffassign)
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 27: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/identitymocks; to add it: (ineffassign)
    • Line 24: warning: could not import github.com/hyperledger-labs/firefly/mocks/broadcastmocks (invalid package name: "") (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • Line 27: warning: could not import github.com/hyperledger-labs/firefly/mocks/identitymocks (invalid package name: "") (ineffassign)
    • firefly/internal/orchestrator/bound_callbacks_test.go
    • Line 23: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/blockchainmocks; to add it: (ineffassign)
    • Line 24: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/eventmocks; to add it: (ineffassign)
    • Line 23: warning: could not import github.com/hyperledger-labs/firefly/mocks/blockchainmocks (invalid package name: "") (ineffassign)
    • Line 24: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/eventmocks (invalid package name: "") (ineffassign)
    • firefly/internal/data/blobstore_test.go
    • Line 29: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 30: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 29: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • Line 30: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • firefly/internal/batch/batch_manager_test.go
    • Line 27: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 28: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/datamocks; to add it: (ineffassign)
    • Line 27: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • Line 28: warning: could not import github.com/hyperledger-labs/firefly/mocks/datamocks (invalid package name: "") (ineffassign)
    • firefly/internal/identity/onchain/onchain_test.go
    • Line 24: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/identitymocks; to add it: (ineffassign)
    • Line 24: warning: could not import github.com/hyperledger-labs/firefly/mocks/identitymocks (invalid package name: "") (ineffassign)
    • firefly/internal/events/event_dispatcher_test.go
    • Line 28: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/eventsmocks; to add it: (ineffassign)
    • Line 28: warning: could not import github.com/hyperledger-labs/firefly/mocks/eventsmocks (invalid package name: "") (ineffassign)
    • firefly/internal/database/sqlite/sqlite_test.go
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • firefly/cmd/firefly_test.go
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/orchestratormocks; to add it: (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/orchestratormocks (invalid package name: "") (ineffassign)
    • firefly/internal/publicstorage/ipfs/ipfs_test.go
    • Line 30: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/publicstoragemocks; to add it: (ineffassign)
    • Line 30: warning: could not import github.com/hyperledger-labs/firefly/mocks/publicstoragemocks (invalid package name: "") (ineffassign)
    • firefly/internal/privatemessaging/groupmanager_test.go
    • Line 24: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/datamocks; to add it: (ineffassign)
    • Line 24: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/datamocks (invalid package name: "") (ineffassign)
    • firefly/internal/dataexchange/dxhttps/dxhttps_test.go
    • Line 31: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 32: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/wsmocks; to add it: (ineffassign)
    • Line 31: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • Line 32: warning: could not import github.com/hyperledger-labs/firefly/mocks/wsmocks (invalid package name: "") (ineffassign)
    • firefly/internal/database/ql/ql_test.go
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • firefly/internal/blockchain/utdbql/utdbql_test.go
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/blockchainmocks; to add it: (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/blockchainmocks (invalid package name: "") (ineffassign)
    • firefly/internal/privatemessaging/message_test.go
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/identitymocks; to add it: (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/identitymocks (invalid package name: "") (ineffassign)
    • firefly/internal/broadcast/manager_test.go
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/batchmocks; to add it: (ineffassign)
    • Line 28: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 31: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/publicstoragemocks; to add it: (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/batchmocks (invalid package name: "") (ineffassign)
    • Line 28: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • Line 31: warning: could not import github.com/hyperledger-labs/firefly/mocks/publicstoragemocks (invalid package name: "") (ineffassign)
    • firefly/internal/orchestrator/orchestrator_test.go
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/batchmocks; to add it: (ineffassign)
    • Line 27: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/broadcastmocks; to add it: (ineffassign)
    • Line 28: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 30: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/datamocks; to add it: (ineffassign)
    • Line 32: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/identitymocks; to add it: (ineffassign)
    • Line 33: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/networkmapmocks; to add it: (ineffassign)
    • Line 34: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/privatemessagingmocks; to add it: (ineffassign)
    • Line 35: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/publicstoragemocks; to add it: (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/batchmocks (invalid package name: "") (ineffassign)
    • Line 27: warning: could not import github.com/hyperledger-labs/firefly/mocks/broadcastmocks (invalid package name: "") (ineffassign)
    • Line 28: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • Line 30: warning: could not import github.com/hyperledger-labs/firefly/mocks/datamocks (invalid package name: "") (ineffassign)
    • Line 32: warning: could not import github.com/hyperledger-labs/firefly/mocks/identitymocks (invalid package name: "") (ineffassign)
    • Line 33: warning: could not import github.com/hyperledger-labs/firefly/mocks/networkmapmocks (invalid package name: "") (ineffassign)
    • Line 34: warning: could not import github.com/hyperledger-labs/firefly/mocks/privatemessagingmocks (invalid package name: "") (ineffassign)
    • Line 35: warning: could not import github.com/hyperledger-labs/firefly/mocks/publicstoragemocks (invalid package name: "") (ineffassign)
    • firefly/internal/privatemessaging/privatemessaging_test.go
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/batchmocks; to add it: (ineffassign)
    • Line 26: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/blockchainmocks; to add it: (ineffassign)
    • Line 28: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/dataexchangemocks; to add it: (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/batchmocks (invalid package name: "") (ineffassign)
    • Line 26: warning: could not import github.com/hyperledger-labs/firefly/mocks/blockchainmocks (invalid package name: "") (ineffassign)
    • Line 28: warning: could not import github.com/hyperledger-labs/firefly/mocks/dataexchangemocks (invalid package name: "") (ineffassign)
    • firefly/internal/networkmap/data_query_test.go
    • Line 22: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/databasemocks; to add it: (ineffassign)
    • Line 22: warning: could not import github.com/hyperledger-labs/firefly/mocks/databasemocks (invalid package name: "") (ineffassign)
    • firefly/internal/events/batch_pin_complete_test.go
    • Line 27: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/blockchainmocks; to add it: (ineffassign)
    • Line 29: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/identitymocks; to add it: (ineffassign)
    • Line 30: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/publicstoragemocks; to add it: (ineffassign)
    • Line 27: warning: could not import github.com/hyperledger-labs/firefly/mocks/blockchainmocks (invalid package name: "") (ineffassign)
    • Line 29: warning: could not import github.com/hyperledger-labs/firefly/mocks/identitymocks (invalid package name: "") (ineffassign)
    • Line 30: warning: could not import github.com/hyperledger-labs/firefly/mocks/publicstoragemocks (invalid package name: "") (ineffassign)
    • firefly/internal/broadcast/definition_test.go
    • Line 24: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/blockchainmocks; to add it: (ineffassign)
    • Line 25: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/identitymocks; to add it: (ineffassign)
    • Line 24: warning: could not import github.com/hyperledger-labs/firefly/mocks/blockchainmocks (invalid package name: "") (ineffassign)
    • Line 25: warning: could not import github.com/hyperledger-labs/firefly/mocks/identitymocks (invalid package name: "") (ineffassign)
    • firefly/internal/blockchain/ethereum/ethereum_test.go
    • Line 32: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/blockchainmocks; to add it: (ineffassign)
    • Line 33: warning: no required module provides package github.com/hyperledger-labs/firefly/mocks/wsmocks; to add it: (ineffassign)
    • Line 32: warning: could not import github.com/hyperledger-labs/firefly/mocks/blockchainmocks (invalid package name: "") (ineffassign)
    • Line 33: warning: could not import github.com/hyperledger-labs/firefly/mocks/wsmocks (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!