Preparing report...

Report for github.com/ianeinser/bca-api-go

A+    Excellent!    Found 8 issues across 13 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint38%

Golint is a linter for Go source code.

    • bca-api-go/fire/client.go
    • Line 33: warning: comment on exported method Client.TeleTransferToAccount should be of the form "TeleTransferToAccount ..." (golint)
    • Line 34: warning: don't use underscores in Go names; method parameter ptr_ttAccountRequest should be ptrTtAccountRequest (golint)
    • Line 52: warning: don't use underscores in Go names; method parameter ptr_ttInquiryAccountRequest should be ptrTtInquiryAccountRequest (golint)
    • Line 70: warning: don't use underscores in Go names; method parameter ptr_inquiryAccountBalanceRequest should be ptrInquiryAccountBalanceRequest (golint)
    • Line 87: warning: comment on exported method Client.InquiryTransaction should be of the form "InquiryTransaction ..." (golint)
    • Line 88: warning: don't use underscores in Go names; method parameter ptr_inquiryTransactionRequest should be ptrInquiryTransactionRequest (golint)
    • Line 105: warning: comment on exported method Client.TeleTransferCashTransfer should be of the form "TeleTransferCashTransfer ..." (golint)
    • Line 106: warning: don't use underscores in Go names; method parameter ptr_ttCashTransferRequest should be ptrTtCashTransferRequest (golint)
    • Line 123: warning: comment on exported method Client.TeleTransferAmendCashTransfer should be of the form "TeleTransferAmendCashTransfer ..." (golint)
    • Line 124: warning: don't use underscores in Go names; method parameter ptr_ttAmendCashTransferRequest should be ptrTtAmendCashTransferRequest (golint)
    • Line 141: warning: comment on exported method Client.TeleTransferCancelCashTransfer should be of the form "TeleTransferCancelCashTransfer ..." (golint)
    • Line 142: warning: don't use underscores in Go names; method parameter ptr_ttCancelCashTransferRequest should be ptrTtCancelCashTransferRequest (golint)
    • bca-api-go/va/client.go
    • Line 26: warning: don't use underscores in Go names; method parameter ptr_vaInquiryStatusPaymentRequest should be ptrVaInquiryStatusPaymentRequest (golint)
    • bca-api-go/business/client.go
    • Line 37: warning: don't use underscores in Go names; method parameter ptr_balanceInformationRequest should be ptrBalanceInformationRequest (golint)
    • Line 48: warning: don't use underscores in Go names; method parameter ptr_accountStatementRequest should be ptrAccountStatementRequest (golint)
    • Line 67: warning: don't use underscores in Go names; method parameter ptr_fundTransferRequest should be ptrFundTransferRequest (golint)
    • Line 84: warning: don't use underscores in Go names; method parameter ptr_domesticFundTransferRequest should be ptrDomesticFundTransferRequest (golint)
    • Line 106: warning: don't use underscores in Go names; method parameter ptr_accountStatementOfflineRequest should be ptrAccountStatementOfflineRequest (golint)
    • Line 130: warning: don't use underscores in Go names; method parameter ptr_inquiryTransferStatusRequest should be ptrInquiryTransferStatusRequest (golint)
    • Line 153: warning: don't use underscores in Go names; method parameter ptr_inquiryDomesticAccountRequest should be ptrInquiryDomesticAccountRequest (golint)
    • bca-api-go/business.go
    • Line 11: warning: comment on exported type BalanceSuccessBalanceInformationResponse should be of the form "BalanceSuccessBalanceInformationResponse ..." (with optional leading article) (golint)
    • Line 24: warning: comment on exported type BalanceFailedBalanceInformationResponse should be of the form "BalanceFailedBalanceInformationResponse ..." (with optional leading article) (golint)
    • bca-api-go/fire.go
    • Line 52: warning: comment on exported type TransactionAccountRequest should be of the form "TransactionAccountRequest ..." (with optional leading article) (golint)
    • Line 72: warning: comment on exported type BeneficiaryAccountResponse should be of the form "BeneficiaryAccountResponse ..." (with optional leading article) (golint)
    • Line 79: warning: comment on exported type TransactionAccountResponse should be of the form "TransactionAccountResponse ..." (with optional leading article) (golint)
    • Line 92: warning: comment on exported type TeleTransferAccountResponse should be of the form "TeleTransferAccountResponse ..." (with optional leading article) (golint)
    • Line 127: warning: comment on exported type FIInquiryAccountBalanceRequest should be of the form "FIInquiryAccountBalanceRequest ..." (with optional leading article) (golint)
    • Line 144: warning: comment on exported type InquiryAccountBalanceResponse should be of the form "InquiryAccountBalanceResponse ..." (with optional leading article) (golint)
    • Line 152: warning: comment on exported type TransactionInquiryTransactionRequest should be of the form "TransactionInquiryTransactionRequest ..." (with optional leading article) (golint)
    • Line 178: warning: comment on exported type TransactionTTInquiryTransactionResponse should be of the form "TransactionTTInquiryTransactionResponse ..." (with optional leading article) (golint)
    • Line 274: warning: comment on exported type TeleTransferCashTransferResponse should be of the form "TeleTransferCashTransferResponse ..." (with optional leading article) (golint)
    • Line 299: warning: comment on exported type BeneficiaryTeleTransferAmendCashTransfer should be of the form "BeneficiaryTeleTransferAmendCashTransfer ..." (with optional leading article) (golint)
    • Line 331: warning: comment on exported type Transaction2TTAmendCashTransfer should be of the form "Transaction2TTAmendCashTransfer ..." (with optional leading article) (golint)
    • Line 361: warning: comment on exported type TransactionTeleTransferCancelCashTransferRequest should be of the form "TransactionTeleTransferCancelCashTransferRequest ..." (with optional leading article) (golint)
    • Line 368: warning: comment on exported type TeleTransferCancelCashTransferRequest should be of the form "TeleTransferCancelCashTransferRequest ..." (with optional leading article) (golint)
    • Line 374: warning: comment on exported type TransactionTeleTransferCancelCashTransferResponse should be of the form "TransactionTeleTransferCancelCashTransferResponse ..." (with optional leading article) (golint)
    • Line 380: warning: comment on exported type TeleTransferCancelCashTransferResponse should be of the form "TeleTransferCancelCashTransferResponse ..." (with optional leading article) (golint)
    • bca-api-go/general.go
    • Line 3: warning: exported type ForeignExchangeRateRequest should have comment or be unexported (golint)
    • Line 8: warning: exported type RateDetails should have comment or be unexported (golint)
    • Line 15: warning: exported type Currency should have comment or be unexported (golint)
    • Line 20: warning: exported type ForeignExchangeRateResponse should have comment or be unexported (golint)
    • bca-api-go/va.go
    • Line 27: warning: comment on exported type InquiryStatusPaymentResponse should be of the form "InquiryStatusPaymentResponse ..." (with optional leading article) (golint)
    • bca-api-go/general/client.go
    • Line 25: warning: comment on exported method Client.ForeignExchangeRate should be of the form "ForeignExchangeRate ..." (golint)
    • Line 26: warning: don't use underscores in Go names; method parameter ptr_foreignExchangeRate should be ptrForeignExchangeRate (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!