gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• kedge/pkg/kedge/grpc/integration_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kedge/pkg/kedge/http/director/router/router_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• kedge/pkg/kedge/http/integration_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• kedge/cmd/kedge/main.go
  • Line 85: warning: cyclomatic complexity 27 of function main() is high (> 15) (gocyclo)

• kedge/cmd/winch/main.go
  • Line 94: warning: cyclomatic complexity 18 of function main() is high (> 15) (gocyclo)

• kedge/pkg/resolvers/k8s/watcher.go
  • Line 153: warning: cyclomatic complexity 20 of function (*watcher).next() is high (> 15) (gocyclo)

golint51%

Golint is a linter for Go source code.

• kedge/pkg/kedge/grpc/backendpool/backend.go
  • Line 28: warning: exported var ParentDialFunc should have comment or be unexported (golint)
  • Line 160: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• kedge/pkg/kedge/http/director/router/router.go
  • Line 18: warning: exported var ErrRouteNotFound should have comment or be unexported (golint)
  • Line 21: warning: exported type Router should have comment or be unexported (golint)
  • Line 56: warning: exported function NewStatic should have comment or be unexported (golint)

• kedge/pkg/kedge/grpc/integration_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/kedge/grpc/director/router/router.go
  • Line 20: warning: exported var ErrRouteNotFound should have comment or be unexported (golint)
  • Line 60: warning: exported function NewStatic should have comment or be unexported (golint)

• kedge/pkg/kedge/grpc/backendpool/pool.go
  • Line 9: warning: exported var ErrUnknownBackend should have comment or be unexported (golint)
  • Line 12: warning: exported type Pool should have comment or be unexported (golint)

• kedge/pkg/map/simple.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/http/tripperware/route.go
  • Line 45: warning: exported function WrapForRouting should have comment or be unexported (golint)

• kedge/pkg/tls/client.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/logstash/conn.go
  • Line 23: warning: exported function NewReconnectingWriter should have comment or be unexported (golint)

• kedge/cmd/kedge/version.go
  • Line 8: warning: comment on exported var BuildVersion should be of the form "BuildVersion ..." (golint)

• kedge/pkg/kedge/grpc/client/client.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/metrics/kedge_error.go
  • Line 6: warning: exported var KedgeProxyErrors should have comment or be unexported (golint)

• kedge/pkg/e2e/spinup_test.go
  • Line 53: warning: context.Context should be the first parameter of a function (golint)

• kedge/pkg/http/tripperware/map.go
  • Line 32: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 57: warning: exported function WrapForMapping should have comment or be unexported (golint)

• kedge/pkg/resolvers/k8s/watcher.go
  • Line 28: warning: error var staleStreamError should have name of the form errFoo (golint)

• kedge/cmd/winch/version.go
  • Line 8: warning: comment on exported var BuildVersion should be of the form "BuildVersion ..." (golint)

• kedge/pkg/resolvers/host/host.go
  • Line 18: warning: exported var ParentHostResolver should have comment or be unexported (golint)

• kedge/pkg/resolvers/k8s/resolver.go
  • Line 56: warning: exported function NewFromFlags should have comment or be unexported (golint)

• kedge/pkg/winch/grpc/proxy.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/logstash/logstash_formatter.go
  • Line 25: warning: exported var TimestampFormat should have comment or be unexported (golint)
  • Line 30: warning: exported function NewFormatter should have comment or be unexported (golint)

• kedge/pkg/winch/http/integration_test.go
  • Line 2: warning: don't use an underscore in package name (golint)

• kedge/pkg/kedge/http/director/adhoc/adhoc.go
  • Line 18: warning: exported function NewStaticAddresser should have comment or be unexported (golint)

• kedge/pkg/map/iface.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 17: warning: exported type Route should have comment or be unexported (golint)
  • Line 29: warning: comment on exported type ErrorNotKedgeDestination should be of the form "ErrorNotKedgeDestination ..." (with optional leading article) (golint)
  • Line 36: warning: exported function NotKedgeDestinationErr should have comment or be unexported (golint)
  • Line 48: warning: exported function IsNotKedgeDestinationError should have comment or be unexported (golint)

• kedge/pkg/kedge/http/backendpool/backend.go
  • Line 28: warning: comment on exported var ParentDialFunc should be of the form "ParentDialFunc ..." (golint)
  • Line 180: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• kedge/pkg/winch/auth.go
  • Line 24: warning: exported var NoAuth should have comment or be unexported (golint)
  • Line 29: warning: exported type AuthFactory should have comment or be unexported (golint)
  • Line 35: warning: exported function NewAuthFactory should have comment or be unexported (golint)
  • Line 43: warning: exported method AuthFactory.Get should have comment or be unexported (golint)

• kedge/pkg/reporter/reporter.go
  • Line 47: warning: exported method Tracker.ErrType should have comment or be unexported (golint)
  • Line 67: warning: comment on exported function Extract should be of the form "Extract ..." (golint)

• kedge/pkg/kedge/http/lbtransport/policy.go
  • Line 21: warning: exported type LBPolicy should have comment or be unexported (golint)
  • Line 56: warning: exported function RoundRobinPolicyFromFlags should have comment or be unexported (golint)
  • Line 60: warning: exported function RoundRobinPolicy should have comment or be unexported (golint)

• kedge/pkg/kedge/http/director/proxyreq/request.go
  • Line 9: warning: exported type ProxyMode should have comment or be unexported (golint)
  • Line 12: warning: exported const MODE_FORWARD_PROXY should have comment (or a comment on this block) or be unexported (golint)
  • Line 23: warning: should not use basic type string as key in context.WithValue (golint)
  • Line 34: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
  • Line 39: warning: exported function GetProxyMode should have comment or be unexported (golint)

• kedge/pkg/discovery/discovery.go
  • Line 36: warning: error var staleStreamError should have name of the form errFoo (golint)

• kedge/pkg/map/route_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/kedge/http/backendpool/pool.go
  • Line 11: warning: exported var ErrUnknownBackend should have comment or be unexported (golint)
  • Line 14: warning: exported type Pool should have comment or be unexported (golint)

• kedge/pkg/tokenauth/http/tripper.go
  • Line 11: warning: exported type Tripper should have comment or be unexported (golint)

• kedge/pkg/kedge/common/common.go
  • Line 52: warning: exported function ExtractHostPort should have comment or be unexported (golint)
  • Line 67: warning: exported function HostMatches should have comment or be unexported (golint)
  • Line 77: warning: exported function PortAllowed should have comment or be unexported (golint)
  • Line 92: warning: exported function AdhocResolveHost should have comment or be unexported (golint)

• kedge/pkg/map/suffix.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/kedge/http/director/router/error.go
  • Line 3: warning: exported type Error should have comment or be unexported (golint)
  • Line 8: warning: exported function NewError should have comment or be unexported (golint)
  • Line 16: warning: exported method Error.StatusCode should have comment or be unexported (golint)

• kedge/pkg/resolvers/srv/srv.go
  • Line 17: warning: exported var ParentSrvResolver should have comment or be unexported (golint)

• kedge/pkg/winch/routes.go
  • Line 15: warning: exported type StaticRoutes should have comment or be unexported (golint)
  • Line 20: warning: exported function NewStaticRoutes should have comment or be unexported (golint)
  • Line 75: warning: exported method StaticRoutes.HTTP should have comment or be unexported (golint)
  • Line 79: warning: exported method StaticRoutes.GRPC should have comment or be unexported (golint)

• kedge/pkg/grpcutils/metadata.go
  • Line 9: warning: exported function CloneIncomingToOutgoingMD should have comment or be unexported (golint)

• kedge/pkg/map/route.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 10: warning: exported type RouteGetter should have comment or be unexported (golint)

• kedge/pkg/logstash/logstash.go
  • Line 32: warning: comment on exported function NewHook should be of the form "NewHook ..." (golint)

• kedge/pkg/kedge/http/integration_test.go
  • Line 14: warning: don't use an underscore in package name (golint)

• kedge/pkg/winch/pac.go
  • Line 25: warning: exported function NewPacFromFlags should have comment or be unexported (golint)

• kedge/pkg/http/tripperware/auth.go
  • Line 16: warning: exported const ProxyAuthHeader should have comment (or a comment on this block) or be unexported (golint)
  • Line 62: warning: exported function WrapForProxyAuth should have comment or be unexported (golint)
  • Line 74: warning: exported function WrapForBackendAuth should have comment or be unexported (golint)

• kedge/pkg/kedge/http/director/proxy.go
  • Line 33: warning: exported var AdhocTransport should have comment or be unexported (golint)
  • Line 180: warning: exported function AuthMiddleware should have comment or be unexported (golint)

• kedge/pkg/map/single.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/logstash/reporter.go
  • Line 43: warning: exported const BufferFull should have comment (or a comment on this block) or be unexported (golint)

• kedge/pkg/winch/grpc/integration_test.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/winch/http/proxy.go
  • Line 1: warning: don't use an underscore in package name (golint)
  • Line 37: warning: exported function New should have comment or be unexported (golint)

• kedge/pkg/k8s/client.go
  • Line 11: warning: exported type APIClient should have comment or be unexported (golint)

• kedge/pkg/http/tripperware/tripperware.go
  • Line 15: warning: exported function Default should have comment or be unexported (golint)
  • Line 34: warning: exported function DefaultWithTransport should have comment or be unexported (golint)

• kedge/pkg/kedge/http/integration.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/http/header/response.go
  • Line 7: warning: comment on exported const ResponseKedgeErrorType should be of the form "ResponseKedgeErrorType ..." (golint)

• kedge/pkg/kedge/grpc/director/adhoc/adhoc.go
  • Line 18: warning: exported function NewStaticAddresser should have comment or be unexported (golint)

• kedge/pkg/kedge/http/client/client.go
  • Line 1: warning: don't use an underscore in package name (golint)

• kedge/pkg/metrics/backend_configuration.go
  • Line 6: warning: exported const ConfiguationActionCreate should have comment (or a comment on this block) or be unexported (golint)
  • Line 12: warning: exported var BackendHTTPConfigurationCounter should have comment or be unexported (golint)

• kedge/pkg/reporter/errtypes/errtypes.go
  • Line 3: warning: exported type Type should have comment or be unexported (golint)
  • Line 6: warning: exported const OK should have comment (or a comment on this block) or be unexported (golint)
  • Line 34: warning: comment on exported const TransportUnknownError should be of the form "TransportUnknownError ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• kedge/pkg/http/tripperware/auth.go
  • Line 41: warning: ineffectual assignment to ok (ineffassign)

• kedge/pkg/winch/auth.go
  • Line 90: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• kedge/pkg/http/header/response.go
  • Line 7: warning: "respone" is a misspelling of "response" (misspell)
  • Line 13: warning: "respone" is a misspelling of "response" (misspell)

• kedge/pkg/reporter/reporter.go
  • Line 21: warning: "succesfully" is a misspelling of "successfully" (misspell)

• kedge/pkg/logstash/logstash.go
  • Line 16: warning: "successfull" is a misspelling of "successful" (misspell)